Ragnor Comerford bf7d716d1b forbidden_apis: add .restore( and document why .append( / .delete( are excluded ... Cubic flagged that the guard misses `ds.append() / ds.delete() / ds.restore()`. `.restore(` is added — Lance-specific (no false positives in the workspace). `.append(` and `.delete(` stay excluded with a documenting comment: * `.append(` over-matches `Vec::append`, `String::append`, every `arrow_array::xxxArrayBuilder::append` (30+ legit uses across `exec/mutation.rs`, `loader/jsonl.rs`, `exec/projection.rs`). * `.delete(` over-matches `ObjectStore::delete` (used in `storage.rs`, `db/schema_state.rs`, `db/omnigraph.rs:1277` for staging-file cleanup) and would require many `// forbidden-api-allow:` sentinels for legitimate uses. The remaining bypass route — engine code that imports `lance::Dataset` and calls `ds.append(reader, params)` — is bounded by: 1. The trait surface itself (sealed, only-callable-via-trait once Phase 1b call-site conversion completes). 2. The PR-review process catching new `lance::Dataset` imports in non-storage files. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>		2026-05-02 19:25:52 +02:00
..
omnigraph	forbidden_apis: add .restore( and document why .append( / .delete( are excluded	2026-05-02 19:25:52 +02:00
omnigraph-cli	chore: scrub Linear ticket numbers and review-bot mentions from code comments	2026-05-01 22:45:38 +02:00
omnigraph-compiler	Parallel per-type load writes + omnigraph optimize/cleanup CLI (#46)	2026-04-25 14:22:14 +03:00
omnigraph-server	chore: scrub Linear ticket numbers and review-bot mentions from code comments	2026-05-01 22:45:38 +02:00