mirror of
https://github.com/ModernRelay/omnigraph.git
synced 2026-06-15 01:55:13 +02:00
1e70028293
Two new tests in tests/staged_writes.rs that the recovery sweep design depends on: - lance_restore_appends_one_commit_with_checked_out_content — verifies Dataset::restore() (no-args; restores currently-checked-out version) produces HEAD+1, not HEAD+2 as the v1 design assumed. Source confirmed at lance-4.0.0/src/dataset.rs:1106; this test prevents a future lance bump from silently breaking the recovery rollback math. - lance_restore_loses_to_concurrent_append_via_orphaning — pins the concurrency hazard motivating MR-847's open-time-only invocation strategy: check_restore_txn (lance-4.0.0/src/io/commit/conflict_ resolver.rs:986) returns Ok against Append/Update/Delete/CreateIndex/ Merge/etc., so a Restore commits successfully even when a concurrent legitimate writer just landed an Append — silently orphaning the Append's data from the active timeline. MR-847 sidesteps via running recovery only at Omnigraph::open (before any other writers race); MR-856 (continuous-recovery reconciler) must guard via per-(table, branch) queue acquisition once MR-686 lands. These two tests together pin the foundation for MR-847's correctness claims and document the load-bearing constraint MR-856 will inherit. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| omnigraph | ||
| omnigraph-cli | ||
| omnigraph-compiler | ||
| omnigraph-server | ||