apunkt/omnigraph
1
0
Fork 0
mirror of https://github.com/ModernRelay/omnigraph.git synced 2026-06-09 01:35:18 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix: propagate edge-lookup errors from iterative traversal loop

Browse source 
The retain-based loop swallowed catalog.lookup_edge_by_name errors by
keeping the traversal for the next pass, where it could never succeed.
This caused the no-progress break to fire, silently dropping the
traversal and producing incorrect query results with missing joins.

Replaced retain with a manual for-loop that propagates errors via ?.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Ragnor Comerford 2026-04-13 13:40:22 +02:00
parent 88384476be
commit fabd65b08a
No known key found for this signature in database
1 changed files with 16 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

31
crates/omnigraph-compiler/src/ir/lower.rs
View file

@ -243,19 +243,23 @@ fn lower_clauses(
// until all traversals are consumed.
let mut remaining: Vec<&Traversal> = traversals.to_vec();
while !remaining.is_empty() {
let before = remaining.len();
remaining.retain(|traversal| {
let mut next_remaining = Vec::new();
for traversal in &remaining {
let src_bound = bound_vars.contains(&traversal.src);
let dst_bound = bound_vars.contains(&traversal.dst);
if !src_bound && !dst_bound {
return true; // keep for next pass
next_remaining.push(*traversal);
continue;
}
// This traversal can be processed — emit the appropriate ops.
// (errors inside retain are not ergonomic, so we rely on the
// type-checker having validated edge names already.)
let Some(edge) = catalog.lookup_edge_by_name(&traversal.edge_name) else {
return true; // keep; will error on next pass or after loop
};
let edge = catalog
.lookup_edge_by_name(&traversal.edge_name)
.ok_or_else(|| {
crate::error::NanoError::Plan(format!(
"lowering traversal referenced missing edge '{}' after typecheck",
traversal.edge_name
))
})?;
let direction = type_ctx
.traversals
@ -340,14 +344,11 @@ fn lower_clauses(
bound_vars.insert(traversal.dst.clone());
}
}
false // processed — remove from remaining
});
if remaining.len() == before {
// No progress — remaining traversals reference no bound variables.
// Fall through; the traversals will be skipped (this would be a
// type-check error in practice).
}
if next_remaining.len() == remaining.len() {
break;
}
remaining = next_remaining;
}
// Lower explicit filters