From 972a6e047b5a57865e63cf07d11a748daf98262b Mon Sep 17 00:00:00 2001 From: Ragnor Comerford Date: Thu, 28 May 2026 11:20:51 +0200 Subject: [PATCH 1/2] chore(codeowners): add ragnorc as engineering owner --- .github/CODEOWNERS | 4 ++-- .github/codeowners-roles.yml | 3 ++- docs/dev/codeowners.md | 2 +- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 34dd9c6..ce8510c 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -8,9 +8,9 @@ # CI fails if this file drifts from its source, and rejects PRs that # edit this file directly without also editing the yml. -* @aaltshuler +* @aaltshuler @ragnorc -crates/** @aaltshuler +crates/** @aaltshuler @ragnorc docs/** @aaltshuler @ragnorc README.md @aaltshuler @ragnorc AGENTS.md @aaltshuler @ragnorc diff --git a/.github/codeowners-roles.yml b/.github/codeowners-roles.yml index 9fdc8e5..f542b84 100644 --- a/.github/codeowners-roles.yml +++ b/.github/codeowners-roles.yml @@ -19,9 +19,10 @@ roles: engineering: description: > All production code under crates/**. Engine, CLI, server, - compiler. Single owner; review must come from this person. + compiler. Either named member can approve. members: - aaltshuler + - ragnorc docs: description: > diff --git a/docs/dev/codeowners.md b/docs/dev/codeowners.md index edd355d..160f9f4 100644 --- a/docs/dev/codeowners.md +++ b/docs/dev/codeowners.md @@ -8,7 +8,7 @@ This setup gives every role change a reviewable PR and a permanent in-repository | Role | Members | Scope | |---|---|---| -| `engineering` | `@aaltshuler` | All code under `crates/**`, repository infrastructure, default for unmapped paths | +| `engineering` | `@aaltshuler`, `@ragnorc` | All code under `crates/**`, repository infrastructure, default for unmapped paths | | `docs` | `@aaltshuler`, `@ragnorc` | `docs/**`, README.md, AGENTS.md, CLAUDE.md, SECURITY.md | GitHub treats multiple owners in a CODEOWNERS line as **"any one of them satisfies the review requirement"**. For docs, either named member can approve. To require N distinct approvers on a specific path, layer a CI check on top (not currently configured). From fd41f798b7d4559a58e2b93fc693c2ba45af0d53 Mon Sep 17 00:00:00 2001 From: Ragnor Comerford Date: Thu, 28 May 2026 11:41:38 +0200 Subject: [PATCH 2/2] chore(codeowners): remove aaltshuler as owner --- .github/CODEOWNERS | 14 +++++++------- .github/codeowners-roles.yml | 8 ++------ docs/dev/codeowners.md | 6 +++--- 3 files changed, 12 insertions(+), 16 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index ce8510c..d4ecfa5 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -8,11 +8,11 @@ # CI fails if this file drifts from its source, and rejects PRs that # edit this file directly without also editing the yml. -* @aaltshuler @ragnorc +* @ragnorc -crates/** @aaltshuler @ragnorc -docs/** @aaltshuler @ragnorc -README.md @aaltshuler @ragnorc -AGENTS.md @aaltshuler @ragnorc -CLAUDE.md @aaltshuler @ragnorc -SECURITY.md @aaltshuler @ragnorc +crates/** @ragnorc +docs/** @ragnorc +README.md @ragnorc +AGENTS.md @ragnorc +CLAUDE.md @ragnorc +SECURITY.md @ragnorc diff --git a/.github/codeowners-roles.yml b/.github/codeowners-roles.yml index f542b84..c5e36a9 100644 --- a/.github/codeowners-roles.yml +++ b/.github/codeowners-roles.yml @@ -19,19 +19,15 @@ roles: engineering: description: > All production code under crates/**. Engine, CLI, server, - compiler. Either named member can approve. + compiler. members: - - aaltshuler - ragnorc docs: description: > Documentation under docs/**, plus repo-level docs (README.md, - AGENTS.md, CLAUDE.md symlink, SECURITY.md). Either named member - can approve; both are listed so reviews can route to whoever is - available. + AGENTS.md, CLAUDE.md symlink, SECURITY.md). members: - - aaltshuler - ragnorc # Path → role mapping. GitHub CODEOWNERS uses "last match wins" diff --git a/docs/dev/codeowners.md b/docs/dev/codeowners.md index 160f9f4..9a7fb50 100644 --- a/docs/dev/codeowners.md +++ b/docs/dev/codeowners.md @@ -8,10 +8,10 @@ This setup gives every role change a reviewable PR and a permanent in-repository | Role | Members | Scope | |---|---|---| -| `engineering` | `@aaltshuler`, `@ragnorc` | All code under `crates/**`, repository infrastructure, default for unmapped paths | -| `docs` | `@aaltshuler`, `@ragnorc` | `docs/**`, README.md, AGENTS.md, CLAUDE.md, SECURITY.md | +| `engineering` | `@ragnorc` | All code under `crates/**`, repository infrastructure, default for unmapped paths | +| `docs` | `@ragnorc` | `docs/**`, README.md, AGENTS.md, CLAUDE.md, SECURITY.md | -GitHub treats multiple owners in a CODEOWNERS line as **"any one of them satisfies the review requirement"**. For docs, either named member can approve. To require N distinct approvers on a specific path, layer a CI check on top (not currently configured). +GitHub treats multiple owners in a CODEOWNERS line as **"any one of them satisfies the review requirement"**. To require N distinct approvers on a specific path, layer a CI check on top (not currently configured). ## How to change role membership or path mappings