apunkt/omnigraph
1
0
Fork 0
mirror of https://github.com/ModernRelay/omnigraph.git synced 2026-06-21 02:28:07 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(engine): restrict anti-join bulk fast path to one-hop expands

Browse source 
bulk_anti_join_applies accepted any single Expand, but try_bulk_anti_join_mask
decides via the CSR has_neighbors one-hop existence check — wrong for multi-hop
negations. Require min_hops==1 && max_hops==1 in the predicate; anything else
falls to the slow path, whose inner Expand runs the real bounded traversal.
Turns the multi-hop regression green; one-hop anti-joins unchanged.
This commit is contained in:
Ragnor Comerford 2026-06-09 17:18:24 +02:00
parent 4aca3dfece
commit edca75457e
No known key found for this signature in database
1 changed files with 9 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

11
crates/omnigraph/src/exec/query.rs
View file

@ -1558,8 +1558,15 @@ async fn hydrate_nodes(
fn bulk_anti_join_applies(inner_pipeline: &[IROp], outer_var: &str) -> bool { fn bulk_anti_join_applies(inner_pipeline: &[IROp], outer_var: &str) -> bool {
matches!( matches!(
inner_pipeline, inner_pipeline,
[IROp::Expand { src_var, dst_filters, .. }] [IROp::Expand { src_var, dst_filters, min_hops, max_hops, .. }]
if src_var == outer_var && dst_filters.is_empty() if src_var == outer_var
&& dst_filters.is_empty()
// `has_neighbors` is a ONE-hop existence test, so the fast path
// is valid only for a single-hop expand. Multi-hop negations
// (e.g. `not { $p knows{2,2} $x }`) fall to the slow path, whose
// inner Expand runs the real bounded traversal.
&& *min_hops == 1
&& (*max_hops).unwrap_or(1) == 1
) )
} }