apunkt/omnigraph
1
0
Fork 0
mirror of https://github.com/ModernRelay/omnigraph.git synced 2026-06-27 02:39:38 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

test(engine): drop flaky wall-clock budget from the merge truth table

Browse source 
The 30s wall-clock assertion in merge_pair_truth_table flakes under parallel
test load: it tripped at ~31s in the full --test-threads=4 gate while passing at
~20s in isolation. A fixed time budget in a correctness test depends on machine
and parallelism, not correctness; elapsed is still logged for visibility, and a
real merge-perf regression belongs in a bench. The cell-count correctness
assertions (81 / 36 / 45) are unchanged.
This commit is contained in:
Ragnor Comerford 2026-06-09 13:25:32 +02:00
parent bdc899f03d
commit d746a69237
No known key found for this signature in database
1 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
crates/omnigraph/tests/merge_truth_table.rs
View file

@ -941,8 +941,8 @@ async fn merge_pair_truth_table() {
unsupported_cells, 45, unsupported_cells, 45,
"expected 45 cells involving dropProperty/addLabel/removeLabel" "expected 45 cells involving dropProperty/addLabel/removeLabel"
); );
assert!( // No wall-clock assertion here: `elapsed` is logged above for visibility, but
elapsed.as_secs() < 30, // a fixed time budget in a correctness test flakes under parallel test load
"merge truth table exceeded 30s budget: {elapsed:?}" // (it tripped at ~31s in the full `--test-threads=4` gate while passing at
); // ~20s in isolation). Merge-perf regressions belong in a bench, not here.
} }