apunkt/omnigraph
1
0
Fork 0
mirror of https://github.com/ModernRelay/omnigraph.git synced 2026-07-12 03:12:11 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

fix(engine): warn when OMNIGRAPH_EMBEDDINGS_MOCK overrides an explicit provider

Browse source 
The mock flag's precedence over OMNIGRAPH_EMBED_PROVIDER is deliberate
and stays (pinned by from_env_mock_flag_wins) — but the override was
silent, and mock vectors are indistinguishable from real ones (correct
dimension, unit norm, deterministic hash), so a leaked test env var
silently poisoned persisted embeds (CLI) and query-time nearest()
(server, for graphs without a bound cluster embedding profile). Emit a
tracing::warn naming the overridden provider; document the precedence
in the embeddings env-var table.

Closes iss-embeddings-mock-override-silent.
This commit is contained in:
aaltshuler 2026-07-05 05:08:26 +03:00 • committed by Andrew Altshuler
parent fd32460eac
commit 4834c6a0dc
2 changed files with 19 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

18
crates/omnigraph/src/embedding.rs
View file

@ -70,6 +70,24 @@ impl EmbeddingConfig {
/// 5. provider api-key env (`OPENROUTER_API_KEY`/`OPENAI_API_KEY`, or `GEMINI_API_KEY`).
pub fn from_env() -> Result<Self> {
if env_flag("OMNIGRAPH_EMBEDDINGS_MOCK") {
// The mock flag deliberately wins (pinned by
// from_env_mock_flag_wins) — but overriding an EXPLICITLY
// configured real provider must be loud: mock vectors are
// indistinguishable from real ones (correct dimension, unit
// norm), so a leaked test env var would otherwise silently
// poison persisted embeds and query-time nearest().
if let Some(provider) = env_string("OMNIGRAPH_EMBED_PROVIDER")
&& provider != "mock"
{
tracing::warn!(
target: "omnigraph::embedding",
overridden_provider = %provider,
"OMNIGRAPH_EMBEDDINGS_MOCK is set and overrides the \
explicitly configured OMNIGRAPH_EMBED_PROVIDER — all \
embeddings in this process are deterministic mock \
vectors, not real ones"
);
}
return Ok(Self::mock());
}

2
docs/user/search/embeddings.md
View file

@ -61,7 +61,7 @@ Direct (`--store`) access, embedded callers, and the offline
| `OMNIGRAPH_EMBED_DEADLINE_MS` | total wall-clock budget for one embed call across all retries (default `60000`; `0` = unbounded) |
| `OMNIGRAPH_EMBED_TIMEOUT_MS` | per-request HTTP timeout (default `30000`) |
| `OMNIGRAPH_EMBED_RETRY_ATTEMPTS` / `OMNIGRAPH_EMBED_RETRY_BACKOFF_MS` | retry policy (defaults `4` / `200`) |
| `OMNIGRAPH_EMBEDDINGS_MOCK` | set truthy to force the deterministic mock provider |
| `OMNIGRAPH_EMBEDDINGS_MOCK` | set truthy to force the deterministic mock provider. Takes precedence over an explicitly configured `OMNIGRAPH_EMBED_PROVIDER` — the override is logged as a warning (`omnigraph::embedding` target), since mock vectors are indistinguishable from real ones (correct dimension, unit norm) |
The default zero-config path is OpenRouter: set `OPENROUTER_API_KEY` and run. Reaching Gemini takes
`OMNIGRAPH_EMBED_PROVIDER=gemini` plus `GEMINI_API_KEY`.