apunkt/omnigraph
1
0
Fork 0
mirror of https://github.com/ModernRelay/omnigraph.git synced 2026-06-09 01:35:18 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

MR-771: address cubic comment — drop vacuous __run__ check in cancel test

Browse source 
cubic correctly flagged that the assertion `!branches_after.iter().any(|b| b.starts_with("__run__"))` is vacuous because `branch_list()` already filters `__run__*` via `is_internal_system_branch`. The real structural property (no `__run__` branches can ever be created) is enforced by MR-771's deletion of `begin_run` etc. — that's a build-time invariant, not a runtime one.

Drop the vacuous assertion; document why. The remaining checks (public branch list unchanged + `_graph_runs.lance` never reappears) cover the actual cancel-safety properties.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
Ragnor Comerford 2026-04-30 15:31:30 +02:00
parent a7109d5fba
commit 1a906403cb
No known key found for this signature in database
1 changed files with 11 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

21
crates/omnigraph/tests/runs.rs
View file

@ -369,19 +369,20 @@ async fn cancelled_mutation_future_leaves_no_state() {
let branches_after = db.branch_list().await.unwrap();
// Cancel-safety property: no graph-level run/staging state remains.
// (1) No `__run__*` staging branches are created either way.
assert!(
!branches_after.iter().any(|b| b.starts_with("__run__")),
"cancelled mutation must not leave a __run__* branch behind",
);
// (2) The branch list is otherwise unchanged: cancellation/completion
// cannot synthesize new public branches.
//
// Note: `branch_list()` already filters `__run__*` via
// `is_internal_system_branch`, so a runtime "no `__run__` branches" check
// would be vacuous. The structural property that no `__run__` branches
// can ever be created is enforced by deletion of `begin_run` etc. in
// MR-771 (verified by the build itself — those symbols no longer exist).
//
// (1) The branch list is unchanged: cancellation/completion cannot
// synthesize new public branches.
assert_eq!(
branches_after.iter().filter(|b| !b.starts_with("__run__")).count(),
branches_before.iter().filter(|b| !b.starts_with("__run__")).count(),
branches_after, branches_before,
"cancelled mutation must not synthesize new public branches",
);
// (3) The legacy run-state machine table never reappears.
// (2) The legacy run-state machine table never reappears on disk.
assert!(
!std::path::Path::new(&format!("{}/_graph_runs.lance", uri)).exists(),
"no _graph_runs.lance after cancel — state machine is gone",