nyx/tests/perf_tests.rs
Eli Peter a438886217
Python fp and docs updtes (#58)
* refactor: Update comments for clarity and add expectations.json files for performance metrics

* feat: Implement FP guard for JS/TS local-collection receivers to suppress missing ownership checks

* feat: Enhance Rust parameter handling to classify local collections and prevent false ownership checks

* refactor: Simplify code formatting for better readability in multiple files

* refactor: Improve UTF-8 sequence length handling and enhance clarity in loop iteration

* feat: Update Java and Python patterns to include new security rules

* refactor: Improve comment clarity and consistency across multiple Rust files

* refactor: Simplify code formatting for improved readability in integration tests and module files

* refactor: Improve comment formatting and enhance clarity in assertions across multiple files
2026-04-29 19:53:34 -04:00

183 lines
6.2 KiB
Rust

#[allow(dead_code)]
mod common;
use common::{load_expectations, test_config};
use nyx_scanner::utils::config::AnalysisMode;
use std::path::{Path, PathBuf};
use std::sync::Arc;
use std::time::Instant;
fn fixture_path(name: &str) -> PathBuf {
PathBuf::from(env!("CARGO_MANIFEST_DIR"))
.join("tests")
.join("fixtures")
.join(name)
}
/// Perf thresholds are asserted only when a caller explicitly opts in via
/// `NYX_CI_BENCH=1`. The dedicated `benchmark-gate` CI job sets this in a
/// release build; the regular (debug) test jobs just print the numbers so
/// shared-runner noise on debug wall-clock does not cause flaky CI failures.
fn is_ci_bench() -> bool {
std::env::var("NYX_CI_BENCH").as_deref() == Ok("1")
}
/// Summarise a run's wall-clock samples.
///
/// When the perf gate is active (`NYX_CI_BENCH=1`) we take the *minimum* of the
/// recorded samples. This is the standard resistance-to-noise choice for CI
/// wall-clock microbenchmarks: unexpected slowdowns come from CPU steal,
/// background jobs, page-cache misses etc., which can only make a sample
/// slower, never faster. The minimum is the best available estimate of the
/// actual work cost; using the median would let a single lucky fast run hide a
/// real regression and, worse, let a single unlucky slow run fail an otherwise
/// healthy build. Outside CI we keep the median so the printed number tracks
/// the typical developer-machine experience.
fn summarise(mut samples: Vec<u64>) -> u64 {
assert!(!samples.is_empty(), "need at least one sample");
samples.sort_unstable();
if is_ci_bench() {
samples[0]
} else {
samples[samples.len() / 2]
}
}
/// Run `scan_no_index` once to warm caches, then N timed iterations.
fn bench_no_index(fixture_dir: &Path, iterations: usize) -> u64 {
let cfg = test_config(AnalysisMode::Full);
// Warm-up: ignore the first run so filesystem cache + lazy statics don't
// dominate the first sample.
let _ = nyx_scanner::scan_no_index(fixture_dir, &cfg);
let mut durations: Vec<u64> = Vec::with_capacity(iterations);
for _ in 0..iterations {
let start = Instant::now();
let _ = nyx_scanner::scan_no_index(fixture_dir, &cfg);
durations.push(start.elapsed().as_millis() as u64);
}
summarise(durations)
}
/// Run indexed scan (cold = new tempdir with fresh index, warm = second run).
fn bench_indexed(fixture_dir: &Path, iterations: usize) -> (u64, u64) {
use nyx_scanner::commands::index::build_index;
use nyx_scanner::commands::scan::scan_with_index_parallel;
use nyx_scanner::database::index::Indexer;
let cfg = test_config(AnalysisMode::Full);
let mut cold_durations: Vec<u64> = Vec::with_capacity(iterations);
let mut warm_durations: Vec<u64> = Vec::with_capacity(iterations);
// Warm-up pair: drop these samples.
{
let td = tempfile::tempdir().expect("tempdir");
let db_path = td.path().join("bench.db");
build_index("bench", fixture_dir, &db_path, &cfg, false).expect("build_index");
let pool = Indexer::init(&db_path).expect("db init");
let _ = scan_with_index_parallel("bench", Arc::clone(&pool), &cfg, false, fixture_dir);
let _ = scan_with_index_parallel("bench", Arc::clone(&pool), &cfg, false, fixture_dir);
}
for _ in 0..iterations {
let td = tempfile::tempdir().expect("tempdir");
let db_path = td.path().join("bench.db");
// Cold: build index + scan
let start = Instant::now();
build_index("bench", fixture_dir, &db_path, &cfg, false).expect("build_index");
let pool = Indexer::init(&db_path).expect("db init");
let _ = scan_with_index_parallel("bench", Arc::clone(&pool), &cfg, false, fixture_dir);
cold_durations.push(start.elapsed().as_millis() as u64);
// Warm: second scan on same index, files unchanged
let start = Instant::now();
let _ = scan_with_index_parallel("bench", Arc::clone(&pool), &cfg, false, fixture_dir);
warm_durations.push(start.elapsed().as_millis() as u64);
}
(summarise(cold_durations), summarise(warm_durations))
}
fn run_fixture_bench(name: &str) {
let dir = fixture_path(name);
let exp = load_expectations(&dir);
let perf = &exp.performance_expectations;
let iterations = 5;
let no_index_ms = bench_no_index(&dir, iterations);
println!(
"[{name}] no-index: {no_index_ms}ms (threshold: {}ms)",
perf.max_ms_no_index
);
let (cold_ms, warm_ms) = bench_indexed(&dir, iterations);
println!(
"[{name}] index-cold: {cold_ms}ms (threshold: {}ms)",
perf.max_ms_index_cold
);
println!(
"[{name}] index-warm: {warm_ms}ms (threshold: {}ms)",
perf.max_ms_index_warm
);
if is_ci_bench() {
// Shared GitHub Actions runners have unpredictable CPU contention;
// give "lenient" fixtures 2x headroom so a slow-but-passing scanner
// does not flake the build. "strict" fixtures still keep a small
// cushion, regressions at that level are real.
let multiplier = if perf.ci_mode == "lenient" { 2.0 } else { 1.25 };
let max_no_index = (perf.max_ms_no_index as f64 * multiplier) as u64;
let max_cold = (perf.max_ms_index_cold as f64 * multiplier) as u64;
let max_warm = (perf.max_ms_index_warm as f64 * multiplier) as u64;
assert!(
no_index_ms <= max_no_index,
"[{name}] no-index exceeded threshold: {no_index_ms}ms > {max_no_index}ms"
);
assert!(
cold_ms <= max_cold,
"[{name}] index-cold exceeded threshold: {cold_ms}ms > {max_cold}ms"
);
assert!(
warm_ms <= max_warm,
"[{name}] index-warm exceeded threshold: {warm_ms}ms > {max_warm}ms"
);
}
}
#[test]
fn perf_rust_web_app() {
run_fixture_bench("rust_web_app");
}
#[test]
fn perf_express_app() {
run_fixture_bench("express_app");
}
#[test]
fn perf_flask_app() {
run_fixture_bench("flask_app");
}
#[test]
fn perf_go_server() {
run_fixture_bench("go_server");
}
#[test]
fn perf_c_utils() {
run_fixture_bench("c_utils");
}
#[test]
fn perf_java_service() {
run_fixture_bench("java_service");
}
#[test]
fn perf_mixed_project() {
run_fixture_bench("mixed_project");
}