nyx/frontend/src/pages/FindingDetailPage.tsx
Eli Peter 41128177d2
Release/0.5.0 (#35)
* feat: Introduce function-scoped variable interning for state analysis with new tests and fixtures

* feat: Add Phase 26 symbolic execution enhancements with bitwise operator support, abstract interpretation refinements, and new taint analysis tests

* feat: Refine state analysis to handle factory-pattern resource returns with mixed-path tests and leak detection enhancements

* feat: Add Phase 27 debug views with symbolic execution, abstract interpretation, SSA, and call graph viewers; integrate with debug layout and styles

* feat: Add Phase 31 type-qualified symbolic resolution with receiver-based callee disambiguation and testing

* feat: Extend symbolic execution with state iteration, enhanced debug views, and debounced input handling

* feat: Add Phase 13 resource and auth pattern extensions with new tests and fixtures

* feat: Introduce CFG debug graph renderer with compact mode, toolbar, and DAG layout integration

* feat: Add Phase 28 encoding and decoding transform modeling with structural symex enhancements and new taint analysis tests

* feat: Extend abstract interpretation with type facts and constant value tracking in debug views and server logic

* feat: Add linear path handling and witness extraction to symbolic execution with Phase 28 transform mismatch detection

* feat: Refine Go auth and sanitizer handling with enhanced rules, state updates, and benchmark improvements

* feat: Enable auth-state analysis by default and update relevant tests in benchmark config

* test: Update state_tests to reflect default enablement of auth-state analysis and add auth suppression test

* docs: update CHANGELOG.md

* feat: Introduce per-index taint tracking in `HeapState` with `HeapSlot`, overflow handling, and revised SSA transfers

* feat: Introduce C/C++ language labels and refine heap state tracking in SSA transfers

* feat: Implement per-index array slot tracking in symbolic heap with overflow collapse

* feat: Add implicit definition handling for uninitialized declarations in SSA value allocation

* feat: Refactor function parameters and constants for improved clarity and maintainability

* refactor: Reorder module imports and improve formatting for consistency

* refactor: Fix formatting erorrs

* refactor: Fix clippy warnings

* refactor: Fix fmt warnings (again)

* chore: Update dependencies and improve feature configuration

* Add comprehensive tests for undertested modules (#36) (COPILOT)

* Add comprehensive tests for undertested modules

Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/f3fc877e-f386-49ba-9793-fc93d3805083

* Add comprehensive tests for ext, project, walk, and errors modules

Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/f3fc877e-f386-49ba-9793-fc93d3805083

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>

* chore: Update dependencies and improve feature configuration

* fix: formatting errors in new tests

* chore: Update license list in about.toml

* chore: made functions input inline

* chore: updated cfg graph to take up the full page

* chore: add Prettier configuration and update code formatting

* Add frontend test suite with Vitest (111 tests) (#37)

* Add Vitest test suite for frontend - 111 tests across utils, components, hooks, and graph utilities

Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/7cf0dba2-ecff-4740-ba4d-92717e74a0b7

* ci: add frontend test step to CI workflow

Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/5bc0ac9f-0a32-4d03-9cb7-7a15aea53fca

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>

* chore: simplify array initialization in test files for consistency

* ran typecheck

* feat: add AnalysisWorkspace component and integrate it into CfgViewerPage

* feat: update routing in AppLayout and improve empty state message in ExplorerPage

* feat: enhance scan progress tracking with additional metrics and stages

* feat: update license information and add license check script

* feat: implement cross-file symbolic execution with callee body persistence

* feat: replace dagre graphs with Graphology + ELK + Sigma for more advanced call stack and cfg rendering

* feat: ensure CFG function view is scoped to the selected function, preventing bleed into sibling functions

* feat: enhance resource tracking with proxy method summaries and improve finding extraction

* feat: add terminal function exit detection for accurate resource leak analysis

* feat: add warnings for loops and functions without bodies to improve error recovery

* feat: update lambda expression handling to ensure proper function classification and control flow

* feat: remove bounded formatting/string ops and add JSON.parse sanitizer for improved data handling

* feat: add inline return taint analysis and regression tests for improved security checks

* feat: add engine version management and migration handling for database schema updates

* feat: enhance first_call_ident to skip nested function bodies and add regression tests

* feat: enhance callee name resolution with two-segment normalization and disambiguation

* feat: add cross-file context flags and debug assertions for taint analysis

* feat: refactor taint analysis structure to unify context handling and improve clarity

* feat: enhance dead code elimination to preserve Sink, Source, and Sanitizer labels with new tests

* docs: updated CHANGELOG.md

* fmt: formatting fixes

* fix: fixed frontend formatting and lint warnings

* fix: optimized ci

* fix: optimized ci

* Add comprehensive multi-file test coverage to Nyx (#38)

* Initial checklist for multi-file test suite expansion

Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/e550cb88-9767-4442-94d4-101bf5bb0e23

Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>

* Add 12 new multi-file test fixtures with TP/TN/near-miss coverage

Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/e550cb88-9767-4442-94d4-101bf5bb0e23

Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>

* deleted root repo

* rebuilt to test for regressions

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
Co-authored-by: elipeter <elicpeter@gmail.com>

* feat: enhance import alias resolution and taint tracking

* feat: implement security hardening with CSRF protection and path validation

* feat: add support for import alias bindings in Python, PHP, and Rust

* feat: enhance CFG analysis modes and improve code readability

* feat: add detection for parameterized SQL queries to enhance security

* feat: add safe internal redirect handling and enhance session destroy validation

* feat: implement security improvements by addressing vulnerabilities in execAsync, session management, and file downloads

* feat: enhance taint detection by adding support for inline source member expressions in call arguments

* feat: implement pre-emission of Source nodes for inline source member expressions in call arguments

* feat: add support for Throw statement in control flow and error handling

* feat: add debug and echo endpoints with potential information leakage

* feat: implement internal redirect suppression and enhance taint detection

* feat: implement module alias tracking for dynamic dispatch in JS/TS

* feat: add authorization analysis module with Express support

* feat: add authorization analysis module with Express support

* feat: add tests for admin guard requirements and clean checks in authorization analysis

* feat: integrate Koa and Fastify frameworks into authorization analysis

* feat: add Flask and Django support to authorization analysis module

* feat: add support for Rails and Sinatra frameworks in authorization analysis

* feat: add support for Axum, ActixWeb, and Rocket frameworks in authorization analysis

* feat: add support for ActixWeb, Axum, and Rocket frameworks in authorization analysis

* feat: add support for Rails and Sinatra in authorization analysis

* chore: add .DS_Store to .gitignore

* refactor: simplify conditional checks and improve readability in multiple files

* refactor: update usage of Option methods for improved clarity and consistency

* refactor: improve code readability by simplifying conditional checks and formatting

* refactor: improve code formatting and readability by simplifying conditional checks

* refactor: simplify conditional checks and improve readability in multiple files

* refactor: simplify conditional checks in axum.rs for improved readability

* feat: add CodeQL analysis configuration for enhanced security scanning

* test: add comprehensive tests for `src/output.rs` SARIF builder (#39)

* chore: start test coverage improvement work

Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/cd7ff398-134e-4728-a5e7-0353a0744423

Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>

* test: add comprehensive tests for src/output.rs SARIF builder

Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/cd7ff398-134e-4728-a5e7-0353a0744423

Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>

* refactor: improve code formatting and readability in output.rs

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
Co-authored-by: elipeter <elicpeter@gmail.com>

* refactor: improve code formatting and readability in output.rs

* Potential fix for code scanning alert no. 210: Uncontrolled data used in path expression

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

* Potential fix for code scanning alert no. 211: Uncontrolled data used in path expression

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

* refactor: enhance triage file path handling with improved error management and validation

* refactor: updated func summaries for richer detail

* refactor: update SSA summary extraction to use canonical FuncKey for distinct entries

* refactor: enhance callee metadata structure to support arity, receiver, and qualifier for better overload resolution

* refactor: add support for keyword arguments in function calls and enhance receiver extraction for method-style calls

* refactor: implement new Flask routes for safe and unsafe shell command execution

* refactor: separate receiver handling in SSA operations and enhance taint propagation

* refactor: improve arity handling by using arg_uses for positional argument count and enhance witness scoring for tainted arguments

* refactor: implement auth decorator extraction and classification for multiple languages

* refactor: enhance Rust module path resolution and use map handling for cross-file disambiguation

* refactor: introduce CalleeQuery struct for structured callee resolution and enhance resolver logic

* refactor: implement same-file identity collision handling for `runTask` to ensure correct resolver behavior

* refactor: standardize default struct initialization across multiple files

* feat: add scripts for formatting checks and auto-fixes with test summaries

* refactor: simplify character splitting and enhance namespace qualifier handling

* refactor: improve documentation clarity and enhance code readability in resolver logic

* refactor: replace default struct initialization with explicit field assignments for clarity

* feat: enhance anonymous function naming by deriving context-based bindings

* refactor: streamline match expressions for improved readability and performance

* refactor: streamline match expressions for improved readability and performance

* refactor: replace loop with while let for improved clarity and performance

* feat: add SSA constant propagation support to analysis context for improved accuracy

* feat: add SSA constant propagation support to analysis context for improved accuracy

* feat: implement shell metacharacter validation and bounded-length checks in Rust analysis

* feat: add static map analysis for command injection suppression and type safety

* refactor: simplify match statements and reduce line breaks for improved readability

* feat(summary): phase 1/5 SinkSite data model for primary sink-location attribution

Introduce SinkSite (file_rel, line, col, snippet, cap) carrying the
primary sink source-location through function summaries. Swap
SsaFuncSummary.param_to_sink and FuncSummary.param_to_sink from a coarse
Cap map to a deduped SmallVec<[SinkSite; 1]> per parameter, with a
backward-compatible cap_sites() helper and serde defaults so pre-phase-1
on-disk rows continue to deserialise cleanly.

Extraction: SinkSiteLocator bundles the tree/bytes/file_rel needed by
extract_ssa_func_summary; ParsedFile::extract_ssa_artifacts wires the
locator in for the persisted pass-1 path, while pass-2 intra-file
transient summaries fall back to cap-only sites (behavior unchanged).
Merge: GlobalSummaries::insert now unions sink sites with
(file_rel, line, col, cap) dedup via shared union_param_sink_sites
helper.

Database: JSON-serialised summary columns carry the new shape
automatically; no schema change needed.

Phase 2 will consume SinkSite in build_taint_diag() to overwrite the
caller-site Finding.line with the callee's sink line when resolved via
summary. Phase 1 keeps behavior unchanged: scanning
tests/benchmark/corpus/rust/cmdi/cmdi_indirect.rs still produces the
same (wrong) line 10 finding.

Adds round-trip tests covering SinkSite solo, SsaFuncSummary with sink
sites, legacy-JSON default handling for both summary types, and merge
dedup.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* feat(taint): phase 2/5 thread SinkSite into SsaTaintEvent and Finding

Plumb Phase 1's SinkSite through the event pipeline into Findings,
no output change yet.  SsaTaintEvent gains `primary_sink_site:
Option<SinkSite>`; when the main or callback sink-emission path has
non-empty `param_to_sink_sites`, filter to sites whose
`(line != 0) && (cap ∩ sink_caps != ∅)` and emit one event per
distinct site — the multi-primary collapse keeps each downstream
Finding single-primary.

Resolution: ResolvedSummary and SinkInfo gain mirror
`param_to_sink_sites` fields, populated from `SsaFuncSummary.param_to_sink`
(SSA + callback paths) and `FuncSummary.param_to_sink` (global paths).
Label, local-summary, and interop resolution paths leave the field
empty — they only ever had cap-level info to begin with.

Finding: new `primary_location: Option<SinkLocation>` with
`file_rel/line/col`.  `ssa_events_to_findings` maps
`event.primary_sink_site` → `Finding.primary_location`, filtering
cap-only sites (`line == 0`) to `None` so the (0,0) sentinel never
leaks to formatters.  Dedup key extended with the primary location
so multi-site events aren't collapsed back together.

Invariants (debug_assert!):
* every SinkSite reaching emission has `line != 0 && cap ∩ sink_caps
  != ∅` — enforced by the pick_primary_sink_sites* filters;
* every populated Finding.primary_location has `line != 0` AND
  non-empty `file_rel` — the cap-only → None translation upstream
  guarantees this.

Deliberately independent of `uses_summary`: that flag tracks whether
the *taint chain* used a summary, whereas primary attribution
requires only that the *sink* itself was summary-resolved.  A local
source reaching a cross-file sink produces `uses_summary=false`
alongside a populated primary_location — documented on
Finding.primary_location, covered by
`cross_file_sink_finding_carries_primary_location`.

build_taint_diag, SARIF/JSON/explanation formatters, and the
benchmark scorer remain untouched: finding.line still comes from
`cfg_graph[finding.sink]`, so cmdi_indirect.rs still reports line 10
and the benchmark's rs-cmdi-003 row still shows FN in the LOC column.

Tests: `cross_file_sink_finding_carries_primary_location` (proves
plumbing via a synthetic FuncSummary carrying a SinkSite at 42:5) and
`cross_file_sink_cap_only_site_leaves_primary_location_none`
(regression guard against cap-only sites surfacing).  All 1566 lib
tests + integration tests pass.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* feat(output): phase 3/5 consume primary sink location in diag + SARIF

When a finding's primary_location (populated in phase 2 from a callee
summary's SinkSite) names the dangerous instruction inside a callee
body, attribute the diagnostic line to that location instead of the
caller's call site. The call site is demoted to a Call step in
flow_steps, and a synthetic Sink step at the primary location is
appended so analysts still see the full trace.

Changes:
- Add scan_root parameter to build_taint_diag so file_rel can be
  resolved back to an absolute path via a shared resolve_file_rel
  helper. Empty file_rel (single-file scans where namespace == "")
  resolves to the file under analysis.
- Extend SinkLocation with snippet, carried from the upstream
  SinkSite so the formatter needs no second file read.
- Relax the ssa_events_to_findings debug_assert to allow empty
  file_rel, which is valid when scan root equals the file itself.
- SARIF: emit data-flow as codeFlows[0].threadFlows[0].locations[];
  locations[0] already reflects the primary sink position via the
  updated diag line/col.

Acceptance: scan on tests/benchmark/corpus/rust/cmdi/cmdi_indirect.rs
now reports line 5 (Command::new) as the primary sink, with the call
site at line 10 visible in flow_steps.

Two expect.json fixtures updated (must_match line_range widened):
- javascript/taint/context_sensitive_call: 12-14 -> 7-14 (line 8 is
  the real sink inside run()).
- rust/cfg/closure_async: 10-10 -> 10-11 (line 11 is Command::new
  inside the closure).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* feat(bench): phase 4/5 validate primary sink attribution across corpus

Extend the benchmark scorer and ground truth to lock in phase 3's
primary-location behavior, and add fixtures that exercise the new
capability end-to-end.

Scorer (tests/benchmark_test.rs):
- Add optional `expected_call_site_lines: Option<Vec<[usize; 2]>>` on
  Case. When present, score_location_level additionally requires at
  least one flow_step in the finding's evidence trace to fall within
  ±2 of the call-site range. When absent, the check is skipped —
  fully forward-compatible with existing fixtures.
- Retain ±2 tolerance on expected_sink_lines (compared against the
  now-primary Diag.line post-phase-3).

Ground truth edits:
- rs-cmdi-cross-001: expected_sink_lines [8,8] -> [9,9]. Line 8 is the
  transform::wrap call site (a cross-file propagator, not a sink);
  line 9 is Command::new, the real sink. The ±2 tolerance happened to
  mask this stale attribution but it was semantically wrong — phase 4
  is the right time to correct it. Also adds expected_call_site_lines
  [8,8] so the new field is exercised on an existing cross-file case.
- rs-cmdi-003: adds expected_call_site_lines [10,10] (run_cmd call).
  This fixture's sink (Command::new inside run_cmd at line 5) was the
  motivating case for phases 1-3; adding the call-site assertion
  guards against regression to caller-line attribution.

New fixtures:
- rust/cmdi/cmdi_indirect_multisink.rs (rs-cmdi-009): helper run_both
  takes two tainted params and invokes two Command sinks on
  consecutive lines. Locks in that primary line lands inside the
  helper (lines 5-6), not at the caller (line 12). Notes document
  that SinkSite is currently one-per-callee so both findings today
  collapse onto the first sink; expected_sink_lines=[5,6] and
  expected_call_site_lines=[12,12] stay valid either way.
- python/cmdi/cross_indirect_sink/{app.py,helper.py} (py-cmdi-cross-
  004): sink os.system lives in helper.py (cross-file), caller in
  app.py reads env source and calls run_cmd. Verifies phase 3's
  cross-file primary attribution: Diag.path = helper.py, Diag.line =
  5, with app.py:7 recorded in flow_steps as a Call step.

Acceptance:
- `cargo test --test benchmark_test -- --ignored --nocapture` passes.
- rs-cmdi-003 is TP/TP/TP (the target flip FN->TP at LOC). All
  pre-existing TP/TP/TP fixtures remain TP/TP/TP; 2 new fixtures are
  TP/TP/TP.
- Aggregate rule-level: TP=158 FP=10 FN=1 TN=97, P=0.940 R=0.994
  F1=0.966 on the 266-case corpus (was TP=156 FP=10 FN=1 TN=97 on
  264 pre-phase-4, delta is the +2 new cases both resolving TP).
- Full `cargo test` green (1566 lib tests + all integration tests).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* feat(taint): phase 5/5 lock Finding.primary_location contract via regression test

Add a regression test in src/taint/ssa_transfer.rs that wires up a synthetic
SsaFuncSummary with a SinkSite at other.rs:42:10 and drives the three
emission stages (pick_primary_sink_sites → emit_ssa_taint_events →
ssa_events_to_findings) against a minimal caller SSA body.  Asserts the
resulting Finding.primary_location is exactly that triple.

The existing integration tests in src/taint/tests.rs cover the coarse
FuncSummary path end-to-end through analyse_file.  This test locks in the
lower-level SSA-side plumbing so a future refactor that silently drops the
site between pick → emit → findings fails here rather than only at the
benchmark layer.

Also refreshes tests/benchmark/results/latest.json (timestamp only; rs-cmdi-003
remains TP/TP/TP and the aggregate P/R/F1 are unchanged from phase 4).

Closes the primary sink-location attribution feature (phases 1-5/5):
* Phase 1 — SinkSite data model on summaries.
* Phase 2 — SinkSite threaded into SsaTaintEvent and Finding.
* Phase 3 — diag + SARIF consume primary_location.
* Phase 4 — benchmark validates primary_call_site_lines across corpus.
* Phase 5 — regression test locks the event→finding contract.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* refactor: clean up formatting and improve readability in multiple files

* refactor: simplify type definition for deduplication key in findings

* test(harness): add must_not_match expectation for FP regression guards

Extends ExpectedFinding with must_not_match field that asserts a
diagnostic must NOT fire — presence is a hard failure. Non-consuming
scan so it coexists with must_match entries on the same rule_id.
Adds forbidden_violations accumulator and updates summary line.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* feat(regression): update expectations to ensure must_not_match for various taint and resource leak rules

* feat: implement auto-seeding for JS/TS handler parameters to enhance taint tracking

* feat: update switch statement handling to improve control flow analysis

* feat: implement promisify alias handling for JS/TS to enhance taint tracking

* feat: enhance taint tracking by refining expectation handling and adding mode filtering

* feat: refine SQL handling in stream processing and enhance auto-seeding for handler parameters

* feat: update taint tracking rules to enforce full mode matching and improve flow analysis

* feat: enhance Ruby subshell handling to improve taint tracking and flow analysis

* feat: update xss_response expectations to refine taint flow analysis and enhance regression guarding

* feat: refine framework detection and update expectation handling for Echo and Sinatra

* feat: implement max_count for taint tracking expectations and deduplicate findings

* feat: add strict_unexpected handling for taint-unsanitised-flow in expectation files

* feat: enhance deduplication of taint-unsanitised-flow findings by collapsing based on line and severity

* feat: add strict_unexpected handling for taint-unsanitised-flow in multiple expectation files

* feat: add structural invariant checks for SSA bodies

* feat: ensure deterministic phi emission order using BTreeSet

* feat: enhance handling of terminators to ensure authoritative flow through successor edges

* feat: enhance Goto terminator handling to ensure all successors are marked executable

* feat: refactor code for improved readability and organization

* feat: simplify predicate checks and enhance readability in SSA handling

* feat: implement per-file parse timeout and enhance file size handling

* feat: migrate analysis engine toggles from environment variables to configuration file

* feat: remove unnecessary whitespace in hostile_input_tests.rs

* feat: remove unnecessary whitespace in hostile_input_tests.rs

* feat: update dependencies and enhance documentation on language maturity

* feat: enhance security headers and improve request body limits

* feat: implement sink capability bits for deduplication and enhance evidence tagging

* feat: implement dynamic activation handling for gated sinks and enhance validation logic

* feat: enhance configuration documentation and clarify inline analysis cache behavior

* feat: implement panic recovery during analysis to continue scans past errors

* feat: add expectations configuration for taint analysis and performance metrics

* feat: enhance error handling and logging during file reading and mutex locking

* feat: add cross-file body loading tests and plumbing for CF-1 phase

* feat: implement cross-file k=1 context-sensitive inline taint analysis with new tests and fixtures

* feat: implement indexed-scan parity in cross-file inline analysis with new dropdown and copy functionality

* feat: enhance classification span handling in CFG and AST for improved source attribution

* feat: add new Express routes for handling user input and telemetry data

* feat: implement ternary expression handling in CFG with diamond structure for JS/TS

* feat: implement Phase CF-3 abstract-domain transfer channels in summaries

* feat: add support for string-prefix transfer in cross-file calls and update tests

* docs: reduce RESULTS.md doc size

* feat: implement Phase CF-4 per-return-path summary decomposition with tests

* feat: update parameter handling in pass1 and refactor SsaFuncSummary initialization

* feat: implement Phase CF-5 for cross-file SCC joint fixed-point convergence with new flags and tests

* feat: implement Phase CF-6 with parameter-granularity points-to summaries and associated tests

* refactor: update comments and documentation for clarity and consistency

* style: format code for consistency and readability

* refactor: simplify verdict handling and improve edge checking logic

* refactor: optimize path and identifier collection by avoiding unnecessary cloning

* chore: update Cargo.toml for Rust version 1.85 and add ignored files; modify CHANGELOG and README for clarity on state analysis defaults

* refactor: update documentation and improve clarity in configuration files

* refactor: update documentation and improve clarity in configuration files

* feat: add JS/TS pass-2 convergence tests and expectations configuration

* feat: add Phase 5 regression tests for inline cache origin attribution and update related logic

* feat: implement Phase 7 deduplication and alternative path linking for taint findings

* feat: implement structural DFS index for anonymous functions and update naming conventions

* feat: add Phase 8 regression tests for container-element taint in JS and Python

* feat: add engine-depth profiles and explain-engine option for CLI

* feat: update expectations and add new README fixtures for multi-file scan regression

* feat: implement Phase 11 callback-alias and factory patterns with regression tests

* feat: implement Terminator::Switch for multi-way dispatch and add regression tests

* feat: add real-CVE benchmark fixtures for CVE-2023-48022, CVE-2019-14939, and CVE-2023-26159 with corresponding patched variants

* refactor: extract cfg and ssa_transfer to submodules

* refactor: cargo fmt

* refactor: remove unnecessary blank line in cfg_tests.rs

* refactor: remove unnecessary planning file

* chore: update Rust version to 1.88 and bump dependencies in Cargo files

* feat: enhance triage UI with new layout and controls, update README for clarity

* feat: enhance triage UI with new layout and controls, update README for clarity

* chore: remove outdated section from README for version 0.5.0

* docs: improve clarity and consistency in README content

* chore: add "GPL-3.0-or-later" to license options in about.toml

* chore: update license handling in about.toml and check-licenses.mjs

* style: format code for improved readability in TriagePage component

* style: format code for improved readability in TriagePage component

* chore: enhance license handling and improve body_id scoping in seed lookup

* feat: introduce owner and parent body IDs for enhanced seed scoping

* feat: implement direction-aware engine provenance with new CLI flag for strict CI gating

* feat: add Undef SSA operation for improved control-flow handling

* style: improve code formatting for consistency and readability in multiple files

* feat: add 16-function chain SCC across multiple files for enhanced analysis

* style: simplify code formatting for improved readability in multiple files

* fix: update CapHitReason default implementation and improve README clarity

* docs: enhance README with detailed explanations of taint analysis and limitations

* docs: refine README for clarity and consistency in taint analysis section

* style: improve code formatting for better readability in NewScanModal and scans

* fix: update cargo-about command to use --offline for deterministic license generation

* fix: update cargo-about command to use --offline for deterministic license generation

* ci: add step to prime cargo registry cache for deterministic license generation

* feat: add support for non-sink collections in authorization analysis

* feat: enhance authorization checks with row-level ownership equality and binding tracking

* feat: implement self-scoped user handling and enhance ownership checks

* refactor: simplify assertions and formatting in authorization analysis tests

* fix: normalize line endings in THIRDPARTY-LICENSES.html generation and update README with AI disclosure

* docs: update AI disclosure section for clarity and conciseness

* feat: add AI Contribution Policy and update contributing guidelines for AI assistance disclosure

* feat: enhance authorization analysis with SSA-derived variable type classification

* feat: implement auth_finding_to_diag function for enhanced security diagnostics

* feat: add args_value_refs to CallSite struct for enhanced argument tracking

* feat: add args_value_refs to CallSite struct for enhanced argument tracking

* feat: add direction-aware engine provenance with LossDirection classification and new CLI flag

* feat: simplify strip_cap_from_call_args call by removing unnecessary line breaks

* feat: enhance error message handling in cli_validation_tests for better Windows compatibility

* feat: optimize release profile settings in Cargo.toml and update CodeQL configuration

* feat: enhance release build process with SBOM generation and SLSA provenance

* feat: update actions/checkout and actions/setup-node to v6, enhance CLI options, and improve auth-check summaries

* feat: introduce PathFact handling for path safety checks and rejection logic

* feat: introduce PathFact handling for path safety checks and rejection logic

* feat: update benchmark data and enhance path sanitization logic with new safety checks

* feat: document AI assistance in frontend UI development and human review process

* feat: add return path facts for enhanced path safety checks and update documentation

* chore: update release date for version 0.5.0 in CHANGELOG.md

* chore: clean up ci.yml by removing outdated comments and clarifying steps

* feat: implement cross-language path sanitizers and validators for enhanced security

* feat: enhance SSA value usage tracking by including block terminators and improve path safety checks

* feat: enhance switch statement handling by adding per-case path constraints and support for exclusive cases

* refactor: simplify conditional formatting and improve code readability in executor and lower modules

* feat: add vulnerable examples for various languages demonstrating authentication and sanitization issues

* feat: enhance actor context recognition for self-actor identifiers and add support for global non-sink receivers

* feat: enhance actor context recognition for self-actor identifiers and add support for global non-sink receivers

* feat: add transform classifiers for Java, Go, and Ruby with corresponding tests

* refactor: clarify comments on reassign-to-constant idiom and sink behavior in guards.rs

---------

Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
2026-04-25 17:59:11 -04:00

1024 lines
31 KiB
TypeScript

import { useState, useCallback } from 'react';
import { useParams, useNavigate } from 'react-router-dom';
import { useFinding } from '../api/queries/findings';
import { useBulkTriage } from '../api/mutations/triage';
import { truncPath } from '../utils/truncPath';
import { escapeHtml, highlightSyntax } from '../utils/syntaxHighlight';
import { parseNoteText } from '../utils/parseNote';
import { findingToMarkdown } from '../utils/findingMarkdown';
import { CopyMarkdownButton } from '../components/CopyMarkdownButton';
import { Dropdown, DropdownItem } from '../components/ui/Dropdown';
import { CodeViewerModal } from '../modals/CodeViewerModal';
import type {
FindingView,
Evidence,
FlowStep,
SpanEvidence,
RelatedFindingView,
} from '../api/types';
// ── Helpers ─────────────────────────────────────────────────────────────────
function formatTriageState(state: string): string {
return (state || 'open').replace(/_/g, ' ');
}
interface StatusOption {
value: string;
label: string;
}
const STATUS_GROUPS: { heading: string; options: StatusOption[] }[] = [
{
heading: 'Active',
options: [
{ value: 'open', label: 'Open' },
{ value: 'investigating', label: 'Investigating' },
],
},
{
heading: 'Resolved',
options: [
{ value: 'fixed', label: 'Fixed' },
{ value: 'false_positive', label: 'False Positive' },
{ value: 'accepted_risk', label: 'Accepted Risk' },
{ value: 'suppressed', label: 'Suppressed' },
],
},
];
function isStateFinding(f: FindingView): boolean {
return f.rule_id.startsWith('state-');
}
const STATE_REMEDIATION_HINTS: Record<string, string[]> = {
'state-use-after-close': [
'Do not access the resource after calling close/free.',
'Restructure so every use happens before release.',
'Consider a language-native cleanup pattern (defer, with, try-with-resources, RAII).',
],
'state-double-close': [
'Remove the duplicate close call, or guard with a null/closed check.',
'Centralize cleanup in a single code path to avoid repeats.',
],
'state-resource-leak': [
'Add a close/free call before every function exit.',
'Prefer a language-native cleanup pattern (defer, with, try-with-resources, RAII).',
],
'state-resource-leak-possible': [
'Ensure the resource is closed on all code paths — including error and early-return paths.',
'Put cleanup in a finally/defer block rather than after the happy path.',
],
'state-unauthed-access': [
'Add an authentication check before the sensitive operation.',
'Move this handler behind an auth middleware or guard.',
],
};
const STATE_RULE_DESCRIPTIONS: Record<string, string> = {
'state-use-after-close': 'Variable used after its resource handle was closed',
'state-double-close': 'Resource handle closed more than once',
'state-resource-leak': 'Resource acquired but never closed',
'state-resource-leak-possible': 'Resource may not be closed on all paths',
'state-unauthed-access': 'Sensitive operation reached without authentication',
};
// ── Collapsible Section ─────────────────────────────────────────────────────
interface CollapsibleSectionProps {
title: string;
defaultOpen?: boolean;
children: React.ReactNode;
}
function CollapsibleSection({
title,
defaultOpen = true,
children,
}: CollapsibleSectionProps) {
const [open, setOpen] = useState(defaultOpen);
return (
<div className="detail-section">
<div className="section-toggle" onClick={() => setOpen((v) => !v)}>
<span className={`toggle-arrow${!open ? ' collapsed' : ''}`}>
&#9660;
</span>{' '}
{title}
</div>
<div className={`section-body${!open ? ' collapsed' : ''}`}>
{children}
</div>
</div>
);
}
// ── Evidence Cards ──────────────────────────────────────────────────────────
function EvidenceCard({
kind,
color,
span,
}: {
kind: string;
color: string;
span: SpanEvidence;
}) {
return (
<div className="evidence-card">
<div className="evidence-kind" style={{ color }}>
{kind}
</div>
<div>
{span.path}:{span.line}:{span.col}
</div>
{span.snippet && <div className="evidence-snippet">{span.snippet}</div>}
</div>
);
}
function StateTransitionCard({
evidence,
ruleId,
}: {
evidence: Evidence;
ruleId: string;
}) {
const st = evidence.state;
if (!st) return null;
const isAuth = st.machine === 'auth';
const machineLabel = isAuth ? 'Authentication State' : 'Resource Lifecycle';
const acquireLocation =
ruleId.includes('leak') && evidence.sink
? `${evidence.sink.path}:${evidence.sink.line}:${evidence.sink.col}`
: null;
return (
<div className="state-transition-card">
<div className="state-machine-label">{machineLabel}</div>
{st.subject && (
<div className="state-subject">
<span className="state-subject-label">Variable:</span>
<code className="state-subject-name">{st.subject}</code>
</div>
)}
<div className="state-transition-visual">
<span className="state-from">{st.from_state}</span>
<span className="state-arrow">&rarr;</span>
<span className="state-to">{st.to_state}</span>
</div>
{acquireLocation && (
<div className="state-acquire-location">
Acquired at: {acquireLocation}
</div>
)}
</div>
);
}
function EvidenceSection({
evidence,
skipStateCard,
}: {
evidence: Evidence;
skipStateCard?: boolean;
}) {
const cards: React.ReactNode[] = [];
if (evidence.source) {
cards.push(
<EvidenceCard
key="source"
kind="Source"
color="var(--success)"
span={evidence.source}
/>,
);
}
if (evidence.sink) {
cards.push(
<EvidenceCard
key="sink"
kind="Sink"
color="var(--sev-high)"
span={evidence.sink}
/>,
);
}
for (let i = 0; i < (evidence.guards?.length ?? 0); i++) {
cards.push(
<EvidenceCard
key={`guard-${i}`}
kind="Guard"
color="var(--accent)"
span={evidence.guards[i]}
/>,
);
}
for (let i = 0; i < (evidence.sanitizers?.length ?? 0); i++) {
cards.push(
<EvidenceCard
key={`sanitizer-${i}`}
kind="Sanitizer"
color="var(--sev-medium)"
span={evidence.sanitizers[i]}
/>,
);
}
if (evidence.state && !skipStateCard) {
const st = evidence.state;
cards.push(
<div className="evidence-card" key="state">
<div className="evidence-kind">State: {st.machine}</div>
<div>
{st.subject ? `${st.subject}: ` : ''}
{st.from_state} &rarr; {st.to_state}
</div>
</div>,
);
}
if (cards.length === 0) return null;
return <>{cards}</>;
}
// ── Notes Section ───────────────────────────────────────────────────────────
function NotesSection({ evidence }: { evidence: Evidence }) {
if (!evidence.notes || evidence.notes.length === 0) return null;
return (
<ul style={{ listStyle: 'disc', paddingLeft: 20, margin: 0 }}>
{evidence.notes.map((note, i) => (
<li key={i} className="evidence-note">
{parseNoteText(note)}
</li>
))}
</ul>
);
}
// ── Confidence Section ──────────────────────────────────────────────────────
function ConfidenceSection({ finding }: { finding: FindingView }) {
if (!finding.confidence) return null;
const limiters = finding.evidence?.confidence_limiters;
const showLimiters =
limiters && limiters.length > 0 && finding.confidence !== 'High';
return (
<>
<span className={`badge badge-conf-${finding.confidence.toLowerCase()}`}>
{finding.confidence}
</span>
{finding.rank_score != null && (
<span
style={{
marginLeft: 'var(--space-2)',
fontSize: 'var(--text-sm)',
color: 'var(--text-secondary)',
}}
>
Score: {finding.rank_score.toFixed(1)}
</span>
)}
{finding.rank_reason && finding.rank_reason.length > 0 && (
<div style={{ marginTop: 'var(--space-2)' }}>
{finding.rank_reason.map(([k, v], i) => (
<div key={i} className="evidence-note">
<strong>{k}:</strong> {v}
</div>
))}
</div>
)}
{showLimiters && (
<div style={{ marginTop: 'var(--space-3)' }}>
<strong
style={{
fontSize: 'var(--text-sm)',
color: 'var(--text-secondary)',
}}
>
Why not higher confidence?
</strong>
<ul className="confidence-limiters">
{limiters!.map((l, i) => (
<li key={i}>{l}</li>
))}
</ul>
</div>
)}
</>
);
}
// ── Structured Explanation ──────────────────────────────────────────────────
function describeSpan(span: SpanEvidence): string {
const name =
span.snippet?.trim() ||
span.kind ||
span.path.split('/').pop() ||
span.path;
return `${name} (line ${span.line})`;
}
function StructuredExplanation({
finding,
evidence,
}: {
finding: FindingView;
evidence: Evidence;
}) {
const rows: { label: string; value: React.ReactNode }[] = [];
if (evidence.source) {
rows.push({
label: 'From',
value: (
<code className="struct-expl-code">
{describeSpan(evidence.source)}
</code>
),
});
}
if (evidence.sink) {
rows.push({
label: 'Into',
value: (
<code className="struct-expl-code">{describeSpan(evidence.sink)}</code>
),
});
}
rows.push({
label: 'Risk',
value: riskSummary(finding, evidence),
});
const contextNote = buildContextNote(finding, evidence);
if (contextNote) {
rows.push({ label: 'Notes', value: contextNote });
}
if (rows.length === 0) return null;
return (
<dl className="struct-expl">
{rows.map((r, i) => (
<div className="struct-expl-row" key={i}>
<dt>{r.label}</dt>
<dd>{r.value}</dd>
</div>
))}
</dl>
);
}
function riskSummary(finding: FindingView, evidence: Evidence): string {
if (evidence.explanation) return evidence.explanation;
if (finding.message) return finding.message;
const category = finding.category?.toLowerCase() || '';
if (category.includes('security')) {
return 'Potential injection or unsafe-operation vulnerability.';
}
return `${finding.category} issue.`;
}
function buildContextNote(
finding: FindingView,
evidence: Evidence,
): React.ReactNode {
const parts: string[] = [];
const hasCrossFile = evidence.flow_steps?.some((s) => s.is_cross_file);
if (hasCrossFile) {
parts.push('Crosses function boundaries via summary resolution.');
}
if (finding.sanitizer_status === 'none') {
parts.push('No sanitizer was applied to this flow.');
} else if (finding.sanitizer_status === 'bypassed') {
parts.push('A sanitizer was present but was bypassed.');
}
if (finding.guard_kind) {
parts.push(`Guard: ${finding.guard_kind}.`);
}
return parts.length ? parts.join(' ') : null;
}
// ── Taint Flow Timeline ─────────────────────────────────────────────────────
const FLOW_KIND_COLORS: Record<string, string> = {
source: 'var(--success)',
assignment: 'var(--accent)',
call: 'var(--sev-medium)',
phi: 'var(--text-tertiary)',
sink: 'var(--sev-high)',
};
const FLOW_KIND_LABELS: Record<string, string> = {
source: 'Source',
assignment: 'Assign',
call: 'Call',
phi: 'Phi',
sink: 'Sink',
};
const FLOW_COLLAPSE_THRESHOLD = 5;
function FlowTimeline({ steps }: { steps: FlowStep[] }) {
const [expanded, setExpanded] = useState(
steps.length <= FLOW_COLLAPSE_THRESHOLD,
);
if (steps.length === 0) return null;
const isLong = steps.length > FLOW_COLLAPSE_THRESHOLD;
const visibleSteps: FlowStep[] = (() => {
if (!isLong || expanded) return steps;
const firstIdx = steps.findIndex((s) => s.kind === 'source');
const lastSinkIdx = [...steps]
.map((s, i) => ({ s, i }))
.reverse()
.find(({ s }) => s.kind === 'sink')?.i;
const picked = new Set<number>();
if (firstIdx >= 0) picked.add(firstIdx);
if (lastSinkIdx != null) picked.add(lastSinkIdx);
picked.add(0);
picked.add(steps.length - 1);
return [...picked].sort((a, b) => a - b).map((i) => steps[i]);
})();
return (
<div className="flow-timeline">
{visibleSteps.map((s, i) => {
const color = FLOW_KIND_COLORS[s.kind] || 'var(--text-secondary)';
const label = FLOW_KIND_LABELS[s.kind] || s.kind;
const isLast = i === visibleSteps.length - 1;
const isEndpoint = s.kind === 'source' || s.kind === 'sink';
return (
<div
key={`${s.step}-${i}`}
className={[
'flow-step',
s.is_cross_file ? 'flow-step-cross-file' : '',
isEndpoint ? `flow-step-endpoint flow-step-${s.kind}` : '',
]
.filter(Boolean)
.join(' ')}
>
<div className="flow-step-connector">
<div className="flow-step-dot" style={{ background: color }} />
{!isLast && <div className="flow-step-line" />}
</div>
<div className="flow-step-card">
<div className="flow-step-header">
<span className="flow-step-badge" style={{ color }}>
{label}
</span>
<span className="flow-step-num">#{s.step}</span>
{s.variable && (
<span className="flow-step-var">{s.variable}</span>
)}
{s.callee && (
<span className="flow-step-callee">{s.callee}</span>
)}
</div>
<div className="flow-step-loc">
{s.file}:{s.line}:{s.col}
{s.function ? ` in ${s.function}` : ''}
</div>
{s.snippet && (
<div className="flow-step-snippet">{s.snippet}</div>
)}
</div>
</div>
);
})}
{isLong && (
<button
type="button"
className="flow-expand-toggle"
onClick={() => setExpanded((v) => !v)}
>
{expanded
? `Collapse (${steps.length} steps)`
: `Show all ${steps.length} steps`}
</button>
)}
</div>
);
}
// ── Related Findings ────────────────────────────────────────────────────────
function RelatedFindings({ findings }: { findings: RelatedFindingView[] }) {
const navigate = useNavigate();
if (findings.length === 0) return null;
return (
<>
{findings.map((r) => (
<div
key={r.index}
className="related-row"
onClick={() => navigate(`/findings/${r.index}`)}
>
<span className={`badge badge-${r.severity.toLowerCase()}`}>
{r.severity.charAt(0)}
</span>
<span style={{ fontSize: 'var(--text-xs)' }}>{r.rule_id}</span>
<span
className="cell-path"
style={{ fontSize: 'var(--text-xs)', maxWidth: 200 }}
>
{truncPath(r.path, 30)}:{r.line}
</span>
</div>
))}
</>
);
}
// ── Code Preview ────────────────────────────────────────────────────────────
function CodePreview({
lines,
startLine,
highlightLine,
language,
}: {
lines: string[];
startLine: number;
highlightLine: number;
language?: string;
}) {
const lang = (language || '').toLowerCase();
return (
<div className="code-block">
{lines.map((line, i) => {
const lineNum = startLine + i;
const isHighlight = lineNum === highlightLine;
return (
<div
key={lineNum}
className={`code-line${isHighlight ? ' highlight' : ''}`}
>
<span className="line-number">{lineNum}</span>
<span
className="line-content"
dangerouslySetInnerHTML={{
__html: highlightSyntax(escapeHtml(line), lang),
}}
/>
</div>
);
})}
</div>
);
}
// ── How to Fix ──────────────────────────────────────────────────────────────
function sinkCapKey(finding: FindingView): string | null {
const snippet = (finding.evidence?.sink?.snippet || '').toLowerCase();
const rule = finding.rule_id.toLowerCase();
if (
/innerhtml|outerhtml|document\.write|dangerouslysetinnerhtml/.test(snippet)
)
return 'xss';
if (/\beval\b|new function|settimeout\s*\(\s*["'`]/.test(snippet))
return 'code-exec';
if (
/\bexec\b|\bspawn\b|\bsystem\b|\bpopen\b|shell_exec|subprocess/.test(
snippet,
)
)
return 'cmd-inject';
if (
/query|execute|raw|prepare.*%|select\s|insert\s|update\s|delete\s/i.test(
snippet,
)
)
return 'sql';
if (/readfile|fs\.|open\s*\(|path\.join/.test(snippet)) return 'path';
if (/\bfetch\b|\baxios\b|http\.|request\.|urlopen|curl/.test(snippet))
return 'ssrf';
if (rule.includes('xss')) return 'xss';
if (rule.includes('sql')) return 'sql';
if (rule.includes('cmd') || rule.includes('command')) return 'cmd-inject';
if (rule.includes('ssrf')) return 'ssrf';
if (rule.includes('path') || rule.includes('traversal')) return 'path';
if (rule.includes('deserial')) return 'deserialize';
if (rule.includes('eval') || rule.includes('codeexec')) return 'code-exec';
return null;
}
const TAINT_REMEDIATION: Record<string, string[]> = {
xss: [
'Avoid writing user input into innerHTML / outerHTML / document.write.',
'Use textContent, or framework-native binding (React props, Vue {{ }}, etc.).',
'If HTML is unavoidable, run input through a well-maintained sanitizer (DOMPurify, Bleach).',
],
sql: [
'Use parameterized queries or a prepared statement — never concatenate user input into SQL.',
'Prefer an ORM or query builder that escapes parameters automatically.',
'Validate input type (integer, enum, allowlist) before the query.',
],
'cmd-inject': [
'Avoid passing user input to shell/exec APIs.',
'Use the argv-array form of exec (no shell interpretation).',
'Validate against a strict allowlist of commands and arguments.',
],
ssrf: [
'Validate and allowlist outbound hostnames before making the request.',
'Resolve and check the target IP is not internal / metadata (169.254.169.254, 127.0.0.0/8, 10.0.0.0/8, RFC1918).',
'Use a dedicated HTTP client that disables redirects to private addresses.',
],
path: [
'Normalize the path and verify it stays within an expected root directory.',
'Reject inputs containing "..", null bytes, or absolute paths.',
'Use a safe-join helper rather than string concatenation.',
],
deserialize: [
'Do not deserialize untrusted input with dangerous formats (pickle, ObjectInputStream).',
'Use a schema-constrained format (JSON with a validator, Protobuf).',
'If unavoidable, run deserialization in a locked-down process and validate types post-hoc.',
],
'code-exec': [
'Do not pass user input to eval / new Function / exec.',
'Replace dynamic code generation with a parser over an allowlisted grammar.',
'If scripting is required, sandbox it (VM / Web Worker with no DOM, seccomp).',
],
};
const DEFAULT_TAINT_REMEDIATION: string[] = [
'Validate user input against an allowlist (length, character set, format).',
'Encode or escape data appropriately for the target sink.',
'Prefer parameterized / structured APIs over string concatenation.',
];
function HowToFix({ finding }: { finding: FindingView }) {
const isState = isStateFinding(finding);
const bullets: string[] = (() => {
if (isState) {
return STATE_REMEDIATION_HINTS[finding.rule_id] || [];
}
const key = sinkCapKey(finding);
if (key && TAINT_REMEDIATION[key]) return TAINT_REMEDIATION[key];
return DEFAULT_TAINT_REMEDIATION;
})();
if (bullets.length === 0) return null;
return (
<ul className="how-to-fix-list">
{bullets.map((b, i) => (
<li key={i}>{b}</li>
))}
</ul>
);
}
// ── Status Control ──────────────────────────────────────────────────────────
function StatusControl({
finding,
onTriage,
isPending,
}: {
finding: FindingView;
onTriage: (state: string, note: string) => void;
isPending: boolean;
}) {
const [noteDraft, setNoteDraft] = useState('');
const [noteOpen, setNoteOpen] = useState(false);
const currentState = finding.triage_state || 'open';
const chooseStatus = (state: string, close: () => void) => {
if (state === currentState) {
close();
return;
}
onTriage(state, noteDraft.trim());
setNoteDraft('');
setNoteOpen(false);
close();
};
return (
<div className="status-control" data-fingerprint={finding.fingerprint}>
<div className="status-control-row">
<label className="status-label">Status</label>
<Dropdown
trigger={({ open }) => (
<button
type="button"
className={`status-trigger status-trigger-${currentState}`}
disabled={isPending}
>
<span className={`status-dot status-dot-${currentState}`} />
<span className="status-value">
{formatTriageState(currentState)}
</span>
<span className={`status-caret${open ? ' open' : ''}`}></span>
</button>
)}
>
{({ close }) => (
<>
{STATUS_GROUPS.map((group) => (
<div className="status-group" key={group.heading}>
<div className="status-group-heading">{group.heading}</div>
{group.options.map((opt) => (
<DropdownItem
key={opt.value}
checked={opt.value === currentState}
onClick={() => chooseStatus(opt.value, close)}
>
{opt.label}
</DropdownItem>
))}
</div>
))}
</>
)}
</Dropdown>
{!noteOpen && (
<button
type="button"
className="status-note-toggle"
onClick={() => setNoteOpen(true)}
>
{finding.triage_note ? 'Edit note' : 'Add note'}
</button>
)}
</div>
{finding.triage_note && !noteOpen && (
<div className="status-current-note">
<strong>Note:</strong> {finding.triage_note}
</div>
)}
{noteOpen && (
<div className="status-note-input">
<textarea
placeholder="Context for the next person reading this…"
rows={2}
value={noteDraft || finding.triage_note || ''}
onChange={(e) => setNoteDraft(e.target.value)}
autoFocus
/>
<div className="status-note-actions">
<button
className="btn btn-sm btn-primary"
disabled={isPending}
onClick={() => {
onTriage(currentState, noteDraft.trim());
setNoteOpen(false);
}}
>
Save note
</button>
<button
type="button"
className="btn btn-sm"
onClick={() => {
setNoteOpen(false);
setNoteDraft('');
}}
>
Cancel
</button>
</div>
</div>
)}
</div>
);
}
// ── Main Component ──────────────────────────────────────────────────────────
export function FindingDetailPage() {
const { id } = useParams<{ id: string }>();
const { data: finding, isLoading, isError, error } = useFinding(id ?? '');
const bulkTriage = useBulkTriage();
const [codeModalOpen, setCodeModalOpen] = useState(false);
const handleTriage = useCallback(
(state: string, note: string) => {
if (!finding) return;
bulkTriage.mutate({
fingerprints: [finding.fingerprint],
state,
note,
});
},
[finding, bulkTriage],
);
if (isLoading) {
return <div className="loading">Loading finding...</div>;
}
if (isError || !finding) {
const msg = error instanceof Error ? error.message : 'Unknown error';
return (
<div className="error-state">
<h3>Finding not found</h3>
<p>{msg}</p>
</div>
);
}
const f = finding;
const evidence = f.evidence;
const isState = isStateFinding(f);
const hasWhySection =
f.message ||
(evidence && (evidence.source || evidence.sink || evidence.state));
const hasEvidence =
evidence &&
(evidence.source ||
evidence.sink ||
(evidence.guards && evidence.guards.length > 0) ||
(evidence.sanitizers && evidence.sanitizers.length > 0) ||
evidence.state);
const hasNotes = evidence && evidence.notes && evidence.notes.length > 0;
const hasFlow =
evidence && evidence.flow_steps && evidence.flow_steps.length > 0;
const hasRelated = f.related_findings && f.related_findings.length > 0;
const hasLabels = f.labels && f.labels.length > 0;
const hasCode = !!f.code_context;
const metaParts: string[] = [];
if (f.category) metaParts.push(f.category);
if (f.language) metaParts.push(f.language);
metaParts.push(formatTriageState(f.triage_state || 'open'));
if (f.sanitizer_status && !isState) {
metaParts.push(
f.sanitizer_status === 'none'
? 'No sanitizers'
: f.sanitizer_status === 'bypassed'
? 'Sanitizer bypassed'
: 'Sanitized',
);
}
return (
<div className="detail-panel finding-detail">
<div className="detail-title-row">
<h2 className="finding-heading">
<span
className={`severity-pill severity-pill-${f.severity.toLowerCase()}`}
>
{f.severity}
</span>
<span className="finding-rule-id">{f.rule_id}</span>
</h2>
<CopyMarkdownButton
iconOnly
title="Copy as markdown"
getMarkdown={() => findingToMarkdown(f)}
/>
</div>
<a
href="#"
className="file-location"
onClick={(e) => {
e.preventDefault();
setCodeModalOpen(true);
}}
>
{f.path}:{f.line}:{f.col}
</a>
<div className="finding-meta">
{metaParts.map((p, i) => (
<span key={i}>
{i > 0 && <span className="finding-meta-sep"></span>}
<span className="finding-meta-item">{p}</span>
</span>
))}
</div>
<StatusControl
finding={f}
onTriage={handleTriage}
isPending={bulkTriage.isPending}
/>
{/* Why Nyx Reported This */}
{hasWhySection && (
<CollapsibleSection title="Why Nyx Reported This">
{isState ? (
<>
{STATE_RULE_DESCRIPTIONS[f.rule_id] && (
<p style={{ marginBottom: 'var(--space-3)', lineHeight: 1.5 }}>
{STATE_RULE_DESCRIPTIONS[f.rule_id]}
</p>
)}
{f.message && (
<p style={{ marginBottom: 'var(--space-3)' }}>{f.message}</p>
)}
{evidence && (
<StateTransitionCard evidence={evidence} ruleId={f.rule_id} />
)}
</>
) : (
evidence && (
<StructuredExplanation finding={f} evidence={evidence} />
)
)}
</CollapsibleSection>
)}
{/* Taint Flow */}
{hasFlow && (
<CollapsibleSection title="Taint Flow">
<FlowTimeline steps={evidence!.flow_steps} />
</CollapsibleSection>
)}
{/* How to Fix */}
<CollapsibleSection title="How to fix">
<HowToFix finding={f} />
</CollapsibleSection>
{/* Evidence (collapsed by default — overlaps with taint flow) */}
{hasEvidence && (
<CollapsibleSection title="Evidence" defaultOpen={false}>
<EvidenceSection evidence={evidence!} skipStateCard={isState} />
</CollapsibleSection>
)}
{/* Analysis Notes */}
{hasNotes && (
<CollapsibleSection title="Analysis Notes" defaultOpen={false}>
<NotesSection evidence={evidence!} />
</CollapsibleSection>
)}
{/* Confidence Reasoning */}
{f.confidence && (
<CollapsibleSection title="Confidence Reasoning" defaultOpen={false}>
<ConfidenceSection finding={f} />
</CollapsibleSection>
)}
{/* Related Findings */}
{hasRelated && (
<CollapsibleSection title="Related Findings">
<RelatedFindings findings={f.related_findings} />
</CollapsibleSection>
)}
{/* Labels */}
{hasLabels && (
<CollapsibleSection title="Labels" defaultOpen={false}>
<div className="label-list">
{f.labels.map(([k, v], i) => (
<span key={i} className="label-item">
<span className="label-key">{k}:</span>{' '}
<span className="label-value">{v}</span>
</span>
))}
</div>
</CollapsibleSection>
)}
{/* Code Preview */}
{hasCode && (
<CollapsibleSection title="Code Preview" defaultOpen={false}>
<CodePreview
lines={f.code_context!.lines}
startLine={f.code_context!.start_line}
highlightLine={f.code_context!.highlight_line}
language={f.language}
/>
</CollapsibleSection>
)}
<CodeViewerModal
open={codeModalOpen}
onClose={() => setCodeModalOpen(false)}
finding={f}
/>
</div>
);
}