mirror of
https://github.com/elicpeter/nyx.git
synced 2026-06-06 19:35:13 +02:00
* feat: Introduce function-scoped variable interning for state analysis with new tests and fixtures * feat: Add Phase 26 symbolic execution enhancements with bitwise operator support, abstract interpretation refinements, and new taint analysis tests * feat: Refine state analysis to handle factory-pattern resource returns with mixed-path tests and leak detection enhancements * feat: Add Phase 27 debug views with symbolic execution, abstract interpretation, SSA, and call graph viewers; integrate with debug layout and styles * feat: Add Phase 31 type-qualified symbolic resolution with receiver-based callee disambiguation and testing * feat: Extend symbolic execution with state iteration, enhanced debug views, and debounced input handling * feat: Add Phase 13 resource and auth pattern extensions with new tests and fixtures * feat: Introduce CFG debug graph renderer with compact mode, toolbar, and DAG layout integration * feat: Add Phase 28 encoding and decoding transform modeling with structural symex enhancements and new taint analysis tests * feat: Extend abstract interpretation with type facts and constant value tracking in debug views and server logic * feat: Add linear path handling and witness extraction to symbolic execution with Phase 28 transform mismatch detection * feat: Refine Go auth and sanitizer handling with enhanced rules, state updates, and benchmark improvements * feat: Enable auth-state analysis by default and update relevant tests in benchmark config * test: Update state_tests to reflect default enablement of auth-state analysis and add auth suppression test * docs: update CHANGELOG.md * feat: Introduce per-index taint tracking in `HeapState` with `HeapSlot`, overflow handling, and revised SSA transfers * feat: Introduce C/C++ language labels and refine heap state tracking in SSA transfers * feat: Implement per-index array slot tracking in symbolic heap with overflow collapse * feat: Add implicit definition handling for uninitialized declarations in SSA value allocation * feat: Refactor function parameters and constants for improved clarity and maintainability * refactor: Reorder module imports and improve formatting for consistency * refactor: Fix formatting erorrs * refactor: Fix clippy warnings * refactor: Fix fmt warnings (again) * chore: Update dependencies and improve feature configuration * Add comprehensive tests for undertested modules (#36) (COPILOT) * Add comprehensive tests for undertested modules Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com> Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/f3fc877e-f386-49ba-9793-fc93d3805083 * Add comprehensive tests for ext, project, walk, and errors modules Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com> Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/f3fc877e-f386-49ba-9793-fc93d3805083 --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com> * chore: Update dependencies and improve feature configuration * fix: formatting errors in new tests * chore: Update license list in about.toml * chore: made functions input inline * chore: updated cfg graph to take up the full page * chore: add Prettier configuration and update code formatting * Add frontend test suite with Vitest (111 tests) (#37) * Add Vitest test suite for frontend - 111 tests across utils, components, hooks, and graph utilities Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com> Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/7cf0dba2-ecff-4740-ba4d-92717e74a0b7 * ci: add frontend test step to CI workflow Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com> Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/5bc0ac9f-0a32-4d03-9cb7-7a15aea53fca --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com> * chore: simplify array initialization in test files for consistency * ran typecheck * feat: add AnalysisWorkspace component and integrate it into CfgViewerPage * feat: update routing in AppLayout and improve empty state message in ExplorerPage * feat: enhance scan progress tracking with additional metrics and stages * feat: update license information and add license check script * feat: implement cross-file symbolic execution with callee body persistence * feat: replace dagre graphs with Graphology + ELK + Sigma for more advanced call stack and cfg rendering * feat: ensure CFG function view is scoped to the selected function, preventing bleed into sibling functions * feat: enhance resource tracking with proxy method summaries and improve finding extraction * feat: add terminal function exit detection for accurate resource leak analysis * feat: add warnings for loops and functions without bodies to improve error recovery * feat: update lambda expression handling to ensure proper function classification and control flow * feat: remove bounded formatting/string ops and add JSON.parse sanitizer for improved data handling * feat: add inline return taint analysis and regression tests for improved security checks * feat: add engine version management and migration handling for database schema updates * feat: enhance first_call_ident to skip nested function bodies and add regression tests * feat: enhance callee name resolution with two-segment normalization and disambiguation * feat: add cross-file context flags and debug assertions for taint analysis * feat: refactor taint analysis structure to unify context handling and improve clarity * feat: enhance dead code elimination to preserve Sink, Source, and Sanitizer labels with new tests * docs: updated CHANGELOG.md * fmt: formatting fixes * fix: fixed frontend formatting and lint warnings * fix: optimized ci * fix: optimized ci * Add comprehensive multi-file test coverage to Nyx (#38) * Initial checklist for multi-file test suite expansion Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/e550cb88-9767-4442-94d4-101bf5bb0e23 Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com> * Add 12 new multi-file test fixtures with TP/TN/near-miss coverage Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/e550cb88-9767-4442-94d4-101bf5bb0e23 Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com> * deleted root repo * rebuilt to test for regressions --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com> Co-authored-by: elipeter <elicpeter@gmail.com> * feat: enhance import alias resolution and taint tracking * feat: implement security hardening with CSRF protection and path validation * feat: add support for import alias bindings in Python, PHP, and Rust * feat: enhance CFG analysis modes and improve code readability * feat: add detection for parameterized SQL queries to enhance security * feat: add safe internal redirect handling and enhance session destroy validation * feat: implement security improvements by addressing vulnerabilities in execAsync, session management, and file downloads * feat: enhance taint detection by adding support for inline source member expressions in call arguments * feat: implement pre-emission of Source nodes for inline source member expressions in call arguments * feat: add support for Throw statement in control flow and error handling * feat: add debug and echo endpoints with potential information leakage * feat: implement internal redirect suppression and enhance taint detection * feat: implement module alias tracking for dynamic dispatch in JS/TS * feat: add authorization analysis module with Express support * feat: add authorization analysis module with Express support * feat: add tests for admin guard requirements and clean checks in authorization analysis * feat: integrate Koa and Fastify frameworks into authorization analysis * feat: add Flask and Django support to authorization analysis module * feat: add support for Rails and Sinatra frameworks in authorization analysis * feat: add support for Axum, ActixWeb, and Rocket frameworks in authorization analysis * feat: add support for ActixWeb, Axum, and Rocket frameworks in authorization analysis * feat: add support for Rails and Sinatra in authorization analysis * chore: add .DS_Store to .gitignore * refactor: simplify conditional checks and improve readability in multiple files * refactor: update usage of Option methods for improved clarity and consistency * refactor: improve code readability by simplifying conditional checks and formatting * refactor: improve code formatting and readability by simplifying conditional checks * refactor: simplify conditional checks and improve readability in multiple files * refactor: simplify conditional checks in axum.rs for improved readability * feat: add CodeQL analysis configuration for enhanced security scanning * test: add comprehensive tests for `src/output.rs` SARIF builder (#39) * chore: start test coverage improvement work Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/cd7ff398-134e-4728-a5e7-0353a0744423 Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com> * test: add comprehensive tests for src/output.rs SARIF builder Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/cd7ff398-134e-4728-a5e7-0353a0744423 Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com> * refactor: improve code formatting and readability in output.rs --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com> Co-authored-by: elipeter <elicpeter@gmail.com> * refactor: improve code formatting and readability in output.rs * Potential fix for code scanning alert no. 210: Uncontrolled data used in path expression Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> * Potential fix for code scanning alert no. 211: Uncontrolled data used in path expression Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> * refactor: enhance triage file path handling with improved error management and validation * refactor: updated func summaries for richer detail * refactor: update SSA summary extraction to use canonical FuncKey for distinct entries * refactor: enhance callee metadata structure to support arity, receiver, and qualifier for better overload resolution * refactor: add support for keyword arguments in function calls and enhance receiver extraction for method-style calls * refactor: implement new Flask routes for safe and unsafe shell command execution * refactor: separate receiver handling in SSA operations and enhance taint propagation * refactor: improve arity handling by using arg_uses for positional argument count and enhance witness scoring for tainted arguments * refactor: implement auth decorator extraction and classification for multiple languages * refactor: enhance Rust module path resolution and use map handling for cross-file disambiguation * refactor: introduce CalleeQuery struct for structured callee resolution and enhance resolver logic * refactor: implement same-file identity collision handling for `runTask` to ensure correct resolver behavior * refactor: standardize default struct initialization across multiple files * feat: add scripts for formatting checks and auto-fixes with test summaries * refactor: simplify character splitting and enhance namespace qualifier handling * refactor: improve documentation clarity and enhance code readability in resolver logic * refactor: replace default struct initialization with explicit field assignments for clarity * feat: enhance anonymous function naming by deriving context-based bindings * refactor: streamline match expressions for improved readability and performance * refactor: streamline match expressions for improved readability and performance * refactor: replace loop with while let for improved clarity and performance * feat: add SSA constant propagation support to analysis context for improved accuracy * feat: add SSA constant propagation support to analysis context for improved accuracy * feat: implement shell metacharacter validation and bounded-length checks in Rust analysis * feat: add static map analysis for command injection suppression and type safety * refactor: simplify match statements and reduce line breaks for improved readability * feat(summary): phase 1/5 SinkSite data model for primary sink-location attribution Introduce SinkSite (file_rel, line, col, snippet, cap) carrying the primary sink source-location through function summaries. Swap SsaFuncSummary.param_to_sink and FuncSummary.param_to_sink from a coarse Cap map to a deduped SmallVec<[SinkSite; 1]> per parameter, with a backward-compatible cap_sites() helper and serde defaults so pre-phase-1 on-disk rows continue to deserialise cleanly. Extraction: SinkSiteLocator bundles the tree/bytes/file_rel needed by extract_ssa_func_summary; ParsedFile::extract_ssa_artifacts wires the locator in for the persisted pass-1 path, while pass-2 intra-file transient summaries fall back to cap-only sites (behavior unchanged). Merge: GlobalSummaries::insert now unions sink sites with (file_rel, line, col, cap) dedup via shared union_param_sink_sites helper. Database: JSON-serialised summary columns carry the new shape automatically; no schema change needed. Phase 2 will consume SinkSite in build_taint_diag() to overwrite the caller-site Finding.line with the callee's sink line when resolved via summary. Phase 1 keeps behavior unchanged: scanning tests/benchmark/corpus/rust/cmdi/cmdi_indirect.rs still produces the same (wrong) line 10 finding. Adds round-trip tests covering SinkSite solo, SsaFuncSummary with sink sites, legacy-JSON default handling for both summary types, and merge dedup. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * feat(taint): phase 2/5 thread SinkSite into SsaTaintEvent and Finding Plumb Phase 1's SinkSite through the event pipeline into Findings, no output change yet. SsaTaintEvent gains `primary_sink_site: Option<SinkSite>`; when the main or callback sink-emission path has non-empty `param_to_sink_sites`, filter to sites whose `(line != 0) && (cap ∩ sink_caps != ∅)` and emit one event per distinct site — the multi-primary collapse keeps each downstream Finding single-primary. Resolution: ResolvedSummary and SinkInfo gain mirror `param_to_sink_sites` fields, populated from `SsaFuncSummary.param_to_sink` (SSA + callback paths) and `FuncSummary.param_to_sink` (global paths). Label, local-summary, and interop resolution paths leave the field empty — they only ever had cap-level info to begin with. Finding: new `primary_location: Option<SinkLocation>` with `file_rel/line/col`. `ssa_events_to_findings` maps `event.primary_sink_site` → `Finding.primary_location`, filtering cap-only sites (`line == 0`) to `None` so the (0,0) sentinel never leaks to formatters. Dedup key extended with the primary location so multi-site events aren't collapsed back together. Invariants (debug_assert!): * every SinkSite reaching emission has `line != 0 && cap ∩ sink_caps != ∅` — enforced by the pick_primary_sink_sites* filters; * every populated Finding.primary_location has `line != 0` AND non-empty `file_rel` — the cap-only → None translation upstream guarantees this. Deliberately independent of `uses_summary`: that flag tracks whether the *taint chain* used a summary, whereas primary attribution requires only that the *sink* itself was summary-resolved. A local source reaching a cross-file sink produces `uses_summary=false` alongside a populated primary_location — documented on Finding.primary_location, covered by `cross_file_sink_finding_carries_primary_location`. build_taint_diag, SARIF/JSON/explanation formatters, and the benchmark scorer remain untouched: finding.line still comes from `cfg_graph[finding.sink]`, so cmdi_indirect.rs still reports line 10 and the benchmark's rs-cmdi-003 row still shows FN in the LOC column. Tests: `cross_file_sink_finding_carries_primary_location` (proves plumbing via a synthetic FuncSummary carrying a SinkSite at 42:5) and `cross_file_sink_cap_only_site_leaves_primary_location_none` (regression guard against cap-only sites surfacing). All 1566 lib tests + integration tests pass. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat(output): phase 3/5 consume primary sink location in diag + SARIF When a finding's primary_location (populated in phase 2 from a callee summary's SinkSite) names the dangerous instruction inside a callee body, attribute the diagnostic line to that location instead of the caller's call site. The call site is demoted to a Call step in flow_steps, and a synthetic Sink step at the primary location is appended so analysts still see the full trace. Changes: - Add scan_root parameter to build_taint_diag so file_rel can be resolved back to an absolute path via a shared resolve_file_rel helper. Empty file_rel (single-file scans where namespace == "") resolves to the file under analysis. - Extend SinkLocation with snippet, carried from the upstream SinkSite so the formatter needs no second file read. - Relax the ssa_events_to_findings debug_assert to allow empty file_rel, which is valid when scan root equals the file itself. - SARIF: emit data-flow as codeFlows[0].threadFlows[0].locations[]; locations[0] already reflects the primary sink position via the updated diag line/col. Acceptance: scan on tests/benchmark/corpus/rust/cmdi/cmdi_indirect.rs now reports line 5 (Command::new) as the primary sink, with the call site at line 10 visible in flow_steps. Two expect.json fixtures updated (must_match line_range widened): - javascript/taint/context_sensitive_call: 12-14 -> 7-14 (line 8 is the real sink inside run()). - rust/cfg/closure_async: 10-10 -> 10-11 (line 11 is Command::new inside the closure). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat(bench): phase 4/5 validate primary sink attribution across corpus Extend the benchmark scorer and ground truth to lock in phase 3's primary-location behavior, and add fixtures that exercise the new capability end-to-end. Scorer (tests/benchmark_test.rs): - Add optional `expected_call_site_lines: Option<Vec<[usize; 2]>>` on Case. When present, score_location_level additionally requires at least one flow_step in the finding's evidence trace to fall within ±2 of the call-site range. When absent, the check is skipped — fully forward-compatible with existing fixtures. - Retain ±2 tolerance on expected_sink_lines (compared against the now-primary Diag.line post-phase-3). Ground truth edits: - rs-cmdi-cross-001: expected_sink_lines [8,8] -> [9,9]. Line 8 is the transform::wrap call site (a cross-file propagator, not a sink); line 9 is Command::new, the real sink. The ±2 tolerance happened to mask this stale attribution but it was semantically wrong — phase 4 is the right time to correct it. Also adds expected_call_site_lines [8,8] so the new field is exercised on an existing cross-file case. - rs-cmdi-003: adds expected_call_site_lines [10,10] (run_cmd call). This fixture's sink (Command::new inside run_cmd at line 5) was the motivating case for phases 1-3; adding the call-site assertion guards against regression to caller-line attribution. New fixtures: - rust/cmdi/cmdi_indirect_multisink.rs (rs-cmdi-009): helper run_both takes two tainted params and invokes two Command sinks on consecutive lines. Locks in that primary line lands inside the helper (lines 5-6), not at the caller (line 12). Notes document that SinkSite is currently one-per-callee so both findings today collapse onto the first sink; expected_sink_lines=[5,6] and expected_call_site_lines=[12,12] stay valid either way. - python/cmdi/cross_indirect_sink/{app.py,helper.py} (py-cmdi-cross- 004): sink os.system lives in helper.py (cross-file), caller in app.py reads env source and calls run_cmd. Verifies phase 3's cross-file primary attribution: Diag.path = helper.py, Diag.line = 5, with app.py:7 recorded in flow_steps as a Call step. Acceptance: - `cargo test --test benchmark_test -- --ignored --nocapture` passes. - rs-cmdi-003 is TP/TP/TP (the target flip FN->TP at LOC). All pre-existing TP/TP/TP fixtures remain TP/TP/TP; 2 new fixtures are TP/TP/TP. - Aggregate rule-level: TP=158 FP=10 FN=1 TN=97, P=0.940 R=0.994 F1=0.966 on the 266-case corpus (was TP=156 FP=10 FN=1 TN=97 on 264 pre-phase-4, delta is the +2 new cases both resolving TP). - Full `cargo test` green (1566 lib tests + all integration tests). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat(taint): phase 5/5 lock Finding.primary_location contract via regression test Add a regression test in src/taint/ssa_transfer.rs that wires up a synthetic SsaFuncSummary with a SinkSite at other.rs:42:10 and drives the three emission stages (pick_primary_sink_sites → emit_ssa_taint_events → ssa_events_to_findings) against a minimal caller SSA body. Asserts the resulting Finding.primary_location is exactly that triple. The existing integration tests in src/taint/tests.rs cover the coarse FuncSummary path end-to-end through analyse_file. This test locks in the lower-level SSA-side plumbing so a future refactor that silently drops the site between pick → emit → findings fails here rather than only at the benchmark layer. Also refreshes tests/benchmark/results/latest.json (timestamp only; rs-cmdi-003 remains TP/TP/TP and the aggregate P/R/F1 are unchanged from phase 4). Closes the primary sink-location attribution feature (phases 1-5/5): * Phase 1 — SinkSite data model on summaries. * Phase 2 — SinkSite threaded into SsaTaintEvent and Finding. * Phase 3 — diag + SARIF consume primary_location. * Phase 4 — benchmark validates primary_call_site_lines across corpus. * Phase 5 — regression test locks the event→finding contract. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * refactor: clean up formatting and improve readability in multiple files * refactor: simplify type definition for deduplication key in findings * test(harness): add must_not_match expectation for FP regression guards Extends ExpectedFinding with must_not_match field that asserts a diagnostic must NOT fire — presence is a hard failure. Non-consuming scan so it coexists with must_match entries on the same rule_id. Adds forbidden_violations accumulator and updates summary line. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat(regression): update expectations to ensure must_not_match for various taint and resource leak rules * feat: implement auto-seeding for JS/TS handler parameters to enhance taint tracking * feat: update switch statement handling to improve control flow analysis * feat: implement promisify alias handling for JS/TS to enhance taint tracking * feat: enhance taint tracking by refining expectation handling and adding mode filtering * feat: refine SQL handling in stream processing and enhance auto-seeding for handler parameters * feat: update taint tracking rules to enforce full mode matching and improve flow analysis * feat: enhance Ruby subshell handling to improve taint tracking and flow analysis * feat: update xss_response expectations to refine taint flow analysis and enhance regression guarding * feat: refine framework detection and update expectation handling for Echo and Sinatra * feat: implement max_count for taint tracking expectations and deduplicate findings * feat: add strict_unexpected handling for taint-unsanitised-flow in expectation files * feat: enhance deduplication of taint-unsanitised-flow findings by collapsing based on line and severity * feat: add strict_unexpected handling for taint-unsanitised-flow in multiple expectation files * feat: add structural invariant checks for SSA bodies * feat: ensure deterministic phi emission order using BTreeSet * feat: enhance handling of terminators to ensure authoritative flow through successor edges * feat: enhance Goto terminator handling to ensure all successors are marked executable * feat: refactor code for improved readability and organization * feat: simplify predicate checks and enhance readability in SSA handling * feat: implement per-file parse timeout and enhance file size handling * feat: migrate analysis engine toggles from environment variables to configuration file * feat: remove unnecessary whitespace in hostile_input_tests.rs * feat: remove unnecessary whitespace in hostile_input_tests.rs * feat: update dependencies and enhance documentation on language maturity * feat: enhance security headers and improve request body limits * feat: implement sink capability bits for deduplication and enhance evidence tagging * feat: implement dynamic activation handling for gated sinks and enhance validation logic * feat: enhance configuration documentation and clarify inline analysis cache behavior * feat: implement panic recovery during analysis to continue scans past errors * feat: add expectations configuration for taint analysis and performance metrics * feat: enhance error handling and logging during file reading and mutex locking * feat: add cross-file body loading tests and plumbing for CF-1 phase * feat: implement cross-file k=1 context-sensitive inline taint analysis with new tests and fixtures * feat: implement indexed-scan parity in cross-file inline analysis with new dropdown and copy functionality * feat: enhance classification span handling in CFG and AST for improved source attribution * feat: add new Express routes for handling user input and telemetry data * feat: implement ternary expression handling in CFG with diamond structure for JS/TS * feat: implement Phase CF-3 abstract-domain transfer channels in summaries * feat: add support for string-prefix transfer in cross-file calls and update tests * docs: reduce RESULTS.md doc size * feat: implement Phase CF-4 per-return-path summary decomposition with tests * feat: update parameter handling in pass1 and refactor SsaFuncSummary initialization * feat: implement Phase CF-5 for cross-file SCC joint fixed-point convergence with new flags and tests * feat: implement Phase CF-6 with parameter-granularity points-to summaries and associated tests * refactor: update comments and documentation for clarity and consistency * style: format code for consistency and readability * refactor: simplify verdict handling and improve edge checking logic * refactor: optimize path and identifier collection by avoiding unnecessary cloning * chore: update Cargo.toml for Rust version 1.85 and add ignored files; modify CHANGELOG and README for clarity on state analysis defaults * refactor: update documentation and improve clarity in configuration files * refactor: update documentation and improve clarity in configuration files * feat: add JS/TS pass-2 convergence tests and expectations configuration * feat: add Phase 5 regression tests for inline cache origin attribution and update related logic * feat: implement Phase 7 deduplication and alternative path linking for taint findings * feat: implement structural DFS index for anonymous functions and update naming conventions * feat: add Phase 8 regression tests for container-element taint in JS and Python * feat: add engine-depth profiles and explain-engine option for CLI * feat: update expectations and add new README fixtures for multi-file scan regression * feat: implement Phase 11 callback-alias and factory patterns with regression tests * feat: implement Terminator::Switch for multi-way dispatch and add regression tests * feat: add real-CVE benchmark fixtures for CVE-2023-48022, CVE-2019-14939, and CVE-2023-26159 with corresponding patched variants * refactor: extract cfg and ssa_transfer to submodules * refactor: cargo fmt * refactor: remove unnecessary blank line in cfg_tests.rs * refactor: remove unnecessary planning file * chore: update Rust version to 1.88 and bump dependencies in Cargo files * feat: enhance triage UI with new layout and controls, update README for clarity * feat: enhance triage UI with new layout and controls, update README for clarity * chore: remove outdated section from README for version 0.5.0 * docs: improve clarity and consistency in README content * chore: add "GPL-3.0-or-later" to license options in about.toml * chore: update license handling in about.toml and check-licenses.mjs * style: format code for improved readability in TriagePage component * style: format code for improved readability in TriagePage component * chore: enhance license handling and improve body_id scoping in seed lookup * feat: introduce owner and parent body IDs for enhanced seed scoping * feat: implement direction-aware engine provenance with new CLI flag for strict CI gating * feat: add Undef SSA operation for improved control-flow handling * style: improve code formatting for consistency and readability in multiple files * feat: add 16-function chain SCC across multiple files for enhanced analysis * style: simplify code formatting for improved readability in multiple files * fix: update CapHitReason default implementation and improve README clarity * docs: enhance README with detailed explanations of taint analysis and limitations * docs: refine README for clarity and consistency in taint analysis section * style: improve code formatting for better readability in NewScanModal and scans * fix: update cargo-about command to use --offline for deterministic license generation * fix: update cargo-about command to use --offline for deterministic license generation * ci: add step to prime cargo registry cache for deterministic license generation * feat: add support for non-sink collections in authorization analysis * feat: enhance authorization checks with row-level ownership equality and binding tracking * feat: implement self-scoped user handling and enhance ownership checks * refactor: simplify assertions and formatting in authorization analysis tests * fix: normalize line endings in THIRDPARTY-LICENSES.html generation and update README with AI disclosure * docs: update AI disclosure section for clarity and conciseness * feat: add AI Contribution Policy and update contributing guidelines for AI assistance disclosure * feat: enhance authorization analysis with SSA-derived variable type classification * feat: implement auth_finding_to_diag function for enhanced security diagnostics * feat: add args_value_refs to CallSite struct for enhanced argument tracking * feat: add args_value_refs to CallSite struct for enhanced argument tracking * feat: add direction-aware engine provenance with LossDirection classification and new CLI flag * feat: simplify strip_cap_from_call_args call by removing unnecessary line breaks * feat: enhance error message handling in cli_validation_tests for better Windows compatibility * feat: optimize release profile settings in Cargo.toml and update CodeQL configuration * feat: enhance release build process with SBOM generation and SLSA provenance * feat: update actions/checkout and actions/setup-node to v6, enhance CLI options, and improve auth-check summaries * feat: introduce PathFact handling for path safety checks and rejection logic * feat: introduce PathFact handling for path safety checks and rejection logic * feat: update benchmark data and enhance path sanitization logic with new safety checks * feat: document AI assistance in frontend UI development and human review process * feat: add return path facts for enhanced path safety checks and update documentation * chore: update release date for version 0.5.0 in CHANGELOG.md * chore: clean up ci.yml by removing outdated comments and clarifying steps * feat: implement cross-language path sanitizers and validators for enhanced security * feat: enhance SSA value usage tracking by including block terminators and improve path safety checks * feat: enhance switch statement handling by adding per-case path constraints and support for exclusive cases * refactor: simplify conditional formatting and improve code readability in executor and lower modules * feat: add vulnerable examples for various languages demonstrating authentication and sanitization issues * feat: enhance actor context recognition for self-actor identifiers and add support for global non-sink receivers * feat: enhance actor context recognition for self-actor identifiers and add support for global non-sink receivers * feat: add transform classifiers for Java, Go, and Ruby with corresponding tests * refactor: clarify comments on reassign-to-constant idiom and sink behavior in guards.rs --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
1051 lines
28 KiB
Rust
1051 lines
28 KiB
Rust
mod common;
|
|
|
|
use nyx_scanner::commands::scan::Diag;
|
|
use nyx_scanner::utils::config::AnalysisMode;
|
|
use std::path::PathBuf;
|
|
use std::sync::OnceLock;
|
|
|
|
fn auth_fixture_dir() -> PathBuf {
|
|
PathBuf::from(env!("CARGO_MANIFEST_DIR"))
|
|
.join("tests")
|
|
.join("fixtures")
|
|
.join("auth_analysis")
|
|
}
|
|
|
|
fn scan_all_fixtures() -> &'static Vec<Diag> {
|
|
static DIAGS: OnceLock<Vec<Diag>> = OnceLock::new();
|
|
DIAGS.get_or_init(|| {
|
|
let cfg = common::test_config(AnalysisMode::Full);
|
|
nyx_scanner::scan_no_index(&auth_fixture_dir(), &cfg).expect("scan should succeed")
|
|
})
|
|
}
|
|
|
|
fn auth_diags_for(filename: &str) -> Vec<&'static Diag> {
|
|
scan_all_fixtures()
|
|
.iter()
|
|
.filter(|d| {
|
|
d.path.contains(filename)
|
|
&& (d.id.starts_with("js.auth.")
|
|
|| d.id.starts_with("py.auth.")
|
|
|| d.id.starts_with("rb.auth.")
|
|
|| d.id.starts_with("go.auth.")
|
|
|| d.id.starts_with("java.auth.")
|
|
|| d.id.starts_with("rs.auth."))
|
|
})
|
|
.collect()
|
|
}
|
|
|
|
fn auth_ids_for(filename: &str) -> Vec<String> {
|
|
auth_diags_for(filename)
|
|
.iter()
|
|
.map(|diag| diag.id.clone())
|
|
.collect()
|
|
}
|
|
|
|
fn assert_has(filename: &str, rule_id: &str) {
|
|
assert!(
|
|
auth_diags_for(filename)
|
|
.iter()
|
|
.any(|diag| diag.id == rule_id),
|
|
"Expected {rule_id} in {filename}.\n Got: {:?}",
|
|
auth_ids_for(filename)
|
|
);
|
|
}
|
|
|
|
fn assert_absent(filename: &str, rule_id: &str) {
|
|
assert!(
|
|
auth_diags_for(filename)
|
|
.iter()
|
|
.all(|diag| diag.id != rule_id),
|
|
"Did not expect {rule_id} in {filename}.\n Got: {:?}",
|
|
auth_ids_for(filename)
|
|
);
|
|
}
|
|
|
|
fn assert_no_auth_diags_for(diags: &[Diag], filename: &str) {
|
|
let matching: Vec<_> = diags
|
|
.iter()
|
|
.filter(|diag| {
|
|
diag.path.contains(filename)
|
|
&& (diag.id.starts_with("js.auth.")
|
|
|| diag.id.starts_with("py.auth.")
|
|
|| diag.id.starts_with("rb.auth.")
|
|
|| diag.id.starts_with("go.auth.")
|
|
|| diag.id.starts_with("java.auth.")
|
|
|| diag.id.starts_with("rs.auth."))
|
|
})
|
|
.map(|diag| diag.id.clone())
|
|
.collect();
|
|
assert!(
|
|
matching.is_empty(),
|
|
"Did not expect auth findings in {filename}.\n Got: {:?}",
|
|
matching
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn admin_route_missing_admin_check() {
|
|
assert_has(
|
|
"admin_route_missing.js",
|
|
"js.auth.admin_route_missing_admin_check",
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn admin_route_with_admin_guard_is_clean() {
|
|
assert_absent(
|
|
"admin_route_clean.js",
|
|
"js.auth.admin_route_missing_admin_check",
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn support_impersonation_requires_admin_guard() {
|
|
assert_has(
|
|
"support_impersonation_missing.js",
|
|
"js.auth.admin_route_missing_admin_check",
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn debug_session_requires_admin_guard() {
|
|
assert_has(
|
|
"debug_session_missing.js",
|
|
"js.auth.admin_route_missing_admin_check",
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn koa_admin_route_missing_admin_check() {
|
|
assert_has(
|
|
"koa_admin_route_missing.js",
|
|
"js.auth.admin_route_missing_admin_check",
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn koa_admin_route_with_admin_guard_is_clean() {
|
|
assert_absent(
|
|
"koa_admin_route_clean.js",
|
|
"js.auth.admin_route_missing_admin_check",
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn fastify_admin_route_missing_admin_check() {
|
|
assert_has(
|
|
"fastify_admin_route_missing.js",
|
|
"js.auth.admin_route_missing_admin_check",
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn fastify_admin_route_with_admin_guard_is_clean() {
|
|
assert_absent(
|
|
"fastify_admin_route_clean.js",
|
|
"js.auth.admin_route_missing_admin_check",
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn scoped_read_without_membership_check() {
|
|
assert_has("scoped_read_missing.js", "js.auth.missing_ownership_check");
|
|
}
|
|
|
|
#[test]
|
|
fn scoped_write_without_membership_check() {
|
|
assert_has("scoped_write_missing.js", "js.auth.missing_ownership_check");
|
|
}
|
|
|
|
#[test]
|
|
fn koa_scoped_read_without_membership_check() {
|
|
assert_has(
|
|
"koa_scoped_read_missing.js",
|
|
"js.auth.missing_ownership_check",
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn koa_scoped_read_with_ownership_check_is_clean() {
|
|
assert_absent(
|
|
"koa_scoped_read_clean.js",
|
|
"js.auth.missing_ownership_check",
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn fastify_scoped_write_without_membership_check() {
|
|
assert_has(
|
|
"fastify_scoped_write_missing.js",
|
|
"js.auth.missing_ownership_check",
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn fastify_scoped_write_with_ownership_check_is_clean() {
|
|
assert_absent(
|
|
"fastify_scoped_write_clean.js",
|
|
"js.auth.missing_ownership_check",
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn koa_route_registration_noise_is_clean() {
|
|
assert!(auth_diags_for("koa_route_registration_noise.js").is_empty());
|
|
}
|
|
|
|
#[test]
|
|
fn fastify_route_registration_noise_is_clean() {
|
|
assert!(auth_diags_for("fastify_route_registration_noise.js").is_empty());
|
|
}
|
|
|
|
#[test]
|
|
fn self_profile_read_is_clean() {
|
|
assert_absent("self_profile_read.js", "js.auth.missing_ownership_check");
|
|
}
|
|
|
|
#[test]
|
|
fn self_profile_update_is_clean() {
|
|
assert_absent("self_profile_update.js", "js.auth.missing_ownership_check");
|
|
assert_absent("self_profile_update.js", "js.auth.stale_authorization");
|
|
}
|
|
|
|
#[test]
|
|
fn current_user_listing_is_clean() {
|
|
assert_absent(
|
|
"dashboard_self_listing.js",
|
|
"js.auth.missing_ownership_check",
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn auth_helper_lookup_is_clean() {
|
|
assert_absent("membership_helper.js", "js.auth.missing_ownership_check");
|
|
}
|
|
|
|
#[test]
|
|
fn delegated_service_read_is_clean() {
|
|
assert_absent(
|
|
"delegated_service_read.js",
|
|
"js.auth.missing_ownership_check",
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn related_membership_check_covers_child_reads() {
|
|
assert_absent(
|
|
"related_membership_check.js",
|
|
"js.auth.missing_ownership_check",
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn workspace_job_body_id_without_check() {
|
|
assert_has(
|
|
"workspace_job_missing.js",
|
|
"js.auth.missing_ownership_check",
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn service_function_without_auth_context_or_check() {
|
|
assert_has(
|
|
"service_missing_context.js",
|
|
"js.auth.missing_ownership_check",
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn service_function_with_ownership_check_is_clean() {
|
|
assert_absent("service_with_check.js", "js.auth.missing_ownership_check");
|
|
}
|
|
|
|
#[test]
|
|
fn stale_session_backed_mutation() {
|
|
assert_has("stale_session_mutation.js", "js.auth.stale_authorization");
|
|
}
|
|
|
|
#[test]
|
|
fn partial_batch_authorization_detected() {
|
|
assert_has("partial_batch.js", "js.auth.partial_batch_authorization");
|
|
}
|
|
|
|
#[test]
|
|
fn token_flow_missing_expiry_check() {
|
|
assert_has(
|
|
"token_missing_expiry.js",
|
|
"js.auth.token_override_without_validation",
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn token_flow_missing_recipient_check() {
|
|
assert_has(
|
|
"token_missing_recipient.js",
|
|
"js.auth.token_override_without_validation",
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn token_flow_workspace_override_detected() {
|
|
assert_has(
|
|
"token_workspace_override.js",
|
|
"js.auth.token_override_without_validation",
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn token_flow_role_override_detected() {
|
|
assert_has(
|
|
"token_role_override.js",
|
|
"js.auth.token_override_without_validation",
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn clean_token_acceptance_is_clean() {
|
|
assert_absent(
|
|
"token_clean.js",
|
|
"js.auth.token_override_without_validation",
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn partial_batch_with_full_collection_authorization_is_clean() {
|
|
assert_absent(
|
|
"partial_batch_full_check_clean.js",
|
|
"js.auth.partial_batch_authorization",
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn typescript_auth_findings_use_javascript_prefix() {
|
|
assert_has(
|
|
"typed_admin_route_missing.ts",
|
|
"js.auth.admin_route_missing_admin_check",
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn flask_admin_route_missing_admin_check() {
|
|
assert_has(
|
|
"flask_admin_route_missing.py",
|
|
"py.auth.admin_route_missing_admin_check",
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn flask_admin_route_with_admin_guard_is_clean() {
|
|
assert_absent(
|
|
"flask_admin_route_clean.py",
|
|
"py.auth.admin_route_missing_admin_check",
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn flask_scoped_write_without_membership_check() {
|
|
assert_has(
|
|
"flask_scoped_write_missing.py",
|
|
"py.auth.missing_ownership_check",
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn flask_clean_token_acceptance_is_clean() {
|
|
assert_absent(
|
|
"flask_token_clean.py",
|
|
"py.auth.token_override_without_validation",
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn django_view_admin_route_missing_admin_check() {
|
|
assert_has(
|
|
"django_view_admin_missing.py",
|
|
"py.auth.admin_route_missing_admin_check",
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn django_view_admin_route_with_permission_guard_is_clean() {
|
|
assert_absent(
|
|
"django_view_admin_clean.py",
|
|
"py.auth.admin_route_missing_admin_check",
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn django_scoped_read_without_membership_check() {
|
|
assert_has(
|
|
"django_scoped_read_missing.py",
|
|
"py.auth.missing_ownership_check",
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn django_cbv_admin_route_with_permission_mixin_is_clean() {
|
|
assert_absent(
|
|
"django_cbv_admin_clean.py",
|
|
"py.auth.admin_route_missing_admin_check",
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn django_cbv_scoped_write_without_membership_check() {
|
|
assert_has(
|
|
"django_cbv_scoped_write_missing.py",
|
|
"py.auth.missing_ownership_check",
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn django_partial_batch_authorization_detected() {
|
|
assert_has(
|
|
"django_partial_batch.py",
|
|
"py.auth.partial_batch_authorization",
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn django_stale_session_backed_mutation() {
|
|
assert_has(
|
|
"django_stale_session_mutation.py",
|
|
"py.auth.stale_authorization",
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn django_token_flow_missing_expiry_check() {
|
|
assert_has(
|
|
"django_token_missing_expiry.py",
|
|
"py.auth.token_override_without_validation",
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn django_token_flow_missing_recipient_check() {
|
|
assert_has(
|
|
"django_token_missing_recipient.py",
|
|
"py.auth.token_override_without_validation",
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn rails_admin_route_missing_admin_check() {
|
|
assert_has(
|
|
"rails_admin_route_missing.rb",
|
|
"rb.auth.admin_route_missing_admin_check",
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn rails_admin_route_with_admin_guard_is_clean() {
|
|
assert_absent(
|
|
"rails_admin_route_clean.rb",
|
|
"rb.auth.admin_route_missing_admin_check",
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn rails_scoped_write_without_membership_check() {
|
|
assert_has(
|
|
"rails_scoped_write_missing.rb",
|
|
"rb.auth.missing_ownership_check",
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn rails_clean_controller_action_with_before_action_auth_is_clean() {
|
|
assert_absent(
|
|
"rails_clean_before_action.rb",
|
|
"rb.auth.missing_ownership_check",
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn rails_partial_batch_authorization_detected() {
|
|
assert_has(
|
|
"rails_partial_batch.rb",
|
|
"rb.auth.partial_batch_authorization",
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn rails_stale_session_backed_mutation() {
|
|
assert_has(
|
|
"rails_stale_session_mutation.rb",
|
|
"rb.auth.stale_authorization",
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn rails_token_flow_missing_expiry_check() {
|
|
assert_has(
|
|
"rails_token_missing_expiry.rb",
|
|
"rb.auth.token_override_without_validation",
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn rails_clean_token_acceptance_is_clean() {
|
|
assert_absent(
|
|
"rails_token_clean.rb",
|
|
"rb.auth.token_override_without_validation",
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn sinatra_admin_route_missing_admin_check() {
|
|
assert_has(
|
|
"sinatra_admin_route_missing.rb",
|
|
"rb.auth.admin_route_missing_admin_check",
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn sinatra_admin_route_with_admin_guard_is_clean() {
|
|
assert_absent(
|
|
"sinatra_admin_route_clean.rb",
|
|
"rb.auth.admin_route_missing_admin_check",
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn sinatra_scoped_read_without_membership_check() {
|
|
assert_has(
|
|
"sinatra_scoped_read_missing.rb",
|
|
"rb.auth.missing_ownership_check",
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn sinatra_scoped_read_with_membership_check_is_clean() {
|
|
assert_absent(
|
|
"sinatra_scoped_read_clean.rb",
|
|
"rb.auth.missing_ownership_check",
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn sinatra_token_flow_missing_recipient_check() {
|
|
assert_has(
|
|
"sinatra_token_missing_recipient.rb",
|
|
"rb.auth.token_override_without_validation",
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn gin_admin_route_missing_admin_check() {
|
|
assert_has(
|
|
"gin_admin_route_missing.go",
|
|
"go.auth.admin_route_missing_admin_check",
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn gin_scoped_write_with_ownership_check_is_clean() {
|
|
assert_absent(
|
|
"gin_scoped_write_clean.go",
|
|
"go.auth.missing_ownership_check",
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn gin_stale_session_backed_mutation() {
|
|
assert_has(
|
|
"gin_stale_session_mutation.go",
|
|
"go.auth.stale_authorization",
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn echo_admin_route_with_admin_guard_is_clean() {
|
|
assert_absent(
|
|
"echo_admin_route_clean.go",
|
|
"go.auth.admin_route_missing_admin_check",
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn echo_partial_batch_authorization_detected() {
|
|
assert_has(
|
|
"echo_partial_batch.go",
|
|
"go.auth.partial_batch_authorization",
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn echo_token_flow_missing_recipient_check() {
|
|
assert_has(
|
|
"echo_token_missing_recipient.go",
|
|
"go.auth.token_override_without_validation",
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn spring_admin_route_missing_admin_check() {
|
|
assert_has(
|
|
"spring_admin_route_missing.java",
|
|
"java.auth.admin_route_missing_admin_check",
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn spring_admin_route_with_annotation_guard_is_clean() {
|
|
assert_absent(
|
|
"spring_admin_route_clean.java",
|
|
"java.auth.admin_route_missing_admin_check",
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn spring_scoped_read_without_membership_check() {
|
|
assert_has(
|
|
"spring_scoped_read_missing.java",
|
|
"java.auth.missing_ownership_check",
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn axum_admin_route_missing_admin_check() {
|
|
assert_has(
|
|
"axum_admin_route_missing.rs",
|
|
"rs.auth.admin_route_missing_admin_check",
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn axum_admin_route_with_admin_guard_is_clean() {
|
|
assert_absent(
|
|
"axum_admin_route_clean.rs",
|
|
"rs.auth.admin_route_missing_admin_check",
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn axum_partial_batch_authorization_detected() {
|
|
assert_has(
|
|
"axum_partial_batch.rs",
|
|
"rs.auth.partial_batch_authorization",
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn actix_scoped_write_without_membership_check() {
|
|
assert_has(
|
|
"actix_scoped_write_missing.rs",
|
|
"rs.auth.missing_ownership_check",
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn hashmap_local_noise_is_clean() {
|
|
// std::collections method calls on locally-constructed
|
|
// HashMap/HashSet bindings should not be treated as
|
|
// authorization-relevant Read/Mutation operations.
|
|
assert_absent("hashmap_local_noise.rs", "rs.auth.missing_ownership_check");
|
|
}
|
|
|
|
#[test]
|
|
fn row_ownership_equality_is_clean() {
|
|
// `if owner_id != user.id { return ... }` is a row-level
|
|
// ownership check — both the row-fetching call and any downstream
|
|
// uses of the row's fields should be considered authorized.
|
|
assert_absent(
|
|
"row_ownership_equality.rs",
|
|
"rs.auth.missing_ownership_check",
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn row_ownership_no_early_exit_flags() {
|
|
// Regression guard: equality check without an early exit has no
|
|
// effect, so the downstream mutation should still flag.
|
|
assert_has(
|
|
"row_ownership_no_early_exit.rs",
|
|
"rs.auth.missing_ownership_check",
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn helper_scoped_params_is_clean() {
|
|
// A library helper whose internal work is `result.insert(..)`
|
|
// on a locally-constructed HashSet is not a sink — the call is
|
|
// classified as non-sink because the receiver is the locally-bound
|
|
// collection.
|
|
assert_absent("helper_scoped_params.rs", "rs.auth.missing_ownership_check");
|
|
}
|
|
|
|
#[test]
|
|
fn self_scoped_user_is_clean() {
|
|
// `let user = auth::require_auth(..).await?` binds the
|
|
// authenticated caller, so `user.id` passed to a helper is self-
|
|
// referential rather than a foreign scoped id.
|
|
assert_absent("self_scoped_user.rs", "rs.auth.missing_ownership_check");
|
|
}
|
|
|
|
#[test]
|
|
fn true_positive_missing_check_flags() {
|
|
// Positive control: an authenticated handler that deletes a doc
|
|
// and publishes against a group without any ownership/membership
|
|
// check — must still flag.
|
|
assert_has(
|
|
"true_positive_missing_check.rs",
|
|
"rs.auth.missing_ownership_check",
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn helper_no_auth_lift_still_flags() {
|
|
// Regression guard: a helper that doesn't auth-check its
|
|
// parameter must NOT have a synthetic AuthCheck synthesised at
|
|
// its call site.
|
|
assert_has("helper_no_auth_lift.rs", "rs.auth.missing_ownership_check");
|
|
}
|
|
|
|
#[test]
|
|
fn transitive_helper_is_clean() {
|
|
// `validate_target(&db, group_id, user.id)` is a helper that
|
|
// internally calls `authz::require_group_member` against
|
|
// `group_id`. Helper-summary lifting should synthesise an
|
|
// AuthCheck at the handler's call site covering `group_id`, so
|
|
// the subsequent `db.exec("INSERT INTO comments …", &[group_id])`
|
|
// MUST NOT flag.
|
|
assert_absent("transitive_helper.rs", "rs.auth.missing_ownership_check");
|
|
}
|
|
|
|
#[test]
|
|
fn cross_file_helper_is_clean() {
|
|
// `require_owner(&user, &row)` is declared in
|
|
// `cross_file_helper_authz.rs` and called from
|
|
// `cross_file_helper_handler.rs`. Cross-file helper-summary
|
|
// lifting must synthesise an AuthCheck at the handler's call
|
|
// site covering `row`, so the downstream `db.update(..)` must
|
|
// NOT flag as `rs.auth.missing_ownership_check`.
|
|
assert_absent(
|
|
"cross_file_helper_handler.rs",
|
|
"rs.auth.missing_ownership_check",
|
|
);
|
|
// The helper itself is a free function returning `Result<(), ()>`;
|
|
// it performs no sensitive operation and should produce no auth
|
|
// findings.
|
|
assert_absent(
|
|
"cross_file_helper_authz.rs",
|
|
"rs.auth.missing_ownership_check",
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn sql_no_acl_join_flags() {
|
|
// Regression guard: a JOIN against a non-ACL table (`audit_log`,
|
|
// not in the configured ACL list) does NOT prove caller ownership
|
|
// even when the WHERE clause names `user_id`. The downstream
|
|
// realtime publish must still flag.
|
|
assert_has(
|
|
"sql_no_acl_join_flags.rs",
|
|
"rs.auth.missing_ownership_check",
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn sql_join_acl_is_clean() {
|
|
// A SELECT that JOINs through the configured `group_members`
|
|
// ACL table and pins rows via `WHERE gm.user_id = ?1` is auth-gated.
|
|
// Downstream uses of the returned columns (`group_id` here) are
|
|
// covered by the synthesised SQL `AuthCheck`, so the realtime
|
|
// publish call MUST NOT flag.
|
|
assert_absent("sql_join_acl.rs", "rs.auth.missing_ownership_check");
|
|
}
|
|
|
|
#[test]
|
|
fn db_connection_type_inferred_is_clean() {
|
|
// `let conn = rusqlite::Connection::open(..).unwrap();` is
|
|
// inferred as a `DatabaseConnection` via SSA `constructor_type`
|
|
// (through `peel_identity_suffix`). The handler logs the caller's
|
|
// own id; no foreign scoped id reaches the sink, so the ownership
|
|
// gate has nothing to flag — the type-facts refinement must not
|
|
// introduce a false positive here.
|
|
assert_absent(
|
|
"db_connection_type_inferred.rs",
|
|
"rs.auth.missing_ownership_check",
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn actix_admin_route_with_admin_guard_is_clean() {
|
|
assert_absent(
|
|
"actix_admin_route_clean.rs",
|
|
"rs.auth.admin_route_missing_admin_check",
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn rocket_admin_route_with_guard_is_clean() {
|
|
assert_absent(
|
|
"rocket_admin_route_clean.rs",
|
|
"rs.auth.admin_route_missing_admin_check",
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn rocket_stale_session_backed_mutation() {
|
|
assert_has(
|
|
"rocket_stale_session_mutation.rs",
|
|
"rs.auth.stale_authorization",
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn rocket_token_flow_missing_recipient_check() {
|
|
assert_has(
|
|
"rocket_token_missing_recipient.rs",
|
|
"rs.auth.token_override_without_validation",
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn generic_admin_route_check_is_consistent_across_languages() {
|
|
for (filename, rule_id) in [
|
|
(
|
|
"admin_route_missing.js",
|
|
"js.auth.admin_route_missing_admin_check",
|
|
),
|
|
(
|
|
"flask_admin_route_missing.py",
|
|
"py.auth.admin_route_missing_admin_check",
|
|
),
|
|
(
|
|
"rails_admin_route_missing.rb",
|
|
"rb.auth.admin_route_missing_admin_check",
|
|
),
|
|
(
|
|
"gin_admin_route_missing.go",
|
|
"go.auth.admin_route_missing_admin_check",
|
|
),
|
|
(
|
|
"spring_admin_route_missing.java",
|
|
"java.auth.admin_route_missing_admin_check",
|
|
),
|
|
(
|
|
"axum_admin_route_missing.rs",
|
|
"rs.auth.admin_route_missing_admin_check",
|
|
),
|
|
] {
|
|
assert_has(filename, rule_id);
|
|
}
|
|
}
|
|
|
|
#[test]
|
|
fn generic_ownership_check_is_consistent_across_languages() {
|
|
for (filename, rule_id) in [
|
|
("scoped_write_missing.js", "js.auth.missing_ownership_check"),
|
|
(
|
|
"django_scoped_read_missing.py",
|
|
"py.auth.missing_ownership_check",
|
|
),
|
|
(
|
|
"rails_scoped_write_missing.rb",
|
|
"rb.auth.missing_ownership_check",
|
|
),
|
|
(
|
|
"spring_scoped_read_missing.java",
|
|
"java.auth.missing_ownership_check",
|
|
),
|
|
(
|
|
"actix_scoped_write_missing.rs",
|
|
"rs.auth.missing_ownership_check",
|
|
),
|
|
] {
|
|
assert_has(filename, rule_id);
|
|
}
|
|
}
|
|
|
|
#[test]
|
|
fn auth_analysis_runs_in_ast_mode() {
|
|
let cfg = common::test_config(AnalysisMode::Ast);
|
|
let diags = nyx_scanner::scan_no_index(&auth_fixture_dir(), &cfg).expect("scan should succeed");
|
|
assert!(
|
|
diags.iter().any(|diag| {
|
|
diag.path.contains("scoped_write_missing.js")
|
|
&& diag.id == "js.auth.missing_ownership_check"
|
|
}),
|
|
"expected AST mode to emit js.auth findings"
|
|
);
|
|
assert!(
|
|
diags.iter().any(|diag| {
|
|
diag.path.contains("koa_scoped_read_missing.js")
|
|
&& diag.id == "js.auth.missing_ownership_check"
|
|
}),
|
|
"expected AST mode to emit Koa js.auth findings"
|
|
);
|
|
assert!(
|
|
diags.iter().any(|diag| {
|
|
diag.path.contains("fastify_scoped_write_missing.js")
|
|
&& diag.id == "js.auth.missing_ownership_check"
|
|
}),
|
|
"expected AST mode to emit Fastify js.auth findings"
|
|
);
|
|
assert!(
|
|
diags.iter().any(|diag| {
|
|
diag.path.contains("flask_scoped_write_missing.py")
|
|
&& diag.id == "py.auth.missing_ownership_check"
|
|
}),
|
|
"expected AST mode to emit Flask py.auth findings"
|
|
);
|
|
assert!(
|
|
diags.iter().any(|diag| {
|
|
diag.path.contains("django_cbv_scoped_write_missing.py")
|
|
&& diag.id == "py.auth.missing_ownership_check"
|
|
}),
|
|
"expected AST mode to emit Django py.auth findings"
|
|
);
|
|
assert!(
|
|
diags.iter().any(|diag| {
|
|
diag.path.contains("rails_scoped_write_missing.rb")
|
|
&& diag.id == "rb.auth.missing_ownership_check"
|
|
}),
|
|
"expected AST mode to emit Rails rb.auth findings"
|
|
);
|
|
assert!(
|
|
diags.iter().any(|diag| {
|
|
diag.path.contains("sinatra_scoped_read_missing.rb")
|
|
&& diag.id == "rb.auth.missing_ownership_check"
|
|
}),
|
|
"expected AST mode to emit Sinatra rb.auth findings"
|
|
);
|
|
assert!(
|
|
diags.iter().any(|diag| {
|
|
diag.path.contains("gin_admin_route_missing.go")
|
|
&& diag.id == "go.auth.admin_route_missing_admin_check"
|
|
}),
|
|
"expected AST mode to emit Gin go.auth findings"
|
|
);
|
|
assert!(
|
|
diags.iter().any(|diag| {
|
|
diag.path.contains("echo_partial_batch.go")
|
|
&& diag.id == "go.auth.partial_batch_authorization"
|
|
}),
|
|
"expected AST mode to emit Echo go.auth findings"
|
|
);
|
|
assert!(
|
|
diags.iter().any(|diag| {
|
|
diag.path.contains("spring_scoped_read_missing.java")
|
|
&& diag.id == "java.auth.missing_ownership_check"
|
|
}),
|
|
"expected AST mode to emit Spring java.auth findings"
|
|
);
|
|
assert!(
|
|
diags.iter().any(|diag| {
|
|
diag.path.contains("actix_scoped_write_missing.rs")
|
|
&& diag.id == "rs.auth.missing_ownership_check"
|
|
}),
|
|
"expected AST mode to emit Rust rs.auth findings"
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn auth_analysis_does_not_run_in_cfg_mode() {
|
|
let cfg = common::test_config(AnalysisMode::Cfg);
|
|
let diags = nyx_scanner::scan_no_index(&auth_fixture_dir(), &cfg).expect("scan should succeed");
|
|
assert!(
|
|
diags.iter().all(|diag| !diag.id.starts_with("js.auth.")),
|
|
"CFG mode should not emit js.auth findings"
|
|
);
|
|
assert!(
|
|
diags.iter().all(|diag| !diag.id.starts_with("py.auth.")),
|
|
"CFG mode should not emit py.auth findings"
|
|
);
|
|
assert!(
|
|
diags.iter().all(|diag| !diag.id.starts_with("rb.auth.")),
|
|
"CFG mode should not emit rb.auth findings"
|
|
);
|
|
assert!(
|
|
diags.iter().all(|diag| !diag.id.starts_with("go.auth.")),
|
|
"CFG mode should not emit go.auth findings"
|
|
);
|
|
assert!(
|
|
diags.iter().all(|diag| !diag.id.starts_with("java.auth.")),
|
|
"CFG mode should not emit java.auth findings"
|
|
);
|
|
assert!(
|
|
diags.iter().all(|diag| !diag.id.starts_with("rs.auth.")),
|
|
"CFG mode should not emit rs.auth findings"
|
|
);
|
|
assert!(
|
|
diags
|
|
.iter()
|
|
.all(|diag| !diag.path.contains("koa_scoped_read_missing.js")),
|
|
"CFG mode should not emit Koa auth-analysis findings"
|
|
);
|
|
assert!(
|
|
diags
|
|
.iter()
|
|
.all(|diag| !diag.path.contains("fastify_scoped_write_missing.js")),
|
|
"CFG mode should not emit Fastify auth-analysis findings"
|
|
);
|
|
assert!(
|
|
diags
|
|
.iter()
|
|
.all(|diag| !diag.path.contains("flask_scoped_write_missing.py")),
|
|
"CFG mode should not emit Flask auth-analysis findings"
|
|
);
|
|
assert!(
|
|
diags
|
|
.iter()
|
|
.all(|diag| !diag.path.contains("django_cbv_scoped_write_missing.py")),
|
|
"CFG mode should not emit Django auth-analysis findings"
|
|
);
|
|
assert!(
|
|
diags
|
|
.iter()
|
|
.all(|diag| !diag.path.contains("rails_scoped_write_missing.rb")),
|
|
"CFG mode should not emit Rails auth-analysis findings"
|
|
);
|
|
assert!(
|
|
diags
|
|
.iter()
|
|
.all(|diag| !diag.path.contains("sinatra_scoped_read_missing.rb")),
|
|
"CFG mode should not emit Sinatra auth-analysis findings"
|
|
);
|
|
assert!(
|
|
diags
|
|
.iter()
|
|
.all(|diag| !diag.path.contains("gin_admin_route_missing.go")),
|
|
"CFG mode should not emit Gin auth-analysis findings"
|
|
);
|
|
assert!(
|
|
diags
|
|
.iter()
|
|
.all(|diag| !diag.path.contains("echo_partial_batch.go")),
|
|
"CFG mode should not emit Echo auth-analysis findings"
|
|
);
|
|
assert!(
|
|
diags
|
|
.iter()
|
|
.all(|diag| !diag.path.contains("spring_scoped_read_missing.java")),
|
|
"CFG mode should not emit Spring auth-analysis findings"
|
|
);
|
|
assert!(
|
|
diags
|
|
.iter()
|
|
.all(|diag| !diag.path.contains("actix_scoped_write_missing.rs")),
|
|
"CFG mode should not emit Rust auth-analysis findings"
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn auth_analysis_does_not_run_in_taint_mode() {
|
|
let cfg = common::test_config(AnalysisMode::Taint);
|
|
let diags = nyx_scanner::scan_no_index(&auth_fixture_dir(), &cfg).expect("scan should succeed");
|
|
for filename in [
|
|
"admin_route_missing.js",
|
|
"typed_admin_route_missing.ts",
|
|
"flask_admin_route_missing.py",
|
|
"rails_admin_route_missing.rb",
|
|
"gin_admin_route_missing.go",
|
|
"spring_admin_route_missing.java",
|
|
"axum_admin_route_missing.rs",
|
|
] {
|
|
assert_no_auth_diags_for(&diags, filename);
|
|
}
|
|
}
|