mirror of
https://github.com/elicpeter/nyx.git
synced 2026-06-15 20:05:13 +02:00
* feat: Introduce function-scoped variable interning for state analysis with new tests and fixtures * feat: Add Phase 26 symbolic execution enhancements with bitwise operator support, abstract interpretation refinements, and new taint analysis tests * feat: Refine state analysis to handle factory-pattern resource returns with mixed-path tests and leak detection enhancements * feat: Add Phase 27 debug views with symbolic execution, abstract interpretation, SSA, and call graph viewers; integrate with debug layout and styles * feat: Add Phase 31 type-qualified symbolic resolution with receiver-based callee disambiguation and testing * feat: Extend symbolic execution with state iteration, enhanced debug views, and debounced input handling * feat: Add Phase 13 resource and auth pattern extensions with new tests and fixtures * feat: Introduce CFG debug graph renderer with compact mode, toolbar, and DAG layout integration * feat: Add Phase 28 encoding and decoding transform modeling with structural symex enhancements and new taint analysis tests * feat: Extend abstract interpretation with type facts and constant value tracking in debug views and server logic * feat: Add linear path handling and witness extraction to symbolic execution with Phase 28 transform mismatch detection * feat: Refine Go auth and sanitizer handling with enhanced rules, state updates, and benchmark improvements * feat: Enable auth-state analysis by default and update relevant tests in benchmark config * test: Update state_tests to reflect default enablement of auth-state analysis and add auth suppression test * docs: update CHANGELOG.md * feat: Introduce per-index taint tracking in `HeapState` with `HeapSlot`, overflow handling, and revised SSA transfers * feat: Introduce C/C++ language labels and refine heap state tracking in SSA transfers * feat: Implement per-index array slot tracking in symbolic heap with overflow collapse * feat: Add implicit definition handling for uninitialized declarations in SSA value allocation * feat: Refactor function parameters and constants for improved clarity and maintainability * refactor: Reorder module imports and improve formatting for consistency * refactor: Fix formatting erorrs * refactor: Fix clippy warnings * refactor: Fix fmt warnings (again) * chore: Update dependencies and improve feature configuration * Add comprehensive tests for undertested modules (#36) (COPILOT) * Add comprehensive tests for undertested modules Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com> Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/f3fc877e-f386-49ba-9793-fc93d3805083 * Add comprehensive tests for ext, project, walk, and errors modules Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com> Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/f3fc877e-f386-49ba-9793-fc93d3805083 --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com> * chore: Update dependencies and improve feature configuration * fix: formatting errors in new tests * chore: Update license list in about.toml * chore: made functions input inline * chore: updated cfg graph to take up the full page * chore: add Prettier configuration and update code formatting * Add frontend test suite with Vitest (111 tests) (#37) * Add Vitest test suite for frontend - 111 tests across utils, components, hooks, and graph utilities Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com> Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/7cf0dba2-ecff-4740-ba4d-92717e74a0b7 * ci: add frontend test step to CI workflow Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com> Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/5bc0ac9f-0a32-4d03-9cb7-7a15aea53fca --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com> * chore: simplify array initialization in test files for consistency * ran typecheck * feat: add AnalysisWorkspace component and integrate it into CfgViewerPage * feat: update routing in AppLayout and improve empty state message in ExplorerPage * feat: enhance scan progress tracking with additional metrics and stages * feat: update license information and add license check script * feat: implement cross-file symbolic execution with callee body persistence * feat: replace dagre graphs with Graphology + ELK + Sigma for more advanced call stack and cfg rendering * feat: ensure CFG function view is scoped to the selected function, preventing bleed into sibling functions * feat: enhance resource tracking with proxy method summaries and improve finding extraction * feat: add terminal function exit detection for accurate resource leak analysis * feat: add warnings for loops and functions without bodies to improve error recovery * feat: update lambda expression handling to ensure proper function classification and control flow * feat: remove bounded formatting/string ops and add JSON.parse sanitizer for improved data handling * feat: add inline return taint analysis and regression tests for improved security checks * feat: add engine version management and migration handling for database schema updates * feat: enhance first_call_ident to skip nested function bodies and add regression tests * feat: enhance callee name resolution with two-segment normalization and disambiguation * feat: add cross-file context flags and debug assertions for taint analysis * feat: refactor taint analysis structure to unify context handling and improve clarity * feat: enhance dead code elimination to preserve Sink, Source, and Sanitizer labels with new tests * docs: updated CHANGELOG.md * fmt: formatting fixes * fix: fixed frontend formatting and lint warnings * fix: optimized ci * fix: optimized ci * Add comprehensive multi-file test coverage to Nyx (#38) * Initial checklist for multi-file test suite expansion Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/e550cb88-9767-4442-94d4-101bf5bb0e23 Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com> * Add 12 new multi-file test fixtures with TP/TN/near-miss coverage Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/e550cb88-9767-4442-94d4-101bf5bb0e23 Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com> * deleted root repo * rebuilt to test for regressions --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com> Co-authored-by: elipeter <elicpeter@gmail.com> * feat: enhance import alias resolution and taint tracking * feat: implement security hardening with CSRF protection and path validation * feat: add support for import alias bindings in Python, PHP, and Rust * feat: enhance CFG analysis modes and improve code readability * feat: add detection for parameterized SQL queries to enhance security * feat: add safe internal redirect handling and enhance session destroy validation * feat: implement security improvements by addressing vulnerabilities in execAsync, session management, and file downloads * feat: enhance taint detection by adding support for inline source member expressions in call arguments * feat: implement pre-emission of Source nodes for inline source member expressions in call arguments * feat: add support for Throw statement in control flow and error handling * feat: add debug and echo endpoints with potential information leakage * feat: implement internal redirect suppression and enhance taint detection * feat: implement module alias tracking for dynamic dispatch in JS/TS * feat: add authorization analysis module with Express support * feat: add authorization analysis module with Express support * feat: add tests for admin guard requirements and clean checks in authorization analysis * feat: integrate Koa and Fastify frameworks into authorization analysis * feat: add Flask and Django support to authorization analysis module * feat: add support for Rails and Sinatra frameworks in authorization analysis * feat: add support for Axum, ActixWeb, and Rocket frameworks in authorization analysis * feat: add support for ActixWeb, Axum, and Rocket frameworks in authorization analysis * feat: add support for Rails and Sinatra in authorization analysis * chore: add .DS_Store to .gitignore * refactor: simplify conditional checks and improve readability in multiple files * refactor: update usage of Option methods for improved clarity and consistency * refactor: improve code readability by simplifying conditional checks and formatting * refactor: improve code formatting and readability by simplifying conditional checks * refactor: simplify conditional checks and improve readability in multiple files * refactor: simplify conditional checks in axum.rs for improved readability * feat: add CodeQL analysis configuration for enhanced security scanning * test: add comprehensive tests for `src/output.rs` SARIF builder (#39) * chore: start test coverage improvement work Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/cd7ff398-134e-4728-a5e7-0353a0744423 Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com> * test: add comprehensive tests for src/output.rs SARIF builder Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/cd7ff398-134e-4728-a5e7-0353a0744423 Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com> * refactor: improve code formatting and readability in output.rs --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com> Co-authored-by: elipeter <elicpeter@gmail.com> * refactor: improve code formatting and readability in output.rs * Potential fix for code scanning alert no. 210: Uncontrolled data used in path expression Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> * Potential fix for code scanning alert no. 211: Uncontrolled data used in path expression Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> * refactor: enhance triage file path handling with improved error management and validation * refactor: updated func summaries for richer detail * refactor: update SSA summary extraction to use canonical FuncKey for distinct entries * refactor: enhance callee metadata structure to support arity, receiver, and qualifier for better overload resolution * refactor: add support for keyword arguments in function calls and enhance receiver extraction for method-style calls * refactor: implement new Flask routes for safe and unsafe shell command execution * refactor: separate receiver handling in SSA operations and enhance taint propagation * refactor: improve arity handling by using arg_uses for positional argument count and enhance witness scoring for tainted arguments * refactor: implement auth decorator extraction and classification for multiple languages * refactor: enhance Rust module path resolution and use map handling for cross-file disambiguation * refactor: introduce CalleeQuery struct for structured callee resolution and enhance resolver logic * refactor: implement same-file identity collision handling for `runTask` to ensure correct resolver behavior * refactor: standardize default struct initialization across multiple files * feat: add scripts for formatting checks and auto-fixes with test summaries * refactor: simplify character splitting and enhance namespace qualifier handling * refactor: improve documentation clarity and enhance code readability in resolver logic * refactor: replace default struct initialization with explicit field assignments for clarity * feat: enhance anonymous function naming by deriving context-based bindings * refactor: streamline match expressions for improved readability and performance * refactor: streamline match expressions for improved readability and performance * refactor: replace loop with while let for improved clarity and performance * feat: add SSA constant propagation support to analysis context for improved accuracy * feat: add SSA constant propagation support to analysis context for improved accuracy * feat: implement shell metacharacter validation and bounded-length checks in Rust analysis * feat: add static map analysis for command injection suppression and type safety * refactor: simplify match statements and reduce line breaks for improved readability * feat(summary): phase 1/5 SinkSite data model for primary sink-location attribution Introduce SinkSite (file_rel, line, col, snippet, cap) carrying the primary sink source-location through function summaries. Swap SsaFuncSummary.param_to_sink and FuncSummary.param_to_sink from a coarse Cap map to a deduped SmallVec<[SinkSite; 1]> per parameter, with a backward-compatible cap_sites() helper and serde defaults so pre-phase-1 on-disk rows continue to deserialise cleanly. Extraction: SinkSiteLocator bundles the tree/bytes/file_rel needed by extract_ssa_func_summary; ParsedFile::extract_ssa_artifacts wires the locator in for the persisted pass-1 path, while pass-2 intra-file transient summaries fall back to cap-only sites (behavior unchanged). Merge: GlobalSummaries::insert now unions sink sites with (file_rel, line, col, cap) dedup via shared union_param_sink_sites helper. Database: JSON-serialised summary columns carry the new shape automatically; no schema change needed. Phase 2 will consume SinkSite in build_taint_diag() to overwrite the caller-site Finding.line with the callee's sink line when resolved via summary. Phase 1 keeps behavior unchanged: scanning tests/benchmark/corpus/rust/cmdi/cmdi_indirect.rs still produces the same (wrong) line 10 finding. Adds round-trip tests covering SinkSite solo, SsaFuncSummary with sink sites, legacy-JSON default handling for both summary types, and merge dedup. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * feat(taint): phase 2/5 thread SinkSite into SsaTaintEvent and Finding Plumb Phase 1's SinkSite through the event pipeline into Findings, no output change yet. SsaTaintEvent gains `primary_sink_site: Option<SinkSite>`; when the main or callback sink-emission path has non-empty `param_to_sink_sites`, filter to sites whose `(line != 0) && (cap ∩ sink_caps != ∅)` and emit one event per distinct site — the multi-primary collapse keeps each downstream Finding single-primary. Resolution: ResolvedSummary and SinkInfo gain mirror `param_to_sink_sites` fields, populated from `SsaFuncSummary.param_to_sink` (SSA + callback paths) and `FuncSummary.param_to_sink` (global paths). Label, local-summary, and interop resolution paths leave the field empty — they only ever had cap-level info to begin with. Finding: new `primary_location: Option<SinkLocation>` with `file_rel/line/col`. `ssa_events_to_findings` maps `event.primary_sink_site` → `Finding.primary_location`, filtering cap-only sites (`line == 0`) to `None` so the (0,0) sentinel never leaks to formatters. Dedup key extended with the primary location so multi-site events aren't collapsed back together. Invariants (debug_assert!): * every SinkSite reaching emission has `line != 0 && cap ∩ sink_caps != ∅` — enforced by the pick_primary_sink_sites* filters; * every populated Finding.primary_location has `line != 0` AND non-empty `file_rel` — the cap-only → None translation upstream guarantees this. Deliberately independent of `uses_summary`: that flag tracks whether the *taint chain* used a summary, whereas primary attribution requires only that the *sink* itself was summary-resolved. A local source reaching a cross-file sink produces `uses_summary=false` alongside a populated primary_location — documented on Finding.primary_location, covered by `cross_file_sink_finding_carries_primary_location`. build_taint_diag, SARIF/JSON/explanation formatters, and the benchmark scorer remain untouched: finding.line still comes from `cfg_graph[finding.sink]`, so cmdi_indirect.rs still reports line 10 and the benchmark's rs-cmdi-003 row still shows FN in the LOC column. Tests: `cross_file_sink_finding_carries_primary_location` (proves plumbing via a synthetic FuncSummary carrying a SinkSite at 42:5) and `cross_file_sink_cap_only_site_leaves_primary_location_none` (regression guard against cap-only sites surfacing). All 1566 lib tests + integration tests pass. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat(output): phase 3/5 consume primary sink location in diag + SARIF When a finding's primary_location (populated in phase 2 from a callee summary's SinkSite) names the dangerous instruction inside a callee body, attribute the diagnostic line to that location instead of the caller's call site. The call site is demoted to a Call step in flow_steps, and a synthetic Sink step at the primary location is appended so analysts still see the full trace. Changes: - Add scan_root parameter to build_taint_diag so file_rel can be resolved back to an absolute path via a shared resolve_file_rel helper. Empty file_rel (single-file scans where namespace == "") resolves to the file under analysis. - Extend SinkLocation with snippet, carried from the upstream SinkSite so the formatter needs no second file read. - Relax the ssa_events_to_findings debug_assert to allow empty file_rel, which is valid when scan root equals the file itself. - SARIF: emit data-flow as codeFlows[0].threadFlows[0].locations[]; locations[0] already reflects the primary sink position via the updated diag line/col. Acceptance: scan on tests/benchmark/corpus/rust/cmdi/cmdi_indirect.rs now reports line 5 (Command::new) as the primary sink, with the call site at line 10 visible in flow_steps. Two expect.json fixtures updated (must_match line_range widened): - javascript/taint/context_sensitive_call: 12-14 -> 7-14 (line 8 is the real sink inside run()). - rust/cfg/closure_async: 10-10 -> 10-11 (line 11 is Command::new inside the closure). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat(bench): phase 4/5 validate primary sink attribution across corpus Extend the benchmark scorer and ground truth to lock in phase 3's primary-location behavior, and add fixtures that exercise the new capability end-to-end. Scorer (tests/benchmark_test.rs): - Add optional `expected_call_site_lines: Option<Vec<[usize; 2]>>` on Case. When present, score_location_level additionally requires at least one flow_step in the finding's evidence trace to fall within ±2 of the call-site range. When absent, the check is skipped — fully forward-compatible with existing fixtures. - Retain ±2 tolerance on expected_sink_lines (compared against the now-primary Diag.line post-phase-3). Ground truth edits: - rs-cmdi-cross-001: expected_sink_lines [8,8] -> [9,9]. Line 8 is the transform::wrap call site (a cross-file propagator, not a sink); line 9 is Command::new, the real sink. The ±2 tolerance happened to mask this stale attribution but it was semantically wrong — phase 4 is the right time to correct it. Also adds expected_call_site_lines [8,8] so the new field is exercised on an existing cross-file case. - rs-cmdi-003: adds expected_call_site_lines [10,10] (run_cmd call). This fixture's sink (Command::new inside run_cmd at line 5) was the motivating case for phases 1-3; adding the call-site assertion guards against regression to caller-line attribution. New fixtures: - rust/cmdi/cmdi_indirect_multisink.rs (rs-cmdi-009): helper run_both takes two tainted params and invokes two Command sinks on consecutive lines. Locks in that primary line lands inside the helper (lines 5-6), not at the caller (line 12). Notes document that SinkSite is currently one-per-callee so both findings today collapse onto the first sink; expected_sink_lines=[5,6] and expected_call_site_lines=[12,12] stay valid either way. - python/cmdi/cross_indirect_sink/{app.py,helper.py} (py-cmdi-cross- 004): sink os.system lives in helper.py (cross-file), caller in app.py reads env source and calls run_cmd. Verifies phase 3's cross-file primary attribution: Diag.path = helper.py, Diag.line = 5, with app.py:7 recorded in flow_steps as a Call step. Acceptance: - `cargo test --test benchmark_test -- --ignored --nocapture` passes. - rs-cmdi-003 is TP/TP/TP (the target flip FN->TP at LOC). All pre-existing TP/TP/TP fixtures remain TP/TP/TP; 2 new fixtures are TP/TP/TP. - Aggregate rule-level: TP=158 FP=10 FN=1 TN=97, P=0.940 R=0.994 F1=0.966 on the 266-case corpus (was TP=156 FP=10 FN=1 TN=97 on 264 pre-phase-4, delta is the +2 new cases both resolving TP). - Full `cargo test` green (1566 lib tests + all integration tests). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat(taint): phase 5/5 lock Finding.primary_location contract via regression test Add a regression test in src/taint/ssa_transfer.rs that wires up a synthetic SsaFuncSummary with a SinkSite at other.rs:42:10 and drives the three emission stages (pick_primary_sink_sites → emit_ssa_taint_events → ssa_events_to_findings) against a minimal caller SSA body. Asserts the resulting Finding.primary_location is exactly that triple. The existing integration tests in src/taint/tests.rs cover the coarse FuncSummary path end-to-end through analyse_file. This test locks in the lower-level SSA-side plumbing so a future refactor that silently drops the site between pick → emit → findings fails here rather than only at the benchmark layer. Also refreshes tests/benchmark/results/latest.json (timestamp only; rs-cmdi-003 remains TP/TP/TP and the aggregate P/R/F1 are unchanged from phase 4). Closes the primary sink-location attribution feature (phases 1-5/5): * Phase 1 — SinkSite data model on summaries. * Phase 2 — SinkSite threaded into SsaTaintEvent and Finding. * Phase 3 — diag + SARIF consume primary_location. * Phase 4 — benchmark validates primary_call_site_lines across corpus. * Phase 5 — regression test locks the event→finding contract. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * refactor: clean up formatting and improve readability in multiple files * refactor: simplify type definition for deduplication key in findings * test(harness): add must_not_match expectation for FP regression guards Extends ExpectedFinding with must_not_match field that asserts a diagnostic must NOT fire — presence is a hard failure. Non-consuming scan so it coexists with must_match entries on the same rule_id. Adds forbidden_violations accumulator and updates summary line. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat(regression): update expectations to ensure must_not_match for various taint and resource leak rules * feat: implement auto-seeding for JS/TS handler parameters to enhance taint tracking * feat: update switch statement handling to improve control flow analysis * feat: implement promisify alias handling for JS/TS to enhance taint tracking * feat: enhance taint tracking by refining expectation handling and adding mode filtering * feat: refine SQL handling in stream processing and enhance auto-seeding for handler parameters * feat: update taint tracking rules to enforce full mode matching and improve flow analysis * feat: enhance Ruby subshell handling to improve taint tracking and flow analysis * feat: update xss_response expectations to refine taint flow analysis and enhance regression guarding * feat: refine framework detection and update expectation handling for Echo and Sinatra * feat: implement max_count for taint tracking expectations and deduplicate findings * feat: add strict_unexpected handling for taint-unsanitised-flow in expectation files * feat: enhance deduplication of taint-unsanitised-flow findings by collapsing based on line and severity * feat: add strict_unexpected handling for taint-unsanitised-flow in multiple expectation files * feat: add structural invariant checks for SSA bodies * feat: ensure deterministic phi emission order using BTreeSet * feat: enhance handling of terminators to ensure authoritative flow through successor edges * feat: enhance Goto terminator handling to ensure all successors are marked executable * feat: refactor code for improved readability and organization * feat: simplify predicate checks and enhance readability in SSA handling * feat: implement per-file parse timeout and enhance file size handling * feat: migrate analysis engine toggles from environment variables to configuration file * feat: remove unnecessary whitespace in hostile_input_tests.rs * feat: remove unnecessary whitespace in hostile_input_tests.rs * feat: update dependencies and enhance documentation on language maturity * feat: enhance security headers and improve request body limits * feat: implement sink capability bits for deduplication and enhance evidence tagging * feat: implement dynamic activation handling for gated sinks and enhance validation logic * feat: enhance configuration documentation and clarify inline analysis cache behavior * feat: implement panic recovery during analysis to continue scans past errors * feat: add expectations configuration for taint analysis and performance metrics * feat: enhance error handling and logging during file reading and mutex locking * feat: add cross-file body loading tests and plumbing for CF-1 phase * feat: implement cross-file k=1 context-sensitive inline taint analysis with new tests and fixtures * feat: implement indexed-scan parity in cross-file inline analysis with new dropdown and copy functionality * feat: enhance classification span handling in CFG and AST for improved source attribution * feat: add new Express routes for handling user input and telemetry data * feat: implement ternary expression handling in CFG with diamond structure for JS/TS * feat: implement Phase CF-3 abstract-domain transfer channels in summaries * feat: add support for string-prefix transfer in cross-file calls and update tests * docs: reduce RESULTS.md doc size * feat: implement Phase CF-4 per-return-path summary decomposition with tests * feat: update parameter handling in pass1 and refactor SsaFuncSummary initialization * feat: implement Phase CF-5 for cross-file SCC joint fixed-point convergence with new flags and tests * feat: implement Phase CF-6 with parameter-granularity points-to summaries and associated tests * refactor: update comments and documentation for clarity and consistency * style: format code for consistency and readability * refactor: simplify verdict handling and improve edge checking logic * refactor: optimize path and identifier collection by avoiding unnecessary cloning * chore: update Cargo.toml for Rust version 1.85 and add ignored files; modify CHANGELOG and README for clarity on state analysis defaults * refactor: update documentation and improve clarity in configuration files * refactor: update documentation and improve clarity in configuration files * feat: add JS/TS pass-2 convergence tests and expectations configuration * feat: add Phase 5 regression tests for inline cache origin attribution and update related logic * feat: implement Phase 7 deduplication and alternative path linking for taint findings * feat: implement structural DFS index for anonymous functions and update naming conventions * feat: add Phase 8 regression tests for container-element taint in JS and Python * feat: add engine-depth profiles and explain-engine option for CLI * feat: update expectations and add new README fixtures for multi-file scan regression * feat: implement Phase 11 callback-alias and factory patterns with regression tests * feat: implement Terminator::Switch for multi-way dispatch and add regression tests * feat: add real-CVE benchmark fixtures for CVE-2023-48022, CVE-2019-14939, and CVE-2023-26159 with corresponding patched variants * refactor: extract cfg and ssa_transfer to submodules * refactor: cargo fmt * refactor: remove unnecessary blank line in cfg_tests.rs * refactor: remove unnecessary planning file * chore: update Rust version to 1.88 and bump dependencies in Cargo files * feat: enhance triage UI with new layout and controls, update README for clarity * feat: enhance triage UI with new layout and controls, update README for clarity * chore: remove outdated section from README for version 0.5.0 * docs: improve clarity and consistency in README content * chore: add "GPL-3.0-or-later" to license options in about.toml * chore: update license handling in about.toml and check-licenses.mjs * style: format code for improved readability in TriagePage component * style: format code for improved readability in TriagePage component * chore: enhance license handling and improve body_id scoping in seed lookup * feat: introduce owner and parent body IDs for enhanced seed scoping * feat: implement direction-aware engine provenance with new CLI flag for strict CI gating * feat: add Undef SSA operation for improved control-flow handling * style: improve code formatting for consistency and readability in multiple files * feat: add 16-function chain SCC across multiple files for enhanced analysis * style: simplify code formatting for improved readability in multiple files * fix: update CapHitReason default implementation and improve README clarity * docs: enhance README with detailed explanations of taint analysis and limitations * docs: refine README for clarity and consistency in taint analysis section * style: improve code formatting for better readability in NewScanModal and scans * fix: update cargo-about command to use --offline for deterministic license generation * fix: update cargo-about command to use --offline for deterministic license generation * ci: add step to prime cargo registry cache for deterministic license generation * feat: add support for non-sink collections in authorization analysis * feat: enhance authorization checks with row-level ownership equality and binding tracking * feat: implement self-scoped user handling and enhance ownership checks * refactor: simplify assertions and formatting in authorization analysis tests * fix: normalize line endings in THIRDPARTY-LICENSES.html generation and update README with AI disclosure * docs: update AI disclosure section for clarity and conciseness * feat: add AI Contribution Policy and update contributing guidelines for AI assistance disclosure * feat: enhance authorization analysis with SSA-derived variable type classification * feat: implement auth_finding_to_diag function for enhanced security diagnostics * feat: add args_value_refs to CallSite struct for enhanced argument tracking * feat: add args_value_refs to CallSite struct for enhanced argument tracking * feat: add direction-aware engine provenance with LossDirection classification and new CLI flag * feat: simplify strip_cap_from_call_args call by removing unnecessary line breaks * feat: enhance error message handling in cli_validation_tests for better Windows compatibility * feat: optimize release profile settings in Cargo.toml and update CodeQL configuration * feat: enhance release build process with SBOM generation and SLSA provenance * feat: update actions/checkout and actions/setup-node to v6, enhance CLI options, and improve auth-check summaries * feat: introduce PathFact handling for path safety checks and rejection logic * feat: introduce PathFact handling for path safety checks and rejection logic * feat: update benchmark data and enhance path sanitization logic with new safety checks * feat: document AI assistance in frontend UI development and human review process * feat: add return path facts for enhanced path safety checks and update documentation * chore: update release date for version 0.5.0 in CHANGELOG.md * chore: clean up ci.yml by removing outdated comments and clarifying steps * feat: implement cross-language path sanitizers and validators for enhanced security * feat: enhance SSA value usage tracking by including block terminators and improve path safety checks * feat: enhance switch statement handling by adding per-case path constraints and support for exclusive cases * refactor: simplify conditional formatting and improve code readability in executor and lower modules * feat: add vulnerable examples for various languages demonstrating authentication and sanitization issues * feat: enhance actor context recognition for self-actor identifiers and add support for global non-sink receivers * feat: enhance actor context recognition for self-actor identifiers and add support for global non-sink receivers * feat: add transform classifiers for Java, Go, and Ruby with corresponding tests * refactor: clarify comments on reassign-to-constant idiom and sink behavior in guards.rs --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
617 lines
19 KiB
Rust
617 lines
19 KiB
Rust
use super::AuthExtractor;
|
|
use super::common::{
|
|
attach_route_handler, call_name, call_site_from_node, call_sites_from_value,
|
|
collect_top_level_units, function_definition_node, named_children, resolve_handler_node,
|
|
string_literal_value, text,
|
|
};
|
|
use crate::auth_analysis::config::AuthAnalysisRules;
|
|
use crate::auth_analysis::model::{
|
|
AuthCheck, AuthCheckKind, AuthorizationModel, CallSite, Framework, HttpMethod,
|
|
RouteRegistration, ValueRef, ValueSourceKind,
|
|
};
|
|
use crate::utils::project::{DetectedFramework, FrameworkContext};
|
|
use std::collections::HashMap;
|
|
use std::path::Path;
|
|
use tree_sitter::{Node, Tree};
|
|
|
|
pub struct AxumExtractor;
|
|
|
|
impl AuthExtractor for AxumExtractor {
|
|
fn supports(&self, lang: &str, framework_ctx: Option<&FrameworkContext>) -> bool {
|
|
lang == "rust"
|
|
&& framework_ctx
|
|
.is_none_or(|ctx| ctx.frameworks.is_empty() || ctx.has(DetectedFramework::Axum))
|
|
}
|
|
|
|
fn extract(
|
|
&self,
|
|
tree: &Tree,
|
|
bytes: &[u8],
|
|
path: &Path,
|
|
rules: &AuthAnalysisRules,
|
|
) -> AuthorizationModel {
|
|
let root = tree.root_node();
|
|
let mut model = AuthorizationModel::default();
|
|
|
|
collect_top_level_units(root, bytes, rules, &mut model);
|
|
collect_routes(root, root, bytes, path, rules, &mut model);
|
|
|
|
model
|
|
}
|
|
}
|
|
|
|
fn collect_routes(
|
|
root: Node<'_>,
|
|
node: Node<'_>,
|
|
bytes: &[u8],
|
|
path: &Path,
|
|
rules: &AuthAnalysisRules,
|
|
model: &mut AuthorizationModel,
|
|
) {
|
|
if node.kind() == "call_expression" {
|
|
maybe_collect_route(root, node, bytes, path, rules, model);
|
|
}
|
|
|
|
for child in named_children(node) {
|
|
collect_routes(root, child, bytes, path, rules, model);
|
|
}
|
|
}
|
|
|
|
fn maybe_collect_route(
|
|
root: Node<'_>,
|
|
node: Node<'_>,
|
|
bytes: &[u8],
|
|
path: &Path,
|
|
rules: &AuthAnalysisRules,
|
|
model: &mut AuthorizationModel,
|
|
) {
|
|
if call_name(node, bytes).rsplit('.').next() != Some("route") {
|
|
return;
|
|
}
|
|
|
|
let Some(arguments) = node.child_by_field_name("arguments") else {
|
|
return;
|
|
};
|
|
let args = named_children(arguments);
|
|
let Some(path_node) = args.first().copied() else {
|
|
return;
|
|
};
|
|
let Some(route_path) = string_literal_value(path_node, bytes) else {
|
|
return;
|
|
};
|
|
let Some(route_spec) = args.get(1).copied() else {
|
|
return;
|
|
};
|
|
let Some(spec) = parse_method_router(route_spec, bytes) else {
|
|
return;
|
|
};
|
|
let Some(handler_node) = resolve_handler_node(root, spec.handler_expr, bytes) else {
|
|
return;
|
|
};
|
|
let Some(handler) = attach_route_handler(
|
|
root,
|
|
spec.handler_expr,
|
|
format!("{:?} {}", spec.method, route_path),
|
|
bytes,
|
|
rules,
|
|
model,
|
|
) else {
|
|
return;
|
|
};
|
|
|
|
let mut middleware_calls = inherited_layer_calls(node, bytes);
|
|
middleware_calls.extend(spec.middleware_calls.clone());
|
|
let guard_calls =
|
|
guard_calls_for_handler(handler_node, &route_path, bytes, GuardFramework::Axum);
|
|
middleware_calls.extend(guard_calls.clone());
|
|
dedup_call_sites(&mut middleware_calls);
|
|
|
|
if let Some(unit) = model.units.get_mut(handler.unit_idx) {
|
|
let aliases = rust_param_aliases(handler_node, &route_path, bytes, GuardFramework::Axum);
|
|
apply_aliases(unit, &aliases);
|
|
inject_guard_checks(unit, &guard_calls, rules);
|
|
}
|
|
|
|
model.routes.push(RouteRegistration {
|
|
framework: Framework::Axum,
|
|
method: spec.method,
|
|
path: route_path,
|
|
middleware: middleware_calls
|
|
.iter()
|
|
.map(|call| call.name.clone())
|
|
.collect(),
|
|
handler_span: handler.span,
|
|
handler_params: handler.params,
|
|
file: path.to_path_buf(),
|
|
line: handler.line,
|
|
unit_idx: handler.unit_idx,
|
|
middleware_calls,
|
|
});
|
|
}
|
|
|
|
struct MethodRouterSpec<'tree> {
|
|
method: HttpMethod,
|
|
handler_expr: Node<'tree>,
|
|
middleware_calls: Vec<CallSite>,
|
|
}
|
|
|
|
fn parse_method_router<'tree>(node: Node<'tree>, bytes: &[u8]) -> Option<MethodRouterSpec<'tree>> {
|
|
let last = call_name(node, bytes).rsplit('.').next()?.to_string();
|
|
if let Some(method) = axum_http_method(&last) {
|
|
let args = node
|
|
.child_by_field_name("arguments")
|
|
.map(named_children)
|
|
.unwrap_or_default();
|
|
let handler_expr = *args.last()?;
|
|
return Some(MethodRouterSpec {
|
|
method,
|
|
handler_expr,
|
|
middleware_calls: Vec::new(),
|
|
});
|
|
}
|
|
|
|
if node.kind() != "call_expression" {
|
|
return None;
|
|
}
|
|
|
|
let function = node.child_by_field_name("function")?;
|
|
let receiver = function
|
|
.child_by_field_name("object")
|
|
.or_else(|| function.child_by_field_name("argument"))?;
|
|
let mut spec = parse_method_router(receiver, bytes)?;
|
|
match last.as_str() {
|
|
"layer" | "route_layer" => {
|
|
if let Some(arguments) = node.child_by_field_name("arguments") {
|
|
for arg in named_children(arguments) {
|
|
spec.middleware_calls
|
|
.extend(expanded_guard_call_sites(arg, bytes));
|
|
}
|
|
}
|
|
Some(spec)
|
|
}
|
|
_ => None,
|
|
}
|
|
}
|
|
|
|
fn axum_http_method(name: &str) -> Option<HttpMethod> {
|
|
match name {
|
|
"get" => Some(HttpMethod::Get),
|
|
"post" => Some(HttpMethod::Post),
|
|
"put" => Some(HttpMethod::Put),
|
|
"delete" => Some(HttpMethod::Delete),
|
|
"patch" => Some(HttpMethod::Patch),
|
|
"any" => Some(HttpMethod::All),
|
|
_ => None,
|
|
}
|
|
}
|
|
|
|
fn inherited_layer_calls(node: Node<'_>, bytes: &[u8]) -> Vec<CallSite> {
|
|
let Some(function) = node.child_by_field_name("function") else {
|
|
return Vec::new();
|
|
};
|
|
let Some(receiver) = function
|
|
.child_by_field_name("object")
|
|
.or_else(|| function.child_by_field_name("argument"))
|
|
else {
|
|
return Vec::new();
|
|
};
|
|
collect_layer_calls(receiver, bytes)
|
|
}
|
|
|
|
fn collect_layer_calls(node: Node<'_>, bytes: &[u8]) -> Vec<CallSite> {
|
|
if node.kind() != "call_expression" {
|
|
return Vec::new();
|
|
}
|
|
|
|
let mut calls = Vec::new();
|
|
let name = call_name(node, bytes);
|
|
if matches!(name.rsplit('.').next(), Some("layer" | "route_layer"))
|
|
&& let Some(arguments) = node.child_by_field_name("arguments")
|
|
{
|
|
for arg in named_children(arguments) {
|
|
calls.extend(expanded_guard_call_sites(arg, bytes));
|
|
}
|
|
}
|
|
|
|
if let Some(function) = node.child_by_field_name("function")
|
|
&& let Some(receiver) = function
|
|
.child_by_field_name("object")
|
|
.or_else(|| function.child_by_field_name("argument"))
|
|
{
|
|
calls.extend(collect_layer_calls(receiver, bytes));
|
|
}
|
|
|
|
calls
|
|
}
|
|
|
|
#[derive(Clone, Copy)]
|
|
pub(crate) enum GuardFramework {
|
|
Axum,
|
|
ActixWeb,
|
|
Rocket,
|
|
}
|
|
|
|
pub(crate) fn rust_param_aliases(
|
|
handler_node: Node<'_>,
|
|
route_path: &str,
|
|
bytes: &[u8],
|
|
framework: GuardFramework,
|
|
) -> HashMap<String, ValueSourceKind> {
|
|
let mut aliases = HashMap::new();
|
|
let Some(parameters) = function_definition_node(handler_node).child_by_field_name("parameters")
|
|
else {
|
|
return aliases;
|
|
};
|
|
|
|
let path_names = route_placeholder_names(route_path);
|
|
let query_names = route_query_placeholder_names(route_path);
|
|
|
|
for param in named_children(parameters) {
|
|
let param_text = text(param, bytes);
|
|
if param.kind() == "self_parameter" || param_text.trim().is_empty() {
|
|
continue;
|
|
}
|
|
let binding = rust_binding_name(¶m_text);
|
|
let type_text = rust_param_type_text(param, bytes, ¶m_text);
|
|
if binding.is_empty() || type_text.is_empty() {
|
|
continue;
|
|
}
|
|
|
|
let kind = match framework {
|
|
GuardFramework::Axum => classify_axum_param(&binding, &type_text),
|
|
GuardFramework::ActixWeb => classify_actix_param(&binding, &type_text),
|
|
GuardFramework::Rocket => {
|
|
classify_rocket_param(&binding, &type_text, &path_names, &query_names)
|
|
}
|
|
};
|
|
if let Some(kind) = kind {
|
|
aliases.insert(binding, kind);
|
|
}
|
|
}
|
|
|
|
aliases
|
|
}
|
|
|
|
pub(crate) fn guard_calls_for_handler(
|
|
handler_node: Node<'_>,
|
|
route_path: &str,
|
|
bytes: &[u8],
|
|
framework: GuardFramework,
|
|
) -> Vec<CallSite> {
|
|
let mut calls = Vec::new();
|
|
let Some(parameters) = function_definition_node(handler_node).child_by_field_name("parameters")
|
|
else {
|
|
return calls;
|
|
};
|
|
let span = (handler_node.start_byte(), handler_node.end_byte());
|
|
let path_names = route_placeholder_names(route_path);
|
|
let query_names = route_query_placeholder_names(route_path);
|
|
|
|
for param in named_children(parameters) {
|
|
let param_text = text(param, bytes);
|
|
if param.kind() == "self_parameter" || param_text.trim().is_empty() {
|
|
continue;
|
|
}
|
|
let type_text = rust_param_type_text(param, bytes, ¶m_text);
|
|
let Some(kind) = (match framework {
|
|
GuardFramework::Axum => classify_guard_type(&type_text),
|
|
GuardFramework::ActixWeb => classify_guard_type(&type_text),
|
|
GuardFramework::Rocket => classify_rocket_guard_type(
|
|
&type_text,
|
|
&rust_binding_name(¶m_text),
|
|
&path_names,
|
|
&query_names,
|
|
),
|
|
}) else {
|
|
continue;
|
|
};
|
|
|
|
let name = type_last_segment(&type_text);
|
|
if !name.is_empty() {
|
|
calls.push(CallSite {
|
|
name,
|
|
args: Vec::new(),
|
|
span,
|
|
args_value_refs: Vec::new(),
|
|
});
|
|
if matches!(kind, AuthCheckKind::AdminGuard) {
|
|
calls.push(CallSite {
|
|
name: "require_admin".to_string(),
|
|
args: Vec::new(),
|
|
span,
|
|
args_value_refs: Vec::new(),
|
|
});
|
|
}
|
|
}
|
|
}
|
|
|
|
dedup_call_sites(&mut calls);
|
|
calls
|
|
}
|
|
|
|
fn classify_axum_param(binding: &str, type_text: &str) -> Option<ValueSourceKind> {
|
|
if wrapper_type_matches(type_text, &["Path"]) {
|
|
Some(ValueSourceKind::RequestParam)
|
|
} else if wrapper_type_matches(type_text, &["Query"]) {
|
|
Some(ValueSourceKind::RequestQuery)
|
|
} else if wrapper_type_matches(type_text, &["Json", "Form"]) {
|
|
Some(ValueSourceKind::RequestBody)
|
|
} else if wrapper_type_matches(type_text, &["State", "Extension"]) || binding == "session" {
|
|
Some(ValueSourceKind::Session)
|
|
} else {
|
|
None
|
|
}
|
|
}
|
|
|
|
fn classify_actix_param(binding: &str, type_text: &str) -> Option<ValueSourceKind> {
|
|
if wrapper_type_matches(type_text, &["Path"]) {
|
|
Some(ValueSourceKind::RequestParam)
|
|
} else if wrapper_type_matches(type_text, &["Query"]) {
|
|
Some(ValueSourceKind::RequestQuery)
|
|
} else if wrapper_type_matches(type_text, &["Json", "Form"]) {
|
|
Some(ValueSourceKind::RequestBody)
|
|
} else if wrapper_type_matches(type_text, &["Session", "Identity", "ReqData"])
|
|
|| binding == "session"
|
|
{
|
|
Some(ValueSourceKind::Session)
|
|
} else {
|
|
None
|
|
}
|
|
}
|
|
|
|
fn classify_rocket_param(
|
|
binding: &str,
|
|
type_text: &str,
|
|
path_names: &[String],
|
|
query_names: &[String],
|
|
) -> Option<ValueSourceKind> {
|
|
if wrapper_type_matches(type_text, &["Json", "Form"]) {
|
|
Some(ValueSourceKind::RequestBody)
|
|
} else if wrapper_type_matches(type_text, &["State", "Session"]) || binding == "session" {
|
|
Some(ValueSourceKind::Session)
|
|
} else if query_names.iter().any(|name| name == binding) {
|
|
Some(ValueSourceKind::RequestQuery)
|
|
} else if path_names.iter().any(|name| name == binding) {
|
|
Some(ValueSourceKind::RequestParam)
|
|
} else {
|
|
None
|
|
}
|
|
}
|
|
|
|
fn classify_guard_type(type_text: &str) -> Option<AuthCheckKind> {
|
|
let lower = type_text.to_ascii_lowercase();
|
|
if is_extractor_wrapper(&lower) {
|
|
return None;
|
|
}
|
|
if lower.contains("admin") {
|
|
Some(AuthCheckKind::AdminGuard)
|
|
} else if lower.contains("user")
|
|
|| lower.contains("auth")
|
|
|| lower.contains("session")
|
|
|| lower.contains("identity")
|
|
{
|
|
Some(AuthCheckKind::LoginGuard)
|
|
} else {
|
|
None
|
|
}
|
|
}
|
|
|
|
fn classify_rocket_guard_type(
|
|
type_text: &str,
|
|
binding: &str,
|
|
path_names: &[String],
|
|
query_names: &[String],
|
|
) -> Option<AuthCheckKind> {
|
|
if path_names.iter().any(|name| name == binding)
|
|
|| query_names.iter().any(|name| name == binding)
|
|
{
|
|
return None;
|
|
}
|
|
classify_guard_type(type_text)
|
|
}
|
|
|
|
fn is_extractor_wrapper(lower: &str) -> bool {
|
|
lower.contains("path<")
|
|
|| lower.contains("query<")
|
|
|| lower.contains("json<")
|
|
|| lower.contains("form<")
|
|
|| lower.contains("state<")
|
|
|| lower.contains("extension<")
|
|
|| lower.contains("web::")
|
|
}
|
|
|
|
fn wrapper_type_matches(type_text: &str, wrappers: &[&str]) -> bool {
|
|
let normalized = type_text.replace(' ', "");
|
|
wrappers.iter().any(|wrapper| {
|
|
normalized.contains(&format!("{wrapper}<")) || normalized.contains(&format!("::{wrapper}<"))
|
|
})
|
|
}
|
|
|
|
fn rust_binding_name(param_text: &str) -> String {
|
|
let before_colon = param_text.split(':').next().unwrap_or(param_text).trim();
|
|
let tokens: Vec<&str> = before_colon
|
|
.split(|ch: char| !(ch.is_ascii_alphanumeric() || ch == '_'))
|
|
.filter(|token| !token.is_empty() && *token != "mut")
|
|
.collect();
|
|
tokens.last().copied().unwrap_or_default().to_string()
|
|
}
|
|
|
|
fn rust_param_type_text(param: Node<'_>, bytes: &[u8], param_text: &str) -> String {
|
|
param
|
|
.child_by_field_name("type")
|
|
.map(|node| text(node, bytes))
|
|
.or_else(|| {
|
|
param_text
|
|
.split_once(':')
|
|
.map(|(_, ty)| ty.trim().to_string())
|
|
})
|
|
.unwrap_or_default()
|
|
}
|
|
|
|
fn route_placeholder_names(route_path: &str) -> Vec<String> {
|
|
route_path
|
|
.split(['/', '<', '>', ':', '{', '}'])
|
|
.filter(|segment| !segment.is_empty())
|
|
.filter(|segment| !segment.contains('?'))
|
|
.filter(|segment| {
|
|
route_path.contains(&format!("<{segment}>"))
|
|
|| route_path.contains(&format!(":{segment}"))
|
|
|| route_path.contains(&format!("{{{segment}}}"))
|
|
})
|
|
.map(|segment| segment.to_string())
|
|
.collect()
|
|
}
|
|
|
|
fn route_query_placeholder_names(route_path: &str) -> Vec<String> {
|
|
let Some((_, query)) = route_path.split_once('?') else {
|
|
return Vec::new();
|
|
};
|
|
query
|
|
.split('&')
|
|
.filter_map(|segment| {
|
|
if let Some(name) = segment.strip_prefix('<').and_then(|s| s.strip_suffix('>')) {
|
|
Some(name.to_string())
|
|
} else {
|
|
segment
|
|
.split('=')
|
|
.next()
|
|
.map(str::trim)
|
|
.filter(|name| !name.is_empty())
|
|
.map(|name| name.to_string())
|
|
}
|
|
})
|
|
.collect()
|
|
}
|
|
|
|
fn type_last_segment(type_text: &str) -> String {
|
|
type_text
|
|
.trim_start_matches('&')
|
|
.split(|ch: char| !(ch.is_ascii_alphanumeric() || ch == '_' || ch == ':'))
|
|
.find(|segment| !segment.is_empty())
|
|
.and_then(|segment| segment.rsplit("::").next())
|
|
.unwrap_or_default()
|
|
.to_string()
|
|
}
|
|
|
|
pub(crate) fn expanded_guard_call_sites(node: Node<'_>, bytes: &[u8]) -> Vec<CallSite> {
|
|
let mut calls = call_sites_from_value(node, bytes);
|
|
if node.kind() == "call_expression" {
|
|
let name = call_name(node, bytes);
|
|
if matches!(
|
|
name.rsplit('.').next(),
|
|
Some("from_fn" | "from_fn_with_state" | "wrap_fn" | "fn_guard")
|
|
) && let Some(arguments) = node.child_by_field_name("arguments")
|
|
{
|
|
for arg in named_children(arguments) {
|
|
let inner = call_site_from_node(arg, bytes);
|
|
if !inner.name.is_empty() {
|
|
calls.push(inner);
|
|
}
|
|
}
|
|
}
|
|
}
|
|
dedup_call_sites(&mut calls);
|
|
calls
|
|
}
|
|
|
|
pub(crate) fn dedup_call_sites(calls: &mut Vec<CallSite>) {
|
|
let mut deduped = Vec::new();
|
|
for call in calls.drain(..) {
|
|
if !deduped.iter().any(|existing: &CallSite| {
|
|
existing.name == call.name && existing.span == call.span && existing.args == call.args
|
|
}) {
|
|
deduped.push(call);
|
|
}
|
|
}
|
|
*calls = deduped;
|
|
}
|
|
|
|
pub(crate) fn apply_aliases(
|
|
unit: &mut crate::auth_analysis::model::AnalysisUnit,
|
|
aliases: &HashMap<String, ValueSourceKind>,
|
|
) {
|
|
for value in &mut unit.value_refs {
|
|
apply_alias_to_value(value, aliases);
|
|
}
|
|
for check in &mut unit.auth_checks {
|
|
for subject in &mut check.subjects {
|
|
apply_alias_to_value(subject, aliases);
|
|
}
|
|
}
|
|
for op in &mut unit.operations {
|
|
for subject in &mut op.subjects {
|
|
apply_alias_to_value(subject, aliases);
|
|
}
|
|
}
|
|
unit.context_inputs = unit
|
|
.value_refs
|
|
.iter()
|
|
.filter(|value| {
|
|
matches!(
|
|
value.source_kind,
|
|
ValueSourceKind::RequestParam
|
|
| ValueSourceKind::RequestBody
|
|
| ValueSourceKind::RequestQuery
|
|
| ValueSourceKind::Session
|
|
)
|
|
})
|
|
.cloned()
|
|
.collect();
|
|
}
|
|
|
|
fn apply_alias_to_value(value: &mut ValueRef, aliases: &HashMap<String, ValueSourceKind>) {
|
|
let root = value
|
|
.base
|
|
.as_deref()
|
|
.and_then(first_identifier)
|
|
.or_else(|| first_identifier(&value.name));
|
|
let Some(root) = root else {
|
|
return;
|
|
};
|
|
let Some(kind) = aliases.get(root) else {
|
|
return;
|
|
};
|
|
|
|
if value.source_kind == ValueSourceKind::ArrayIndex && *kind != ValueSourceKind::Session {
|
|
return;
|
|
}
|
|
|
|
value.source_kind = *kind;
|
|
}
|
|
|
|
fn first_identifier(input: &str) -> Option<&str> {
|
|
let mut end = input.len();
|
|
for (idx, ch) in input.char_indices() {
|
|
if !(ch.is_ascii_alphanumeric() || ch == '_') {
|
|
end = idx;
|
|
break;
|
|
}
|
|
}
|
|
if end == 0 { None } else { Some(&input[..end]) }
|
|
}
|
|
|
|
pub(crate) fn inject_guard_checks(
|
|
unit: &mut crate::auth_analysis::model::AnalysisUnit,
|
|
guard_calls: &[CallSite],
|
|
rules: &AuthAnalysisRules,
|
|
) {
|
|
let line = unit.line;
|
|
for call in guard_calls {
|
|
let kind = if rules.is_admin_guard(&call.name, &call.args) {
|
|
AuthCheckKind::AdminGuard
|
|
} else if rules.is_login_guard(&call.name) {
|
|
AuthCheckKind::LoginGuard
|
|
} else {
|
|
continue;
|
|
};
|
|
unit.auth_checks.push(AuthCheck {
|
|
kind,
|
|
callee: call.name.clone(),
|
|
subjects: Vec::new(),
|
|
span: call.span,
|
|
line,
|
|
args: call.args.clone(),
|
|
condition_text: None,
|
|
});
|
|
}
|
|
}
|