mirror of
https://github.com/elicpeter/nyx.git
synced 2026-06-12 19:55:14 +02:00
refactor(dynamic): introduce build pools for Python, C, C++, Go, Ruby, PHP, and Node.js with shared caching and warming improvements; enhance test coverage with micro-benchmarks
This commit is contained in:
parent
3d710c856d
commit
bd76cd5b9d
20 changed files with 2123 additions and 23 deletions
115
tests/dynamic_ruby_build_pool.rs
Normal file
115
tests/dynamic_ruby_build_pool.rs
Normal file
|
|
@ -0,0 +1,115 @@
|
|||
//! Phase 23 / Track O.1 micro-benchmark for the Ruby build pool.
|
||||
//!
|
||||
//! Asserts the `prepare_ruby` hot path stays ≤ 200ms, the interpreted budget.
|
||||
//!
|
||||
//! A warm Bootsnap/Bundler cache hit needs real gems, which means a network
|
||||
//! fetch — flaky offline. The deterministic, offline-safe hot path is the
|
||||
//! no-`Gemfile` cheap leg `prepare_ruby` takes for gem-free projects, which is
|
||||
//! the path actually exercised most in a scan. We benchmark that.
|
||||
|
||||
#![cfg(feature = "dynamic")]
|
||||
|
||||
use std::sync::{Mutex, MutexGuard};
|
||||
use std::time::{Duration, Instant};
|
||||
|
||||
use nyx_scanner::dynamic::build_sandbox::prepare_ruby;
|
||||
use nyx_scanner::dynamic::spec::{
|
||||
EntryKind, HarnessSpec, JavaToolchain, PayloadSlot, SpecDerivationStrategy,
|
||||
};
|
||||
use nyx_scanner::labels::Cap;
|
||||
use nyx_scanner::symbol::Lang;
|
||||
|
||||
static ENV_LOCK: Mutex<()> = Mutex::new(());
|
||||
|
||||
struct CacheGuard {
|
||||
_lock: MutexGuard<'static, ()>,
|
||||
prior_cache: Option<String>,
|
||||
prior_pool: Option<String>,
|
||||
_cache: tempfile::TempDir,
|
||||
_pool: tempfile::TempDir,
|
||||
}
|
||||
|
||||
impl CacheGuard {
|
||||
fn isolated() -> Self {
|
||||
let lock = ENV_LOCK.lock().unwrap_or_else(|p| p.into_inner());
|
||||
let cache = tempfile::TempDir::new().unwrap();
|
||||
let pool = tempfile::TempDir::new().unwrap();
|
||||
let prior_cache = std::env::var("NYX_BUILD_CACHE").ok();
|
||||
let prior_pool = std::env::var("NYX_BUILD_POOL_DIR").ok();
|
||||
unsafe {
|
||||
std::env::set_var("NYX_BUILD_CACHE", cache.path());
|
||||
std::env::set_var("NYX_BUILD_POOL_DIR", pool.path());
|
||||
}
|
||||
Self {
|
||||
_lock: lock,
|
||||
prior_cache,
|
||||
prior_pool,
|
||||
_cache: cache,
|
||||
_pool: pool,
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
impl Drop for CacheGuard {
|
||||
fn drop(&mut self) {
|
||||
restore("NYX_BUILD_CACHE", self.prior_cache.take());
|
||||
restore("NYX_BUILD_POOL_DIR", self.prior_pool.take());
|
||||
}
|
||||
}
|
||||
|
||||
fn restore(key: &str, prior: Option<String>) {
|
||||
match prior {
|
||||
Some(v) => unsafe { std::env::set_var(key, v) },
|
||||
None => unsafe { std::env::remove_var(key) },
|
||||
}
|
||||
}
|
||||
|
||||
fn median(mut ds: Vec<Duration>) -> Duration {
|
||||
ds.sort();
|
||||
ds[ds.len() / 2]
|
||||
}
|
||||
|
||||
fn mk_spec() -> HarnessSpec {
|
||||
HarnessSpec {
|
||||
finding_id: "bench".to_owned(),
|
||||
entry_file: "entry".to_owned(),
|
||||
entry_name: "main".to_owned(),
|
||||
entry_kind: EntryKind::Function,
|
||||
lang: Lang::Ruby,
|
||||
toolchain_id: "bench-ruby".to_owned(),
|
||||
payload_slot: PayloadSlot::Param(0),
|
||||
expected_cap: Cap::CODE_EXEC,
|
||||
constraint_hints: vec![],
|
||||
sink_file: "sink".to_owned(),
|
||||
sink_line: 1,
|
||||
spec_hash: "0000000000000000".to_owned(),
|
||||
derivation: SpecDerivationStrategy::FromFlowSteps,
|
||||
stubs_required: vec![],
|
||||
framework: None,
|
||||
java_toolchain: JavaToolchain::default(),
|
||||
}
|
||||
}
|
||||
|
||||
#[test]
|
||||
#[ignore = "real-toolchain perf bench: spawns `bundle`. Opt-in so the default suite stays hermetic + fast. Run: cargo nextest run --features dynamic --run-ignored ignored-only -E 'binary(~build_pool) | binary(~compile_pool)'"]
|
||||
fn warm_prepare_p50_under_200ms() {
|
||||
let _guard = CacheGuard::isolated();
|
||||
let spec = mk_spec();
|
||||
let work = tempfile::TempDir::new().unwrap();
|
||||
|
||||
prepare_ruby(&spec, work.path()).expect("gem-free prepare_ruby must succeed");
|
||||
|
||||
let mut hot = Vec::new();
|
||||
for _ in 0..5 {
|
||||
let start = Instant::now();
|
||||
prepare_ruby(&spec, work.path()).expect("prepare_ruby must succeed");
|
||||
hot.push(start.elapsed());
|
||||
}
|
||||
|
||||
let p50 = median(hot);
|
||||
eprintln!("ruby build-pool warm P50: {p50:?}");
|
||||
assert!(
|
||||
p50 <= Duration::from_millis(200),
|
||||
"ruby prepare P50 {p50:?} exceeds the 200ms interpreted budget",
|
||||
);
|
||||
}
|
||||
Loading…
Add table
Add a link
Reference in a new issue