new capacity bits (#67)

This commit is contained in:
Eli Peter 2026-05-07 01:29:31 -04:00 committed by GitHub
parent afaffc0df6
commit 7d0e7320e2
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
261 changed files with 10591 additions and 231 deletions

View file

@ -0,0 +1,14 @@
// Baseline: expression is a compile-time constant. No taint reaches
// `xpath.evaluate` so no XPATH_INJECTION finding fires.
import javax.xml.xpath.XPath;
import javax.xml.xpath.XPathConstants;
import javax.xml.xpath.XPathFactory;
import org.w3c.dom.Document;
import org.w3c.dom.NodeList;
public class BaselineConstantXpath {
public NodeList lookup(Document doc) throws Exception {
XPath xpath = XPathFactory.newInstance().newXPath();
return (NodeList) xpath.evaluate("//user[@role='admin']", doc, XPathConstants.NODESET);
}
}

View file

@ -0,0 +1,26 @@
// Parameterised XPath: user input is bound via XPathVariableResolver
// (RFC-correct parameterisation) and the expression itself is a compile-time
// constant. Even with the variable-resolver call preceding the evaluate(),
// the expression argument is not taint-bearing, so no XPATH_INJECTION
// finding fires.
import javax.xml.namespace.QName;
import javax.xml.xpath.XPath;
import javax.xml.xpath.XPathConstants;
import javax.xml.xpath.XPathFactory;
import javax.xml.xpath.XPathVariableResolver;
import javax.servlet.http.HttpServletRequest;
import org.w3c.dom.Document;
import org.w3c.dom.NodeList;
public class ParameterizedXpath {
public NodeList lookup(HttpServletRequest req, Document doc) throws Exception {
final String user = req.getParameter("user");
XPath xpath = XPathFactory.newInstance().newXPath();
xpath.setXPathVariableResolver(new XPathVariableResolver() {
public Object resolveVariable(QName name) {
return user;
}
});
return (NodeList) xpath.evaluate("//user[name=$u]", doc, XPathConstants.NODESET);
}
}

View file

@ -0,0 +1,23 @@
// Safe: user-supplied substring routed through the project-local
// `escapeXpath` helper before being concatenated into the XPath expression.
// The sanitizer clears the XPATH_INJECTION cap so the sink does not fire.
import javax.xml.xpath.XPath;
import javax.xml.xpath.XPathConstants;
import javax.xml.xpath.XPathFactory;
import javax.servlet.http.HttpServletRequest;
import org.w3c.dom.Document;
import org.w3c.dom.NodeList;
public class SafeXPathQuery {
public static String escapeXpath(String raw) {
return raw.replace("'", "'");
}
public NodeList lookup(HttpServletRequest req, Document doc) throws Exception {
String user = req.getParameter("user");
String safe = escapeXpath(user);
String expr = "//user[name='" + safe + "']";
XPath xpath = XPathFactory.newInstance().newXPath();
return (NodeList) xpath.evaluate(expr, doc, XPathConstants.NODESET);
}
}

View file

@ -0,0 +1,36 @@
// Tainted-expression-with-resolver: user input flows into the XPath
// expression argument, but the receiver was bound to an
// XPathVariableResolver before the evaluate() call. Phase 03's
// name-only `setXPathVariableResolver` sanitizer rule would not have
// suppressed this (the rule fires on the resolver-binding call, which
// has no flow-tied taint to clear). The receiver-config sidecar in
// `src/ssa/xpath_config.rs` flips `has_resolver` on the bound XPath
// instance and the SSA sink-emission site strips XPATH_INJECTION from
// any later evaluate() on that receiver.
import javax.xml.namespace.QName;
import javax.xml.xpath.XPath;
import javax.xml.xpath.XPathConstants;
import javax.xml.xpath.XPathFactory;
import javax.xml.xpath.XPathVariableResolver;
import javax.servlet.http.HttpServletRequest;
import org.w3c.dom.Document;
import org.w3c.dom.NodeList;
public class TaintedParameterizedXpath {
public NodeList lookup(HttpServletRequest req, Document doc) throws Exception {
final String user = req.getParameter("user");
XPath xpath = XPathFactory.newInstance().newXPath();
xpath.setXPathVariableResolver(new XPathVariableResolver() {
public Object resolveVariable(QName name) {
return user;
}
});
// Tainted expression interpolation: user bypasses the resolver
// and reaches `evaluate` directly. Real-world parameterised
// XPath would use a constant expression with `$u` here, but the
// engineering decision modelled by the sidecar is: a bound
// resolver indicates intended parameterisation, so suppress.
String expr = "//user[name='" + user + "']";
return (NodeList) xpath.evaluate(expr, doc, XPathConstants.NODESET);
}
}

View file

@ -0,0 +1,17 @@
// Unsafe: attacker-controlled username concatenated into an XPath expression
// passed to XPath.evaluate. The flat matcher catches the qualified call.
import javax.xml.xpath.XPath;
import javax.xml.xpath.XPathConstants;
import javax.xml.xpath.XPathFactory;
import javax.servlet.http.HttpServletRequest;
import org.w3c.dom.Document;
import org.w3c.dom.NodeList;
public class UnsafeXPathQuery {
public NodeList lookup(HttpServletRequest req, Document doc) throws Exception {
String user = req.getParameter("user");
String expr = "//user[name='" + user + "']";
XPath xpath = XPathFactory.newInstance().newXPath();
return (NodeList) xpath.evaluate(expr, doc, XPathConstants.NODESET);
}
}