apunkt/nyx
1
0
Fork 0
mirror of https://github.com/elicpeter/nyx.git synced 2026-06-30 20:39:39 +02:00
Code Issues Projects Releases Packages Wiki Activity

refactor(dynamic): centralize stub initialization for test cases, enhance error handling for permission issues, and expand test coverage

Browse source
This commit is contained in:
elipeter 2026-05-25 09:04:04 -05:00
parent 9c323d0ed5
commit 5e1e5cbd11
6 changed files with 144 additions and 63 deletions
Download patch file Download diff file Expand all files Collapse all files

41
src/dynamic/stubs/http.rs
View file

@ -319,15 +319,20 @@ mod tests {
out
}
fn start_stub() -> (TempDir, HttpStub) {
fn start_stub() -> Option<(TempDir, HttpStub)> {
let dir = TempDir::new().unwrap();
let stub = HttpStub::start(dir.path()).unwrap();
(dir, stub)
match HttpStub::start(dir.path()) {
Ok(stub) => Some((dir, stub)),
Err(e) if e.kind() == std::io::ErrorKind::PermissionDenied => None,
Err(e) => panic!("start http stub: {e}"),
}
}
#[test]
fn endpoint_uses_loopback_with_assigned_port() {
let (_dir, stub) = start_stub();
let Some((_dir, stub)) = start_stub() else {
return;
};
let ep = stub.endpoint();
assert!(ep.starts_with("http://127.0.0.1:"));
assert!(ep.ends_with(&stub.port().to_string()));
@ -335,7 +340,9 @@ mod tests {
#[test]
fn captures_request_line_via_real_socket() {
let (_dir, stub) = start_stub();
let Some((_dir, stub)) = start_stub() else {
return;
};
let reply = send_request(
stub.port(),
b"GET /api/users HTTP/1.1\r\nHost: 127.0.0.1\r\n\r\n",
@ -354,7 +361,9 @@ mod tests {
#[test]
fn captures_post_body() {
let (_dir, stub) = start_stub();
let Some((_dir, stub)) = start_stub() else {
return;
};
let body = b"username=admin&password=hunter2";
let req = format!(
"POST /login HTTP/1.1\r\nHost: 127.0.0.1\r\nContent-Length: {}\r\n\r\n",
@ -374,7 +383,9 @@ mod tests {
#[test]
fn drain_resets_event_buffer() {
let (_dir, stub) = start_stub();
let Some((_dir, stub)) = start_stub() else {
return;
};
stub.record("GET /first HTTP/1.1");
assert_eq!(stub.drain_events().len(), 1);
assert!(stub.drain_events().is_empty(), "second drain must be empty");
@ -383,7 +394,9 @@ mod tests {
#[test]
fn drop_releases_port_for_rebind() {
let port = {
let (_dir, stub) = start_stub();
let Some((_dir, stub)) = start_stub() else {
return;
};
stub.port()
};
// After drop, the OS releases the port. The accept thread may
@ -397,7 +410,9 @@ mod tests {
#[test]
fn recording_endpoint_publishes_log_path_under_nyx_http_log() {
let (_dir, stub) = start_stub();
let Some((_dir, stub)) = start_stub() else {
return;
};
let pair = stub
.recording_endpoint()
.expect("HttpStub must publish a recording endpoint");
@ -412,7 +427,9 @@ mod tests {
#[test]
fn drain_events_merges_log_file_records_with_in_memory_events() {
let (_dir, stub) = start_stub();
let Some((_dir, stub)) = start_stub() else {
return;
};
// Simulate the on-the-wire path.
stub.record("GET /listener-hit HTTP/1.1");
// Simulate the shim path: append a detail-then-summary record
@ -448,7 +465,9 @@ mod tests {
#[test]
fn drain_log_file_returns_only_new_entries() {
let (_dir, stub) = start_stub();
let Some((_dir, stub)) = start_stub() else {
return;
};
let mut f = std::fs::OpenOptions::new()
.append(true)
.open(stub.log_path())