refactor(dynamic): enhance framework bindings with SSA receiver type checks, add tests for Laravel, Symfony, Rabbit, Kafka, and Pub/Sub

src/dynamic/framework/adapters/kafka_python.rs

@@ -11,6 +11,7 @@
 use crate::dynamic::framework::{FrameworkAdapter, FrameworkBinding};
 use crate::evidence::EntryKind;
 use crate::summary::FuncSummary;
+use crate::summary::ssa_summary::SsaFuncSummary;
 use crate::symbol::Lang;
 
 pub struct KafkaPythonAdapter;
@@ -67,32 +68,64 @@ impl FrameworkAdapter for KafkaPythonAdapter {
     fn detect(
         &self,
         summary: &FuncSummary,
-        _ast: tree_sitter::Node<'_>,
+        ast: tree_sitter::Node<'_>,
         file_bytes: &[u8],
     ) -> Option<FrameworkBinding> {
-        let matches_call = super::any_callee_matches(summary, callee_is_kafka_consumer);
-        let matches_source = source_imports_kafka(file_bytes);
-        if matches_call || matches_source {
-            Some(FrameworkBinding {
-                adapter: ADAPTER_NAME.to_owned(),
-                kind: EntryKind::MessageHandler {
-                    queue: extract_topic_literal(file_bytes),
-                    message_schema: None,
-                },
-                route: None,
-                request_params: Vec::new(),
-                response_writer: None,
-                middleware: Vec::new(),
-            })
-        } else {
-            None
-        }
+        detect_kafka_python(summary, None, ast, file_bytes)
     }
+
+    fn detect_with_context(
+        &self,
+        summary: &FuncSummary,
+        ssa_summary: Option<&SsaFuncSummary>,
+        ast: tree_sitter::Node<'_>,
+        file_bytes: &[u8],
+    ) -> Option<FrameworkBinding> {
+        detect_kafka_python(summary, ssa_summary, ast, file_bytes)
+    }
+}
+
+fn detect_kafka_python(
+    summary: &FuncSummary,
+    ssa_summary: Option<&SsaFuncSummary>,
+    _ast: tree_sitter::Node<'_>,
+    file_bytes: &[u8],
+) -> Option<FrameworkBinding> {
+    let matches_call = super::any_callee_matches(summary, callee_is_kafka_consumer);
+    let matches_source = source_imports_kafka(file_bytes);
+    if !(matches_call || matches_source) {
+        return None;
+    }
+    if !super::typed_receiver_facts_allow(
+        summary,
+        ssa_summary,
+        callee_is_kafka_consumer,
+        typed_container_allows_kafka,
+    ) {
+        return None;
+    }
+    Some(FrameworkBinding {
+        adapter: ADAPTER_NAME.to_owned(),
+        kind: EntryKind::MessageHandler {
+            queue: extract_topic_literal(file_bytes),
+            message_schema: None,
+        },
+        route: None,
+        request_params: Vec::new(),
+        response_writer: None,
+        middleware: Vec::new(),
+    })
+}
+
+fn typed_container_allows_kafka(container: &str) -> bool {
+    let lc = container.to_ascii_lowercase();
+    lc.contains("kafka") || lc.contains("consumer")
 }
 
 #[cfg(test)]
 mod tests {
     use super::*;
+    use crate::summary::CalleeSite;
 
     fn parse_python(src: &[u8]) -> tree_sitter::Tree {
         let mut parser = tree_sitter::Parser::new();
@@ -135,4 +168,53 @@ mod tests {
                 .is_none()
         );
     }
+
+    #[test]
+    fn ssa_receiver_type_rejects_non_kafka_poll_collision() {
+        let src: &[u8] = b"from kafka import KafkaConsumer\n\
+            def handler(msg):\n    cache.poll(msg)\n";
+        let tree = parse_python(src);
+        let mut summary = FuncSummary {
+            name: "handler".into(),
+            ..Default::default()
+        };
+        summary.callees.push(CalleeSite {
+            name: "cache.poll".to_owned(),
+            receiver: Some("cache".to_owned()),
+            ordinal: 0,
+            ..Default::default()
+        });
+        let mut ssa = SsaFuncSummary::default();
+        ssa.typed_call_receivers.push((0, "Cache".to_owned()));
+        assert!(
+            KafkaPythonAdapter
+                .detect_with_context(&summary, Some(&ssa), tree.root_node(), src)
+                .is_none()
+        );
+    }
+
+    #[test]
+    fn ssa_receiver_type_keeps_kafka_consumer() {
+        let src: &[u8] = b"from kafka import KafkaConsumer\n\
+            def handler(msg):\n    consumer.poll()\n";
+        let tree = parse_python(src);
+        let mut summary = FuncSummary {
+            name: "handler".into(),
+            ..Default::default()
+        };
+        summary.callees.push(CalleeSite {
+            name: "consumer.poll".to_owned(),
+            receiver: Some("consumer".to_owned()),
+            ordinal: 0,
+            ..Default::default()
+        });
+        let mut ssa = SsaFuncSummary::default();
+        ssa.typed_call_receivers
+            .push((0, "KafkaConsumer".to_owned()));
+        assert!(
+            KafkaPythonAdapter
+                .detect_with_context(&summary, Some(&ssa), tree.root_node(), src)
+                .is_some()
+        );
+    }
 }