Release/0.5.0 (#35)
* feat: Introduce function-scoped variable interning for state analysis with new tests and fixtures
* feat: Add Phase 26 symbolic execution enhancements with bitwise operator support, abstract interpretation refinements, and new taint analysis tests
* feat: Refine state analysis to handle factory-pattern resource returns with mixed-path tests and leak detection enhancements
* feat: Add Phase 27 debug views with symbolic execution, abstract interpretation, SSA, and call graph viewers; integrate with debug layout and styles
* feat: Add Phase 31 type-qualified symbolic resolution with receiver-based callee disambiguation and testing
* feat: Extend symbolic execution with state iteration, enhanced debug views, and debounced input handling
* feat: Add Phase 13 resource and auth pattern extensions with new tests and fixtures
* feat: Introduce CFG debug graph renderer with compact mode, toolbar, and DAG layout integration
* feat: Add Phase 28 encoding and decoding transform modeling with structural symex enhancements and new taint analysis tests
* feat: Extend abstract interpretation with type facts and constant value tracking in debug views and server logic
* feat: Add linear path handling and witness extraction to symbolic execution with Phase 28 transform mismatch detection
* feat: Refine Go auth and sanitizer handling with enhanced rules, state updates, and benchmark improvements
* feat: Enable auth-state analysis by default and update relevant tests in benchmark config
* test: Update state_tests to reflect default enablement of auth-state analysis and add auth suppression test
* docs: update CHANGELOG.md
* feat: Introduce per-index taint tracking in `HeapState` with `HeapSlot`, overflow handling, and revised SSA transfers
* feat: Introduce C/C++ language labels and refine heap state tracking in SSA transfers
* feat: Implement per-index array slot tracking in symbolic heap with overflow collapse
* feat: Add implicit definition handling for uninitialized declarations in SSA value allocation
* feat: Refactor function parameters and constants for improved clarity and maintainability
* refactor: Reorder module imports and improve formatting for consistency
* refactor: Fix formatting erorrs
* refactor: Fix clippy warnings
* refactor: Fix fmt warnings (again)
* chore: Update dependencies and improve feature configuration
* Add comprehensive tests for undertested modules (#36) (COPILOT)
* Add comprehensive tests for undertested modules
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/f3fc877e-f386-49ba-9793-fc93d3805083
* Add comprehensive tests for ext, project, walk, and errors modules
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/f3fc877e-f386-49ba-9793-fc93d3805083
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
* chore: Update dependencies and improve feature configuration
* fix: formatting errors in new tests
* chore: Update license list in about.toml
* chore: made functions input inline
* chore: updated cfg graph to take up the full page
* chore: add Prettier configuration and update code formatting
* Add frontend test suite with Vitest (111 tests) (#37)
* Add Vitest test suite for frontend - 111 tests across utils, components, hooks, and graph utilities
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/7cf0dba2-ecff-4740-ba4d-92717e74a0b7
* ci: add frontend test step to CI workflow
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/5bc0ac9f-0a32-4d03-9cb7-7a15aea53fca
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
* chore: simplify array initialization in test files for consistency
* ran typecheck
* feat: add AnalysisWorkspace component and integrate it into CfgViewerPage
* feat: update routing in AppLayout and improve empty state message in ExplorerPage
* feat: enhance scan progress tracking with additional metrics and stages
* feat: update license information and add license check script
* feat: implement cross-file symbolic execution with callee body persistence
* feat: replace dagre graphs with Graphology + ELK + Sigma for more advanced call stack and cfg rendering
* feat: ensure CFG function view is scoped to the selected function, preventing bleed into sibling functions
* feat: enhance resource tracking with proxy method summaries and improve finding extraction
* feat: add terminal function exit detection for accurate resource leak analysis
* feat: add warnings for loops and functions without bodies to improve error recovery
* feat: update lambda expression handling to ensure proper function classification and control flow
* feat: remove bounded formatting/string ops and add JSON.parse sanitizer for improved data handling
* feat: add inline return taint analysis and regression tests for improved security checks
* feat: add engine version management and migration handling for database schema updates
* feat: enhance first_call_ident to skip nested function bodies and add regression tests
* feat: enhance callee name resolution with two-segment normalization and disambiguation
* feat: add cross-file context flags and debug assertions for taint analysis
* feat: refactor taint analysis structure to unify context handling and improve clarity
* feat: enhance dead code elimination to preserve Sink, Source, and Sanitizer labels with new tests
* docs: updated CHANGELOG.md
* fmt: formatting fixes
* fix: fixed frontend formatting and lint warnings
* fix: optimized ci
* fix: optimized ci
* Add comprehensive multi-file test coverage to Nyx (#38)
* Initial checklist for multi-file test suite expansion
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/e550cb88-9767-4442-94d4-101bf5bb0e23
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
* Add 12 new multi-file test fixtures with TP/TN/near-miss coverage
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/e550cb88-9767-4442-94d4-101bf5bb0e23
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
* deleted root repo
* rebuilt to test for regressions
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
Co-authored-by: elipeter <elicpeter@gmail.com>
* feat: enhance import alias resolution and taint tracking
* feat: implement security hardening with CSRF protection and path validation
* feat: add support for import alias bindings in Python, PHP, and Rust
* feat: enhance CFG analysis modes and improve code readability
* feat: add detection for parameterized SQL queries to enhance security
* feat: add safe internal redirect handling and enhance session destroy validation
* feat: implement security improvements by addressing vulnerabilities in execAsync, session management, and file downloads
* feat: enhance taint detection by adding support for inline source member expressions in call arguments
* feat: implement pre-emission of Source nodes for inline source member expressions in call arguments
* feat: add support for Throw statement in control flow and error handling
* feat: add debug and echo endpoints with potential information leakage
* feat: implement internal redirect suppression and enhance taint detection
* feat: implement module alias tracking for dynamic dispatch in JS/TS
* feat: add authorization analysis module with Express support
* feat: add authorization analysis module with Express support
* feat: add tests for admin guard requirements and clean checks in authorization analysis
* feat: integrate Koa and Fastify frameworks into authorization analysis
* feat: add Flask and Django support to authorization analysis module
* feat: add support for Rails and Sinatra frameworks in authorization analysis
* feat: add support for Axum, ActixWeb, and Rocket frameworks in authorization analysis
* feat: add support for ActixWeb, Axum, and Rocket frameworks in authorization analysis
* feat: add support for Rails and Sinatra in authorization analysis
* chore: add .DS_Store to .gitignore
* refactor: simplify conditional checks and improve readability in multiple files
* refactor: update usage of Option methods for improved clarity and consistency
* refactor: improve code readability by simplifying conditional checks and formatting
* refactor: improve code formatting and readability by simplifying conditional checks
* refactor: simplify conditional checks and improve readability in multiple files
* refactor: simplify conditional checks in axum.rs for improved readability
* feat: add CodeQL analysis configuration for enhanced security scanning
* test: add comprehensive tests for `src/output.rs` SARIF builder (#39)
* chore: start test coverage improvement work
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/cd7ff398-134e-4728-a5e7-0353a0744423
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
* test: add comprehensive tests for src/output.rs SARIF builder
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/cd7ff398-134e-4728-a5e7-0353a0744423
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
* refactor: improve code formatting and readability in output.rs
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
Co-authored-by: elipeter <elicpeter@gmail.com>
* refactor: improve code formatting and readability in output.rs
* Potential fix for code scanning alert no. 210: Uncontrolled data used in path expression
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
* Potential fix for code scanning alert no. 211: Uncontrolled data used in path expression
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
* refactor: enhance triage file path handling with improved error management and validation
* refactor: updated func summaries for richer detail
* refactor: update SSA summary extraction to use canonical FuncKey for distinct entries
* refactor: enhance callee metadata structure to support arity, receiver, and qualifier for better overload resolution
* refactor: add support for keyword arguments in function calls and enhance receiver extraction for method-style calls
* refactor: implement new Flask routes for safe and unsafe shell command execution
* refactor: separate receiver handling in SSA operations and enhance taint propagation
* refactor: improve arity handling by using arg_uses for positional argument count and enhance witness scoring for tainted arguments
* refactor: implement auth decorator extraction and classification for multiple languages
* refactor: enhance Rust module path resolution and use map handling for cross-file disambiguation
* refactor: introduce CalleeQuery struct for structured callee resolution and enhance resolver logic
* refactor: implement same-file identity collision handling for `runTask` to ensure correct resolver behavior
* refactor: standardize default struct initialization across multiple files
* feat: add scripts for formatting checks and auto-fixes with test summaries
* refactor: simplify character splitting and enhance namespace qualifier handling
* refactor: improve documentation clarity and enhance code readability in resolver logic
* refactor: replace default struct initialization with explicit field assignments for clarity
* feat: enhance anonymous function naming by deriving context-based bindings
* refactor: streamline match expressions for improved readability and performance
* refactor: streamline match expressions for improved readability and performance
* refactor: replace loop with while let for improved clarity and performance
* feat: add SSA constant propagation support to analysis context for improved accuracy
* feat: add SSA constant propagation support to analysis context for improved accuracy
* feat: implement shell metacharacter validation and bounded-length checks in Rust analysis
* feat: add static map analysis for command injection suppression and type safety
* refactor: simplify match statements and reduce line breaks for improved readability
* feat(summary): phase 1/5 SinkSite data model for primary sink-location attribution
Introduce SinkSite (file_rel, line, col, snippet, cap) carrying the
primary sink source-location through function summaries. Swap
SsaFuncSummary.param_to_sink and FuncSummary.param_to_sink from a coarse
Cap map to a deduped SmallVec<[SinkSite; 1]> per parameter, with a
backward-compatible cap_sites() helper and serde defaults so pre-phase-1
on-disk rows continue to deserialise cleanly.
Extraction: SinkSiteLocator bundles the tree/bytes/file_rel needed by
extract_ssa_func_summary; ParsedFile::extract_ssa_artifacts wires the
locator in for the persisted pass-1 path, while pass-2 intra-file
transient summaries fall back to cap-only sites (behavior unchanged).
Merge: GlobalSummaries::insert now unions sink sites with
(file_rel, line, col, cap) dedup via shared union_param_sink_sites
helper.
Database: JSON-serialised summary columns carry the new shape
automatically; no schema change needed.
Phase 2 will consume SinkSite in build_taint_diag() to overwrite the
caller-site Finding.line with the callee's sink line when resolved via
summary. Phase 1 keeps behavior unchanged: scanning
tests/benchmark/corpus/rust/cmdi/cmdi_indirect.rs still produces the
same (wrong) line 10 finding.
Adds round-trip tests covering SinkSite solo, SsaFuncSummary with sink
sites, legacy-JSON default handling for both summary types, and merge
dedup.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
* feat(taint): phase 2/5 thread SinkSite into SsaTaintEvent and Finding
Plumb Phase 1's SinkSite through the event pipeline into Findings,
no output change yet. SsaTaintEvent gains `primary_sink_site:
Option<SinkSite>`; when the main or callback sink-emission path has
non-empty `param_to_sink_sites`, filter to sites whose
`(line != 0) && (cap ∩ sink_caps != ∅)` and emit one event per
distinct site — the multi-primary collapse keeps each downstream
Finding single-primary.
Resolution: ResolvedSummary and SinkInfo gain mirror
`param_to_sink_sites` fields, populated from `SsaFuncSummary.param_to_sink`
(SSA + callback paths) and `FuncSummary.param_to_sink` (global paths).
Label, local-summary, and interop resolution paths leave the field
empty — they only ever had cap-level info to begin with.
Finding: new `primary_location: Option<SinkLocation>` with
`file_rel/line/col`. `ssa_events_to_findings` maps
`event.primary_sink_site` → `Finding.primary_location`, filtering
cap-only sites (`line == 0`) to `None` so the (0,0) sentinel never
leaks to formatters. Dedup key extended with the primary location
so multi-site events aren't collapsed back together.
Invariants (debug_assert!):
* every SinkSite reaching emission has `line != 0 && cap ∩ sink_caps
!= ∅` — enforced by the pick_primary_sink_sites* filters;
* every populated Finding.primary_location has `line != 0` AND
non-empty `file_rel` — the cap-only → None translation upstream
guarantees this.
Deliberately independent of `uses_summary`: that flag tracks whether
the *taint chain* used a summary, whereas primary attribution
requires only that the *sink* itself was summary-resolved. A local
source reaching a cross-file sink produces `uses_summary=false`
alongside a populated primary_location — documented on
Finding.primary_location, covered by
`cross_file_sink_finding_carries_primary_location`.
build_taint_diag, SARIF/JSON/explanation formatters, and the
benchmark scorer remain untouched: finding.line still comes from
`cfg_graph[finding.sink]`, so cmdi_indirect.rs still reports line 10
and the benchmark's rs-cmdi-003 row still shows FN in the LOC column.
Tests: `cross_file_sink_finding_carries_primary_location` (proves
plumbing via a synthetic FuncSummary carrying a SinkSite at 42:5) and
`cross_file_sink_cap_only_site_leaves_primary_location_none`
(regression guard against cap-only sites surfacing). All 1566 lib
tests + integration tests pass.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* feat(output): phase 3/5 consume primary sink location in diag + SARIF
When a finding's primary_location (populated in phase 2 from a callee
summary's SinkSite) names the dangerous instruction inside a callee
body, attribute the diagnostic line to that location instead of the
caller's call site. The call site is demoted to a Call step in
flow_steps, and a synthetic Sink step at the primary location is
appended so analysts still see the full trace.
Changes:
- Add scan_root parameter to build_taint_diag so file_rel can be
resolved back to an absolute path via a shared resolve_file_rel
helper. Empty file_rel (single-file scans where namespace == "")
resolves to the file under analysis.
- Extend SinkLocation with snippet, carried from the upstream
SinkSite so the formatter needs no second file read.
- Relax the ssa_events_to_findings debug_assert to allow empty
file_rel, which is valid when scan root equals the file itself.
- SARIF: emit data-flow as codeFlows[0].threadFlows[0].locations[];
locations[0] already reflects the primary sink position via the
updated diag line/col.
Acceptance: scan on tests/benchmark/corpus/rust/cmdi/cmdi_indirect.rs
now reports line 5 (Command::new) as the primary sink, with the call
site at line 10 visible in flow_steps.
Two expect.json fixtures updated (must_match line_range widened):
- javascript/taint/context_sensitive_call: 12-14 -> 7-14 (line 8 is
the real sink inside run()).
- rust/cfg/closure_async: 10-10 -> 10-11 (line 11 is Command::new
inside the closure).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* feat(bench): phase 4/5 validate primary sink attribution across corpus
Extend the benchmark scorer and ground truth to lock in phase 3's
primary-location behavior, and add fixtures that exercise the new
capability end-to-end.
Scorer (tests/benchmark_test.rs):
- Add optional `expected_call_site_lines: Option<Vec<[usize; 2]>>` on
Case. When present, score_location_level additionally requires at
least one flow_step in the finding's evidence trace to fall within
±2 of the call-site range. When absent, the check is skipped —
fully forward-compatible with existing fixtures.
- Retain ±2 tolerance on expected_sink_lines (compared against the
now-primary Diag.line post-phase-3).
Ground truth edits:
- rs-cmdi-cross-001: expected_sink_lines [8,8] -> [9,9]. Line 8 is the
transform::wrap call site (a cross-file propagator, not a sink);
line 9 is Command::new, the real sink. The ±2 tolerance happened to
mask this stale attribution but it was semantically wrong — phase 4
is the right time to correct it. Also adds expected_call_site_lines
[8,8] so the new field is exercised on an existing cross-file case.
- rs-cmdi-003: adds expected_call_site_lines [10,10] (run_cmd call).
This fixture's sink (Command::new inside run_cmd at line 5) was the
motivating case for phases 1-3; adding the call-site assertion
guards against regression to caller-line attribution.
New fixtures:
- rust/cmdi/cmdi_indirect_multisink.rs (rs-cmdi-009): helper run_both
takes two tainted params and invokes two Command sinks on
consecutive lines. Locks in that primary line lands inside the
helper (lines 5-6), not at the caller (line 12). Notes document
that SinkSite is currently one-per-callee so both findings today
collapse onto the first sink; expected_sink_lines=[5,6] and
expected_call_site_lines=[12,12] stay valid either way.
- python/cmdi/cross_indirect_sink/{app.py,helper.py} (py-cmdi-cross-
004): sink os.system lives in helper.py (cross-file), caller in
app.py reads env source and calls run_cmd. Verifies phase 3's
cross-file primary attribution: Diag.path = helper.py, Diag.line =
5, with app.py:7 recorded in flow_steps as a Call step.
Acceptance:
- `cargo test --test benchmark_test -- --ignored --nocapture` passes.
- rs-cmdi-003 is TP/TP/TP (the target flip FN->TP at LOC). All
pre-existing TP/TP/TP fixtures remain TP/TP/TP; 2 new fixtures are
TP/TP/TP.
- Aggregate rule-level: TP=158 FP=10 FN=1 TN=97, P=0.940 R=0.994
F1=0.966 on the 266-case corpus (was TP=156 FP=10 FN=1 TN=97 on
264 pre-phase-4, delta is the +2 new cases both resolving TP).
- Full `cargo test` green (1566 lib tests + all integration tests).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* feat(taint): phase 5/5 lock Finding.primary_location contract via regression test
Add a regression test in src/taint/ssa_transfer.rs that wires up a synthetic
SsaFuncSummary with a SinkSite at other.rs:42:10 and drives the three
emission stages (pick_primary_sink_sites → emit_ssa_taint_events →
ssa_events_to_findings) against a minimal caller SSA body. Asserts the
resulting Finding.primary_location is exactly that triple.
The existing integration tests in src/taint/tests.rs cover the coarse
FuncSummary path end-to-end through analyse_file. This test locks in the
lower-level SSA-side plumbing so a future refactor that silently drops the
site between pick → emit → findings fails here rather than only at the
benchmark layer.
Also refreshes tests/benchmark/results/latest.json (timestamp only; rs-cmdi-003
remains TP/TP/TP and the aggregate P/R/F1 are unchanged from phase 4).
Closes the primary sink-location attribution feature (phases 1-5/5):
* Phase 1 — SinkSite data model on summaries.
* Phase 2 — SinkSite threaded into SsaTaintEvent and Finding.
* Phase 3 — diag + SARIF consume primary_location.
* Phase 4 — benchmark validates primary_call_site_lines across corpus.
* Phase 5 — regression test locks the event→finding contract.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* refactor: clean up formatting and improve readability in multiple files
* refactor: simplify type definition for deduplication key in findings
* test(harness): add must_not_match expectation for FP regression guards
Extends ExpectedFinding with must_not_match field that asserts a
diagnostic must NOT fire — presence is a hard failure. Non-consuming
scan so it coexists with must_match entries on the same rule_id.
Adds forbidden_violations accumulator and updates summary line.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* feat(regression): update expectations to ensure must_not_match for various taint and resource leak rules
* feat: implement auto-seeding for JS/TS handler parameters to enhance taint tracking
* feat: update switch statement handling to improve control flow analysis
* feat: implement promisify alias handling for JS/TS to enhance taint tracking
* feat: enhance taint tracking by refining expectation handling and adding mode filtering
* feat: refine SQL handling in stream processing and enhance auto-seeding for handler parameters
* feat: update taint tracking rules to enforce full mode matching and improve flow analysis
* feat: enhance Ruby subshell handling to improve taint tracking and flow analysis
* feat: update xss_response expectations to refine taint flow analysis and enhance regression guarding
* feat: refine framework detection and update expectation handling for Echo and Sinatra
* feat: implement max_count for taint tracking expectations and deduplicate findings
* feat: add strict_unexpected handling for taint-unsanitised-flow in expectation files
* feat: enhance deduplication of taint-unsanitised-flow findings by collapsing based on line and severity
* feat: add strict_unexpected handling for taint-unsanitised-flow in multiple expectation files
* feat: add structural invariant checks for SSA bodies
* feat: ensure deterministic phi emission order using BTreeSet
* feat: enhance handling of terminators to ensure authoritative flow through successor edges
* feat: enhance Goto terminator handling to ensure all successors are marked executable
* feat: refactor code for improved readability and organization
* feat: simplify predicate checks and enhance readability in SSA handling
* feat: implement per-file parse timeout and enhance file size handling
* feat: migrate analysis engine toggles from environment variables to configuration file
* feat: remove unnecessary whitespace in hostile_input_tests.rs
* feat: remove unnecessary whitespace in hostile_input_tests.rs
* feat: update dependencies and enhance documentation on language maturity
* feat: enhance security headers and improve request body limits
* feat: implement sink capability bits for deduplication and enhance evidence tagging
* feat: implement dynamic activation handling for gated sinks and enhance validation logic
* feat: enhance configuration documentation and clarify inline analysis cache behavior
* feat: implement panic recovery during analysis to continue scans past errors
* feat: add expectations configuration for taint analysis and performance metrics
* feat: enhance error handling and logging during file reading and mutex locking
* feat: add cross-file body loading tests and plumbing for CF-1 phase
* feat: implement cross-file k=1 context-sensitive inline taint analysis with new tests and fixtures
* feat: implement indexed-scan parity in cross-file inline analysis with new dropdown and copy functionality
* feat: enhance classification span handling in CFG and AST for improved source attribution
* feat: add new Express routes for handling user input and telemetry data
* feat: implement ternary expression handling in CFG with diamond structure for JS/TS
* feat: implement Phase CF-3 abstract-domain transfer channels in summaries
* feat: add support for string-prefix transfer in cross-file calls and update tests
* docs: reduce RESULTS.md doc size
* feat: implement Phase CF-4 per-return-path summary decomposition with tests
* feat: update parameter handling in pass1 and refactor SsaFuncSummary initialization
* feat: implement Phase CF-5 for cross-file SCC joint fixed-point convergence with new flags and tests
* feat: implement Phase CF-6 with parameter-granularity points-to summaries and associated tests
* refactor: update comments and documentation for clarity and consistency
* style: format code for consistency and readability
* refactor: simplify verdict handling and improve edge checking logic
* refactor: optimize path and identifier collection by avoiding unnecessary cloning
* chore: update Cargo.toml for Rust version 1.85 and add ignored files; modify CHANGELOG and README for clarity on state analysis defaults
* refactor: update documentation and improve clarity in configuration files
* refactor: update documentation and improve clarity in configuration files
* feat: add JS/TS pass-2 convergence tests and expectations configuration
* feat: add Phase 5 regression tests for inline cache origin attribution and update related logic
* feat: implement Phase 7 deduplication and alternative path linking for taint findings
* feat: implement structural DFS index for anonymous functions and update naming conventions
* feat: add Phase 8 regression tests for container-element taint in JS and Python
* feat: add engine-depth profiles and explain-engine option for CLI
* feat: update expectations and add new README fixtures for multi-file scan regression
* feat: implement Phase 11 callback-alias and factory patterns with regression tests
* feat: implement Terminator::Switch for multi-way dispatch and add regression tests
* feat: add real-CVE benchmark fixtures for CVE-2023-48022, CVE-2019-14939, and CVE-2023-26159 with corresponding patched variants
* refactor: extract cfg and ssa_transfer to submodules
* refactor: cargo fmt
* refactor: remove unnecessary blank line in cfg_tests.rs
* refactor: remove unnecessary planning file
* chore: update Rust version to 1.88 and bump dependencies in Cargo files
* feat: enhance triage UI with new layout and controls, update README for clarity
* feat: enhance triage UI with new layout and controls, update README for clarity
* chore: remove outdated section from README for version 0.5.0
* docs: improve clarity and consistency in README content
* chore: add "GPL-3.0-or-later" to license options in about.toml
* chore: update license handling in about.toml and check-licenses.mjs
* style: format code for improved readability in TriagePage component
* style: format code for improved readability in TriagePage component
* chore: enhance license handling and improve body_id scoping in seed lookup
* feat: introduce owner and parent body IDs for enhanced seed scoping
* feat: implement direction-aware engine provenance with new CLI flag for strict CI gating
* feat: add Undef SSA operation for improved control-flow handling
* style: improve code formatting for consistency and readability in multiple files
* feat: add 16-function chain SCC across multiple files for enhanced analysis
* style: simplify code formatting for improved readability in multiple files
* fix: update CapHitReason default implementation and improve README clarity
* docs: enhance README with detailed explanations of taint analysis and limitations
* docs: refine README for clarity and consistency in taint analysis section
* style: improve code formatting for better readability in NewScanModal and scans
* fix: update cargo-about command to use --offline for deterministic license generation
* fix: update cargo-about command to use --offline for deterministic license generation
* ci: add step to prime cargo registry cache for deterministic license generation
* feat: add support for non-sink collections in authorization analysis
* feat: enhance authorization checks with row-level ownership equality and binding tracking
* feat: implement self-scoped user handling and enhance ownership checks
* refactor: simplify assertions and formatting in authorization analysis tests
* fix: normalize line endings in THIRDPARTY-LICENSES.html generation and update README with AI disclosure
* docs: update AI disclosure section for clarity and conciseness
* feat: add AI Contribution Policy and update contributing guidelines for AI assistance disclosure
* feat: enhance authorization analysis with SSA-derived variable type classification
* feat: implement auth_finding_to_diag function for enhanced security diagnostics
* feat: add args_value_refs to CallSite struct for enhanced argument tracking
* feat: add args_value_refs to CallSite struct for enhanced argument tracking
* feat: add direction-aware engine provenance with LossDirection classification and new CLI flag
* feat: simplify strip_cap_from_call_args call by removing unnecessary line breaks
* feat: enhance error message handling in cli_validation_tests for better Windows compatibility
* feat: optimize release profile settings in Cargo.toml and update CodeQL configuration
* feat: enhance release build process with SBOM generation and SLSA provenance
* feat: update actions/checkout and actions/setup-node to v6, enhance CLI options, and improve auth-check summaries
* feat: introduce PathFact handling for path safety checks and rejection logic
* feat: introduce PathFact handling for path safety checks and rejection logic
* feat: update benchmark data and enhance path sanitization logic with new safety checks
* feat: document AI assistance in frontend UI development and human review process
* feat: add return path facts for enhanced path safety checks and update documentation
* chore: update release date for version 0.5.0 in CHANGELOG.md
* chore: clean up ci.yml by removing outdated comments and clarifying steps
* feat: implement cross-language path sanitizers and validators for enhanced security
* feat: enhance SSA value usage tracking by including block terminators and improve path safety checks
* feat: enhance switch statement handling by adding per-case path constraints and support for exclusive cases
* refactor: simplify conditional formatting and improve code readability in executor and lower modules
* feat: add vulnerable examples for various languages demonstrating authentication and sanitization issues
* feat: enhance actor context recognition for self-actor identifiers and add support for global non-sink receivers
* feat: enhance actor context recognition for self-actor identifiers and add support for global non-sink receivers
* feat: add transform classifiers for Java, Go, and Ruby with corresponding tests
* refactor: clarify comments on reassign-to-constant idiom and sink behavior in guards.rs
---------
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
2026-04-25 17:59:11 -04:00
|
|
|
use crate::constraint::domain::ConstValue;
|
|
|
|
|
use crate::constraint::lower::ConditionExpr;
|
2026-04-29 00:58:38 -04:00
|
|
|
use crate::ssa::type_facts::TypeKind;
|
Release/0.5.0 (#35)
* feat: Introduce function-scoped variable interning for state analysis with new tests and fixtures
* feat: Add Phase 26 symbolic execution enhancements with bitwise operator support, abstract interpretation refinements, and new taint analysis tests
* feat: Refine state analysis to handle factory-pattern resource returns with mixed-path tests and leak detection enhancements
* feat: Add Phase 27 debug views with symbolic execution, abstract interpretation, SSA, and call graph viewers; integrate with debug layout and styles
* feat: Add Phase 31 type-qualified symbolic resolution with receiver-based callee disambiguation and testing
* feat: Extend symbolic execution with state iteration, enhanced debug views, and debounced input handling
* feat: Add Phase 13 resource and auth pattern extensions with new tests and fixtures
* feat: Introduce CFG debug graph renderer with compact mode, toolbar, and DAG layout integration
* feat: Add Phase 28 encoding and decoding transform modeling with structural symex enhancements and new taint analysis tests
* feat: Extend abstract interpretation with type facts and constant value tracking in debug views and server logic
* feat: Add linear path handling and witness extraction to symbolic execution with Phase 28 transform mismatch detection
* feat: Refine Go auth and sanitizer handling with enhanced rules, state updates, and benchmark improvements
* feat: Enable auth-state analysis by default and update relevant tests in benchmark config
* test: Update state_tests to reflect default enablement of auth-state analysis and add auth suppression test
* docs: update CHANGELOG.md
* feat: Introduce per-index taint tracking in `HeapState` with `HeapSlot`, overflow handling, and revised SSA transfers
* feat: Introduce C/C++ language labels and refine heap state tracking in SSA transfers
* feat: Implement per-index array slot tracking in symbolic heap with overflow collapse
* feat: Add implicit definition handling for uninitialized declarations in SSA value allocation
* feat: Refactor function parameters and constants for improved clarity and maintainability
* refactor: Reorder module imports and improve formatting for consistency
* refactor: Fix formatting erorrs
* refactor: Fix clippy warnings
* refactor: Fix fmt warnings (again)
* chore: Update dependencies and improve feature configuration
* Add comprehensive tests for undertested modules (#36) (COPILOT)
* Add comprehensive tests for undertested modules
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/f3fc877e-f386-49ba-9793-fc93d3805083
* Add comprehensive tests for ext, project, walk, and errors modules
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/f3fc877e-f386-49ba-9793-fc93d3805083
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
* chore: Update dependencies and improve feature configuration
* fix: formatting errors in new tests
* chore: Update license list in about.toml
* chore: made functions input inline
* chore: updated cfg graph to take up the full page
* chore: add Prettier configuration and update code formatting
* Add frontend test suite with Vitest (111 tests) (#37)
* Add Vitest test suite for frontend - 111 tests across utils, components, hooks, and graph utilities
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/7cf0dba2-ecff-4740-ba4d-92717e74a0b7
* ci: add frontend test step to CI workflow
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/5bc0ac9f-0a32-4d03-9cb7-7a15aea53fca
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
* chore: simplify array initialization in test files for consistency
* ran typecheck
* feat: add AnalysisWorkspace component and integrate it into CfgViewerPage
* feat: update routing in AppLayout and improve empty state message in ExplorerPage
* feat: enhance scan progress tracking with additional metrics and stages
* feat: update license information and add license check script
* feat: implement cross-file symbolic execution with callee body persistence
* feat: replace dagre graphs with Graphology + ELK + Sigma for more advanced call stack and cfg rendering
* feat: ensure CFG function view is scoped to the selected function, preventing bleed into sibling functions
* feat: enhance resource tracking with proxy method summaries and improve finding extraction
* feat: add terminal function exit detection for accurate resource leak analysis
* feat: add warnings for loops and functions without bodies to improve error recovery
* feat: update lambda expression handling to ensure proper function classification and control flow
* feat: remove bounded formatting/string ops and add JSON.parse sanitizer for improved data handling
* feat: add inline return taint analysis and regression tests for improved security checks
* feat: add engine version management and migration handling for database schema updates
* feat: enhance first_call_ident to skip nested function bodies and add regression tests
* feat: enhance callee name resolution with two-segment normalization and disambiguation
* feat: add cross-file context flags and debug assertions for taint analysis
* feat: refactor taint analysis structure to unify context handling and improve clarity
* feat: enhance dead code elimination to preserve Sink, Source, and Sanitizer labels with new tests
* docs: updated CHANGELOG.md
* fmt: formatting fixes
* fix: fixed frontend formatting and lint warnings
* fix: optimized ci
* fix: optimized ci
* Add comprehensive multi-file test coverage to Nyx (#38)
* Initial checklist for multi-file test suite expansion
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/e550cb88-9767-4442-94d4-101bf5bb0e23
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
* Add 12 new multi-file test fixtures with TP/TN/near-miss coverage
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/e550cb88-9767-4442-94d4-101bf5bb0e23
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
* deleted root repo
* rebuilt to test for regressions
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
Co-authored-by: elipeter <elicpeter@gmail.com>
* feat: enhance import alias resolution and taint tracking
* feat: implement security hardening with CSRF protection and path validation
* feat: add support for import alias bindings in Python, PHP, and Rust
* feat: enhance CFG analysis modes and improve code readability
* feat: add detection for parameterized SQL queries to enhance security
* feat: add safe internal redirect handling and enhance session destroy validation
* feat: implement security improvements by addressing vulnerabilities in execAsync, session management, and file downloads
* feat: enhance taint detection by adding support for inline source member expressions in call arguments
* feat: implement pre-emission of Source nodes for inline source member expressions in call arguments
* feat: add support for Throw statement in control flow and error handling
* feat: add debug and echo endpoints with potential information leakage
* feat: implement internal redirect suppression and enhance taint detection
* feat: implement module alias tracking for dynamic dispatch in JS/TS
* feat: add authorization analysis module with Express support
* feat: add authorization analysis module with Express support
* feat: add tests for admin guard requirements and clean checks in authorization analysis
* feat: integrate Koa and Fastify frameworks into authorization analysis
* feat: add Flask and Django support to authorization analysis module
* feat: add support for Rails and Sinatra frameworks in authorization analysis
* feat: add support for Axum, ActixWeb, and Rocket frameworks in authorization analysis
* feat: add support for ActixWeb, Axum, and Rocket frameworks in authorization analysis
* feat: add support for Rails and Sinatra in authorization analysis
* chore: add .DS_Store to .gitignore
* refactor: simplify conditional checks and improve readability in multiple files
* refactor: update usage of Option methods for improved clarity and consistency
* refactor: improve code readability by simplifying conditional checks and formatting
* refactor: improve code formatting and readability by simplifying conditional checks
* refactor: simplify conditional checks and improve readability in multiple files
* refactor: simplify conditional checks in axum.rs for improved readability
* feat: add CodeQL analysis configuration for enhanced security scanning
* test: add comprehensive tests for `src/output.rs` SARIF builder (#39)
* chore: start test coverage improvement work
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/cd7ff398-134e-4728-a5e7-0353a0744423
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
* test: add comprehensive tests for src/output.rs SARIF builder
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/cd7ff398-134e-4728-a5e7-0353a0744423
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
* refactor: improve code formatting and readability in output.rs
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
Co-authored-by: elipeter <elicpeter@gmail.com>
* refactor: improve code formatting and readability in output.rs
* Potential fix for code scanning alert no. 210: Uncontrolled data used in path expression
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
* Potential fix for code scanning alert no. 211: Uncontrolled data used in path expression
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
* refactor: enhance triage file path handling with improved error management and validation
* refactor: updated func summaries for richer detail
* refactor: update SSA summary extraction to use canonical FuncKey for distinct entries
* refactor: enhance callee metadata structure to support arity, receiver, and qualifier for better overload resolution
* refactor: add support for keyword arguments in function calls and enhance receiver extraction for method-style calls
* refactor: implement new Flask routes for safe and unsafe shell command execution
* refactor: separate receiver handling in SSA operations and enhance taint propagation
* refactor: improve arity handling by using arg_uses for positional argument count and enhance witness scoring for tainted arguments
* refactor: implement auth decorator extraction and classification for multiple languages
* refactor: enhance Rust module path resolution and use map handling for cross-file disambiguation
* refactor: introduce CalleeQuery struct for structured callee resolution and enhance resolver logic
* refactor: implement same-file identity collision handling for `runTask` to ensure correct resolver behavior
* refactor: standardize default struct initialization across multiple files
* feat: add scripts for formatting checks and auto-fixes with test summaries
* refactor: simplify character splitting and enhance namespace qualifier handling
* refactor: improve documentation clarity and enhance code readability in resolver logic
* refactor: replace default struct initialization with explicit field assignments for clarity
* feat: enhance anonymous function naming by deriving context-based bindings
* refactor: streamline match expressions for improved readability and performance
* refactor: streamline match expressions for improved readability and performance
* refactor: replace loop with while let for improved clarity and performance
* feat: add SSA constant propagation support to analysis context for improved accuracy
* feat: add SSA constant propagation support to analysis context for improved accuracy
* feat: implement shell metacharacter validation and bounded-length checks in Rust analysis
* feat: add static map analysis for command injection suppression and type safety
* refactor: simplify match statements and reduce line breaks for improved readability
* feat(summary): phase 1/5 SinkSite data model for primary sink-location attribution
Introduce SinkSite (file_rel, line, col, snippet, cap) carrying the
primary sink source-location through function summaries. Swap
SsaFuncSummary.param_to_sink and FuncSummary.param_to_sink from a coarse
Cap map to a deduped SmallVec<[SinkSite; 1]> per parameter, with a
backward-compatible cap_sites() helper and serde defaults so pre-phase-1
on-disk rows continue to deserialise cleanly.
Extraction: SinkSiteLocator bundles the tree/bytes/file_rel needed by
extract_ssa_func_summary; ParsedFile::extract_ssa_artifacts wires the
locator in for the persisted pass-1 path, while pass-2 intra-file
transient summaries fall back to cap-only sites (behavior unchanged).
Merge: GlobalSummaries::insert now unions sink sites with
(file_rel, line, col, cap) dedup via shared union_param_sink_sites
helper.
Database: JSON-serialised summary columns carry the new shape
automatically; no schema change needed.
Phase 2 will consume SinkSite in build_taint_diag() to overwrite the
caller-site Finding.line with the callee's sink line when resolved via
summary. Phase 1 keeps behavior unchanged: scanning
tests/benchmark/corpus/rust/cmdi/cmdi_indirect.rs still produces the
same (wrong) line 10 finding.
Adds round-trip tests covering SinkSite solo, SsaFuncSummary with sink
sites, legacy-JSON default handling for both summary types, and merge
dedup.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
* feat(taint): phase 2/5 thread SinkSite into SsaTaintEvent and Finding
Plumb Phase 1's SinkSite through the event pipeline into Findings,
no output change yet. SsaTaintEvent gains `primary_sink_site:
Option<SinkSite>`; when the main or callback sink-emission path has
non-empty `param_to_sink_sites`, filter to sites whose
`(line != 0) && (cap ∩ sink_caps != ∅)` and emit one event per
distinct site — the multi-primary collapse keeps each downstream
Finding single-primary.
Resolution: ResolvedSummary and SinkInfo gain mirror
`param_to_sink_sites` fields, populated from `SsaFuncSummary.param_to_sink`
(SSA + callback paths) and `FuncSummary.param_to_sink` (global paths).
Label, local-summary, and interop resolution paths leave the field
empty — they only ever had cap-level info to begin with.
Finding: new `primary_location: Option<SinkLocation>` with
`file_rel/line/col`. `ssa_events_to_findings` maps
`event.primary_sink_site` → `Finding.primary_location`, filtering
cap-only sites (`line == 0`) to `None` so the (0,0) sentinel never
leaks to formatters. Dedup key extended with the primary location
so multi-site events aren't collapsed back together.
Invariants (debug_assert!):
* every SinkSite reaching emission has `line != 0 && cap ∩ sink_caps
!= ∅` — enforced by the pick_primary_sink_sites* filters;
* every populated Finding.primary_location has `line != 0` AND
non-empty `file_rel` — the cap-only → None translation upstream
guarantees this.
Deliberately independent of `uses_summary`: that flag tracks whether
the *taint chain* used a summary, whereas primary attribution
requires only that the *sink* itself was summary-resolved. A local
source reaching a cross-file sink produces `uses_summary=false`
alongside a populated primary_location — documented on
Finding.primary_location, covered by
`cross_file_sink_finding_carries_primary_location`.
build_taint_diag, SARIF/JSON/explanation formatters, and the
benchmark scorer remain untouched: finding.line still comes from
`cfg_graph[finding.sink]`, so cmdi_indirect.rs still reports line 10
and the benchmark's rs-cmdi-003 row still shows FN in the LOC column.
Tests: `cross_file_sink_finding_carries_primary_location` (proves
plumbing via a synthetic FuncSummary carrying a SinkSite at 42:5) and
`cross_file_sink_cap_only_site_leaves_primary_location_none`
(regression guard against cap-only sites surfacing). All 1566 lib
tests + integration tests pass.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* feat(output): phase 3/5 consume primary sink location in diag + SARIF
When a finding's primary_location (populated in phase 2 from a callee
summary's SinkSite) names the dangerous instruction inside a callee
body, attribute the diagnostic line to that location instead of the
caller's call site. The call site is demoted to a Call step in
flow_steps, and a synthetic Sink step at the primary location is
appended so analysts still see the full trace.
Changes:
- Add scan_root parameter to build_taint_diag so file_rel can be
resolved back to an absolute path via a shared resolve_file_rel
helper. Empty file_rel (single-file scans where namespace == "")
resolves to the file under analysis.
- Extend SinkLocation with snippet, carried from the upstream
SinkSite so the formatter needs no second file read.
- Relax the ssa_events_to_findings debug_assert to allow empty
file_rel, which is valid when scan root equals the file itself.
- SARIF: emit data-flow as codeFlows[0].threadFlows[0].locations[];
locations[0] already reflects the primary sink position via the
updated diag line/col.
Acceptance: scan on tests/benchmark/corpus/rust/cmdi/cmdi_indirect.rs
now reports line 5 (Command::new) as the primary sink, with the call
site at line 10 visible in flow_steps.
Two expect.json fixtures updated (must_match line_range widened):
- javascript/taint/context_sensitive_call: 12-14 -> 7-14 (line 8 is
the real sink inside run()).
- rust/cfg/closure_async: 10-10 -> 10-11 (line 11 is Command::new
inside the closure).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* feat(bench): phase 4/5 validate primary sink attribution across corpus
Extend the benchmark scorer and ground truth to lock in phase 3's
primary-location behavior, and add fixtures that exercise the new
capability end-to-end.
Scorer (tests/benchmark_test.rs):
- Add optional `expected_call_site_lines: Option<Vec<[usize; 2]>>` on
Case. When present, score_location_level additionally requires at
least one flow_step in the finding's evidence trace to fall within
±2 of the call-site range. When absent, the check is skipped —
fully forward-compatible with existing fixtures.
- Retain ±2 tolerance on expected_sink_lines (compared against the
now-primary Diag.line post-phase-3).
Ground truth edits:
- rs-cmdi-cross-001: expected_sink_lines [8,8] -> [9,9]. Line 8 is the
transform::wrap call site (a cross-file propagator, not a sink);
line 9 is Command::new, the real sink. The ±2 tolerance happened to
mask this stale attribution but it was semantically wrong — phase 4
is the right time to correct it. Also adds expected_call_site_lines
[8,8] so the new field is exercised on an existing cross-file case.
- rs-cmdi-003: adds expected_call_site_lines [10,10] (run_cmd call).
This fixture's sink (Command::new inside run_cmd at line 5) was the
motivating case for phases 1-3; adding the call-site assertion
guards against regression to caller-line attribution.
New fixtures:
- rust/cmdi/cmdi_indirect_multisink.rs (rs-cmdi-009): helper run_both
takes two tainted params and invokes two Command sinks on
consecutive lines. Locks in that primary line lands inside the
helper (lines 5-6), not at the caller (line 12). Notes document
that SinkSite is currently one-per-callee so both findings today
collapse onto the first sink; expected_sink_lines=[5,6] and
expected_call_site_lines=[12,12] stay valid either way.
- python/cmdi/cross_indirect_sink/{app.py,helper.py} (py-cmdi-cross-
004): sink os.system lives in helper.py (cross-file), caller in
app.py reads env source and calls run_cmd. Verifies phase 3's
cross-file primary attribution: Diag.path = helper.py, Diag.line =
5, with app.py:7 recorded in flow_steps as a Call step.
Acceptance:
- `cargo test --test benchmark_test -- --ignored --nocapture` passes.
- rs-cmdi-003 is TP/TP/TP (the target flip FN->TP at LOC). All
pre-existing TP/TP/TP fixtures remain TP/TP/TP; 2 new fixtures are
TP/TP/TP.
- Aggregate rule-level: TP=158 FP=10 FN=1 TN=97, P=0.940 R=0.994
F1=0.966 on the 266-case corpus (was TP=156 FP=10 FN=1 TN=97 on
264 pre-phase-4, delta is the +2 new cases both resolving TP).
- Full `cargo test` green (1566 lib tests + all integration tests).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* feat(taint): phase 5/5 lock Finding.primary_location contract via regression test
Add a regression test in src/taint/ssa_transfer.rs that wires up a synthetic
SsaFuncSummary with a SinkSite at other.rs:42:10 and drives the three
emission stages (pick_primary_sink_sites → emit_ssa_taint_events →
ssa_events_to_findings) against a minimal caller SSA body. Asserts the
resulting Finding.primary_location is exactly that triple.
The existing integration tests in src/taint/tests.rs cover the coarse
FuncSummary path end-to-end through analyse_file. This test locks in the
lower-level SSA-side plumbing so a future refactor that silently drops the
site between pick → emit → findings fails here rather than only at the
benchmark layer.
Also refreshes tests/benchmark/results/latest.json (timestamp only; rs-cmdi-003
remains TP/TP/TP and the aggregate P/R/F1 are unchanged from phase 4).
Closes the primary sink-location attribution feature (phases 1-5/5):
* Phase 1 — SinkSite data model on summaries.
* Phase 2 — SinkSite threaded into SsaTaintEvent and Finding.
* Phase 3 — diag + SARIF consume primary_location.
* Phase 4 — benchmark validates primary_call_site_lines across corpus.
* Phase 5 — regression test locks the event→finding contract.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* refactor: clean up formatting and improve readability in multiple files
* refactor: simplify type definition for deduplication key in findings
* test(harness): add must_not_match expectation for FP regression guards
Extends ExpectedFinding with must_not_match field that asserts a
diagnostic must NOT fire — presence is a hard failure. Non-consuming
scan so it coexists with must_match entries on the same rule_id.
Adds forbidden_violations accumulator and updates summary line.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* feat(regression): update expectations to ensure must_not_match for various taint and resource leak rules
* feat: implement auto-seeding for JS/TS handler parameters to enhance taint tracking
* feat: update switch statement handling to improve control flow analysis
* feat: implement promisify alias handling for JS/TS to enhance taint tracking
* feat: enhance taint tracking by refining expectation handling and adding mode filtering
* feat: refine SQL handling in stream processing and enhance auto-seeding for handler parameters
* feat: update taint tracking rules to enforce full mode matching and improve flow analysis
* feat: enhance Ruby subshell handling to improve taint tracking and flow analysis
* feat: update xss_response expectations to refine taint flow analysis and enhance regression guarding
* feat: refine framework detection and update expectation handling for Echo and Sinatra
* feat: implement max_count for taint tracking expectations and deduplicate findings
* feat: add strict_unexpected handling for taint-unsanitised-flow in expectation files
* feat: enhance deduplication of taint-unsanitised-flow findings by collapsing based on line and severity
* feat: add strict_unexpected handling for taint-unsanitised-flow in multiple expectation files
* feat: add structural invariant checks for SSA bodies
* feat: ensure deterministic phi emission order using BTreeSet
* feat: enhance handling of terminators to ensure authoritative flow through successor edges
* feat: enhance Goto terminator handling to ensure all successors are marked executable
* feat: refactor code for improved readability and organization
* feat: simplify predicate checks and enhance readability in SSA handling
* feat: implement per-file parse timeout and enhance file size handling
* feat: migrate analysis engine toggles from environment variables to configuration file
* feat: remove unnecessary whitespace in hostile_input_tests.rs
* feat: remove unnecessary whitespace in hostile_input_tests.rs
* feat: update dependencies and enhance documentation on language maturity
* feat: enhance security headers and improve request body limits
* feat: implement sink capability bits for deduplication and enhance evidence tagging
* feat: implement dynamic activation handling for gated sinks and enhance validation logic
* feat: enhance configuration documentation and clarify inline analysis cache behavior
* feat: implement panic recovery during analysis to continue scans past errors
* feat: add expectations configuration for taint analysis and performance metrics
* feat: enhance error handling and logging during file reading and mutex locking
* feat: add cross-file body loading tests and plumbing for CF-1 phase
* feat: implement cross-file k=1 context-sensitive inline taint analysis with new tests and fixtures
* feat: implement indexed-scan parity in cross-file inline analysis with new dropdown and copy functionality
* feat: enhance classification span handling in CFG and AST for improved source attribution
* feat: add new Express routes for handling user input and telemetry data
* feat: implement ternary expression handling in CFG with diamond structure for JS/TS
* feat: implement Phase CF-3 abstract-domain transfer channels in summaries
* feat: add support for string-prefix transfer in cross-file calls and update tests
* docs: reduce RESULTS.md doc size
* feat: implement Phase CF-4 per-return-path summary decomposition with tests
* feat: update parameter handling in pass1 and refactor SsaFuncSummary initialization
* feat: implement Phase CF-5 for cross-file SCC joint fixed-point convergence with new flags and tests
* feat: implement Phase CF-6 with parameter-granularity points-to summaries and associated tests
* refactor: update comments and documentation for clarity and consistency
* style: format code for consistency and readability
* refactor: simplify verdict handling and improve edge checking logic
* refactor: optimize path and identifier collection by avoiding unnecessary cloning
* chore: update Cargo.toml for Rust version 1.85 and add ignored files; modify CHANGELOG and README for clarity on state analysis defaults
* refactor: update documentation and improve clarity in configuration files
* refactor: update documentation and improve clarity in configuration files
* feat: add JS/TS pass-2 convergence tests and expectations configuration
* feat: add Phase 5 regression tests for inline cache origin attribution and update related logic
* feat: implement Phase 7 deduplication and alternative path linking for taint findings
* feat: implement structural DFS index for anonymous functions and update naming conventions
* feat: add Phase 8 regression tests for container-element taint in JS and Python
* feat: add engine-depth profiles and explain-engine option for CLI
* feat: update expectations and add new README fixtures for multi-file scan regression
* feat: implement Phase 11 callback-alias and factory patterns with regression tests
* feat: implement Terminator::Switch for multi-way dispatch and add regression tests
* feat: add real-CVE benchmark fixtures for CVE-2023-48022, CVE-2019-14939, and CVE-2023-26159 with corresponding patched variants
* refactor: extract cfg and ssa_transfer to submodules
* refactor: cargo fmt
* refactor: remove unnecessary blank line in cfg_tests.rs
* refactor: remove unnecessary planning file
* chore: update Rust version to 1.88 and bump dependencies in Cargo files
* feat: enhance triage UI with new layout and controls, update README for clarity
* feat: enhance triage UI with new layout and controls, update README for clarity
* chore: remove outdated section from README for version 0.5.0
* docs: improve clarity and consistency in README content
* chore: add "GPL-3.0-or-later" to license options in about.toml
* chore: update license handling in about.toml and check-licenses.mjs
* style: format code for improved readability in TriagePage component
* style: format code for improved readability in TriagePage component
* chore: enhance license handling and improve body_id scoping in seed lookup
* feat: introduce owner and parent body IDs for enhanced seed scoping
* feat: implement direction-aware engine provenance with new CLI flag for strict CI gating
* feat: add Undef SSA operation for improved control-flow handling
* style: improve code formatting for consistency and readability in multiple files
* feat: add 16-function chain SCC across multiple files for enhanced analysis
* style: simplify code formatting for improved readability in multiple files
* fix: update CapHitReason default implementation and improve README clarity
* docs: enhance README with detailed explanations of taint analysis and limitations
* docs: refine README for clarity and consistency in taint analysis section
* style: improve code formatting for better readability in NewScanModal and scans
* fix: update cargo-about command to use --offline for deterministic license generation
* fix: update cargo-about command to use --offline for deterministic license generation
* ci: add step to prime cargo registry cache for deterministic license generation
* feat: add support for non-sink collections in authorization analysis
* feat: enhance authorization checks with row-level ownership equality and binding tracking
* feat: implement self-scoped user handling and enhance ownership checks
* refactor: simplify assertions and formatting in authorization analysis tests
* fix: normalize line endings in THIRDPARTY-LICENSES.html generation and update README with AI disclosure
* docs: update AI disclosure section for clarity and conciseness
* feat: add AI Contribution Policy and update contributing guidelines for AI assistance disclosure
* feat: enhance authorization analysis with SSA-derived variable type classification
* feat: implement auth_finding_to_diag function for enhanced security diagnostics
* feat: add args_value_refs to CallSite struct for enhanced argument tracking
* feat: add args_value_refs to CallSite struct for enhanced argument tracking
* feat: add direction-aware engine provenance with LossDirection classification and new CLI flag
* feat: simplify strip_cap_from_call_args call by removing unnecessary line breaks
* feat: enhance error message handling in cli_validation_tests for better Windows compatibility
* feat: optimize release profile settings in Cargo.toml and update CodeQL configuration
* feat: enhance release build process with SBOM generation and SLSA provenance
* feat: update actions/checkout and actions/setup-node to v6, enhance CLI options, and improve auth-check summaries
* feat: introduce PathFact handling for path safety checks and rejection logic
* feat: introduce PathFact handling for path safety checks and rejection logic
* feat: update benchmark data and enhance path sanitization logic with new safety checks
* feat: document AI assistance in frontend UI development and human review process
* feat: add return path facts for enhanced path safety checks and update documentation
* chore: update release date for version 0.5.0 in CHANGELOG.md
* chore: clean up ci.yml by removing outdated comments and clarifying steps
* feat: implement cross-language path sanitizers and validators for enhanced security
* feat: enhance SSA value usage tracking by including block terminators and improve path safety checks
* feat: enhance switch statement handling by adding per-case path constraints and support for exclusive cases
* refactor: simplify conditional formatting and improve code readability in executor and lower modules
* feat: add vulnerable examples for various languages demonstrating authentication and sanitization issues
* feat: enhance actor context recognition for self-actor identifiers and add support for global non-sink receivers
* feat: enhance actor context recognition for self-actor identifiers and add support for global non-sink receivers
* feat: add transform classifiers for Java, Go, and Ruby with corresponding tests
* refactor: clarify comments on reassign-to-constant idiom and sink behavior in guards.rs
---------
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
2026-04-25 17:59:11 -04:00
|
|
|
use petgraph::graph::NodeIndex;
|
|
|
|
|
use serde::{Deserialize, Serialize};
|
|
|
|
|
use smallvec::SmallVec;
|
2026-05-01 10:59:52 -04:00
|
|
|
use std::collections::{HashMap, HashSet};
|
Release/0.5.0 (#35)
* feat: Introduce function-scoped variable interning for state analysis with new tests and fixtures
* feat: Add Phase 26 symbolic execution enhancements with bitwise operator support, abstract interpretation refinements, and new taint analysis tests
* feat: Refine state analysis to handle factory-pattern resource returns with mixed-path tests and leak detection enhancements
* feat: Add Phase 27 debug views with symbolic execution, abstract interpretation, SSA, and call graph viewers; integrate with debug layout and styles
* feat: Add Phase 31 type-qualified symbolic resolution with receiver-based callee disambiguation and testing
* feat: Extend symbolic execution with state iteration, enhanced debug views, and debounced input handling
* feat: Add Phase 13 resource and auth pattern extensions with new tests and fixtures
* feat: Introduce CFG debug graph renderer with compact mode, toolbar, and DAG layout integration
* feat: Add Phase 28 encoding and decoding transform modeling with structural symex enhancements and new taint analysis tests
* feat: Extend abstract interpretation with type facts and constant value tracking in debug views and server logic
* feat: Add linear path handling and witness extraction to symbolic execution with Phase 28 transform mismatch detection
* feat: Refine Go auth and sanitizer handling with enhanced rules, state updates, and benchmark improvements
* feat: Enable auth-state analysis by default and update relevant tests in benchmark config
* test: Update state_tests to reflect default enablement of auth-state analysis and add auth suppression test
* docs: update CHANGELOG.md
* feat: Introduce per-index taint tracking in `HeapState` with `HeapSlot`, overflow handling, and revised SSA transfers
* feat: Introduce C/C++ language labels and refine heap state tracking in SSA transfers
* feat: Implement per-index array slot tracking in symbolic heap with overflow collapse
* feat: Add implicit definition handling for uninitialized declarations in SSA value allocation
* feat: Refactor function parameters and constants for improved clarity and maintainability
* refactor: Reorder module imports and improve formatting for consistency
* refactor: Fix formatting erorrs
* refactor: Fix clippy warnings
* refactor: Fix fmt warnings (again)
* chore: Update dependencies and improve feature configuration
* Add comprehensive tests for undertested modules (#36) (COPILOT)
* Add comprehensive tests for undertested modules
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/f3fc877e-f386-49ba-9793-fc93d3805083
* Add comprehensive tests for ext, project, walk, and errors modules
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/f3fc877e-f386-49ba-9793-fc93d3805083
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
* chore: Update dependencies and improve feature configuration
* fix: formatting errors in new tests
* chore: Update license list in about.toml
* chore: made functions input inline
* chore: updated cfg graph to take up the full page
* chore: add Prettier configuration and update code formatting
* Add frontend test suite with Vitest (111 tests) (#37)
* Add Vitest test suite for frontend - 111 tests across utils, components, hooks, and graph utilities
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/7cf0dba2-ecff-4740-ba4d-92717e74a0b7
* ci: add frontend test step to CI workflow
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/5bc0ac9f-0a32-4d03-9cb7-7a15aea53fca
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
* chore: simplify array initialization in test files for consistency
* ran typecheck
* feat: add AnalysisWorkspace component and integrate it into CfgViewerPage
* feat: update routing in AppLayout and improve empty state message in ExplorerPage
* feat: enhance scan progress tracking with additional metrics and stages
* feat: update license information and add license check script
* feat: implement cross-file symbolic execution with callee body persistence
* feat: replace dagre graphs with Graphology + ELK + Sigma for more advanced call stack and cfg rendering
* feat: ensure CFG function view is scoped to the selected function, preventing bleed into sibling functions
* feat: enhance resource tracking with proxy method summaries and improve finding extraction
* feat: add terminal function exit detection for accurate resource leak analysis
* feat: add warnings for loops and functions without bodies to improve error recovery
* feat: update lambda expression handling to ensure proper function classification and control flow
* feat: remove bounded formatting/string ops and add JSON.parse sanitizer for improved data handling
* feat: add inline return taint analysis and regression tests for improved security checks
* feat: add engine version management and migration handling for database schema updates
* feat: enhance first_call_ident to skip nested function bodies and add regression tests
* feat: enhance callee name resolution with two-segment normalization and disambiguation
* feat: add cross-file context flags and debug assertions for taint analysis
* feat: refactor taint analysis structure to unify context handling and improve clarity
* feat: enhance dead code elimination to preserve Sink, Source, and Sanitizer labels with new tests
* docs: updated CHANGELOG.md
* fmt: formatting fixes
* fix: fixed frontend formatting and lint warnings
* fix: optimized ci
* fix: optimized ci
* Add comprehensive multi-file test coverage to Nyx (#38)
* Initial checklist for multi-file test suite expansion
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/e550cb88-9767-4442-94d4-101bf5bb0e23
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
* Add 12 new multi-file test fixtures with TP/TN/near-miss coverage
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/e550cb88-9767-4442-94d4-101bf5bb0e23
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
* deleted root repo
* rebuilt to test for regressions
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
Co-authored-by: elipeter <elicpeter@gmail.com>
* feat: enhance import alias resolution and taint tracking
* feat: implement security hardening with CSRF protection and path validation
* feat: add support for import alias bindings in Python, PHP, and Rust
* feat: enhance CFG analysis modes and improve code readability
* feat: add detection for parameterized SQL queries to enhance security
* feat: add safe internal redirect handling and enhance session destroy validation
* feat: implement security improvements by addressing vulnerabilities in execAsync, session management, and file downloads
* feat: enhance taint detection by adding support for inline source member expressions in call arguments
* feat: implement pre-emission of Source nodes for inline source member expressions in call arguments
* feat: add support for Throw statement in control flow and error handling
* feat: add debug and echo endpoints with potential information leakage
* feat: implement internal redirect suppression and enhance taint detection
* feat: implement module alias tracking for dynamic dispatch in JS/TS
* feat: add authorization analysis module with Express support
* feat: add authorization analysis module with Express support
* feat: add tests for admin guard requirements and clean checks in authorization analysis
* feat: integrate Koa and Fastify frameworks into authorization analysis
* feat: add Flask and Django support to authorization analysis module
* feat: add support for Rails and Sinatra frameworks in authorization analysis
* feat: add support for Axum, ActixWeb, and Rocket frameworks in authorization analysis
* feat: add support for ActixWeb, Axum, and Rocket frameworks in authorization analysis
* feat: add support for Rails and Sinatra in authorization analysis
* chore: add .DS_Store to .gitignore
* refactor: simplify conditional checks and improve readability in multiple files
* refactor: update usage of Option methods for improved clarity and consistency
* refactor: improve code readability by simplifying conditional checks and formatting
* refactor: improve code formatting and readability by simplifying conditional checks
* refactor: simplify conditional checks and improve readability in multiple files
* refactor: simplify conditional checks in axum.rs for improved readability
* feat: add CodeQL analysis configuration for enhanced security scanning
* test: add comprehensive tests for `src/output.rs` SARIF builder (#39)
* chore: start test coverage improvement work
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/cd7ff398-134e-4728-a5e7-0353a0744423
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
* test: add comprehensive tests for src/output.rs SARIF builder
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/cd7ff398-134e-4728-a5e7-0353a0744423
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
* refactor: improve code formatting and readability in output.rs
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
Co-authored-by: elipeter <elicpeter@gmail.com>
* refactor: improve code formatting and readability in output.rs
* Potential fix for code scanning alert no. 210: Uncontrolled data used in path expression
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
* Potential fix for code scanning alert no. 211: Uncontrolled data used in path expression
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
* refactor: enhance triage file path handling with improved error management and validation
* refactor: updated func summaries for richer detail
* refactor: update SSA summary extraction to use canonical FuncKey for distinct entries
* refactor: enhance callee metadata structure to support arity, receiver, and qualifier for better overload resolution
* refactor: add support for keyword arguments in function calls and enhance receiver extraction for method-style calls
* refactor: implement new Flask routes for safe and unsafe shell command execution
* refactor: separate receiver handling in SSA operations and enhance taint propagation
* refactor: improve arity handling by using arg_uses for positional argument count and enhance witness scoring for tainted arguments
* refactor: implement auth decorator extraction and classification for multiple languages
* refactor: enhance Rust module path resolution and use map handling for cross-file disambiguation
* refactor: introduce CalleeQuery struct for structured callee resolution and enhance resolver logic
* refactor: implement same-file identity collision handling for `runTask` to ensure correct resolver behavior
* refactor: standardize default struct initialization across multiple files
* feat: add scripts for formatting checks and auto-fixes with test summaries
* refactor: simplify character splitting and enhance namespace qualifier handling
* refactor: improve documentation clarity and enhance code readability in resolver logic
* refactor: replace default struct initialization with explicit field assignments for clarity
* feat: enhance anonymous function naming by deriving context-based bindings
* refactor: streamline match expressions for improved readability and performance
* refactor: streamline match expressions for improved readability and performance
* refactor: replace loop with while let for improved clarity and performance
* feat: add SSA constant propagation support to analysis context for improved accuracy
* feat: add SSA constant propagation support to analysis context for improved accuracy
* feat: implement shell metacharacter validation and bounded-length checks in Rust analysis
* feat: add static map analysis for command injection suppression and type safety
* refactor: simplify match statements and reduce line breaks for improved readability
* feat(summary): phase 1/5 SinkSite data model for primary sink-location attribution
Introduce SinkSite (file_rel, line, col, snippet, cap) carrying the
primary sink source-location through function summaries. Swap
SsaFuncSummary.param_to_sink and FuncSummary.param_to_sink from a coarse
Cap map to a deduped SmallVec<[SinkSite; 1]> per parameter, with a
backward-compatible cap_sites() helper and serde defaults so pre-phase-1
on-disk rows continue to deserialise cleanly.
Extraction: SinkSiteLocator bundles the tree/bytes/file_rel needed by
extract_ssa_func_summary; ParsedFile::extract_ssa_artifacts wires the
locator in for the persisted pass-1 path, while pass-2 intra-file
transient summaries fall back to cap-only sites (behavior unchanged).
Merge: GlobalSummaries::insert now unions sink sites with
(file_rel, line, col, cap) dedup via shared union_param_sink_sites
helper.
Database: JSON-serialised summary columns carry the new shape
automatically; no schema change needed.
Phase 2 will consume SinkSite in build_taint_diag() to overwrite the
caller-site Finding.line with the callee's sink line when resolved via
summary. Phase 1 keeps behavior unchanged: scanning
tests/benchmark/corpus/rust/cmdi/cmdi_indirect.rs still produces the
same (wrong) line 10 finding.
Adds round-trip tests covering SinkSite solo, SsaFuncSummary with sink
sites, legacy-JSON default handling for both summary types, and merge
dedup.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
* feat(taint): phase 2/5 thread SinkSite into SsaTaintEvent and Finding
Plumb Phase 1's SinkSite through the event pipeline into Findings,
no output change yet. SsaTaintEvent gains `primary_sink_site:
Option<SinkSite>`; when the main or callback sink-emission path has
non-empty `param_to_sink_sites`, filter to sites whose
`(line != 0) && (cap ∩ sink_caps != ∅)` and emit one event per
distinct site — the multi-primary collapse keeps each downstream
Finding single-primary.
Resolution: ResolvedSummary and SinkInfo gain mirror
`param_to_sink_sites` fields, populated from `SsaFuncSummary.param_to_sink`
(SSA + callback paths) and `FuncSummary.param_to_sink` (global paths).
Label, local-summary, and interop resolution paths leave the field
empty — they only ever had cap-level info to begin with.
Finding: new `primary_location: Option<SinkLocation>` with
`file_rel/line/col`. `ssa_events_to_findings` maps
`event.primary_sink_site` → `Finding.primary_location`, filtering
cap-only sites (`line == 0`) to `None` so the (0,0) sentinel never
leaks to formatters. Dedup key extended with the primary location
so multi-site events aren't collapsed back together.
Invariants (debug_assert!):
* every SinkSite reaching emission has `line != 0 && cap ∩ sink_caps
!= ∅` — enforced by the pick_primary_sink_sites* filters;
* every populated Finding.primary_location has `line != 0` AND
non-empty `file_rel` — the cap-only → None translation upstream
guarantees this.
Deliberately independent of `uses_summary`: that flag tracks whether
the *taint chain* used a summary, whereas primary attribution
requires only that the *sink* itself was summary-resolved. A local
source reaching a cross-file sink produces `uses_summary=false`
alongside a populated primary_location — documented on
Finding.primary_location, covered by
`cross_file_sink_finding_carries_primary_location`.
build_taint_diag, SARIF/JSON/explanation formatters, and the
benchmark scorer remain untouched: finding.line still comes from
`cfg_graph[finding.sink]`, so cmdi_indirect.rs still reports line 10
and the benchmark's rs-cmdi-003 row still shows FN in the LOC column.
Tests: `cross_file_sink_finding_carries_primary_location` (proves
plumbing via a synthetic FuncSummary carrying a SinkSite at 42:5) and
`cross_file_sink_cap_only_site_leaves_primary_location_none`
(regression guard against cap-only sites surfacing). All 1566 lib
tests + integration tests pass.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* feat(output): phase 3/5 consume primary sink location in diag + SARIF
When a finding's primary_location (populated in phase 2 from a callee
summary's SinkSite) names the dangerous instruction inside a callee
body, attribute the diagnostic line to that location instead of the
caller's call site. The call site is demoted to a Call step in
flow_steps, and a synthetic Sink step at the primary location is
appended so analysts still see the full trace.
Changes:
- Add scan_root parameter to build_taint_diag so file_rel can be
resolved back to an absolute path via a shared resolve_file_rel
helper. Empty file_rel (single-file scans where namespace == "")
resolves to the file under analysis.
- Extend SinkLocation with snippet, carried from the upstream
SinkSite so the formatter needs no second file read.
- Relax the ssa_events_to_findings debug_assert to allow empty
file_rel, which is valid when scan root equals the file itself.
- SARIF: emit data-flow as codeFlows[0].threadFlows[0].locations[];
locations[0] already reflects the primary sink position via the
updated diag line/col.
Acceptance: scan on tests/benchmark/corpus/rust/cmdi/cmdi_indirect.rs
now reports line 5 (Command::new) as the primary sink, with the call
site at line 10 visible in flow_steps.
Two expect.json fixtures updated (must_match line_range widened):
- javascript/taint/context_sensitive_call: 12-14 -> 7-14 (line 8 is
the real sink inside run()).
- rust/cfg/closure_async: 10-10 -> 10-11 (line 11 is Command::new
inside the closure).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* feat(bench): phase 4/5 validate primary sink attribution across corpus
Extend the benchmark scorer and ground truth to lock in phase 3's
primary-location behavior, and add fixtures that exercise the new
capability end-to-end.
Scorer (tests/benchmark_test.rs):
- Add optional `expected_call_site_lines: Option<Vec<[usize; 2]>>` on
Case. When present, score_location_level additionally requires at
least one flow_step in the finding's evidence trace to fall within
±2 of the call-site range. When absent, the check is skipped —
fully forward-compatible with existing fixtures.
- Retain ±2 tolerance on expected_sink_lines (compared against the
now-primary Diag.line post-phase-3).
Ground truth edits:
- rs-cmdi-cross-001: expected_sink_lines [8,8] -> [9,9]. Line 8 is the
transform::wrap call site (a cross-file propagator, not a sink);
line 9 is Command::new, the real sink. The ±2 tolerance happened to
mask this stale attribution but it was semantically wrong — phase 4
is the right time to correct it. Also adds expected_call_site_lines
[8,8] so the new field is exercised on an existing cross-file case.
- rs-cmdi-003: adds expected_call_site_lines [10,10] (run_cmd call).
This fixture's sink (Command::new inside run_cmd at line 5) was the
motivating case for phases 1-3; adding the call-site assertion
guards against regression to caller-line attribution.
New fixtures:
- rust/cmdi/cmdi_indirect_multisink.rs (rs-cmdi-009): helper run_both
takes two tainted params and invokes two Command sinks on
consecutive lines. Locks in that primary line lands inside the
helper (lines 5-6), not at the caller (line 12). Notes document
that SinkSite is currently one-per-callee so both findings today
collapse onto the first sink; expected_sink_lines=[5,6] and
expected_call_site_lines=[12,12] stay valid either way.
- python/cmdi/cross_indirect_sink/{app.py,helper.py} (py-cmdi-cross-
004): sink os.system lives in helper.py (cross-file), caller in
app.py reads env source and calls run_cmd. Verifies phase 3's
cross-file primary attribution: Diag.path = helper.py, Diag.line =
5, with app.py:7 recorded in flow_steps as a Call step.
Acceptance:
- `cargo test --test benchmark_test -- --ignored --nocapture` passes.
- rs-cmdi-003 is TP/TP/TP (the target flip FN->TP at LOC). All
pre-existing TP/TP/TP fixtures remain TP/TP/TP; 2 new fixtures are
TP/TP/TP.
- Aggregate rule-level: TP=158 FP=10 FN=1 TN=97, P=0.940 R=0.994
F1=0.966 on the 266-case corpus (was TP=156 FP=10 FN=1 TN=97 on
264 pre-phase-4, delta is the +2 new cases both resolving TP).
- Full `cargo test` green (1566 lib tests + all integration tests).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* feat(taint): phase 5/5 lock Finding.primary_location contract via regression test
Add a regression test in src/taint/ssa_transfer.rs that wires up a synthetic
SsaFuncSummary with a SinkSite at other.rs:42:10 and drives the three
emission stages (pick_primary_sink_sites → emit_ssa_taint_events →
ssa_events_to_findings) against a minimal caller SSA body. Asserts the
resulting Finding.primary_location is exactly that triple.
The existing integration tests in src/taint/tests.rs cover the coarse
FuncSummary path end-to-end through analyse_file. This test locks in the
lower-level SSA-side plumbing so a future refactor that silently drops the
site between pick → emit → findings fails here rather than only at the
benchmark layer.
Also refreshes tests/benchmark/results/latest.json (timestamp only; rs-cmdi-003
remains TP/TP/TP and the aggregate P/R/F1 are unchanged from phase 4).
Closes the primary sink-location attribution feature (phases 1-5/5):
* Phase 1 — SinkSite data model on summaries.
* Phase 2 — SinkSite threaded into SsaTaintEvent and Finding.
* Phase 3 — diag + SARIF consume primary_location.
* Phase 4 — benchmark validates primary_call_site_lines across corpus.
* Phase 5 — regression test locks the event→finding contract.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* refactor: clean up formatting and improve readability in multiple files
* refactor: simplify type definition for deduplication key in findings
* test(harness): add must_not_match expectation for FP regression guards
Extends ExpectedFinding with must_not_match field that asserts a
diagnostic must NOT fire — presence is a hard failure. Non-consuming
scan so it coexists with must_match entries on the same rule_id.
Adds forbidden_violations accumulator and updates summary line.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* feat(regression): update expectations to ensure must_not_match for various taint and resource leak rules
* feat: implement auto-seeding for JS/TS handler parameters to enhance taint tracking
* feat: update switch statement handling to improve control flow analysis
* feat: implement promisify alias handling for JS/TS to enhance taint tracking
* feat: enhance taint tracking by refining expectation handling and adding mode filtering
* feat: refine SQL handling in stream processing and enhance auto-seeding for handler parameters
* feat: update taint tracking rules to enforce full mode matching and improve flow analysis
* feat: enhance Ruby subshell handling to improve taint tracking and flow analysis
* feat: update xss_response expectations to refine taint flow analysis and enhance regression guarding
* feat: refine framework detection and update expectation handling for Echo and Sinatra
* feat: implement max_count for taint tracking expectations and deduplicate findings
* feat: add strict_unexpected handling for taint-unsanitised-flow in expectation files
* feat: enhance deduplication of taint-unsanitised-flow findings by collapsing based on line and severity
* feat: add strict_unexpected handling for taint-unsanitised-flow in multiple expectation files
* feat: add structural invariant checks for SSA bodies
* feat: ensure deterministic phi emission order using BTreeSet
* feat: enhance handling of terminators to ensure authoritative flow through successor edges
* feat: enhance Goto terminator handling to ensure all successors are marked executable
* feat: refactor code for improved readability and organization
* feat: simplify predicate checks and enhance readability in SSA handling
* feat: implement per-file parse timeout and enhance file size handling
* feat: migrate analysis engine toggles from environment variables to configuration file
* feat: remove unnecessary whitespace in hostile_input_tests.rs
* feat: remove unnecessary whitespace in hostile_input_tests.rs
* feat: update dependencies and enhance documentation on language maturity
* feat: enhance security headers and improve request body limits
* feat: implement sink capability bits for deduplication and enhance evidence tagging
* feat: implement dynamic activation handling for gated sinks and enhance validation logic
* feat: enhance configuration documentation and clarify inline analysis cache behavior
* feat: implement panic recovery during analysis to continue scans past errors
* feat: add expectations configuration for taint analysis and performance metrics
* feat: enhance error handling and logging during file reading and mutex locking
* feat: add cross-file body loading tests and plumbing for CF-1 phase
* feat: implement cross-file k=1 context-sensitive inline taint analysis with new tests and fixtures
* feat: implement indexed-scan parity in cross-file inline analysis with new dropdown and copy functionality
* feat: enhance classification span handling in CFG and AST for improved source attribution
* feat: add new Express routes for handling user input and telemetry data
* feat: implement ternary expression handling in CFG with diamond structure for JS/TS
* feat: implement Phase CF-3 abstract-domain transfer channels in summaries
* feat: add support for string-prefix transfer in cross-file calls and update tests
* docs: reduce RESULTS.md doc size
* feat: implement Phase CF-4 per-return-path summary decomposition with tests
* feat: update parameter handling in pass1 and refactor SsaFuncSummary initialization
* feat: implement Phase CF-5 for cross-file SCC joint fixed-point convergence with new flags and tests
* feat: implement Phase CF-6 with parameter-granularity points-to summaries and associated tests
* refactor: update comments and documentation for clarity and consistency
* style: format code for consistency and readability
* refactor: simplify verdict handling and improve edge checking logic
* refactor: optimize path and identifier collection by avoiding unnecessary cloning
* chore: update Cargo.toml for Rust version 1.85 and add ignored files; modify CHANGELOG and README for clarity on state analysis defaults
* refactor: update documentation and improve clarity in configuration files
* refactor: update documentation and improve clarity in configuration files
* feat: add JS/TS pass-2 convergence tests and expectations configuration
* feat: add Phase 5 regression tests for inline cache origin attribution and update related logic
* feat: implement Phase 7 deduplication and alternative path linking for taint findings
* feat: implement structural DFS index for anonymous functions and update naming conventions
* feat: add Phase 8 regression tests for container-element taint in JS and Python
* feat: add engine-depth profiles and explain-engine option for CLI
* feat: update expectations and add new README fixtures for multi-file scan regression
* feat: implement Phase 11 callback-alias and factory patterns with regression tests
* feat: implement Terminator::Switch for multi-way dispatch and add regression tests
* feat: add real-CVE benchmark fixtures for CVE-2023-48022, CVE-2019-14939, and CVE-2023-26159 with corresponding patched variants
* refactor: extract cfg and ssa_transfer to submodules
* refactor: cargo fmt
* refactor: remove unnecessary blank line in cfg_tests.rs
* refactor: remove unnecessary planning file
* chore: update Rust version to 1.88 and bump dependencies in Cargo files
* feat: enhance triage UI with new layout and controls, update README for clarity
* feat: enhance triage UI with new layout and controls, update README for clarity
* chore: remove outdated section from README for version 0.5.0
* docs: improve clarity and consistency in README content
* chore: add "GPL-3.0-or-later" to license options in about.toml
* chore: update license handling in about.toml and check-licenses.mjs
* style: format code for improved readability in TriagePage component
* style: format code for improved readability in TriagePage component
* chore: enhance license handling and improve body_id scoping in seed lookup
* feat: introduce owner and parent body IDs for enhanced seed scoping
* feat: implement direction-aware engine provenance with new CLI flag for strict CI gating
* feat: add Undef SSA operation for improved control-flow handling
* style: improve code formatting for consistency and readability in multiple files
* feat: add 16-function chain SCC across multiple files for enhanced analysis
* style: simplify code formatting for improved readability in multiple files
* fix: update CapHitReason default implementation and improve README clarity
* docs: enhance README with detailed explanations of taint analysis and limitations
* docs: refine README for clarity and consistency in taint analysis section
* style: improve code formatting for better readability in NewScanModal and scans
* fix: update cargo-about command to use --offline for deterministic license generation
* fix: update cargo-about command to use --offline for deterministic license generation
* ci: add step to prime cargo registry cache for deterministic license generation
* feat: add support for non-sink collections in authorization analysis
* feat: enhance authorization checks with row-level ownership equality and binding tracking
* feat: implement self-scoped user handling and enhance ownership checks
* refactor: simplify assertions and formatting in authorization analysis tests
* fix: normalize line endings in THIRDPARTY-LICENSES.html generation and update README with AI disclosure
* docs: update AI disclosure section for clarity and conciseness
* feat: add AI Contribution Policy and update contributing guidelines for AI assistance disclosure
* feat: enhance authorization analysis with SSA-derived variable type classification
* feat: implement auth_finding_to_diag function for enhanced security diagnostics
* feat: add args_value_refs to CallSite struct for enhanced argument tracking
* feat: add args_value_refs to CallSite struct for enhanced argument tracking
* feat: add direction-aware engine provenance with LossDirection classification and new CLI flag
* feat: simplify strip_cap_from_call_args call by removing unnecessary line breaks
* feat: enhance error message handling in cli_validation_tests for better Windows compatibility
* feat: optimize release profile settings in Cargo.toml and update CodeQL configuration
* feat: enhance release build process with SBOM generation and SLSA provenance
* feat: update actions/checkout and actions/setup-node to v6, enhance CLI options, and improve auth-check summaries
* feat: introduce PathFact handling for path safety checks and rejection logic
* feat: introduce PathFact handling for path safety checks and rejection logic
* feat: update benchmark data and enhance path sanitization logic with new safety checks
* feat: document AI assistance in frontend UI development and human review process
* feat: add return path facts for enhanced path safety checks and update documentation
* chore: update release date for version 0.5.0 in CHANGELOG.md
* chore: clean up ci.yml by removing outdated comments and clarifying steps
* feat: implement cross-language path sanitizers and validators for enhanced security
* feat: enhance SSA value usage tracking by including block terminators and improve path safety checks
* feat: enhance switch statement handling by adding per-case path constraints and support for exclusive cases
* refactor: simplify conditional formatting and improve code readability in executor and lower modules
* feat: add vulnerable examples for various languages demonstrating authentication and sanitization issues
* feat: enhance actor context recognition for self-actor identifiers and add support for global non-sink receivers
* feat: enhance actor context recognition for self-actor identifiers and add support for global non-sink receivers
* feat: add transform classifiers for Java, Go, and Ruby with corresponding tests
* refactor: clarify comments on reassign-to-constant idiom and sink behavior in guards.rs
---------
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
2026-04-25 17:59:11 -04:00
|
|
|
|
|
|
|
|
/// Unique identifier for an SSA value (one per definition point).
|
|
|
|
|
#[derive(Clone, Copy, Debug, PartialEq, Eq, Hash, PartialOrd, Ord, Serialize, Deserialize)]
|
|
|
|
|
pub struct SsaValue(pub u32);
|
|
|
|
|
|
|
|
|
|
/// Basic block identifier.
|
|
|
|
|
#[derive(Clone, Copy, Debug, PartialEq, Eq, Hash, PartialOrd, Ord, Serialize, Deserialize)]
|
|
|
|
|
pub struct BlockId(pub u32);
|
|
|
|
|
|
2026-04-29 00:58:38 -04:00
|
|
|
/// Interned field-name identifier, scoped to a single [`SsaBody`].
|
|
|
|
|
///
|
|
|
|
|
/// Different bodies may assign different `FieldId`s to the same field name,
|
|
|
|
|
/// so callers MUST resolve through the owning body's [`FieldInterner`]
|
|
|
|
|
/// (`SsaBody::field_name`) before using the name in cross-body contexts
|
|
|
|
|
/// (e.g. summary serialization).
|
|
|
|
|
#[derive(Clone, Copy, Debug, PartialEq, Eq, Hash, PartialOrd, Ord, Serialize, Deserialize)]
|
|
|
|
|
pub struct FieldId(pub u32);
|
|
|
|
|
|
|
|
|
|
impl FieldId {
|
2026-04-29 19:53:34 -04:00
|
|
|
/// Sentinel for the abstract "any element of a container" field.
|
|
|
|
|
/// Every numeric or dynamic index access (`arr[i]`, `arr.shift()`,
|
|
|
|
|
/// `map[k]`) projects through the same `Field(pt(container), ELEM)`
|
|
|
|
|
/// cell. `u32::MAX` is reserved; the per-body interner never
|
|
|
|
|
/// assigns it.
|
2026-04-29 00:58:38 -04:00
|
|
|
pub const ELEM: FieldId = FieldId(u32::MAX);
|
|
|
|
|
|
2026-04-29 19:53:34 -04:00
|
|
|
/// "Tainted at every field" wildcard sentinel, distinct from
|
2026-04-29 00:58:38 -04:00
|
|
|
/// [`Self::ELEM`] (which is container-element semantics: every
|
|
|
|
|
/// numeric/dynamic index access projects through it).
|
|
|
|
|
/// `ANY_FIELD` represents the case where a writeback-shaped sink
|
|
|
|
|
/// (`json.NewDecoder(r.Body).Decode(&dest)`,
|
|
|
|
|
/// `proto.Unmarshal(buf, &msg)`) taints the destination wholesale
|
|
|
|
|
/// without a per-field decomposition the caller can enumerate.
|
|
|
|
|
/// Read by [`SsaOp::FieldProj`] as a fallback when no specific
|
|
|
|
|
/// `(loc, *field)` cell exists, so subsequent struct-field reads
|
|
|
|
|
/// pick up the writeback's taint without over-tainting unrelated
|
|
|
|
|
/// containers' element cells. `u32::MAX - 1` is reserved
|
|
|
|
|
/// alongside `ELEM` and is similarly never assigned by the per-
|
|
|
|
|
/// body interner.
|
|
|
|
|
pub const ANY_FIELD: FieldId = FieldId(u32::MAX - 1);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/// Per-body interner for field names referenced by [`SsaOp::FieldProj`].
|
|
|
|
|
///
|
|
|
|
|
/// Names are deduped within a single SSA body: every distinct field-name
|
|
|
|
|
/// string is assigned a stable `FieldId(u32)` for the lifetime of the body.
|
|
|
|
|
/// The interner is serialized alongside the body so deserialization restores
|
|
|
|
|
/// IDs intact; cross-body summary code is responsible for resolving names
|
|
|
|
|
/// before passing them across body boundaries.
|
|
|
|
|
#[derive(Clone, Debug, Default, Serialize, Deserialize)]
|
|
|
|
|
pub struct FieldInterner {
|
|
|
|
|
/// Names indexed by `FieldId.0`.
|
|
|
|
|
names: Vec<String>,
|
|
|
|
|
/// Reverse lookup: name → existing FieldId.
|
|
|
|
|
#[serde(skip)]
|
|
|
|
|
lookup: HashMap<String, u32>,
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
impl FieldInterner {
|
|
|
|
|
/// Create an empty interner.
|
|
|
|
|
pub fn new() -> Self {
|
|
|
|
|
Self::default()
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/// Intern a field name, returning its [`FieldId`]. Reuses the existing
|
|
|
|
|
/// id if the name has already been interned.
|
|
|
|
|
pub fn intern(&mut self, name: &str) -> FieldId {
|
|
|
|
|
if let Some(&id) = self.lookup.get(name) {
|
|
|
|
|
return FieldId(id);
|
|
|
|
|
}
|
|
|
|
|
let id = self.names.len() as u32;
|
|
|
|
|
self.names.push(name.to_string());
|
|
|
|
|
self.lookup.insert(name.to_string(), id);
|
|
|
|
|
FieldId(id)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/// Read-only lookup: returns the [`FieldId`] for `name` if it has
|
|
|
|
|
/// already been interned, or `None` otherwise.
|
|
|
|
|
///
|
2026-04-29 19:53:34 -04:00
|
|
|
/// Used by cross-call resolvers to avoid growing the caller's
|
|
|
|
|
/// interner with field names introduced solely by callee summaries
|
|
|
|
|
///, such cells would be write-only.
|
2026-04-29 00:58:38 -04:00
|
|
|
pub fn lookup(&self, name: &str) -> Option<FieldId> {
|
|
|
|
|
// Walk `names` directly so we don't require the post-deserialise
|
|
|
|
|
// `ensure_lookup()` rebuild before this method is callable.
|
2026-04-29 19:53:34 -04:00
|
|
|
// Callers usually own `&SsaBody`, interning was either done at
|
|
|
|
|
// lowering time or via `ensure_lookup` post-deserialise, so the
|
2026-04-29 00:58:38 -04:00
|
|
|
// hot path goes through the `lookup` table; the linear walk is
|
|
|
|
|
// a fallback for the (small) deserialised-but-not-rebuilt case.
|
|
|
|
|
if let Some(&id) = self.lookup.get(name) {
|
|
|
|
|
return Some(FieldId(id));
|
|
|
|
|
}
|
|
|
|
|
for (idx, n) in self.names.iter().enumerate() {
|
|
|
|
|
if n == name {
|
|
|
|
|
return Some(FieldId(idx as u32));
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
None
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/// Resolve a [`FieldId`] back to its interned name.
|
|
|
|
|
pub fn resolve(&self, id: FieldId) -> &str {
|
|
|
|
|
&self.names[id.0 as usize]
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/// Number of unique interned names.
|
|
|
|
|
pub fn len(&self) -> usize {
|
|
|
|
|
self.names.len()
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/// Whether the interner contains no names.
|
|
|
|
|
pub fn is_empty(&self) -> bool {
|
|
|
|
|
self.names.is_empty()
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/// Rebuild the reverse lookup after deserialization. Called lazily by
|
|
|
|
|
/// [`Self::ensure_lookup`] so deserialized interners can still be used
|
|
|
|
|
/// for further interning.
|
|
|
|
|
fn rebuild_lookup(&mut self) {
|
|
|
|
|
self.lookup.clear();
|
|
|
|
|
for (i, n) in self.names.iter().enumerate() {
|
|
|
|
|
self.lookup.entry(n.clone()).or_insert(i as u32);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/// Ensure the reverse lookup is populated (rebuilds after a serde
|
|
|
|
|
/// roundtrip when the lookup table was skipped).
|
|
|
|
|
pub fn ensure_lookup(&mut self) {
|
|
|
|
|
if self.lookup.len() != self.names.len() {
|
|
|
|
|
self.rebuild_lookup();
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
Release/0.5.0 (#35)
* feat: Introduce function-scoped variable interning for state analysis with new tests and fixtures
* feat: Add Phase 26 symbolic execution enhancements with bitwise operator support, abstract interpretation refinements, and new taint analysis tests
* feat: Refine state analysis to handle factory-pattern resource returns with mixed-path tests and leak detection enhancements
* feat: Add Phase 27 debug views with symbolic execution, abstract interpretation, SSA, and call graph viewers; integrate with debug layout and styles
* feat: Add Phase 31 type-qualified symbolic resolution with receiver-based callee disambiguation and testing
* feat: Extend symbolic execution with state iteration, enhanced debug views, and debounced input handling
* feat: Add Phase 13 resource and auth pattern extensions with new tests and fixtures
* feat: Introduce CFG debug graph renderer with compact mode, toolbar, and DAG layout integration
* feat: Add Phase 28 encoding and decoding transform modeling with structural symex enhancements and new taint analysis tests
* feat: Extend abstract interpretation with type facts and constant value tracking in debug views and server logic
* feat: Add linear path handling and witness extraction to symbolic execution with Phase 28 transform mismatch detection
* feat: Refine Go auth and sanitizer handling with enhanced rules, state updates, and benchmark improvements
* feat: Enable auth-state analysis by default and update relevant tests in benchmark config
* test: Update state_tests to reflect default enablement of auth-state analysis and add auth suppression test
* docs: update CHANGELOG.md
* feat: Introduce per-index taint tracking in `HeapState` with `HeapSlot`, overflow handling, and revised SSA transfers
* feat: Introduce C/C++ language labels and refine heap state tracking in SSA transfers
* feat: Implement per-index array slot tracking in symbolic heap with overflow collapse
* feat: Add implicit definition handling for uninitialized declarations in SSA value allocation
* feat: Refactor function parameters and constants for improved clarity and maintainability
* refactor: Reorder module imports and improve formatting for consistency
* refactor: Fix formatting erorrs
* refactor: Fix clippy warnings
* refactor: Fix fmt warnings (again)
* chore: Update dependencies and improve feature configuration
* Add comprehensive tests for undertested modules (#36) (COPILOT)
* Add comprehensive tests for undertested modules
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/f3fc877e-f386-49ba-9793-fc93d3805083
* Add comprehensive tests for ext, project, walk, and errors modules
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/f3fc877e-f386-49ba-9793-fc93d3805083
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
* chore: Update dependencies and improve feature configuration
* fix: formatting errors in new tests
* chore: Update license list in about.toml
* chore: made functions input inline
* chore: updated cfg graph to take up the full page
* chore: add Prettier configuration and update code formatting
* Add frontend test suite with Vitest (111 tests) (#37)
* Add Vitest test suite for frontend - 111 tests across utils, components, hooks, and graph utilities
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/7cf0dba2-ecff-4740-ba4d-92717e74a0b7
* ci: add frontend test step to CI workflow
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/5bc0ac9f-0a32-4d03-9cb7-7a15aea53fca
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
* chore: simplify array initialization in test files for consistency
* ran typecheck
* feat: add AnalysisWorkspace component and integrate it into CfgViewerPage
* feat: update routing in AppLayout and improve empty state message in ExplorerPage
* feat: enhance scan progress tracking with additional metrics and stages
* feat: update license information and add license check script
* feat: implement cross-file symbolic execution with callee body persistence
* feat: replace dagre graphs with Graphology + ELK + Sigma for more advanced call stack and cfg rendering
* feat: ensure CFG function view is scoped to the selected function, preventing bleed into sibling functions
* feat: enhance resource tracking with proxy method summaries and improve finding extraction
* feat: add terminal function exit detection for accurate resource leak analysis
* feat: add warnings for loops and functions without bodies to improve error recovery
* feat: update lambda expression handling to ensure proper function classification and control flow
* feat: remove bounded formatting/string ops and add JSON.parse sanitizer for improved data handling
* feat: add inline return taint analysis and regression tests for improved security checks
* feat: add engine version management and migration handling for database schema updates
* feat: enhance first_call_ident to skip nested function bodies and add regression tests
* feat: enhance callee name resolution with two-segment normalization and disambiguation
* feat: add cross-file context flags and debug assertions for taint analysis
* feat: refactor taint analysis structure to unify context handling and improve clarity
* feat: enhance dead code elimination to preserve Sink, Source, and Sanitizer labels with new tests
* docs: updated CHANGELOG.md
* fmt: formatting fixes
* fix: fixed frontend formatting and lint warnings
* fix: optimized ci
* fix: optimized ci
* Add comprehensive multi-file test coverage to Nyx (#38)
* Initial checklist for multi-file test suite expansion
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/e550cb88-9767-4442-94d4-101bf5bb0e23
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
* Add 12 new multi-file test fixtures with TP/TN/near-miss coverage
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/e550cb88-9767-4442-94d4-101bf5bb0e23
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
* deleted root repo
* rebuilt to test for regressions
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
Co-authored-by: elipeter <elicpeter@gmail.com>
* feat: enhance import alias resolution and taint tracking
* feat: implement security hardening with CSRF protection and path validation
* feat: add support for import alias bindings in Python, PHP, and Rust
* feat: enhance CFG analysis modes and improve code readability
* feat: add detection for parameterized SQL queries to enhance security
* feat: add safe internal redirect handling and enhance session destroy validation
* feat: implement security improvements by addressing vulnerabilities in execAsync, session management, and file downloads
* feat: enhance taint detection by adding support for inline source member expressions in call arguments
* feat: implement pre-emission of Source nodes for inline source member expressions in call arguments
* feat: add support for Throw statement in control flow and error handling
* feat: add debug and echo endpoints with potential information leakage
* feat: implement internal redirect suppression and enhance taint detection
* feat: implement module alias tracking for dynamic dispatch in JS/TS
* feat: add authorization analysis module with Express support
* feat: add authorization analysis module with Express support
* feat: add tests for admin guard requirements and clean checks in authorization analysis
* feat: integrate Koa and Fastify frameworks into authorization analysis
* feat: add Flask and Django support to authorization analysis module
* feat: add support for Rails and Sinatra frameworks in authorization analysis
* feat: add support for Axum, ActixWeb, and Rocket frameworks in authorization analysis
* feat: add support for ActixWeb, Axum, and Rocket frameworks in authorization analysis
* feat: add support for Rails and Sinatra in authorization analysis
* chore: add .DS_Store to .gitignore
* refactor: simplify conditional checks and improve readability in multiple files
* refactor: update usage of Option methods for improved clarity and consistency
* refactor: improve code readability by simplifying conditional checks and formatting
* refactor: improve code formatting and readability by simplifying conditional checks
* refactor: simplify conditional checks and improve readability in multiple files
* refactor: simplify conditional checks in axum.rs for improved readability
* feat: add CodeQL analysis configuration for enhanced security scanning
* test: add comprehensive tests for `src/output.rs` SARIF builder (#39)
* chore: start test coverage improvement work
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/cd7ff398-134e-4728-a5e7-0353a0744423
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
* test: add comprehensive tests for src/output.rs SARIF builder
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/cd7ff398-134e-4728-a5e7-0353a0744423
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
* refactor: improve code formatting and readability in output.rs
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
Co-authored-by: elipeter <elicpeter@gmail.com>
* refactor: improve code formatting and readability in output.rs
* Potential fix for code scanning alert no. 210: Uncontrolled data used in path expression
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
* Potential fix for code scanning alert no. 211: Uncontrolled data used in path expression
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
* refactor: enhance triage file path handling with improved error management and validation
* refactor: updated func summaries for richer detail
* refactor: update SSA summary extraction to use canonical FuncKey for distinct entries
* refactor: enhance callee metadata structure to support arity, receiver, and qualifier for better overload resolution
* refactor: add support for keyword arguments in function calls and enhance receiver extraction for method-style calls
* refactor: implement new Flask routes for safe and unsafe shell command execution
* refactor: separate receiver handling in SSA operations and enhance taint propagation
* refactor: improve arity handling by using arg_uses for positional argument count and enhance witness scoring for tainted arguments
* refactor: implement auth decorator extraction and classification for multiple languages
* refactor: enhance Rust module path resolution and use map handling for cross-file disambiguation
* refactor: introduce CalleeQuery struct for structured callee resolution and enhance resolver logic
* refactor: implement same-file identity collision handling for `runTask` to ensure correct resolver behavior
* refactor: standardize default struct initialization across multiple files
* feat: add scripts for formatting checks and auto-fixes with test summaries
* refactor: simplify character splitting and enhance namespace qualifier handling
* refactor: improve documentation clarity and enhance code readability in resolver logic
* refactor: replace default struct initialization with explicit field assignments for clarity
* feat: enhance anonymous function naming by deriving context-based bindings
* refactor: streamline match expressions for improved readability and performance
* refactor: streamline match expressions for improved readability and performance
* refactor: replace loop with while let for improved clarity and performance
* feat: add SSA constant propagation support to analysis context for improved accuracy
* feat: add SSA constant propagation support to analysis context for improved accuracy
* feat: implement shell metacharacter validation and bounded-length checks in Rust analysis
* feat: add static map analysis for command injection suppression and type safety
* refactor: simplify match statements and reduce line breaks for improved readability
* feat(summary): phase 1/5 SinkSite data model for primary sink-location attribution
Introduce SinkSite (file_rel, line, col, snippet, cap) carrying the
primary sink source-location through function summaries. Swap
SsaFuncSummary.param_to_sink and FuncSummary.param_to_sink from a coarse
Cap map to a deduped SmallVec<[SinkSite; 1]> per parameter, with a
backward-compatible cap_sites() helper and serde defaults so pre-phase-1
on-disk rows continue to deserialise cleanly.
Extraction: SinkSiteLocator bundles the tree/bytes/file_rel needed by
extract_ssa_func_summary; ParsedFile::extract_ssa_artifacts wires the
locator in for the persisted pass-1 path, while pass-2 intra-file
transient summaries fall back to cap-only sites (behavior unchanged).
Merge: GlobalSummaries::insert now unions sink sites with
(file_rel, line, col, cap) dedup via shared union_param_sink_sites
helper.
Database: JSON-serialised summary columns carry the new shape
automatically; no schema change needed.
Phase 2 will consume SinkSite in build_taint_diag() to overwrite the
caller-site Finding.line with the callee's sink line when resolved via
summary. Phase 1 keeps behavior unchanged: scanning
tests/benchmark/corpus/rust/cmdi/cmdi_indirect.rs still produces the
same (wrong) line 10 finding.
Adds round-trip tests covering SinkSite solo, SsaFuncSummary with sink
sites, legacy-JSON default handling for both summary types, and merge
dedup.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
* feat(taint): phase 2/5 thread SinkSite into SsaTaintEvent and Finding
Plumb Phase 1's SinkSite through the event pipeline into Findings,
no output change yet. SsaTaintEvent gains `primary_sink_site:
Option<SinkSite>`; when the main or callback sink-emission path has
non-empty `param_to_sink_sites`, filter to sites whose
`(line != 0) && (cap ∩ sink_caps != ∅)` and emit one event per
distinct site — the multi-primary collapse keeps each downstream
Finding single-primary.
Resolution: ResolvedSummary and SinkInfo gain mirror
`param_to_sink_sites` fields, populated from `SsaFuncSummary.param_to_sink`
(SSA + callback paths) and `FuncSummary.param_to_sink` (global paths).
Label, local-summary, and interop resolution paths leave the field
empty — they only ever had cap-level info to begin with.
Finding: new `primary_location: Option<SinkLocation>` with
`file_rel/line/col`. `ssa_events_to_findings` maps
`event.primary_sink_site` → `Finding.primary_location`, filtering
cap-only sites (`line == 0`) to `None` so the (0,0) sentinel never
leaks to formatters. Dedup key extended with the primary location
so multi-site events aren't collapsed back together.
Invariants (debug_assert!):
* every SinkSite reaching emission has `line != 0 && cap ∩ sink_caps
!= ∅` — enforced by the pick_primary_sink_sites* filters;
* every populated Finding.primary_location has `line != 0` AND
non-empty `file_rel` — the cap-only → None translation upstream
guarantees this.
Deliberately independent of `uses_summary`: that flag tracks whether
the *taint chain* used a summary, whereas primary attribution
requires only that the *sink* itself was summary-resolved. A local
source reaching a cross-file sink produces `uses_summary=false`
alongside a populated primary_location — documented on
Finding.primary_location, covered by
`cross_file_sink_finding_carries_primary_location`.
build_taint_diag, SARIF/JSON/explanation formatters, and the
benchmark scorer remain untouched: finding.line still comes from
`cfg_graph[finding.sink]`, so cmdi_indirect.rs still reports line 10
and the benchmark's rs-cmdi-003 row still shows FN in the LOC column.
Tests: `cross_file_sink_finding_carries_primary_location` (proves
plumbing via a synthetic FuncSummary carrying a SinkSite at 42:5) and
`cross_file_sink_cap_only_site_leaves_primary_location_none`
(regression guard against cap-only sites surfacing). All 1566 lib
tests + integration tests pass.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* feat(output): phase 3/5 consume primary sink location in diag + SARIF
When a finding's primary_location (populated in phase 2 from a callee
summary's SinkSite) names the dangerous instruction inside a callee
body, attribute the diagnostic line to that location instead of the
caller's call site. The call site is demoted to a Call step in
flow_steps, and a synthetic Sink step at the primary location is
appended so analysts still see the full trace.
Changes:
- Add scan_root parameter to build_taint_diag so file_rel can be
resolved back to an absolute path via a shared resolve_file_rel
helper. Empty file_rel (single-file scans where namespace == "")
resolves to the file under analysis.
- Extend SinkLocation with snippet, carried from the upstream
SinkSite so the formatter needs no second file read.
- Relax the ssa_events_to_findings debug_assert to allow empty
file_rel, which is valid when scan root equals the file itself.
- SARIF: emit data-flow as codeFlows[0].threadFlows[0].locations[];
locations[0] already reflects the primary sink position via the
updated diag line/col.
Acceptance: scan on tests/benchmark/corpus/rust/cmdi/cmdi_indirect.rs
now reports line 5 (Command::new) as the primary sink, with the call
site at line 10 visible in flow_steps.
Two expect.json fixtures updated (must_match line_range widened):
- javascript/taint/context_sensitive_call: 12-14 -> 7-14 (line 8 is
the real sink inside run()).
- rust/cfg/closure_async: 10-10 -> 10-11 (line 11 is Command::new
inside the closure).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* feat(bench): phase 4/5 validate primary sink attribution across corpus
Extend the benchmark scorer and ground truth to lock in phase 3's
primary-location behavior, and add fixtures that exercise the new
capability end-to-end.
Scorer (tests/benchmark_test.rs):
- Add optional `expected_call_site_lines: Option<Vec<[usize; 2]>>` on
Case. When present, score_location_level additionally requires at
least one flow_step in the finding's evidence trace to fall within
±2 of the call-site range. When absent, the check is skipped —
fully forward-compatible with existing fixtures.
- Retain ±2 tolerance on expected_sink_lines (compared against the
now-primary Diag.line post-phase-3).
Ground truth edits:
- rs-cmdi-cross-001: expected_sink_lines [8,8] -> [9,9]. Line 8 is the
transform::wrap call site (a cross-file propagator, not a sink);
line 9 is Command::new, the real sink. The ±2 tolerance happened to
mask this stale attribution but it was semantically wrong — phase 4
is the right time to correct it. Also adds expected_call_site_lines
[8,8] so the new field is exercised on an existing cross-file case.
- rs-cmdi-003: adds expected_call_site_lines [10,10] (run_cmd call).
This fixture's sink (Command::new inside run_cmd at line 5) was the
motivating case for phases 1-3; adding the call-site assertion
guards against regression to caller-line attribution.
New fixtures:
- rust/cmdi/cmdi_indirect_multisink.rs (rs-cmdi-009): helper run_both
takes two tainted params and invokes two Command sinks on
consecutive lines. Locks in that primary line lands inside the
helper (lines 5-6), not at the caller (line 12). Notes document
that SinkSite is currently one-per-callee so both findings today
collapse onto the first sink; expected_sink_lines=[5,6] and
expected_call_site_lines=[12,12] stay valid either way.
- python/cmdi/cross_indirect_sink/{app.py,helper.py} (py-cmdi-cross-
004): sink os.system lives in helper.py (cross-file), caller in
app.py reads env source and calls run_cmd. Verifies phase 3's
cross-file primary attribution: Diag.path = helper.py, Diag.line =
5, with app.py:7 recorded in flow_steps as a Call step.
Acceptance:
- `cargo test --test benchmark_test -- --ignored --nocapture` passes.
- rs-cmdi-003 is TP/TP/TP (the target flip FN->TP at LOC). All
pre-existing TP/TP/TP fixtures remain TP/TP/TP; 2 new fixtures are
TP/TP/TP.
- Aggregate rule-level: TP=158 FP=10 FN=1 TN=97, P=0.940 R=0.994
F1=0.966 on the 266-case corpus (was TP=156 FP=10 FN=1 TN=97 on
264 pre-phase-4, delta is the +2 new cases both resolving TP).
- Full `cargo test` green (1566 lib tests + all integration tests).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* feat(taint): phase 5/5 lock Finding.primary_location contract via regression test
Add a regression test in src/taint/ssa_transfer.rs that wires up a synthetic
SsaFuncSummary with a SinkSite at other.rs:42:10 and drives the three
emission stages (pick_primary_sink_sites → emit_ssa_taint_events →
ssa_events_to_findings) against a minimal caller SSA body. Asserts the
resulting Finding.primary_location is exactly that triple.
The existing integration tests in src/taint/tests.rs cover the coarse
FuncSummary path end-to-end through analyse_file. This test locks in the
lower-level SSA-side plumbing so a future refactor that silently drops the
site between pick → emit → findings fails here rather than only at the
benchmark layer.
Also refreshes tests/benchmark/results/latest.json (timestamp only; rs-cmdi-003
remains TP/TP/TP and the aggregate P/R/F1 are unchanged from phase 4).
Closes the primary sink-location attribution feature (phases 1-5/5):
* Phase 1 — SinkSite data model on summaries.
* Phase 2 — SinkSite threaded into SsaTaintEvent and Finding.
* Phase 3 — diag + SARIF consume primary_location.
* Phase 4 — benchmark validates primary_call_site_lines across corpus.
* Phase 5 — regression test locks the event→finding contract.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* refactor: clean up formatting and improve readability in multiple files
* refactor: simplify type definition for deduplication key in findings
* test(harness): add must_not_match expectation for FP regression guards
Extends ExpectedFinding with must_not_match field that asserts a
diagnostic must NOT fire — presence is a hard failure. Non-consuming
scan so it coexists with must_match entries on the same rule_id.
Adds forbidden_violations accumulator and updates summary line.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* feat(regression): update expectations to ensure must_not_match for various taint and resource leak rules
* feat: implement auto-seeding for JS/TS handler parameters to enhance taint tracking
* feat: update switch statement handling to improve control flow analysis
* feat: implement promisify alias handling for JS/TS to enhance taint tracking
* feat: enhance taint tracking by refining expectation handling and adding mode filtering
* feat: refine SQL handling in stream processing and enhance auto-seeding for handler parameters
* feat: update taint tracking rules to enforce full mode matching and improve flow analysis
* feat: enhance Ruby subshell handling to improve taint tracking and flow analysis
* feat: update xss_response expectations to refine taint flow analysis and enhance regression guarding
* feat: refine framework detection and update expectation handling for Echo and Sinatra
* feat: implement max_count for taint tracking expectations and deduplicate findings
* feat: add strict_unexpected handling for taint-unsanitised-flow in expectation files
* feat: enhance deduplication of taint-unsanitised-flow findings by collapsing based on line and severity
* feat: add strict_unexpected handling for taint-unsanitised-flow in multiple expectation files
* feat: add structural invariant checks for SSA bodies
* feat: ensure deterministic phi emission order using BTreeSet
* feat: enhance handling of terminators to ensure authoritative flow through successor edges
* feat: enhance Goto terminator handling to ensure all successors are marked executable
* feat: refactor code for improved readability and organization
* feat: simplify predicate checks and enhance readability in SSA handling
* feat: implement per-file parse timeout and enhance file size handling
* feat: migrate analysis engine toggles from environment variables to configuration file
* feat: remove unnecessary whitespace in hostile_input_tests.rs
* feat: remove unnecessary whitespace in hostile_input_tests.rs
* feat: update dependencies and enhance documentation on language maturity
* feat: enhance security headers and improve request body limits
* feat: implement sink capability bits for deduplication and enhance evidence tagging
* feat: implement dynamic activation handling for gated sinks and enhance validation logic
* feat: enhance configuration documentation and clarify inline analysis cache behavior
* feat: implement panic recovery during analysis to continue scans past errors
* feat: add expectations configuration for taint analysis and performance metrics
* feat: enhance error handling and logging during file reading and mutex locking
* feat: add cross-file body loading tests and plumbing for CF-1 phase
* feat: implement cross-file k=1 context-sensitive inline taint analysis with new tests and fixtures
* feat: implement indexed-scan parity in cross-file inline analysis with new dropdown and copy functionality
* feat: enhance classification span handling in CFG and AST for improved source attribution
* feat: add new Express routes for handling user input and telemetry data
* feat: implement ternary expression handling in CFG with diamond structure for JS/TS
* feat: implement Phase CF-3 abstract-domain transfer channels in summaries
* feat: add support for string-prefix transfer in cross-file calls and update tests
* docs: reduce RESULTS.md doc size
* feat: implement Phase CF-4 per-return-path summary decomposition with tests
* feat: update parameter handling in pass1 and refactor SsaFuncSummary initialization
* feat: implement Phase CF-5 for cross-file SCC joint fixed-point convergence with new flags and tests
* feat: implement Phase CF-6 with parameter-granularity points-to summaries and associated tests
* refactor: update comments and documentation for clarity and consistency
* style: format code for consistency and readability
* refactor: simplify verdict handling and improve edge checking logic
* refactor: optimize path and identifier collection by avoiding unnecessary cloning
* chore: update Cargo.toml for Rust version 1.85 and add ignored files; modify CHANGELOG and README for clarity on state analysis defaults
* refactor: update documentation and improve clarity in configuration files
* refactor: update documentation and improve clarity in configuration files
* feat: add JS/TS pass-2 convergence tests and expectations configuration
* feat: add Phase 5 regression tests for inline cache origin attribution and update related logic
* feat: implement Phase 7 deduplication and alternative path linking for taint findings
* feat: implement structural DFS index for anonymous functions and update naming conventions
* feat: add Phase 8 regression tests for container-element taint in JS and Python
* feat: add engine-depth profiles and explain-engine option for CLI
* feat: update expectations and add new README fixtures for multi-file scan regression
* feat: implement Phase 11 callback-alias and factory patterns with regression tests
* feat: implement Terminator::Switch for multi-way dispatch and add regression tests
* feat: add real-CVE benchmark fixtures for CVE-2023-48022, CVE-2019-14939, and CVE-2023-26159 with corresponding patched variants
* refactor: extract cfg and ssa_transfer to submodules
* refactor: cargo fmt
* refactor: remove unnecessary blank line in cfg_tests.rs
* refactor: remove unnecessary planning file
* chore: update Rust version to 1.88 and bump dependencies in Cargo files
* feat: enhance triage UI with new layout and controls, update README for clarity
* feat: enhance triage UI with new layout and controls, update README for clarity
* chore: remove outdated section from README for version 0.5.0
* docs: improve clarity and consistency in README content
* chore: add "GPL-3.0-or-later" to license options in about.toml
* chore: update license handling in about.toml and check-licenses.mjs
* style: format code for improved readability in TriagePage component
* style: format code for improved readability in TriagePage component
* chore: enhance license handling and improve body_id scoping in seed lookup
* feat: introduce owner and parent body IDs for enhanced seed scoping
* feat: implement direction-aware engine provenance with new CLI flag for strict CI gating
* feat: add Undef SSA operation for improved control-flow handling
* style: improve code formatting for consistency and readability in multiple files
* feat: add 16-function chain SCC across multiple files for enhanced analysis
* style: simplify code formatting for improved readability in multiple files
* fix: update CapHitReason default implementation and improve README clarity
* docs: enhance README with detailed explanations of taint analysis and limitations
* docs: refine README for clarity and consistency in taint analysis section
* style: improve code formatting for better readability in NewScanModal and scans
* fix: update cargo-about command to use --offline for deterministic license generation
* fix: update cargo-about command to use --offline for deterministic license generation
* ci: add step to prime cargo registry cache for deterministic license generation
* feat: add support for non-sink collections in authorization analysis
* feat: enhance authorization checks with row-level ownership equality and binding tracking
* feat: implement self-scoped user handling and enhance ownership checks
* refactor: simplify assertions and formatting in authorization analysis tests
* fix: normalize line endings in THIRDPARTY-LICENSES.html generation and update README with AI disclosure
* docs: update AI disclosure section for clarity and conciseness
* feat: add AI Contribution Policy and update contributing guidelines for AI assistance disclosure
* feat: enhance authorization analysis with SSA-derived variable type classification
* feat: implement auth_finding_to_diag function for enhanced security diagnostics
* feat: add args_value_refs to CallSite struct for enhanced argument tracking
* feat: add args_value_refs to CallSite struct for enhanced argument tracking
* feat: add direction-aware engine provenance with LossDirection classification and new CLI flag
* feat: simplify strip_cap_from_call_args call by removing unnecessary line breaks
* feat: enhance error message handling in cli_validation_tests for better Windows compatibility
* feat: optimize release profile settings in Cargo.toml and update CodeQL configuration
* feat: enhance release build process with SBOM generation and SLSA provenance
* feat: update actions/checkout and actions/setup-node to v6, enhance CLI options, and improve auth-check summaries
* feat: introduce PathFact handling for path safety checks and rejection logic
* feat: introduce PathFact handling for path safety checks and rejection logic
* feat: update benchmark data and enhance path sanitization logic with new safety checks
* feat: document AI assistance in frontend UI development and human review process
* feat: add return path facts for enhanced path safety checks and update documentation
* chore: update release date for version 0.5.0 in CHANGELOG.md
* chore: clean up ci.yml by removing outdated comments and clarifying steps
* feat: implement cross-language path sanitizers and validators for enhanced security
* feat: enhance SSA value usage tracking by including block terminators and improve path safety checks
* feat: enhance switch statement handling by adding per-case path constraints and support for exclusive cases
* refactor: simplify conditional formatting and improve code readability in executor and lower modules
* feat: add vulnerable examples for various languages demonstrating authentication and sanitization issues
* feat: enhance actor context recognition for self-actor identifiers and add support for global non-sink receivers
* feat: enhance actor context recognition for self-actor identifiers and add support for global non-sink receivers
* feat: add transform classifiers for Java, Go, and Ruby with corresponding tests
* refactor: clarify comments on reassign-to-constant idiom and sink behavior in guards.rs
---------
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
2026-04-25 17:59:11 -04:00
|
|
|
/// SSA instruction operation.
|
|
|
|
|
#[derive(Clone, Debug, Serialize, Deserialize)]
|
|
|
|
|
pub enum SsaOp {
|
|
|
|
|
/// Phi: merge values from predecessor blocks.
|
|
|
|
|
Phi(SmallVec<[(BlockId, SsaValue); 2]>),
|
|
|
|
|
/// Assignment: result depends on the listed SSA values.
|
|
|
|
|
Assign(SmallVec<[SsaValue; 4]>),
|
|
|
|
|
/// Function/method call.
|
2026-04-29 00:58:38 -04:00
|
|
|
///
|
|
|
|
|
/// `callee` is the canonical name SSA-time consumers should match on.
|
|
|
|
|
/// When SSA lowering decomposes a chained-receiver method call into a
|
|
|
|
|
/// `FieldProj` chain (e.g. `c.mu.Lock()` → `v_mu = FieldProj(v_c, "mu")`,
|
|
|
|
|
/// `Call("Lock", [v_mu])`), `callee` carries the bare method name
|
|
|
|
|
/// (`"Lock"`) and `callee_text` carries the original full path
|
|
|
|
|
/// (`Some("c.mu.Lock")`). When no decomposition happens, `callee_text`
|
|
|
|
|
/// is `None` and `callee` already holds the original textual form.
|
Release/0.5.0 (#35)
* feat: Introduce function-scoped variable interning for state analysis with new tests and fixtures
* feat: Add Phase 26 symbolic execution enhancements with bitwise operator support, abstract interpretation refinements, and new taint analysis tests
* feat: Refine state analysis to handle factory-pattern resource returns with mixed-path tests and leak detection enhancements
* feat: Add Phase 27 debug views with symbolic execution, abstract interpretation, SSA, and call graph viewers; integrate with debug layout and styles
* feat: Add Phase 31 type-qualified symbolic resolution with receiver-based callee disambiguation and testing
* feat: Extend symbolic execution with state iteration, enhanced debug views, and debounced input handling
* feat: Add Phase 13 resource and auth pattern extensions with new tests and fixtures
* feat: Introduce CFG debug graph renderer with compact mode, toolbar, and DAG layout integration
* feat: Add Phase 28 encoding and decoding transform modeling with structural symex enhancements and new taint analysis tests
* feat: Extend abstract interpretation with type facts and constant value tracking in debug views and server logic
* feat: Add linear path handling and witness extraction to symbolic execution with Phase 28 transform mismatch detection
* feat: Refine Go auth and sanitizer handling with enhanced rules, state updates, and benchmark improvements
* feat: Enable auth-state analysis by default and update relevant tests in benchmark config
* test: Update state_tests to reflect default enablement of auth-state analysis and add auth suppression test
* docs: update CHANGELOG.md
* feat: Introduce per-index taint tracking in `HeapState` with `HeapSlot`, overflow handling, and revised SSA transfers
* feat: Introduce C/C++ language labels and refine heap state tracking in SSA transfers
* feat: Implement per-index array slot tracking in symbolic heap with overflow collapse
* feat: Add implicit definition handling for uninitialized declarations in SSA value allocation
* feat: Refactor function parameters and constants for improved clarity and maintainability
* refactor: Reorder module imports and improve formatting for consistency
* refactor: Fix formatting erorrs
* refactor: Fix clippy warnings
* refactor: Fix fmt warnings (again)
* chore: Update dependencies and improve feature configuration
* Add comprehensive tests for undertested modules (#36) (COPILOT)
* Add comprehensive tests for undertested modules
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/f3fc877e-f386-49ba-9793-fc93d3805083
* Add comprehensive tests for ext, project, walk, and errors modules
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/f3fc877e-f386-49ba-9793-fc93d3805083
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
* chore: Update dependencies and improve feature configuration
* fix: formatting errors in new tests
* chore: Update license list in about.toml
* chore: made functions input inline
* chore: updated cfg graph to take up the full page
* chore: add Prettier configuration and update code formatting
* Add frontend test suite with Vitest (111 tests) (#37)
* Add Vitest test suite for frontend - 111 tests across utils, components, hooks, and graph utilities
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/7cf0dba2-ecff-4740-ba4d-92717e74a0b7
* ci: add frontend test step to CI workflow
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/5bc0ac9f-0a32-4d03-9cb7-7a15aea53fca
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
* chore: simplify array initialization in test files for consistency
* ran typecheck
* feat: add AnalysisWorkspace component and integrate it into CfgViewerPage
* feat: update routing in AppLayout and improve empty state message in ExplorerPage
* feat: enhance scan progress tracking with additional metrics and stages
* feat: update license information and add license check script
* feat: implement cross-file symbolic execution with callee body persistence
* feat: replace dagre graphs with Graphology + ELK + Sigma for more advanced call stack and cfg rendering
* feat: ensure CFG function view is scoped to the selected function, preventing bleed into sibling functions
* feat: enhance resource tracking with proxy method summaries and improve finding extraction
* feat: add terminal function exit detection for accurate resource leak analysis
* feat: add warnings for loops and functions without bodies to improve error recovery
* feat: update lambda expression handling to ensure proper function classification and control flow
* feat: remove bounded formatting/string ops and add JSON.parse sanitizer for improved data handling
* feat: add inline return taint analysis and regression tests for improved security checks
* feat: add engine version management and migration handling for database schema updates
* feat: enhance first_call_ident to skip nested function bodies and add regression tests
* feat: enhance callee name resolution with two-segment normalization and disambiguation
* feat: add cross-file context flags and debug assertions for taint analysis
* feat: refactor taint analysis structure to unify context handling and improve clarity
* feat: enhance dead code elimination to preserve Sink, Source, and Sanitizer labels with new tests
* docs: updated CHANGELOG.md
* fmt: formatting fixes
* fix: fixed frontend formatting and lint warnings
* fix: optimized ci
* fix: optimized ci
* Add comprehensive multi-file test coverage to Nyx (#38)
* Initial checklist for multi-file test suite expansion
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/e550cb88-9767-4442-94d4-101bf5bb0e23
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
* Add 12 new multi-file test fixtures with TP/TN/near-miss coverage
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/e550cb88-9767-4442-94d4-101bf5bb0e23
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
* deleted root repo
* rebuilt to test for regressions
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
Co-authored-by: elipeter <elicpeter@gmail.com>
* feat: enhance import alias resolution and taint tracking
* feat: implement security hardening with CSRF protection and path validation
* feat: add support for import alias bindings in Python, PHP, and Rust
* feat: enhance CFG analysis modes and improve code readability
* feat: add detection for parameterized SQL queries to enhance security
* feat: add safe internal redirect handling and enhance session destroy validation
* feat: implement security improvements by addressing vulnerabilities in execAsync, session management, and file downloads
* feat: enhance taint detection by adding support for inline source member expressions in call arguments
* feat: implement pre-emission of Source nodes for inline source member expressions in call arguments
* feat: add support for Throw statement in control flow and error handling
* feat: add debug and echo endpoints with potential information leakage
* feat: implement internal redirect suppression and enhance taint detection
* feat: implement module alias tracking for dynamic dispatch in JS/TS
* feat: add authorization analysis module with Express support
* feat: add authorization analysis module with Express support
* feat: add tests for admin guard requirements and clean checks in authorization analysis
* feat: integrate Koa and Fastify frameworks into authorization analysis
* feat: add Flask and Django support to authorization analysis module
* feat: add support for Rails and Sinatra frameworks in authorization analysis
* feat: add support for Axum, ActixWeb, and Rocket frameworks in authorization analysis
* feat: add support for ActixWeb, Axum, and Rocket frameworks in authorization analysis
* feat: add support for Rails and Sinatra in authorization analysis
* chore: add .DS_Store to .gitignore
* refactor: simplify conditional checks and improve readability in multiple files
* refactor: update usage of Option methods for improved clarity and consistency
* refactor: improve code readability by simplifying conditional checks and formatting
* refactor: improve code formatting and readability by simplifying conditional checks
* refactor: simplify conditional checks and improve readability in multiple files
* refactor: simplify conditional checks in axum.rs for improved readability
* feat: add CodeQL analysis configuration for enhanced security scanning
* test: add comprehensive tests for `src/output.rs` SARIF builder (#39)
* chore: start test coverage improvement work
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/cd7ff398-134e-4728-a5e7-0353a0744423
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
* test: add comprehensive tests for src/output.rs SARIF builder
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/cd7ff398-134e-4728-a5e7-0353a0744423
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
* refactor: improve code formatting and readability in output.rs
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
Co-authored-by: elipeter <elicpeter@gmail.com>
* refactor: improve code formatting and readability in output.rs
* Potential fix for code scanning alert no. 210: Uncontrolled data used in path expression
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
* Potential fix for code scanning alert no. 211: Uncontrolled data used in path expression
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
* refactor: enhance triage file path handling with improved error management and validation
* refactor: updated func summaries for richer detail
* refactor: update SSA summary extraction to use canonical FuncKey for distinct entries
* refactor: enhance callee metadata structure to support arity, receiver, and qualifier for better overload resolution
* refactor: add support for keyword arguments in function calls and enhance receiver extraction for method-style calls
* refactor: implement new Flask routes for safe and unsafe shell command execution
* refactor: separate receiver handling in SSA operations and enhance taint propagation
* refactor: improve arity handling by using arg_uses for positional argument count and enhance witness scoring for tainted arguments
* refactor: implement auth decorator extraction and classification for multiple languages
* refactor: enhance Rust module path resolution and use map handling for cross-file disambiguation
* refactor: introduce CalleeQuery struct for structured callee resolution and enhance resolver logic
* refactor: implement same-file identity collision handling for `runTask` to ensure correct resolver behavior
* refactor: standardize default struct initialization across multiple files
* feat: add scripts for formatting checks and auto-fixes with test summaries
* refactor: simplify character splitting and enhance namespace qualifier handling
* refactor: improve documentation clarity and enhance code readability in resolver logic
* refactor: replace default struct initialization with explicit field assignments for clarity
* feat: enhance anonymous function naming by deriving context-based bindings
* refactor: streamline match expressions for improved readability and performance
* refactor: streamline match expressions for improved readability and performance
* refactor: replace loop with while let for improved clarity and performance
* feat: add SSA constant propagation support to analysis context for improved accuracy
* feat: add SSA constant propagation support to analysis context for improved accuracy
* feat: implement shell metacharacter validation and bounded-length checks in Rust analysis
* feat: add static map analysis for command injection suppression and type safety
* refactor: simplify match statements and reduce line breaks for improved readability
* feat(summary): phase 1/5 SinkSite data model for primary sink-location attribution
Introduce SinkSite (file_rel, line, col, snippet, cap) carrying the
primary sink source-location through function summaries. Swap
SsaFuncSummary.param_to_sink and FuncSummary.param_to_sink from a coarse
Cap map to a deduped SmallVec<[SinkSite; 1]> per parameter, with a
backward-compatible cap_sites() helper and serde defaults so pre-phase-1
on-disk rows continue to deserialise cleanly.
Extraction: SinkSiteLocator bundles the tree/bytes/file_rel needed by
extract_ssa_func_summary; ParsedFile::extract_ssa_artifacts wires the
locator in for the persisted pass-1 path, while pass-2 intra-file
transient summaries fall back to cap-only sites (behavior unchanged).
Merge: GlobalSummaries::insert now unions sink sites with
(file_rel, line, col, cap) dedup via shared union_param_sink_sites
helper.
Database: JSON-serialised summary columns carry the new shape
automatically; no schema change needed.
Phase 2 will consume SinkSite in build_taint_diag() to overwrite the
caller-site Finding.line with the callee's sink line when resolved via
summary. Phase 1 keeps behavior unchanged: scanning
tests/benchmark/corpus/rust/cmdi/cmdi_indirect.rs still produces the
same (wrong) line 10 finding.
Adds round-trip tests covering SinkSite solo, SsaFuncSummary with sink
sites, legacy-JSON default handling for both summary types, and merge
dedup.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
* feat(taint): phase 2/5 thread SinkSite into SsaTaintEvent and Finding
Plumb Phase 1's SinkSite through the event pipeline into Findings,
no output change yet. SsaTaintEvent gains `primary_sink_site:
Option<SinkSite>`; when the main or callback sink-emission path has
non-empty `param_to_sink_sites`, filter to sites whose
`(line != 0) && (cap ∩ sink_caps != ∅)` and emit one event per
distinct site — the multi-primary collapse keeps each downstream
Finding single-primary.
Resolution: ResolvedSummary and SinkInfo gain mirror
`param_to_sink_sites` fields, populated from `SsaFuncSummary.param_to_sink`
(SSA + callback paths) and `FuncSummary.param_to_sink` (global paths).
Label, local-summary, and interop resolution paths leave the field
empty — they only ever had cap-level info to begin with.
Finding: new `primary_location: Option<SinkLocation>` with
`file_rel/line/col`. `ssa_events_to_findings` maps
`event.primary_sink_site` → `Finding.primary_location`, filtering
cap-only sites (`line == 0`) to `None` so the (0,0) sentinel never
leaks to formatters. Dedup key extended with the primary location
so multi-site events aren't collapsed back together.
Invariants (debug_assert!):
* every SinkSite reaching emission has `line != 0 && cap ∩ sink_caps
!= ∅` — enforced by the pick_primary_sink_sites* filters;
* every populated Finding.primary_location has `line != 0` AND
non-empty `file_rel` — the cap-only → None translation upstream
guarantees this.
Deliberately independent of `uses_summary`: that flag tracks whether
the *taint chain* used a summary, whereas primary attribution
requires only that the *sink* itself was summary-resolved. A local
source reaching a cross-file sink produces `uses_summary=false`
alongside a populated primary_location — documented on
Finding.primary_location, covered by
`cross_file_sink_finding_carries_primary_location`.
build_taint_diag, SARIF/JSON/explanation formatters, and the
benchmark scorer remain untouched: finding.line still comes from
`cfg_graph[finding.sink]`, so cmdi_indirect.rs still reports line 10
and the benchmark's rs-cmdi-003 row still shows FN in the LOC column.
Tests: `cross_file_sink_finding_carries_primary_location` (proves
plumbing via a synthetic FuncSummary carrying a SinkSite at 42:5) and
`cross_file_sink_cap_only_site_leaves_primary_location_none`
(regression guard against cap-only sites surfacing). All 1566 lib
tests + integration tests pass.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* feat(output): phase 3/5 consume primary sink location in diag + SARIF
When a finding's primary_location (populated in phase 2 from a callee
summary's SinkSite) names the dangerous instruction inside a callee
body, attribute the diagnostic line to that location instead of the
caller's call site. The call site is demoted to a Call step in
flow_steps, and a synthetic Sink step at the primary location is
appended so analysts still see the full trace.
Changes:
- Add scan_root parameter to build_taint_diag so file_rel can be
resolved back to an absolute path via a shared resolve_file_rel
helper. Empty file_rel (single-file scans where namespace == "")
resolves to the file under analysis.
- Extend SinkLocation with snippet, carried from the upstream
SinkSite so the formatter needs no second file read.
- Relax the ssa_events_to_findings debug_assert to allow empty
file_rel, which is valid when scan root equals the file itself.
- SARIF: emit data-flow as codeFlows[0].threadFlows[0].locations[];
locations[0] already reflects the primary sink position via the
updated diag line/col.
Acceptance: scan on tests/benchmark/corpus/rust/cmdi/cmdi_indirect.rs
now reports line 5 (Command::new) as the primary sink, with the call
site at line 10 visible in flow_steps.
Two expect.json fixtures updated (must_match line_range widened):
- javascript/taint/context_sensitive_call: 12-14 -> 7-14 (line 8 is
the real sink inside run()).
- rust/cfg/closure_async: 10-10 -> 10-11 (line 11 is Command::new
inside the closure).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* feat(bench): phase 4/5 validate primary sink attribution across corpus
Extend the benchmark scorer and ground truth to lock in phase 3's
primary-location behavior, and add fixtures that exercise the new
capability end-to-end.
Scorer (tests/benchmark_test.rs):
- Add optional `expected_call_site_lines: Option<Vec<[usize; 2]>>` on
Case. When present, score_location_level additionally requires at
least one flow_step in the finding's evidence trace to fall within
±2 of the call-site range. When absent, the check is skipped —
fully forward-compatible with existing fixtures.
- Retain ±2 tolerance on expected_sink_lines (compared against the
now-primary Diag.line post-phase-3).
Ground truth edits:
- rs-cmdi-cross-001: expected_sink_lines [8,8] -> [9,9]. Line 8 is the
transform::wrap call site (a cross-file propagator, not a sink);
line 9 is Command::new, the real sink. The ±2 tolerance happened to
mask this stale attribution but it was semantically wrong — phase 4
is the right time to correct it. Also adds expected_call_site_lines
[8,8] so the new field is exercised on an existing cross-file case.
- rs-cmdi-003: adds expected_call_site_lines [10,10] (run_cmd call).
This fixture's sink (Command::new inside run_cmd at line 5) was the
motivating case for phases 1-3; adding the call-site assertion
guards against regression to caller-line attribution.
New fixtures:
- rust/cmdi/cmdi_indirect_multisink.rs (rs-cmdi-009): helper run_both
takes two tainted params and invokes two Command sinks on
consecutive lines. Locks in that primary line lands inside the
helper (lines 5-6), not at the caller (line 12). Notes document
that SinkSite is currently one-per-callee so both findings today
collapse onto the first sink; expected_sink_lines=[5,6] and
expected_call_site_lines=[12,12] stay valid either way.
- python/cmdi/cross_indirect_sink/{app.py,helper.py} (py-cmdi-cross-
004): sink os.system lives in helper.py (cross-file), caller in
app.py reads env source and calls run_cmd. Verifies phase 3's
cross-file primary attribution: Diag.path = helper.py, Diag.line =
5, with app.py:7 recorded in flow_steps as a Call step.
Acceptance:
- `cargo test --test benchmark_test -- --ignored --nocapture` passes.
- rs-cmdi-003 is TP/TP/TP (the target flip FN->TP at LOC). All
pre-existing TP/TP/TP fixtures remain TP/TP/TP; 2 new fixtures are
TP/TP/TP.
- Aggregate rule-level: TP=158 FP=10 FN=1 TN=97, P=0.940 R=0.994
F1=0.966 on the 266-case corpus (was TP=156 FP=10 FN=1 TN=97 on
264 pre-phase-4, delta is the +2 new cases both resolving TP).
- Full `cargo test` green (1566 lib tests + all integration tests).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* feat(taint): phase 5/5 lock Finding.primary_location contract via regression test
Add a regression test in src/taint/ssa_transfer.rs that wires up a synthetic
SsaFuncSummary with a SinkSite at other.rs:42:10 and drives the three
emission stages (pick_primary_sink_sites → emit_ssa_taint_events →
ssa_events_to_findings) against a minimal caller SSA body. Asserts the
resulting Finding.primary_location is exactly that triple.
The existing integration tests in src/taint/tests.rs cover the coarse
FuncSummary path end-to-end through analyse_file. This test locks in the
lower-level SSA-side plumbing so a future refactor that silently drops the
site between pick → emit → findings fails here rather than only at the
benchmark layer.
Also refreshes tests/benchmark/results/latest.json (timestamp only; rs-cmdi-003
remains TP/TP/TP and the aggregate P/R/F1 are unchanged from phase 4).
Closes the primary sink-location attribution feature (phases 1-5/5):
* Phase 1 — SinkSite data model on summaries.
* Phase 2 — SinkSite threaded into SsaTaintEvent and Finding.
* Phase 3 — diag + SARIF consume primary_location.
* Phase 4 — benchmark validates primary_call_site_lines across corpus.
* Phase 5 — regression test locks the event→finding contract.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* refactor: clean up formatting and improve readability in multiple files
* refactor: simplify type definition for deduplication key in findings
* test(harness): add must_not_match expectation for FP regression guards
Extends ExpectedFinding with must_not_match field that asserts a
diagnostic must NOT fire — presence is a hard failure. Non-consuming
scan so it coexists with must_match entries on the same rule_id.
Adds forbidden_violations accumulator and updates summary line.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* feat(regression): update expectations to ensure must_not_match for various taint and resource leak rules
* feat: implement auto-seeding for JS/TS handler parameters to enhance taint tracking
* feat: update switch statement handling to improve control flow analysis
* feat: implement promisify alias handling for JS/TS to enhance taint tracking
* feat: enhance taint tracking by refining expectation handling and adding mode filtering
* feat: refine SQL handling in stream processing and enhance auto-seeding for handler parameters
* feat: update taint tracking rules to enforce full mode matching and improve flow analysis
* feat: enhance Ruby subshell handling to improve taint tracking and flow analysis
* feat: update xss_response expectations to refine taint flow analysis and enhance regression guarding
* feat: refine framework detection and update expectation handling for Echo and Sinatra
* feat: implement max_count for taint tracking expectations and deduplicate findings
* feat: add strict_unexpected handling for taint-unsanitised-flow in expectation files
* feat: enhance deduplication of taint-unsanitised-flow findings by collapsing based on line and severity
* feat: add strict_unexpected handling for taint-unsanitised-flow in multiple expectation files
* feat: add structural invariant checks for SSA bodies
* feat: ensure deterministic phi emission order using BTreeSet
* feat: enhance handling of terminators to ensure authoritative flow through successor edges
* feat: enhance Goto terminator handling to ensure all successors are marked executable
* feat: refactor code for improved readability and organization
* feat: simplify predicate checks and enhance readability in SSA handling
* feat: implement per-file parse timeout and enhance file size handling
* feat: migrate analysis engine toggles from environment variables to configuration file
* feat: remove unnecessary whitespace in hostile_input_tests.rs
* feat: remove unnecessary whitespace in hostile_input_tests.rs
* feat: update dependencies and enhance documentation on language maturity
* feat: enhance security headers and improve request body limits
* feat: implement sink capability bits for deduplication and enhance evidence tagging
* feat: implement dynamic activation handling for gated sinks and enhance validation logic
* feat: enhance configuration documentation and clarify inline analysis cache behavior
* feat: implement panic recovery during analysis to continue scans past errors
* feat: add expectations configuration for taint analysis and performance metrics
* feat: enhance error handling and logging during file reading and mutex locking
* feat: add cross-file body loading tests and plumbing for CF-1 phase
* feat: implement cross-file k=1 context-sensitive inline taint analysis with new tests and fixtures
* feat: implement indexed-scan parity in cross-file inline analysis with new dropdown and copy functionality
* feat: enhance classification span handling in CFG and AST for improved source attribution
* feat: add new Express routes for handling user input and telemetry data
* feat: implement ternary expression handling in CFG with diamond structure for JS/TS
* feat: implement Phase CF-3 abstract-domain transfer channels in summaries
* feat: add support for string-prefix transfer in cross-file calls and update tests
* docs: reduce RESULTS.md doc size
* feat: implement Phase CF-4 per-return-path summary decomposition with tests
* feat: update parameter handling in pass1 and refactor SsaFuncSummary initialization
* feat: implement Phase CF-5 for cross-file SCC joint fixed-point convergence with new flags and tests
* feat: implement Phase CF-6 with parameter-granularity points-to summaries and associated tests
* refactor: update comments and documentation for clarity and consistency
* style: format code for consistency and readability
* refactor: simplify verdict handling and improve edge checking logic
* refactor: optimize path and identifier collection by avoiding unnecessary cloning
* chore: update Cargo.toml for Rust version 1.85 and add ignored files; modify CHANGELOG and README for clarity on state analysis defaults
* refactor: update documentation and improve clarity in configuration files
* refactor: update documentation and improve clarity in configuration files
* feat: add JS/TS pass-2 convergence tests and expectations configuration
* feat: add Phase 5 regression tests for inline cache origin attribution and update related logic
* feat: implement Phase 7 deduplication and alternative path linking for taint findings
* feat: implement structural DFS index for anonymous functions and update naming conventions
* feat: add Phase 8 regression tests for container-element taint in JS and Python
* feat: add engine-depth profiles and explain-engine option for CLI
* feat: update expectations and add new README fixtures for multi-file scan regression
* feat: implement Phase 11 callback-alias and factory patterns with regression tests
* feat: implement Terminator::Switch for multi-way dispatch and add regression tests
* feat: add real-CVE benchmark fixtures for CVE-2023-48022, CVE-2019-14939, and CVE-2023-26159 with corresponding patched variants
* refactor: extract cfg and ssa_transfer to submodules
* refactor: cargo fmt
* refactor: remove unnecessary blank line in cfg_tests.rs
* refactor: remove unnecessary planning file
* chore: update Rust version to 1.88 and bump dependencies in Cargo files
* feat: enhance triage UI with new layout and controls, update README for clarity
* feat: enhance triage UI with new layout and controls, update README for clarity
* chore: remove outdated section from README for version 0.5.0
* docs: improve clarity and consistency in README content
* chore: add "GPL-3.0-or-later" to license options in about.toml
* chore: update license handling in about.toml and check-licenses.mjs
* style: format code for improved readability in TriagePage component
* style: format code for improved readability in TriagePage component
* chore: enhance license handling and improve body_id scoping in seed lookup
* feat: introduce owner and parent body IDs for enhanced seed scoping
* feat: implement direction-aware engine provenance with new CLI flag for strict CI gating
* feat: add Undef SSA operation for improved control-flow handling
* style: improve code formatting for consistency and readability in multiple files
* feat: add 16-function chain SCC across multiple files for enhanced analysis
* style: simplify code formatting for improved readability in multiple files
* fix: update CapHitReason default implementation and improve README clarity
* docs: enhance README with detailed explanations of taint analysis and limitations
* docs: refine README for clarity and consistency in taint analysis section
* style: improve code formatting for better readability in NewScanModal and scans
* fix: update cargo-about command to use --offline for deterministic license generation
* fix: update cargo-about command to use --offline for deterministic license generation
* ci: add step to prime cargo registry cache for deterministic license generation
* feat: add support for non-sink collections in authorization analysis
* feat: enhance authorization checks with row-level ownership equality and binding tracking
* feat: implement self-scoped user handling and enhance ownership checks
* refactor: simplify assertions and formatting in authorization analysis tests
* fix: normalize line endings in THIRDPARTY-LICENSES.html generation and update README with AI disclosure
* docs: update AI disclosure section for clarity and conciseness
* feat: add AI Contribution Policy and update contributing guidelines for AI assistance disclosure
* feat: enhance authorization analysis with SSA-derived variable type classification
* feat: implement auth_finding_to_diag function for enhanced security diagnostics
* feat: add args_value_refs to CallSite struct for enhanced argument tracking
* feat: add args_value_refs to CallSite struct for enhanced argument tracking
* feat: add direction-aware engine provenance with LossDirection classification and new CLI flag
* feat: simplify strip_cap_from_call_args call by removing unnecessary line breaks
* feat: enhance error message handling in cli_validation_tests for better Windows compatibility
* feat: optimize release profile settings in Cargo.toml and update CodeQL configuration
* feat: enhance release build process with SBOM generation and SLSA provenance
* feat: update actions/checkout and actions/setup-node to v6, enhance CLI options, and improve auth-check summaries
* feat: introduce PathFact handling for path safety checks and rejection logic
* feat: introduce PathFact handling for path safety checks and rejection logic
* feat: update benchmark data and enhance path sanitization logic with new safety checks
* feat: document AI assistance in frontend UI development and human review process
* feat: add return path facts for enhanced path safety checks and update documentation
* chore: update release date for version 0.5.0 in CHANGELOG.md
* chore: clean up ci.yml by removing outdated comments and clarifying steps
* feat: implement cross-language path sanitizers and validators for enhanced security
* feat: enhance SSA value usage tracking by including block terminators and improve path safety checks
* feat: enhance switch statement handling by adding per-case path constraints and support for exclusive cases
* refactor: simplify conditional formatting and improve code readability in executor and lower modules
* feat: add vulnerable examples for various languages demonstrating authentication and sanitization issues
* feat: enhance actor context recognition for self-actor identifiers and add support for global non-sink receivers
* feat: enhance actor context recognition for self-actor identifiers and add support for global non-sink receivers
* feat: add transform classifiers for Java, Go, and Ruby with corresponding tests
* refactor: clarify comments on reassign-to-constant idiom and sink behavior in guards.rs
---------
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
2026-04-25 17:59:11 -04:00
|
|
|
Call {
|
|
|
|
|
callee: String,
|
2026-04-29 00:58:38 -04:00
|
|
|
/// Original textual full path when SSA decomposed a chained receiver.
|
2026-04-29 19:53:34 -04:00
|
|
|
/// `None` when the callee was not rewritten, `callee` already holds
|
2026-04-29 00:58:38 -04:00
|
|
|
/// the source-level textual form.
|
|
|
|
|
///
|
|
|
|
|
/// **Debug / display only.** Analysis code must walk the SSA receiver
|
|
|
|
|
/// chain (through `FieldProj` ops) for precise field structure, or
|
|
|
|
|
/// use [`crate::labels::bare_method_name`] when only the terminal
|
|
|
|
|
/// method name is needed from a textual callee.
|
|
|
|
|
#[doc(hidden)]
|
|
|
|
|
#[serde(default)]
|
|
|
|
|
callee_text: Option<String>,
|
Release/0.5.0 (#35)
* feat: Introduce function-scoped variable interning for state analysis with new tests and fixtures
* feat: Add Phase 26 symbolic execution enhancements with bitwise operator support, abstract interpretation refinements, and new taint analysis tests
* feat: Refine state analysis to handle factory-pattern resource returns with mixed-path tests and leak detection enhancements
* feat: Add Phase 27 debug views with symbolic execution, abstract interpretation, SSA, and call graph viewers; integrate with debug layout and styles
* feat: Add Phase 31 type-qualified symbolic resolution with receiver-based callee disambiguation and testing
* feat: Extend symbolic execution with state iteration, enhanced debug views, and debounced input handling
* feat: Add Phase 13 resource and auth pattern extensions with new tests and fixtures
* feat: Introduce CFG debug graph renderer with compact mode, toolbar, and DAG layout integration
* feat: Add Phase 28 encoding and decoding transform modeling with structural symex enhancements and new taint analysis tests
* feat: Extend abstract interpretation with type facts and constant value tracking in debug views and server logic
* feat: Add linear path handling and witness extraction to symbolic execution with Phase 28 transform mismatch detection
* feat: Refine Go auth and sanitizer handling with enhanced rules, state updates, and benchmark improvements
* feat: Enable auth-state analysis by default and update relevant tests in benchmark config
* test: Update state_tests to reflect default enablement of auth-state analysis and add auth suppression test
* docs: update CHANGELOG.md
* feat: Introduce per-index taint tracking in `HeapState` with `HeapSlot`, overflow handling, and revised SSA transfers
* feat: Introduce C/C++ language labels and refine heap state tracking in SSA transfers
* feat: Implement per-index array slot tracking in symbolic heap with overflow collapse
* feat: Add implicit definition handling for uninitialized declarations in SSA value allocation
* feat: Refactor function parameters and constants for improved clarity and maintainability
* refactor: Reorder module imports and improve formatting for consistency
* refactor: Fix formatting erorrs
* refactor: Fix clippy warnings
* refactor: Fix fmt warnings (again)
* chore: Update dependencies and improve feature configuration
* Add comprehensive tests for undertested modules (#36) (COPILOT)
* Add comprehensive tests for undertested modules
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/f3fc877e-f386-49ba-9793-fc93d3805083
* Add comprehensive tests for ext, project, walk, and errors modules
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/f3fc877e-f386-49ba-9793-fc93d3805083
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
* chore: Update dependencies and improve feature configuration
* fix: formatting errors in new tests
* chore: Update license list in about.toml
* chore: made functions input inline
* chore: updated cfg graph to take up the full page
* chore: add Prettier configuration and update code formatting
* Add frontend test suite with Vitest (111 tests) (#37)
* Add Vitest test suite for frontend - 111 tests across utils, components, hooks, and graph utilities
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/7cf0dba2-ecff-4740-ba4d-92717e74a0b7
* ci: add frontend test step to CI workflow
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/5bc0ac9f-0a32-4d03-9cb7-7a15aea53fca
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
* chore: simplify array initialization in test files for consistency
* ran typecheck
* feat: add AnalysisWorkspace component and integrate it into CfgViewerPage
* feat: update routing in AppLayout and improve empty state message in ExplorerPage
* feat: enhance scan progress tracking with additional metrics and stages
* feat: update license information and add license check script
* feat: implement cross-file symbolic execution with callee body persistence
* feat: replace dagre graphs with Graphology + ELK + Sigma for more advanced call stack and cfg rendering
* feat: ensure CFG function view is scoped to the selected function, preventing bleed into sibling functions
* feat: enhance resource tracking with proxy method summaries and improve finding extraction
* feat: add terminal function exit detection for accurate resource leak analysis
* feat: add warnings for loops and functions without bodies to improve error recovery
* feat: update lambda expression handling to ensure proper function classification and control flow
* feat: remove bounded formatting/string ops and add JSON.parse sanitizer for improved data handling
* feat: add inline return taint analysis and regression tests for improved security checks
* feat: add engine version management and migration handling for database schema updates
* feat: enhance first_call_ident to skip nested function bodies and add regression tests
* feat: enhance callee name resolution with two-segment normalization and disambiguation
* feat: add cross-file context flags and debug assertions for taint analysis
* feat: refactor taint analysis structure to unify context handling and improve clarity
* feat: enhance dead code elimination to preserve Sink, Source, and Sanitizer labels with new tests
* docs: updated CHANGELOG.md
* fmt: formatting fixes
* fix: fixed frontend formatting and lint warnings
* fix: optimized ci
* fix: optimized ci
* Add comprehensive multi-file test coverage to Nyx (#38)
* Initial checklist for multi-file test suite expansion
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/e550cb88-9767-4442-94d4-101bf5bb0e23
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
* Add 12 new multi-file test fixtures with TP/TN/near-miss coverage
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/e550cb88-9767-4442-94d4-101bf5bb0e23
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
* deleted root repo
* rebuilt to test for regressions
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
Co-authored-by: elipeter <elicpeter@gmail.com>
* feat: enhance import alias resolution and taint tracking
* feat: implement security hardening with CSRF protection and path validation
* feat: add support for import alias bindings in Python, PHP, and Rust
* feat: enhance CFG analysis modes and improve code readability
* feat: add detection for parameterized SQL queries to enhance security
* feat: add safe internal redirect handling and enhance session destroy validation
* feat: implement security improvements by addressing vulnerabilities in execAsync, session management, and file downloads
* feat: enhance taint detection by adding support for inline source member expressions in call arguments
* feat: implement pre-emission of Source nodes for inline source member expressions in call arguments
* feat: add support for Throw statement in control flow and error handling
* feat: add debug and echo endpoints with potential information leakage
* feat: implement internal redirect suppression and enhance taint detection
* feat: implement module alias tracking for dynamic dispatch in JS/TS
* feat: add authorization analysis module with Express support
* feat: add authorization analysis module with Express support
* feat: add tests for admin guard requirements and clean checks in authorization analysis
* feat: integrate Koa and Fastify frameworks into authorization analysis
* feat: add Flask and Django support to authorization analysis module
* feat: add support for Rails and Sinatra frameworks in authorization analysis
* feat: add support for Axum, ActixWeb, and Rocket frameworks in authorization analysis
* feat: add support for ActixWeb, Axum, and Rocket frameworks in authorization analysis
* feat: add support for Rails and Sinatra in authorization analysis
* chore: add .DS_Store to .gitignore
* refactor: simplify conditional checks and improve readability in multiple files
* refactor: update usage of Option methods for improved clarity and consistency
* refactor: improve code readability by simplifying conditional checks and formatting
* refactor: improve code formatting and readability by simplifying conditional checks
* refactor: simplify conditional checks and improve readability in multiple files
* refactor: simplify conditional checks in axum.rs for improved readability
* feat: add CodeQL analysis configuration for enhanced security scanning
* test: add comprehensive tests for `src/output.rs` SARIF builder (#39)
* chore: start test coverage improvement work
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/cd7ff398-134e-4728-a5e7-0353a0744423
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
* test: add comprehensive tests for src/output.rs SARIF builder
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/cd7ff398-134e-4728-a5e7-0353a0744423
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
* refactor: improve code formatting and readability in output.rs
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
Co-authored-by: elipeter <elicpeter@gmail.com>
* refactor: improve code formatting and readability in output.rs
* Potential fix for code scanning alert no. 210: Uncontrolled data used in path expression
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
* Potential fix for code scanning alert no. 211: Uncontrolled data used in path expression
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
* refactor: enhance triage file path handling with improved error management and validation
* refactor: updated func summaries for richer detail
* refactor: update SSA summary extraction to use canonical FuncKey for distinct entries
* refactor: enhance callee metadata structure to support arity, receiver, and qualifier for better overload resolution
* refactor: add support for keyword arguments in function calls and enhance receiver extraction for method-style calls
* refactor: implement new Flask routes for safe and unsafe shell command execution
* refactor: separate receiver handling in SSA operations and enhance taint propagation
* refactor: improve arity handling by using arg_uses for positional argument count and enhance witness scoring for tainted arguments
* refactor: implement auth decorator extraction and classification for multiple languages
* refactor: enhance Rust module path resolution and use map handling for cross-file disambiguation
* refactor: introduce CalleeQuery struct for structured callee resolution and enhance resolver logic
* refactor: implement same-file identity collision handling for `runTask` to ensure correct resolver behavior
* refactor: standardize default struct initialization across multiple files
* feat: add scripts for formatting checks and auto-fixes with test summaries
* refactor: simplify character splitting and enhance namespace qualifier handling
* refactor: improve documentation clarity and enhance code readability in resolver logic
* refactor: replace default struct initialization with explicit field assignments for clarity
* feat: enhance anonymous function naming by deriving context-based bindings
* refactor: streamline match expressions for improved readability and performance
* refactor: streamline match expressions for improved readability and performance
* refactor: replace loop with while let for improved clarity and performance
* feat: add SSA constant propagation support to analysis context for improved accuracy
* feat: add SSA constant propagation support to analysis context for improved accuracy
* feat: implement shell metacharacter validation and bounded-length checks in Rust analysis
* feat: add static map analysis for command injection suppression and type safety
* refactor: simplify match statements and reduce line breaks for improved readability
* feat(summary): phase 1/5 SinkSite data model for primary sink-location attribution
Introduce SinkSite (file_rel, line, col, snippet, cap) carrying the
primary sink source-location through function summaries. Swap
SsaFuncSummary.param_to_sink and FuncSummary.param_to_sink from a coarse
Cap map to a deduped SmallVec<[SinkSite; 1]> per parameter, with a
backward-compatible cap_sites() helper and serde defaults so pre-phase-1
on-disk rows continue to deserialise cleanly.
Extraction: SinkSiteLocator bundles the tree/bytes/file_rel needed by
extract_ssa_func_summary; ParsedFile::extract_ssa_artifacts wires the
locator in for the persisted pass-1 path, while pass-2 intra-file
transient summaries fall back to cap-only sites (behavior unchanged).
Merge: GlobalSummaries::insert now unions sink sites with
(file_rel, line, col, cap) dedup via shared union_param_sink_sites
helper.
Database: JSON-serialised summary columns carry the new shape
automatically; no schema change needed.
Phase 2 will consume SinkSite in build_taint_diag() to overwrite the
caller-site Finding.line with the callee's sink line when resolved via
summary. Phase 1 keeps behavior unchanged: scanning
tests/benchmark/corpus/rust/cmdi/cmdi_indirect.rs still produces the
same (wrong) line 10 finding.
Adds round-trip tests covering SinkSite solo, SsaFuncSummary with sink
sites, legacy-JSON default handling for both summary types, and merge
dedup.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
* feat(taint): phase 2/5 thread SinkSite into SsaTaintEvent and Finding
Plumb Phase 1's SinkSite through the event pipeline into Findings,
no output change yet. SsaTaintEvent gains `primary_sink_site:
Option<SinkSite>`; when the main or callback sink-emission path has
non-empty `param_to_sink_sites`, filter to sites whose
`(line != 0) && (cap ∩ sink_caps != ∅)` and emit one event per
distinct site — the multi-primary collapse keeps each downstream
Finding single-primary.
Resolution: ResolvedSummary and SinkInfo gain mirror
`param_to_sink_sites` fields, populated from `SsaFuncSummary.param_to_sink`
(SSA + callback paths) and `FuncSummary.param_to_sink` (global paths).
Label, local-summary, and interop resolution paths leave the field
empty — they only ever had cap-level info to begin with.
Finding: new `primary_location: Option<SinkLocation>` with
`file_rel/line/col`. `ssa_events_to_findings` maps
`event.primary_sink_site` → `Finding.primary_location`, filtering
cap-only sites (`line == 0`) to `None` so the (0,0) sentinel never
leaks to formatters. Dedup key extended with the primary location
so multi-site events aren't collapsed back together.
Invariants (debug_assert!):
* every SinkSite reaching emission has `line != 0 && cap ∩ sink_caps
!= ∅` — enforced by the pick_primary_sink_sites* filters;
* every populated Finding.primary_location has `line != 0` AND
non-empty `file_rel` — the cap-only → None translation upstream
guarantees this.
Deliberately independent of `uses_summary`: that flag tracks whether
the *taint chain* used a summary, whereas primary attribution
requires only that the *sink* itself was summary-resolved. A local
source reaching a cross-file sink produces `uses_summary=false`
alongside a populated primary_location — documented on
Finding.primary_location, covered by
`cross_file_sink_finding_carries_primary_location`.
build_taint_diag, SARIF/JSON/explanation formatters, and the
benchmark scorer remain untouched: finding.line still comes from
`cfg_graph[finding.sink]`, so cmdi_indirect.rs still reports line 10
and the benchmark's rs-cmdi-003 row still shows FN in the LOC column.
Tests: `cross_file_sink_finding_carries_primary_location` (proves
plumbing via a synthetic FuncSummary carrying a SinkSite at 42:5) and
`cross_file_sink_cap_only_site_leaves_primary_location_none`
(regression guard against cap-only sites surfacing). All 1566 lib
tests + integration tests pass.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* feat(output): phase 3/5 consume primary sink location in diag + SARIF
When a finding's primary_location (populated in phase 2 from a callee
summary's SinkSite) names the dangerous instruction inside a callee
body, attribute the diagnostic line to that location instead of the
caller's call site. The call site is demoted to a Call step in
flow_steps, and a synthetic Sink step at the primary location is
appended so analysts still see the full trace.
Changes:
- Add scan_root parameter to build_taint_diag so file_rel can be
resolved back to an absolute path via a shared resolve_file_rel
helper. Empty file_rel (single-file scans where namespace == "")
resolves to the file under analysis.
- Extend SinkLocation with snippet, carried from the upstream
SinkSite so the formatter needs no second file read.
- Relax the ssa_events_to_findings debug_assert to allow empty
file_rel, which is valid when scan root equals the file itself.
- SARIF: emit data-flow as codeFlows[0].threadFlows[0].locations[];
locations[0] already reflects the primary sink position via the
updated diag line/col.
Acceptance: scan on tests/benchmark/corpus/rust/cmdi/cmdi_indirect.rs
now reports line 5 (Command::new) as the primary sink, with the call
site at line 10 visible in flow_steps.
Two expect.json fixtures updated (must_match line_range widened):
- javascript/taint/context_sensitive_call: 12-14 -> 7-14 (line 8 is
the real sink inside run()).
- rust/cfg/closure_async: 10-10 -> 10-11 (line 11 is Command::new
inside the closure).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* feat(bench): phase 4/5 validate primary sink attribution across corpus
Extend the benchmark scorer and ground truth to lock in phase 3's
primary-location behavior, and add fixtures that exercise the new
capability end-to-end.
Scorer (tests/benchmark_test.rs):
- Add optional `expected_call_site_lines: Option<Vec<[usize; 2]>>` on
Case. When present, score_location_level additionally requires at
least one flow_step in the finding's evidence trace to fall within
±2 of the call-site range. When absent, the check is skipped —
fully forward-compatible with existing fixtures.
- Retain ±2 tolerance on expected_sink_lines (compared against the
now-primary Diag.line post-phase-3).
Ground truth edits:
- rs-cmdi-cross-001: expected_sink_lines [8,8] -> [9,9]. Line 8 is the
transform::wrap call site (a cross-file propagator, not a sink);
line 9 is Command::new, the real sink. The ±2 tolerance happened to
mask this stale attribution but it was semantically wrong — phase 4
is the right time to correct it. Also adds expected_call_site_lines
[8,8] so the new field is exercised on an existing cross-file case.
- rs-cmdi-003: adds expected_call_site_lines [10,10] (run_cmd call).
This fixture's sink (Command::new inside run_cmd at line 5) was the
motivating case for phases 1-3; adding the call-site assertion
guards against regression to caller-line attribution.
New fixtures:
- rust/cmdi/cmdi_indirect_multisink.rs (rs-cmdi-009): helper run_both
takes two tainted params and invokes two Command sinks on
consecutive lines. Locks in that primary line lands inside the
helper (lines 5-6), not at the caller (line 12). Notes document
that SinkSite is currently one-per-callee so both findings today
collapse onto the first sink; expected_sink_lines=[5,6] and
expected_call_site_lines=[12,12] stay valid either way.
- python/cmdi/cross_indirect_sink/{app.py,helper.py} (py-cmdi-cross-
004): sink os.system lives in helper.py (cross-file), caller in
app.py reads env source and calls run_cmd. Verifies phase 3's
cross-file primary attribution: Diag.path = helper.py, Diag.line =
5, with app.py:7 recorded in flow_steps as a Call step.
Acceptance:
- `cargo test --test benchmark_test -- --ignored --nocapture` passes.
- rs-cmdi-003 is TP/TP/TP (the target flip FN->TP at LOC). All
pre-existing TP/TP/TP fixtures remain TP/TP/TP; 2 new fixtures are
TP/TP/TP.
- Aggregate rule-level: TP=158 FP=10 FN=1 TN=97, P=0.940 R=0.994
F1=0.966 on the 266-case corpus (was TP=156 FP=10 FN=1 TN=97 on
264 pre-phase-4, delta is the +2 new cases both resolving TP).
- Full `cargo test` green (1566 lib tests + all integration tests).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* feat(taint): phase 5/5 lock Finding.primary_location contract via regression test
Add a regression test in src/taint/ssa_transfer.rs that wires up a synthetic
SsaFuncSummary with a SinkSite at other.rs:42:10 and drives the three
emission stages (pick_primary_sink_sites → emit_ssa_taint_events →
ssa_events_to_findings) against a minimal caller SSA body. Asserts the
resulting Finding.primary_location is exactly that triple.
The existing integration tests in src/taint/tests.rs cover the coarse
FuncSummary path end-to-end through analyse_file. This test locks in the
lower-level SSA-side plumbing so a future refactor that silently drops the
site between pick → emit → findings fails here rather than only at the
benchmark layer.
Also refreshes tests/benchmark/results/latest.json (timestamp only; rs-cmdi-003
remains TP/TP/TP and the aggregate P/R/F1 are unchanged from phase 4).
Closes the primary sink-location attribution feature (phases 1-5/5):
* Phase 1 — SinkSite data model on summaries.
* Phase 2 — SinkSite threaded into SsaTaintEvent and Finding.
* Phase 3 — diag + SARIF consume primary_location.
* Phase 4 — benchmark validates primary_call_site_lines across corpus.
* Phase 5 — regression test locks the event→finding contract.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* refactor: clean up formatting and improve readability in multiple files
* refactor: simplify type definition for deduplication key in findings
* test(harness): add must_not_match expectation for FP regression guards
Extends ExpectedFinding with must_not_match field that asserts a
diagnostic must NOT fire — presence is a hard failure. Non-consuming
scan so it coexists with must_match entries on the same rule_id.
Adds forbidden_violations accumulator and updates summary line.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* feat(regression): update expectations to ensure must_not_match for various taint and resource leak rules
* feat: implement auto-seeding for JS/TS handler parameters to enhance taint tracking
* feat: update switch statement handling to improve control flow analysis
* feat: implement promisify alias handling for JS/TS to enhance taint tracking
* feat: enhance taint tracking by refining expectation handling and adding mode filtering
* feat: refine SQL handling in stream processing and enhance auto-seeding for handler parameters
* feat: update taint tracking rules to enforce full mode matching and improve flow analysis
* feat: enhance Ruby subshell handling to improve taint tracking and flow analysis
* feat: update xss_response expectations to refine taint flow analysis and enhance regression guarding
* feat: refine framework detection and update expectation handling for Echo and Sinatra
* feat: implement max_count for taint tracking expectations and deduplicate findings
* feat: add strict_unexpected handling for taint-unsanitised-flow in expectation files
* feat: enhance deduplication of taint-unsanitised-flow findings by collapsing based on line and severity
* feat: add strict_unexpected handling for taint-unsanitised-flow in multiple expectation files
* feat: add structural invariant checks for SSA bodies
* feat: ensure deterministic phi emission order using BTreeSet
* feat: enhance handling of terminators to ensure authoritative flow through successor edges
* feat: enhance Goto terminator handling to ensure all successors are marked executable
* feat: refactor code for improved readability and organization
* feat: simplify predicate checks and enhance readability in SSA handling
* feat: implement per-file parse timeout and enhance file size handling
* feat: migrate analysis engine toggles from environment variables to configuration file
* feat: remove unnecessary whitespace in hostile_input_tests.rs
* feat: remove unnecessary whitespace in hostile_input_tests.rs
* feat: update dependencies and enhance documentation on language maturity
* feat: enhance security headers and improve request body limits
* feat: implement sink capability bits for deduplication and enhance evidence tagging
* feat: implement dynamic activation handling for gated sinks and enhance validation logic
* feat: enhance configuration documentation and clarify inline analysis cache behavior
* feat: implement panic recovery during analysis to continue scans past errors
* feat: add expectations configuration for taint analysis and performance metrics
* feat: enhance error handling and logging during file reading and mutex locking
* feat: add cross-file body loading tests and plumbing for CF-1 phase
* feat: implement cross-file k=1 context-sensitive inline taint analysis with new tests and fixtures
* feat: implement indexed-scan parity in cross-file inline analysis with new dropdown and copy functionality
* feat: enhance classification span handling in CFG and AST for improved source attribution
* feat: add new Express routes for handling user input and telemetry data
* feat: implement ternary expression handling in CFG with diamond structure for JS/TS
* feat: implement Phase CF-3 abstract-domain transfer channels in summaries
* feat: add support for string-prefix transfer in cross-file calls and update tests
* docs: reduce RESULTS.md doc size
* feat: implement Phase CF-4 per-return-path summary decomposition with tests
* feat: update parameter handling in pass1 and refactor SsaFuncSummary initialization
* feat: implement Phase CF-5 for cross-file SCC joint fixed-point convergence with new flags and tests
* feat: implement Phase CF-6 with parameter-granularity points-to summaries and associated tests
* refactor: update comments and documentation for clarity and consistency
* style: format code for consistency and readability
* refactor: simplify verdict handling and improve edge checking logic
* refactor: optimize path and identifier collection by avoiding unnecessary cloning
* chore: update Cargo.toml for Rust version 1.85 and add ignored files; modify CHANGELOG and README for clarity on state analysis defaults
* refactor: update documentation and improve clarity in configuration files
* refactor: update documentation and improve clarity in configuration files
* feat: add JS/TS pass-2 convergence tests and expectations configuration
* feat: add Phase 5 regression tests for inline cache origin attribution and update related logic
* feat: implement Phase 7 deduplication and alternative path linking for taint findings
* feat: implement structural DFS index for anonymous functions and update naming conventions
* feat: add Phase 8 regression tests for container-element taint in JS and Python
* feat: add engine-depth profiles and explain-engine option for CLI
* feat: update expectations and add new README fixtures for multi-file scan regression
* feat: implement Phase 11 callback-alias and factory patterns with regression tests
* feat: implement Terminator::Switch for multi-way dispatch and add regression tests
* feat: add real-CVE benchmark fixtures for CVE-2023-48022, CVE-2019-14939, and CVE-2023-26159 with corresponding patched variants
* refactor: extract cfg and ssa_transfer to submodules
* refactor: cargo fmt
* refactor: remove unnecessary blank line in cfg_tests.rs
* refactor: remove unnecessary planning file
* chore: update Rust version to 1.88 and bump dependencies in Cargo files
* feat: enhance triage UI with new layout and controls, update README for clarity
* feat: enhance triage UI with new layout and controls, update README for clarity
* chore: remove outdated section from README for version 0.5.0
* docs: improve clarity and consistency in README content
* chore: add "GPL-3.0-or-later" to license options in about.toml
* chore: update license handling in about.toml and check-licenses.mjs
* style: format code for improved readability in TriagePage component
* style: format code for improved readability in TriagePage component
* chore: enhance license handling and improve body_id scoping in seed lookup
* feat: introduce owner and parent body IDs for enhanced seed scoping
* feat: implement direction-aware engine provenance with new CLI flag for strict CI gating
* feat: add Undef SSA operation for improved control-flow handling
* style: improve code formatting for consistency and readability in multiple files
* feat: add 16-function chain SCC across multiple files for enhanced analysis
* style: simplify code formatting for improved readability in multiple files
* fix: update CapHitReason default implementation and improve README clarity
* docs: enhance README with detailed explanations of taint analysis and limitations
* docs: refine README for clarity and consistency in taint analysis section
* style: improve code formatting for better readability in NewScanModal and scans
* fix: update cargo-about command to use --offline for deterministic license generation
* fix: update cargo-about command to use --offline for deterministic license generation
* ci: add step to prime cargo registry cache for deterministic license generation
* feat: add support for non-sink collections in authorization analysis
* feat: enhance authorization checks with row-level ownership equality and binding tracking
* feat: implement self-scoped user handling and enhance ownership checks
* refactor: simplify assertions and formatting in authorization analysis tests
* fix: normalize line endings in THIRDPARTY-LICENSES.html generation and update README with AI disclosure
* docs: update AI disclosure section for clarity and conciseness
* feat: add AI Contribution Policy and update contributing guidelines for AI assistance disclosure
* feat: enhance authorization analysis with SSA-derived variable type classification
* feat: implement auth_finding_to_diag function for enhanced security diagnostics
* feat: add args_value_refs to CallSite struct for enhanced argument tracking
* feat: add args_value_refs to CallSite struct for enhanced argument tracking
* feat: add direction-aware engine provenance with LossDirection classification and new CLI flag
* feat: simplify strip_cap_from_call_args call by removing unnecessary line breaks
* feat: enhance error message handling in cli_validation_tests for better Windows compatibility
* feat: optimize release profile settings in Cargo.toml and update CodeQL configuration
* feat: enhance release build process with SBOM generation and SLSA provenance
* feat: update actions/checkout and actions/setup-node to v6, enhance CLI options, and improve auth-check summaries
* feat: introduce PathFact handling for path safety checks and rejection logic
* feat: introduce PathFact handling for path safety checks and rejection logic
* feat: update benchmark data and enhance path sanitization logic with new safety checks
* feat: document AI assistance in frontend UI development and human review process
* feat: add return path facts for enhanced path safety checks and update documentation
* chore: update release date for version 0.5.0 in CHANGELOG.md
* chore: clean up ci.yml by removing outdated comments and clarifying steps
* feat: implement cross-language path sanitizers and validators for enhanced security
* feat: enhance SSA value usage tracking by including block terminators and improve path safety checks
* feat: enhance switch statement handling by adding per-case path constraints and support for exclusive cases
* refactor: simplify conditional formatting and improve code readability in executor and lower modules
* feat: add vulnerable examples for various languages demonstrating authentication and sanitization issues
* feat: enhance actor context recognition for self-actor identifiers and add support for global non-sink receivers
* feat: enhance actor context recognition for self-actor identifiers and add support for global non-sink receivers
* feat: add transform classifiers for Java, Go, and Ruby with corresponding tests
* refactor: clarify comments on reassign-to-constant idiom and sink behavior in guards.rs
---------
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
2026-04-25 17:59:11 -04:00
|
|
|
/// Per-argument SSA value uses.
|
|
|
|
|
args: Vec<SmallVec<[SsaValue; 2]>>,
|
|
|
|
|
/// Receiver SSA value (for method calls).
|
|
|
|
|
receiver: Option<SsaValue>,
|
|
|
|
|
},
|
2026-04-29 00:58:38 -04:00
|
|
|
/// Field projection: read field `field` of object `receiver`.
|
|
|
|
|
///
|
|
|
|
|
/// Models member-access expressions (`obj.field`) as a first-class SSA
|
|
|
|
|
/// op. Lowering walks the receiver tree so chained accesses like
|
|
|
|
|
/// `c.writer.header` produce a chain of `FieldProj` ops with explicit
|
2026-04-29 19:53:34 -04:00
|
|
|
/// per-step receivers, eliminating the textual-prefix parsing that
|
2026-04-29 00:58:38 -04:00
|
|
|
/// previously misclassified deep receivers (the gin/context.go FP).
|
|
|
|
|
///
|
|
|
|
|
/// `field` is interned in the owning [`SsaBody`]'s [`FieldInterner`].
|
|
|
|
|
/// `projected_type` carries the inferred type of the projected field
|
|
|
|
|
/// when known (populated by type-fact analysis), `None` otherwise.
|
|
|
|
|
FieldProj {
|
|
|
|
|
receiver: SsaValue,
|
|
|
|
|
field: FieldId,
|
|
|
|
|
projected_type: Option<TypeKind>,
|
|
|
|
|
},
|
Release/0.5.0 (#35)
* feat: Introduce function-scoped variable interning for state analysis with new tests and fixtures
* feat: Add Phase 26 symbolic execution enhancements with bitwise operator support, abstract interpretation refinements, and new taint analysis tests
* feat: Refine state analysis to handle factory-pattern resource returns with mixed-path tests and leak detection enhancements
* feat: Add Phase 27 debug views with symbolic execution, abstract interpretation, SSA, and call graph viewers; integrate with debug layout and styles
* feat: Add Phase 31 type-qualified symbolic resolution with receiver-based callee disambiguation and testing
* feat: Extend symbolic execution with state iteration, enhanced debug views, and debounced input handling
* feat: Add Phase 13 resource and auth pattern extensions with new tests and fixtures
* feat: Introduce CFG debug graph renderer with compact mode, toolbar, and DAG layout integration
* feat: Add Phase 28 encoding and decoding transform modeling with structural symex enhancements and new taint analysis tests
* feat: Extend abstract interpretation with type facts and constant value tracking in debug views and server logic
* feat: Add linear path handling and witness extraction to symbolic execution with Phase 28 transform mismatch detection
* feat: Refine Go auth and sanitizer handling with enhanced rules, state updates, and benchmark improvements
* feat: Enable auth-state analysis by default and update relevant tests in benchmark config
* test: Update state_tests to reflect default enablement of auth-state analysis and add auth suppression test
* docs: update CHANGELOG.md
* feat: Introduce per-index taint tracking in `HeapState` with `HeapSlot`, overflow handling, and revised SSA transfers
* feat: Introduce C/C++ language labels and refine heap state tracking in SSA transfers
* feat: Implement per-index array slot tracking in symbolic heap with overflow collapse
* feat: Add implicit definition handling for uninitialized declarations in SSA value allocation
* feat: Refactor function parameters and constants for improved clarity and maintainability
* refactor: Reorder module imports and improve formatting for consistency
* refactor: Fix formatting erorrs
* refactor: Fix clippy warnings
* refactor: Fix fmt warnings (again)
* chore: Update dependencies and improve feature configuration
* Add comprehensive tests for undertested modules (#36) (COPILOT)
* Add comprehensive tests for undertested modules
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/f3fc877e-f386-49ba-9793-fc93d3805083
* Add comprehensive tests for ext, project, walk, and errors modules
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/f3fc877e-f386-49ba-9793-fc93d3805083
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
* chore: Update dependencies and improve feature configuration
* fix: formatting errors in new tests
* chore: Update license list in about.toml
* chore: made functions input inline
* chore: updated cfg graph to take up the full page
* chore: add Prettier configuration and update code formatting
* Add frontend test suite with Vitest (111 tests) (#37)
* Add Vitest test suite for frontend - 111 tests across utils, components, hooks, and graph utilities
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/7cf0dba2-ecff-4740-ba4d-92717e74a0b7
* ci: add frontend test step to CI workflow
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/5bc0ac9f-0a32-4d03-9cb7-7a15aea53fca
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
* chore: simplify array initialization in test files for consistency
* ran typecheck
* feat: add AnalysisWorkspace component and integrate it into CfgViewerPage
* feat: update routing in AppLayout and improve empty state message in ExplorerPage
* feat: enhance scan progress tracking with additional metrics and stages
* feat: update license information and add license check script
* feat: implement cross-file symbolic execution with callee body persistence
* feat: replace dagre graphs with Graphology + ELK + Sigma for more advanced call stack and cfg rendering
* feat: ensure CFG function view is scoped to the selected function, preventing bleed into sibling functions
* feat: enhance resource tracking with proxy method summaries and improve finding extraction
* feat: add terminal function exit detection for accurate resource leak analysis
* feat: add warnings for loops and functions without bodies to improve error recovery
* feat: update lambda expression handling to ensure proper function classification and control flow
* feat: remove bounded formatting/string ops and add JSON.parse sanitizer for improved data handling
* feat: add inline return taint analysis and regression tests for improved security checks
* feat: add engine version management and migration handling for database schema updates
* feat: enhance first_call_ident to skip nested function bodies and add regression tests
* feat: enhance callee name resolution with two-segment normalization and disambiguation
* feat: add cross-file context flags and debug assertions for taint analysis
* feat: refactor taint analysis structure to unify context handling and improve clarity
* feat: enhance dead code elimination to preserve Sink, Source, and Sanitizer labels with new tests
* docs: updated CHANGELOG.md
* fmt: formatting fixes
* fix: fixed frontend formatting and lint warnings
* fix: optimized ci
* fix: optimized ci
* Add comprehensive multi-file test coverage to Nyx (#38)
* Initial checklist for multi-file test suite expansion
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/e550cb88-9767-4442-94d4-101bf5bb0e23
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
* Add 12 new multi-file test fixtures with TP/TN/near-miss coverage
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/e550cb88-9767-4442-94d4-101bf5bb0e23
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
* deleted root repo
* rebuilt to test for regressions
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
Co-authored-by: elipeter <elicpeter@gmail.com>
* feat: enhance import alias resolution and taint tracking
* feat: implement security hardening with CSRF protection and path validation
* feat: add support for import alias bindings in Python, PHP, and Rust
* feat: enhance CFG analysis modes and improve code readability
* feat: add detection for parameterized SQL queries to enhance security
* feat: add safe internal redirect handling and enhance session destroy validation
* feat: implement security improvements by addressing vulnerabilities in execAsync, session management, and file downloads
* feat: enhance taint detection by adding support for inline source member expressions in call arguments
* feat: implement pre-emission of Source nodes for inline source member expressions in call arguments
* feat: add support for Throw statement in control flow and error handling
* feat: add debug and echo endpoints with potential information leakage
* feat: implement internal redirect suppression and enhance taint detection
* feat: implement module alias tracking for dynamic dispatch in JS/TS
* feat: add authorization analysis module with Express support
* feat: add authorization analysis module with Express support
* feat: add tests for admin guard requirements and clean checks in authorization analysis
* feat: integrate Koa and Fastify frameworks into authorization analysis
* feat: add Flask and Django support to authorization analysis module
* feat: add support for Rails and Sinatra frameworks in authorization analysis
* feat: add support for Axum, ActixWeb, and Rocket frameworks in authorization analysis
* feat: add support for ActixWeb, Axum, and Rocket frameworks in authorization analysis
* feat: add support for Rails and Sinatra in authorization analysis
* chore: add .DS_Store to .gitignore
* refactor: simplify conditional checks and improve readability in multiple files
* refactor: update usage of Option methods for improved clarity and consistency
* refactor: improve code readability by simplifying conditional checks and formatting
* refactor: improve code formatting and readability by simplifying conditional checks
* refactor: simplify conditional checks and improve readability in multiple files
* refactor: simplify conditional checks in axum.rs for improved readability
* feat: add CodeQL analysis configuration for enhanced security scanning
* test: add comprehensive tests for `src/output.rs` SARIF builder (#39)
* chore: start test coverage improvement work
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/cd7ff398-134e-4728-a5e7-0353a0744423
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
* test: add comprehensive tests for src/output.rs SARIF builder
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/cd7ff398-134e-4728-a5e7-0353a0744423
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
* refactor: improve code formatting and readability in output.rs
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
Co-authored-by: elipeter <elicpeter@gmail.com>
* refactor: improve code formatting and readability in output.rs
* Potential fix for code scanning alert no. 210: Uncontrolled data used in path expression
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
* Potential fix for code scanning alert no. 211: Uncontrolled data used in path expression
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
* refactor: enhance triage file path handling with improved error management and validation
* refactor: updated func summaries for richer detail
* refactor: update SSA summary extraction to use canonical FuncKey for distinct entries
* refactor: enhance callee metadata structure to support arity, receiver, and qualifier for better overload resolution
* refactor: add support for keyword arguments in function calls and enhance receiver extraction for method-style calls
* refactor: implement new Flask routes for safe and unsafe shell command execution
* refactor: separate receiver handling in SSA operations and enhance taint propagation
* refactor: improve arity handling by using arg_uses for positional argument count and enhance witness scoring for tainted arguments
* refactor: implement auth decorator extraction and classification for multiple languages
* refactor: enhance Rust module path resolution and use map handling for cross-file disambiguation
* refactor: introduce CalleeQuery struct for structured callee resolution and enhance resolver logic
* refactor: implement same-file identity collision handling for `runTask` to ensure correct resolver behavior
* refactor: standardize default struct initialization across multiple files
* feat: add scripts for formatting checks and auto-fixes with test summaries
* refactor: simplify character splitting and enhance namespace qualifier handling
* refactor: improve documentation clarity and enhance code readability in resolver logic
* refactor: replace default struct initialization with explicit field assignments for clarity
* feat: enhance anonymous function naming by deriving context-based bindings
* refactor: streamline match expressions for improved readability and performance
* refactor: streamline match expressions for improved readability and performance
* refactor: replace loop with while let for improved clarity and performance
* feat: add SSA constant propagation support to analysis context for improved accuracy
* feat: add SSA constant propagation support to analysis context for improved accuracy
* feat: implement shell metacharacter validation and bounded-length checks in Rust analysis
* feat: add static map analysis for command injection suppression and type safety
* refactor: simplify match statements and reduce line breaks for improved readability
* feat(summary): phase 1/5 SinkSite data model for primary sink-location attribution
Introduce SinkSite (file_rel, line, col, snippet, cap) carrying the
primary sink source-location through function summaries. Swap
SsaFuncSummary.param_to_sink and FuncSummary.param_to_sink from a coarse
Cap map to a deduped SmallVec<[SinkSite; 1]> per parameter, with a
backward-compatible cap_sites() helper and serde defaults so pre-phase-1
on-disk rows continue to deserialise cleanly.
Extraction: SinkSiteLocator bundles the tree/bytes/file_rel needed by
extract_ssa_func_summary; ParsedFile::extract_ssa_artifacts wires the
locator in for the persisted pass-1 path, while pass-2 intra-file
transient summaries fall back to cap-only sites (behavior unchanged).
Merge: GlobalSummaries::insert now unions sink sites with
(file_rel, line, col, cap) dedup via shared union_param_sink_sites
helper.
Database: JSON-serialised summary columns carry the new shape
automatically; no schema change needed.
Phase 2 will consume SinkSite in build_taint_diag() to overwrite the
caller-site Finding.line with the callee's sink line when resolved via
summary. Phase 1 keeps behavior unchanged: scanning
tests/benchmark/corpus/rust/cmdi/cmdi_indirect.rs still produces the
same (wrong) line 10 finding.
Adds round-trip tests covering SinkSite solo, SsaFuncSummary with sink
sites, legacy-JSON default handling for both summary types, and merge
dedup.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
* feat(taint): phase 2/5 thread SinkSite into SsaTaintEvent and Finding
Plumb Phase 1's SinkSite through the event pipeline into Findings,
no output change yet. SsaTaintEvent gains `primary_sink_site:
Option<SinkSite>`; when the main or callback sink-emission path has
non-empty `param_to_sink_sites`, filter to sites whose
`(line != 0) && (cap ∩ sink_caps != ∅)` and emit one event per
distinct site — the multi-primary collapse keeps each downstream
Finding single-primary.
Resolution: ResolvedSummary and SinkInfo gain mirror
`param_to_sink_sites` fields, populated from `SsaFuncSummary.param_to_sink`
(SSA + callback paths) and `FuncSummary.param_to_sink` (global paths).
Label, local-summary, and interop resolution paths leave the field
empty — they only ever had cap-level info to begin with.
Finding: new `primary_location: Option<SinkLocation>` with
`file_rel/line/col`. `ssa_events_to_findings` maps
`event.primary_sink_site` → `Finding.primary_location`, filtering
cap-only sites (`line == 0`) to `None` so the (0,0) sentinel never
leaks to formatters. Dedup key extended with the primary location
so multi-site events aren't collapsed back together.
Invariants (debug_assert!):
* every SinkSite reaching emission has `line != 0 && cap ∩ sink_caps
!= ∅` — enforced by the pick_primary_sink_sites* filters;
* every populated Finding.primary_location has `line != 0` AND
non-empty `file_rel` — the cap-only → None translation upstream
guarantees this.
Deliberately independent of `uses_summary`: that flag tracks whether
the *taint chain* used a summary, whereas primary attribution
requires only that the *sink* itself was summary-resolved. A local
source reaching a cross-file sink produces `uses_summary=false`
alongside a populated primary_location — documented on
Finding.primary_location, covered by
`cross_file_sink_finding_carries_primary_location`.
build_taint_diag, SARIF/JSON/explanation formatters, and the
benchmark scorer remain untouched: finding.line still comes from
`cfg_graph[finding.sink]`, so cmdi_indirect.rs still reports line 10
and the benchmark's rs-cmdi-003 row still shows FN in the LOC column.
Tests: `cross_file_sink_finding_carries_primary_location` (proves
plumbing via a synthetic FuncSummary carrying a SinkSite at 42:5) and
`cross_file_sink_cap_only_site_leaves_primary_location_none`
(regression guard against cap-only sites surfacing). All 1566 lib
tests + integration tests pass.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* feat(output): phase 3/5 consume primary sink location in diag + SARIF
When a finding's primary_location (populated in phase 2 from a callee
summary's SinkSite) names the dangerous instruction inside a callee
body, attribute the diagnostic line to that location instead of the
caller's call site. The call site is demoted to a Call step in
flow_steps, and a synthetic Sink step at the primary location is
appended so analysts still see the full trace.
Changes:
- Add scan_root parameter to build_taint_diag so file_rel can be
resolved back to an absolute path via a shared resolve_file_rel
helper. Empty file_rel (single-file scans where namespace == "")
resolves to the file under analysis.
- Extend SinkLocation with snippet, carried from the upstream
SinkSite so the formatter needs no second file read.
- Relax the ssa_events_to_findings debug_assert to allow empty
file_rel, which is valid when scan root equals the file itself.
- SARIF: emit data-flow as codeFlows[0].threadFlows[0].locations[];
locations[0] already reflects the primary sink position via the
updated diag line/col.
Acceptance: scan on tests/benchmark/corpus/rust/cmdi/cmdi_indirect.rs
now reports line 5 (Command::new) as the primary sink, with the call
site at line 10 visible in flow_steps.
Two expect.json fixtures updated (must_match line_range widened):
- javascript/taint/context_sensitive_call: 12-14 -> 7-14 (line 8 is
the real sink inside run()).
- rust/cfg/closure_async: 10-10 -> 10-11 (line 11 is Command::new
inside the closure).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* feat(bench): phase 4/5 validate primary sink attribution across corpus
Extend the benchmark scorer and ground truth to lock in phase 3's
primary-location behavior, and add fixtures that exercise the new
capability end-to-end.
Scorer (tests/benchmark_test.rs):
- Add optional `expected_call_site_lines: Option<Vec<[usize; 2]>>` on
Case. When present, score_location_level additionally requires at
least one flow_step in the finding's evidence trace to fall within
±2 of the call-site range. When absent, the check is skipped —
fully forward-compatible with existing fixtures.
- Retain ±2 tolerance on expected_sink_lines (compared against the
now-primary Diag.line post-phase-3).
Ground truth edits:
- rs-cmdi-cross-001: expected_sink_lines [8,8] -> [9,9]. Line 8 is the
transform::wrap call site (a cross-file propagator, not a sink);
line 9 is Command::new, the real sink. The ±2 tolerance happened to
mask this stale attribution but it was semantically wrong — phase 4
is the right time to correct it. Also adds expected_call_site_lines
[8,8] so the new field is exercised on an existing cross-file case.
- rs-cmdi-003: adds expected_call_site_lines [10,10] (run_cmd call).
This fixture's sink (Command::new inside run_cmd at line 5) was the
motivating case for phases 1-3; adding the call-site assertion
guards against regression to caller-line attribution.
New fixtures:
- rust/cmdi/cmdi_indirect_multisink.rs (rs-cmdi-009): helper run_both
takes two tainted params and invokes two Command sinks on
consecutive lines. Locks in that primary line lands inside the
helper (lines 5-6), not at the caller (line 12). Notes document
that SinkSite is currently one-per-callee so both findings today
collapse onto the first sink; expected_sink_lines=[5,6] and
expected_call_site_lines=[12,12] stay valid either way.
- python/cmdi/cross_indirect_sink/{app.py,helper.py} (py-cmdi-cross-
004): sink os.system lives in helper.py (cross-file), caller in
app.py reads env source and calls run_cmd. Verifies phase 3's
cross-file primary attribution: Diag.path = helper.py, Diag.line =
5, with app.py:7 recorded in flow_steps as a Call step.
Acceptance:
- `cargo test --test benchmark_test -- --ignored --nocapture` passes.
- rs-cmdi-003 is TP/TP/TP (the target flip FN->TP at LOC). All
pre-existing TP/TP/TP fixtures remain TP/TP/TP; 2 new fixtures are
TP/TP/TP.
- Aggregate rule-level: TP=158 FP=10 FN=1 TN=97, P=0.940 R=0.994
F1=0.966 on the 266-case corpus (was TP=156 FP=10 FN=1 TN=97 on
264 pre-phase-4, delta is the +2 new cases both resolving TP).
- Full `cargo test` green (1566 lib tests + all integration tests).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* feat(taint): phase 5/5 lock Finding.primary_location contract via regression test
Add a regression test in src/taint/ssa_transfer.rs that wires up a synthetic
SsaFuncSummary with a SinkSite at other.rs:42:10 and drives the three
emission stages (pick_primary_sink_sites → emit_ssa_taint_events →
ssa_events_to_findings) against a minimal caller SSA body. Asserts the
resulting Finding.primary_location is exactly that triple.
The existing integration tests in src/taint/tests.rs cover the coarse
FuncSummary path end-to-end through analyse_file. This test locks in the
lower-level SSA-side plumbing so a future refactor that silently drops the
site between pick → emit → findings fails here rather than only at the
benchmark layer.
Also refreshes tests/benchmark/results/latest.json (timestamp only; rs-cmdi-003
remains TP/TP/TP and the aggregate P/R/F1 are unchanged from phase 4).
Closes the primary sink-location attribution feature (phases 1-5/5):
* Phase 1 — SinkSite data model on summaries.
* Phase 2 — SinkSite threaded into SsaTaintEvent and Finding.
* Phase 3 — diag + SARIF consume primary_location.
* Phase 4 — benchmark validates primary_call_site_lines across corpus.
* Phase 5 — regression test locks the event→finding contract.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* refactor: clean up formatting and improve readability in multiple files
* refactor: simplify type definition for deduplication key in findings
* test(harness): add must_not_match expectation for FP regression guards
Extends ExpectedFinding with must_not_match field that asserts a
diagnostic must NOT fire — presence is a hard failure. Non-consuming
scan so it coexists with must_match entries on the same rule_id.
Adds forbidden_violations accumulator and updates summary line.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* feat(regression): update expectations to ensure must_not_match for various taint and resource leak rules
* feat: implement auto-seeding for JS/TS handler parameters to enhance taint tracking
* feat: update switch statement handling to improve control flow analysis
* feat: implement promisify alias handling for JS/TS to enhance taint tracking
* feat: enhance taint tracking by refining expectation handling and adding mode filtering
* feat: refine SQL handling in stream processing and enhance auto-seeding for handler parameters
* feat: update taint tracking rules to enforce full mode matching and improve flow analysis
* feat: enhance Ruby subshell handling to improve taint tracking and flow analysis
* feat: update xss_response expectations to refine taint flow analysis and enhance regression guarding
* feat: refine framework detection and update expectation handling for Echo and Sinatra
* feat: implement max_count for taint tracking expectations and deduplicate findings
* feat: add strict_unexpected handling for taint-unsanitised-flow in expectation files
* feat: enhance deduplication of taint-unsanitised-flow findings by collapsing based on line and severity
* feat: add strict_unexpected handling for taint-unsanitised-flow in multiple expectation files
* feat: add structural invariant checks for SSA bodies
* feat: ensure deterministic phi emission order using BTreeSet
* feat: enhance handling of terminators to ensure authoritative flow through successor edges
* feat: enhance Goto terminator handling to ensure all successors are marked executable
* feat: refactor code for improved readability and organization
* feat: simplify predicate checks and enhance readability in SSA handling
* feat: implement per-file parse timeout and enhance file size handling
* feat: migrate analysis engine toggles from environment variables to configuration file
* feat: remove unnecessary whitespace in hostile_input_tests.rs
* feat: remove unnecessary whitespace in hostile_input_tests.rs
* feat: update dependencies and enhance documentation on language maturity
* feat: enhance security headers and improve request body limits
* feat: implement sink capability bits for deduplication and enhance evidence tagging
* feat: implement dynamic activation handling for gated sinks and enhance validation logic
* feat: enhance configuration documentation and clarify inline analysis cache behavior
* feat: implement panic recovery during analysis to continue scans past errors
* feat: add expectations configuration for taint analysis and performance metrics
* feat: enhance error handling and logging during file reading and mutex locking
* feat: add cross-file body loading tests and plumbing for CF-1 phase
* feat: implement cross-file k=1 context-sensitive inline taint analysis with new tests and fixtures
* feat: implement indexed-scan parity in cross-file inline analysis with new dropdown and copy functionality
* feat: enhance classification span handling in CFG and AST for improved source attribution
* feat: add new Express routes for handling user input and telemetry data
* feat: implement ternary expression handling in CFG with diamond structure for JS/TS
* feat: implement Phase CF-3 abstract-domain transfer channels in summaries
* feat: add support for string-prefix transfer in cross-file calls and update tests
* docs: reduce RESULTS.md doc size
* feat: implement Phase CF-4 per-return-path summary decomposition with tests
* feat: update parameter handling in pass1 and refactor SsaFuncSummary initialization
* feat: implement Phase CF-5 for cross-file SCC joint fixed-point convergence with new flags and tests
* feat: implement Phase CF-6 with parameter-granularity points-to summaries and associated tests
* refactor: update comments and documentation for clarity and consistency
* style: format code for consistency and readability
* refactor: simplify verdict handling and improve edge checking logic
* refactor: optimize path and identifier collection by avoiding unnecessary cloning
* chore: update Cargo.toml for Rust version 1.85 and add ignored files; modify CHANGELOG and README for clarity on state analysis defaults
* refactor: update documentation and improve clarity in configuration files
* refactor: update documentation and improve clarity in configuration files
* feat: add JS/TS pass-2 convergence tests and expectations configuration
* feat: add Phase 5 regression tests for inline cache origin attribution and update related logic
* feat: implement Phase 7 deduplication and alternative path linking for taint findings
* feat: implement structural DFS index for anonymous functions and update naming conventions
* feat: add Phase 8 regression tests for container-element taint in JS and Python
* feat: add engine-depth profiles and explain-engine option for CLI
* feat: update expectations and add new README fixtures for multi-file scan regression
* feat: implement Phase 11 callback-alias and factory patterns with regression tests
* feat: implement Terminator::Switch for multi-way dispatch and add regression tests
* feat: add real-CVE benchmark fixtures for CVE-2023-48022, CVE-2019-14939, and CVE-2023-26159 with corresponding patched variants
* refactor: extract cfg and ssa_transfer to submodules
* refactor: cargo fmt
* refactor: remove unnecessary blank line in cfg_tests.rs
* refactor: remove unnecessary planning file
* chore: update Rust version to 1.88 and bump dependencies in Cargo files
* feat: enhance triage UI with new layout and controls, update README for clarity
* feat: enhance triage UI with new layout and controls, update README for clarity
* chore: remove outdated section from README for version 0.5.0
* docs: improve clarity and consistency in README content
* chore: add "GPL-3.0-or-later" to license options in about.toml
* chore: update license handling in about.toml and check-licenses.mjs
* style: format code for improved readability in TriagePage component
* style: format code for improved readability in TriagePage component
* chore: enhance license handling and improve body_id scoping in seed lookup
* feat: introduce owner and parent body IDs for enhanced seed scoping
* feat: implement direction-aware engine provenance with new CLI flag for strict CI gating
* feat: add Undef SSA operation for improved control-flow handling
* style: improve code formatting for consistency and readability in multiple files
* feat: add 16-function chain SCC across multiple files for enhanced analysis
* style: simplify code formatting for improved readability in multiple files
* fix: update CapHitReason default implementation and improve README clarity
* docs: enhance README with detailed explanations of taint analysis and limitations
* docs: refine README for clarity and consistency in taint analysis section
* style: improve code formatting for better readability in NewScanModal and scans
* fix: update cargo-about command to use --offline for deterministic license generation
* fix: update cargo-about command to use --offline for deterministic license generation
* ci: add step to prime cargo registry cache for deterministic license generation
* feat: add support for non-sink collections in authorization analysis
* feat: enhance authorization checks with row-level ownership equality and binding tracking
* feat: implement self-scoped user handling and enhance ownership checks
* refactor: simplify assertions and formatting in authorization analysis tests
* fix: normalize line endings in THIRDPARTY-LICENSES.html generation and update README with AI disclosure
* docs: update AI disclosure section for clarity and conciseness
* feat: add AI Contribution Policy and update contributing guidelines for AI assistance disclosure
* feat: enhance authorization analysis with SSA-derived variable type classification
* feat: implement auth_finding_to_diag function for enhanced security diagnostics
* feat: add args_value_refs to CallSite struct for enhanced argument tracking
* feat: add args_value_refs to CallSite struct for enhanced argument tracking
* feat: add direction-aware engine provenance with LossDirection classification and new CLI flag
* feat: simplify strip_cap_from_call_args call by removing unnecessary line breaks
* feat: enhance error message handling in cli_validation_tests for better Windows compatibility
* feat: optimize release profile settings in Cargo.toml and update CodeQL configuration
* feat: enhance release build process with SBOM generation and SLSA provenance
* feat: update actions/checkout and actions/setup-node to v6, enhance CLI options, and improve auth-check summaries
* feat: introduce PathFact handling for path safety checks and rejection logic
* feat: introduce PathFact handling for path safety checks and rejection logic
* feat: update benchmark data and enhance path sanitization logic with new safety checks
* feat: document AI assistance in frontend UI development and human review process
* feat: add return path facts for enhanced path safety checks and update documentation
* chore: update release date for version 0.5.0 in CHANGELOG.md
* chore: clean up ci.yml by removing outdated comments and clarifying steps
* feat: implement cross-language path sanitizers and validators for enhanced security
* feat: enhance SSA value usage tracking by including block terminators and improve path safety checks
* feat: enhance switch statement handling by adding per-case path constraints and support for exclusive cases
* refactor: simplify conditional formatting and improve code readability in executor and lower modules
* feat: add vulnerable examples for various languages demonstrating authentication and sanitization issues
* feat: enhance actor context recognition for self-actor identifiers and add support for global non-sink receivers
* feat: enhance actor context recognition for self-actor identifiers and add support for global non-sink receivers
* feat: add transform classifiers for Java, Go, and Ruby with corresponding tests
* refactor: clarify comments on reassign-to-constant idiom and sink behavior in guards.rs
---------
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
2026-04-25 17:59:11 -04:00
|
|
|
/// Taint source introduction.
|
|
|
|
|
Source,
|
|
|
|
|
/// Constant / literal value (no taint).
|
|
|
|
|
/// The optional string carries the raw source text when captured during lowering.
|
|
|
|
|
Const(Option<String>),
|
|
|
|
|
/// Function parameter (positional). Index is the 0-based positional
|
|
|
|
|
/// parameter index, *excluding* any implicit receiver (`self`/`this`).
|
|
|
|
|
/// The receiver, when present, is represented by [`SsaOp::SelfParam`].
|
|
|
|
|
Param { index: usize },
|
|
|
|
|
/// Implicit method receiver (`self` in Rust/Python, `this` in
|
|
|
|
|
/// JS/TS/Java/PHP). Emitted in block 0 of a function body whenever the
|
|
|
|
|
/// body has a receiver (either an explicit `self` formal parameter or an
|
|
|
|
|
/// implicit `this` reference). Having a dedicated IR node keeps
|
|
|
|
|
/// receiver taint tracking entirely separate from positional-parameter
|
|
|
|
|
/// taint, eliminating off-by-receiver arithmetic at call sites.
|
|
|
|
|
SelfParam,
|
|
|
|
|
/// Catch-clause exception binding.
|
|
|
|
|
CatchParam,
|
|
|
|
|
/// Non-defining node (e.g. If condition evaluation, Entry, Exit).
|
|
|
|
|
Nop,
|
|
|
|
|
/// Sentinel for "no reaching definition on this control-flow edge".
|
|
|
|
|
///
|
|
|
|
|
/// Emitted by SSA lowering as a synthesized instruction in the entry
|
|
|
|
|
/// block and referenced from phi operands whose incoming edge does
|
2026-04-29 19:53:34 -04:00
|
|
|
/// not carry a definition of the phi's variable, e.g. a try/catch
|
Release/0.5.0 (#35)
* feat: Introduce function-scoped variable interning for state analysis with new tests and fixtures
* feat: Add Phase 26 symbolic execution enhancements with bitwise operator support, abstract interpretation refinements, and new taint analysis tests
* feat: Refine state analysis to handle factory-pattern resource returns with mixed-path tests and leak detection enhancements
* feat: Add Phase 27 debug views with symbolic execution, abstract interpretation, SSA, and call graph viewers; integrate with debug layout and styles
* feat: Add Phase 31 type-qualified symbolic resolution with receiver-based callee disambiguation and testing
* feat: Extend symbolic execution with state iteration, enhanced debug views, and debounced input handling
* feat: Add Phase 13 resource and auth pattern extensions with new tests and fixtures
* feat: Introduce CFG debug graph renderer with compact mode, toolbar, and DAG layout integration
* feat: Add Phase 28 encoding and decoding transform modeling with structural symex enhancements and new taint analysis tests
* feat: Extend abstract interpretation with type facts and constant value tracking in debug views and server logic
* feat: Add linear path handling and witness extraction to symbolic execution with Phase 28 transform mismatch detection
* feat: Refine Go auth and sanitizer handling with enhanced rules, state updates, and benchmark improvements
* feat: Enable auth-state analysis by default and update relevant tests in benchmark config
* test: Update state_tests to reflect default enablement of auth-state analysis and add auth suppression test
* docs: update CHANGELOG.md
* feat: Introduce per-index taint tracking in `HeapState` with `HeapSlot`, overflow handling, and revised SSA transfers
* feat: Introduce C/C++ language labels and refine heap state tracking in SSA transfers
* feat: Implement per-index array slot tracking in symbolic heap with overflow collapse
* feat: Add implicit definition handling for uninitialized declarations in SSA value allocation
* feat: Refactor function parameters and constants for improved clarity and maintainability
* refactor: Reorder module imports and improve formatting for consistency
* refactor: Fix formatting erorrs
* refactor: Fix clippy warnings
* refactor: Fix fmt warnings (again)
* chore: Update dependencies and improve feature configuration
* Add comprehensive tests for undertested modules (#36) (COPILOT)
* Add comprehensive tests for undertested modules
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/f3fc877e-f386-49ba-9793-fc93d3805083
* Add comprehensive tests for ext, project, walk, and errors modules
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/f3fc877e-f386-49ba-9793-fc93d3805083
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
* chore: Update dependencies and improve feature configuration
* fix: formatting errors in new tests
* chore: Update license list in about.toml
* chore: made functions input inline
* chore: updated cfg graph to take up the full page
* chore: add Prettier configuration and update code formatting
* Add frontend test suite with Vitest (111 tests) (#37)
* Add Vitest test suite for frontend - 111 tests across utils, components, hooks, and graph utilities
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/7cf0dba2-ecff-4740-ba4d-92717e74a0b7
* ci: add frontend test step to CI workflow
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/5bc0ac9f-0a32-4d03-9cb7-7a15aea53fca
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
* chore: simplify array initialization in test files for consistency
* ran typecheck
* feat: add AnalysisWorkspace component and integrate it into CfgViewerPage
* feat: update routing in AppLayout and improve empty state message in ExplorerPage
* feat: enhance scan progress tracking with additional metrics and stages
* feat: update license information and add license check script
* feat: implement cross-file symbolic execution with callee body persistence
* feat: replace dagre graphs with Graphology + ELK + Sigma for more advanced call stack and cfg rendering
* feat: ensure CFG function view is scoped to the selected function, preventing bleed into sibling functions
* feat: enhance resource tracking with proxy method summaries and improve finding extraction
* feat: add terminal function exit detection for accurate resource leak analysis
* feat: add warnings for loops and functions without bodies to improve error recovery
* feat: update lambda expression handling to ensure proper function classification and control flow
* feat: remove bounded formatting/string ops and add JSON.parse sanitizer for improved data handling
* feat: add inline return taint analysis and regression tests for improved security checks
* feat: add engine version management and migration handling for database schema updates
* feat: enhance first_call_ident to skip nested function bodies and add regression tests
* feat: enhance callee name resolution with two-segment normalization and disambiguation
* feat: add cross-file context flags and debug assertions for taint analysis
* feat: refactor taint analysis structure to unify context handling and improve clarity
* feat: enhance dead code elimination to preserve Sink, Source, and Sanitizer labels with new tests
* docs: updated CHANGELOG.md
* fmt: formatting fixes
* fix: fixed frontend formatting and lint warnings
* fix: optimized ci
* fix: optimized ci
* Add comprehensive multi-file test coverage to Nyx (#38)
* Initial checklist for multi-file test suite expansion
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/e550cb88-9767-4442-94d4-101bf5bb0e23
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
* Add 12 new multi-file test fixtures with TP/TN/near-miss coverage
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/e550cb88-9767-4442-94d4-101bf5bb0e23
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
* deleted root repo
* rebuilt to test for regressions
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
Co-authored-by: elipeter <elicpeter@gmail.com>
* feat: enhance import alias resolution and taint tracking
* feat: implement security hardening with CSRF protection and path validation
* feat: add support for import alias bindings in Python, PHP, and Rust
* feat: enhance CFG analysis modes and improve code readability
* feat: add detection for parameterized SQL queries to enhance security
* feat: add safe internal redirect handling and enhance session destroy validation
* feat: implement security improvements by addressing vulnerabilities in execAsync, session management, and file downloads
* feat: enhance taint detection by adding support for inline source member expressions in call arguments
* feat: implement pre-emission of Source nodes for inline source member expressions in call arguments
* feat: add support for Throw statement in control flow and error handling
* feat: add debug and echo endpoints with potential information leakage
* feat: implement internal redirect suppression and enhance taint detection
* feat: implement module alias tracking for dynamic dispatch in JS/TS
* feat: add authorization analysis module with Express support
* feat: add authorization analysis module with Express support
* feat: add tests for admin guard requirements and clean checks in authorization analysis
* feat: integrate Koa and Fastify frameworks into authorization analysis
* feat: add Flask and Django support to authorization analysis module
* feat: add support for Rails and Sinatra frameworks in authorization analysis
* feat: add support for Axum, ActixWeb, and Rocket frameworks in authorization analysis
* feat: add support for ActixWeb, Axum, and Rocket frameworks in authorization analysis
* feat: add support for Rails and Sinatra in authorization analysis
* chore: add .DS_Store to .gitignore
* refactor: simplify conditional checks and improve readability in multiple files
* refactor: update usage of Option methods for improved clarity and consistency
* refactor: improve code readability by simplifying conditional checks and formatting
* refactor: improve code formatting and readability by simplifying conditional checks
* refactor: simplify conditional checks and improve readability in multiple files
* refactor: simplify conditional checks in axum.rs for improved readability
* feat: add CodeQL analysis configuration for enhanced security scanning
* test: add comprehensive tests for `src/output.rs` SARIF builder (#39)
* chore: start test coverage improvement work
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/cd7ff398-134e-4728-a5e7-0353a0744423
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
* test: add comprehensive tests for src/output.rs SARIF builder
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/cd7ff398-134e-4728-a5e7-0353a0744423
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
* refactor: improve code formatting and readability in output.rs
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
Co-authored-by: elipeter <elicpeter@gmail.com>
* refactor: improve code formatting and readability in output.rs
* Potential fix for code scanning alert no. 210: Uncontrolled data used in path expression
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
* Potential fix for code scanning alert no. 211: Uncontrolled data used in path expression
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
* refactor: enhance triage file path handling with improved error management and validation
* refactor: updated func summaries for richer detail
* refactor: update SSA summary extraction to use canonical FuncKey for distinct entries
* refactor: enhance callee metadata structure to support arity, receiver, and qualifier for better overload resolution
* refactor: add support for keyword arguments in function calls and enhance receiver extraction for method-style calls
* refactor: implement new Flask routes for safe and unsafe shell command execution
* refactor: separate receiver handling in SSA operations and enhance taint propagation
* refactor: improve arity handling by using arg_uses for positional argument count and enhance witness scoring for tainted arguments
* refactor: implement auth decorator extraction and classification for multiple languages
* refactor: enhance Rust module path resolution and use map handling for cross-file disambiguation
* refactor: introduce CalleeQuery struct for structured callee resolution and enhance resolver logic
* refactor: implement same-file identity collision handling for `runTask` to ensure correct resolver behavior
* refactor: standardize default struct initialization across multiple files
* feat: add scripts for formatting checks and auto-fixes with test summaries
* refactor: simplify character splitting and enhance namespace qualifier handling
* refactor: improve documentation clarity and enhance code readability in resolver logic
* refactor: replace default struct initialization with explicit field assignments for clarity
* feat: enhance anonymous function naming by deriving context-based bindings
* refactor: streamline match expressions for improved readability and performance
* refactor: streamline match expressions for improved readability and performance
* refactor: replace loop with while let for improved clarity and performance
* feat: add SSA constant propagation support to analysis context for improved accuracy
* feat: add SSA constant propagation support to analysis context for improved accuracy
* feat: implement shell metacharacter validation and bounded-length checks in Rust analysis
* feat: add static map analysis for command injection suppression and type safety
* refactor: simplify match statements and reduce line breaks for improved readability
* feat(summary): phase 1/5 SinkSite data model for primary sink-location attribution
Introduce SinkSite (file_rel, line, col, snippet, cap) carrying the
primary sink source-location through function summaries. Swap
SsaFuncSummary.param_to_sink and FuncSummary.param_to_sink from a coarse
Cap map to a deduped SmallVec<[SinkSite; 1]> per parameter, with a
backward-compatible cap_sites() helper and serde defaults so pre-phase-1
on-disk rows continue to deserialise cleanly.
Extraction: SinkSiteLocator bundles the tree/bytes/file_rel needed by
extract_ssa_func_summary; ParsedFile::extract_ssa_artifacts wires the
locator in for the persisted pass-1 path, while pass-2 intra-file
transient summaries fall back to cap-only sites (behavior unchanged).
Merge: GlobalSummaries::insert now unions sink sites with
(file_rel, line, col, cap) dedup via shared union_param_sink_sites
helper.
Database: JSON-serialised summary columns carry the new shape
automatically; no schema change needed.
Phase 2 will consume SinkSite in build_taint_diag() to overwrite the
caller-site Finding.line with the callee's sink line when resolved via
summary. Phase 1 keeps behavior unchanged: scanning
tests/benchmark/corpus/rust/cmdi/cmdi_indirect.rs still produces the
same (wrong) line 10 finding.
Adds round-trip tests covering SinkSite solo, SsaFuncSummary with sink
sites, legacy-JSON default handling for both summary types, and merge
dedup.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
* feat(taint): phase 2/5 thread SinkSite into SsaTaintEvent and Finding
Plumb Phase 1's SinkSite through the event pipeline into Findings,
no output change yet. SsaTaintEvent gains `primary_sink_site:
Option<SinkSite>`; when the main or callback sink-emission path has
non-empty `param_to_sink_sites`, filter to sites whose
`(line != 0) && (cap ∩ sink_caps != ∅)` and emit one event per
distinct site — the multi-primary collapse keeps each downstream
Finding single-primary.
Resolution: ResolvedSummary and SinkInfo gain mirror
`param_to_sink_sites` fields, populated from `SsaFuncSummary.param_to_sink`
(SSA + callback paths) and `FuncSummary.param_to_sink` (global paths).
Label, local-summary, and interop resolution paths leave the field
empty — they only ever had cap-level info to begin with.
Finding: new `primary_location: Option<SinkLocation>` with
`file_rel/line/col`. `ssa_events_to_findings` maps
`event.primary_sink_site` → `Finding.primary_location`, filtering
cap-only sites (`line == 0`) to `None` so the (0,0) sentinel never
leaks to formatters. Dedup key extended with the primary location
so multi-site events aren't collapsed back together.
Invariants (debug_assert!):
* every SinkSite reaching emission has `line != 0 && cap ∩ sink_caps
!= ∅` — enforced by the pick_primary_sink_sites* filters;
* every populated Finding.primary_location has `line != 0` AND
non-empty `file_rel` — the cap-only → None translation upstream
guarantees this.
Deliberately independent of `uses_summary`: that flag tracks whether
the *taint chain* used a summary, whereas primary attribution
requires only that the *sink* itself was summary-resolved. A local
source reaching a cross-file sink produces `uses_summary=false`
alongside a populated primary_location — documented on
Finding.primary_location, covered by
`cross_file_sink_finding_carries_primary_location`.
build_taint_diag, SARIF/JSON/explanation formatters, and the
benchmark scorer remain untouched: finding.line still comes from
`cfg_graph[finding.sink]`, so cmdi_indirect.rs still reports line 10
and the benchmark's rs-cmdi-003 row still shows FN in the LOC column.
Tests: `cross_file_sink_finding_carries_primary_location` (proves
plumbing via a synthetic FuncSummary carrying a SinkSite at 42:5) and
`cross_file_sink_cap_only_site_leaves_primary_location_none`
(regression guard against cap-only sites surfacing). All 1566 lib
tests + integration tests pass.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* feat(output): phase 3/5 consume primary sink location in diag + SARIF
When a finding's primary_location (populated in phase 2 from a callee
summary's SinkSite) names the dangerous instruction inside a callee
body, attribute the diagnostic line to that location instead of the
caller's call site. The call site is demoted to a Call step in
flow_steps, and a synthetic Sink step at the primary location is
appended so analysts still see the full trace.
Changes:
- Add scan_root parameter to build_taint_diag so file_rel can be
resolved back to an absolute path via a shared resolve_file_rel
helper. Empty file_rel (single-file scans where namespace == "")
resolves to the file under analysis.
- Extend SinkLocation with snippet, carried from the upstream
SinkSite so the formatter needs no second file read.
- Relax the ssa_events_to_findings debug_assert to allow empty
file_rel, which is valid when scan root equals the file itself.
- SARIF: emit data-flow as codeFlows[0].threadFlows[0].locations[];
locations[0] already reflects the primary sink position via the
updated diag line/col.
Acceptance: scan on tests/benchmark/corpus/rust/cmdi/cmdi_indirect.rs
now reports line 5 (Command::new) as the primary sink, with the call
site at line 10 visible in flow_steps.
Two expect.json fixtures updated (must_match line_range widened):
- javascript/taint/context_sensitive_call: 12-14 -> 7-14 (line 8 is
the real sink inside run()).
- rust/cfg/closure_async: 10-10 -> 10-11 (line 11 is Command::new
inside the closure).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* feat(bench): phase 4/5 validate primary sink attribution across corpus
Extend the benchmark scorer and ground truth to lock in phase 3's
primary-location behavior, and add fixtures that exercise the new
capability end-to-end.
Scorer (tests/benchmark_test.rs):
- Add optional `expected_call_site_lines: Option<Vec<[usize; 2]>>` on
Case. When present, score_location_level additionally requires at
least one flow_step in the finding's evidence trace to fall within
±2 of the call-site range. When absent, the check is skipped —
fully forward-compatible with existing fixtures.
- Retain ±2 tolerance on expected_sink_lines (compared against the
now-primary Diag.line post-phase-3).
Ground truth edits:
- rs-cmdi-cross-001: expected_sink_lines [8,8] -> [9,9]. Line 8 is the
transform::wrap call site (a cross-file propagator, not a sink);
line 9 is Command::new, the real sink. The ±2 tolerance happened to
mask this stale attribution but it was semantically wrong — phase 4
is the right time to correct it. Also adds expected_call_site_lines
[8,8] so the new field is exercised on an existing cross-file case.
- rs-cmdi-003: adds expected_call_site_lines [10,10] (run_cmd call).
This fixture's sink (Command::new inside run_cmd at line 5) was the
motivating case for phases 1-3; adding the call-site assertion
guards against regression to caller-line attribution.
New fixtures:
- rust/cmdi/cmdi_indirect_multisink.rs (rs-cmdi-009): helper run_both
takes two tainted params and invokes two Command sinks on
consecutive lines. Locks in that primary line lands inside the
helper (lines 5-6), not at the caller (line 12). Notes document
that SinkSite is currently one-per-callee so both findings today
collapse onto the first sink; expected_sink_lines=[5,6] and
expected_call_site_lines=[12,12] stay valid either way.
- python/cmdi/cross_indirect_sink/{app.py,helper.py} (py-cmdi-cross-
004): sink os.system lives in helper.py (cross-file), caller in
app.py reads env source and calls run_cmd. Verifies phase 3's
cross-file primary attribution: Diag.path = helper.py, Diag.line =
5, with app.py:7 recorded in flow_steps as a Call step.
Acceptance:
- `cargo test --test benchmark_test -- --ignored --nocapture` passes.
- rs-cmdi-003 is TP/TP/TP (the target flip FN->TP at LOC). All
pre-existing TP/TP/TP fixtures remain TP/TP/TP; 2 new fixtures are
TP/TP/TP.
- Aggregate rule-level: TP=158 FP=10 FN=1 TN=97, P=0.940 R=0.994
F1=0.966 on the 266-case corpus (was TP=156 FP=10 FN=1 TN=97 on
264 pre-phase-4, delta is the +2 new cases both resolving TP).
- Full `cargo test` green (1566 lib tests + all integration tests).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* feat(taint): phase 5/5 lock Finding.primary_location contract via regression test
Add a regression test in src/taint/ssa_transfer.rs that wires up a synthetic
SsaFuncSummary with a SinkSite at other.rs:42:10 and drives the three
emission stages (pick_primary_sink_sites → emit_ssa_taint_events →
ssa_events_to_findings) against a minimal caller SSA body. Asserts the
resulting Finding.primary_location is exactly that triple.
The existing integration tests in src/taint/tests.rs cover the coarse
FuncSummary path end-to-end through analyse_file. This test locks in the
lower-level SSA-side plumbing so a future refactor that silently drops the
site between pick → emit → findings fails here rather than only at the
benchmark layer.
Also refreshes tests/benchmark/results/latest.json (timestamp only; rs-cmdi-003
remains TP/TP/TP and the aggregate P/R/F1 are unchanged from phase 4).
Closes the primary sink-location attribution feature (phases 1-5/5):
* Phase 1 — SinkSite data model on summaries.
* Phase 2 — SinkSite threaded into SsaTaintEvent and Finding.
* Phase 3 — diag + SARIF consume primary_location.
* Phase 4 — benchmark validates primary_call_site_lines across corpus.
* Phase 5 — regression test locks the event→finding contract.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* refactor: clean up formatting and improve readability in multiple files
* refactor: simplify type definition for deduplication key in findings
* test(harness): add must_not_match expectation for FP regression guards
Extends ExpectedFinding with must_not_match field that asserts a
diagnostic must NOT fire — presence is a hard failure. Non-consuming
scan so it coexists with must_match entries on the same rule_id.
Adds forbidden_violations accumulator and updates summary line.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* feat(regression): update expectations to ensure must_not_match for various taint and resource leak rules
* feat: implement auto-seeding for JS/TS handler parameters to enhance taint tracking
* feat: update switch statement handling to improve control flow analysis
* feat: implement promisify alias handling for JS/TS to enhance taint tracking
* feat: enhance taint tracking by refining expectation handling and adding mode filtering
* feat: refine SQL handling in stream processing and enhance auto-seeding for handler parameters
* feat: update taint tracking rules to enforce full mode matching and improve flow analysis
* feat: enhance Ruby subshell handling to improve taint tracking and flow analysis
* feat: update xss_response expectations to refine taint flow analysis and enhance regression guarding
* feat: refine framework detection and update expectation handling for Echo and Sinatra
* feat: implement max_count for taint tracking expectations and deduplicate findings
* feat: add strict_unexpected handling for taint-unsanitised-flow in expectation files
* feat: enhance deduplication of taint-unsanitised-flow findings by collapsing based on line and severity
* feat: add strict_unexpected handling for taint-unsanitised-flow in multiple expectation files
* feat: add structural invariant checks for SSA bodies
* feat: ensure deterministic phi emission order using BTreeSet
* feat: enhance handling of terminators to ensure authoritative flow through successor edges
* feat: enhance Goto terminator handling to ensure all successors are marked executable
* feat: refactor code for improved readability and organization
* feat: simplify predicate checks and enhance readability in SSA handling
* feat: implement per-file parse timeout and enhance file size handling
* feat: migrate analysis engine toggles from environment variables to configuration file
* feat: remove unnecessary whitespace in hostile_input_tests.rs
* feat: remove unnecessary whitespace in hostile_input_tests.rs
* feat: update dependencies and enhance documentation on language maturity
* feat: enhance security headers and improve request body limits
* feat: implement sink capability bits for deduplication and enhance evidence tagging
* feat: implement dynamic activation handling for gated sinks and enhance validation logic
* feat: enhance configuration documentation and clarify inline analysis cache behavior
* feat: implement panic recovery during analysis to continue scans past errors
* feat: add expectations configuration for taint analysis and performance metrics
* feat: enhance error handling and logging during file reading and mutex locking
* feat: add cross-file body loading tests and plumbing for CF-1 phase
* feat: implement cross-file k=1 context-sensitive inline taint analysis with new tests and fixtures
* feat: implement indexed-scan parity in cross-file inline analysis with new dropdown and copy functionality
* feat: enhance classification span handling in CFG and AST for improved source attribution
* feat: add new Express routes for handling user input and telemetry data
* feat: implement ternary expression handling in CFG with diamond structure for JS/TS
* feat: implement Phase CF-3 abstract-domain transfer channels in summaries
* feat: add support for string-prefix transfer in cross-file calls and update tests
* docs: reduce RESULTS.md doc size
* feat: implement Phase CF-4 per-return-path summary decomposition with tests
* feat: update parameter handling in pass1 and refactor SsaFuncSummary initialization
* feat: implement Phase CF-5 for cross-file SCC joint fixed-point convergence with new flags and tests
* feat: implement Phase CF-6 with parameter-granularity points-to summaries and associated tests
* refactor: update comments and documentation for clarity and consistency
* style: format code for consistency and readability
* refactor: simplify verdict handling and improve edge checking logic
* refactor: optimize path and identifier collection by avoiding unnecessary cloning
* chore: update Cargo.toml for Rust version 1.85 and add ignored files; modify CHANGELOG and README for clarity on state analysis defaults
* refactor: update documentation and improve clarity in configuration files
* refactor: update documentation and improve clarity in configuration files
* feat: add JS/TS pass-2 convergence tests and expectations configuration
* feat: add Phase 5 regression tests for inline cache origin attribution and update related logic
* feat: implement Phase 7 deduplication and alternative path linking for taint findings
* feat: implement structural DFS index for anonymous functions and update naming conventions
* feat: add Phase 8 regression tests for container-element taint in JS and Python
* feat: add engine-depth profiles and explain-engine option for CLI
* feat: update expectations and add new README fixtures for multi-file scan regression
* feat: implement Phase 11 callback-alias and factory patterns with regression tests
* feat: implement Terminator::Switch for multi-way dispatch and add regression tests
* feat: add real-CVE benchmark fixtures for CVE-2023-48022, CVE-2019-14939, and CVE-2023-26159 with corresponding patched variants
* refactor: extract cfg and ssa_transfer to submodules
* refactor: cargo fmt
* refactor: remove unnecessary blank line in cfg_tests.rs
* refactor: remove unnecessary planning file
* chore: update Rust version to 1.88 and bump dependencies in Cargo files
* feat: enhance triage UI with new layout and controls, update README for clarity
* feat: enhance triage UI with new layout and controls, update README for clarity
* chore: remove outdated section from README for version 0.5.0
* docs: improve clarity and consistency in README content
* chore: add "GPL-3.0-or-later" to license options in about.toml
* chore: update license handling in about.toml and check-licenses.mjs
* style: format code for improved readability in TriagePage component
* style: format code for improved readability in TriagePage component
* chore: enhance license handling and improve body_id scoping in seed lookup
* feat: introduce owner and parent body IDs for enhanced seed scoping
* feat: implement direction-aware engine provenance with new CLI flag for strict CI gating
* feat: add Undef SSA operation for improved control-flow handling
* style: improve code formatting for consistency and readability in multiple files
* feat: add 16-function chain SCC across multiple files for enhanced analysis
* style: simplify code formatting for improved readability in multiple files
* fix: update CapHitReason default implementation and improve README clarity
* docs: enhance README with detailed explanations of taint analysis and limitations
* docs: refine README for clarity and consistency in taint analysis section
* style: improve code formatting for better readability in NewScanModal and scans
* fix: update cargo-about command to use --offline for deterministic license generation
* fix: update cargo-about command to use --offline for deterministic license generation
* ci: add step to prime cargo registry cache for deterministic license generation
* feat: add support for non-sink collections in authorization analysis
* feat: enhance authorization checks with row-level ownership equality and binding tracking
* feat: implement self-scoped user handling and enhance ownership checks
* refactor: simplify assertions and formatting in authorization analysis tests
* fix: normalize line endings in THIRDPARTY-LICENSES.html generation and update README with AI disclosure
* docs: update AI disclosure section for clarity and conciseness
* feat: add AI Contribution Policy and update contributing guidelines for AI assistance disclosure
* feat: enhance authorization analysis with SSA-derived variable type classification
* feat: implement auth_finding_to_diag function for enhanced security diagnostics
* feat: add args_value_refs to CallSite struct for enhanced argument tracking
* feat: add args_value_refs to CallSite struct for enhanced argument tracking
* feat: add direction-aware engine provenance with LossDirection classification and new CLI flag
* feat: simplify strip_cap_from_call_args call by removing unnecessary line breaks
* feat: enhance error message handling in cli_validation_tests for better Windows compatibility
* feat: optimize release profile settings in Cargo.toml and update CodeQL configuration
* feat: enhance release build process with SBOM generation and SLSA provenance
* feat: update actions/checkout and actions/setup-node to v6, enhance CLI options, and improve auth-check summaries
* feat: introduce PathFact handling for path safety checks and rejection logic
* feat: introduce PathFact handling for path safety checks and rejection logic
* feat: update benchmark data and enhance path sanitization logic with new safety checks
* feat: document AI assistance in frontend UI development and human review process
* feat: add return path facts for enhanced path safety checks and update documentation
* chore: update release date for version 0.5.0 in CHANGELOG.md
* chore: clean up ci.yml by removing outdated comments and clarifying steps
* feat: implement cross-language path sanitizers and validators for enhanced security
* feat: enhance SSA value usage tracking by including block terminators and improve path safety checks
* feat: enhance switch statement handling by adding per-case path constraints and support for exclusive cases
* refactor: simplify conditional formatting and improve code readability in executor and lower modules
* feat: add vulnerable examples for various languages demonstrating authentication and sanitization issues
* feat: enhance actor context recognition for self-actor identifiers and add support for global non-sink receivers
* feat: enhance actor context recognition for self-actor identifiers and add support for global non-sink receivers
* feat: add transform classifiers for Java, Go, and Ruby with corresponding tests
* refactor: clarify comments on reassign-to-constant idiom and sink behavior in guards.rs
---------
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
2026-04-25 17:59:11 -04:00
|
|
|
/// rejoin where a variable is only defined on the normal path, or
|
|
|
|
|
/// an early-return branch on a later-defined variable.
|
|
|
|
|
///
|
|
|
|
|
/// Having an explicit value lets phis satisfy the invariant that
|
|
|
|
|
/// `phi.operands.len() == block.preds.len()` (one operand per
|
|
|
|
|
/// predecessor). Downstream analyses treat Undef as a
|
|
|
|
|
/// no-taint / unknown / bottom-of-the-lattice contribution: a phi
|
|
|
|
|
/// operand of Undef carries no caps, no concrete value, and no
|
|
|
|
|
/// abstract fact.
|
|
|
|
|
Undef,
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/// A single SSA instruction.
|
|
|
|
|
#[derive(Clone, Debug, Serialize, Deserialize)]
|
|
|
|
|
pub struct SsaInst {
|
|
|
|
|
/// The SSA value defined by this instruction.
|
|
|
|
|
pub value: SsaValue,
|
|
|
|
|
/// The operation.
|
|
|
|
|
pub op: SsaOp,
|
|
|
|
|
/// The original CFG node this instruction was derived from.
|
|
|
|
|
pub cfg_node: NodeIndex,
|
|
|
|
|
/// Original variable name (for debugging and label lookups).
|
|
|
|
|
pub var_name: Option<String>,
|
|
|
|
|
/// Source byte span from the original file.
|
|
|
|
|
pub span: (usize, usize),
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/// Basic block terminator.
|
|
|
|
|
#[derive(Clone, Debug, Serialize, Deserialize)]
|
|
|
|
|
pub enum Terminator {
|
|
|
|
|
Goto(BlockId),
|
|
|
|
|
Branch {
|
|
|
|
|
cond: NodeIndex,
|
|
|
|
|
true_blk: BlockId,
|
|
|
|
|
false_blk: BlockId,
|
|
|
|
|
/// Structured condition lowered from CFG metadata during SSA construction.
|
|
|
|
|
/// `None` when the condition could not be lowered (falls back to text-based
|
|
|
|
|
/// lowering in taint transfer).
|
|
|
|
|
condition: Option<Box<ConditionExpr>>,
|
|
|
|
|
},
|
|
|
|
|
/// Multi-way switch dispatch.
|
|
|
|
|
///
|
|
|
|
|
/// `targets` lists the per-case successor blocks (order matches the
|
|
|
|
|
/// source-order of cases in the switch); `default` is the fallback
|
|
|
|
|
/// branch taken when no case matches. Block `succs` remain the
|
2026-04-29 19:53:34 -04:00
|
|
|
/// authoritative flow set, the terminator is a structured summary.
|
Release/0.5.0 (#35)
* feat: Introduce function-scoped variable interning for state analysis with new tests and fixtures
* feat: Add Phase 26 symbolic execution enhancements with bitwise operator support, abstract interpretation refinements, and new taint analysis tests
* feat: Refine state analysis to handle factory-pattern resource returns with mixed-path tests and leak detection enhancements
* feat: Add Phase 27 debug views with symbolic execution, abstract interpretation, SSA, and call graph viewers; integrate with debug layout and styles
* feat: Add Phase 31 type-qualified symbolic resolution with receiver-based callee disambiguation and testing
* feat: Extend symbolic execution with state iteration, enhanced debug views, and debounced input handling
* feat: Add Phase 13 resource and auth pattern extensions with new tests and fixtures
* feat: Introduce CFG debug graph renderer with compact mode, toolbar, and DAG layout integration
* feat: Add Phase 28 encoding and decoding transform modeling with structural symex enhancements and new taint analysis tests
* feat: Extend abstract interpretation with type facts and constant value tracking in debug views and server logic
* feat: Add linear path handling and witness extraction to symbolic execution with Phase 28 transform mismatch detection
* feat: Refine Go auth and sanitizer handling with enhanced rules, state updates, and benchmark improvements
* feat: Enable auth-state analysis by default and update relevant tests in benchmark config
* test: Update state_tests to reflect default enablement of auth-state analysis and add auth suppression test
* docs: update CHANGELOG.md
* feat: Introduce per-index taint tracking in `HeapState` with `HeapSlot`, overflow handling, and revised SSA transfers
* feat: Introduce C/C++ language labels and refine heap state tracking in SSA transfers
* feat: Implement per-index array slot tracking in symbolic heap with overflow collapse
* feat: Add implicit definition handling for uninitialized declarations in SSA value allocation
* feat: Refactor function parameters and constants for improved clarity and maintainability
* refactor: Reorder module imports and improve formatting for consistency
* refactor: Fix formatting erorrs
* refactor: Fix clippy warnings
* refactor: Fix fmt warnings (again)
* chore: Update dependencies and improve feature configuration
* Add comprehensive tests for undertested modules (#36) (COPILOT)
* Add comprehensive tests for undertested modules
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/f3fc877e-f386-49ba-9793-fc93d3805083
* Add comprehensive tests for ext, project, walk, and errors modules
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/f3fc877e-f386-49ba-9793-fc93d3805083
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
* chore: Update dependencies and improve feature configuration
* fix: formatting errors in new tests
* chore: Update license list in about.toml
* chore: made functions input inline
* chore: updated cfg graph to take up the full page
* chore: add Prettier configuration and update code formatting
* Add frontend test suite with Vitest (111 tests) (#37)
* Add Vitest test suite for frontend - 111 tests across utils, components, hooks, and graph utilities
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/7cf0dba2-ecff-4740-ba4d-92717e74a0b7
* ci: add frontend test step to CI workflow
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/5bc0ac9f-0a32-4d03-9cb7-7a15aea53fca
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
* chore: simplify array initialization in test files for consistency
* ran typecheck
* feat: add AnalysisWorkspace component and integrate it into CfgViewerPage
* feat: update routing in AppLayout and improve empty state message in ExplorerPage
* feat: enhance scan progress tracking with additional metrics and stages
* feat: update license information and add license check script
* feat: implement cross-file symbolic execution with callee body persistence
* feat: replace dagre graphs with Graphology + ELK + Sigma for more advanced call stack and cfg rendering
* feat: ensure CFG function view is scoped to the selected function, preventing bleed into sibling functions
* feat: enhance resource tracking with proxy method summaries and improve finding extraction
* feat: add terminal function exit detection for accurate resource leak analysis
* feat: add warnings for loops and functions without bodies to improve error recovery
* feat: update lambda expression handling to ensure proper function classification and control flow
* feat: remove bounded formatting/string ops and add JSON.parse sanitizer for improved data handling
* feat: add inline return taint analysis and regression tests for improved security checks
* feat: add engine version management and migration handling for database schema updates
* feat: enhance first_call_ident to skip nested function bodies and add regression tests
* feat: enhance callee name resolution with two-segment normalization and disambiguation
* feat: add cross-file context flags and debug assertions for taint analysis
* feat: refactor taint analysis structure to unify context handling and improve clarity
* feat: enhance dead code elimination to preserve Sink, Source, and Sanitizer labels with new tests
* docs: updated CHANGELOG.md
* fmt: formatting fixes
* fix: fixed frontend formatting and lint warnings
* fix: optimized ci
* fix: optimized ci
* Add comprehensive multi-file test coverage to Nyx (#38)
* Initial checklist for multi-file test suite expansion
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/e550cb88-9767-4442-94d4-101bf5bb0e23
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
* Add 12 new multi-file test fixtures with TP/TN/near-miss coverage
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/e550cb88-9767-4442-94d4-101bf5bb0e23
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
* deleted root repo
* rebuilt to test for regressions
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
Co-authored-by: elipeter <elicpeter@gmail.com>
* feat: enhance import alias resolution and taint tracking
* feat: implement security hardening with CSRF protection and path validation
* feat: add support for import alias bindings in Python, PHP, and Rust
* feat: enhance CFG analysis modes and improve code readability
* feat: add detection for parameterized SQL queries to enhance security
* feat: add safe internal redirect handling and enhance session destroy validation
* feat: implement security improvements by addressing vulnerabilities in execAsync, session management, and file downloads
* feat: enhance taint detection by adding support for inline source member expressions in call arguments
* feat: implement pre-emission of Source nodes for inline source member expressions in call arguments
* feat: add support for Throw statement in control flow and error handling
* feat: add debug and echo endpoints with potential information leakage
* feat: implement internal redirect suppression and enhance taint detection
* feat: implement module alias tracking for dynamic dispatch in JS/TS
* feat: add authorization analysis module with Express support
* feat: add authorization analysis module with Express support
* feat: add tests for admin guard requirements and clean checks in authorization analysis
* feat: integrate Koa and Fastify frameworks into authorization analysis
* feat: add Flask and Django support to authorization analysis module
* feat: add support for Rails and Sinatra frameworks in authorization analysis
* feat: add support for Axum, ActixWeb, and Rocket frameworks in authorization analysis
* feat: add support for ActixWeb, Axum, and Rocket frameworks in authorization analysis
* feat: add support for Rails and Sinatra in authorization analysis
* chore: add .DS_Store to .gitignore
* refactor: simplify conditional checks and improve readability in multiple files
* refactor: update usage of Option methods for improved clarity and consistency
* refactor: improve code readability by simplifying conditional checks and formatting
* refactor: improve code formatting and readability by simplifying conditional checks
* refactor: simplify conditional checks and improve readability in multiple files
* refactor: simplify conditional checks in axum.rs for improved readability
* feat: add CodeQL analysis configuration for enhanced security scanning
* test: add comprehensive tests for `src/output.rs` SARIF builder (#39)
* chore: start test coverage improvement work
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/cd7ff398-134e-4728-a5e7-0353a0744423
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
* test: add comprehensive tests for src/output.rs SARIF builder
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/cd7ff398-134e-4728-a5e7-0353a0744423
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
* refactor: improve code formatting and readability in output.rs
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
Co-authored-by: elipeter <elicpeter@gmail.com>
* refactor: improve code formatting and readability in output.rs
* Potential fix for code scanning alert no. 210: Uncontrolled data used in path expression
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
* Potential fix for code scanning alert no. 211: Uncontrolled data used in path expression
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
* refactor: enhance triage file path handling with improved error management and validation
* refactor: updated func summaries for richer detail
* refactor: update SSA summary extraction to use canonical FuncKey for distinct entries
* refactor: enhance callee metadata structure to support arity, receiver, and qualifier for better overload resolution
* refactor: add support for keyword arguments in function calls and enhance receiver extraction for method-style calls
* refactor: implement new Flask routes for safe and unsafe shell command execution
* refactor: separate receiver handling in SSA operations and enhance taint propagation
* refactor: improve arity handling by using arg_uses for positional argument count and enhance witness scoring for tainted arguments
* refactor: implement auth decorator extraction and classification for multiple languages
* refactor: enhance Rust module path resolution and use map handling for cross-file disambiguation
* refactor: introduce CalleeQuery struct for structured callee resolution and enhance resolver logic
* refactor: implement same-file identity collision handling for `runTask` to ensure correct resolver behavior
* refactor: standardize default struct initialization across multiple files
* feat: add scripts for formatting checks and auto-fixes with test summaries
* refactor: simplify character splitting and enhance namespace qualifier handling
* refactor: improve documentation clarity and enhance code readability in resolver logic
* refactor: replace default struct initialization with explicit field assignments for clarity
* feat: enhance anonymous function naming by deriving context-based bindings
* refactor: streamline match expressions for improved readability and performance
* refactor: streamline match expressions for improved readability and performance
* refactor: replace loop with while let for improved clarity and performance
* feat: add SSA constant propagation support to analysis context for improved accuracy
* feat: add SSA constant propagation support to analysis context for improved accuracy
* feat: implement shell metacharacter validation and bounded-length checks in Rust analysis
* feat: add static map analysis for command injection suppression and type safety
* refactor: simplify match statements and reduce line breaks for improved readability
* feat(summary): phase 1/5 SinkSite data model for primary sink-location attribution
Introduce SinkSite (file_rel, line, col, snippet, cap) carrying the
primary sink source-location through function summaries. Swap
SsaFuncSummary.param_to_sink and FuncSummary.param_to_sink from a coarse
Cap map to a deduped SmallVec<[SinkSite; 1]> per parameter, with a
backward-compatible cap_sites() helper and serde defaults so pre-phase-1
on-disk rows continue to deserialise cleanly.
Extraction: SinkSiteLocator bundles the tree/bytes/file_rel needed by
extract_ssa_func_summary; ParsedFile::extract_ssa_artifacts wires the
locator in for the persisted pass-1 path, while pass-2 intra-file
transient summaries fall back to cap-only sites (behavior unchanged).
Merge: GlobalSummaries::insert now unions sink sites with
(file_rel, line, col, cap) dedup via shared union_param_sink_sites
helper.
Database: JSON-serialised summary columns carry the new shape
automatically; no schema change needed.
Phase 2 will consume SinkSite in build_taint_diag() to overwrite the
caller-site Finding.line with the callee's sink line when resolved via
summary. Phase 1 keeps behavior unchanged: scanning
tests/benchmark/corpus/rust/cmdi/cmdi_indirect.rs still produces the
same (wrong) line 10 finding.
Adds round-trip tests covering SinkSite solo, SsaFuncSummary with sink
sites, legacy-JSON default handling for both summary types, and merge
dedup.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
* feat(taint): phase 2/5 thread SinkSite into SsaTaintEvent and Finding
Plumb Phase 1's SinkSite through the event pipeline into Findings,
no output change yet. SsaTaintEvent gains `primary_sink_site:
Option<SinkSite>`; when the main or callback sink-emission path has
non-empty `param_to_sink_sites`, filter to sites whose
`(line != 0) && (cap ∩ sink_caps != ∅)` and emit one event per
distinct site — the multi-primary collapse keeps each downstream
Finding single-primary.
Resolution: ResolvedSummary and SinkInfo gain mirror
`param_to_sink_sites` fields, populated from `SsaFuncSummary.param_to_sink`
(SSA + callback paths) and `FuncSummary.param_to_sink` (global paths).
Label, local-summary, and interop resolution paths leave the field
empty — they only ever had cap-level info to begin with.
Finding: new `primary_location: Option<SinkLocation>` with
`file_rel/line/col`. `ssa_events_to_findings` maps
`event.primary_sink_site` → `Finding.primary_location`, filtering
cap-only sites (`line == 0`) to `None` so the (0,0) sentinel never
leaks to formatters. Dedup key extended with the primary location
so multi-site events aren't collapsed back together.
Invariants (debug_assert!):
* every SinkSite reaching emission has `line != 0 && cap ∩ sink_caps
!= ∅` — enforced by the pick_primary_sink_sites* filters;
* every populated Finding.primary_location has `line != 0` AND
non-empty `file_rel` — the cap-only → None translation upstream
guarantees this.
Deliberately independent of `uses_summary`: that flag tracks whether
the *taint chain* used a summary, whereas primary attribution
requires only that the *sink* itself was summary-resolved. A local
source reaching a cross-file sink produces `uses_summary=false`
alongside a populated primary_location — documented on
Finding.primary_location, covered by
`cross_file_sink_finding_carries_primary_location`.
build_taint_diag, SARIF/JSON/explanation formatters, and the
benchmark scorer remain untouched: finding.line still comes from
`cfg_graph[finding.sink]`, so cmdi_indirect.rs still reports line 10
and the benchmark's rs-cmdi-003 row still shows FN in the LOC column.
Tests: `cross_file_sink_finding_carries_primary_location` (proves
plumbing via a synthetic FuncSummary carrying a SinkSite at 42:5) and
`cross_file_sink_cap_only_site_leaves_primary_location_none`
(regression guard against cap-only sites surfacing). All 1566 lib
tests + integration tests pass.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* feat(output): phase 3/5 consume primary sink location in diag + SARIF
When a finding's primary_location (populated in phase 2 from a callee
summary's SinkSite) names the dangerous instruction inside a callee
body, attribute the diagnostic line to that location instead of the
caller's call site. The call site is demoted to a Call step in
flow_steps, and a synthetic Sink step at the primary location is
appended so analysts still see the full trace.
Changes:
- Add scan_root parameter to build_taint_diag so file_rel can be
resolved back to an absolute path via a shared resolve_file_rel
helper. Empty file_rel (single-file scans where namespace == "")
resolves to the file under analysis.
- Extend SinkLocation with snippet, carried from the upstream
SinkSite so the formatter needs no second file read.
- Relax the ssa_events_to_findings debug_assert to allow empty
file_rel, which is valid when scan root equals the file itself.
- SARIF: emit data-flow as codeFlows[0].threadFlows[0].locations[];
locations[0] already reflects the primary sink position via the
updated diag line/col.
Acceptance: scan on tests/benchmark/corpus/rust/cmdi/cmdi_indirect.rs
now reports line 5 (Command::new) as the primary sink, with the call
site at line 10 visible in flow_steps.
Two expect.json fixtures updated (must_match line_range widened):
- javascript/taint/context_sensitive_call: 12-14 -> 7-14 (line 8 is
the real sink inside run()).
- rust/cfg/closure_async: 10-10 -> 10-11 (line 11 is Command::new
inside the closure).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* feat(bench): phase 4/5 validate primary sink attribution across corpus
Extend the benchmark scorer and ground truth to lock in phase 3's
primary-location behavior, and add fixtures that exercise the new
capability end-to-end.
Scorer (tests/benchmark_test.rs):
- Add optional `expected_call_site_lines: Option<Vec<[usize; 2]>>` on
Case. When present, score_location_level additionally requires at
least one flow_step in the finding's evidence trace to fall within
±2 of the call-site range. When absent, the check is skipped —
fully forward-compatible with existing fixtures.
- Retain ±2 tolerance on expected_sink_lines (compared against the
now-primary Diag.line post-phase-3).
Ground truth edits:
- rs-cmdi-cross-001: expected_sink_lines [8,8] -> [9,9]. Line 8 is the
transform::wrap call site (a cross-file propagator, not a sink);
line 9 is Command::new, the real sink. The ±2 tolerance happened to
mask this stale attribution but it was semantically wrong — phase 4
is the right time to correct it. Also adds expected_call_site_lines
[8,8] so the new field is exercised on an existing cross-file case.
- rs-cmdi-003: adds expected_call_site_lines [10,10] (run_cmd call).
This fixture's sink (Command::new inside run_cmd at line 5) was the
motivating case for phases 1-3; adding the call-site assertion
guards against regression to caller-line attribution.
New fixtures:
- rust/cmdi/cmdi_indirect_multisink.rs (rs-cmdi-009): helper run_both
takes two tainted params and invokes two Command sinks on
consecutive lines. Locks in that primary line lands inside the
helper (lines 5-6), not at the caller (line 12). Notes document
that SinkSite is currently one-per-callee so both findings today
collapse onto the first sink; expected_sink_lines=[5,6] and
expected_call_site_lines=[12,12] stay valid either way.
- python/cmdi/cross_indirect_sink/{app.py,helper.py} (py-cmdi-cross-
004): sink os.system lives in helper.py (cross-file), caller in
app.py reads env source and calls run_cmd. Verifies phase 3's
cross-file primary attribution: Diag.path = helper.py, Diag.line =
5, with app.py:7 recorded in flow_steps as a Call step.
Acceptance:
- `cargo test --test benchmark_test -- --ignored --nocapture` passes.
- rs-cmdi-003 is TP/TP/TP (the target flip FN->TP at LOC). All
pre-existing TP/TP/TP fixtures remain TP/TP/TP; 2 new fixtures are
TP/TP/TP.
- Aggregate rule-level: TP=158 FP=10 FN=1 TN=97, P=0.940 R=0.994
F1=0.966 on the 266-case corpus (was TP=156 FP=10 FN=1 TN=97 on
264 pre-phase-4, delta is the +2 new cases both resolving TP).
- Full `cargo test` green (1566 lib tests + all integration tests).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* feat(taint): phase 5/5 lock Finding.primary_location contract via regression test
Add a regression test in src/taint/ssa_transfer.rs that wires up a synthetic
SsaFuncSummary with a SinkSite at other.rs:42:10 and drives the three
emission stages (pick_primary_sink_sites → emit_ssa_taint_events →
ssa_events_to_findings) against a minimal caller SSA body. Asserts the
resulting Finding.primary_location is exactly that triple.
The existing integration tests in src/taint/tests.rs cover the coarse
FuncSummary path end-to-end through analyse_file. This test locks in the
lower-level SSA-side plumbing so a future refactor that silently drops the
site between pick → emit → findings fails here rather than only at the
benchmark layer.
Also refreshes tests/benchmark/results/latest.json (timestamp only; rs-cmdi-003
remains TP/TP/TP and the aggregate P/R/F1 are unchanged from phase 4).
Closes the primary sink-location attribution feature (phases 1-5/5):
* Phase 1 — SinkSite data model on summaries.
* Phase 2 — SinkSite threaded into SsaTaintEvent and Finding.
* Phase 3 — diag + SARIF consume primary_location.
* Phase 4 — benchmark validates primary_call_site_lines across corpus.
* Phase 5 — regression test locks the event→finding contract.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* refactor: clean up formatting and improve readability in multiple files
* refactor: simplify type definition for deduplication key in findings
* test(harness): add must_not_match expectation for FP regression guards
Extends ExpectedFinding with must_not_match field that asserts a
diagnostic must NOT fire — presence is a hard failure. Non-consuming
scan so it coexists with must_match entries on the same rule_id.
Adds forbidden_violations accumulator and updates summary line.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* feat(regression): update expectations to ensure must_not_match for various taint and resource leak rules
* feat: implement auto-seeding for JS/TS handler parameters to enhance taint tracking
* feat: update switch statement handling to improve control flow analysis
* feat: implement promisify alias handling for JS/TS to enhance taint tracking
* feat: enhance taint tracking by refining expectation handling and adding mode filtering
* feat: refine SQL handling in stream processing and enhance auto-seeding for handler parameters
* feat: update taint tracking rules to enforce full mode matching and improve flow analysis
* feat: enhance Ruby subshell handling to improve taint tracking and flow analysis
* feat: update xss_response expectations to refine taint flow analysis and enhance regression guarding
* feat: refine framework detection and update expectation handling for Echo and Sinatra
* feat: implement max_count for taint tracking expectations and deduplicate findings
* feat: add strict_unexpected handling for taint-unsanitised-flow in expectation files
* feat: enhance deduplication of taint-unsanitised-flow findings by collapsing based on line and severity
* feat: add strict_unexpected handling for taint-unsanitised-flow in multiple expectation files
* feat: add structural invariant checks for SSA bodies
* feat: ensure deterministic phi emission order using BTreeSet
* feat: enhance handling of terminators to ensure authoritative flow through successor edges
* feat: enhance Goto terminator handling to ensure all successors are marked executable
* feat: refactor code for improved readability and organization
* feat: simplify predicate checks and enhance readability in SSA handling
* feat: implement per-file parse timeout and enhance file size handling
* feat: migrate analysis engine toggles from environment variables to configuration file
* feat: remove unnecessary whitespace in hostile_input_tests.rs
* feat: remove unnecessary whitespace in hostile_input_tests.rs
* feat: update dependencies and enhance documentation on language maturity
* feat: enhance security headers and improve request body limits
* feat: implement sink capability bits for deduplication and enhance evidence tagging
* feat: implement dynamic activation handling for gated sinks and enhance validation logic
* feat: enhance configuration documentation and clarify inline analysis cache behavior
* feat: implement panic recovery during analysis to continue scans past errors
* feat: add expectations configuration for taint analysis and performance metrics
* feat: enhance error handling and logging during file reading and mutex locking
* feat: add cross-file body loading tests and plumbing for CF-1 phase
* feat: implement cross-file k=1 context-sensitive inline taint analysis with new tests and fixtures
* feat: implement indexed-scan parity in cross-file inline analysis with new dropdown and copy functionality
* feat: enhance classification span handling in CFG and AST for improved source attribution
* feat: add new Express routes for handling user input and telemetry data
* feat: implement ternary expression handling in CFG with diamond structure for JS/TS
* feat: implement Phase CF-3 abstract-domain transfer channels in summaries
* feat: add support for string-prefix transfer in cross-file calls and update tests
* docs: reduce RESULTS.md doc size
* feat: implement Phase CF-4 per-return-path summary decomposition with tests
* feat: update parameter handling in pass1 and refactor SsaFuncSummary initialization
* feat: implement Phase CF-5 for cross-file SCC joint fixed-point convergence with new flags and tests
* feat: implement Phase CF-6 with parameter-granularity points-to summaries and associated tests
* refactor: update comments and documentation for clarity and consistency
* style: format code for consistency and readability
* refactor: simplify verdict handling and improve edge checking logic
* refactor: optimize path and identifier collection by avoiding unnecessary cloning
* chore: update Cargo.toml for Rust version 1.85 and add ignored files; modify CHANGELOG and README for clarity on state analysis defaults
* refactor: update documentation and improve clarity in configuration files
* refactor: update documentation and improve clarity in configuration files
* feat: add JS/TS pass-2 convergence tests and expectations configuration
* feat: add Phase 5 regression tests for inline cache origin attribution and update related logic
* feat: implement Phase 7 deduplication and alternative path linking for taint findings
* feat: implement structural DFS index for anonymous functions and update naming conventions
* feat: add Phase 8 regression tests for container-element taint in JS and Python
* feat: add engine-depth profiles and explain-engine option for CLI
* feat: update expectations and add new README fixtures for multi-file scan regression
* feat: implement Phase 11 callback-alias and factory patterns with regression tests
* feat: implement Terminator::Switch for multi-way dispatch and add regression tests
* feat: add real-CVE benchmark fixtures for CVE-2023-48022, CVE-2019-14939, and CVE-2023-26159 with corresponding patched variants
* refactor: extract cfg and ssa_transfer to submodules
* refactor: cargo fmt
* refactor: remove unnecessary blank line in cfg_tests.rs
* refactor: remove unnecessary planning file
* chore: update Rust version to 1.88 and bump dependencies in Cargo files
* feat: enhance triage UI with new layout and controls, update README for clarity
* feat: enhance triage UI with new layout and controls, update README for clarity
* chore: remove outdated section from README for version 0.5.0
* docs: improve clarity and consistency in README content
* chore: add "GPL-3.0-or-later" to license options in about.toml
* chore: update license handling in about.toml and check-licenses.mjs
* style: format code for improved readability in TriagePage component
* style: format code for improved readability in TriagePage component
* chore: enhance license handling and improve body_id scoping in seed lookup
* feat: introduce owner and parent body IDs for enhanced seed scoping
* feat: implement direction-aware engine provenance with new CLI flag for strict CI gating
* feat: add Undef SSA operation for improved control-flow handling
* style: improve code formatting for consistency and readability in multiple files
* feat: add 16-function chain SCC across multiple files for enhanced analysis
* style: simplify code formatting for improved readability in multiple files
* fix: update CapHitReason default implementation and improve README clarity
* docs: enhance README with detailed explanations of taint analysis and limitations
* docs: refine README for clarity and consistency in taint analysis section
* style: improve code formatting for better readability in NewScanModal and scans
* fix: update cargo-about command to use --offline for deterministic license generation
* fix: update cargo-about command to use --offline for deterministic license generation
* ci: add step to prime cargo registry cache for deterministic license generation
* feat: add support for non-sink collections in authorization analysis
* feat: enhance authorization checks with row-level ownership equality and binding tracking
* feat: implement self-scoped user handling and enhance ownership checks
* refactor: simplify assertions and formatting in authorization analysis tests
* fix: normalize line endings in THIRDPARTY-LICENSES.html generation and update README with AI disclosure
* docs: update AI disclosure section for clarity and conciseness
* feat: add AI Contribution Policy and update contributing guidelines for AI assistance disclosure
* feat: enhance authorization analysis with SSA-derived variable type classification
* feat: implement auth_finding_to_diag function for enhanced security diagnostics
* feat: add args_value_refs to CallSite struct for enhanced argument tracking
* feat: add args_value_refs to CallSite struct for enhanced argument tracking
* feat: add direction-aware engine provenance with LossDirection classification and new CLI flag
* feat: simplify strip_cap_from_call_args call by removing unnecessary line breaks
* feat: enhance error message handling in cli_validation_tests for better Windows compatibility
* feat: optimize release profile settings in Cargo.toml and update CodeQL configuration
* feat: enhance release build process with SBOM generation and SLSA provenance
* feat: update actions/checkout and actions/setup-node to v6, enhance CLI options, and improve auth-check summaries
* feat: introduce PathFact handling for path safety checks and rejection logic
* feat: introduce PathFact handling for path safety checks and rejection logic
* feat: update benchmark data and enhance path sanitization logic with new safety checks
* feat: document AI assistance in frontend UI development and human review process
* feat: add return path facts for enhanced path safety checks and update documentation
* chore: update release date for version 0.5.0 in CHANGELOG.md
* chore: clean up ci.yml by removing outdated comments and clarifying steps
* feat: implement cross-language path sanitizers and validators for enhanced security
* feat: enhance SSA value usage tracking by including block terminators and improve path safety checks
* feat: enhance switch statement handling by adding per-case path constraints and support for exclusive cases
* refactor: simplify conditional formatting and improve code readability in executor and lower modules
* feat: add vulnerable examples for various languages demonstrating authentication and sanitization issues
* feat: enhance actor context recognition for self-actor identifiers and add support for global non-sink receivers
* feat: enhance actor context recognition for self-actor identifiers and add support for global non-sink receivers
* feat: add transform classifiers for Java, Go, and Ruby with corresponding tests
* refactor: clarify comments on reassign-to-constant idiom and sink behavior in guards.rs
---------
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
2026-04-25 17:59:11 -04:00
|
|
|
///
|
|
|
|
|
/// Emitted only for switch-like dispatch whose semantics are
|
|
|
|
|
/// guaranteed-exclusive across cases (e.g. Go `switch`, Java
|
|
|
|
|
/// arrow-switch, Rust `match`). Fall-through switches (C, C++, Java
|
|
|
|
|
/// classic switch without `break`) continue to use the cascaded
|
|
|
|
|
/// `Branch` lowering because the precision advantage only holds when
|
|
|
|
|
/// cases are mutually exclusive.
|
|
|
|
|
Switch {
|
|
|
|
|
scrutinee: SsaValue,
|
|
|
|
|
targets: SmallVec<[BlockId; 4]>,
|
|
|
|
|
default: BlockId,
|
|
|
|
|
/// Per-target case literals, aligned 1:1 with `targets`.
|
|
|
|
|
///
|
|
|
|
|
/// `Some(c)` records the constant value the scrutinee must equal for
|
|
|
|
|
/// the corresponding target to be taken. `None` means the literal is
|
2026-04-29 19:53:34 -04:00
|
|
|
/// unknown, emitted for synthetic ≥3-way CFG fanouts or for case
|
Release/0.5.0 (#35)
* feat: Introduce function-scoped variable interning for state analysis with new tests and fixtures
* feat: Add Phase 26 symbolic execution enhancements with bitwise operator support, abstract interpretation refinements, and new taint analysis tests
* feat: Refine state analysis to handle factory-pattern resource returns with mixed-path tests and leak detection enhancements
* feat: Add Phase 27 debug views with symbolic execution, abstract interpretation, SSA, and call graph viewers; integrate with debug layout and styles
* feat: Add Phase 31 type-qualified symbolic resolution with receiver-based callee disambiguation and testing
* feat: Extend symbolic execution with state iteration, enhanced debug views, and debounced input handling
* feat: Add Phase 13 resource and auth pattern extensions with new tests and fixtures
* feat: Introduce CFG debug graph renderer with compact mode, toolbar, and DAG layout integration
* feat: Add Phase 28 encoding and decoding transform modeling with structural symex enhancements and new taint analysis tests
* feat: Extend abstract interpretation with type facts and constant value tracking in debug views and server logic
* feat: Add linear path handling and witness extraction to symbolic execution with Phase 28 transform mismatch detection
* feat: Refine Go auth and sanitizer handling with enhanced rules, state updates, and benchmark improvements
* feat: Enable auth-state analysis by default and update relevant tests in benchmark config
* test: Update state_tests to reflect default enablement of auth-state analysis and add auth suppression test
* docs: update CHANGELOG.md
* feat: Introduce per-index taint tracking in `HeapState` with `HeapSlot`, overflow handling, and revised SSA transfers
* feat: Introduce C/C++ language labels and refine heap state tracking in SSA transfers
* feat: Implement per-index array slot tracking in symbolic heap with overflow collapse
* feat: Add implicit definition handling for uninitialized declarations in SSA value allocation
* feat: Refactor function parameters and constants for improved clarity and maintainability
* refactor: Reorder module imports and improve formatting for consistency
* refactor: Fix formatting erorrs
* refactor: Fix clippy warnings
* refactor: Fix fmt warnings (again)
* chore: Update dependencies and improve feature configuration
* Add comprehensive tests for undertested modules (#36) (COPILOT)
* Add comprehensive tests for undertested modules
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/f3fc877e-f386-49ba-9793-fc93d3805083
* Add comprehensive tests for ext, project, walk, and errors modules
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/f3fc877e-f386-49ba-9793-fc93d3805083
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
* chore: Update dependencies and improve feature configuration
* fix: formatting errors in new tests
* chore: Update license list in about.toml
* chore: made functions input inline
* chore: updated cfg graph to take up the full page
* chore: add Prettier configuration and update code formatting
* Add frontend test suite with Vitest (111 tests) (#37)
* Add Vitest test suite for frontend - 111 tests across utils, components, hooks, and graph utilities
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/7cf0dba2-ecff-4740-ba4d-92717e74a0b7
* ci: add frontend test step to CI workflow
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/5bc0ac9f-0a32-4d03-9cb7-7a15aea53fca
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
* chore: simplify array initialization in test files for consistency
* ran typecheck
* feat: add AnalysisWorkspace component and integrate it into CfgViewerPage
* feat: update routing in AppLayout and improve empty state message in ExplorerPage
* feat: enhance scan progress tracking with additional metrics and stages
* feat: update license information and add license check script
* feat: implement cross-file symbolic execution with callee body persistence
* feat: replace dagre graphs with Graphology + ELK + Sigma for more advanced call stack and cfg rendering
* feat: ensure CFG function view is scoped to the selected function, preventing bleed into sibling functions
* feat: enhance resource tracking with proxy method summaries and improve finding extraction
* feat: add terminal function exit detection for accurate resource leak analysis
* feat: add warnings for loops and functions without bodies to improve error recovery
* feat: update lambda expression handling to ensure proper function classification and control flow
* feat: remove bounded formatting/string ops and add JSON.parse sanitizer for improved data handling
* feat: add inline return taint analysis and regression tests for improved security checks
* feat: add engine version management and migration handling for database schema updates
* feat: enhance first_call_ident to skip nested function bodies and add regression tests
* feat: enhance callee name resolution with two-segment normalization and disambiguation
* feat: add cross-file context flags and debug assertions for taint analysis
* feat: refactor taint analysis structure to unify context handling and improve clarity
* feat: enhance dead code elimination to preserve Sink, Source, and Sanitizer labels with new tests
* docs: updated CHANGELOG.md
* fmt: formatting fixes
* fix: fixed frontend formatting and lint warnings
* fix: optimized ci
* fix: optimized ci
* Add comprehensive multi-file test coverage to Nyx (#38)
* Initial checklist for multi-file test suite expansion
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/e550cb88-9767-4442-94d4-101bf5bb0e23
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
* Add 12 new multi-file test fixtures with TP/TN/near-miss coverage
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/e550cb88-9767-4442-94d4-101bf5bb0e23
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
* deleted root repo
* rebuilt to test for regressions
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
Co-authored-by: elipeter <elicpeter@gmail.com>
* feat: enhance import alias resolution and taint tracking
* feat: implement security hardening with CSRF protection and path validation
* feat: add support for import alias bindings in Python, PHP, and Rust
* feat: enhance CFG analysis modes and improve code readability
* feat: add detection for parameterized SQL queries to enhance security
* feat: add safe internal redirect handling and enhance session destroy validation
* feat: implement security improvements by addressing vulnerabilities in execAsync, session management, and file downloads
* feat: enhance taint detection by adding support for inline source member expressions in call arguments
* feat: implement pre-emission of Source nodes for inline source member expressions in call arguments
* feat: add support for Throw statement in control flow and error handling
* feat: add debug and echo endpoints with potential information leakage
* feat: implement internal redirect suppression and enhance taint detection
* feat: implement module alias tracking for dynamic dispatch in JS/TS
* feat: add authorization analysis module with Express support
* feat: add authorization analysis module with Express support
* feat: add tests for admin guard requirements and clean checks in authorization analysis
* feat: integrate Koa and Fastify frameworks into authorization analysis
* feat: add Flask and Django support to authorization analysis module
* feat: add support for Rails and Sinatra frameworks in authorization analysis
* feat: add support for Axum, ActixWeb, and Rocket frameworks in authorization analysis
* feat: add support for ActixWeb, Axum, and Rocket frameworks in authorization analysis
* feat: add support for Rails and Sinatra in authorization analysis
* chore: add .DS_Store to .gitignore
* refactor: simplify conditional checks and improve readability in multiple files
* refactor: update usage of Option methods for improved clarity and consistency
* refactor: improve code readability by simplifying conditional checks and formatting
* refactor: improve code formatting and readability by simplifying conditional checks
* refactor: simplify conditional checks and improve readability in multiple files
* refactor: simplify conditional checks in axum.rs for improved readability
* feat: add CodeQL analysis configuration for enhanced security scanning
* test: add comprehensive tests for `src/output.rs` SARIF builder (#39)
* chore: start test coverage improvement work
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/cd7ff398-134e-4728-a5e7-0353a0744423
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
* test: add comprehensive tests for src/output.rs SARIF builder
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/cd7ff398-134e-4728-a5e7-0353a0744423
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
* refactor: improve code formatting and readability in output.rs
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
Co-authored-by: elipeter <elicpeter@gmail.com>
* refactor: improve code formatting and readability in output.rs
* Potential fix for code scanning alert no. 210: Uncontrolled data used in path expression
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
* Potential fix for code scanning alert no. 211: Uncontrolled data used in path expression
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
* refactor: enhance triage file path handling with improved error management and validation
* refactor: updated func summaries for richer detail
* refactor: update SSA summary extraction to use canonical FuncKey for distinct entries
* refactor: enhance callee metadata structure to support arity, receiver, and qualifier for better overload resolution
* refactor: add support for keyword arguments in function calls and enhance receiver extraction for method-style calls
* refactor: implement new Flask routes for safe and unsafe shell command execution
* refactor: separate receiver handling in SSA operations and enhance taint propagation
* refactor: improve arity handling by using arg_uses for positional argument count and enhance witness scoring for tainted arguments
* refactor: implement auth decorator extraction and classification for multiple languages
* refactor: enhance Rust module path resolution and use map handling for cross-file disambiguation
* refactor: introduce CalleeQuery struct for structured callee resolution and enhance resolver logic
* refactor: implement same-file identity collision handling for `runTask` to ensure correct resolver behavior
* refactor: standardize default struct initialization across multiple files
* feat: add scripts for formatting checks and auto-fixes with test summaries
* refactor: simplify character splitting and enhance namespace qualifier handling
* refactor: improve documentation clarity and enhance code readability in resolver logic
* refactor: replace default struct initialization with explicit field assignments for clarity
* feat: enhance anonymous function naming by deriving context-based bindings
* refactor: streamline match expressions for improved readability and performance
* refactor: streamline match expressions for improved readability and performance
* refactor: replace loop with while let for improved clarity and performance
* feat: add SSA constant propagation support to analysis context for improved accuracy
* feat: add SSA constant propagation support to analysis context for improved accuracy
* feat: implement shell metacharacter validation and bounded-length checks in Rust analysis
* feat: add static map analysis for command injection suppression and type safety
* refactor: simplify match statements and reduce line breaks for improved readability
* feat(summary): phase 1/5 SinkSite data model for primary sink-location attribution
Introduce SinkSite (file_rel, line, col, snippet, cap) carrying the
primary sink source-location through function summaries. Swap
SsaFuncSummary.param_to_sink and FuncSummary.param_to_sink from a coarse
Cap map to a deduped SmallVec<[SinkSite; 1]> per parameter, with a
backward-compatible cap_sites() helper and serde defaults so pre-phase-1
on-disk rows continue to deserialise cleanly.
Extraction: SinkSiteLocator bundles the tree/bytes/file_rel needed by
extract_ssa_func_summary; ParsedFile::extract_ssa_artifacts wires the
locator in for the persisted pass-1 path, while pass-2 intra-file
transient summaries fall back to cap-only sites (behavior unchanged).
Merge: GlobalSummaries::insert now unions sink sites with
(file_rel, line, col, cap) dedup via shared union_param_sink_sites
helper.
Database: JSON-serialised summary columns carry the new shape
automatically; no schema change needed.
Phase 2 will consume SinkSite in build_taint_diag() to overwrite the
caller-site Finding.line with the callee's sink line when resolved via
summary. Phase 1 keeps behavior unchanged: scanning
tests/benchmark/corpus/rust/cmdi/cmdi_indirect.rs still produces the
same (wrong) line 10 finding.
Adds round-trip tests covering SinkSite solo, SsaFuncSummary with sink
sites, legacy-JSON default handling for both summary types, and merge
dedup.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
* feat(taint): phase 2/5 thread SinkSite into SsaTaintEvent and Finding
Plumb Phase 1's SinkSite through the event pipeline into Findings,
no output change yet. SsaTaintEvent gains `primary_sink_site:
Option<SinkSite>`; when the main or callback sink-emission path has
non-empty `param_to_sink_sites`, filter to sites whose
`(line != 0) && (cap ∩ sink_caps != ∅)` and emit one event per
distinct site — the multi-primary collapse keeps each downstream
Finding single-primary.
Resolution: ResolvedSummary and SinkInfo gain mirror
`param_to_sink_sites` fields, populated from `SsaFuncSummary.param_to_sink`
(SSA + callback paths) and `FuncSummary.param_to_sink` (global paths).
Label, local-summary, and interop resolution paths leave the field
empty — they only ever had cap-level info to begin with.
Finding: new `primary_location: Option<SinkLocation>` with
`file_rel/line/col`. `ssa_events_to_findings` maps
`event.primary_sink_site` → `Finding.primary_location`, filtering
cap-only sites (`line == 0`) to `None` so the (0,0) sentinel never
leaks to formatters. Dedup key extended with the primary location
so multi-site events aren't collapsed back together.
Invariants (debug_assert!):
* every SinkSite reaching emission has `line != 0 && cap ∩ sink_caps
!= ∅` — enforced by the pick_primary_sink_sites* filters;
* every populated Finding.primary_location has `line != 0` AND
non-empty `file_rel` — the cap-only → None translation upstream
guarantees this.
Deliberately independent of `uses_summary`: that flag tracks whether
the *taint chain* used a summary, whereas primary attribution
requires only that the *sink* itself was summary-resolved. A local
source reaching a cross-file sink produces `uses_summary=false`
alongside a populated primary_location — documented on
Finding.primary_location, covered by
`cross_file_sink_finding_carries_primary_location`.
build_taint_diag, SARIF/JSON/explanation formatters, and the
benchmark scorer remain untouched: finding.line still comes from
`cfg_graph[finding.sink]`, so cmdi_indirect.rs still reports line 10
and the benchmark's rs-cmdi-003 row still shows FN in the LOC column.
Tests: `cross_file_sink_finding_carries_primary_location` (proves
plumbing via a synthetic FuncSummary carrying a SinkSite at 42:5) and
`cross_file_sink_cap_only_site_leaves_primary_location_none`
(regression guard against cap-only sites surfacing). All 1566 lib
tests + integration tests pass.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* feat(output): phase 3/5 consume primary sink location in diag + SARIF
When a finding's primary_location (populated in phase 2 from a callee
summary's SinkSite) names the dangerous instruction inside a callee
body, attribute the diagnostic line to that location instead of the
caller's call site. The call site is demoted to a Call step in
flow_steps, and a synthetic Sink step at the primary location is
appended so analysts still see the full trace.
Changes:
- Add scan_root parameter to build_taint_diag so file_rel can be
resolved back to an absolute path via a shared resolve_file_rel
helper. Empty file_rel (single-file scans where namespace == "")
resolves to the file under analysis.
- Extend SinkLocation with snippet, carried from the upstream
SinkSite so the formatter needs no second file read.
- Relax the ssa_events_to_findings debug_assert to allow empty
file_rel, which is valid when scan root equals the file itself.
- SARIF: emit data-flow as codeFlows[0].threadFlows[0].locations[];
locations[0] already reflects the primary sink position via the
updated diag line/col.
Acceptance: scan on tests/benchmark/corpus/rust/cmdi/cmdi_indirect.rs
now reports line 5 (Command::new) as the primary sink, with the call
site at line 10 visible in flow_steps.
Two expect.json fixtures updated (must_match line_range widened):
- javascript/taint/context_sensitive_call: 12-14 -> 7-14 (line 8 is
the real sink inside run()).
- rust/cfg/closure_async: 10-10 -> 10-11 (line 11 is Command::new
inside the closure).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* feat(bench): phase 4/5 validate primary sink attribution across corpus
Extend the benchmark scorer and ground truth to lock in phase 3's
primary-location behavior, and add fixtures that exercise the new
capability end-to-end.
Scorer (tests/benchmark_test.rs):
- Add optional `expected_call_site_lines: Option<Vec<[usize; 2]>>` on
Case. When present, score_location_level additionally requires at
least one flow_step in the finding's evidence trace to fall within
±2 of the call-site range. When absent, the check is skipped —
fully forward-compatible with existing fixtures.
- Retain ±2 tolerance on expected_sink_lines (compared against the
now-primary Diag.line post-phase-3).
Ground truth edits:
- rs-cmdi-cross-001: expected_sink_lines [8,8] -> [9,9]. Line 8 is the
transform::wrap call site (a cross-file propagator, not a sink);
line 9 is Command::new, the real sink. The ±2 tolerance happened to
mask this stale attribution but it was semantically wrong — phase 4
is the right time to correct it. Also adds expected_call_site_lines
[8,8] so the new field is exercised on an existing cross-file case.
- rs-cmdi-003: adds expected_call_site_lines [10,10] (run_cmd call).
This fixture's sink (Command::new inside run_cmd at line 5) was the
motivating case for phases 1-3; adding the call-site assertion
guards against regression to caller-line attribution.
New fixtures:
- rust/cmdi/cmdi_indirect_multisink.rs (rs-cmdi-009): helper run_both
takes two tainted params and invokes two Command sinks on
consecutive lines. Locks in that primary line lands inside the
helper (lines 5-6), not at the caller (line 12). Notes document
that SinkSite is currently one-per-callee so both findings today
collapse onto the first sink; expected_sink_lines=[5,6] and
expected_call_site_lines=[12,12] stay valid either way.
- python/cmdi/cross_indirect_sink/{app.py,helper.py} (py-cmdi-cross-
004): sink os.system lives in helper.py (cross-file), caller in
app.py reads env source and calls run_cmd. Verifies phase 3's
cross-file primary attribution: Diag.path = helper.py, Diag.line =
5, with app.py:7 recorded in flow_steps as a Call step.
Acceptance:
- `cargo test --test benchmark_test -- --ignored --nocapture` passes.
- rs-cmdi-003 is TP/TP/TP (the target flip FN->TP at LOC). All
pre-existing TP/TP/TP fixtures remain TP/TP/TP; 2 new fixtures are
TP/TP/TP.
- Aggregate rule-level: TP=158 FP=10 FN=1 TN=97, P=0.940 R=0.994
F1=0.966 on the 266-case corpus (was TP=156 FP=10 FN=1 TN=97 on
264 pre-phase-4, delta is the +2 new cases both resolving TP).
- Full `cargo test` green (1566 lib tests + all integration tests).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* feat(taint): phase 5/5 lock Finding.primary_location contract via regression test
Add a regression test in src/taint/ssa_transfer.rs that wires up a synthetic
SsaFuncSummary with a SinkSite at other.rs:42:10 and drives the three
emission stages (pick_primary_sink_sites → emit_ssa_taint_events →
ssa_events_to_findings) against a minimal caller SSA body. Asserts the
resulting Finding.primary_location is exactly that triple.
The existing integration tests in src/taint/tests.rs cover the coarse
FuncSummary path end-to-end through analyse_file. This test locks in the
lower-level SSA-side plumbing so a future refactor that silently drops the
site between pick → emit → findings fails here rather than only at the
benchmark layer.
Also refreshes tests/benchmark/results/latest.json (timestamp only; rs-cmdi-003
remains TP/TP/TP and the aggregate P/R/F1 are unchanged from phase 4).
Closes the primary sink-location attribution feature (phases 1-5/5):
* Phase 1 — SinkSite data model on summaries.
* Phase 2 — SinkSite threaded into SsaTaintEvent and Finding.
* Phase 3 — diag + SARIF consume primary_location.
* Phase 4 — benchmark validates primary_call_site_lines across corpus.
* Phase 5 — regression test locks the event→finding contract.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* refactor: clean up formatting and improve readability in multiple files
* refactor: simplify type definition for deduplication key in findings
* test(harness): add must_not_match expectation for FP regression guards
Extends ExpectedFinding with must_not_match field that asserts a
diagnostic must NOT fire — presence is a hard failure. Non-consuming
scan so it coexists with must_match entries on the same rule_id.
Adds forbidden_violations accumulator and updates summary line.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* feat(regression): update expectations to ensure must_not_match for various taint and resource leak rules
* feat: implement auto-seeding for JS/TS handler parameters to enhance taint tracking
* feat: update switch statement handling to improve control flow analysis
* feat: implement promisify alias handling for JS/TS to enhance taint tracking
* feat: enhance taint tracking by refining expectation handling and adding mode filtering
* feat: refine SQL handling in stream processing and enhance auto-seeding for handler parameters
* feat: update taint tracking rules to enforce full mode matching and improve flow analysis
* feat: enhance Ruby subshell handling to improve taint tracking and flow analysis
* feat: update xss_response expectations to refine taint flow analysis and enhance regression guarding
* feat: refine framework detection and update expectation handling for Echo and Sinatra
* feat: implement max_count for taint tracking expectations and deduplicate findings
* feat: add strict_unexpected handling for taint-unsanitised-flow in expectation files
* feat: enhance deduplication of taint-unsanitised-flow findings by collapsing based on line and severity
* feat: add strict_unexpected handling for taint-unsanitised-flow in multiple expectation files
* feat: add structural invariant checks for SSA bodies
* feat: ensure deterministic phi emission order using BTreeSet
* feat: enhance handling of terminators to ensure authoritative flow through successor edges
* feat: enhance Goto terminator handling to ensure all successors are marked executable
* feat: refactor code for improved readability and organization
* feat: simplify predicate checks and enhance readability in SSA handling
* feat: implement per-file parse timeout and enhance file size handling
* feat: migrate analysis engine toggles from environment variables to configuration file
* feat: remove unnecessary whitespace in hostile_input_tests.rs
* feat: remove unnecessary whitespace in hostile_input_tests.rs
* feat: update dependencies and enhance documentation on language maturity
* feat: enhance security headers and improve request body limits
* feat: implement sink capability bits for deduplication and enhance evidence tagging
* feat: implement dynamic activation handling for gated sinks and enhance validation logic
* feat: enhance configuration documentation and clarify inline analysis cache behavior
* feat: implement panic recovery during analysis to continue scans past errors
* feat: add expectations configuration for taint analysis and performance metrics
* feat: enhance error handling and logging during file reading and mutex locking
* feat: add cross-file body loading tests and plumbing for CF-1 phase
* feat: implement cross-file k=1 context-sensitive inline taint analysis with new tests and fixtures
* feat: implement indexed-scan parity in cross-file inline analysis with new dropdown and copy functionality
* feat: enhance classification span handling in CFG and AST for improved source attribution
* feat: add new Express routes for handling user input and telemetry data
* feat: implement ternary expression handling in CFG with diamond structure for JS/TS
* feat: implement Phase CF-3 abstract-domain transfer channels in summaries
* feat: add support for string-prefix transfer in cross-file calls and update tests
* docs: reduce RESULTS.md doc size
* feat: implement Phase CF-4 per-return-path summary decomposition with tests
* feat: update parameter handling in pass1 and refactor SsaFuncSummary initialization
* feat: implement Phase CF-5 for cross-file SCC joint fixed-point convergence with new flags and tests
* feat: implement Phase CF-6 with parameter-granularity points-to summaries and associated tests
* refactor: update comments and documentation for clarity and consistency
* style: format code for consistency and readability
* refactor: simplify verdict handling and improve edge checking logic
* refactor: optimize path and identifier collection by avoiding unnecessary cloning
* chore: update Cargo.toml for Rust version 1.85 and add ignored files; modify CHANGELOG and README for clarity on state analysis defaults
* refactor: update documentation and improve clarity in configuration files
* refactor: update documentation and improve clarity in configuration files
* feat: add JS/TS pass-2 convergence tests and expectations configuration
* feat: add Phase 5 regression tests for inline cache origin attribution and update related logic
* feat: implement Phase 7 deduplication and alternative path linking for taint findings
* feat: implement structural DFS index for anonymous functions and update naming conventions
* feat: add Phase 8 regression tests for container-element taint in JS and Python
* feat: add engine-depth profiles and explain-engine option for CLI
* feat: update expectations and add new README fixtures for multi-file scan regression
* feat: implement Phase 11 callback-alias and factory patterns with regression tests
* feat: implement Terminator::Switch for multi-way dispatch and add regression tests
* feat: add real-CVE benchmark fixtures for CVE-2023-48022, CVE-2019-14939, and CVE-2023-26159 with corresponding patched variants
* refactor: extract cfg and ssa_transfer to submodules
* refactor: cargo fmt
* refactor: remove unnecessary blank line in cfg_tests.rs
* refactor: remove unnecessary planning file
* chore: update Rust version to 1.88 and bump dependencies in Cargo files
* feat: enhance triage UI with new layout and controls, update README for clarity
* feat: enhance triage UI with new layout and controls, update README for clarity
* chore: remove outdated section from README for version 0.5.0
* docs: improve clarity and consistency in README content
* chore: add "GPL-3.0-or-later" to license options in about.toml
* chore: update license handling in about.toml and check-licenses.mjs
* style: format code for improved readability in TriagePage component
* style: format code for improved readability in TriagePage component
* chore: enhance license handling and improve body_id scoping in seed lookup
* feat: introduce owner and parent body IDs for enhanced seed scoping
* feat: implement direction-aware engine provenance with new CLI flag for strict CI gating
* feat: add Undef SSA operation for improved control-flow handling
* style: improve code formatting for consistency and readability in multiple files
* feat: add 16-function chain SCC across multiple files for enhanced analysis
* style: simplify code formatting for improved readability in multiple files
* fix: update CapHitReason default implementation and improve README clarity
* docs: enhance README with detailed explanations of taint analysis and limitations
* docs: refine README for clarity and consistency in taint analysis section
* style: improve code formatting for better readability in NewScanModal and scans
* fix: update cargo-about command to use --offline for deterministic license generation
* fix: update cargo-about command to use --offline for deterministic license generation
* ci: add step to prime cargo registry cache for deterministic license generation
* feat: add support for non-sink collections in authorization analysis
* feat: enhance authorization checks with row-level ownership equality and binding tracking
* feat: implement self-scoped user handling and enhance ownership checks
* refactor: simplify assertions and formatting in authorization analysis tests
* fix: normalize line endings in THIRDPARTY-LICENSES.html generation and update README with AI disclosure
* docs: update AI disclosure section for clarity and conciseness
* feat: add AI Contribution Policy and update contributing guidelines for AI assistance disclosure
* feat: enhance authorization analysis with SSA-derived variable type classification
* feat: implement auth_finding_to_diag function for enhanced security diagnostics
* feat: add args_value_refs to CallSite struct for enhanced argument tracking
* feat: add args_value_refs to CallSite struct for enhanced argument tracking
* feat: add direction-aware engine provenance with LossDirection classification and new CLI flag
* feat: simplify strip_cap_from_call_args call by removing unnecessary line breaks
* feat: enhance error message handling in cli_validation_tests for better Windows compatibility
* feat: optimize release profile settings in Cargo.toml and update CodeQL configuration
* feat: enhance release build process with SBOM generation and SLSA provenance
* feat: update actions/checkout and actions/setup-node to v6, enhance CLI options, and improve auth-check summaries
* feat: introduce PathFact handling for path safety checks and rejection logic
* feat: introduce PathFact handling for path safety checks and rejection logic
* feat: update benchmark data and enhance path sanitization logic with new safety checks
* feat: document AI assistance in frontend UI development and human review process
* feat: add return path facts for enhanced path safety checks and update documentation
* chore: update release date for version 0.5.0 in CHANGELOG.md
* chore: clean up ci.yml by removing outdated comments and clarifying steps
* feat: implement cross-language path sanitizers and validators for enhanced security
* feat: enhance SSA value usage tracking by including block terminators and improve path safety checks
* feat: enhance switch statement handling by adding per-case path constraints and support for exclusive cases
* refactor: simplify conditional formatting and improve code readability in executor and lower modules
* feat: add vulnerable examples for various languages demonstrating authentication and sanitization issues
* feat: enhance actor context recognition for self-actor identifiers and add support for global non-sink receivers
* feat: enhance actor context recognition for self-actor identifiers and add support for global non-sink receivers
* feat: add transform classifiers for Java, Go, and Ruby with corresponding tests
* refactor: clarify comments on reassign-to-constant idiom and sink behavior in guards.rs
---------
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
2026-04-25 17:59:11 -04:00
|
|
|
/// patterns that aren't plain literals (OR-patterns, ranges, guards).
|
|
|
|
|
///
|
|
|
|
|
/// When omitted/empty (length zero), all targets behave as "unknown
|
2026-04-29 19:53:34 -04:00
|
|
|
/// literal", preserves backward compatibility with consumers that
|
Release/0.5.0 (#35)
* feat: Introduce function-scoped variable interning for state analysis with new tests and fixtures
* feat: Add Phase 26 symbolic execution enhancements with bitwise operator support, abstract interpretation refinements, and new taint analysis tests
* feat: Refine state analysis to handle factory-pattern resource returns with mixed-path tests and leak detection enhancements
* feat: Add Phase 27 debug views with symbolic execution, abstract interpretation, SSA, and call graph viewers; integrate with debug layout and styles
* feat: Add Phase 31 type-qualified symbolic resolution with receiver-based callee disambiguation and testing
* feat: Extend symbolic execution with state iteration, enhanced debug views, and debounced input handling
* feat: Add Phase 13 resource and auth pattern extensions with new tests and fixtures
* feat: Introduce CFG debug graph renderer with compact mode, toolbar, and DAG layout integration
* feat: Add Phase 28 encoding and decoding transform modeling with structural symex enhancements and new taint analysis tests
* feat: Extend abstract interpretation with type facts and constant value tracking in debug views and server logic
* feat: Add linear path handling and witness extraction to symbolic execution with Phase 28 transform mismatch detection
* feat: Refine Go auth and sanitizer handling with enhanced rules, state updates, and benchmark improvements
* feat: Enable auth-state analysis by default and update relevant tests in benchmark config
* test: Update state_tests to reflect default enablement of auth-state analysis and add auth suppression test
* docs: update CHANGELOG.md
* feat: Introduce per-index taint tracking in `HeapState` with `HeapSlot`, overflow handling, and revised SSA transfers
* feat: Introduce C/C++ language labels and refine heap state tracking in SSA transfers
* feat: Implement per-index array slot tracking in symbolic heap with overflow collapse
* feat: Add implicit definition handling for uninitialized declarations in SSA value allocation
* feat: Refactor function parameters and constants for improved clarity and maintainability
* refactor: Reorder module imports and improve formatting for consistency
* refactor: Fix formatting erorrs
* refactor: Fix clippy warnings
* refactor: Fix fmt warnings (again)
* chore: Update dependencies and improve feature configuration
* Add comprehensive tests for undertested modules (#36) (COPILOT)
* Add comprehensive tests for undertested modules
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/f3fc877e-f386-49ba-9793-fc93d3805083
* Add comprehensive tests for ext, project, walk, and errors modules
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/f3fc877e-f386-49ba-9793-fc93d3805083
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
* chore: Update dependencies and improve feature configuration
* fix: formatting errors in new tests
* chore: Update license list in about.toml
* chore: made functions input inline
* chore: updated cfg graph to take up the full page
* chore: add Prettier configuration and update code formatting
* Add frontend test suite with Vitest (111 tests) (#37)
* Add Vitest test suite for frontend - 111 tests across utils, components, hooks, and graph utilities
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/7cf0dba2-ecff-4740-ba4d-92717e74a0b7
* ci: add frontend test step to CI workflow
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/5bc0ac9f-0a32-4d03-9cb7-7a15aea53fca
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
* chore: simplify array initialization in test files for consistency
* ran typecheck
* feat: add AnalysisWorkspace component and integrate it into CfgViewerPage
* feat: update routing in AppLayout and improve empty state message in ExplorerPage
* feat: enhance scan progress tracking with additional metrics and stages
* feat: update license information and add license check script
* feat: implement cross-file symbolic execution with callee body persistence
* feat: replace dagre graphs with Graphology + ELK + Sigma for more advanced call stack and cfg rendering
* feat: ensure CFG function view is scoped to the selected function, preventing bleed into sibling functions
* feat: enhance resource tracking with proxy method summaries and improve finding extraction
* feat: add terminal function exit detection for accurate resource leak analysis
* feat: add warnings for loops and functions without bodies to improve error recovery
* feat: update lambda expression handling to ensure proper function classification and control flow
* feat: remove bounded formatting/string ops and add JSON.parse sanitizer for improved data handling
* feat: add inline return taint analysis and regression tests for improved security checks
* feat: add engine version management and migration handling for database schema updates
* feat: enhance first_call_ident to skip nested function bodies and add regression tests
* feat: enhance callee name resolution with two-segment normalization and disambiguation
* feat: add cross-file context flags and debug assertions for taint analysis
* feat: refactor taint analysis structure to unify context handling and improve clarity
* feat: enhance dead code elimination to preserve Sink, Source, and Sanitizer labels with new tests
* docs: updated CHANGELOG.md
* fmt: formatting fixes
* fix: fixed frontend formatting and lint warnings
* fix: optimized ci
* fix: optimized ci
* Add comprehensive multi-file test coverage to Nyx (#38)
* Initial checklist for multi-file test suite expansion
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/e550cb88-9767-4442-94d4-101bf5bb0e23
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
* Add 12 new multi-file test fixtures with TP/TN/near-miss coverage
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/e550cb88-9767-4442-94d4-101bf5bb0e23
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
* deleted root repo
* rebuilt to test for regressions
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
Co-authored-by: elipeter <elicpeter@gmail.com>
* feat: enhance import alias resolution and taint tracking
* feat: implement security hardening with CSRF protection and path validation
* feat: add support for import alias bindings in Python, PHP, and Rust
* feat: enhance CFG analysis modes and improve code readability
* feat: add detection for parameterized SQL queries to enhance security
* feat: add safe internal redirect handling and enhance session destroy validation
* feat: implement security improvements by addressing vulnerabilities in execAsync, session management, and file downloads
* feat: enhance taint detection by adding support for inline source member expressions in call arguments
* feat: implement pre-emission of Source nodes for inline source member expressions in call arguments
* feat: add support for Throw statement in control flow and error handling
* feat: add debug and echo endpoints with potential information leakage
* feat: implement internal redirect suppression and enhance taint detection
* feat: implement module alias tracking for dynamic dispatch in JS/TS
* feat: add authorization analysis module with Express support
* feat: add authorization analysis module with Express support
* feat: add tests for admin guard requirements and clean checks in authorization analysis
* feat: integrate Koa and Fastify frameworks into authorization analysis
* feat: add Flask and Django support to authorization analysis module
* feat: add support for Rails and Sinatra frameworks in authorization analysis
* feat: add support for Axum, ActixWeb, and Rocket frameworks in authorization analysis
* feat: add support for ActixWeb, Axum, and Rocket frameworks in authorization analysis
* feat: add support for Rails and Sinatra in authorization analysis
* chore: add .DS_Store to .gitignore
* refactor: simplify conditional checks and improve readability in multiple files
* refactor: update usage of Option methods for improved clarity and consistency
* refactor: improve code readability by simplifying conditional checks and formatting
* refactor: improve code formatting and readability by simplifying conditional checks
* refactor: simplify conditional checks and improve readability in multiple files
* refactor: simplify conditional checks in axum.rs for improved readability
* feat: add CodeQL analysis configuration for enhanced security scanning
* test: add comprehensive tests for `src/output.rs` SARIF builder (#39)
* chore: start test coverage improvement work
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/cd7ff398-134e-4728-a5e7-0353a0744423
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
* test: add comprehensive tests for src/output.rs SARIF builder
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/cd7ff398-134e-4728-a5e7-0353a0744423
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
* refactor: improve code formatting and readability in output.rs
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
Co-authored-by: elipeter <elicpeter@gmail.com>
* refactor: improve code formatting and readability in output.rs
* Potential fix for code scanning alert no. 210: Uncontrolled data used in path expression
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
* Potential fix for code scanning alert no. 211: Uncontrolled data used in path expression
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
* refactor: enhance triage file path handling with improved error management and validation
* refactor: updated func summaries for richer detail
* refactor: update SSA summary extraction to use canonical FuncKey for distinct entries
* refactor: enhance callee metadata structure to support arity, receiver, and qualifier for better overload resolution
* refactor: add support for keyword arguments in function calls and enhance receiver extraction for method-style calls
* refactor: implement new Flask routes for safe and unsafe shell command execution
* refactor: separate receiver handling in SSA operations and enhance taint propagation
* refactor: improve arity handling by using arg_uses for positional argument count and enhance witness scoring for tainted arguments
* refactor: implement auth decorator extraction and classification for multiple languages
* refactor: enhance Rust module path resolution and use map handling for cross-file disambiguation
* refactor: introduce CalleeQuery struct for structured callee resolution and enhance resolver logic
* refactor: implement same-file identity collision handling for `runTask` to ensure correct resolver behavior
* refactor: standardize default struct initialization across multiple files
* feat: add scripts for formatting checks and auto-fixes with test summaries
* refactor: simplify character splitting and enhance namespace qualifier handling
* refactor: improve documentation clarity and enhance code readability in resolver logic
* refactor: replace default struct initialization with explicit field assignments for clarity
* feat: enhance anonymous function naming by deriving context-based bindings
* refactor: streamline match expressions for improved readability and performance
* refactor: streamline match expressions for improved readability and performance
* refactor: replace loop with while let for improved clarity and performance
* feat: add SSA constant propagation support to analysis context for improved accuracy
* feat: add SSA constant propagation support to analysis context for improved accuracy
* feat: implement shell metacharacter validation and bounded-length checks in Rust analysis
* feat: add static map analysis for command injection suppression and type safety
* refactor: simplify match statements and reduce line breaks for improved readability
* feat(summary): phase 1/5 SinkSite data model for primary sink-location attribution
Introduce SinkSite (file_rel, line, col, snippet, cap) carrying the
primary sink source-location through function summaries. Swap
SsaFuncSummary.param_to_sink and FuncSummary.param_to_sink from a coarse
Cap map to a deduped SmallVec<[SinkSite; 1]> per parameter, with a
backward-compatible cap_sites() helper and serde defaults so pre-phase-1
on-disk rows continue to deserialise cleanly.
Extraction: SinkSiteLocator bundles the tree/bytes/file_rel needed by
extract_ssa_func_summary; ParsedFile::extract_ssa_artifacts wires the
locator in for the persisted pass-1 path, while pass-2 intra-file
transient summaries fall back to cap-only sites (behavior unchanged).
Merge: GlobalSummaries::insert now unions sink sites with
(file_rel, line, col, cap) dedup via shared union_param_sink_sites
helper.
Database: JSON-serialised summary columns carry the new shape
automatically; no schema change needed.
Phase 2 will consume SinkSite in build_taint_diag() to overwrite the
caller-site Finding.line with the callee's sink line when resolved via
summary. Phase 1 keeps behavior unchanged: scanning
tests/benchmark/corpus/rust/cmdi/cmdi_indirect.rs still produces the
same (wrong) line 10 finding.
Adds round-trip tests covering SinkSite solo, SsaFuncSummary with sink
sites, legacy-JSON default handling for both summary types, and merge
dedup.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
* feat(taint): phase 2/5 thread SinkSite into SsaTaintEvent and Finding
Plumb Phase 1's SinkSite through the event pipeline into Findings,
no output change yet. SsaTaintEvent gains `primary_sink_site:
Option<SinkSite>`; when the main or callback sink-emission path has
non-empty `param_to_sink_sites`, filter to sites whose
`(line != 0) && (cap ∩ sink_caps != ∅)` and emit one event per
distinct site — the multi-primary collapse keeps each downstream
Finding single-primary.
Resolution: ResolvedSummary and SinkInfo gain mirror
`param_to_sink_sites` fields, populated from `SsaFuncSummary.param_to_sink`
(SSA + callback paths) and `FuncSummary.param_to_sink` (global paths).
Label, local-summary, and interop resolution paths leave the field
empty — they only ever had cap-level info to begin with.
Finding: new `primary_location: Option<SinkLocation>` with
`file_rel/line/col`. `ssa_events_to_findings` maps
`event.primary_sink_site` → `Finding.primary_location`, filtering
cap-only sites (`line == 0`) to `None` so the (0,0) sentinel never
leaks to formatters. Dedup key extended with the primary location
so multi-site events aren't collapsed back together.
Invariants (debug_assert!):
* every SinkSite reaching emission has `line != 0 && cap ∩ sink_caps
!= ∅` — enforced by the pick_primary_sink_sites* filters;
* every populated Finding.primary_location has `line != 0` AND
non-empty `file_rel` — the cap-only → None translation upstream
guarantees this.
Deliberately independent of `uses_summary`: that flag tracks whether
the *taint chain* used a summary, whereas primary attribution
requires only that the *sink* itself was summary-resolved. A local
source reaching a cross-file sink produces `uses_summary=false`
alongside a populated primary_location — documented on
Finding.primary_location, covered by
`cross_file_sink_finding_carries_primary_location`.
build_taint_diag, SARIF/JSON/explanation formatters, and the
benchmark scorer remain untouched: finding.line still comes from
`cfg_graph[finding.sink]`, so cmdi_indirect.rs still reports line 10
and the benchmark's rs-cmdi-003 row still shows FN in the LOC column.
Tests: `cross_file_sink_finding_carries_primary_location` (proves
plumbing via a synthetic FuncSummary carrying a SinkSite at 42:5) and
`cross_file_sink_cap_only_site_leaves_primary_location_none`
(regression guard against cap-only sites surfacing). All 1566 lib
tests + integration tests pass.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* feat(output): phase 3/5 consume primary sink location in diag + SARIF
When a finding's primary_location (populated in phase 2 from a callee
summary's SinkSite) names the dangerous instruction inside a callee
body, attribute the diagnostic line to that location instead of the
caller's call site. The call site is demoted to a Call step in
flow_steps, and a synthetic Sink step at the primary location is
appended so analysts still see the full trace.
Changes:
- Add scan_root parameter to build_taint_diag so file_rel can be
resolved back to an absolute path via a shared resolve_file_rel
helper. Empty file_rel (single-file scans where namespace == "")
resolves to the file under analysis.
- Extend SinkLocation with snippet, carried from the upstream
SinkSite so the formatter needs no second file read.
- Relax the ssa_events_to_findings debug_assert to allow empty
file_rel, which is valid when scan root equals the file itself.
- SARIF: emit data-flow as codeFlows[0].threadFlows[0].locations[];
locations[0] already reflects the primary sink position via the
updated diag line/col.
Acceptance: scan on tests/benchmark/corpus/rust/cmdi/cmdi_indirect.rs
now reports line 5 (Command::new) as the primary sink, with the call
site at line 10 visible in flow_steps.
Two expect.json fixtures updated (must_match line_range widened):
- javascript/taint/context_sensitive_call: 12-14 -> 7-14 (line 8 is
the real sink inside run()).
- rust/cfg/closure_async: 10-10 -> 10-11 (line 11 is Command::new
inside the closure).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* feat(bench): phase 4/5 validate primary sink attribution across corpus
Extend the benchmark scorer and ground truth to lock in phase 3's
primary-location behavior, and add fixtures that exercise the new
capability end-to-end.
Scorer (tests/benchmark_test.rs):
- Add optional `expected_call_site_lines: Option<Vec<[usize; 2]>>` on
Case. When present, score_location_level additionally requires at
least one flow_step in the finding's evidence trace to fall within
±2 of the call-site range. When absent, the check is skipped —
fully forward-compatible with existing fixtures.
- Retain ±2 tolerance on expected_sink_lines (compared against the
now-primary Diag.line post-phase-3).
Ground truth edits:
- rs-cmdi-cross-001: expected_sink_lines [8,8] -> [9,9]. Line 8 is the
transform::wrap call site (a cross-file propagator, not a sink);
line 9 is Command::new, the real sink. The ±2 tolerance happened to
mask this stale attribution but it was semantically wrong — phase 4
is the right time to correct it. Also adds expected_call_site_lines
[8,8] so the new field is exercised on an existing cross-file case.
- rs-cmdi-003: adds expected_call_site_lines [10,10] (run_cmd call).
This fixture's sink (Command::new inside run_cmd at line 5) was the
motivating case for phases 1-3; adding the call-site assertion
guards against regression to caller-line attribution.
New fixtures:
- rust/cmdi/cmdi_indirect_multisink.rs (rs-cmdi-009): helper run_both
takes two tainted params and invokes two Command sinks on
consecutive lines. Locks in that primary line lands inside the
helper (lines 5-6), not at the caller (line 12). Notes document
that SinkSite is currently one-per-callee so both findings today
collapse onto the first sink; expected_sink_lines=[5,6] and
expected_call_site_lines=[12,12] stay valid either way.
- python/cmdi/cross_indirect_sink/{app.py,helper.py} (py-cmdi-cross-
004): sink os.system lives in helper.py (cross-file), caller in
app.py reads env source and calls run_cmd. Verifies phase 3's
cross-file primary attribution: Diag.path = helper.py, Diag.line =
5, with app.py:7 recorded in flow_steps as a Call step.
Acceptance:
- `cargo test --test benchmark_test -- --ignored --nocapture` passes.
- rs-cmdi-003 is TP/TP/TP (the target flip FN->TP at LOC). All
pre-existing TP/TP/TP fixtures remain TP/TP/TP; 2 new fixtures are
TP/TP/TP.
- Aggregate rule-level: TP=158 FP=10 FN=1 TN=97, P=0.940 R=0.994
F1=0.966 on the 266-case corpus (was TP=156 FP=10 FN=1 TN=97 on
264 pre-phase-4, delta is the +2 new cases both resolving TP).
- Full `cargo test` green (1566 lib tests + all integration tests).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* feat(taint): phase 5/5 lock Finding.primary_location contract via regression test
Add a regression test in src/taint/ssa_transfer.rs that wires up a synthetic
SsaFuncSummary with a SinkSite at other.rs:42:10 and drives the three
emission stages (pick_primary_sink_sites → emit_ssa_taint_events →
ssa_events_to_findings) against a minimal caller SSA body. Asserts the
resulting Finding.primary_location is exactly that triple.
The existing integration tests in src/taint/tests.rs cover the coarse
FuncSummary path end-to-end through analyse_file. This test locks in the
lower-level SSA-side plumbing so a future refactor that silently drops the
site between pick → emit → findings fails here rather than only at the
benchmark layer.
Also refreshes tests/benchmark/results/latest.json (timestamp only; rs-cmdi-003
remains TP/TP/TP and the aggregate P/R/F1 are unchanged from phase 4).
Closes the primary sink-location attribution feature (phases 1-5/5):
* Phase 1 — SinkSite data model on summaries.
* Phase 2 — SinkSite threaded into SsaTaintEvent and Finding.
* Phase 3 — diag + SARIF consume primary_location.
* Phase 4 — benchmark validates primary_call_site_lines across corpus.
* Phase 5 — regression test locks the event→finding contract.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* refactor: clean up formatting and improve readability in multiple files
* refactor: simplify type definition for deduplication key in findings
* test(harness): add must_not_match expectation for FP regression guards
Extends ExpectedFinding with must_not_match field that asserts a
diagnostic must NOT fire — presence is a hard failure. Non-consuming
scan so it coexists with must_match entries on the same rule_id.
Adds forbidden_violations accumulator and updates summary line.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* feat(regression): update expectations to ensure must_not_match for various taint and resource leak rules
* feat: implement auto-seeding for JS/TS handler parameters to enhance taint tracking
* feat: update switch statement handling to improve control flow analysis
* feat: implement promisify alias handling for JS/TS to enhance taint tracking
* feat: enhance taint tracking by refining expectation handling and adding mode filtering
* feat: refine SQL handling in stream processing and enhance auto-seeding for handler parameters
* feat: update taint tracking rules to enforce full mode matching and improve flow analysis
* feat: enhance Ruby subshell handling to improve taint tracking and flow analysis
* feat: update xss_response expectations to refine taint flow analysis and enhance regression guarding
* feat: refine framework detection and update expectation handling for Echo and Sinatra
* feat: implement max_count for taint tracking expectations and deduplicate findings
* feat: add strict_unexpected handling for taint-unsanitised-flow in expectation files
* feat: enhance deduplication of taint-unsanitised-flow findings by collapsing based on line and severity
* feat: add strict_unexpected handling for taint-unsanitised-flow in multiple expectation files
* feat: add structural invariant checks for SSA bodies
* feat: ensure deterministic phi emission order using BTreeSet
* feat: enhance handling of terminators to ensure authoritative flow through successor edges
* feat: enhance Goto terminator handling to ensure all successors are marked executable
* feat: refactor code for improved readability and organization
* feat: simplify predicate checks and enhance readability in SSA handling
* feat: implement per-file parse timeout and enhance file size handling
* feat: migrate analysis engine toggles from environment variables to configuration file
* feat: remove unnecessary whitespace in hostile_input_tests.rs
* feat: remove unnecessary whitespace in hostile_input_tests.rs
* feat: update dependencies and enhance documentation on language maturity
* feat: enhance security headers and improve request body limits
* feat: implement sink capability bits for deduplication and enhance evidence tagging
* feat: implement dynamic activation handling for gated sinks and enhance validation logic
* feat: enhance configuration documentation and clarify inline analysis cache behavior
* feat: implement panic recovery during analysis to continue scans past errors
* feat: add expectations configuration for taint analysis and performance metrics
* feat: enhance error handling and logging during file reading and mutex locking
* feat: add cross-file body loading tests and plumbing for CF-1 phase
* feat: implement cross-file k=1 context-sensitive inline taint analysis with new tests and fixtures
* feat: implement indexed-scan parity in cross-file inline analysis with new dropdown and copy functionality
* feat: enhance classification span handling in CFG and AST for improved source attribution
* feat: add new Express routes for handling user input and telemetry data
* feat: implement ternary expression handling in CFG with diamond structure for JS/TS
* feat: implement Phase CF-3 abstract-domain transfer channels in summaries
* feat: add support for string-prefix transfer in cross-file calls and update tests
* docs: reduce RESULTS.md doc size
* feat: implement Phase CF-4 per-return-path summary decomposition with tests
* feat: update parameter handling in pass1 and refactor SsaFuncSummary initialization
* feat: implement Phase CF-5 for cross-file SCC joint fixed-point convergence with new flags and tests
* feat: implement Phase CF-6 with parameter-granularity points-to summaries and associated tests
* refactor: update comments and documentation for clarity and consistency
* style: format code for consistency and readability
* refactor: simplify verdict handling and improve edge checking logic
* refactor: optimize path and identifier collection by avoiding unnecessary cloning
* chore: update Cargo.toml for Rust version 1.85 and add ignored files; modify CHANGELOG and README for clarity on state analysis defaults
* refactor: update documentation and improve clarity in configuration files
* refactor: update documentation and improve clarity in configuration files
* feat: add JS/TS pass-2 convergence tests and expectations configuration
* feat: add Phase 5 regression tests for inline cache origin attribution and update related logic
* feat: implement Phase 7 deduplication and alternative path linking for taint findings
* feat: implement structural DFS index for anonymous functions and update naming conventions
* feat: add Phase 8 regression tests for container-element taint in JS and Python
* feat: add engine-depth profiles and explain-engine option for CLI
* feat: update expectations and add new README fixtures for multi-file scan regression
* feat: implement Phase 11 callback-alias and factory patterns with regression tests
* feat: implement Terminator::Switch for multi-way dispatch and add regression tests
* feat: add real-CVE benchmark fixtures for CVE-2023-48022, CVE-2019-14939, and CVE-2023-26159 with corresponding patched variants
* refactor: extract cfg and ssa_transfer to submodules
* refactor: cargo fmt
* refactor: remove unnecessary blank line in cfg_tests.rs
* refactor: remove unnecessary planning file
* chore: update Rust version to 1.88 and bump dependencies in Cargo files
* feat: enhance triage UI with new layout and controls, update README for clarity
* feat: enhance triage UI with new layout and controls, update README for clarity
* chore: remove outdated section from README for version 0.5.0
* docs: improve clarity and consistency in README content
* chore: add "GPL-3.0-or-later" to license options in about.toml
* chore: update license handling in about.toml and check-licenses.mjs
* style: format code for improved readability in TriagePage component
* style: format code for improved readability in TriagePage component
* chore: enhance license handling and improve body_id scoping in seed lookup
* feat: introduce owner and parent body IDs for enhanced seed scoping
* feat: implement direction-aware engine provenance with new CLI flag for strict CI gating
* feat: add Undef SSA operation for improved control-flow handling
* style: improve code formatting for consistency and readability in multiple files
* feat: add 16-function chain SCC across multiple files for enhanced analysis
* style: simplify code formatting for improved readability in multiple files
* fix: update CapHitReason default implementation and improve README clarity
* docs: enhance README with detailed explanations of taint analysis and limitations
* docs: refine README for clarity and consistency in taint analysis section
* style: improve code formatting for better readability in NewScanModal and scans
* fix: update cargo-about command to use --offline for deterministic license generation
* fix: update cargo-about command to use --offline for deterministic license generation
* ci: add step to prime cargo registry cache for deterministic license generation
* feat: add support for non-sink collections in authorization analysis
* feat: enhance authorization checks with row-level ownership equality and binding tracking
* feat: implement self-scoped user handling and enhance ownership checks
* refactor: simplify assertions and formatting in authorization analysis tests
* fix: normalize line endings in THIRDPARTY-LICENSES.html generation and update README with AI disclosure
* docs: update AI disclosure section for clarity and conciseness
* feat: add AI Contribution Policy and update contributing guidelines for AI assistance disclosure
* feat: enhance authorization analysis with SSA-derived variable type classification
* feat: implement auth_finding_to_diag function for enhanced security diagnostics
* feat: add args_value_refs to CallSite struct for enhanced argument tracking
* feat: add args_value_refs to CallSite struct for enhanced argument tracking
* feat: add direction-aware engine provenance with LossDirection classification and new CLI flag
* feat: simplify strip_cap_from_call_args call by removing unnecessary line breaks
* feat: enhance error message handling in cli_validation_tests for better Windows compatibility
* feat: optimize release profile settings in Cargo.toml and update CodeQL configuration
* feat: enhance release build process with SBOM generation and SLSA provenance
* feat: update actions/checkout and actions/setup-node to v6, enhance CLI options, and improve auth-check summaries
* feat: introduce PathFact handling for path safety checks and rejection logic
* feat: introduce PathFact handling for path safety checks and rejection logic
* feat: update benchmark data and enhance path sanitization logic with new safety checks
* feat: document AI assistance in frontend UI development and human review process
* feat: add return path facts for enhanced path safety checks and update documentation
* chore: update release date for version 0.5.0 in CHANGELOG.md
* chore: clean up ci.yml by removing outdated comments and clarifying steps
* feat: implement cross-language path sanitizers and validators for enhanced security
* feat: enhance SSA value usage tracking by including block terminators and improve path safety checks
* feat: enhance switch statement handling by adding per-case path constraints and support for exclusive cases
* refactor: simplify conditional formatting and improve code readability in executor and lower modules
* feat: add vulnerable examples for various languages demonstrating authentication and sanitization issues
* feat: enhance actor context recognition for self-actor identifiers and add support for global non-sink receivers
* feat: enhance actor context recognition for self-actor identifiers and add support for global non-sink receivers
* feat: add transform classifiers for Java, Go, and Ruby with corresponding tests
* refactor: clarify comments on reassign-to-constant idiom and sink behavior in guards.rs
---------
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
2026-04-25 17:59:11 -04:00
|
|
|
/// only inspect `targets`/`default`.
|
|
|
|
|
#[serde(default)]
|
|
|
|
|
case_values: SmallVec<[Option<ConstValue>; 4]>,
|
|
|
|
|
},
|
|
|
|
|
Return(Option<SsaValue>),
|
|
|
|
|
Unreachable,
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/// A basic block in SSA form.
|
|
|
|
|
#[derive(Clone, Debug, Serialize, Deserialize)]
|
|
|
|
|
pub struct SsaBlock {
|
|
|
|
|
pub id: BlockId,
|
|
|
|
|
/// Phi instructions (always at block start).
|
|
|
|
|
pub phis: Vec<SsaInst>,
|
|
|
|
|
/// Body instructions (after phis).
|
|
|
|
|
pub body: Vec<SsaInst>,
|
|
|
|
|
/// Block terminator.
|
|
|
|
|
pub terminator: Terminator,
|
|
|
|
|
/// Predecessor block IDs.
|
|
|
|
|
pub preds: SmallVec<[BlockId; 2]>,
|
|
|
|
|
/// Successor block IDs.
|
|
|
|
|
pub succs: SmallVec<[BlockId; 2]>,
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/// Per-value definition metadata.
|
|
|
|
|
#[derive(Clone, Debug, Serialize, Deserialize)]
|
|
|
|
|
pub struct ValueDef {
|
|
|
|
|
/// Original variable name (if any).
|
|
|
|
|
pub var_name: Option<String>,
|
|
|
|
|
/// The CFG node where this value was defined.
|
|
|
|
|
pub cfg_node: NodeIndex,
|
|
|
|
|
/// The block containing the definition.
|
|
|
|
|
pub block: BlockId,
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/// Complete SSA representation for a function/scope.
|
|
|
|
|
#[derive(Clone, Debug, Serialize, Deserialize)]
|
|
|
|
|
pub struct SsaBody {
|
|
|
|
|
/// All basic blocks, indexed by BlockId.
|
|
|
|
|
pub blocks: Vec<SsaBlock>,
|
|
|
|
|
/// Entry block.
|
|
|
|
|
pub entry: BlockId,
|
|
|
|
|
/// Per-SsaValue definition info, indexed by SsaValue.0.
|
|
|
|
|
pub value_defs: Vec<ValueDef>,
|
|
|
|
|
/// Map from original CFG NodeIndex to the primary SsaValue defined there.
|
|
|
|
|
pub cfg_node_map: std::collections::HashMap<NodeIndex, SsaValue>,
|
|
|
|
|
/// Exception edges: (source block, catch entry block).
|
|
|
|
|
/// Recorded during lowering when exception edges are stripped from the CFG.
|
|
|
|
|
/// Used by taint analysis to seed catch blocks with try-body taint state.
|
|
|
|
|
pub exception_edges: Vec<(BlockId, BlockId)>,
|
2026-04-29 00:58:38 -04:00
|
|
|
/// Per-body interner for [`SsaOp::FieldProj`] field names.
|
|
|
|
|
///
|
2026-04-29 19:53:34 -04:00
|
|
|
/// Empty until lowering emits FieldProj ops. Cross-body callers
|
|
|
|
|
/// (cross-file summaries, debug serialization) MUST resolve interned
|
|
|
|
|
/// ids through this interner before transporting field references
|
|
|
|
|
/// to other bodies.
|
2026-04-29 00:58:38 -04:00
|
|
|
#[serde(default)]
|
|
|
|
|
pub field_interner: FieldInterner,
|
2026-04-29 19:53:34 -04:00
|
|
|
/// Side-table mapping a synthetic base-update [`SsaOp::Assign`]'s
|
|
|
|
|
/// defined value back to the `(receiver, field)` pair it
|
|
|
|
|
/// represents. Populated by lowering at the `obj.f = rhs` synthesis
|
|
|
|
|
/// point so the taint engine can treat the synthetic assign as a
|
|
|
|
|
/// structural field WRITE.
|
2026-04-29 00:58:38 -04:00
|
|
|
///
|
|
|
|
|
/// Empty by default; only synthetic assigns whose enclosing source
|
|
|
|
|
/// statement was a dotted-path assignment (`a.b.c = …`) appear here.
|
|
|
|
|
/// Lookup is `O(log n)` worst case (`HashMap`), but the per-body
|
|
|
|
|
/// table is small (one entry per synthetic chain link).
|
|
|
|
|
///
|
|
|
|
|
/// Serialized via `#[serde(default)]` so pre-W1 SSA blobs decode
|
|
|
|
|
/// cleanly with an empty map (no migration needed).
|
|
|
|
|
#[serde(default)]
|
|
|
|
|
pub field_writes: HashMap<SsaValue, (SsaValue, FieldId)>,
|
2026-05-01 10:59:52 -04:00
|
|
|
/// SSA values that lowering injected for **free / closure-captured**
|
|
|
|
|
/// variables (variables referenced by the body but not declared as
|
|
|
|
|
/// formal parameters and not assigned within the body).
|
|
|
|
|
///
|
|
|
|
|
/// Lowering models every external use as an [`SsaOp::Param`] in block
|
|
|
|
|
/// 0 so the rename pass can reference it. Real formal parameters and
|
|
|
|
|
/// closure captures end up using the same op variant; this side-table
|
|
|
|
|
/// distinguishes the two so downstream analyses (in particular the
|
|
|
|
|
/// JS/TS handler-name auto-seed in
|
|
|
|
|
/// [`crate::taint::ssa_transfer`]) can avoid treating closure
|
|
|
|
|
/// captures as if they were the function's own parameters. Without
|
|
|
|
|
/// this distinction, a lambda body that references an out-of-scope
|
|
|
|
|
/// `userId` / `cmd` / `payload` would have the synthetic Param
|
|
|
|
|
/// auto-seeded as `UserInput`, producing a phantom source on the
|
|
|
|
|
/// enclosing function's declaration line.
|
|
|
|
|
///
|
|
|
|
|
/// `#[serde(default)]` for backward compatibility with summary blobs
|
|
|
|
|
/// produced before this field existed.
|
|
|
|
|
#[serde(default)]
|
|
|
|
|
pub synthetic_externals: HashSet<SsaValue>,
|
2026-05-11 12:42:39 -04:00
|
|
|
/// SSA values whose [`SsaOp::Assign`] is a slot-scoped binding from a
|
|
|
|
|
/// bare-array destructure rewrite (see `bare_array_ops` in
|
|
|
|
|
/// [`crate::ssa::lower`]). The Assign transfer arm in
|
|
|
|
|
/// [`crate::taint::ssa_transfer`] consults this set to skip the
|
|
|
|
|
/// `info.taint.labels` Source pickup that would otherwise bleed the
|
|
|
|
|
/// outer destructure node's Source label into the slot-scoped binding.
|
|
|
|
|
///
|
|
|
|
|
/// Operand union still runs normally, so transitive taint via an
|
|
|
|
|
/// inner ident (e.g. `helper(tainted_local)` in slot 1 of
|
|
|
|
|
/// `[req.body.other, helper(tainted_local)]`) propagates through the
|
|
|
|
|
/// Assign's operands without inheriting the outer-node Source.
|
|
|
|
|
///
|
|
|
|
|
/// Empty by default; only the per-slot kill arm in the bare-array
|
|
|
|
|
/// destructure lowering populates this set.
|
|
|
|
|
#[serde(default)]
|
|
|
|
|
pub slot_scoped_assigns: HashSet<SsaValue>,
|
Release/0.5.0 (#35)
* feat: Introduce function-scoped variable interning for state analysis with new tests and fixtures
* feat: Add Phase 26 symbolic execution enhancements with bitwise operator support, abstract interpretation refinements, and new taint analysis tests
* feat: Refine state analysis to handle factory-pattern resource returns with mixed-path tests and leak detection enhancements
* feat: Add Phase 27 debug views with symbolic execution, abstract interpretation, SSA, and call graph viewers; integrate with debug layout and styles
* feat: Add Phase 31 type-qualified symbolic resolution with receiver-based callee disambiguation and testing
* feat: Extend symbolic execution with state iteration, enhanced debug views, and debounced input handling
* feat: Add Phase 13 resource and auth pattern extensions with new tests and fixtures
* feat: Introduce CFG debug graph renderer with compact mode, toolbar, and DAG layout integration
* feat: Add Phase 28 encoding and decoding transform modeling with structural symex enhancements and new taint analysis tests
* feat: Extend abstract interpretation with type facts and constant value tracking in debug views and server logic
* feat: Add linear path handling and witness extraction to symbolic execution with Phase 28 transform mismatch detection
* feat: Refine Go auth and sanitizer handling with enhanced rules, state updates, and benchmark improvements
* feat: Enable auth-state analysis by default and update relevant tests in benchmark config
* test: Update state_tests to reflect default enablement of auth-state analysis and add auth suppression test
* docs: update CHANGELOG.md
* feat: Introduce per-index taint tracking in `HeapState` with `HeapSlot`, overflow handling, and revised SSA transfers
* feat: Introduce C/C++ language labels and refine heap state tracking in SSA transfers
* feat: Implement per-index array slot tracking in symbolic heap with overflow collapse
* feat: Add implicit definition handling for uninitialized declarations in SSA value allocation
* feat: Refactor function parameters and constants for improved clarity and maintainability
* refactor: Reorder module imports and improve formatting for consistency
* refactor: Fix formatting erorrs
* refactor: Fix clippy warnings
* refactor: Fix fmt warnings (again)
* chore: Update dependencies and improve feature configuration
* Add comprehensive tests for undertested modules (#36) (COPILOT)
* Add comprehensive tests for undertested modules
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/f3fc877e-f386-49ba-9793-fc93d3805083
* Add comprehensive tests for ext, project, walk, and errors modules
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/f3fc877e-f386-49ba-9793-fc93d3805083
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
* chore: Update dependencies and improve feature configuration
* fix: formatting errors in new tests
* chore: Update license list in about.toml
* chore: made functions input inline
* chore: updated cfg graph to take up the full page
* chore: add Prettier configuration and update code formatting
* Add frontend test suite with Vitest (111 tests) (#37)
* Add Vitest test suite for frontend - 111 tests across utils, components, hooks, and graph utilities
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/7cf0dba2-ecff-4740-ba4d-92717e74a0b7
* ci: add frontend test step to CI workflow
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/5bc0ac9f-0a32-4d03-9cb7-7a15aea53fca
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
* chore: simplify array initialization in test files for consistency
* ran typecheck
* feat: add AnalysisWorkspace component and integrate it into CfgViewerPage
* feat: update routing in AppLayout and improve empty state message in ExplorerPage
* feat: enhance scan progress tracking with additional metrics and stages
* feat: update license information and add license check script
* feat: implement cross-file symbolic execution with callee body persistence
* feat: replace dagre graphs with Graphology + ELK + Sigma for more advanced call stack and cfg rendering
* feat: ensure CFG function view is scoped to the selected function, preventing bleed into sibling functions
* feat: enhance resource tracking with proxy method summaries and improve finding extraction
* feat: add terminal function exit detection for accurate resource leak analysis
* feat: add warnings for loops and functions without bodies to improve error recovery
* feat: update lambda expression handling to ensure proper function classification and control flow
* feat: remove bounded formatting/string ops and add JSON.parse sanitizer for improved data handling
* feat: add inline return taint analysis and regression tests for improved security checks
* feat: add engine version management and migration handling for database schema updates
* feat: enhance first_call_ident to skip nested function bodies and add regression tests
* feat: enhance callee name resolution with two-segment normalization and disambiguation
* feat: add cross-file context flags and debug assertions for taint analysis
* feat: refactor taint analysis structure to unify context handling and improve clarity
* feat: enhance dead code elimination to preserve Sink, Source, and Sanitizer labels with new tests
* docs: updated CHANGELOG.md
* fmt: formatting fixes
* fix: fixed frontend formatting and lint warnings
* fix: optimized ci
* fix: optimized ci
* Add comprehensive multi-file test coverage to Nyx (#38)
* Initial checklist for multi-file test suite expansion
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/e550cb88-9767-4442-94d4-101bf5bb0e23
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
* Add 12 new multi-file test fixtures with TP/TN/near-miss coverage
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/e550cb88-9767-4442-94d4-101bf5bb0e23
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
* deleted root repo
* rebuilt to test for regressions
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
Co-authored-by: elipeter <elicpeter@gmail.com>
* feat: enhance import alias resolution and taint tracking
* feat: implement security hardening with CSRF protection and path validation
* feat: add support for import alias bindings in Python, PHP, and Rust
* feat: enhance CFG analysis modes and improve code readability
* feat: add detection for parameterized SQL queries to enhance security
* feat: add safe internal redirect handling and enhance session destroy validation
* feat: implement security improvements by addressing vulnerabilities in execAsync, session management, and file downloads
* feat: enhance taint detection by adding support for inline source member expressions in call arguments
* feat: implement pre-emission of Source nodes for inline source member expressions in call arguments
* feat: add support for Throw statement in control flow and error handling
* feat: add debug and echo endpoints with potential information leakage
* feat: implement internal redirect suppression and enhance taint detection
* feat: implement module alias tracking for dynamic dispatch in JS/TS
* feat: add authorization analysis module with Express support
* feat: add authorization analysis module with Express support
* feat: add tests for admin guard requirements and clean checks in authorization analysis
* feat: integrate Koa and Fastify frameworks into authorization analysis
* feat: add Flask and Django support to authorization analysis module
* feat: add support for Rails and Sinatra frameworks in authorization analysis
* feat: add support for Axum, ActixWeb, and Rocket frameworks in authorization analysis
* feat: add support for ActixWeb, Axum, and Rocket frameworks in authorization analysis
* feat: add support for Rails and Sinatra in authorization analysis
* chore: add .DS_Store to .gitignore
* refactor: simplify conditional checks and improve readability in multiple files
* refactor: update usage of Option methods for improved clarity and consistency
* refactor: improve code readability by simplifying conditional checks and formatting
* refactor: improve code formatting and readability by simplifying conditional checks
* refactor: simplify conditional checks and improve readability in multiple files
* refactor: simplify conditional checks in axum.rs for improved readability
* feat: add CodeQL analysis configuration for enhanced security scanning
* test: add comprehensive tests for `src/output.rs` SARIF builder (#39)
* chore: start test coverage improvement work
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/cd7ff398-134e-4728-a5e7-0353a0744423
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
* test: add comprehensive tests for src/output.rs SARIF builder
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/cd7ff398-134e-4728-a5e7-0353a0744423
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
* refactor: improve code formatting and readability in output.rs
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
Co-authored-by: elipeter <elicpeter@gmail.com>
* refactor: improve code formatting and readability in output.rs
* Potential fix for code scanning alert no. 210: Uncontrolled data used in path expression
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
* Potential fix for code scanning alert no. 211: Uncontrolled data used in path expression
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
* refactor: enhance triage file path handling with improved error management and validation
* refactor: updated func summaries for richer detail
* refactor: update SSA summary extraction to use canonical FuncKey for distinct entries
* refactor: enhance callee metadata structure to support arity, receiver, and qualifier for better overload resolution
* refactor: add support for keyword arguments in function calls and enhance receiver extraction for method-style calls
* refactor: implement new Flask routes for safe and unsafe shell command execution
* refactor: separate receiver handling in SSA operations and enhance taint propagation
* refactor: improve arity handling by using arg_uses for positional argument count and enhance witness scoring for tainted arguments
* refactor: implement auth decorator extraction and classification for multiple languages
* refactor: enhance Rust module path resolution and use map handling for cross-file disambiguation
* refactor: introduce CalleeQuery struct for structured callee resolution and enhance resolver logic
* refactor: implement same-file identity collision handling for `runTask` to ensure correct resolver behavior
* refactor: standardize default struct initialization across multiple files
* feat: add scripts for formatting checks and auto-fixes with test summaries
* refactor: simplify character splitting and enhance namespace qualifier handling
* refactor: improve documentation clarity and enhance code readability in resolver logic
* refactor: replace default struct initialization with explicit field assignments for clarity
* feat: enhance anonymous function naming by deriving context-based bindings
* refactor: streamline match expressions for improved readability and performance
* refactor: streamline match expressions for improved readability and performance
* refactor: replace loop with while let for improved clarity and performance
* feat: add SSA constant propagation support to analysis context for improved accuracy
* feat: add SSA constant propagation support to analysis context for improved accuracy
* feat: implement shell metacharacter validation and bounded-length checks in Rust analysis
* feat: add static map analysis for command injection suppression and type safety
* refactor: simplify match statements and reduce line breaks for improved readability
* feat(summary): phase 1/5 SinkSite data model for primary sink-location attribution
Introduce SinkSite (file_rel, line, col, snippet, cap) carrying the
primary sink source-location through function summaries. Swap
SsaFuncSummary.param_to_sink and FuncSummary.param_to_sink from a coarse
Cap map to a deduped SmallVec<[SinkSite; 1]> per parameter, with a
backward-compatible cap_sites() helper and serde defaults so pre-phase-1
on-disk rows continue to deserialise cleanly.
Extraction: SinkSiteLocator bundles the tree/bytes/file_rel needed by
extract_ssa_func_summary; ParsedFile::extract_ssa_artifacts wires the
locator in for the persisted pass-1 path, while pass-2 intra-file
transient summaries fall back to cap-only sites (behavior unchanged).
Merge: GlobalSummaries::insert now unions sink sites with
(file_rel, line, col, cap) dedup via shared union_param_sink_sites
helper.
Database: JSON-serialised summary columns carry the new shape
automatically; no schema change needed.
Phase 2 will consume SinkSite in build_taint_diag() to overwrite the
caller-site Finding.line with the callee's sink line when resolved via
summary. Phase 1 keeps behavior unchanged: scanning
tests/benchmark/corpus/rust/cmdi/cmdi_indirect.rs still produces the
same (wrong) line 10 finding.
Adds round-trip tests covering SinkSite solo, SsaFuncSummary with sink
sites, legacy-JSON default handling for both summary types, and merge
dedup.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
* feat(taint): phase 2/5 thread SinkSite into SsaTaintEvent and Finding
Plumb Phase 1's SinkSite through the event pipeline into Findings,
no output change yet. SsaTaintEvent gains `primary_sink_site:
Option<SinkSite>`; when the main or callback sink-emission path has
non-empty `param_to_sink_sites`, filter to sites whose
`(line != 0) && (cap ∩ sink_caps != ∅)` and emit one event per
distinct site — the multi-primary collapse keeps each downstream
Finding single-primary.
Resolution: ResolvedSummary and SinkInfo gain mirror
`param_to_sink_sites` fields, populated from `SsaFuncSummary.param_to_sink`
(SSA + callback paths) and `FuncSummary.param_to_sink` (global paths).
Label, local-summary, and interop resolution paths leave the field
empty — they only ever had cap-level info to begin with.
Finding: new `primary_location: Option<SinkLocation>` with
`file_rel/line/col`. `ssa_events_to_findings` maps
`event.primary_sink_site` → `Finding.primary_location`, filtering
cap-only sites (`line == 0`) to `None` so the (0,0) sentinel never
leaks to formatters. Dedup key extended with the primary location
so multi-site events aren't collapsed back together.
Invariants (debug_assert!):
* every SinkSite reaching emission has `line != 0 && cap ∩ sink_caps
!= ∅` — enforced by the pick_primary_sink_sites* filters;
* every populated Finding.primary_location has `line != 0` AND
non-empty `file_rel` — the cap-only → None translation upstream
guarantees this.
Deliberately independent of `uses_summary`: that flag tracks whether
the *taint chain* used a summary, whereas primary attribution
requires only that the *sink* itself was summary-resolved. A local
source reaching a cross-file sink produces `uses_summary=false`
alongside a populated primary_location — documented on
Finding.primary_location, covered by
`cross_file_sink_finding_carries_primary_location`.
build_taint_diag, SARIF/JSON/explanation formatters, and the
benchmark scorer remain untouched: finding.line still comes from
`cfg_graph[finding.sink]`, so cmdi_indirect.rs still reports line 10
and the benchmark's rs-cmdi-003 row still shows FN in the LOC column.
Tests: `cross_file_sink_finding_carries_primary_location` (proves
plumbing via a synthetic FuncSummary carrying a SinkSite at 42:5) and
`cross_file_sink_cap_only_site_leaves_primary_location_none`
(regression guard against cap-only sites surfacing). All 1566 lib
tests + integration tests pass.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* feat(output): phase 3/5 consume primary sink location in diag + SARIF
When a finding's primary_location (populated in phase 2 from a callee
summary's SinkSite) names the dangerous instruction inside a callee
body, attribute the diagnostic line to that location instead of the
caller's call site. The call site is demoted to a Call step in
flow_steps, and a synthetic Sink step at the primary location is
appended so analysts still see the full trace.
Changes:
- Add scan_root parameter to build_taint_diag so file_rel can be
resolved back to an absolute path via a shared resolve_file_rel
helper. Empty file_rel (single-file scans where namespace == "")
resolves to the file under analysis.
- Extend SinkLocation with snippet, carried from the upstream
SinkSite so the formatter needs no second file read.
- Relax the ssa_events_to_findings debug_assert to allow empty
file_rel, which is valid when scan root equals the file itself.
- SARIF: emit data-flow as codeFlows[0].threadFlows[0].locations[];
locations[0] already reflects the primary sink position via the
updated diag line/col.
Acceptance: scan on tests/benchmark/corpus/rust/cmdi/cmdi_indirect.rs
now reports line 5 (Command::new) as the primary sink, with the call
site at line 10 visible in flow_steps.
Two expect.json fixtures updated (must_match line_range widened):
- javascript/taint/context_sensitive_call: 12-14 -> 7-14 (line 8 is
the real sink inside run()).
- rust/cfg/closure_async: 10-10 -> 10-11 (line 11 is Command::new
inside the closure).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* feat(bench): phase 4/5 validate primary sink attribution across corpus
Extend the benchmark scorer and ground truth to lock in phase 3's
primary-location behavior, and add fixtures that exercise the new
capability end-to-end.
Scorer (tests/benchmark_test.rs):
- Add optional `expected_call_site_lines: Option<Vec<[usize; 2]>>` on
Case. When present, score_location_level additionally requires at
least one flow_step in the finding's evidence trace to fall within
±2 of the call-site range. When absent, the check is skipped —
fully forward-compatible with existing fixtures.
- Retain ±2 tolerance on expected_sink_lines (compared against the
now-primary Diag.line post-phase-3).
Ground truth edits:
- rs-cmdi-cross-001: expected_sink_lines [8,8] -> [9,9]. Line 8 is the
transform::wrap call site (a cross-file propagator, not a sink);
line 9 is Command::new, the real sink. The ±2 tolerance happened to
mask this stale attribution but it was semantically wrong — phase 4
is the right time to correct it. Also adds expected_call_site_lines
[8,8] so the new field is exercised on an existing cross-file case.
- rs-cmdi-003: adds expected_call_site_lines [10,10] (run_cmd call).
This fixture's sink (Command::new inside run_cmd at line 5) was the
motivating case for phases 1-3; adding the call-site assertion
guards against regression to caller-line attribution.
New fixtures:
- rust/cmdi/cmdi_indirect_multisink.rs (rs-cmdi-009): helper run_both
takes two tainted params and invokes two Command sinks on
consecutive lines. Locks in that primary line lands inside the
helper (lines 5-6), not at the caller (line 12). Notes document
that SinkSite is currently one-per-callee so both findings today
collapse onto the first sink; expected_sink_lines=[5,6] and
expected_call_site_lines=[12,12] stay valid either way.
- python/cmdi/cross_indirect_sink/{app.py,helper.py} (py-cmdi-cross-
004): sink os.system lives in helper.py (cross-file), caller in
app.py reads env source and calls run_cmd. Verifies phase 3's
cross-file primary attribution: Diag.path = helper.py, Diag.line =
5, with app.py:7 recorded in flow_steps as a Call step.
Acceptance:
- `cargo test --test benchmark_test -- --ignored --nocapture` passes.
- rs-cmdi-003 is TP/TP/TP (the target flip FN->TP at LOC). All
pre-existing TP/TP/TP fixtures remain TP/TP/TP; 2 new fixtures are
TP/TP/TP.
- Aggregate rule-level: TP=158 FP=10 FN=1 TN=97, P=0.940 R=0.994
F1=0.966 on the 266-case corpus (was TP=156 FP=10 FN=1 TN=97 on
264 pre-phase-4, delta is the +2 new cases both resolving TP).
- Full `cargo test` green (1566 lib tests + all integration tests).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* feat(taint): phase 5/5 lock Finding.primary_location contract via regression test
Add a regression test in src/taint/ssa_transfer.rs that wires up a synthetic
SsaFuncSummary with a SinkSite at other.rs:42:10 and drives the three
emission stages (pick_primary_sink_sites → emit_ssa_taint_events →
ssa_events_to_findings) against a minimal caller SSA body. Asserts the
resulting Finding.primary_location is exactly that triple.
The existing integration tests in src/taint/tests.rs cover the coarse
FuncSummary path end-to-end through analyse_file. This test locks in the
lower-level SSA-side plumbing so a future refactor that silently drops the
site between pick → emit → findings fails here rather than only at the
benchmark layer.
Also refreshes tests/benchmark/results/latest.json (timestamp only; rs-cmdi-003
remains TP/TP/TP and the aggregate P/R/F1 are unchanged from phase 4).
Closes the primary sink-location attribution feature (phases 1-5/5):
* Phase 1 — SinkSite data model on summaries.
* Phase 2 — SinkSite threaded into SsaTaintEvent and Finding.
* Phase 3 — diag + SARIF consume primary_location.
* Phase 4 — benchmark validates primary_call_site_lines across corpus.
* Phase 5 — regression test locks the event→finding contract.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* refactor: clean up formatting and improve readability in multiple files
* refactor: simplify type definition for deduplication key in findings
* test(harness): add must_not_match expectation for FP regression guards
Extends ExpectedFinding with must_not_match field that asserts a
diagnostic must NOT fire — presence is a hard failure. Non-consuming
scan so it coexists with must_match entries on the same rule_id.
Adds forbidden_violations accumulator and updates summary line.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* feat(regression): update expectations to ensure must_not_match for various taint and resource leak rules
* feat: implement auto-seeding for JS/TS handler parameters to enhance taint tracking
* feat: update switch statement handling to improve control flow analysis
* feat: implement promisify alias handling for JS/TS to enhance taint tracking
* feat: enhance taint tracking by refining expectation handling and adding mode filtering
* feat: refine SQL handling in stream processing and enhance auto-seeding for handler parameters
* feat: update taint tracking rules to enforce full mode matching and improve flow analysis
* feat: enhance Ruby subshell handling to improve taint tracking and flow analysis
* feat: update xss_response expectations to refine taint flow analysis and enhance regression guarding
* feat: refine framework detection and update expectation handling for Echo and Sinatra
* feat: implement max_count for taint tracking expectations and deduplicate findings
* feat: add strict_unexpected handling for taint-unsanitised-flow in expectation files
* feat: enhance deduplication of taint-unsanitised-flow findings by collapsing based on line and severity
* feat: add strict_unexpected handling for taint-unsanitised-flow in multiple expectation files
* feat: add structural invariant checks for SSA bodies
* feat: ensure deterministic phi emission order using BTreeSet
* feat: enhance handling of terminators to ensure authoritative flow through successor edges
* feat: enhance Goto terminator handling to ensure all successors are marked executable
* feat: refactor code for improved readability and organization
* feat: simplify predicate checks and enhance readability in SSA handling
* feat: implement per-file parse timeout and enhance file size handling
* feat: migrate analysis engine toggles from environment variables to configuration file
* feat: remove unnecessary whitespace in hostile_input_tests.rs
* feat: remove unnecessary whitespace in hostile_input_tests.rs
* feat: update dependencies and enhance documentation on language maturity
* feat: enhance security headers and improve request body limits
* feat: implement sink capability bits for deduplication and enhance evidence tagging
* feat: implement dynamic activation handling for gated sinks and enhance validation logic
* feat: enhance configuration documentation and clarify inline analysis cache behavior
* feat: implement panic recovery during analysis to continue scans past errors
* feat: add expectations configuration for taint analysis and performance metrics
* feat: enhance error handling and logging during file reading and mutex locking
* feat: add cross-file body loading tests and plumbing for CF-1 phase
* feat: implement cross-file k=1 context-sensitive inline taint analysis with new tests and fixtures
* feat: implement indexed-scan parity in cross-file inline analysis with new dropdown and copy functionality
* feat: enhance classification span handling in CFG and AST for improved source attribution
* feat: add new Express routes for handling user input and telemetry data
* feat: implement ternary expression handling in CFG with diamond structure for JS/TS
* feat: implement Phase CF-3 abstract-domain transfer channels in summaries
* feat: add support for string-prefix transfer in cross-file calls and update tests
* docs: reduce RESULTS.md doc size
* feat: implement Phase CF-4 per-return-path summary decomposition with tests
* feat: update parameter handling in pass1 and refactor SsaFuncSummary initialization
* feat: implement Phase CF-5 for cross-file SCC joint fixed-point convergence with new flags and tests
* feat: implement Phase CF-6 with parameter-granularity points-to summaries and associated tests
* refactor: update comments and documentation for clarity and consistency
* style: format code for consistency and readability
* refactor: simplify verdict handling and improve edge checking logic
* refactor: optimize path and identifier collection by avoiding unnecessary cloning
* chore: update Cargo.toml for Rust version 1.85 and add ignored files; modify CHANGELOG and README for clarity on state analysis defaults
* refactor: update documentation and improve clarity in configuration files
* refactor: update documentation and improve clarity in configuration files
* feat: add JS/TS pass-2 convergence tests and expectations configuration
* feat: add Phase 5 regression tests for inline cache origin attribution and update related logic
* feat: implement Phase 7 deduplication and alternative path linking for taint findings
* feat: implement structural DFS index for anonymous functions and update naming conventions
* feat: add Phase 8 regression tests for container-element taint in JS and Python
* feat: add engine-depth profiles and explain-engine option for CLI
* feat: update expectations and add new README fixtures for multi-file scan regression
* feat: implement Phase 11 callback-alias and factory patterns with regression tests
* feat: implement Terminator::Switch for multi-way dispatch and add regression tests
* feat: add real-CVE benchmark fixtures for CVE-2023-48022, CVE-2019-14939, and CVE-2023-26159 with corresponding patched variants
* refactor: extract cfg and ssa_transfer to submodules
* refactor: cargo fmt
* refactor: remove unnecessary blank line in cfg_tests.rs
* refactor: remove unnecessary planning file
* chore: update Rust version to 1.88 and bump dependencies in Cargo files
* feat: enhance triage UI with new layout and controls, update README for clarity
* feat: enhance triage UI with new layout and controls, update README for clarity
* chore: remove outdated section from README for version 0.5.0
* docs: improve clarity and consistency in README content
* chore: add "GPL-3.0-or-later" to license options in about.toml
* chore: update license handling in about.toml and check-licenses.mjs
* style: format code for improved readability in TriagePage component
* style: format code for improved readability in TriagePage component
* chore: enhance license handling and improve body_id scoping in seed lookup
* feat: introduce owner and parent body IDs for enhanced seed scoping
* feat: implement direction-aware engine provenance with new CLI flag for strict CI gating
* feat: add Undef SSA operation for improved control-flow handling
* style: improve code formatting for consistency and readability in multiple files
* feat: add 16-function chain SCC across multiple files for enhanced analysis
* style: simplify code formatting for improved readability in multiple files
* fix: update CapHitReason default implementation and improve README clarity
* docs: enhance README with detailed explanations of taint analysis and limitations
* docs: refine README for clarity and consistency in taint analysis section
* style: improve code formatting for better readability in NewScanModal and scans
* fix: update cargo-about command to use --offline for deterministic license generation
* fix: update cargo-about command to use --offline for deterministic license generation
* ci: add step to prime cargo registry cache for deterministic license generation
* feat: add support for non-sink collections in authorization analysis
* feat: enhance authorization checks with row-level ownership equality and binding tracking
* feat: implement self-scoped user handling and enhance ownership checks
* refactor: simplify assertions and formatting in authorization analysis tests
* fix: normalize line endings in THIRDPARTY-LICENSES.html generation and update README with AI disclosure
* docs: update AI disclosure section for clarity and conciseness
* feat: add AI Contribution Policy and update contributing guidelines for AI assistance disclosure
* feat: enhance authorization analysis with SSA-derived variable type classification
* feat: implement auth_finding_to_diag function for enhanced security diagnostics
* feat: add args_value_refs to CallSite struct for enhanced argument tracking
* feat: add args_value_refs to CallSite struct for enhanced argument tracking
* feat: add direction-aware engine provenance with LossDirection classification and new CLI flag
* feat: simplify strip_cap_from_call_args call by removing unnecessary line breaks
* feat: enhance error message handling in cli_validation_tests for better Windows compatibility
* feat: optimize release profile settings in Cargo.toml and update CodeQL configuration
* feat: enhance release build process with SBOM generation and SLSA provenance
* feat: update actions/checkout and actions/setup-node to v6, enhance CLI options, and improve auth-check summaries
* feat: introduce PathFact handling for path safety checks and rejection logic
* feat: introduce PathFact handling for path safety checks and rejection logic
* feat: update benchmark data and enhance path sanitization logic with new safety checks
* feat: document AI assistance in frontend UI development and human review process
* feat: add return path facts for enhanced path safety checks and update documentation
* chore: update release date for version 0.5.0 in CHANGELOG.md
* chore: clean up ci.yml by removing outdated comments and clarifying steps
* feat: implement cross-language path sanitizers and validators for enhanced security
* feat: enhance SSA value usage tracking by including block terminators and improve path safety checks
* feat: enhance switch statement handling by adding per-case path constraints and support for exclusive cases
* refactor: simplify conditional formatting and improve code readability in executor and lower modules
* feat: add vulnerable examples for various languages demonstrating authentication and sanitization issues
* feat: enhance actor context recognition for self-actor identifiers and add support for global non-sink receivers
* feat: enhance actor context recognition for self-actor identifiers and add support for global non-sink receivers
* feat: add transform classifiers for Java, Go, and Ruby with corresponding tests
* refactor: clarify comments on reassign-to-constant idiom and sink behavior in guards.rs
---------
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
2026-04-25 17:59:11 -04:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
impl SsaBody {
|
|
|
|
|
/// Get a block by its ID.
|
|
|
|
|
pub fn block(&self, id: BlockId) -> &SsaBlock {
|
|
|
|
|
&self.blocks[id.0 as usize]
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/// Get a mutable block by its ID.
|
|
|
|
|
pub fn block_mut(&mut self, id: BlockId) -> &mut SsaBlock {
|
|
|
|
|
&mut self.blocks[id.0 as usize]
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/// Total number of SSA values.
|
|
|
|
|
pub fn num_values(&self) -> usize {
|
|
|
|
|
self.value_defs.len()
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/// Look up definition info for an SSA value.
|
|
|
|
|
pub fn def_of(&self, v: SsaValue) -> &ValueDef {
|
|
|
|
|
&self.value_defs[v.0 as usize]
|
|
|
|
|
}
|
2026-04-29 00:58:38 -04:00
|
|
|
|
|
|
|
|
/// Resolve a [`FieldId`] back to the interned field name within this body.
|
|
|
|
|
pub fn field_name(&self, id: FieldId) -> &str {
|
|
|
|
|
self.field_interner.resolve(id)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/// Intern a field name in this body's [`FieldInterner`], returning its
|
|
|
|
|
/// stable [`FieldId`].
|
|
|
|
|
pub fn intern_field(&mut self, name: &str) -> FieldId {
|
|
|
|
|
self.field_interner.intern(name)
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
impl SsaInst {
|
|
|
|
|
/// Iterate over the SSA values used (read) by this instruction.
|
|
|
|
|
///
|
|
|
|
|
/// Yields receiver/operand values for `Call`, `Phi`, `Assign`, and
|
|
|
|
|
/// `FieldProj`; nothing for leaf ops (`Const`, `Param`, `Source`, etc.).
|
|
|
|
|
/// Callers that need the values as a `Vec` should `.collect()`.
|
|
|
|
|
pub fn uses_iter(&self) -> SmallVec<[SsaValue; 4]> {
|
|
|
|
|
match &self.op {
|
|
|
|
|
SsaOp::Phi(operands) => operands.iter().map(|(_, v)| *v).collect(),
|
|
|
|
|
SsaOp::Assign(uses) => uses.iter().copied().collect(),
|
|
|
|
|
SsaOp::Call { args, receiver, .. } => {
|
|
|
|
|
let mut out: SmallVec<[SsaValue; 4]> = SmallVec::new();
|
|
|
|
|
if let Some(rv) = receiver {
|
|
|
|
|
out.push(*rv);
|
|
|
|
|
}
|
|
|
|
|
for arg in args {
|
|
|
|
|
out.extend(arg.iter().copied());
|
|
|
|
|
}
|
|
|
|
|
out
|
|
|
|
|
}
|
|
|
|
|
SsaOp::FieldProj { receiver, .. } => {
|
|
|
|
|
let mut out: SmallVec<[SsaValue; 4]> = SmallVec::new();
|
|
|
|
|
out.push(*receiver);
|
|
|
|
|
out
|
|
|
|
|
}
|
|
|
|
|
SsaOp::Source
|
|
|
|
|
| SsaOp::Const(_)
|
|
|
|
|
| SsaOp::Param { .. }
|
|
|
|
|
| SsaOp::SelfParam
|
|
|
|
|
| SsaOp::CatchParam
|
|
|
|
|
| SsaOp::Nop
|
|
|
|
|
| SsaOp::Undef => SmallVec::new(),
|
|
|
|
|
}
|
|
|
|
|
}
|
Release/0.5.0 (#35)
* feat: Introduce function-scoped variable interning for state analysis with new tests and fixtures
* feat: Add Phase 26 symbolic execution enhancements with bitwise operator support, abstract interpretation refinements, and new taint analysis tests
* feat: Refine state analysis to handle factory-pattern resource returns with mixed-path tests and leak detection enhancements
* feat: Add Phase 27 debug views with symbolic execution, abstract interpretation, SSA, and call graph viewers; integrate with debug layout and styles
* feat: Add Phase 31 type-qualified symbolic resolution with receiver-based callee disambiguation and testing
* feat: Extend symbolic execution with state iteration, enhanced debug views, and debounced input handling
* feat: Add Phase 13 resource and auth pattern extensions with new tests and fixtures
* feat: Introduce CFG debug graph renderer with compact mode, toolbar, and DAG layout integration
* feat: Add Phase 28 encoding and decoding transform modeling with structural symex enhancements and new taint analysis tests
* feat: Extend abstract interpretation with type facts and constant value tracking in debug views and server logic
* feat: Add linear path handling and witness extraction to symbolic execution with Phase 28 transform mismatch detection
* feat: Refine Go auth and sanitizer handling with enhanced rules, state updates, and benchmark improvements
* feat: Enable auth-state analysis by default and update relevant tests in benchmark config
* test: Update state_tests to reflect default enablement of auth-state analysis and add auth suppression test
* docs: update CHANGELOG.md
* feat: Introduce per-index taint tracking in `HeapState` with `HeapSlot`, overflow handling, and revised SSA transfers
* feat: Introduce C/C++ language labels and refine heap state tracking in SSA transfers
* feat: Implement per-index array slot tracking in symbolic heap with overflow collapse
* feat: Add implicit definition handling for uninitialized declarations in SSA value allocation
* feat: Refactor function parameters and constants for improved clarity and maintainability
* refactor: Reorder module imports and improve formatting for consistency
* refactor: Fix formatting erorrs
* refactor: Fix clippy warnings
* refactor: Fix fmt warnings (again)
* chore: Update dependencies and improve feature configuration
* Add comprehensive tests for undertested modules (#36) (COPILOT)
* Add comprehensive tests for undertested modules
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/f3fc877e-f386-49ba-9793-fc93d3805083
* Add comprehensive tests for ext, project, walk, and errors modules
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/f3fc877e-f386-49ba-9793-fc93d3805083
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
* chore: Update dependencies and improve feature configuration
* fix: formatting errors in new tests
* chore: Update license list in about.toml
* chore: made functions input inline
* chore: updated cfg graph to take up the full page
* chore: add Prettier configuration and update code formatting
* Add frontend test suite with Vitest (111 tests) (#37)
* Add Vitest test suite for frontend - 111 tests across utils, components, hooks, and graph utilities
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/7cf0dba2-ecff-4740-ba4d-92717e74a0b7
* ci: add frontend test step to CI workflow
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/5bc0ac9f-0a32-4d03-9cb7-7a15aea53fca
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
* chore: simplify array initialization in test files for consistency
* ran typecheck
* feat: add AnalysisWorkspace component and integrate it into CfgViewerPage
* feat: update routing in AppLayout and improve empty state message in ExplorerPage
* feat: enhance scan progress tracking with additional metrics and stages
* feat: update license information and add license check script
* feat: implement cross-file symbolic execution with callee body persistence
* feat: replace dagre graphs with Graphology + ELK + Sigma for more advanced call stack and cfg rendering
* feat: ensure CFG function view is scoped to the selected function, preventing bleed into sibling functions
* feat: enhance resource tracking with proxy method summaries and improve finding extraction
* feat: add terminal function exit detection for accurate resource leak analysis
* feat: add warnings for loops and functions without bodies to improve error recovery
* feat: update lambda expression handling to ensure proper function classification and control flow
* feat: remove bounded formatting/string ops and add JSON.parse sanitizer for improved data handling
* feat: add inline return taint analysis and regression tests for improved security checks
* feat: add engine version management and migration handling for database schema updates
* feat: enhance first_call_ident to skip nested function bodies and add regression tests
* feat: enhance callee name resolution with two-segment normalization and disambiguation
* feat: add cross-file context flags and debug assertions for taint analysis
* feat: refactor taint analysis structure to unify context handling and improve clarity
* feat: enhance dead code elimination to preserve Sink, Source, and Sanitizer labels with new tests
* docs: updated CHANGELOG.md
* fmt: formatting fixes
* fix: fixed frontend formatting and lint warnings
* fix: optimized ci
* fix: optimized ci
* Add comprehensive multi-file test coverage to Nyx (#38)
* Initial checklist for multi-file test suite expansion
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/e550cb88-9767-4442-94d4-101bf5bb0e23
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
* Add 12 new multi-file test fixtures with TP/TN/near-miss coverage
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/e550cb88-9767-4442-94d4-101bf5bb0e23
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
* deleted root repo
* rebuilt to test for regressions
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
Co-authored-by: elipeter <elicpeter@gmail.com>
* feat: enhance import alias resolution and taint tracking
* feat: implement security hardening with CSRF protection and path validation
* feat: add support for import alias bindings in Python, PHP, and Rust
* feat: enhance CFG analysis modes and improve code readability
* feat: add detection for parameterized SQL queries to enhance security
* feat: add safe internal redirect handling and enhance session destroy validation
* feat: implement security improvements by addressing vulnerabilities in execAsync, session management, and file downloads
* feat: enhance taint detection by adding support for inline source member expressions in call arguments
* feat: implement pre-emission of Source nodes for inline source member expressions in call arguments
* feat: add support for Throw statement in control flow and error handling
* feat: add debug and echo endpoints with potential information leakage
* feat: implement internal redirect suppression and enhance taint detection
* feat: implement module alias tracking for dynamic dispatch in JS/TS
* feat: add authorization analysis module with Express support
* feat: add authorization analysis module with Express support
* feat: add tests for admin guard requirements and clean checks in authorization analysis
* feat: integrate Koa and Fastify frameworks into authorization analysis
* feat: add Flask and Django support to authorization analysis module
* feat: add support for Rails and Sinatra frameworks in authorization analysis
* feat: add support for Axum, ActixWeb, and Rocket frameworks in authorization analysis
* feat: add support for ActixWeb, Axum, and Rocket frameworks in authorization analysis
* feat: add support for Rails and Sinatra in authorization analysis
* chore: add .DS_Store to .gitignore
* refactor: simplify conditional checks and improve readability in multiple files
* refactor: update usage of Option methods for improved clarity and consistency
* refactor: improve code readability by simplifying conditional checks and formatting
* refactor: improve code formatting and readability by simplifying conditional checks
* refactor: simplify conditional checks and improve readability in multiple files
* refactor: simplify conditional checks in axum.rs for improved readability
* feat: add CodeQL analysis configuration for enhanced security scanning
* test: add comprehensive tests for `src/output.rs` SARIF builder (#39)
* chore: start test coverage improvement work
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/cd7ff398-134e-4728-a5e7-0353a0744423
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
* test: add comprehensive tests for src/output.rs SARIF builder
Agent-Logs-Url: https://github.com/elicpeter/nyx/sessions/cd7ff398-134e-4728-a5e7-0353a0744423
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
* refactor: improve code formatting and readability in output.rs
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: elicpeter <54954007+elicpeter@users.noreply.github.com>
Co-authored-by: elipeter <elicpeter@gmail.com>
* refactor: improve code formatting and readability in output.rs
* Potential fix for code scanning alert no. 210: Uncontrolled data used in path expression
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
* Potential fix for code scanning alert no. 211: Uncontrolled data used in path expression
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
* refactor: enhance triage file path handling with improved error management and validation
* refactor: updated func summaries for richer detail
* refactor: update SSA summary extraction to use canonical FuncKey for distinct entries
* refactor: enhance callee metadata structure to support arity, receiver, and qualifier for better overload resolution
* refactor: add support for keyword arguments in function calls and enhance receiver extraction for method-style calls
* refactor: implement new Flask routes for safe and unsafe shell command execution
* refactor: separate receiver handling in SSA operations and enhance taint propagation
* refactor: improve arity handling by using arg_uses for positional argument count and enhance witness scoring for tainted arguments
* refactor: implement auth decorator extraction and classification for multiple languages
* refactor: enhance Rust module path resolution and use map handling for cross-file disambiguation
* refactor: introduce CalleeQuery struct for structured callee resolution and enhance resolver logic
* refactor: implement same-file identity collision handling for `runTask` to ensure correct resolver behavior
* refactor: standardize default struct initialization across multiple files
* feat: add scripts for formatting checks and auto-fixes with test summaries
* refactor: simplify character splitting and enhance namespace qualifier handling
* refactor: improve documentation clarity and enhance code readability in resolver logic
* refactor: replace default struct initialization with explicit field assignments for clarity
* feat: enhance anonymous function naming by deriving context-based bindings
* refactor: streamline match expressions for improved readability and performance
* refactor: streamline match expressions for improved readability and performance
* refactor: replace loop with while let for improved clarity and performance
* feat: add SSA constant propagation support to analysis context for improved accuracy
* feat: add SSA constant propagation support to analysis context for improved accuracy
* feat: implement shell metacharacter validation and bounded-length checks in Rust analysis
* feat: add static map analysis for command injection suppression and type safety
* refactor: simplify match statements and reduce line breaks for improved readability
* feat(summary): phase 1/5 SinkSite data model for primary sink-location attribution
Introduce SinkSite (file_rel, line, col, snippet, cap) carrying the
primary sink source-location through function summaries. Swap
SsaFuncSummary.param_to_sink and FuncSummary.param_to_sink from a coarse
Cap map to a deduped SmallVec<[SinkSite; 1]> per parameter, with a
backward-compatible cap_sites() helper and serde defaults so pre-phase-1
on-disk rows continue to deserialise cleanly.
Extraction: SinkSiteLocator bundles the tree/bytes/file_rel needed by
extract_ssa_func_summary; ParsedFile::extract_ssa_artifacts wires the
locator in for the persisted pass-1 path, while pass-2 intra-file
transient summaries fall back to cap-only sites (behavior unchanged).
Merge: GlobalSummaries::insert now unions sink sites with
(file_rel, line, col, cap) dedup via shared union_param_sink_sites
helper.
Database: JSON-serialised summary columns carry the new shape
automatically; no schema change needed.
Phase 2 will consume SinkSite in build_taint_diag() to overwrite the
caller-site Finding.line with the callee's sink line when resolved via
summary. Phase 1 keeps behavior unchanged: scanning
tests/benchmark/corpus/rust/cmdi/cmdi_indirect.rs still produces the
same (wrong) line 10 finding.
Adds round-trip tests covering SinkSite solo, SsaFuncSummary with sink
sites, legacy-JSON default handling for both summary types, and merge
dedup.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
* feat(taint): phase 2/5 thread SinkSite into SsaTaintEvent and Finding
Plumb Phase 1's SinkSite through the event pipeline into Findings,
no output change yet. SsaTaintEvent gains `primary_sink_site:
Option<SinkSite>`; when the main or callback sink-emission path has
non-empty `param_to_sink_sites`, filter to sites whose
`(line != 0) && (cap ∩ sink_caps != ∅)` and emit one event per
distinct site — the multi-primary collapse keeps each downstream
Finding single-primary.
Resolution: ResolvedSummary and SinkInfo gain mirror
`param_to_sink_sites` fields, populated from `SsaFuncSummary.param_to_sink`
(SSA + callback paths) and `FuncSummary.param_to_sink` (global paths).
Label, local-summary, and interop resolution paths leave the field
empty — they only ever had cap-level info to begin with.
Finding: new `primary_location: Option<SinkLocation>` with
`file_rel/line/col`. `ssa_events_to_findings` maps
`event.primary_sink_site` → `Finding.primary_location`, filtering
cap-only sites (`line == 0`) to `None` so the (0,0) sentinel never
leaks to formatters. Dedup key extended with the primary location
so multi-site events aren't collapsed back together.
Invariants (debug_assert!):
* every SinkSite reaching emission has `line != 0 && cap ∩ sink_caps
!= ∅` — enforced by the pick_primary_sink_sites* filters;
* every populated Finding.primary_location has `line != 0` AND
non-empty `file_rel` — the cap-only → None translation upstream
guarantees this.
Deliberately independent of `uses_summary`: that flag tracks whether
the *taint chain* used a summary, whereas primary attribution
requires only that the *sink* itself was summary-resolved. A local
source reaching a cross-file sink produces `uses_summary=false`
alongside a populated primary_location — documented on
Finding.primary_location, covered by
`cross_file_sink_finding_carries_primary_location`.
build_taint_diag, SARIF/JSON/explanation formatters, and the
benchmark scorer remain untouched: finding.line still comes from
`cfg_graph[finding.sink]`, so cmdi_indirect.rs still reports line 10
and the benchmark's rs-cmdi-003 row still shows FN in the LOC column.
Tests: `cross_file_sink_finding_carries_primary_location` (proves
plumbing via a synthetic FuncSummary carrying a SinkSite at 42:5) and
`cross_file_sink_cap_only_site_leaves_primary_location_none`
(regression guard against cap-only sites surfacing). All 1566 lib
tests + integration tests pass.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* feat(output): phase 3/5 consume primary sink location in diag + SARIF
When a finding's primary_location (populated in phase 2 from a callee
summary's SinkSite) names the dangerous instruction inside a callee
body, attribute the diagnostic line to that location instead of the
caller's call site. The call site is demoted to a Call step in
flow_steps, and a synthetic Sink step at the primary location is
appended so analysts still see the full trace.
Changes:
- Add scan_root parameter to build_taint_diag so file_rel can be
resolved back to an absolute path via a shared resolve_file_rel
helper. Empty file_rel (single-file scans where namespace == "")
resolves to the file under analysis.
- Extend SinkLocation with snippet, carried from the upstream
SinkSite so the formatter needs no second file read.
- Relax the ssa_events_to_findings debug_assert to allow empty
file_rel, which is valid when scan root equals the file itself.
- SARIF: emit data-flow as codeFlows[0].threadFlows[0].locations[];
locations[0] already reflects the primary sink position via the
updated diag line/col.
Acceptance: scan on tests/benchmark/corpus/rust/cmdi/cmdi_indirect.rs
now reports line 5 (Command::new) as the primary sink, with the call
site at line 10 visible in flow_steps.
Two expect.json fixtures updated (must_match line_range widened):
- javascript/taint/context_sensitive_call: 12-14 -> 7-14 (line 8 is
the real sink inside run()).
- rust/cfg/closure_async: 10-10 -> 10-11 (line 11 is Command::new
inside the closure).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* feat(bench): phase 4/5 validate primary sink attribution across corpus
Extend the benchmark scorer and ground truth to lock in phase 3's
primary-location behavior, and add fixtures that exercise the new
capability end-to-end.
Scorer (tests/benchmark_test.rs):
- Add optional `expected_call_site_lines: Option<Vec<[usize; 2]>>` on
Case. When present, score_location_level additionally requires at
least one flow_step in the finding's evidence trace to fall within
±2 of the call-site range. When absent, the check is skipped —
fully forward-compatible with existing fixtures.
- Retain ±2 tolerance on expected_sink_lines (compared against the
now-primary Diag.line post-phase-3).
Ground truth edits:
- rs-cmdi-cross-001: expected_sink_lines [8,8] -> [9,9]. Line 8 is the
transform::wrap call site (a cross-file propagator, not a sink);
line 9 is Command::new, the real sink. The ±2 tolerance happened to
mask this stale attribution but it was semantically wrong — phase 4
is the right time to correct it. Also adds expected_call_site_lines
[8,8] so the new field is exercised on an existing cross-file case.
- rs-cmdi-003: adds expected_call_site_lines [10,10] (run_cmd call).
This fixture's sink (Command::new inside run_cmd at line 5) was the
motivating case for phases 1-3; adding the call-site assertion
guards against regression to caller-line attribution.
New fixtures:
- rust/cmdi/cmdi_indirect_multisink.rs (rs-cmdi-009): helper run_both
takes two tainted params and invokes two Command sinks on
consecutive lines. Locks in that primary line lands inside the
helper (lines 5-6), not at the caller (line 12). Notes document
that SinkSite is currently one-per-callee so both findings today
collapse onto the first sink; expected_sink_lines=[5,6] and
expected_call_site_lines=[12,12] stay valid either way.
- python/cmdi/cross_indirect_sink/{app.py,helper.py} (py-cmdi-cross-
004): sink os.system lives in helper.py (cross-file), caller in
app.py reads env source and calls run_cmd. Verifies phase 3's
cross-file primary attribution: Diag.path = helper.py, Diag.line =
5, with app.py:7 recorded in flow_steps as a Call step.
Acceptance:
- `cargo test --test benchmark_test -- --ignored --nocapture` passes.
- rs-cmdi-003 is TP/TP/TP (the target flip FN->TP at LOC). All
pre-existing TP/TP/TP fixtures remain TP/TP/TP; 2 new fixtures are
TP/TP/TP.
- Aggregate rule-level: TP=158 FP=10 FN=1 TN=97, P=0.940 R=0.994
F1=0.966 on the 266-case corpus (was TP=156 FP=10 FN=1 TN=97 on
264 pre-phase-4, delta is the +2 new cases both resolving TP).
- Full `cargo test` green (1566 lib tests + all integration tests).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* feat(taint): phase 5/5 lock Finding.primary_location contract via regression test
Add a regression test in src/taint/ssa_transfer.rs that wires up a synthetic
SsaFuncSummary with a SinkSite at other.rs:42:10 and drives the three
emission stages (pick_primary_sink_sites → emit_ssa_taint_events →
ssa_events_to_findings) against a minimal caller SSA body. Asserts the
resulting Finding.primary_location is exactly that triple.
The existing integration tests in src/taint/tests.rs cover the coarse
FuncSummary path end-to-end through analyse_file. This test locks in the
lower-level SSA-side plumbing so a future refactor that silently drops the
site between pick → emit → findings fails here rather than only at the
benchmark layer.
Also refreshes tests/benchmark/results/latest.json (timestamp only; rs-cmdi-003
remains TP/TP/TP and the aggregate P/R/F1 are unchanged from phase 4).
Closes the primary sink-location attribution feature (phases 1-5/5):
* Phase 1 — SinkSite data model on summaries.
* Phase 2 — SinkSite threaded into SsaTaintEvent and Finding.
* Phase 3 — diag + SARIF consume primary_location.
* Phase 4 — benchmark validates primary_call_site_lines across corpus.
* Phase 5 — regression test locks the event→finding contract.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* refactor: clean up formatting and improve readability in multiple files
* refactor: simplify type definition for deduplication key in findings
* test(harness): add must_not_match expectation for FP regression guards
Extends ExpectedFinding with must_not_match field that asserts a
diagnostic must NOT fire — presence is a hard failure. Non-consuming
scan so it coexists with must_match entries on the same rule_id.
Adds forbidden_violations accumulator and updates summary line.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* feat(regression): update expectations to ensure must_not_match for various taint and resource leak rules
* feat: implement auto-seeding for JS/TS handler parameters to enhance taint tracking
* feat: update switch statement handling to improve control flow analysis
* feat: implement promisify alias handling for JS/TS to enhance taint tracking
* feat: enhance taint tracking by refining expectation handling and adding mode filtering
* feat: refine SQL handling in stream processing and enhance auto-seeding for handler parameters
* feat: update taint tracking rules to enforce full mode matching and improve flow analysis
* feat: enhance Ruby subshell handling to improve taint tracking and flow analysis
* feat: update xss_response expectations to refine taint flow analysis and enhance regression guarding
* feat: refine framework detection and update expectation handling for Echo and Sinatra
* feat: implement max_count for taint tracking expectations and deduplicate findings
* feat: add strict_unexpected handling for taint-unsanitised-flow in expectation files
* feat: enhance deduplication of taint-unsanitised-flow findings by collapsing based on line and severity
* feat: add strict_unexpected handling for taint-unsanitised-flow in multiple expectation files
* feat: add structural invariant checks for SSA bodies
* feat: ensure deterministic phi emission order using BTreeSet
* feat: enhance handling of terminators to ensure authoritative flow through successor edges
* feat: enhance Goto terminator handling to ensure all successors are marked executable
* feat: refactor code for improved readability and organization
* feat: simplify predicate checks and enhance readability in SSA handling
* feat: implement per-file parse timeout and enhance file size handling
* feat: migrate analysis engine toggles from environment variables to configuration file
* feat: remove unnecessary whitespace in hostile_input_tests.rs
* feat: remove unnecessary whitespace in hostile_input_tests.rs
* feat: update dependencies and enhance documentation on language maturity
* feat: enhance security headers and improve request body limits
* feat: implement sink capability bits for deduplication and enhance evidence tagging
* feat: implement dynamic activation handling for gated sinks and enhance validation logic
* feat: enhance configuration documentation and clarify inline analysis cache behavior
* feat: implement panic recovery during analysis to continue scans past errors
* feat: add expectations configuration for taint analysis and performance metrics
* feat: enhance error handling and logging during file reading and mutex locking
* feat: add cross-file body loading tests and plumbing for CF-1 phase
* feat: implement cross-file k=1 context-sensitive inline taint analysis with new tests and fixtures
* feat: implement indexed-scan parity in cross-file inline analysis with new dropdown and copy functionality
* feat: enhance classification span handling in CFG and AST for improved source attribution
* feat: add new Express routes for handling user input and telemetry data
* feat: implement ternary expression handling in CFG with diamond structure for JS/TS
* feat: implement Phase CF-3 abstract-domain transfer channels in summaries
* feat: add support for string-prefix transfer in cross-file calls and update tests
* docs: reduce RESULTS.md doc size
* feat: implement Phase CF-4 per-return-path summary decomposition with tests
* feat: update parameter handling in pass1 and refactor SsaFuncSummary initialization
* feat: implement Phase CF-5 for cross-file SCC joint fixed-point convergence with new flags and tests
* feat: implement Phase CF-6 with parameter-granularity points-to summaries and associated tests
* refactor: update comments and documentation for clarity and consistency
* style: format code for consistency and readability
* refactor: simplify verdict handling and improve edge checking logic
* refactor: optimize path and identifier collection by avoiding unnecessary cloning
* chore: update Cargo.toml for Rust version 1.85 and add ignored files; modify CHANGELOG and README for clarity on state analysis defaults
* refactor: update documentation and improve clarity in configuration files
* refactor: update documentation and improve clarity in configuration files
* feat: add JS/TS pass-2 convergence tests and expectations configuration
* feat: add Phase 5 regression tests for inline cache origin attribution and update related logic
* feat: implement Phase 7 deduplication and alternative path linking for taint findings
* feat: implement structural DFS index for anonymous functions and update naming conventions
* feat: add Phase 8 regression tests for container-element taint in JS and Python
* feat: add engine-depth profiles and explain-engine option for CLI
* feat: update expectations and add new README fixtures for multi-file scan regression
* feat: implement Phase 11 callback-alias and factory patterns with regression tests
* feat: implement Terminator::Switch for multi-way dispatch and add regression tests
* feat: add real-CVE benchmark fixtures for CVE-2023-48022, CVE-2019-14939, and CVE-2023-26159 with corresponding patched variants
* refactor: extract cfg and ssa_transfer to submodules
* refactor: cargo fmt
* refactor: remove unnecessary blank line in cfg_tests.rs
* refactor: remove unnecessary planning file
* chore: update Rust version to 1.88 and bump dependencies in Cargo files
* feat: enhance triage UI with new layout and controls, update README for clarity
* feat: enhance triage UI with new layout and controls, update README for clarity
* chore: remove outdated section from README for version 0.5.0
* docs: improve clarity and consistency in README content
* chore: add "GPL-3.0-or-later" to license options in about.toml
* chore: update license handling in about.toml and check-licenses.mjs
* style: format code for improved readability in TriagePage component
* style: format code for improved readability in TriagePage component
* chore: enhance license handling and improve body_id scoping in seed lookup
* feat: introduce owner and parent body IDs for enhanced seed scoping
* feat: implement direction-aware engine provenance with new CLI flag for strict CI gating
* feat: add Undef SSA operation for improved control-flow handling
* style: improve code formatting for consistency and readability in multiple files
* feat: add 16-function chain SCC across multiple files for enhanced analysis
* style: simplify code formatting for improved readability in multiple files
* fix: update CapHitReason default implementation and improve README clarity
* docs: enhance README with detailed explanations of taint analysis and limitations
* docs: refine README for clarity and consistency in taint analysis section
* style: improve code formatting for better readability in NewScanModal and scans
* fix: update cargo-about command to use --offline for deterministic license generation
* fix: update cargo-about command to use --offline for deterministic license generation
* ci: add step to prime cargo registry cache for deterministic license generation
* feat: add support for non-sink collections in authorization analysis
* feat: enhance authorization checks with row-level ownership equality and binding tracking
* feat: implement self-scoped user handling and enhance ownership checks
* refactor: simplify assertions and formatting in authorization analysis tests
* fix: normalize line endings in THIRDPARTY-LICENSES.html generation and update README with AI disclosure
* docs: update AI disclosure section for clarity and conciseness
* feat: add AI Contribution Policy and update contributing guidelines for AI assistance disclosure
* feat: enhance authorization analysis with SSA-derived variable type classification
* feat: implement auth_finding_to_diag function for enhanced security diagnostics
* feat: add args_value_refs to CallSite struct for enhanced argument tracking
* feat: add args_value_refs to CallSite struct for enhanced argument tracking
* feat: add direction-aware engine provenance with LossDirection classification and new CLI flag
* feat: simplify strip_cap_from_call_args call by removing unnecessary line breaks
* feat: enhance error message handling in cli_validation_tests for better Windows compatibility
* feat: optimize release profile settings in Cargo.toml and update CodeQL configuration
* feat: enhance release build process with SBOM generation and SLSA provenance
* feat: update actions/checkout and actions/setup-node to v6, enhance CLI options, and improve auth-check summaries
* feat: introduce PathFact handling for path safety checks and rejection logic
* feat: introduce PathFact handling for path safety checks and rejection logic
* feat: update benchmark data and enhance path sanitization logic with new safety checks
* feat: document AI assistance in frontend UI development and human review process
* feat: add return path facts for enhanced path safety checks and update documentation
* chore: update release date for version 0.5.0 in CHANGELOG.md
* chore: clean up ci.yml by removing outdated comments and clarifying steps
* feat: implement cross-language path sanitizers and validators for enhanced security
* feat: enhance SSA value usage tracking by including block terminators and improve path safety checks
* feat: enhance switch statement handling by adding per-case path constraints and support for exclusive cases
* refactor: simplify conditional formatting and improve code readability in executor and lower modules
* feat: add vulnerable examples for various languages demonstrating authentication and sanitization issues
* feat: enhance actor context recognition for self-actor identifiers and add support for global non-sink receivers
* feat: enhance actor context recognition for self-actor identifiers and add support for global non-sink receivers
* feat: add transform classifiers for Java, Go, and Ruby with corresponding tests
* refactor: clarify comments on reassign-to-constant idiom and sink behavior in guards.rs
---------
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
2026-04-25 17:59:11 -04:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/// Errors that can occur during SSA lowering.
|
|
|
|
|
#[derive(Debug, Clone)]
|
|
|
|
|
pub enum SsaError {
|
|
|
|
|
/// The CFG has no reachable nodes from the entry.
|
|
|
|
|
EmptyCfg,
|
|
|
|
|
/// Entry node not found in the CFG.
|
|
|
|
|
InvalidEntry,
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
impl std::fmt::Display for SsaError {
|
|
|
|
|
fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
|
|
|
|
|
match self {
|
|
|
|
|
SsaError::EmptyCfg => write!(f, "CFG has no reachable nodes"),
|
|
|
|
|
SsaError::InvalidEntry => write!(f, "entry node not found in CFG"),
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
impl std::error::Error for SsaError {}
|
2026-04-29 00:58:38 -04:00
|
|
|
|
|
|
|
|
#[cfg(test)]
|
|
|
|
|
mod tests {
|
|
|
|
|
use super::*;
|
|
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
|
fn field_interner_dedupes_names() {
|
|
|
|
|
let mut interner = FieldInterner::new();
|
|
|
|
|
let a = interner.intern("mu");
|
|
|
|
|
let b = interner.intern("mu");
|
|
|
|
|
let c = interner.intern("writer");
|
|
|
|
|
assert_eq!(a, b, "interning same name twice yields same id");
|
|
|
|
|
assert_ne!(a, c, "different names get different ids");
|
|
|
|
|
assert_eq!(interner.resolve(a), "mu");
|
|
|
|
|
assert_eq!(interner.resolve(c), "writer");
|
|
|
|
|
assert_eq!(interner.len(), 2);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
|
fn field_interner_serde_roundtrip_rebuilds_lookup() {
|
|
|
|
|
let mut interner = FieldInterner::new();
|
|
|
|
|
let a = interner.intern("mu");
|
|
|
|
|
let b = interner.intern("writer");
|
|
|
|
|
let json = serde_json::to_string(&interner).expect("serialize");
|
|
|
|
|
let mut restored: FieldInterner = serde_json::from_str(&json).expect("deserialize");
|
|
|
|
|
assert_eq!(restored.resolve(a), "mu");
|
|
|
|
|
assert_eq!(restored.resolve(b), "writer");
|
|
|
|
|
// After ensure_lookup, intern("mu") returns the original id (not a new one).
|
|
|
|
|
restored.ensure_lookup();
|
|
|
|
|
assert_eq!(restored.intern("mu"), a);
|
|
|
|
|
assert_eq!(restored.intern("header"), FieldId(2));
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
|
fn field_proj_use_iter_includes_receiver() {
|
|
|
|
|
let inst = SsaInst {
|
|
|
|
|
value: SsaValue(3),
|
|
|
|
|
op: SsaOp::FieldProj {
|
|
|
|
|
receiver: SsaValue(1),
|
|
|
|
|
field: FieldId(0),
|
|
|
|
|
projected_type: None,
|
|
|
|
|
},
|
|
|
|
|
cfg_node: NodeIndex::new(0),
|
|
|
|
|
var_name: Some("c.mu".into()),
|
|
|
|
|
span: (0, 0),
|
|
|
|
|
};
|
|
|
|
|
let uses: Vec<SsaValue> = inst.uses_iter().into_iter().collect();
|
|
|
|
|
assert_eq!(uses, vec![SsaValue(1)]);
|
|
|
|
|
}
|
|
|
|
|
|
2026-04-29 19:53:34 -04:00
|
|
|
/// the [`FieldId::ELEM`] sentinel is
|
2026-04-29 00:58:38 -04:00
|
|
|
/// reserved for "any element of a container". The interner assigns
|
|
|
|
|
/// IDs monotonically from `0`, so the sentinel `u32::MAX` can only
|
2026-04-29 19:53:34 -04:00
|
|
|
/// collide if the body declares ~4 billion fields, a corner case
|
2026-04-29 00:58:38 -04:00
|
|
|
/// no realistic codebase reaches. Pin the contract with a stress
|
|
|
|
|
/// loop so future implementation drift can't silently shift IDs to
|
|
|
|
|
/// the sentinel value.
|
|
|
|
|
#[test]
|
|
|
|
|
fn field_interner_never_assigns_elem_sentinel() {
|
|
|
|
|
let mut interner = FieldInterner::new();
|
|
|
|
|
for i in 0..1024 {
|
|
|
|
|
let id = interner.intern(&format!("f{i}"));
|
|
|
|
|
assert_ne!(
|
|
|
|
|
id,
|
|
|
|
|
FieldId::ELEM,
|
|
|
|
|
"intern('f{i}') yielded the ELEM sentinel — invariant broken",
|
|
|
|
|
);
|
|
|
|
|
}
|
|
|
|
|
// Lookup of the sentinel name (used by W3 to round-trip
|
|
|
|
|
// container-element flow through summary) must NOT match a
|
|
|
|
|
// real interned name even when the same name is interned.
|
2026-04-29 19:53:34 -04:00
|
|
|
// The wire-format keeps `<elem>` as a *string marker*, it
|
2026-04-29 00:58:38 -04:00
|
|
|
// never goes through `intern`. Instead, callers compare
|
|
|
|
|
// explicitly against `FieldId::ELEM`.
|
|
|
|
|
assert_ne!(interner.intern("<elem>"), FieldId::ELEM);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/// A6: the `<elem>` marker round-trips through extraction →
|
|
|
|
|
/// SQLite → caller-side translation without colliding with a
|
|
|
|
|
/// caller-interned `<elem>` field. When a caller's body has its
|
|
|
|
|
/// own `<elem>` field, that gets a regular FieldId, distinct from
|
|
|
|
|
/// the sentinel.
|
|
|
|
|
#[test]
|
|
|
|
|
fn elem_marker_distinct_from_interner_assigned_id() {
|
|
|
|
|
let mut interner = FieldInterner::new();
|
|
|
|
|
let lit_elem = interner.intern("<elem>");
|
|
|
|
|
// Sentinel still compares equal to itself only.
|
|
|
|
|
assert_eq!(FieldId::ELEM, FieldId(u32::MAX));
|
|
|
|
|
assert_ne!(lit_elem, FieldId::ELEM);
|
|
|
|
|
// Resolve the literal-string id back to its interned name.
|
|
|
|
|
assert_eq!(interner.resolve(lit_elem), "<elem>");
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
|
fn field_proj_serde_roundtrip_with_field_name() {
|
|
|
|
|
// Build a tiny body with one FieldProj op and check that the
|
|
|
|
|
// body's interner survives round-trip and the id resolves back
|
|
|
|
|
// to the original name.
|
|
|
|
|
let mut body = SsaBody {
|
|
|
|
|
blocks: vec![SsaBlock {
|
|
|
|
|
id: BlockId(0),
|
|
|
|
|
phis: vec![],
|
|
|
|
|
body: vec![],
|
|
|
|
|
terminator: Terminator::Return(None),
|
|
|
|
|
preds: SmallVec::new(),
|
|
|
|
|
succs: SmallVec::new(),
|
|
|
|
|
}],
|
|
|
|
|
entry: BlockId(0),
|
|
|
|
|
value_defs: vec![ValueDef {
|
|
|
|
|
var_name: Some("c".into()),
|
|
|
|
|
cfg_node: NodeIndex::new(0),
|
|
|
|
|
block: BlockId(0),
|
|
|
|
|
}],
|
|
|
|
|
cfg_node_map: HashMap::new(),
|
|
|
|
|
exception_edges: vec![],
|
|
|
|
|
field_interner: FieldInterner::new(),
|
|
|
|
|
field_writes: HashMap::new(),
|
2026-05-01 10:59:52 -04:00
|
|
|
synthetic_externals: HashSet::new(),
|
2026-05-11 12:42:39 -04:00
|
|
|
slot_scoped_assigns: HashSet::new(),
|
2026-04-29 00:58:38 -04:00
|
|
|
};
|
|
|
|
|
let fid = body.intern_field("mu");
|
|
|
|
|
body.blocks[0].body.push(SsaInst {
|
|
|
|
|
value: SsaValue(1),
|
|
|
|
|
op: SsaOp::FieldProj {
|
|
|
|
|
receiver: SsaValue(0),
|
|
|
|
|
field: fid,
|
|
|
|
|
projected_type: None,
|
|
|
|
|
},
|
|
|
|
|
cfg_node: NodeIndex::new(0),
|
|
|
|
|
var_name: Some("c.mu".into()),
|
|
|
|
|
span: (0, 0),
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
let json = serde_json::to_string(&body).expect("serialize body");
|
|
|
|
|
let restored: SsaBody = serde_json::from_str(&json).expect("deserialize body");
|
|
|
|
|
|
|
|
|
|
let inst = &restored.blocks[0].body[0];
|
|
|
|
|
match &inst.op {
|
|
|
|
|
SsaOp::FieldProj {
|
|
|
|
|
receiver, field, ..
|
|
|
|
|
} => {
|
|
|
|
|
assert_eq!(*receiver, SsaValue(0));
|
|
|
|
|
assert_eq!(restored.field_name(*field), "mu");
|
|
|
|
|
}
|
|
|
|
|
other => panic!("expected FieldProj, got {other:?}"),
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|