2026-05-18 01:08:32 -05:00
|
|
|
//! Java [`super::super::FrameworkAdapter`] matching HTTP response-
|
|
|
|
|
//! header CRLF-injection sink constructions
|
|
|
|
|
//! (`HttpServletResponse.setHeader` / `addHeader`).
|
|
|
|
|
//!
|
|
|
|
|
//! Phase 08 (Track J.6). Fires when the function body invokes one
|
|
|
|
|
//! of the canonical servlet response-writer entry points and the
|
|
|
|
|
//! surrounding source imports a servlet API.
|
|
|
|
|
|
|
|
|
|
use crate::dynamic::framework::{FrameworkAdapter, FrameworkBinding};
|
|
|
|
|
use crate::evidence::EntryKind;
|
|
|
|
|
use crate::summary::FuncSummary;
|
|
|
|
|
use crate::symbol::Lang;
|
|
|
|
|
|
|
|
|
|
pub struct HeaderJavaAdapter;
|
|
|
|
|
|
|
|
|
|
const ADAPTER_NAME: &str = "header-java";
|
|
|
|
|
|
|
|
|
|
fn callee_is_header_setter(name: &str) -> bool {
|
|
|
|
|
let last = name.rsplit_once('.').map(|(_, s)| s).unwrap_or(name);
|
2026-05-21 14:35:42 -05:00
|
|
|
matches!(
|
|
|
|
|
last,
|
|
|
|
|
"setHeader"
|
|
|
|
|
| "addHeader"
|
|
|
|
|
| "setDateHeader"
|
|
|
|
|
| "addDateHeader"
|
|
|
|
|
| "setIntHeader"
|
|
|
|
|
| "addIntHeader"
|
|
|
|
|
)
|
2026-05-18 01:08:32 -05:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
fn source_imports_servlet(file_bytes: &[u8]) -> bool {
|
|
|
|
|
const NEEDLES: &[&[u8]] = &[
|
|
|
|
|
b"javax.servlet",
|
|
|
|
|
b"jakarta.servlet",
|
|
|
|
|
b"HttpServletResponse",
|
|
|
|
|
b"ServerHttpResponse",
|
|
|
|
|
b"org.springframework.http",
|
|
|
|
|
];
|
|
|
|
|
NEEDLES
|
|
|
|
|
.iter()
|
|
|
|
|
.any(|n| file_bytes.windows(n.len()).any(|w| w == *n))
|
|
|
|
|
}
|
|
|
|
|
|
2026-05-21 01:36:46 -05:00
|
|
|
/// Returns `true` when the surrounding source visibly routes the
|
|
|
|
|
/// header value through a canonical URL-encoder / HTML-escaper. The
|
|
|
|
|
/// header-setter then receives a CRLF-free string and cannot smuggle
|
|
|
|
|
/// a second header.
|
|
|
|
|
fn value_routed_through_encoder(file_bytes: &[u8]) -> bool {
|
|
|
|
|
const ENCODER_CALLS: &[&[u8]] = &[
|
|
|
|
|
b"URLEncoder.encode(",
|
|
|
|
|
b"Encode.forHtml(",
|
|
|
|
|
b"Encode.forHtmlAttribute(",
|
|
|
|
|
b"Encode.forUri(",
|
|
|
|
|
b"Encode.forUriComponent(",
|
|
|
|
|
b"escapeHtml(",
|
|
|
|
|
b"escapeHtml4(",
|
|
|
|
|
b"escapeXml(",
|
|
|
|
|
b"StringEscapeUtils.escape",
|
|
|
|
|
];
|
|
|
|
|
ENCODER_CALLS
|
|
|
|
|
.iter()
|
|
|
|
|
.any(|n| file_bytes.windows(n.len()).any(|w| w == *n))
|
|
|
|
|
}
|
|
|
|
|
|
2026-05-18 01:08:32 -05:00
|
|
|
impl FrameworkAdapter for HeaderJavaAdapter {
|
|
|
|
|
fn name(&self) -> &'static str {
|
|
|
|
|
ADAPTER_NAME
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
fn lang(&self) -> Lang {
|
|
|
|
|
Lang::Java
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
fn detect(
|
|
|
|
|
&self,
|
|
|
|
|
summary: &FuncSummary,
|
|
|
|
|
_ast: tree_sitter::Node<'_>,
|
|
|
|
|
file_bytes: &[u8],
|
|
|
|
|
) -> Option<FrameworkBinding> {
|
2026-05-21 01:36:46 -05:00
|
|
|
if value_routed_through_encoder(file_bytes) {
|
|
|
|
|
return None;
|
|
|
|
|
}
|
2026-05-18 01:08:32 -05:00
|
|
|
let matches_call = super::any_callee_matches(summary, callee_is_header_setter);
|
|
|
|
|
let matches_source = source_imports_servlet(file_bytes);
|
|
|
|
|
if matches_call && matches_source {
|
|
|
|
|
Some(FrameworkBinding {
|
|
|
|
|
adapter: ADAPTER_NAME.to_owned(),
|
|
|
|
|
kind: EntryKind::Function,
|
|
|
|
|
route: None,
|
|
|
|
|
request_params: Vec::new(),
|
|
|
|
|
response_writer: None,
|
|
|
|
|
middleware: Vec::new(),
|
|
|
|
|
})
|
|
|
|
|
} else {
|
|
|
|
|
None
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
#[cfg(test)]
|
|
|
|
|
mod tests {
|
|
|
|
|
use super::*;
|
|
|
|
|
|
|
|
|
|
fn parse_java(src: &[u8]) -> tree_sitter::Tree {
|
|
|
|
|
let mut parser = tree_sitter::Parser::new();
|
|
|
|
|
let lang = tree_sitter::Language::from(tree_sitter_java::LANGUAGE);
|
|
|
|
|
parser.set_language(&lang).unwrap();
|
|
|
|
|
parser.parse(src, None).unwrap()
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
|
fn fires_on_setheader() {
|
|
|
|
|
let src: &[u8] = b"import javax.servlet.http.HttpServletResponse;\n\
|
|
|
|
|
class C { void run(HttpServletResponse r, String v) { r.setHeader(\"Set-Cookie\", v); } }\n";
|
|
|
|
|
let tree = parse_java(src);
|
|
|
|
|
let summary = FuncSummary {
|
|
|
|
|
name: "run".into(),
|
|
|
|
|
callees: vec![crate::summary::CalleeSite::bare("setHeader")],
|
|
|
|
|
..Default::default()
|
|
|
|
|
};
|
2026-05-21 14:35:42 -05:00
|
|
|
assert!(
|
|
|
|
|
HeaderJavaAdapter
|
|
|
|
|
.detect(&summary, tree.root_node(), src)
|
|
|
|
|
.is_some()
|
|
|
|
|
);
|
2026-05-18 01:08:32 -05:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
|
fn skips_plain_function() {
|
|
|
|
|
let src: &[u8] = b"class C { int add(int a, int b) { return a + b; } }\n";
|
|
|
|
|
let tree = parse_java(src);
|
|
|
|
|
let summary = FuncSummary {
|
|
|
|
|
name: "add".into(),
|
|
|
|
|
..Default::default()
|
|
|
|
|
};
|
2026-05-21 14:35:42 -05:00
|
|
|
assert!(
|
|
|
|
|
HeaderJavaAdapter
|
|
|
|
|
.detect(&summary, tree.root_node(), src)
|
|
|
|
|
.is_none()
|
|
|
|
|
);
|
2026-05-18 01:08:32 -05:00
|
|
|
}
|
2026-05-21 01:36:46 -05:00
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
|
fn skips_when_value_url_encoded() {
|
|
|
|
|
let src: &[u8] = b"import javax.servlet.http.HttpServletResponse;\n\
|
|
|
|
|
import java.net.URLEncoder;\n\
|
|
|
|
|
class C { void run(HttpServletResponse r, String v) throws Exception { \
|
|
|
|
|
String safe = URLEncoder.encode(v, \"UTF-8\"); r.setHeader(\"X-Token\", safe); } }\n";
|
|
|
|
|
let tree = parse_java(src);
|
|
|
|
|
let summary = FuncSummary {
|
|
|
|
|
name: "run".into(),
|
|
|
|
|
callees: vec![
|
|
|
|
|
crate::summary::CalleeSite::bare("setHeader"),
|
|
|
|
|
crate::summary::CalleeSite::bare("encode"),
|
|
|
|
|
],
|
|
|
|
|
..Default::default()
|
|
|
|
|
};
|
2026-05-21 14:35:42 -05:00
|
|
|
assert!(
|
|
|
|
|
HeaderJavaAdapter
|
|
|
|
|
.detect(&summary, tree.root_node(), src)
|
|
|
|
|
.is_none()
|
|
|
|
|
);
|
2026-05-21 01:36:46 -05:00
|
|
|
}
|
2026-05-18 01:08:32 -05:00
|
|
|
}
|