mirror of
https://github.com/willchen96/mike.git
synced 2026-07-24 23:41:04 +02:00
0740f656e6
Takes frontend/npm run lint from 23 errors / 40 warnings to 0 errors / 40 warnings, then removes continue-on-error from the CI lint step so it gates merges. Errors fixed outright: - @typescript-eslint/no-explicit-any (5, ChatView.tsx): dropped redundant (msg as any) casts — Message already declares files, workflow, and error with the exact shapes the props expect. - react/no-unescaped-entities (1, support/page.tsx): "We'll" -> "We'll". Targeted disables (17, all react-hooks/set-state-in-effect): every site is an intentional effect-driven state pattern — SSR/hydration mount gates (Modal, useSelectedModel), reset-on-prop/identity-change (CaseLawPanel x3, ChatView chat switch, CitationQuotesHeader, ChatHistoryContext logout, useFetchDocxBytes), sync fast paths of async fetch/check effects (CaseLawPanel, MfaLoginGate x2), DOM-measured state (ChatView scroll button, message-visibility restore), and timed UI latches (PreResponseWrapper, TRChatPanel, AskInputPopup auto-submit). Rewriting any of them would change runtime behavior, so each carries a // eslint-disable-next-line with a one-line reason instead of a fix or a repo-wide rule change. CI: lint step is now blocking; comments updated to say the backlog is at zero. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
100 lines
3.3 KiB
YAML
100 lines
3.3 KiB
YAML
# CI: build and test.
|
|
#
|
|
# Adapted from the amal66/mike fork's .github/workflows/ci.yml (monorepo
|
|
# layout) to this repository's backend/ + frontend/ layout. Test steps use
|
|
# `npm test --if-present`, and the eval job checks for evals/run.mjs, so this
|
|
# workflow is safe to merge before or after the test-harness and evals PRs:
|
|
# on a tree without those pieces the test steps no-op and the build still
|
|
# gates the merge. Beyond the fork version this also builds the frontend
|
|
# (placeholder NEXT_PUBLIC_* env — verified sufficient for `next build`) and
|
|
# runs eslint as a blocking gate (the error backlog is at zero).
|
|
name: CI
|
|
|
|
on:
|
|
push:
|
|
branches: [main]
|
|
pull_request:
|
|
branches: [main]
|
|
|
|
jobs:
|
|
backend:
|
|
name: Backend build and tests
|
|
runs-on: ubuntu-latest
|
|
defaults:
|
|
run:
|
|
working-directory: backend
|
|
steps:
|
|
- uses: actions/checkout@v4
|
|
|
|
- uses: actions/setup-node@v4
|
|
with:
|
|
node-version: 22
|
|
cache: npm
|
|
cache-dependency-path: backend/package-lock.json
|
|
|
|
- run: npm ci
|
|
|
|
# No-ops on a tree without a "test" script (e.g. before the vitest
|
|
# harness PR merges); runs the suite once it exists.
|
|
- run: npm test --if-present
|
|
|
|
- run: npm run build
|
|
|
|
frontend:
|
|
name: Frontend build and tests
|
|
runs-on: ubuntu-latest
|
|
defaults:
|
|
run:
|
|
working-directory: frontend
|
|
steps:
|
|
- uses: actions/checkout@v4
|
|
|
|
- uses: actions/setup-node@v4
|
|
with:
|
|
node-version: 22
|
|
cache: npm
|
|
cache-dependency-path: frontend/package-lock.json
|
|
|
|
- run: npm ci
|
|
|
|
# No-ops on a tree without a "test" script (e.g. before the vitest
|
|
# harness PR merges); runs the suite once it exists.
|
|
- run: npm test --if-present
|
|
|
|
# Blocking gate: the eslint error backlog was burned down in this PR
|
|
# (0 errors; warnings do not fail the step), so any new error fails CI.
|
|
- run: npm run lint
|
|
|
|
# Production build. NEXT_PUBLIC_* values are inlined at build time and
|
|
# only need to be well-formed here — nothing is contacted during build.
|
|
# This catches type errors (next build runs tsc) and broken routes/imports.
|
|
- run: npm run build
|
|
env:
|
|
NEXT_PUBLIC_SUPABASE_URL: https://placeholder.supabase.co
|
|
NEXT_PUBLIC_SUPABASE_PUBLISHABLE_DEFAULT_KEY: sb_publishable_placeholder
|
|
NEXT_PUBLIC_API_BASE_URL: http://localhost:3001
|
|
|
|
# -----------------------------------------------------------------------
|
|
# Offline eval harness: deterministic scorecard for citation accuracy,
|
|
# prompt-injection resistance, and privilege/PII leakage. Runs against
|
|
# committed fixtures (no network, no LLM calls, no secrets), so it is cheap
|
|
# enough to gate every PR. --threshold 1.0 = every case must pass.
|
|
# Skips gracefully until the evals PR merges.
|
|
# -----------------------------------------------------------------------
|
|
evals:
|
|
name: Eval harness
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- uses: actions/checkout@v4
|
|
|
|
- uses: actions/setup-node@v4
|
|
with:
|
|
node-version: 22
|
|
|
|
- name: Run eval harness (skips if evals/ not present)
|
|
run: |
|
|
if [ -f evals/run.mjs ]; then
|
|
node evals/run.mjs --threshold 1.0
|
|
else
|
|
echo "evals/run.mjs not present on this tree; skipping"
|
|
fi
|