mirror of
https://github.com/willchen96/mike.git
synced 2026-07-26 23:51:08 +02:00
docs(e2e): mark the model-selection gap fixed — specs pick a Claude model when the key is set
The "Known gap" paragraph predicted the 4 LLM specs would fail with the secret set because they selected the fork-only "Demo (no key needed)" model. That is now fixed on the e2e suite branch (#220): the helper selects "Claude Sonnet 4.6" and the critical-path assertion checks for a nonempty streamed assistant answer. Update the paragraph accordingly: setting ANTHROPIC_API_KEY now yields 27 passed / 0 skipped (verified locally; keyless stays 23 passed / 4 skipped). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
parent
282b2dd271
commit
0cc635bd5e
1 changed files with 11 additions and 8 deletions
|
|
@ -105,16 +105,19 @@ Open the **Run Playwright** step in the Actions log:
|
|||
|
||||
The uploaded `playwright-report` artifact shows the same per-spec statuses.
|
||||
|
||||
### Known gap: model selection
|
||||
### Model selection (gap fixed on the e2e suite branch)
|
||||
|
||||
As of this branch the four specs drive the model picker to a keyless
|
||||
Earlier revisions of the four specs drove the model picker to a keyless
|
||||
**"Demo (no key needed)"** entry that exists in the amal66 fork but **not in
|
||||
this repository** (no `mike-demo` model id, no demo provider). With the secret
|
||||
set they therefore unskip and then fail at model selection. Before the secret
|
||||
turns them green, one of two follow-ups must land: point the specs'
|
||||
`selectDemoModel` helper at a Claude model when the key is present, or upstream
|
||||
the fork's keyless demo provider. The secret setup above is correct and ready
|
||||
either way.
|
||||
this repository** (no `mike-demo` model id, no demo provider), so setting the
|
||||
secret unskipped them and they then failed at model selection. This is fixed on
|
||||
the e2e suite branch (#220): the specs' `selectClaudeModel` helper picks
|
||||
**Claude Sonnet 4.6** in the ModelToggle whenever the key is set, and the
|
||||
critical-path response assertion checks for a nonempty streamed assistant
|
||||
answer instead of the fork's canned demo reply. With that fix, setting the
|
||||
`ANTHROPIC_API_KEY` secret yields **27 passed / 0 skipped** (verified locally:
|
||||
keyless 23 passed / 4 skipped; with the key 27 / 0). The secret setup above is
|
||||
all that is needed.
|
||||
|
||||
## Make it merge-blocking
|
||||
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue