mirror of
https://github.com/Kaelio/ktx.git
synced 2026-06-22 08:38:08 +02:00
* refactor(workspace): relocate @ktx/llm source into packages/cli/src/llm * refactor(workspace): rewrite @ktx/llm imports to relative paths * refactor(workspace): fold internal packages into cli * chore(workspace): gate dead-code with knip production mode Turn on production-mode knip plus an autofix run in pre-commit and the `pnpm dead-code` script, document the `/** @internal */` convention for test-only exports in AGENTS.md, annotate test-only exports across the CLI with that JSDoc, and drop dead exports/wrappers the new gate surfaced (e.g. `cli-project.ts`, `lookerRuntimeSourceToFileAdapterSource`, `createLocalScanEnrichmentProvidersFromConfig`, `PGLITE_OWNER_PROCESS_BACKEND_CAPABILITIES`, stale type re-exports). Replace the loose `ignoreIssues` allowlist in `knip.json` with explicit production entries so cross-package barrel leaks are caught. * refactor(cli): delete internal barrel index.ts files The 34 `index.ts` re-export barrels inside `packages/cli/src/` were holdovers from the pre-fold multi-workspace structure. Post-fold-in they served no production purpose: external consumers go through the single package main entry, and in-repo callers mostly imported through them only because the path was short. Internally, knip flagged most barrel re-exports as production-dead (only reached via tests). This change: - Deletes every internal barrel except `packages/cli/src/index.ts` (the published package entry). - Rewrites ~270 source/test files to import each name directly from the file that defines it. - Moves `tools/warehouse-verification/index.ts` to `create-warehouse-verification-tools.ts` (the function it defined locally) and updates its single consumer. - Renames `search/backend-conformance.ts` → `.test-utils.ts` to match the existing test-helper file convention. - Deletes 13 dead test-only chains (dbt-descriptions/*, live-database/extracted-schema, live-database/structural-sync, relationship-* feedback/review chain) plus their tests and a cascading orphan integration test. - Updates test mocks that pointed at deleted barrel paths (notion-client, connector barrels in scan/local-scan-connectors tests) to mock the source files instead. - Points the maintainer benchmark script (`scripts/relationship-benchmark-report.mjs`) at source files instead of `dist/context/scan/index.js`. - Drops the barrel `!` entries from `knip.json`; adds explicit production entries only for the benchmark code reached via dist by the maintainer script. Net: 413 files changed, ~1.2k insertions, ~9.4k deletions. `pnpm run dead-code` (Biome + knip default + knip production) and `pnpm run type-check` are clean; 2277 tests pass. * refactor(workspace): rename @ktx/cli to @kaelio/ktx and pack it directly Promote the CLI workspace package to the public name `@kaelio/ktx` and drop the separate `scripts/build-public-npm-package.mjs` wrapper. The CLI package is now publishable in place (`publishConfig.access: public`, `provenance: true`), so artifact packing uses `pnpm pack` against `packages/cli/` instead of assembling a parallel package tree. Updates all workspace filter invocations, docs, tests, and release readiness checks to reference the new package name, and folds the tarball-name helper into `scripts/public-npm-release-metadata.mjs`. * docs: align "agent clients" and "data agents" terminology Replace "client agents" with "agent clients" and "database agents" with "data agents" across AGENTS.md, README.md, the docs-site copy, and the matching setup-agents test description, matching the canonical vocabulary in docs/terminology.md. Also moves packages/cli/tsconfig.json's tsBuildInfoFile from node_modules/.cache/ to dist/.tsbuildinfo so incremental builds survive node_modules reinstalls. * refactor(release): single source of truth for package version Make packages/cli/package.json the single source of truth for the @kaelio/ktx version. publicNpmPackageVersion() now reads it directly, so artifact filenames, release-readiness checks, and the Python wheel version all derive from one field. The duplicate release-policy.json.publicNpmPackageVersion is removed. Previously the two fields could drift: tarballs were named kaelio-ktx-0.4.1.tgz while internally containing @kaelio/ktx@0.0.0-private. - update-public-release-version.mjs rewrites both Python pyproject.toml files (ktx-daemon, ktx-sl) alongside the npm package.jsons, normalizing the version for PEP 440 (e.g. 0.1.0-rc.2 -> 0.1.0rc2). - semantic-release-config.cjs adds the two pyproject.toml files to @semantic-release/git assets so the release commit back to main carries every version source in lockstep. - The six "?? '0.0.0-private'" fallback literals across the CLI are replaced with "?? getKtxCliPackageInfo().version", and createDefaultKtxMcpServer makes its version arg required. - docs/release.md describes the actual commit-back model: the dev tree always reflects the most recent release; no sentinel pin to maintain. Verified: pnpm run artifacts:build now produces kaelio-ktx-0.4.1.tgz and kaelio_ktx-0.4.1-py3-none-any.whl with @kaelio/ktx@0.4.1 inside. Full type-check, dead-code, and 2287 vitests + 173 script tests pass. * refactor(cli): inject embedding provider resolution and detect sentence-transformers runtime Make resolveProjectEmbeddingProvider and runtimeIo injectable in ingest and scan command entrypoints so tests can stub them, and teach resolvePublicIngestRuntimeRequirements to flag the local-embeddings runtime feature when ktx.yaml selects sentence-transformers. * chore(cli): mark buildLocalStatsStatus and LocalStatsStatus as @internal Both symbols are consumed only by status-project.test.ts. Annotating with /** @internal */ keeps knip's production-mode check clean without changing runtime behavior. * fix(cli): use real package metadata in print-command-tree The stubbed package name embedded a forbidden product identifier that tripped the boundary check in CI. Read the metadata from package.json instead — keeps the rendered tree unchanged and removes a duplicate source of truth. * feat(cli): show embedding coverage in `ktx status`, drop duplicate disk counts Inline `(N embedded)` next to the Wiki scope counts and Semantic-layer source counts, computed with `SUM(embedding_json IS NOT NULL)` over `knowledge_pages` and `local_sl_sources`. Rename the "Knowledge" label to "Wiki" (canonical per `docs/terminology.md`) and rename the matching `localStats.knowledgePages` field to `localStats.wikiPages`. Drop `wiki=N md` and `semantic-layer=N yaml` from the Disk row — those duplicated the per-surface rows above. Disk now reports only actual byte usage (db, cache, raw-sources). The unused `wikiGlobalMarkdownCount` / `semanticLayerYamlCount` fields, the `isMarkdownEntry` / `isYamlEntry` helpers, and the `filter` arg on `summarizeDir` are removed.
162 lines
5.4 KiB
TypeScript
162 lines
5.4 KiB
TypeScript
import { mkdir, mkdtemp, rm, writeFile } from 'node:fs/promises';
|
|
import { tmpdir } from 'node:os';
|
|
import { join } from 'node:path';
|
|
import { afterEach, beforeEach, describe, expect, it } from 'vitest';
|
|
import type { KtxEmbeddingPort } from '../core/embedding.js';
|
|
import { CandidateDedupService } from './context-candidates/candidate-dedup.service.js';
|
|
import { ContextEvidenceIndexService } from './context-evidence/context-evidence-index.service.js';
|
|
import { SqliteContextEvidenceStore } from './context-evidence/sqlite-context-evidence-store.js';
|
|
import type { DiffSet } from './types.js';
|
|
|
|
describe('local ingest embedding providers with SQLite ingest stores', () => {
|
|
let tempDir: string;
|
|
let dbPath: string;
|
|
let stagedDir: string;
|
|
|
|
beforeEach(async () => {
|
|
tempDir = await mkdtemp(join(tmpdir(), 'ktx-local-ingest-embedding-'));
|
|
dbPath = join(tempDir, '.ktx', 'db.sqlite');
|
|
stagedDir = join(tempDir, 'staged');
|
|
await mkdir(join(stagedDir, 'pages', 'revenue'), { recursive: true });
|
|
await writeFile(
|
|
join(stagedDir, 'pages', 'revenue', 'metadata.json'),
|
|
`${JSON.stringify({
|
|
objectType: 'page',
|
|
id: 'page-revenue',
|
|
title: 'Revenue Policy',
|
|
path: 'Revenue Policy',
|
|
url: 'https://notion.test/revenue',
|
|
parentId: null,
|
|
lastEditedAt: '2026-04-30T12:00:00.000Z',
|
|
properties: {},
|
|
})}\n`,
|
|
'utf8',
|
|
);
|
|
await writeFile(
|
|
join(stagedDir, 'pages', 'revenue', 'page.md'),
|
|
['# Approval', '', 'Owner approval is required before enterprise discounts are granted.', ''].join('\n'),
|
|
'utf8',
|
|
);
|
|
});
|
|
|
|
afterEach(async () => {
|
|
await rm(tempDir, { recursive: true, force: true });
|
|
});
|
|
|
|
function embeddings(): KtxEmbeddingPort {
|
|
return {
|
|
maxBatchSize: 4,
|
|
async computeEmbedding() {
|
|
return [1, 0, 0];
|
|
},
|
|
async computeEmbeddingsBulk(texts) {
|
|
return texts.map(() => [1, 0, 0]);
|
|
},
|
|
};
|
|
}
|
|
|
|
it('indexes and searches context evidence using a package-owned local embedding provider', async () => {
|
|
const store = new SqliteContextEvidenceStore({ dbPath });
|
|
const embeddingPort = embeddings();
|
|
const indexer = new ContextEvidenceIndexService({ store, embeddings: embeddingPort });
|
|
const diffSet: DiffSet = {
|
|
added: ['pages/revenue/metadata.json', 'pages/revenue/page.md'],
|
|
modified: [],
|
|
deleted: [],
|
|
unchanged: [],
|
|
};
|
|
|
|
const summary = await indexer.indexStagedDir({
|
|
stagedDir,
|
|
runId: 'run-1',
|
|
connectionId: 'docs',
|
|
sourceKey: 'notion',
|
|
syncId: 'sync-1',
|
|
diffSet,
|
|
currentHashes: new Map([
|
|
['pages/revenue/metadata.json', 'metadata-hash'],
|
|
['pages/revenue/page.md', 'page-hash'],
|
|
]),
|
|
});
|
|
|
|
expect(summary).toMatchObject({
|
|
documentsIndexed: 1,
|
|
embeddingFailures: 0,
|
|
});
|
|
expect(summary.chunksIndexed).toBeGreaterThan(0);
|
|
|
|
const queryText = [
|
|
'Revenue Policy',
|
|
'Revenue Policy',
|
|
'Approval',
|
|
'Owner approval is required before enterprise discounts are granted.',
|
|
].join('\n');
|
|
const queryEmbedding = await embeddingPort.computeEmbedding(queryText);
|
|
const results = await store.searchRRF({
|
|
connectionId: 'docs',
|
|
sourceKey: 'notion',
|
|
queryEmbedding,
|
|
queryText,
|
|
limit: 5,
|
|
includeDeleted: false,
|
|
currentRunId: 'run-1',
|
|
});
|
|
|
|
expect(results[0]?.title).toBe('Revenue Policy');
|
|
expect(results[0]?.stableCitationKey).toContain('notion:page-revenue');
|
|
expect(results[0]).toMatchObject({
|
|
matchReasons: expect.arrayContaining(['semantic']),
|
|
lanes: expect.arrayContaining([
|
|
expect.objectContaining({ lane: 'semantic', status: 'available' }),
|
|
expect.objectContaining({ lane: 'lexical', status: 'available' }),
|
|
expect.objectContaining({ lane: 'token', status: 'available' }),
|
|
]),
|
|
});
|
|
});
|
|
|
|
it('deduplicates candidates using package-owned local embeddings and SQLite persistence', async () => {
|
|
const store = new SqliteContextEvidenceStore({ dbPath });
|
|
const embeddingPort = embeddings();
|
|
const candidateBase = {
|
|
runId: 'run-1',
|
|
connectionId: 'docs',
|
|
sourceKey: 'notion',
|
|
topic: 'Enterprise discount approval',
|
|
assertion: 'Owner approval is required before enterprise discounts are granted.',
|
|
rationale: 'The source policy states that approval is required.',
|
|
evidenceChunkIds: [],
|
|
evidenceRefs: [],
|
|
suggestedPageKey: 'revenue-policy',
|
|
actionHint: 'create' as const,
|
|
durabilityScore: 3,
|
|
authorityScore: 3,
|
|
reuseScore: 3,
|
|
noveltyScore: 2,
|
|
riskScore: 0,
|
|
promotionScore: 11,
|
|
status: 'pending' as const,
|
|
rejectionReason: null,
|
|
lane: 'full' as const,
|
|
embedding: null,
|
|
};
|
|
|
|
await store.insertCandidate({ ...candidateBase, candidateKey: 'discount-policy-a' });
|
|
await store.insertCandidate({ ...candidateBase, candidateKey: 'discount-policy-b' });
|
|
|
|
const result = await new CandidateDedupService({
|
|
store,
|
|
embeddings: embeddingPort,
|
|
settings: {
|
|
enabled: true,
|
|
topicSimilarityThreshold: -1,
|
|
scoreAggregation: 'max',
|
|
},
|
|
}).deduplicateRun('run-1');
|
|
|
|
expect(result.enabled).toBe(true);
|
|
expect(result.embeddingFailures).toBe(0);
|
|
expect(result.candidatesIn).toBe(2);
|
|
expect(result.clustersOut).toBe(1);
|
|
expect(result.mergedCount).toBe(1);
|
|
});
|
|
});
|