mirror of
https://github.com/Kaelio/ktx.git
synced 2026-06-22 08:38:08 +02:00
* refactor(workspace): relocate @ktx/llm source into packages/cli/src/llm * refactor(workspace): rewrite @ktx/llm imports to relative paths * refactor(workspace): fold internal packages into cli * chore(workspace): gate dead-code with knip production mode Turn on production-mode knip plus an autofix run in pre-commit and the `pnpm dead-code` script, document the `/** @internal */` convention for test-only exports in AGENTS.md, annotate test-only exports across the CLI with that JSDoc, and drop dead exports/wrappers the new gate surfaced (e.g. `cli-project.ts`, `lookerRuntimeSourceToFileAdapterSource`, `createLocalScanEnrichmentProvidersFromConfig`, `PGLITE_OWNER_PROCESS_BACKEND_CAPABILITIES`, stale type re-exports). Replace the loose `ignoreIssues` allowlist in `knip.json` with explicit production entries so cross-package barrel leaks are caught. * refactor(cli): delete internal barrel index.ts files The 34 `index.ts` re-export barrels inside `packages/cli/src/` were holdovers from the pre-fold multi-workspace structure. Post-fold-in they served no production purpose: external consumers go through the single package main entry, and in-repo callers mostly imported through them only because the path was short. Internally, knip flagged most barrel re-exports as production-dead (only reached via tests). This change: - Deletes every internal barrel except `packages/cli/src/index.ts` (the published package entry). - Rewrites ~270 source/test files to import each name directly from the file that defines it. - Moves `tools/warehouse-verification/index.ts` to `create-warehouse-verification-tools.ts` (the function it defined locally) and updates its single consumer. - Renames `search/backend-conformance.ts` → `.test-utils.ts` to match the existing test-helper file convention. - Deletes 13 dead test-only chains (dbt-descriptions/*, live-database/extracted-schema, live-database/structural-sync, relationship-* feedback/review chain) plus their tests and a cascading orphan integration test. - Updates test mocks that pointed at deleted barrel paths (notion-client, connector barrels in scan/local-scan-connectors tests) to mock the source files instead. - Points the maintainer benchmark script (`scripts/relationship-benchmark-report.mjs`) at source files instead of `dist/context/scan/index.js`. - Drops the barrel `!` entries from `knip.json`; adds explicit production entries only for the benchmark code reached via dist by the maintainer script. Net: 413 files changed, ~1.2k insertions, ~9.4k deletions. `pnpm run dead-code` (Biome + knip default + knip production) and `pnpm run type-check` are clean; 2277 tests pass. * refactor(workspace): rename @ktx/cli to @kaelio/ktx and pack it directly Promote the CLI workspace package to the public name `@kaelio/ktx` and drop the separate `scripts/build-public-npm-package.mjs` wrapper. The CLI package is now publishable in place (`publishConfig.access: public`, `provenance: true`), so artifact packing uses `pnpm pack` against `packages/cli/` instead of assembling a parallel package tree. Updates all workspace filter invocations, docs, tests, and release readiness checks to reference the new package name, and folds the tarball-name helper into `scripts/public-npm-release-metadata.mjs`. * docs: align "agent clients" and "data agents" terminology Replace "client agents" with "agent clients" and "database agents" with "data agents" across AGENTS.md, README.md, the docs-site copy, and the matching setup-agents test description, matching the canonical vocabulary in docs/terminology.md. Also moves packages/cli/tsconfig.json's tsBuildInfoFile from node_modules/.cache/ to dist/.tsbuildinfo so incremental builds survive node_modules reinstalls. * refactor(release): single source of truth for package version Make packages/cli/package.json the single source of truth for the @kaelio/ktx version. publicNpmPackageVersion() now reads it directly, so artifact filenames, release-readiness checks, and the Python wheel version all derive from one field. The duplicate release-policy.json.publicNpmPackageVersion is removed. Previously the two fields could drift: tarballs were named kaelio-ktx-0.4.1.tgz while internally containing @kaelio/ktx@0.0.0-private. - update-public-release-version.mjs rewrites both Python pyproject.toml files (ktx-daemon, ktx-sl) alongside the npm package.jsons, normalizing the version for PEP 440 (e.g. 0.1.0-rc.2 -> 0.1.0rc2). - semantic-release-config.cjs adds the two pyproject.toml files to @semantic-release/git assets so the release commit back to main carries every version source in lockstep. - The six "?? '0.0.0-private'" fallback literals across the CLI are replaced with "?? getKtxCliPackageInfo().version", and createDefaultKtxMcpServer makes its version arg required. - docs/release.md describes the actual commit-back model: the dev tree always reflects the most recent release; no sentinel pin to maintain. Verified: pnpm run artifacts:build now produces kaelio-ktx-0.4.1.tgz and kaelio_ktx-0.4.1-py3-none-any.whl with @kaelio/ktx@0.4.1 inside. Full type-check, dead-code, and 2287 vitests + 173 script tests pass. * refactor(cli): inject embedding provider resolution and detect sentence-transformers runtime Make resolveProjectEmbeddingProvider and runtimeIo injectable in ingest and scan command entrypoints so tests can stub them, and teach resolvePublicIngestRuntimeRequirements to flag the local-embeddings runtime feature when ktx.yaml selects sentence-transformers. * chore(cli): mark buildLocalStatsStatus and LocalStatsStatus as @internal Both symbols are consumed only by status-project.test.ts. Annotating with /** @internal */ keeps knip's production-mode check clean without changing runtime behavior. * fix(cli): use real package metadata in print-command-tree The stubbed package name embedded a forbidden product identifier that tripped the boundary check in CI. Read the metadata from package.json instead — keeps the rendered tree unchanged and removes a duplicate source of truth. * feat(cli): show embedding coverage in `ktx status`, drop duplicate disk counts Inline `(N embedded)` next to the Wiki scope counts and Semantic-layer source counts, computed with `SUM(embedding_json IS NOT NULL)` over `knowledge_pages` and `local_sl_sources`. Rename the "Knowledge" label to "Wiki" (canonical per `docs/terminology.md`) and rename the matching `localStats.knowledgePages` field to `localStats.wikiPages`. Drop `wiki=N md` and `semantic-layer=N yaml` from the Disk row — those duplicated the per-surface rows above. Disk now reports only actual byte usage (db, cache, raw-sources). The unused `wikiGlobalMarkdownCount` / `semanticLayerYamlCount` fields, the `isMarkdownEntry` / `isYamlEntry` helpers, and the `filter` arg on `summarizeDir` are removed.
268 lines
9.2 KiB
TypeScript
268 lines
9.2 KiB
TypeScript
import { z } from 'zod';
|
|
import type { KtxLlmRuntimePort } from '../../context/llm/runtime-port.js';
|
|
import type { KtxEnrichedColumn, KtxEnrichedSchema, KtxEnrichedTable } from './enrichment-types.js';
|
|
import {
|
|
normalizeKtxRelationshipName,
|
|
type KtxRelationshipDiscoveryCandidate,
|
|
} from './relationship-candidates.js';
|
|
import type { KtxRelationshipColumnProfile, KtxRelationshipProfileArtifact } from './relationship-profiling.js';
|
|
import type { KtxScanEnrichmentSummary, KtxScanWarning, KtxTableRef } from './types.js';
|
|
|
|
const relationshipLlmProposalSchema = z.object({
|
|
pkCandidates: z.array(
|
|
z.object({
|
|
table: z.string(),
|
|
column: z.string(),
|
|
confidence: z.number(),
|
|
rationale: z.string(),
|
|
}),
|
|
),
|
|
fkCandidates: z.array(
|
|
z.object({
|
|
fromTable: z.string(),
|
|
fromColumn: z.string(),
|
|
toTable: z.string(),
|
|
toColumn: z.string(),
|
|
confidence: z.number(),
|
|
rationale: z.string(),
|
|
}),
|
|
),
|
|
});
|
|
|
|
type KtxRelationshipLlmProposalOutput = z.infer<typeof relationshipLlmProposalSchema>;
|
|
|
|
interface KtxRelationshipLlmProposalSettings {
|
|
maxTablesPerBatch: number;
|
|
maxColumnsPerTable: number;
|
|
maxSampleValuesPerColumn: number;
|
|
minConfidence: number;
|
|
}
|
|
|
|
export interface ProposeKtxRelationshipCandidatesWithLlmInput {
|
|
connectionId: string;
|
|
schema: KtxEnrichedSchema;
|
|
profile: KtxRelationshipProfileArtifact;
|
|
llmRuntime: KtxLlmRuntimePort | null;
|
|
settings?: Partial<KtxRelationshipLlmProposalSettings>;
|
|
}
|
|
|
|
export interface KtxRelationshipLlmProposalResult {
|
|
candidates: KtxRelationshipDiscoveryCandidate[];
|
|
warnings: KtxScanWarning[];
|
|
llmCalls: number;
|
|
summary: KtxScanEnrichmentSummary['llmRelationshipValidation'];
|
|
}
|
|
|
|
const DEFAULT_SETTINGS: KtxRelationshipLlmProposalSettings = {
|
|
maxTablesPerBatch: 40,
|
|
maxColumnsPerTable: 80,
|
|
maxSampleValuesPerColumn: 5,
|
|
minConfidence: 0.55,
|
|
};
|
|
|
|
function mergeSettings(
|
|
settings: Partial<KtxRelationshipLlmProposalSettings> | undefined,
|
|
): KtxRelationshipLlmProposalSettings {
|
|
return { ...DEFAULT_SETTINGS, ...settings };
|
|
}
|
|
|
|
function clampConfidence(value: number): number {
|
|
return Number(Math.max(0, Math.min(1, value)).toFixed(3));
|
|
}
|
|
|
|
function findTable(schema: KtxEnrichedSchema, name: string): KtxEnrichedTable | null {
|
|
const normalized = name.toLowerCase();
|
|
return schema.tables.find((table) => table.ref.name.toLowerCase() === normalized) ?? null;
|
|
}
|
|
|
|
function findColumn(table: KtxEnrichedTable, name: string): KtxEnrichedColumn | null {
|
|
const normalized = name.toLowerCase();
|
|
return table.columns.find((column) => column.name.toLowerCase() === normalized) ?? null;
|
|
}
|
|
|
|
function profileKey(table: KtxTableRef, column: KtxEnrichedColumn): string {
|
|
return `${table.name}.${column.name}`;
|
|
}
|
|
|
|
function profileForColumn(
|
|
profile: KtxRelationshipProfileArtifact,
|
|
table: KtxEnrichedTable,
|
|
column: KtxEnrichedColumn,
|
|
): KtxRelationshipColumnProfile | null {
|
|
return profile.columns[profileKey(table.ref, column)] ?? null;
|
|
}
|
|
|
|
function rowCountForTable(profile: KtxRelationshipProfileArtifact, table: KtxEnrichedTable): number | null {
|
|
return profile.tables.find((item) => item.table.name.toLowerCase() === table.ref.name.toLowerCase())?.rowCount ?? null;
|
|
}
|
|
|
|
function buildEvidencePacket(
|
|
schema: KtxEnrichedSchema,
|
|
profile: KtxRelationshipProfileArtifact,
|
|
settings: KtxRelationshipLlmProposalSettings,
|
|
): Record<string, unknown> {
|
|
return {
|
|
connectionId: schema.connectionId,
|
|
sqlAvailable: profile.sqlAvailable,
|
|
tables: schema.tables
|
|
.filter((table) => table.enabled)
|
|
.slice(0, settings.maxTablesPerBatch)
|
|
.map((table) => ({
|
|
name: table.ref.name,
|
|
catalog: table.ref.catalog,
|
|
db: table.ref.db,
|
|
rowCount: rowCountForTable(profile, table),
|
|
columns: table.columns.slice(0, settings.maxColumnsPerTable).map((column) => {
|
|
const columnProfile = profileForColumn(profile, table, column);
|
|
return {
|
|
name: column.name,
|
|
nativeType: column.nativeType,
|
|
normalizedType: column.normalizedType,
|
|
dimensionType: column.dimensionType,
|
|
nullable: column.nullable,
|
|
declaredPrimaryKey: column.primaryKey,
|
|
profile: columnProfile
|
|
? {
|
|
rowCount: columnProfile.rowCount,
|
|
nullCount: columnProfile.nullCount,
|
|
distinctCount: columnProfile.distinctCount,
|
|
uniquenessRatio: columnProfile.uniquenessRatio,
|
|
nullRate: columnProfile.nullRate,
|
|
sampleValues: columnProfile.sampleValues.slice(0, settings.maxSampleValuesPerColumn),
|
|
}
|
|
: null,
|
|
};
|
|
}),
|
|
})),
|
|
};
|
|
}
|
|
|
|
function pkProposalKey(table: string, column: string): string {
|
|
return `${table.toLowerCase()}.${column.toLowerCase()}`;
|
|
}
|
|
|
|
function endpoint(table: KtxEnrichedTable, column: KtxEnrichedColumn) {
|
|
return {
|
|
tableId: table.id,
|
|
columnIds: [column.id],
|
|
table: table.ref,
|
|
columns: [column.name],
|
|
};
|
|
}
|
|
|
|
function relationshipId(fromTable: KtxEnrichedTable, fromColumn: KtxEnrichedColumn, toTable: KtxEnrichedTable, toColumn: KtxEnrichedColumn): string {
|
|
return `${fromTable.id}:(${fromColumn.id})->${toTable.id}:(${toColumn.id})`;
|
|
}
|
|
|
|
function invalidReferenceWarning(message: string, metadata: Record<string, unknown>): KtxScanWarning {
|
|
return {
|
|
code: 'relationship_llm_invalid_reference',
|
|
message,
|
|
recoverable: true,
|
|
metadata,
|
|
};
|
|
}
|
|
|
|
function mapValidProposals(
|
|
schema: KtxEnrichedSchema,
|
|
output: KtxRelationshipLlmProposalOutput,
|
|
settings: KtxRelationshipLlmProposalSettings,
|
|
): { candidates: KtxRelationshipDiscoveryCandidate[]; warnings: KtxScanWarning[] } {
|
|
const warnings: KtxScanWarning[] = [];
|
|
const pkProposals = new Set(output.pkCandidates.map((item) => pkProposalKey(item.table, item.column)));
|
|
const candidates: KtxRelationshipDiscoveryCandidate[] = [];
|
|
|
|
for (const item of output.fkCandidates) {
|
|
if (item.confidence < settings.minConfidence) {
|
|
continue;
|
|
}
|
|
const fromTable = findTable(schema, item.fromTable);
|
|
const toTable = findTable(schema, item.toTable);
|
|
const fromColumn = fromTable ? findColumn(fromTable, item.fromColumn) : null;
|
|
const toColumn = toTable ? findColumn(toTable, item.toColumn) : null;
|
|
if (!fromTable || !toTable || !fromColumn || !toColumn) {
|
|
warnings.push(
|
|
invalidReferenceWarning('KTX relationship LLM proposal referenced a table or column that is not in the schema.', {
|
|
proposal: item,
|
|
}),
|
|
);
|
|
continue;
|
|
}
|
|
|
|
const pkProposalExists = pkProposals.has(pkProposalKey(toTable.ref.name, toColumn.name));
|
|
candidates.push({
|
|
id: relationshipId(fromTable, fromColumn, toTable, toColumn),
|
|
from: endpoint(fromTable, fromColumn),
|
|
to: endpoint(toTable, toColumn),
|
|
source: 'llm_proposal',
|
|
status: 'review',
|
|
relationshipType: 'many_to_one',
|
|
confidence: clampConfidence(item.confidence),
|
|
evidence: {
|
|
sourceColumnBase: normalizeKtxRelationshipName(fromColumn.name).singular,
|
|
targetTableBase: normalizeKtxRelationshipName(toTable.ref.name).singular,
|
|
targetColumnBase: normalizeKtxRelationshipName(toColumn.name).singular,
|
|
targetKeyScore: pkProposalExists ? 0.88 : 0.68,
|
|
nameScore: 0.45,
|
|
reasons: pkProposalExists ? ['llm_proposal', 'llm_pk_proposal'] : ['llm_proposal'],
|
|
llmConfidence: clampConfidence(item.confidence),
|
|
llmRationale: item.rationale,
|
|
},
|
|
});
|
|
}
|
|
|
|
return { candidates, warnings };
|
|
}
|
|
|
|
function generationFailureWarning(error: unknown): KtxScanWarning {
|
|
const message = error instanceof Error ? error.message : String(error);
|
|
return {
|
|
code: 'relationship_llm_proposal_failed',
|
|
message: `KTX relationship LLM proposal failed: ${message}`,
|
|
recoverable: true,
|
|
};
|
|
}
|
|
|
|
export async function proposeKtxRelationshipCandidatesWithLlm(
|
|
input: ProposeKtxRelationshipCandidatesWithLlmInput,
|
|
): Promise<KtxRelationshipLlmProposalResult> {
|
|
if (!input.llmRuntime) {
|
|
return { candidates: [], warnings: [], llmCalls: 0, summary: 'skipped' };
|
|
}
|
|
|
|
const settings = mergeSettings(input.settings);
|
|
const evidence = buildEvidencePacket(input.schema, input.profile, settings);
|
|
const system = [
|
|
'You are helping KTX review possible SQL relationships before validation.',
|
|
'Use only the compact schema evidence. Propose likely primary keys and foreign keys for later SQL validation.',
|
|
'Return structured output only; never assume a join is accepted.',
|
|
].join('\n');
|
|
const prompt = JSON.stringify(evidence);
|
|
|
|
try {
|
|
const generated = await input.llmRuntime.generateObject<
|
|
KtxRelationshipLlmProposalOutput,
|
|
typeof relationshipLlmProposalSchema
|
|
>({
|
|
role: 'candidateExtraction',
|
|
system,
|
|
prompt,
|
|
schema: relationshipLlmProposalSchema,
|
|
});
|
|
const output = relationshipLlmProposalSchema.parse(generated);
|
|
const mapped = mapValidProposals(input.schema, output, settings);
|
|
return {
|
|
candidates: mapped.candidates,
|
|
warnings: mapped.warnings,
|
|
llmCalls: 1,
|
|
summary: 'completed',
|
|
};
|
|
} catch (error) {
|
|
return {
|
|
candidates: [],
|
|
warnings: [generationFailureWarning(error)],
|
|
llmCalls: 1,
|
|
summary: 'failed',
|
|
};
|
|
}
|
|
}
|