mirror of
https://github.com/Kaelio/ktx.git
synced 2026-06-07 07:55:13 +02:00
* feat(cli): define full warehouse dialect contract
* test(cli): keep dialect edge tests focused
* fix(cli): stabilize dialect contract foundation
* refactor(connectors): own read-only query preparation
* refactor(connectors): resolve dialects through registry
* refactor(connectors): keep concrete dialect classes internal
* chore(workspace): enforce dialect import boundary
* refactor(cli): resolve relationship dialect at scan boundary
* refactor(cli): use dialect display parsing for entity details
* refactor(cli): use dialect display parsing for warehouse catalog
* refactor(cli): use dialect SQL in relationship workflows
* test(cli): verify solid dialect scan workflow closure
* test: split cli tests from source tree
* refactor(cli): standardize BigQuery scope listing
* feat(sqlite): implement connector scope listing
* test(connectors): cover required table listing
* feat(cli): add warehouse driver registry
* refactor(setup): route scope discovery through driver registry
* refactor(cli): route local query execution through driver registry
* refactor(historic-sql): route dialect support through driver registry
* refactor(cli): test warehouse connections through driver registry
* fix(cli): close driver registry type export gaps
* Improve setup daemon diagnostics
* refactor(setup): centralize rail-prefixed diagnostics + query-history fallback
Extract errorMessage, writePrefixedLines, and flushPrefixedBufferedCommandOutput
into clack.ts so the setup wizard, managed daemons, and embedding/agent steps
share one rail-formatted writer. setup-databases.ts also adds a
"disable query history and retry" option when the schema-context build fails
and query history is the likely culprit, surfaced via a new
failed-query-history-unavailable status.
* fix(cli): carry catalog through the picker so BigQuery/Snowflake/SQL Server scope filters match
The setup picker's KtxTableListEntry was a 2-level { schema, name }, so
qualifiedTableId always wrote db.name into enabled_tables. When BigQuery,
Snowflake, or SQL Server later ran fast ingest, their introspect step filtered
the scope set with scopedTableNames(scope, { catalog: projectId|database, db })
— catalog was non-null on the introspect side but null in the scope refs, so
every entry was rejected, the live-database adapter staged zero table files,
and detect() failed with 'Adapter "live-database" did not recognize fetched
source output'.
Align the picker boundary with the canonical 3-level KtxTableRef:
- Add catalog: string | null to KtxTableListEntry.
- BigQuery/Snowflake/SQL Server listTables populate catalog from the
resolved projectId / database; Postgres/MySQL/ClickHouse/SQLite set null.
- qualifiedTableId emits catalog.schema.name when catalog is non-null
(resolveEnabledTables already accepts the 3-part shape) and
schemasFromEnabledTables now goes through parseDottedTableEntry so it
recovers the schema correctly from both 2-part and 3-part entries.
- Export parseDottedTableEntry from enabled-tables.ts (@internal) for picker
reuse.
Update listTables expectations in all seven connector tests and the setup /
picker test fixtures. Add a picker regression test that covers the
catalog-bearing round-trip (save + refine).
* fix(cli): allow debug telemetry under opt-out env
141 lines
5.1 KiB
TypeScript
141 lines
5.1 KiB
TypeScript
import { Command } from '@commander-js/extra-typings';
|
|
import { describe, expect, it } from 'vitest';
|
|
import { formatCommandTree, walkCommandTree } from '../src/command-tree.js';
|
|
|
|
describe('walkCommandTree', () => {
|
|
it('captures name, description, aliases, and nested children', () => {
|
|
const root = new Command('root').description('the root');
|
|
const child = new Command('child').description('a child').alias('c').alias('ch');
|
|
const grandchild = new Command('grand').description('a grandchild');
|
|
child.addCommand(grandchild);
|
|
root.addCommand(child);
|
|
|
|
const tree = walkCommandTree(root);
|
|
|
|
expect(tree).toEqual({
|
|
name: 'root',
|
|
description: 'the root',
|
|
aliases: [],
|
|
arguments: [],
|
|
children: [
|
|
{
|
|
name: 'child',
|
|
description: 'a child',
|
|
aliases: ['c', 'ch'],
|
|
arguments: [],
|
|
children: [{ name: 'grand', description: 'a grandchild', aliases: [], arguments: [], children: [] }],
|
|
},
|
|
],
|
|
});
|
|
});
|
|
|
|
it('returns an empty children array when there are no subcommands', () => {
|
|
const leaf = new Command('leaf').description('alone');
|
|
expect(walkCommandTree(leaf)).toEqual({
|
|
name: 'leaf',
|
|
description: 'alone',
|
|
aliases: [],
|
|
arguments: [],
|
|
children: [],
|
|
});
|
|
});
|
|
|
|
it('uses an empty string when description is unset', () => {
|
|
const command = new Command('bare');
|
|
expect(walkCommandTree(command).description).toBe('');
|
|
});
|
|
|
|
it('captures required, optional, and variadic arguments', () => {
|
|
const command = new Command('scan')
|
|
.argument('<connectionId>', 'KTX connection id')
|
|
.argument('[schemas...]', 'Schemas');
|
|
|
|
expect(walkCommandTree(command).arguments).toEqual(['<connectionId>', '[schemas...]']);
|
|
});
|
|
|
|
it('walks registered commands without applying hidden-command policy', () => {
|
|
const root = new Command('ktx');
|
|
root.command('scan', { hidden: true }).description('Run a standalone connection scan');
|
|
const ingest = root.command('ingest').description('Build or inspect KTX context');
|
|
ingest.command('run', { hidden: true }).description('Run local ingest by adapter');
|
|
ingest.command('watch', { hidden: true }).description('Open a stored visual report');
|
|
ingest.command('status').description('Print status');
|
|
root.command('status').description('Check readiness');
|
|
|
|
const tree = walkCommandTree(root);
|
|
|
|
expect(tree.children.map((child) => child.name)).toEqual(['scan', 'ingest', 'status']);
|
|
expect(tree.children[0]).toMatchObject({
|
|
name: 'scan',
|
|
description: 'Run a standalone connection scan',
|
|
children: [],
|
|
});
|
|
expect(tree.children[1]).toMatchObject({
|
|
name: 'ingest',
|
|
children: [
|
|
{ name: 'run', description: 'Run local ingest by adapter', aliases: [], arguments: [], children: [] },
|
|
{ name: 'watch', description: 'Open a stored visual report', aliases: [], arguments: [], children: [] },
|
|
{ name: 'status', description: 'Print status', aliases: [], arguments: [], children: [] },
|
|
],
|
|
});
|
|
});
|
|
});
|
|
|
|
describe('formatCommandTree', () => {
|
|
it('renders a single node with no children', () => {
|
|
const node = { name: 'solo', description: 'just me', aliases: [], arguments: [], children: [] };
|
|
expect(formatCommandTree(node)).toMatch(/^solo\s+just me\n$/);
|
|
});
|
|
|
|
it('renders aliases in parentheses before the description', () => {
|
|
const node = { name: 'cmd', description: 'does things', aliases: ['c', 'co'], arguments: [], children: [] };
|
|
expect(formatCommandTree(node)).toMatch(/^cmd \(c, co\)\s+does things\n$/);
|
|
});
|
|
|
|
it('renders command arguments after the command name', () => {
|
|
const node = {
|
|
name: 'test',
|
|
description: 'Test a configured connection',
|
|
aliases: [],
|
|
arguments: ['<connectionId>'],
|
|
children: [],
|
|
};
|
|
expect(formatCommandTree(node)).toMatch(/^test <connectionId>\s+Test a configured connection\n$/);
|
|
});
|
|
|
|
it('omits the dash when description is empty', () => {
|
|
const node = { name: 'bare', description: '', aliases: [], arguments: [], children: [] };
|
|
expect(formatCommandTree(node)).toBe('bare\n');
|
|
});
|
|
|
|
it('renders tree connectors and preserves sibling registration order', () => {
|
|
const tree = {
|
|
name: 'root',
|
|
description: 'top',
|
|
aliases: [],
|
|
arguments: [],
|
|
children: [
|
|
{
|
|
name: 'beta',
|
|
description: 'b',
|
|
aliases: [],
|
|
arguments: [],
|
|
children: [{ name: 'leaf', description: 'l', aliases: [], arguments: [], children: [] }],
|
|
},
|
|
{
|
|
name: 'alpha',
|
|
description: 'a',
|
|
aliases: ['al'],
|
|
arguments: ['<id>'],
|
|
children: [{ name: 'inner', description: 'i', aliases: [], arguments: [], children: [] }],
|
|
},
|
|
],
|
|
};
|
|
const lines = formatCommandTree(tree).trimEnd().split('\n');
|
|
expect(lines[0]).toMatch(/^root\s+top$/);
|
|
expect(lines[1]).toMatch(/^ ├── beta\s+b$/);
|
|
expect(lines[2]).toMatch(/^ │ └── leaf\s+l$/);
|
|
expect(lines[3]).toMatch(/^ └── alpha <id> \(al\)\s+a$/);
|
|
expect(lines[4]).toMatch(/^ └── inner\s+i$/);
|
|
});
|
|
});
|