mirror of
https://github.com/Kaelio/ktx.git
synced 2026-06-07 07:55:13 +02:00
* feat(cli): define full warehouse dialect contract
* test(cli): keep dialect edge tests focused
* fix(cli): stabilize dialect contract foundation
* refactor(connectors): own read-only query preparation
* refactor(connectors): resolve dialects through registry
* refactor(connectors): keep concrete dialect classes internal
* chore(workspace): enforce dialect import boundary
* refactor(cli): resolve relationship dialect at scan boundary
* refactor(cli): use dialect display parsing for entity details
* refactor(cli): use dialect display parsing for warehouse catalog
* refactor(cli): use dialect SQL in relationship workflows
* test(cli): verify solid dialect scan workflow closure
* test: split cli tests from source tree
* refactor(cli): standardize BigQuery scope listing
* feat(sqlite): implement connector scope listing
* test(connectors): cover required table listing
* feat(cli): add warehouse driver registry
* refactor(setup): route scope discovery through driver registry
* refactor(cli): route local query execution through driver registry
* refactor(historic-sql): route dialect support through driver registry
* refactor(cli): test warehouse connections through driver registry
* fix(cli): close driver registry type export gaps
* Improve setup daemon diagnostics
* refactor(setup): centralize rail-prefixed diagnostics + query-history fallback
Extract errorMessage, writePrefixedLines, and flushPrefixedBufferedCommandOutput
into clack.ts so the setup wizard, managed daemons, and embedding/agent steps
share one rail-formatted writer. setup-databases.ts also adds a
"disable query history and retry" option when the schema-context build fails
and query history is the likely culprit, surfaced via a new
failed-query-history-unavailable status.
* fix(cli): carry catalog through the picker so BigQuery/Snowflake/SQL Server scope filters match
The setup picker's KtxTableListEntry was a 2-level { schema, name }, so
qualifiedTableId always wrote db.name into enabled_tables. When BigQuery,
Snowflake, or SQL Server later ran fast ingest, their introspect step filtered
the scope set with scopedTableNames(scope, { catalog: projectId|database, db })
— catalog was non-null on the introspect side but null in the scope refs, so
every entry was rejected, the live-database adapter staged zero table files,
and detect() failed with 'Adapter "live-database" did not recognize fetched
source output'.
Align the picker boundary with the canonical 3-level KtxTableRef:
- Add catalog: string | null to KtxTableListEntry.
- BigQuery/Snowflake/SQL Server listTables populate catalog from the
resolved projectId / database; Postgres/MySQL/ClickHouse/SQLite set null.
- qualifiedTableId emits catalog.schema.name when catalog is non-null
(resolveEnabledTables already accepts the 3-part shape) and
schemasFromEnabledTables now goes through parseDottedTableEntry so it
recovers the schema correctly from both 2-part and 3-part entries.
- Export parseDottedTableEntry from enabled-tables.ts (@internal) for picker
reuse.
Update listTables expectations in all seven connector tests and the setup /
picker test fixtures. Add a picker regression test that covers the
catalog-bearing round-trip (save + refine).
* fix(cli): allow debug telemetry under opt-out env
205 lines
6.9 KiB
TypeScript
205 lines
6.9 KiB
TypeScript
import { describe, expect, it, vi } from 'vitest';
|
|
import {
|
|
createManagedDaemonHttpJsonRunner,
|
|
createManagedDaemonLookerTableIdentifierParser,
|
|
createManagedDaemonSqlAnalysisPort,
|
|
createManagedPythonDaemonBaseUrlResolver,
|
|
managedDaemonDatabaseIntrospectionOptions,
|
|
} from '../src/managed-python-http.js';
|
|
|
|
function io() {
|
|
let stderr = '';
|
|
return {
|
|
io: {
|
|
stdout: { write: vi.fn() },
|
|
stderr: { write: (chunk: string) => (stderr += chunk) },
|
|
},
|
|
stderr: () => stderr,
|
|
};
|
|
}
|
|
|
|
describe('createManagedPythonDaemonBaseUrlResolver', () => {
|
|
it('ensures the core runtime, starts the daemon, reports the URL, and caches the result', async () => {
|
|
const testIo = io();
|
|
const ensureRuntime = vi.fn(async () => ({
|
|
layout: {} as never,
|
|
manifest: {} as never,
|
|
}));
|
|
const startDaemon = vi.fn(async () => ({
|
|
status: 'started' as const,
|
|
layout: {} as never,
|
|
state: { pid: 1234 } as never,
|
|
baseUrl: 'http://127.0.0.1:61234',
|
|
}));
|
|
const resolveBaseUrl = createManagedPythonDaemonBaseUrlResolver({
|
|
cliVersion: '0.2.0',
|
|
projectDir: '/work/proj',
|
|
installPolicy: 'auto',
|
|
io: testIo.io,
|
|
ensureRuntime,
|
|
startDaemon,
|
|
});
|
|
|
|
await expect(resolveBaseUrl()).resolves.toBe('http://127.0.0.1:61234');
|
|
await expect(resolveBaseUrl()).resolves.toBe('http://127.0.0.1:61234');
|
|
|
|
expect(ensureRuntime).toHaveBeenCalledTimes(1);
|
|
expect(ensureRuntime).toHaveBeenCalledWith({
|
|
cliVersion: '0.2.0',
|
|
installPolicy: 'auto',
|
|
io: testIo.io,
|
|
feature: 'core',
|
|
});
|
|
expect(startDaemon).toHaveBeenCalledTimes(1);
|
|
expect(startDaemon).toHaveBeenCalledWith({
|
|
cliVersion: '0.2.0',
|
|
projectDir: '/work/proj',
|
|
features: ['core'],
|
|
force: false,
|
|
});
|
|
expect(testIo.stderr()).toContain('Started KTX daemon: http://127.0.0.1:61234');
|
|
});
|
|
|
|
it('reports daemon reuse without reinstalling after the first resolved URL', async () => {
|
|
const testIo = io();
|
|
const ensureRuntime = vi.fn(async () => ({
|
|
layout: {} as never,
|
|
manifest: {} as never,
|
|
}));
|
|
const startDaemon = vi.fn(async () => ({
|
|
status: 'reused' as const,
|
|
layout: {} as never,
|
|
state: { pid: 1234 } as never,
|
|
baseUrl: 'http://127.0.0.1:61234',
|
|
}));
|
|
const resolveBaseUrl = createManagedPythonDaemonBaseUrlResolver({
|
|
cliVersion: '0.2.0',
|
|
projectDir: '/work/proj',
|
|
installPolicy: 'never',
|
|
io: testIo.io,
|
|
ensureRuntime,
|
|
startDaemon,
|
|
});
|
|
|
|
await expect(resolveBaseUrl()).resolves.toBe('http://127.0.0.1:61234');
|
|
await expect(resolveBaseUrl()).resolves.toBe('http://127.0.0.1:61234');
|
|
|
|
expect(ensureRuntime).toHaveBeenCalledTimes(1);
|
|
expect(startDaemon).toHaveBeenCalledTimes(1);
|
|
expect(testIo.stderr()).toContain('Using existing KTX daemon: http://127.0.0.1:61234');
|
|
});
|
|
});
|
|
|
|
describe('createManagedDaemonHttpJsonRunner', () => {
|
|
it('resolves the managed base URL lazily for each HTTP JSON request', async () => {
|
|
const postJson = vi.fn(async () => ({ ok: true }));
|
|
const runner = createManagedDaemonHttpJsonRunner({
|
|
resolveBaseUrl: async () => 'http://127.0.0.1:61234',
|
|
postJson,
|
|
});
|
|
|
|
await expect(runner('/sql/parse-table-identifier', { items: [] })).resolves.toEqual({ ok: true });
|
|
|
|
expect(postJson).toHaveBeenCalledWith('http://127.0.0.1:61234', '/sql/parse-table-identifier', { items: [] });
|
|
});
|
|
});
|
|
|
|
describe('KTX daemon ingest ports', () => {
|
|
it('creates a Looker table parser backed by the KTX daemon runner', async () => {
|
|
const requestJson = vi.fn(async () => ({
|
|
results: {
|
|
'model.explore': {
|
|
ok: true,
|
|
catalog: 'warehouse',
|
|
schema: 'public',
|
|
name: 'orders',
|
|
canonical_table: 'public.orders',
|
|
},
|
|
},
|
|
}));
|
|
const parser = createManagedDaemonLookerTableIdentifierParser({ requestJson });
|
|
|
|
await expect(
|
|
parser.parse([{ key: 'model.explore', sql_table_name: 'public.orders', dialect: 'postgres' }]),
|
|
).resolves.toEqual({
|
|
'model.explore': {
|
|
ok: true,
|
|
catalog: 'warehouse',
|
|
schema: 'public',
|
|
name: 'orders',
|
|
canonical_table: 'public.orders',
|
|
},
|
|
});
|
|
expect(requestJson).toHaveBeenCalledWith('/sql/parse-table-identifier', {
|
|
items: [{ key: 'model.explore', sql_table_name: 'public.orders', dialect: 'postgres' }],
|
|
});
|
|
});
|
|
|
|
it('creates a SQL analysis port backed by the KTX daemon runner', async () => {
|
|
const requestJson = vi.fn(async () => ({
|
|
fingerprint: 'select-orders',
|
|
normalized_sql: 'SELECT * FROM public.orders WHERE id = ?',
|
|
tables_touched: ['public.orders'],
|
|
literal_slots: [{ position: 1, type: 'number', example_value: '42' }],
|
|
}));
|
|
const sqlAnalysis = createManagedDaemonSqlAnalysisPort({ requestJson });
|
|
|
|
await expect(sqlAnalysis.analyzeForFingerprint('SELECT * FROM public.orders WHERE id = 42', 'postgres')).resolves
|
|
.toEqual({
|
|
fingerprint: 'select-orders',
|
|
normalizedSql: 'SELECT * FROM public.orders WHERE id = ?',
|
|
tablesTouched: ['public.orders'],
|
|
literalSlots: [{ position: 1, type: 'number', exampleValue: '42' }],
|
|
});
|
|
expect(requestJson).toHaveBeenCalledWith('/api/sql/analyze-for-fingerprint', {
|
|
sql: 'SELECT * FROM public.orders WHERE id = 42',
|
|
dialect: 'postgres',
|
|
});
|
|
});
|
|
|
|
it('routes SQL batch analysis through the KTX daemon runner', async () => {
|
|
const requestJson = vi.fn(async () => ({
|
|
results: {
|
|
orders: {
|
|
tables_touched: ['public.orders'],
|
|
columns_by_clause: { select: ['status'] },
|
|
error: null,
|
|
},
|
|
},
|
|
}));
|
|
const sqlAnalysis = createManagedDaemonSqlAnalysisPort({ requestJson });
|
|
|
|
await expect(sqlAnalysis.analyzeBatch([{ id: 'orders', sql: 'select status from public.orders' }], 'postgres'))
|
|
.resolves.toEqual(
|
|
new Map([
|
|
[
|
|
'orders',
|
|
{
|
|
tablesTouched: ['public.orders'],
|
|
columnsByClause: { select: ['status'] },
|
|
error: null,
|
|
},
|
|
],
|
|
]),
|
|
);
|
|
expect(requestJson).toHaveBeenCalledWith('/sql/analyze-batch', {
|
|
dialect: 'postgres',
|
|
items: [{ id: 'orders', sql: 'select status from public.orders' }],
|
|
});
|
|
});
|
|
|
|
it('returns live-database daemon request options backed by the managed runner', async () => {
|
|
const requestJson = vi.fn(async () => ({
|
|
connection_id: 'warehouse',
|
|
tables: [],
|
|
}));
|
|
const options = managedDaemonDatabaseIntrospectionOptions({ requestJson });
|
|
expect(options.requestJson).toBeDefined();
|
|
|
|
await expect(options.requestJson?.('/database/introspect', { connection_id: 'warehouse' })).resolves.toEqual({
|
|
connection_id: 'warehouse',
|
|
tables: [],
|
|
});
|
|
expect(requestJson).toHaveBeenCalledWith('/database/introspect', { connection_id: 'warehouse' });
|
|
});
|
|
});
|