mirror of
https://github.com/Kaelio/ktx.git
synced 2026-07-07 11:02:11 +02:00
* refactor(workspace): relocate @ktx/llm source into packages/cli/src/llm * refactor(workspace): rewrite @ktx/llm imports to relative paths * refactor(workspace): fold internal packages into cli * chore(workspace): gate dead-code with knip production mode Turn on production-mode knip plus an autofix run in pre-commit and the `pnpm dead-code` script, document the `/** @internal */` convention for test-only exports in AGENTS.md, annotate test-only exports across the CLI with that JSDoc, and drop dead exports/wrappers the new gate surfaced (e.g. `cli-project.ts`, `lookerRuntimeSourceToFileAdapterSource`, `createLocalScanEnrichmentProvidersFromConfig`, `PGLITE_OWNER_PROCESS_BACKEND_CAPABILITIES`, stale type re-exports). Replace the loose `ignoreIssues` allowlist in `knip.json` with explicit production entries so cross-package barrel leaks are caught. * refactor(cli): delete internal barrel index.ts files The 34 `index.ts` re-export barrels inside `packages/cli/src/` were holdovers from the pre-fold multi-workspace structure. Post-fold-in they served no production purpose: external consumers go through the single package main entry, and in-repo callers mostly imported through them only because the path was short. Internally, knip flagged most barrel re-exports as production-dead (only reached via tests). This change: - Deletes every internal barrel except `packages/cli/src/index.ts` (the published package entry). - Rewrites ~270 source/test files to import each name directly from the file that defines it. - Moves `tools/warehouse-verification/index.ts` to `create-warehouse-verification-tools.ts` (the function it defined locally) and updates its single consumer. - Renames `search/backend-conformance.ts` → `.test-utils.ts` to match the existing test-helper file convention. - Deletes 13 dead test-only chains (dbt-descriptions/*, live-database/extracted-schema, live-database/structural-sync, relationship-* feedback/review chain) plus their tests and a cascading orphan integration test. - Updates test mocks that pointed at deleted barrel paths (notion-client, connector barrels in scan/local-scan-connectors tests) to mock the source files instead. - Points the maintainer benchmark script (`scripts/relationship-benchmark-report.mjs`) at source files instead of `dist/context/scan/index.js`. - Drops the barrel `!` entries from `knip.json`; adds explicit production entries only for the benchmark code reached via dist by the maintainer script. Net: 413 files changed, ~1.2k insertions, ~9.4k deletions. `pnpm run dead-code` (Biome + knip default + knip production) and `pnpm run type-check` are clean; 2277 tests pass. * refactor(workspace): rename @ktx/cli to @kaelio/ktx and pack it directly Promote the CLI workspace package to the public name `@kaelio/ktx` and drop the separate `scripts/build-public-npm-package.mjs` wrapper. The CLI package is now publishable in place (`publishConfig.access: public`, `provenance: true`), so artifact packing uses `pnpm pack` against `packages/cli/` instead of assembling a parallel package tree. Updates all workspace filter invocations, docs, tests, and release readiness checks to reference the new package name, and folds the tarball-name helper into `scripts/public-npm-release-metadata.mjs`. * docs: align "agent clients" and "data agents" terminology Replace "client agents" with "agent clients" and "database agents" with "data agents" across AGENTS.md, README.md, the docs-site copy, and the matching setup-agents test description, matching the canonical vocabulary in docs/terminology.md. Also moves packages/cli/tsconfig.json's tsBuildInfoFile from node_modules/.cache/ to dist/.tsbuildinfo so incremental builds survive node_modules reinstalls. * refactor(release): single source of truth for package version Make packages/cli/package.json the single source of truth for the @kaelio/ktx version. publicNpmPackageVersion() now reads it directly, so artifact filenames, release-readiness checks, and the Python wheel version all derive from one field. The duplicate release-policy.json.publicNpmPackageVersion is removed. Previously the two fields could drift: tarballs were named kaelio-ktx-0.4.1.tgz while internally containing @kaelio/ktx@0.0.0-private. - update-public-release-version.mjs rewrites both Python pyproject.toml files (ktx-daemon, ktx-sl) alongside the npm package.jsons, normalizing the version for PEP 440 (e.g. 0.1.0-rc.2 -> 0.1.0rc2). - semantic-release-config.cjs adds the two pyproject.toml files to @semantic-release/git assets so the release commit back to main carries every version source in lockstep. - The six "?? '0.0.0-private'" fallback literals across the CLI are replaced with "?? getKtxCliPackageInfo().version", and createDefaultKtxMcpServer makes its version arg required. - docs/release.md describes the actual commit-back model: the dev tree always reflects the most recent release; no sentinel pin to maintain. Verified: pnpm run artifacts:build now produces kaelio-ktx-0.4.1.tgz and kaelio_ktx-0.4.1-py3-none-any.whl with @kaelio/ktx@0.4.1 inside. Full type-check, dead-code, and 2287 vitests + 173 script tests pass. * refactor(cli): inject embedding provider resolution and detect sentence-transformers runtime Make resolveProjectEmbeddingProvider and runtimeIo injectable in ingest and scan command entrypoints so tests can stub them, and teach resolvePublicIngestRuntimeRequirements to flag the local-embeddings runtime feature when ktx.yaml selects sentence-transformers. * chore(cli): mark buildLocalStatsStatus and LocalStatsStatus as @internal Both symbols are consumed only by status-project.test.ts. Annotating with /** @internal */ keeps knip's production-mode check clean without changing runtime behavior. * fix(cli): use real package metadata in print-command-tree The stubbed package name embedded a forbidden product identifier that tripped the boundary check in CI. Read the metadata from package.json instead — keeps the rendered tree unchanged and removes a duplicate source of truth. * feat(cli): show embedding coverage in `ktx status`, drop duplicate disk counts Inline `(N embedded)` next to the Wiki scope counts and Semantic-layer source counts, computed with `SUM(embedding_json IS NOT NULL)` over `knowledge_pages` and `local_sl_sources`. Rename the "Knowledge" label to "Wiki" (canonical per `docs/terminology.md`) and rename the matching `localStats.knowledgePages` field to `localStats.wikiPages`. Drop `wiki=N md` and `semantic-layer=N yaml` from the Disk row — those duplicated the per-surface rows above. Disk now reports only actual byte usage (db, cache, raw-sources). The unused `wikiGlobalMarkdownCount` / `semanticLayerYamlCount` fields, the `isMarkdownEntry` / `isYamlEntry` helpers, and the `filter` arg on `summarizeDir` are removed.
195 lines
6.4 KiB
TypeScript
195 lines
6.4 KiB
TypeScript
import { createHash } from 'node:crypto';
|
|
import { type KtxLogger, noopLogger } from '../../../context/core/config.js';
|
|
import type { JsonValue } from '../ports.js';
|
|
import type { ContextCandidateStorePort } from './store.js';
|
|
import type {
|
|
BudgetExhaustedCandidateForCarryForward,
|
|
ContextCandidateCarryforwardSettings,
|
|
CurrentRunEvidenceChunkForCarryForward,
|
|
} from './types.js';
|
|
|
|
export interface ContextCandidateCarryforwardArgs {
|
|
runId: string;
|
|
connectionId: string;
|
|
sourceKey: string;
|
|
}
|
|
|
|
export interface ContextCandidateCarryforwardResult {
|
|
considered: number;
|
|
carriedForward: number;
|
|
skippedNotReemitted: number;
|
|
remappedEvidenceRefs: number;
|
|
staleEvidenceRefs: number;
|
|
warnings: string[];
|
|
}
|
|
|
|
export interface ContextCandidateCarryforwardServiceDeps {
|
|
store: ContextCandidateStorePort;
|
|
settings: ContextCandidateCarryforwardSettings;
|
|
logger?: KtxLogger;
|
|
}
|
|
|
|
export class ContextCandidateCarryforwardService {
|
|
private readonly logger: KtxLogger;
|
|
|
|
constructor(private readonly deps: ContextCandidateCarryforwardServiceDeps) {
|
|
this.logger = deps.logger ?? noopLogger;
|
|
}
|
|
|
|
async carryForward(args: ContextCandidateCarryforwardArgs): Promise<ContextCandidateCarryforwardResult> {
|
|
const candidates = await this.deps.store.listBudgetExhaustedCandidatesForCarryForward({
|
|
connectionId: args.connectionId,
|
|
sourceKey: args.sourceKey,
|
|
currentRunId: args.runId,
|
|
});
|
|
const chunks = await this.deps.store.listCurrentRunEvidenceChunksForCarryForward(args.runId);
|
|
const chunksByStableKey = new Map(chunks.map((chunk) => [chunk.stableCitationKey, chunk]));
|
|
const allowStaleEvidence = this.deps.settings.reExamineBudgetExhaustedOnRerun;
|
|
|
|
let carriedForward = 0;
|
|
let skippedNotReemitted = 0;
|
|
let remappedEvidenceRefs = 0;
|
|
let staleEvidenceRefs = 0;
|
|
|
|
for (const candidate of candidates) {
|
|
const remap = this.remapEvidence(candidate, chunksByStableKey);
|
|
if (remap.remappedCount === 0 && !allowStaleEvidence) {
|
|
skippedNotReemitted += 1;
|
|
continue;
|
|
}
|
|
|
|
await this.deps.store.insertCandidate({
|
|
runId: args.runId,
|
|
connectionId: args.connectionId,
|
|
sourceKey: args.sourceKey,
|
|
candidateKey: candidate.candidateKey,
|
|
topic: candidate.topic,
|
|
assertion: candidate.assertion,
|
|
rationale: candidate.rationale,
|
|
evidenceChunkIds: remap.evidenceChunkIds,
|
|
evidenceRefs: remap.evidenceRefs,
|
|
suggestedPageKey: candidate.suggestedPageKey,
|
|
actionHint: candidate.actionHint,
|
|
durabilityScore: candidate.durabilityScore,
|
|
authorityScore: candidate.authorityScore,
|
|
reuseScore: candidate.reuseScore,
|
|
noveltyScore: candidate.noveltyScore,
|
|
riskScore: candidate.riskScore,
|
|
promotionScore: candidate.promotionScore,
|
|
status: 'pending',
|
|
rejectionReason: null,
|
|
lane: candidate.lane,
|
|
embedding: null,
|
|
});
|
|
|
|
carriedForward += 1;
|
|
remappedEvidenceRefs += remap.remappedCount;
|
|
staleEvidenceRefs += remap.staleCount;
|
|
}
|
|
|
|
const warnings = this.buildWarnings({ carriedForward, skippedNotReemitted, staleEvidenceRefs });
|
|
if (carriedForward > 0 || skippedNotReemitted > 0) {
|
|
this.logger.log(
|
|
`Budget carryforward: considered ${candidates.length}, carried ${carriedForward}, skipped ${skippedNotReemitted}`,
|
|
);
|
|
}
|
|
|
|
return {
|
|
considered: candidates.length,
|
|
carriedForward,
|
|
skippedNotReemitted,
|
|
remappedEvidenceRefs,
|
|
staleEvidenceRefs,
|
|
warnings,
|
|
};
|
|
}
|
|
|
|
private remapEvidence(
|
|
candidate: BudgetExhaustedCandidateForCarryForward,
|
|
chunksByStableKey: Map<string, CurrentRunEvidenceChunkForCarryForward>,
|
|
): { evidenceChunkIds: string[]; evidenceRefs: JsonValue; remappedCount: number; staleCount: number } {
|
|
const refs = Array.isArray(candidate.evidenceRefs) ? candidate.evidenceRefs : [];
|
|
const remappedRefs: JsonValue[] = [];
|
|
const remappedChunkIds: string[] = [];
|
|
|
|
for (const ref of refs) {
|
|
const stableKey = this.stableCitationKey(ref);
|
|
const currentChunk = stableKey ? chunksByStableKey.get(stableKey) : undefined;
|
|
if (!currentChunk) {
|
|
continue;
|
|
}
|
|
|
|
remappedChunkIds.push(currentChunk.chunkId);
|
|
remappedRefs.push(this.currentEvidenceRef(currentChunk));
|
|
}
|
|
|
|
if (remappedRefs.length > 0) {
|
|
return {
|
|
evidenceChunkIds: [...new Set(remappedChunkIds)],
|
|
evidenceRefs: remappedRefs,
|
|
remappedCount: remappedRefs.length,
|
|
staleCount: 0,
|
|
};
|
|
}
|
|
|
|
return {
|
|
evidenceChunkIds: candidate.evidenceChunkIds,
|
|
evidenceRefs: candidate.evidenceRefs,
|
|
remappedCount: 0,
|
|
staleCount: refs.length,
|
|
};
|
|
}
|
|
|
|
private stableCitationKey(ref: JsonValue): string | null {
|
|
if (!ref || typeof ref !== 'object' || Array.isArray(ref)) {
|
|
return null;
|
|
}
|
|
const value = (ref as Record<string, JsonValue>).stableCitationKey;
|
|
return typeof value === 'string' ? value : null;
|
|
}
|
|
|
|
private currentEvidenceRef(chunk: CurrentRunEvidenceChunkForCarryForward): JsonValue {
|
|
return {
|
|
chunkId: chunk.chunkId,
|
|
stableCitationKey: chunk.stableCitationKey,
|
|
syncId: chunk.syncId,
|
|
rawPath: chunk.rawPath,
|
|
title: chunk.title,
|
|
path: chunk.path,
|
|
url: chunk.url,
|
|
lastEditedAt: chunk.lastEditedAt?.toISOString() ?? null,
|
|
snippetHash: createHash('sha256').update(chunk.content).digest('hex'),
|
|
citation: chunk.citation,
|
|
};
|
|
}
|
|
|
|
private buildWarnings(params: {
|
|
carriedForward: number;
|
|
skippedNotReemitted: number;
|
|
staleEvidenceRefs: number;
|
|
}): string[] {
|
|
const warnings: string[] = [];
|
|
if (params.carriedForward > 0) {
|
|
warnings.push(
|
|
`Re-examined ${params.carriedForward} prior budget-exhausted context candidate${
|
|
params.carriedForward === 1 ? '' : 's'
|
|
}.`,
|
|
);
|
|
}
|
|
if (params.skippedNotReemitted > 0) {
|
|
warnings.push(
|
|
`Skipped ${params.skippedNotReemitted} budget-exhausted context candidate${
|
|
params.skippedNotReemitted === 1 ? '' : 's'
|
|
} because its evidence was not re-emitted in this run.`,
|
|
);
|
|
}
|
|
if (params.staleEvidenceRefs > 0) {
|
|
warnings.push(
|
|
`Carried ${params.staleEvidenceRefs} budget-exhausted evidence ref${
|
|
params.staleEvidenceRefs === 1 ? '' : 's'
|
|
} without a current-run chunk remap.`,
|
|
);
|
|
}
|
|
return warnings;
|
|
}
|
|
}
|