mirror of
https://github.com/Kaelio/ktx.git
synced 2026-06-10 08:05:14 +02:00
* refactor(workspace): relocate @ktx/llm source into packages/cli/src/llm * refactor(workspace): rewrite @ktx/llm imports to relative paths * refactor(workspace): fold internal packages into cli * chore(workspace): gate dead-code with knip production mode Turn on production-mode knip plus an autofix run in pre-commit and the `pnpm dead-code` script, document the `/** @internal */` convention for test-only exports in AGENTS.md, annotate test-only exports across the CLI with that JSDoc, and drop dead exports/wrappers the new gate surfaced (e.g. `cli-project.ts`, `lookerRuntimeSourceToFileAdapterSource`, `createLocalScanEnrichmentProvidersFromConfig`, `PGLITE_OWNER_PROCESS_BACKEND_CAPABILITIES`, stale type re-exports). Replace the loose `ignoreIssues` allowlist in `knip.json` with explicit production entries so cross-package barrel leaks are caught. * refactor(cli): delete internal barrel index.ts files The 34 `index.ts` re-export barrels inside `packages/cli/src/` were holdovers from the pre-fold multi-workspace structure. Post-fold-in they served no production purpose: external consumers go through the single package main entry, and in-repo callers mostly imported through them only because the path was short. Internally, knip flagged most barrel re-exports as production-dead (only reached via tests). This change: - Deletes every internal barrel except `packages/cli/src/index.ts` (the published package entry). - Rewrites ~270 source/test files to import each name directly from the file that defines it. - Moves `tools/warehouse-verification/index.ts` to `create-warehouse-verification-tools.ts` (the function it defined locally) and updates its single consumer. - Renames `search/backend-conformance.ts` → `.test-utils.ts` to match the existing test-helper file convention. - Deletes 13 dead test-only chains (dbt-descriptions/*, live-database/extracted-schema, live-database/structural-sync, relationship-* feedback/review chain) plus their tests and a cascading orphan integration test. - Updates test mocks that pointed at deleted barrel paths (notion-client, connector barrels in scan/local-scan-connectors tests) to mock the source files instead. - Points the maintainer benchmark script (`scripts/relationship-benchmark-report.mjs`) at source files instead of `dist/context/scan/index.js`. - Drops the barrel `!` entries from `knip.json`; adds explicit production entries only for the benchmark code reached via dist by the maintainer script. Net: 413 files changed, ~1.2k insertions, ~9.4k deletions. `pnpm run dead-code` (Biome + knip default + knip production) and `pnpm run type-check` are clean; 2277 tests pass. * refactor(workspace): rename @ktx/cli to @kaelio/ktx and pack it directly Promote the CLI workspace package to the public name `@kaelio/ktx` and drop the separate `scripts/build-public-npm-package.mjs` wrapper. The CLI package is now publishable in place (`publishConfig.access: public`, `provenance: true`), so artifact packing uses `pnpm pack` against `packages/cli/` instead of assembling a parallel package tree. Updates all workspace filter invocations, docs, tests, and release readiness checks to reference the new package name, and folds the tarball-name helper into `scripts/public-npm-release-metadata.mjs`. * docs: align "agent clients" and "data agents" terminology Replace "client agents" with "agent clients" and "database agents" with "data agents" across AGENTS.md, README.md, the docs-site copy, and the matching setup-agents test description, matching the canonical vocabulary in docs/terminology.md. Also moves packages/cli/tsconfig.json's tsBuildInfoFile from node_modules/.cache/ to dist/.tsbuildinfo so incremental builds survive node_modules reinstalls. * refactor(release): single source of truth for package version Make packages/cli/package.json the single source of truth for the @kaelio/ktx version. publicNpmPackageVersion() now reads it directly, so artifact filenames, release-readiness checks, and the Python wheel version all derive from one field. The duplicate release-policy.json.publicNpmPackageVersion is removed. Previously the two fields could drift: tarballs were named kaelio-ktx-0.4.1.tgz while internally containing @kaelio/ktx@0.0.0-private. - update-public-release-version.mjs rewrites both Python pyproject.toml files (ktx-daemon, ktx-sl) alongside the npm package.jsons, normalizing the version for PEP 440 (e.g. 0.1.0-rc.2 -> 0.1.0rc2). - semantic-release-config.cjs adds the two pyproject.toml files to @semantic-release/git assets so the release commit back to main carries every version source in lockstep. - The six "?? '0.0.0-private'" fallback literals across the CLI are replaced with "?? getKtxCliPackageInfo().version", and createDefaultKtxMcpServer makes its version arg required. - docs/release.md describes the actual commit-back model: the dev tree always reflects the most recent release; no sentinel pin to maintain. Verified: pnpm run artifacts:build now produces kaelio-ktx-0.4.1.tgz and kaelio_ktx-0.4.1-py3-none-any.whl with @kaelio/ktx@0.4.1 inside. Full type-check, dead-code, and 2287 vitests + 173 script tests pass. * refactor(cli): inject embedding provider resolution and detect sentence-transformers runtime Make resolveProjectEmbeddingProvider and runtimeIo injectable in ingest and scan command entrypoints so tests can stub them, and teach resolvePublicIngestRuntimeRequirements to flag the local-embeddings runtime feature when ktx.yaml selects sentence-transformers. * chore(cli): mark buildLocalStatsStatus and LocalStatsStatus as @internal Both symbols are consumed only by status-project.test.ts. Annotating with /** @internal */ keeps knip's production-mode check clean without changing runtime behavior. * fix(cli): use real package metadata in print-command-tree The stubbed package name embedded a forbidden product identifier that tripped the boundary check in CI. Read the metadata from package.json instead — keeps the rendered tree unchanged and removes a duplicate source of truth. * feat(cli): show embedding coverage in `ktx status`, drop duplicate disk counts Inline `(N embedded)` next to the Wiki scope counts and Semantic-layer source counts, computed with `SUM(embedding_json IS NOT NULL)` over `knowledge_pages` and `local_sl_sources`. Rename the "Knowledge" label to "Wiki" (canonical per `docs/terminology.md`) and rename the matching `localStats.knowledgePages` field to `localStats.wikiPages`. Drop `wiki=N md` and `semantic-layer=N yaml` from the Disk row — those duplicated the per-surface rows above. Disk now reports only actual byte usage (db, cache, raw-sources). The unused `wikiGlobalMarkdownCount` / `semanticLayerYamlCount` fields, the `isMarkdownEntry` / `isYamlEntry` helpers, and the `filter` arg on `summarizeDir` are removed.
282 lines
9.4 KiB
TypeScript
282 lines
9.4 KiB
TypeScript
import { randomUUID } from 'node:crypto';
|
|
import { createServer, type IncomingHttpHeaders, type IncomingMessage, type Server, type ServerResponse } from 'node:http';
|
|
import { loadKtxProject } from './context/project/project.js';
|
|
import type { McpServer } from '@modelcontextprotocol/sdk/server/mcp.js';
|
|
import { StreamableHTTPServerTransport } from '@modelcontextprotocol/sdk/server/streamableHttp.js';
|
|
import { isInitializeRequest } from '@modelcontextprotocol/sdk/types.js';
|
|
import { getKtxCliPackageInfo, type KtxCliIo } from './cli-runtime.js';
|
|
import { createKtxMcpServerFactory } from './mcp-server-factory.js';
|
|
|
|
const DEFAULT_ALLOWED_HOSTS = ['localhost', '127.0.0.1', '::1'] as const;
|
|
|
|
export interface McpSecurityConfigInput {
|
|
host: string;
|
|
port: number;
|
|
token?: string;
|
|
allowedHosts: string[];
|
|
allowedOrigins: string[];
|
|
}
|
|
|
|
export interface McpSecurityConfig {
|
|
host: string;
|
|
port: number;
|
|
token?: string;
|
|
allowedHosts: string[];
|
|
allowedOrigins: string[];
|
|
}
|
|
|
|
/** @internal */
|
|
export type McpAuthorizationResult =
|
|
| { ok: true }
|
|
| { ok: false; status: 401 | 403; message: string };
|
|
|
|
function isLoopbackHost(host: string): boolean {
|
|
const normalized = normalizeHostHeader(host);
|
|
return normalized === 'localhost' || normalized === '127.0.0.1' || normalized === '::1';
|
|
}
|
|
|
|
/** @internal */
|
|
export function normalizeHostHeader(value: string): string {
|
|
const trimmed = value.trim().toLowerCase();
|
|
if (trimmed.startsWith('[')) {
|
|
const close = trimmed.indexOf(']');
|
|
return close >= 0 ? trimmed.slice(1, close) : trimmed.replace(/^\[/, '');
|
|
}
|
|
const colon = trimmed.lastIndexOf(':');
|
|
if (colon > -1 && trimmed.indexOf(':') === colon) {
|
|
return trimmed.slice(0, colon);
|
|
}
|
|
return trimmed;
|
|
}
|
|
|
|
function fullOrigin(value: string): string {
|
|
let parsed: URL;
|
|
try {
|
|
parsed = new URL(value);
|
|
} catch {
|
|
throw new Error(`Allowed origin must be a full origin URL: ${value}`);
|
|
}
|
|
if (!parsed.protocol || !parsed.host || parsed.pathname !== '/' || parsed.search || parsed.hash) {
|
|
throw new Error(`Allowed origin must be a full origin URL: ${value}`);
|
|
}
|
|
return parsed.origin;
|
|
}
|
|
|
|
export function buildMcpSecurityConfig(input: McpSecurityConfigInput): McpSecurityConfig {
|
|
if (!isLoopbackHost(input.host) && !input.token) {
|
|
throw new Error(`Binding KTX MCP to ${input.host} requires --token or KTX_MCP_TOKEN`);
|
|
}
|
|
const allowedHostSet = new Set<string>(DEFAULT_ALLOWED_HOSTS);
|
|
if (!isLoopbackHost(input.host)) {
|
|
allowedHostSet.add(normalizeHostHeader(input.host));
|
|
}
|
|
for (const host of input.allowedHosts) {
|
|
allowedHostSet.add(normalizeHostHeader(host));
|
|
}
|
|
return {
|
|
host: input.host,
|
|
port: input.port,
|
|
...(input.token ? { token: input.token } : {}),
|
|
allowedHosts: [...allowedHostSet],
|
|
allowedOrigins: input.allowedOrigins.map(fullOrigin),
|
|
};
|
|
}
|
|
|
|
function headerValue(headers: IncomingHttpHeaders | Record<string, string | undefined>, name: string): string | undefined {
|
|
const value = headers[name.toLowerCase()];
|
|
return Array.isArray(value) ? value[0] : value;
|
|
}
|
|
|
|
/** @internal */
|
|
export function isMcpRequestAuthorized(
|
|
request: { path: string; headers: IncomingHttpHeaders | Record<string, string | undefined> },
|
|
config: McpSecurityConfig,
|
|
): McpAuthorizationResult {
|
|
const host = headerValue(request.headers, 'host');
|
|
if (!host || !config.allowedHosts.includes(normalizeHostHeader(host))) {
|
|
return { ok: false, status: 403, message: 'Host header is not allowed for KTX MCP.' };
|
|
}
|
|
const origin = headerValue(request.headers, 'origin');
|
|
if (origin && !config.allowedOrigins.includes(origin)) {
|
|
return { ok: false, status: 403, message: 'Origin header is not allowed for KTX MCP.' };
|
|
}
|
|
if (request.path === '/mcp' && config.token) {
|
|
const auth = headerValue(request.headers, 'authorization');
|
|
if (auth !== `Bearer ${config.token}`) {
|
|
return { ok: false, status: 401, message: 'Missing or invalid KTX MCP bearer token.' };
|
|
}
|
|
}
|
|
return { ok: true };
|
|
}
|
|
|
|
export interface KtxMcpHttpServerHandle {
|
|
server: Server;
|
|
close(): Promise<void>;
|
|
}
|
|
|
|
export interface RunKtxMcpHttpServerOptions extends McpSecurityConfigInput {
|
|
projectDir: string;
|
|
cliVersion?: string;
|
|
io?: KtxCliIo;
|
|
createMcpServer?: () => McpServer;
|
|
loadProject?: typeof loadKtxProject;
|
|
}
|
|
|
|
function writeJson(res: ServerResponse, status: number, body: object): void {
|
|
const payload = `${JSON.stringify(body)}\n`;
|
|
res.writeHead(status, {
|
|
'content-type': 'application/json',
|
|
'content-length': Buffer.byteLength(payload),
|
|
});
|
|
res.end(payload);
|
|
}
|
|
|
|
function writeText(res: ServerResponse, status: number, body: string): void {
|
|
res.writeHead(status, { 'content-type': 'text/plain; charset=utf-8' });
|
|
res.end(body);
|
|
}
|
|
|
|
function requestPath(req: IncomingMessage): string {
|
|
const url = new URL(req.url ?? '/', 'http://127.0.0.1');
|
|
return url.pathname;
|
|
}
|
|
|
|
async function readJsonBody(req: IncomingMessage): Promise<unknown> {
|
|
const chunks: Buffer[] = [];
|
|
for await (const chunk of req) {
|
|
chunks.push(Buffer.isBuffer(chunk) ? chunk : Buffer.from(chunk));
|
|
}
|
|
const raw = Buffer.concat(chunks).toString('utf8');
|
|
return raw.trim().length === 0 ? undefined : (JSON.parse(raw) as unknown);
|
|
}
|
|
|
|
function listenerPort(server: Server, fallback: number): number {
|
|
const address = server.address();
|
|
return typeof address === 'object' && address ? address.port : fallback;
|
|
}
|
|
|
|
function transportAllowedHosts(config: McpSecurityConfig, server: Server): string[] {
|
|
const port = listenerPort(server, config.port);
|
|
const hosts = new Set<string>(config.allowedHosts);
|
|
for (const host of config.allowedHosts) {
|
|
hosts.add(`${host}:${port}`);
|
|
if (config.port !== 0 && config.port !== port) {
|
|
hosts.add(`${host}:${config.port}`);
|
|
}
|
|
}
|
|
return [...hosts];
|
|
}
|
|
|
|
export async function runKtxMcpHttpServer(options: RunKtxMcpHttpServerOptions): Promise<KtxMcpHttpServerHandle> {
|
|
const config = buildMcpSecurityConfig(options);
|
|
const project =
|
|
options.createMcpServer === undefined
|
|
? await (options.loadProject ?? loadKtxProject)({ projectDir: options.projectDir })
|
|
: undefined;
|
|
const createMcpServer =
|
|
options.createMcpServer ??
|
|
(await createKtxMcpServerFactory({
|
|
project: project!,
|
|
projectDir: options.projectDir,
|
|
cliVersion: options.cliVersion ?? getKtxCliPackageInfo().version,
|
|
io: options.io,
|
|
}));
|
|
const sessions = new Map<string, StreamableHTTPServerTransport>();
|
|
|
|
async function newTransport(): Promise<StreamableHTTPServerTransport> {
|
|
let transport: StreamableHTTPServerTransport;
|
|
transport = new StreamableHTTPServerTransport({
|
|
sessionIdGenerator: () => randomUUID(),
|
|
onsessioninitialized: (sessionId) => {
|
|
sessions.set(sessionId, transport);
|
|
},
|
|
onsessionclosed: (sessionId) => {
|
|
sessions.delete(sessionId);
|
|
},
|
|
allowedHosts: transportAllowedHosts(config, server),
|
|
allowedOrigins: config.allowedOrigins,
|
|
enableDnsRebindingProtection: true,
|
|
});
|
|
transport.onclose = () => {
|
|
if (transport.sessionId) {
|
|
sessions.delete(transport.sessionId);
|
|
}
|
|
};
|
|
await createMcpServer().connect(transport);
|
|
return transport;
|
|
}
|
|
|
|
const server = createServer(async (req, res) => {
|
|
const path = requestPath(req);
|
|
const auth = isMcpRequestAuthorized({ path, headers: req.headers }, config);
|
|
if (!auth.ok) {
|
|
writeText(res, auth.status, auth.message);
|
|
return;
|
|
}
|
|
|
|
if (path === '/health' && req.method === 'GET') {
|
|
const port = listenerPort(server, config.port);
|
|
writeJson(res, 200, { status: 'ok', projectDir: options.projectDir, port });
|
|
return;
|
|
}
|
|
|
|
if (path !== '/mcp' || !['POST', 'GET', 'DELETE'].includes(req.method ?? '')) {
|
|
writeText(res, 404, 'Not found');
|
|
return;
|
|
}
|
|
|
|
const sessionId = req.headers['mcp-session-id'];
|
|
const normalizedSessionId = Array.isArray(sessionId) ? sessionId[0] : sessionId;
|
|
|
|
if (req.method === 'POST') {
|
|
let body: unknown;
|
|
try {
|
|
body = await readJsonBody(req);
|
|
} catch (error) {
|
|
writeText(res, 400, `Invalid JSON body: ${error instanceof Error ? error.message : String(error)}`);
|
|
return;
|
|
}
|
|
const existing = normalizedSessionId ? sessions.get(normalizedSessionId) : undefined;
|
|
if (existing) {
|
|
await existing.handleRequest(req, res, body);
|
|
return;
|
|
}
|
|
if (normalizedSessionId) {
|
|
writeText(res, 404, `Unknown MCP session: ${normalizedSessionId}`);
|
|
return;
|
|
}
|
|
if (!isInitializeRequest(body)) {
|
|
writeText(res, 400, 'MCP initialize request is required before session traffic.');
|
|
return;
|
|
}
|
|
await (await newTransport()).handleRequest(req, res, body);
|
|
return;
|
|
}
|
|
|
|
if (!normalizedSessionId || !sessions.has(normalizedSessionId)) {
|
|
writeText(res, 404, normalizedSessionId ? `Unknown MCP session: ${normalizedSessionId}` : 'Missing MCP session id.');
|
|
return;
|
|
}
|
|
await sessions.get(normalizedSessionId)!.handleRequest(req, res);
|
|
});
|
|
|
|
await new Promise<void>((resolve, reject) => {
|
|
server.once('error', reject);
|
|
server.listen(config.port, config.host, () => {
|
|
server.off('error', reject);
|
|
resolve();
|
|
});
|
|
});
|
|
|
|
return {
|
|
server,
|
|
async close() {
|
|
for (const transport of sessions.values()) {
|
|
await transport.close();
|
|
}
|
|
await new Promise<void>((resolve, reject) => {
|
|
server.close((error) => (error ? reject(error) : resolve()));
|
|
});
|
|
},
|
|
};
|
|
}
|