mirror of
https://github.com/Kaelio/ktx.git
synced 2026-06-10 08:05:14 +02:00
* feat(cli): define full warehouse dialect contract
* test(cli): keep dialect edge tests focused
* fix(cli): stabilize dialect contract foundation
* refactor(connectors): own read-only query preparation
* refactor(connectors): resolve dialects through registry
* refactor(connectors): keep concrete dialect classes internal
* chore(workspace): enforce dialect import boundary
* refactor(cli): resolve relationship dialect at scan boundary
* refactor(cli): use dialect display parsing for entity details
* refactor(cli): use dialect display parsing for warehouse catalog
* refactor(cli): use dialect SQL in relationship workflows
* test(cli): verify solid dialect scan workflow closure
* test: split cli tests from source tree
* refactor(cli): standardize BigQuery scope listing
* feat(sqlite): implement connector scope listing
* test(connectors): cover required table listing
* feat(cli): add warehouse driver registry
* refactor(setup): route scope discovery through driver registry
* refactor(cli): route local query execution through driver registry
* refactor(historic-sql): route dialect support through driver registry
* refactor(cli): test warehouse connections through driver registry
* fix(cli): close driver registry type export gaps
* Improve setup daemon diagnostics
* refactor(setup): centralize rail-prefixed diagnostics + query-history fallback
Extract errorMessage, writePrefixedLines, and flushPrefixedBufferedCommandOutput
into clack.ts so the setup wizard, managed daemons, and embedding/agent steps
share one rail-formatted writer. setup-databases.ts also adds a
"disable query history and retry" option when the schema-context build fails
and query history is the likely culprit, surfaced via a new
failed-query-history-unavailable status.
* fix(cli): carry catalog through the picker so BigQuery/Snowflake/SQL Server scope filters match
The setup picker's KtxTableListEntry was a 2-level { schema, name }, so
qualifiedTableId always wrote db.name into enabled_tables. When BigQuery,
Snowflake, or SQL Server later ran fast ingest, their introspect step filtered
the scope set with scopedTableNames(scope, { catalog: projectId|database, db })
— catalog was non-null on the introspect side but null in the scope refs, so
every entry was rejected, the live-database adapter staged zero table files,
and detect() failed with 'Adapter "live-database" did not recognize fetched
source output'.
Align the picker boundary with the canonical 3-level KtxTableRef:
- Add catalog: string | null to KtxTableListEntry.
- BigQuery/Snowflake/SQL Server listTables populate catalog from the
resolved projectId / database; Postgres/MySQL/ClickHouse/SQLite set null.
- qualifiedTableId emits catalog.schema.name when catalog is non-null
(resolveEnabledTables already accepts the 3-part shape) and
schemasFromEnabledTables now goes through parseDottedTableEntry so it
recovers the schema correctly from both 2-part and 3-part entries.
- Export parseDottedTableEntry from enabled-tables.ts (@internal) for picker
reuse.
Update listTables expectations in all seven connector tests and the setup /
picker test fixtures. Add a picker regression test that covers the
catalog-bearing round-trip (save + refine).
* fix(cli): allow debug telemetry under opt-out env
122 lines
3 KiB
TypeScript
122 lines
3 KiB
TypeScript
import { cancel, confirm, isCancel, log, spinner } from '@clack/prompts';
|
|
import type { KtxCliIo } from './cli-runtime.js';
|
|
|
|
const ESC = String.fromCharCode(0x1b);
|
|
|
|
export interface RailBufferedSource {
|
|
stdoutText(): string;
|
|
stderrText(): string;
|
|
}
|
|
|
|
export function errorMessage(error: unknown): string {
|
|
return error instanceof Error ? error.message : String(error);
|
|
}
|
|
|
|
export function writePrefixedLines(write: (chunk: string) => void, output: string): void {
|
|
for (const line of output.split(/\r?\n/)) {
|
|
if (line.length > 0) {
|
|
write(`│ ${line}\n`);
|
|
}
|
|
}
|
|
}
|
|
|
|
export function flushPrefixedBufferedCommandOutput(io: KtxCliIo, buffered: RailBufferedSource): void {
|
|
writePrefixedLines((chunk) => io.stdout.write(chunk), buffered.stdoutText());
|
|
writePrefixedLines((chunk) => io.stderr.write(chunk), buffered.stderrText());
|
|
}
|
|
|
|
export interface KtxCliSpinner {
|
|
start(message: string): void;
|
|
message(message: string): void;
|
|
stop(message: string): void;
|
|
error(message: string): void;
|
|
}
|
|
|
|
export interface KtxCliSpinnerIo {
|
|
stderr: { write(chunk: string): void };
|
|
}
|
|
|
|
export interface KtxCliPromptAdapter {
|
|
confirm(options: { message: string; initialValue?: boolean }): Promise<boolean>;
|
|
cancel(message: string): void;
|
|
log: {
|
|
info(message: string): void;
|
|
warn(message: string): void;
|
|
error(message: string): void;
|
|
success(message: string): void;
|
|
step(message: string): void;
|
|
};
|
|
spinner(): KtxCliSpinner;
|
|
}
|
|
|
|
class KtxCliPromptCancelledError extends Error {
|
|
constructor(message = 'Operation cancelled.') {
|
|
super(message);
|
|
this.name = 'KtxCliPromptCancelledError';
|
|
}
|
|
}
|
|
|
|
export function createClackSpinner(): KtxCliSpinner {
|
|
return spinner();
|
|
}
|
|
|
|
function magenta(text: string): string {
|
|
return `${ESC}[35m${text}${ESC}[39m`;
|
|
}
|
|
|
|
function red(text: string): string {
|
|
return `${ESC}[31m${text}${ESC}[39m`;
|
|
}
|
|
|
|
export function createStaticCliSpinner(io: KtxCliSpinnerIo): KtxCliSpinner {
|
|
return {
|
|
start(message) {
|
|
io.stderr.write(`${magenta('◐')} ${message}\n`);
|
|
},
|
|
message(message) {
|
|
io.stderr.write(`${magenta('│')} ${message}\n`);
|
|
},
|
|
stop(message) {
|
|
io.stderr.write(`${magenta('◇')} ${message}\n`);
|
|
},
|
|
error(message) {
|
|
io.stderr.write(`${red('■')} ${message}\n`);
|
|
},
|
|
};
|
|
}
|
|
|
|
export function createClackPromptAdapter(): KtxCliPromptAdapter {
|
|
return {
|
|
async confirm(options) {
|
|
const value = await confirm(options);
|
|
if (isCancel(value)) {
|
|
cancel('Operation cancelled.');
|
|
throw new KtxCliPromptCancelledError();
|
|
}
|
|
return value;
|
|
},
|
|
cancel(message) {
|
|
cancel(message);
|
|
},
|
|
log: {
|
|
info(message) {
|
|
log.info(message);
|
|
},
|
|
warn(message) {
|
|
log.warn(message);
|
|
},
|
|
error(message) {
|
|
log.error(message);
|
|
},
|
|
success(message) {
|
|
log.success(message);
|
|
},
|
|
step(message) {
|
|
log.step(message);
|
|
},
|
|
},
|
|
spinner() {
|
|
return createClackSpinner();
|
|
},
|
|
};
|
|
}
|