mirror of
https://github.com/Kaelio/ktx.git
synced 2026-06-07 07:55:13 +02:00
* feat(completion): complete known argument values
* fix(completion): hide Commander-hidden subcommands from completions
Replace the `__`-prefix name heuristic with Commander's `_hidden` flag so
internal subcommands registered with { hidden: true } (e.g. `mcp serve-internal`)
are excluded from completions, mirroring `ktx --help`.
* test: cover wiki and sl read command routing
* test: cover raw wiki and sl reads
* feat: add wiki read command
* feat: add sl read command
* feat: complete read command entity names
* docs: document wiki and sl read commands
* test: include read commands in command tree
* feat(sl): read and validate unique sources by name
* feat(sl): make read and validate connection id optional
* fix(completion): dedupe semantic source names
* docs(sl): document connection-optional read and validate
* fix(sl): require connection id for query command
* docs(sl): clarify query connection requirement
* fix(completion): don't resolve option values as subcommands
resolveCommand skipped flag tokens but not the value consumed by a
value-taking option in the `--flag value` form, so a connection id like
`query` was matched as the `sl query` subcommand and yielded no `sl`
completions. Track value-taking options and skip their consumed value
before matching subcommands.
* test(telemetry): assert first-run notice via TELEMETRY_NOTICE constant
CI (which tests this branch merged with main) failed because #243 changed
the first-run notice wording in identity.ts (dropped "anonymous") but left
this test grepping for the old literal 'ktx collects anonymous usage data',
so indexOf returned -1. Assert against the exported TELEMETRY_NOTICE
constant instead so the test tracks the source of truth and cannot drift
when the notice text changes again.
134 lines
4.6 KiB
TypeScript
134 lines
4.6 KiB
TypeScript
import { mkdir, mkdtemp, rm, writeFile } from 'node:fs/promises';
|
|
import { tmpdir } from 'node:os';
|
|
import { join } from 'node:path';
|
|
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
|
|
|
|
import { runCommanderKtxCli } from '../src/cli-program.js';
|
|
import type { KtxCliDeps, KtxCliIo, KtxCliPackageInfo } from '../src/cli-runtime.js';
|
|
import { TELEMETRY_NOTICE } from '../src/telemetry/identity.js';
|
|
|
|
function makeIo(stdoutIsTTY = true): { io: KtxCliIo; stdout: () => string; stderr: () => string } {
|
|
let stdout = '';
|
|
let stderr = '';
|
|
return {
|
|
io: {
|
|
stdout: {
|
|
isTTY: stdoutIsTTY,
|
|
write: (chunk) => {
|
|
stdout += chunk;
|
|
},
|
|
},
|
|
stderr: {
|
|
write: (chunk) => {
|
|
stderr += chunk;
|
|
},
|
|
},
|
|
},
|
|
stdout: () => stdout,
|
|
stderr: () => stderr,
|
|
};
|
|
}
|
|
|
|
const info: KtxCliPackageInfo = { name: '@kaelio/ktx', version: '0.4.1' };
|
|
|
|
describe('runCommanderKtxCli telemetry', () => {
|
|
let tempDir: string;
|
|
const originalEnv = process.env;
|
|
|
|
beforeEach(async () => {
|
|
tempDir = await mkdtemp(join(tmpdir(), 'ktx-cli-telemetry-'));
|
|
await writeFile(join(tempDir, 'ktx.yaml'), '{}\n', 'utf-8');
|
|
vi.stubEnv('KTX_TELEMETRY_DEBUG', '1');
|
|
vi.stubEnv('HOME', tempDir);
|
|
vi.stubEnv('CI', '');
|
|
vi.stubEnv('KTX_TELEMETRY_DISABLED', '');
|
|
vi.stubEnv('DO_NOT_TRACK', '');
|
|
});
|
|
|
|
afterEach(async () => {
|
|
vi.unstubAllEnvs();
|
|
process.env = originalEnv;
|
|
await rm(tempDir, { recursive: true, force: true });
|
|
});
|
|
|
|
it('emits debug command telemetry for registered actions', async () => {
|
|
const io = makeIo(true);
|
|
await expect(
|
|
runCommanderKtxCli(
|
|
['--project-dir', tempDir, 'status', '--help'],
|
|
io.io,
|
|
{},
|
|
info,
|
|
{ runInit: async () => 0 },
|
|
),
|
|
).resolves.toBe(0);
|
|
|
|
expect(io.stderr()).not.toContain('[telemetry]');
|
|
|
|
const statusIo = makeIo(true);
|
|
const deps: KtxCliDeps = { doctor: async () => 0 };
|
|
|
|
await expect(
|
|
runCommanderKtxCli(
|
|
['--project-dir', tempDir, 'status', '--json'],
|
|
statusIo.io,
|
|
deps,
|
|
info,
|
|
{ runInit: async () => 0 },
|
|
),
|
|
).resolves.toBe(0);
|
|
|
|
expect(statusIo.stderr()).toContain('[telemetry]');
|
|
expect(statusIo.stderr()).toContain('"event":"install_first_run"');
|
|
expect(statusIo.stderr()).toContain('"event":"command"');
|
|
expect(statusIo.stderr()).toContain('"commandPath":["ktx","status"]');
|
|
expect(statusIo.stderr()).toContain('"event":"project_stack_snapshot"');
|
|
expect(statusIo.stderr()).toContain('"connectionCount"');
|
|
expect(statusIo.stderr()).not.toContain(tempDir);
|
|
|
|
const noticeIndex = statusIo.stderr().indexOf(TELEMETRY_NOTICE);
|
|
const firstTelemetryIndex = statusIo.stderr().indexOf('[telemetry]');
|
|
expect(noticeIndex).toBeGreaterThanOrEqual(0);
|
|
expect(firstTelemetryIndex).toBeGreaterThan(noticeIndex);
|
|
});
|
|
|
|
it('emits aborted telemetry when project validation aborts after preAction starts', async () => {
|
|
const missingProjectDir = join(tempDir, 'missing');
|
|
await mkdir(missingProjectDir, { recursive: true });
|
|
const io = makeIo(true);
|
|
|
|
await expect(
|
|
runCommanderKtxCli(
|
|
['--project-dir', missingProjectDir, 'connection'],
|
|
io.io,
|
|
{},
|
|
info,
|
|
{ runInit: async () => 0 },
|
|
),
|
|
).resolves.toBe(1);
|
|
|
|
expect(io.stderr()).toContain('[telemetry]');
|
|
expect(io.stderr()).toContain('"outcome":"aborted"');
|
|
expect(io.stderr()).toContain('"hasProject":false');
|
|
expect(io.stderr()).toContain('"projectGroupAttached":false');
|
|
expect(io.stderr()).not.toContain(missingProjectDir);
|
|
});
|
|
|
|
it('does not import or emit telemetry for help, version, bare non-TTY, or unknown top-level command', async () => {
|
|
const helpIo = makeIo(true);
|
|
await expect(runCommanderKtxCli(['--help'], helpIo.io, {}, info, { runInit: async () => 0 })).resolves.toBe(0);
|
|
expect(helpIo.stderr()).not.toContain('[telemetry]');
|
|
|
|
const versionIo = makeIo(true);
|
|
await expect(runCommanderKtxCli(['--version'], versionIo.io, {}, info, { runInit: async () => 0 })).resolves.toBe(0);
|
|
expect(versionIo.stderr()).not.toContain('[telemetry]');
|
|
|
|
const bareIo = makeIo(false);
|
|
await expect(runCommanderKtxCli([], bareIo.io, {}, info, { runInit: async () => 0 })).resolves.toBe(0);
|
|
expect(bareIo.stderr()).not.toContain('[telemetry]');
|
|
|
|
const unknownIo = makeIo(true);
|
|
await expect(runCommanderKtxCli(['unknown'], unknownIo.io, {}, info, { runInit: async () => 0 })).resolves.toBe(1);
|
|
expect(unknownIo.stderr()).not.toContain('[telemetry]');
|
|
});
|
|
});
|