mirror of
https://github.com/Kaelio/ktx.git
synced 2026-06-10 08:05:14 +02:00
0425160857
* fix(cli): fail clearly when ktx setup has no LLM backend under --no-input Non-interactive `ktx setup` silently defaulted the LLM backend to `anthropic` and then failed with `Missing Anthropic API key: pass --anthropic-api-key-env or --anthropic-api-key-file` — confusing for users who selected a different provider (e.g. `--target claude-code`) and never asked for the Anthropic API backend. That silent default could never succeed: it was reached only when no backend, Anthropic key, or Vertex flag was supplied, and in exactly that case the Anthropic credential resolver always failed (no env fallback in disabled mode). Unlike embeddings, the LLM has no credential-free default (anthropic needs a key, vertex needs gcloud ADC, claude-code/codex need a logged-in local CLI), so there is nothing safe to assume. `chooseBackend` now fails clearly in disabled mode with no backend, naming the (hidden) `--llm-backend` flag and its choices and noting each backend's credential needs. `--llm-backend` stays hidden in `--help`, consistent with the rest of the documented automation surface; the error message is the discovery path. - Add a unit test (no backend, disabled -> clear message) and a CLI/integration test (`--target claude-code --no-input` -> exit 1, clear message, not the Anthropic red herring). - Document the no-default behavior and add a Common-errors row in docs-site ktx-setup.mdx. * refactor(cli): single source of truth for setup LLM backends The set of LLM backends a user can pick during `ktx setup` (claude-code, codex, anthropic, vertex) was hand-enumerated in five places: the `--llm-backend` arg parser, the `KtxSetupLlmBackend` union, the interactive prompt's narrowing, the prompt options, and the missing-backend error. Only some had TypeScript coverage, so adding a backend could silently drift (e.g. a valid value rejected by the parser, or routed to anthropic by the prompt's `? : 'anthropic'` fallback). Collapse them onto one `KTX_SETUP_LLM_BACKENDS` list: - `KtxSetupLlmBackend` is derived from it. - `isKtxSetupLlmBackend` is the shared validator; the arg parser and the prompt both route through it instead of re-listing literals. - The prompt options derive from the list, with a `Record<KtxSetupLlmBackend, string>` label map so a new backend fails to compile until it has a label. - The missing-backend error builds its choice list from the same source. Behavior-preserving: identical accepted values and parse error, identical prompt options (asserted by an existing test), and the prompt's unreachable fallback now cancels rather than silently assuming anthropic. |
||
|---|---|---|
| .. | ||
| commands | ||
| completion | ||
| connectors | ||
| context | ||
| fixtures | ||
| io | ||
| llm | ||
| star-prompt | ||
| telemetry | ||
| update-check | ||
| admin-reindex.test.ts | ||
| admin.test.ts | ||
| cli-program-telemetry.test.ts | ||
| cli-program.test.ts | ||
| cli-runtime.test.ts | ||
| command-tree.test.ts | ||
| community-cta.test.ts | ||
| connection-recovery.test.ts | ||
| connection.test.ts | ||
| context-build-view.test.ts | ||
| database-tree-picker.test.ts | ||
| demo-assets.test.ts | ||
| demo-metrics.test.ts | ||
| doctor.test.ts | ||
| embedding-resolution.test.ts | ||
| example-smoke.test.ts | ||
| index.test.ts | ||
| ingest-query-executor.test.ts | ||
| ingest-report-file.test.ts | ||
| ingest-viz.test.ts | ||
| ingest.test-utils.ts | ||
| ingest.test.ts | ||
| knowledge.test.ts | ||
| local-adapters.test.ts | ||
| local-scan-connectors.test.ts | ||
| managed-local-embeddings.test.ts | ||
| managed-mcp-daemon.test.ts | ||
| managed-python-command.test.ts | ||
| managed-python-daemon.test.ts | ||
| managed-python-http.test.ts | ||
| managed-python-runtime.test.ts | ||
| mcp-http-server.test.ts | ||
| mcp-server-factory.test.ts | ||
| memory-flow-interactive.test.ts | ||
| memory-flow-tui.test.tsx | ||
| next-steps.test.ts | ||
| notion-page-picker.test.ts | ||
| print-command-tree.test.ts | ||
| progress-port-adapter.test.ts | ||
| project-dir.test.ts | ||
| project-resolver.test.ts | ||
| prompt-navigation.test.ts | ||
| proxy-env.test.ts | ||
| public-ingest-copy.test.ts | ||
| public-ingest.test.ts | ||
| reveal-password-prompt.test.ts | ||
| runtime-requirements.test.ts | ||
| runtime.test.ts | ||
| scan.test.ts | ||
| setup-agents.test.ts | ||
| setup-context.test.ts | ||
| setup-databases.test.ts | ||
| setup-demo-tour.test.ts | ||
| setup-embeddings.test.ts | ||
| setup-interrupt.test.ts | ||
| setup-models.test.ts | ||
| setup-project.test.ts | ||
| setup-prompts.test.ts | ||
| setup-ready-menu.test.ts | ||
| setup-runtime.test.ts | ||
| setup-secrets.test.ts | ||
| setup-sources-notion.test.ts | ||
| setup-sources.test.ts | ||
| setup.test.ts | ||
| sl.test.ts | ||
| source-mapping.test.ts | ||
| sql.test.ts | ||
| standalone-smoke.test.ts | ||
| status-project.test.ts | ||
| text-ingest.test.ts | ||
| tree-picker-state.test.ts | ||
| tree-picker-tui.test.tsx | ||
| viz-fallback.test.ts | ||