mirror of
https://github.com/Kaelio/ktx.git
synced 2026-07-01 08:59:39 +02:00
* refactor(connectors): split KtxDialect into core and KtxSqlDialect Separate the dialect contract into a driver-agnostic core (display/ref formatting and type mapping) and a SQL-only extension (query generators). The catalog and entity-details paths resolve the core dialect for any snapshot driver, so it must stay free of SQL generation; this is the prerequisite refactor for adding non-SQL primary sources. - KtxDialect keeps type, formatDisplayRef, parseDisplayRef, columnDisplayTablePartCount, mapDataType, mapToDimensionType - KtxSqlDialect extends it with quoteIdentifier, formatTableName, and the query/sample/statistics generators; the 7 SQL dialects implement it - add getSqlDialectForDriver for SQL drivers; the 7 connectors and the relationship-benchmark harness consume it - thread the relationship pipeline (profiling/validation/composite/ discovery) as KtxSqlDialect | null so a non-SQL source skips coverage SQL and its candidates stay in review; local-enrichment builds the SQL dialect only when the connector advertises readOnlySql Pure extraction: no behavior change for the existing 7 drivers. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat(connectors): add MongoDB connector for issue #305 Add a read-only MongoDB connector that treats a database as a primary context source: collections map to tables and inferred top-level fields to columns. MongoDB is the first non-SQL source (readOnlySql: false), so ktx sql and metric compilation do not apply, but its collections flow through ingest, descriptions, and relationship discovery. - schema-inference: infer a flat column schema from the most recent sample_size documents (by _id desc, or order_by for non-ObjectId keys). Union BSON types per field, mark multi-type fields mixed (string), keep sub-documents/arrays as a single opaque json column, derive nullability from presence, treat _id as the primary key - connector: KtxMongoDbScanConnector behind an injectable client seam; strictly read-only (find/listCollections/estimatedDocumentCount only), no executeReadOnly; resolves env:/file: via resolveKtxConfigReference - core-only KtxMongoDbDialect and a live-database introspection adapter - wire the mongodb driver: driver union, dialect registry, driver registration (scopeConfigKey databases), mongodbConnectionSchema, connection-drivers, normalizeDriver, the live-database route, and the ktx setup picker. ktx sql is refused by the read-only SQL capability gate - tests: schema inference, connector snapshot via a fake client, dialect, driver-schema parsing, and the ktx sql rejection Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * docs(integrations): document the MongoDB primary source Add a MongoDB section to the primary-sources reference: connection config (url, databases, enabled_tables, sample_size, order_by), mongodb+srv/TLS/ Atlas notes, the schema-inference explainer, a features matrix, and the non-SQL caveat. Update the frontmatter and connection field reference. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(connectors): address review blockers on the MongoDB connector - introspect: skip estimatedDocumentCount for views. The count command is rejected on a MongoDB view (CommandNotSupportedOnView), so counting a view aborted introspect for the whole connection; compute estimatedRows only for real collections, as ClickHouse does. - sl: refuse a semantic-layer query against a non-SQL connection instead of defaulting it to the Postgres dialect. compileLocalSlQuery (the shared CLI + MCP path) now rejects a driver with no SQL dialect via the new isSqlQueryableDriver authority, keeping MongoDB context-only per issue #305. - tests: cover input.tableScope and the empty-scope skip for the Mongo connector (the scan layer does not post-filter), the view no-count path, and the ktx sl query refusal for a mongodb connection. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * polish(mongodb): compute sampled nullCount and document sampling caveats Address the non-blocking review notes: - sampleColumn now counts null/absent values over the sampled window instead of returning nullCount: null, since the documents are already in hand - warn that a custom order_by must be indexed (an unindexed sort hits MongoDB's in-memory sort limit on large collections) in the connection schema and docs - note that sampled values for nested fields are stringified, not faithfully serialized, so the json opacity is deliberate Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * docs(examples): add a MongoDB connector example A manual, container-backed example mirroring examples/postgres-historic: - docker-compose.yml + init/seed.js seed a representative dataset (nested documents, arrays, a Decimal128, a mixed-type field, a nullable field, an ObjectId reference, and a view) on first container start - scripts/smoke.sh + introspect-smoke.mjs assert the connector's inferred schema with no LLM credentials — the same introspection entry point ktx ingest's database-schema stage uses, including the view-no-count path - README.md documents the smoke and a full keyless ktx ingest run (claude-code LLM + managed sentence-transformers embeddings) Works with Docker Compose or podman compose. Verified end to end. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * chore: ignore examples/** in knip to fix dead-code false positives The MongoDB connector example files (examples/mongodb/init/seed.js and examples/mongodb/scripts/introspect-smoke.mjs) are used at runtime but were flagged as unused by knip. Add examples/** to the ignore array, matching the existing .context/** entry. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0114qQV8fJ5a5ME3XbMVRzbL * fix(mongodb): refuse non-SQL connections before SQL analysis `ktx sql` and the MCP sql_execution tool resolved a SQL-analysis dialect (falling back to Postgres for a non-SQL driver) and ran read-only validation before the connector capability gate refused the connection. For a MongoDB connection that spun up the parser/daemon and produced Postgres parser diagnostics instead of a clean non-SQL refusal. Route both entry points through a shared assertSqlQueryableConnection guard before dialect selection, mirroring compileLocalSlQuery. The federated duckdb path has no driver and is exempted at each call site. Add CLI and MCP regression tests asserting validation/connector work never starts for a MongoDB connection. * fix(mongodb): pass CI gates (dialect boundary, secrets, setup test) Three latent failures in the connector surfaced once CI ran on the branch: - connector.ts imported the concrete KtxMongoDbDialect, which the connector dialect-import boundary forbids. Route it through getDialectForDriver('mongodb') and widen inferKtxMongoCollectionColumns to the base KtxDialect (it only uses mapDataType/mapToDimensionType). - detect-secrets flagged a test ObjectId hex and the mongodb+srv example URL; annotate both with allowlist pragmas. - the "shows every supported database" setup test omitted the new MongoDB option. --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Co-authored-by: Luca Martial <48870843+luca-martial@users.noreply.github.com> Co-authored-by: Luca Martial <lucamrtl@gmail.com> Co-authored-by: Andrey Avtomonov <andreybavt@gmail.com>
115 lines
5.3 KiB
TypeScript
115 lines
5.3 KiB
TypeScript
import { KtxBigQueryDialect } from '../../connectors/bigquery/dialect.js';
|
|
import { KtxClickHouseDialect } from '../../connectors/clickhouse/dialect.js';
|
|
import { KtxMongoDbDialect } from '../../connectors/mongodb/dialect.js';
|
|
import { KtxMysqlDialect } from '../../connectors/mysql/dialect.js';
|
|
import { KtxPostgresDialect } from '../../connectors/postgres/dialect.js';
|
|
import { KtxSqliteDialect } from '../../connectors/sqlite/dialect.js';
|
|
import { KtxSnowflakeDialect } from '../../connectors/snowflake/dialect.js';
|
|
import { KtxSqlServerDialect } from '../../connectors/sqlserver/dialect.js';
|
|
import { KtxExpectedError } from '../../errors.js';
|
|
import type { KtxConnectionDriver, KtxSchemaDimensionType, KtxTableRef } from '../scan/types.js';
|
|
import type { KtxDialectTableRef } from './dialect-helpers.js';
|
|
|
|
/**
|
|
* Driver-agnostic dialect surface every connection implements, including
|
|
* non-SQL sources like MongoDB: display/ref formatting and type mapping. The
|
|
* catalog and entity-details paths resolve this for any snapshot driver, so it
|
|
* must stay free of SQL generation.
|
|
*/
|
|
export interface KtxDialect {
|
|
readonly type: KtxConnectionDriver;
|
|
formatDisplayRef(table: KtxDialectTableRef): string;
|
|
parseDisplayRef(display: string): KtxTableRef | null;
|
|
columnDisplayTablePartCount(): 1 | 2 | 3;
|
|
mapToDimensionType(nativeType: string): KtxSchemaDimensionType;
|
|
mapDataType(nativeType: string): string;
|
|
}
|
|
|
|
/**
|
|
* SQL query generation, implemented only by SQL warehouse drivers. The relationship
|
|
* profiling/validation pipeline is the sole caller and is gated on the
|
|
* `readOnlySql` capability, so these methods are unreachable for a non-SQL source.
|
|
*/
|
|
export interface KtxSqlDialect extends KtxDialect {
|
|
quoteIdentifier(identifier: string): string;
|
|
formatTableName(table: KtxDialectTableRef): string;
|
|
getLimitOffsetClause(limit: number, offset?: number): string;
|
|
getTopClause(limit: number): string;
|
|
getRandomSampleFilter(samplePct: number): string;
|
|
getTableSampleClause(samplePct: number): string;
|
|
generateSampleQuery(tableName: string, limit: number, columns?: string[]): string;
|
|
generateColumnSampleQuery(tableName: string, columnName: string, limit: number): string;
|
|
getSampleValueAggregation(innerSql: string): string;
|
|
generateCardinalitySampleQuery(tableName: string, columnName: string, sampleSize: number): string;
|
|
generateRandomizedCardinalitySampleQuery(tableName: string, columnName: string, sampleSize: number): string;
|
|
generateDistinctValuesQuery(tableName: string, columnName: string, limit: number): string;
|
|
generateColumnStatisticsQuery(schemaName: string, tableName: string): string | null;
|
|
getNullCountExpression(column: string): string;
|
|
getDistinctCountExpression(column: string): string;
|
|
textLengthExpression(columnSql: string): string;
|
|
castToText(columnSql: string): string;
|
|
}
|
|
|
|
type KtxSqlDriver = Exclude<KtxConnectionDriver, 'mongodb'>;
|
|
|
|
const sqlDialectFactories: Record<KtxSqlDriver, () => KtxSqlDialect> = {
|
|
bigquery: () => new KtxBigQueryDialect(),
|
|
clickhouse: () => new KtxClickHouseDialect(),
|
|
mysql: () => new KtxMysqlDialect(),
|
|
postgres: () => new KtxPostgresDialect(),
|
|
sqlite: () => new KtxSqliteDialect(),
|
|
snowflake: () => new KtxSnowflakeDialect(),
|
|
sqlserver: () => new KtxSqlServerDialect(),
|
|
};
|
|
|
|
const dialectFactories: Record<KtxConnectionDriver, () => KtxDialect> = {
|
|
...sqlDialectFactories,
|
|
mongodb: () => new KtxMongoDbDialect(),
|
|
};
|
|
|
|
const supportedSqlDrivers = Object.keys(sqlDialectFactories).sort();
|
|
|
|
export function getDialectForDriver(driver: string): KtxDialect {
|
|
const normalized = driver.toLowerCase().trim();
|
|
const factory = dialectFactories[normalized as KtxConnectionDriver];
|
|
if (factory) {
|
|
return factory();
|
|
}
|
|
throw new Error(
|
|
`Unsupported driver "${driver}". Supported drivers: ${Object.keys(dialectFactories).sort().join(', ')}`,
|
|
);
|
|
}
|
|
|
|
export function getSqlDialectForDriver(driver: string): KtxSqlDialect {
|
|
const normalized = driver.toLowerCase().trim();
|
|
const factory = sqlDialectFactories[normalized as KtxSqlDriver];
|
|
if (factory) {
|
|
return factory();
|
|
}
|
|
throw new Error(`Driver "${driver}" has no SQL dialect. SQL drivers: ${supportedSqlDrivers.join(', ')}`);
|
|
}
|
|
|
|
/**
|
|
* Whether a driver can generate and execute SQL. Single source of truth for the
|
|
* SQL/non-SQL boundary: a driver is SQL-queryable iff it has a SQL dialect, so
|
|
* non-SQL sources (e.g. mongodb) are excluded without a hand-maintained list.
|
|
*/
|
|
export function isSqlQueryableDriver(driver: string | undefined): boolean {
|
|
const normalized = (driver ?? '').toLowerCase().trim();
|
|
return Object.prototype.hasOwnProperty.call(sqlDialectFactories, normalized);
|
|
}
|
|
|
|
/**
|
|
* Refuse a non-SQL connection (e.g. mongodb) at a read-only-SQL entry point before
|
|
* any dialect selection or parser/daemon work, so it is never validated as Postgres.
|
|
* The federated `duckdb` connection has no driver — callers skip this guard for it.
|
|
*/
|
|
export function assertSqlQueryableConnection(connectionId: string, driver: string | undefined): void {
|
|
if (!isSqlQueryableDriver(driver)) {
|
|
throw new KtxExpectedError(
|
|
`Connection '${connectionId}' uses the non-SQL driver '${driver ?? 'unknown'}'. ` +
|
|
'Read-only SQL (ktx sql, the sql_execution tool) requires a SQL warehouse connection; ' +
|
|
'MongoDB and other context-only sources are searchable and ingestable, not SQL-queryable.',
|
|
);
|
|
}
|
|
}
|