mirror of
https://github.com/Kaelio/ktx.git
synced 2026-06-25 08:48:08 +02:00
* feat(cli): define full warehouse dialect contract
* test(cli): keep dialect edge tests focused
* fix(cli): stabilize dialect contract foundation
* refactor(connectors): own read-only query preparation
* refactor(connectors): resolve dialects through registry
* refactor(connectors): keep concrete dialect classes internal
* chore(workspace): enforce dialect import boundary
* refactor(cli): resolve relationship dialect at scan boundary
* refactor(cli): use dialect display parsing for entity details
* refactor(cli): use dialect display parsing for warehouse catalog
* refactor(cli): use dialect SQL in relationship workflows
* test(cli): verify solid dialect scan workflow closure
* test: split cli tests from source tree
* refactor(cli): standardize BigQuery scope listing
* feat(sqlite): implement connector scope listing
* test(connectors): cover required table listing
* feat(cli): add warehouse driver registry
* refactor(setup): route scope discovery through driver registry
* refactor(cli): route local query execution through driver registry
* refactor(historic-sql): route dialect support through driver registry
* refactor(cli): test warehouse connections through driver registry
* fix(cli): close driver registry type export gaps
* Improve setup daemon diagnostics
* refactor(setup): centralize rail-prefixed diagnostics + query-history fallback
Extract errorMessage, writePrefixedLines, and flushPrefixedBufferedCommandOutput
into clack.ts so the setup wizard, managed daemons, and embedding/agent steps
share one rail-formatted writer. setup-databases.ts also adds a
"disable query history and retry" option when the schema-context build fails
and query history is the likely culprit, surfaced via a new
failed-query-history-unavailable status.
* fix(cli): carry catalog through the picker so BigQuery/Snowflake/SQL Server scope filters match
The setup picker's KtxTableListEntry was a 2-level { schema, name }, so
qualifiedTableId always wrote db.name into enabled_tables. When BigQuery,
Snowflake, or SQL Server later ran fast ingest, their introspect step filtered
the scope set with scopedTableNames(scope, { catalog: projectId|database, db })
— catalog was non-null on the introspect side but null in the scope refs, so
every entry was rejected, the live-database adapter staged zero table files,
and detect() failed with 'Adapter "live-database" did not recognize fetched
source output'.
Align the picker boundary with the canonical 3-level KtxTableRef:
- Add catalog: string | null to KtxTableListEntry.
- BigQuery/Snowflake/SQL Server listTables populate catalog from the
resolved projectId / database; Postgres/MySQL/ClickHouse/SQLite set null.
- qualifiedTableId emits catalog.schema.name when catalog is non-null
(resolveEnabledTables already accepts the 3-part shape) and
schemasFromEnabledTables now goes through parseDottedTableEntry so it
recovers the schema correctly from both 2-part and 3-part entries.
- Export parseDottedTableEntry from enabled-tables.ts (@internal) for picker
reuse.
Update listTables expectations in all seven connector tests and the setup /
picker test fixtures. Add a picker regression test that covers the
catalog-bearing round-trip (save + refine).
* fix(cli): allow debug telemetry under opt-out env
199 lines
7.7 KiB
TypeScript
199 lines
7.7 KiB
TypeScript
import type { KtxConnectionDriver, KtxScanConnector } from '../scan/types.js';
|
|
|
|
/** @internal */
|
|
export type KtxScopeConfigKey = 'dataset_ids' | 'databases' | 'schemas' | 'schema_names';
|
|
|
|
/** @internal */
|
|
export interface KtxDriverConnectorModule {
|
|
isConnectionConfig(connection: unknown): boolean;
|
|
createScanConnector(args: {
|
|
connectionId: string;
|
|
connection: unknown;
|
|
projectDir: string;
|
|
}): KtxScanConnector;
|
|
}
|
|
|
|
export interface KtxDriverRegistration {
|
|
readonly driver: KtxConnectionDriver;
|
|
readonly scopeConfigKey: KtxScopeConfigKey | null;
|
|
readonly hasHistoricSqlReader: boolean;
|
|
readonly hasLocalQueryExecutor: boolean;
|
|
load(): Promise<KtxDriverConnectorModule>;
|
|
}
|
|
|
|
function invalidConnectionConfig(driver: KtxConnectionDriver): Error {
|
|
return new Error(`Connection config does not match warehouse driver "${driver}".`);
|
|
}
|
|
|
|
/** @internal */
|
|
export const driverRegistrations: Record<KtxConnectionDriver, KtxDriverRegistration> = {
|
|
bigquery: {
|
|
driver: 'bigquery',
|
|
scopeConfigKey: 'dataset_ids',
|
|
hasHistoricSqlReader: true,
|
|
hasLocalQueryExecutor: false,
|
|
load: async () => {
|
|
const m = await import('../../connectors/bigquery/connector.js');
|
|
return {
|
|
isConnectionConfig: (connection) => {
|
|
const typedConnection = connection as Parameters<typeof m.isKtxBigQueryConnectionConfig>[0];
|
|
return m.isKtxBigQueryConnectionConfig(typedConnection);
|
|
},
|
|
createScanConnector: ({ connectionId, connection }) => {
|
|
const typedConnection = connection as Parameters<typeof m.isKtxBigQueryConnectionConfig>[0];
|
|
if (!m.isKtxBigQueryConnectionConfig(typedConnection)) {
|
|
throw invalidConnectionConfig('bigquery');
|
|
}
|
|
return new m.KtxBigQueryScanConnector({ connectionId, connection: typedConnection });
|
|
},
|
|
};
|
|
},
|
|
},
|
|
clickhouse: {
|
|
driver: 'clickhouse',
|
|
scopeConfigKey: 'databases',
|
|
hasHistoricSqlReader: false,
|
|
hasLocalQueryExecutor: false,
|
|
load: async () => {
|
|
const m = await import('../../connectors/clickhouse/connector.js');
|
|
return {
|
|
isConnectionConfig: (connection) => {
|
|
const typedConnection = connection as Parameters<typeof m.isKtxClickHouseConnectionConfig>[0];
|
|
return m.isKtxClickHouseConnectionConfig(typedConnection);
|
|
},
|
|
createScanConnector: ({ connectionId, connection }) => {
|
|
const typedConnection = connection as Parameters<typeof m.isKtxClickHouseConnectionConfig>[0];
|
|
if (!m.isKtxClickHouseConnectionConfig(typedConnection)) {
|
|
throw invalidConnectionConfig('clickhouse');
|
|
}
|
|
return new m.KtxClickHouseScanConnector({ connectionId, connection: typedConnection });
|
|
},
|
|
};
|
|
},
|
|
},
|
|
mysql: {
|
|
driver: 'mysql',
|
|
scopeConfigKey: 'schemas',
|
|
hasHistoricSqlReader: false,
|
|
hasLocalQueryExecutor: false,
|
|
load: async () => {
|
|
const m = await import('../../connectors/mysql/connector.js');
|
|
return {
|
|
isConnectionConfig: (connection) => {
|
|
const typedConnection = connection as Parameters<typeof m.isKtxMysqlConnectionConfig>[0];
|
|
return m.isKtxMysqlConnectionConfig(typedConnection);
|
|
},
|
|
createScanConnector: ({ connectionId, connection }) => {
|
|
const typedConnection = connection as Parameters<typeof m.isKtxMysqlConnectionConfig>[0];
|
|
if (!m.isKtxMysqlConnectionConfig(typedConnection)) {
|
|
throw invalidConnectionConfig('mysql');
|
|
}
|
|
return new m.KtxMysqlScanConnector({ connectionId, connection: typedConnection });
|
|
},
|
|
};
|
|
},
|
|
},
|
|
postgres: {
|
|
driver: 'postgres',
|
|
scopeConfigKey: 'schemas',
|
|
hasHistoricSqlReader: true,
|
|
hasLocalQueryExecutor: true,
|
|
load: async () => {
|
|
const m = await import('../../connectors/postgres/connector.js');
|
|
return {
|
|
isConnectionConfig: (connection) => {
|
|
const typedConnection = connection as Parameters<typeof m.isKtxPostgresConnectionConfig>[0];
|
|
return m.isKtxPostgresConnectionConfig(typedConnection);
|
|
},
|
|
createScanConnector: ({ connectionId, connection }) => {
|
|
const typedConnection = connection as Parameters<typeof m.isKtxPostgresConnectionConfig>[0];
|
|
if (!m.isKtxPostgresConnectionConfig(typedConnection)) {
|
|
throw invalidConnectionConfig('postgres');
|
|
}
|
|
return new m.KtxPostgresScanConnector({ connectionId, connection: typedConnection });
|
|
},
|
|
};
|
|
},
|
|
},
|
|
sqlite: {
|
|
driver: 'sqlite',
|
|
scopeConfigKey: null,
|
|
hasHistoricSqlReader: false,
|
|
hasLocalQueryExecutor: true,
|
|
load: async () => {
|
|
const m = await import('../../connectors/sqlite/connector.js');
|
|
return {
|
|
isConnectionConfig: (connection) => {
|
|
const typedConnection = connection as Parameters<typeof m.isKtxSqliteConnectionConfig>[0];
|
|
return m.isKtxSqliteConnectionConfig(typedConnection);
|
|
},
|
|
createScanConnector: ({ connectionId, connection, projectDir }) => {
|
|
const typedConnection = connection as Parameters<typeof m.isKtxSqliteConnectionConfig>[0];
|
|
if (!m.isKtxSqliteConnectionConfig(typedConnection)) {
|
|
throw invalidConnectionConfig('sqlite');
|
|
}
|
|
return new m.KtxSqliteScanConnector({ connectionId, connection: typedConnection, projectDir });
|
|
},
|
|
};
|
|
},
|
|
},
|
|
snowflake: {
|
|
driver: 'snowflake',
|
|
scopeConfigKey: 'schema_names',
|
|
hasHistoricSqlReader: true,
|
|
hasLocalQueryExecutor: false,
|
|
load: async () => {
|
|
const m = await import('../../connectors/snowflake/connector.js');
|
|
return {
|
|
isConnectionConfig: (connection) => {
|
|
const typedConnection = connection as Parameters<typeof m.isKtxSnowflakeConnectionConfig>[0];
|
|
return m.isKtxSnowflakeConnectionConfig(typedConnection);
|
|
},
|
|
createScanConnector: ({ connectionId, connection, projectDir }) => {
|
|
const typedConnection = connection as Parameters<typeof m.isKtxSnowflakeConnectionConfig>[0];
|
|
if (!m.isKtxSnowflakeConnectionConfig(typedConnection)) {
|
|
throw invalidConnectionConfig('snowflake');
|
|
}
|
|
return new m.KtxSnowflakeScanConnector({ connectionId, connection: typedConnection, projectDir });
|
|
},
|
|
};
|
|
},
|
|
},
|
|
sqlserver: {
|
|
driver: 'sqlserver',
|
|
scopeConfigKey: 'schemas',
|
|
hasHistoricSqlReader: false,
|
|
hasLocalQueryExecutor: false,
|
|
load: async () => {
|
|
const m = await import('../../connectors/sqlserver/connector.js');
|
|
return {
|
|
isConnectionConfig: (connection) => {
|
|
const typedConnection = connection as Parameters<typeof m.isKtxSqlServerConnectionConfig>[0];
|
|
return m.isKtxSqlServerConnectionConfig(typedConnection);
|
|
},
|
|
createScanConnector: ({ connectionId, connection }) => {
|
|
const typedConnection = connection as Parameters<typeof m.isKtxSqlServerConnectionConfig>[0];
|
|
if (!m.isKtxSqlServerConnectionConfig(typedConnection)) {
|
|
throw invalidConnectionConfig('sqlserver');
|
|
}
|
|
return new m.KtxSqlServerScanConnector({ connectionId, connection: typedConnection });
|
|
},
|
|
};
|
|
},
|
|
},
|
|
};
|
|
|
|
const supportedDrivers = Object.keys(driverRegistrations).sort() as KtxConnectionDriver[];
|
|
|
|
function isRegisteredDriver(driver: string): driver is KtxConnectionDriver {
|
|
return Object.prototype.hasOwnProperty.call(driverRegistrations, driver);
|
|
}
|
|
|
|
export function getDriverRegistration(driver: string): KtxDriverRegistration | undefined {
|
|
const normalized = driver.toLowerCase().trim();
|
|
return isRegisteredDriver(normalized) ? driverRegistrations[normalized] : undefined;
|
|
}
|
|
|
|
export function listSupportedDrivers(): KtxConnectionDriver[] {
|
|
return [...supportedDrivers];
|
|
}
|