mirror of
https://github.com/Kaelio/ktx.git
synced 2026-06-07 07:55:13 +02:00
* feat(cli): define full warehouse dialect contract
* test(cli): keep dialect edge tests focused
* fix(cli): stabilize dialect contract foundation
* refactor(connectors): own read-only query preparation
* refactor(connectors): resolve dialects through registry
* refactor(connectors): keep concrete dialect classes internal
* chore(workspace): enforce dialect import boundary
* refactor(cli): resolve relationship dialect at scan boundary
* refactor(cli): use dialect display parsing for entity details
* refactor(cli): use dialect display parsing for warehouse catalog
* refactor(cli): use dialect SQL in relationship workflows
* test(cli): verify solid dialect scan workflow closure
* test: split cli tests from source tree
* refactor(cli): standardize BigQuery scope listing
* feat(sqlite): implement connector scope listing
* test(connectors): cover required table listing
* feat(cli): add warehouse driver registry
* refactor(setup): route scope discovery through driver registry
* refactor(cli): route local query execution through driver registry
* refactor(historic-sql): route dialect support through driver registry
* refactor(cli): test warehouse connections through driver registry
* fix(cli): close driver registry type export gaps
* Improve setup daemon diagnostics
* refactor(setup): centralize rail-prefixed diagnostics + query-history fallback
Extract errorMessage, writePrefixedLines, and flushPrefixedBufferedCommandOutput
into clack.ts so the setup wizard, managed daemons, and embedding/agent steps
share one rail-formatted writer. setup-databases.ts also adds a
"disable query history and retry" option when the schema-context build fails
and query history is the likely culprit, surfaced via a new
failed-query-history-unavailable status.
* fix(cli): carry catalog through the picker so BigQuery/Snowflake/SQL Server scope filters match
The setup picker's KtxTableListEntry was a 2-level { schema, name }, so
qualifiedTableId always wrote db.name into enabled_tables. When BigQuery,
Snowflake, or SQL Server later ran fast ingest, their introspect step filtered
the scope set with scopedTableNames(scope, { catalog: projectId|database, db })
— catalog was non-null on the introspect side but null in the scope refs, so
every entry was rejected, the live-database adapter staged zero table files,
and detect() failed with 'Adapter "live-database" did not recognize fetched
source output'.
Align the picker boundary with the canonical 3-level KtxTableRef:
- Add catalog: string | null to KtxTableListEntry.
- BigQuery/Snowflake/SQL Server listTables populate catalog from the
resolved projectId / database; Postgres/MySQL/ClickHouse/SQLite set null.
- qualifiedTableId emits catalog.schema.name when catalog is non-null
(resolveEnabledTables already accepts the 3-part shape) and
schemasFromEnabledTables now goes through parseDottedTableEntry so it
recovers the schema correctly from both 2-part and 3-part entries.
- Export parseDottedTableEntry from enabled-tables.ts (@internal) for picker
reuse.
Update listTables expectations in all seven connector tests and the setup /
picker test fixtures. Add a picker regression test that covers the
catalog-bearing round-trip (save + refine).
* fix(cli): allow debug telemetry under opt-out env
99 lines
3.6 KiB
TypeScript
99 lines
3.6 KiB
TypeScript
import { loadKtxProject, type KtxLocalProject } from './context/project/project.js';
|
|
import { markKtxSetupStateStepComplete } from './context/project/setup-config.js';
|
|
import type { KtxCliIo } from './cli-runtime.js';
|
|
import { errorMessage, writePrefixedLines } from './clack.js';
|
|
import {
|
|
ensureManagedLocalEmbeddingsDaemon,
|
|
type ManagedLocalEmbeddingsDaemon,
|
|
} from './managed-local-embeddings.js';
|
|
import {
|
|
ensureManagedPythonCommandRuntime,
|
|
type KtxManagedPythonInstallPolicy,
|
|
type ManagedPythonCommandRuntime,
|
|
} from './managed-python-command.js';
|
|
import type { KtxRuntimeFeature } from './managed-python-runtime.js';
|
|
import {
|
|
resolveProjectRuntimeRequirements,
|
|
type KtxRuntimeRequirements,
|
|
} from './runtime-requirements.js';
|
|
|
|
export interface KtxSetupRuntimeArgs {
|
|
projectDir: string;
|
|
inputMode: 'auto' | 'disabled';
|
|
cliVersion: string;
|
|
runtimeInstallPolicy: KtxManagedPythonInstallPolicy;
|
|
databaseIntrospectionFallback?: boolean;
|
|
}
|
|
|
|
export type KtxSetupRuntimeResult =
|
|
| { status: 'ready'; projectDir: string; requirements: KtxRuntimeRequirements }
|
|
| { status: 'skipped'; projectDir: string; requirements: KtxRuntimeRequirements }
|
|
| { status: 'failed'; projectDir: string; requirements: KtxRuntimeRequirements };
|
|
|
|
export interface KtxSetupRuntimeDeps {
|
|
env?: NodeJS.ProcessEnv;
|
|
loadProject?: (options: { projectDir: string }) => Promise<Pick<KtxLocalProject, 'config'>>;
|
|
ensureRuntime?: (options: {
|
|
cliVersion: string;
|
|
installPolicy: KtxManagedPythonInstallPolicy;
|
|
io: KtxCliIo;
|
|
feature: KtxRuntimeFeature;
|
|
}) => Promise<ManagedPythonCommandRuntime>;
|
|
ensureLocalEmbeddings?: (options: {
|
|
cliVersion: string;
|
|
projectDir: string;
|
|
installPolicy: KtxManagedPythonInstallPolicy;
|
|
io: KtxCliIo;
|
|
}) => Promise<ManagedLocalEmbeddingsDaemon>;
|
|
}
|
|
|
|
function formatRuntimeFeature(feature: KtxRuntimeFeature): string {
|
|
return feature === 'local-embeddings' ? 'local embeddings' : 'core';
|
|
}
|
|
|
|
export async function runKtxSetupRuntimeStep(
|
|
args: KtxSetupRuntimeArgs,
|
|
io: KtxCliIo,
|
|
deps: KtxSetupRuntimeDeps = {},
|
|
): Promise<KtxSetupRuntimeResult> {
|
|
const loadProjectForRuntime = deps.loadProject ?? loadKtxProject;
|
|
const project = await loadProjectForRuntime({ projectDir: args.projectDir });
|
|
const requirements = resolveProjectRuntimeRequirements(project.config, {
|
|
databaseIntrospectionFallback: args.databaseIntrospectionFallback,
|
|
env: deps.env ?? process.env,
|
|
});
|
|
|
|
if (requirements.features.length === 0) {
|
|
io.stdout.write('│ Runtime setup skipped.\n');
|
|
return { status: 'skipped', projectDir: args.projectDir, requirements };
|
|
}
|
|
|
|
const ensureRuntime = deps.ensureRuntime ?? ensureManagedPythonCommandRuntime;
|
|
const ensureLocalEmbeddings = deps.ensureLocalEmbeddings ?? ensureManagedLocalEmbeddingsDaemon;
|
|
try {
|
|
for (const feature of requirements.features) {
|
|
if (feature === 'local-embeddings') {
|
|
await ensureLocalEmbeddings({
|
|
cliVersion: args.cliVersion,
|
|
projectDir: args.projectDir,
|
|
installPolicy: args.runtimeInstallPolicy,
|
|
io,
|
|
});
|
|
continue;
|
|
}
|
|
await ensureRuntime({
|
|
cliVersion: args.cliVersion,
|
|
installPolicy: args.runtimeInstallPolicy,
|
|
io,
|
|
feature,
|
|
});
|
|
}
|
|
} catch (error) {
|
|
writePrefixedLines((chunk) => io.stderr.write(chunk), errorMessage(error));
|
|
return { status: 'failed', projectDir: args.projectDir, requirements };
|
|
}
|
|
|
|
await markKtxSetupStateStepComplete(args.projectDir, 'runtime');
|
|
io.stdout.write(`│ Runtime ready: yes (${requirements.features.map(formatRuntimeFeature).join(', ')})\n`);
|
|
return { status: 'ready', projectDir: args.projectDir, requirements };
|
|
}
|