mirror of
https://github.com/Kaelio/ktx.git
synced 2026-06-07 07:55:13 +02:00
* refactor(workspace): relocate @ktx/llm source into packages/cli/src/llm * refactor(workspace): rewrite @ktx/llm imports to relative paths * refactor(workspace): fold internal packages into cli * chore(workspace): gate dead-code with knip production mode Turn on production-mode knip plus an autofix run in pre-commit and the `pnpm dead-code` script, document the `/** @internal */` convention for test-only exports in AGENTS.md, annotate test-only exports across the CLI with that JSDoc, and drop dead exports/wrappers the new gate surfaced (e.g. `cli-project.ts`, `lookerRuntimeSourceToFileAdapterSource`, `createLocalScanEnrichmentProvidersFromConfig`, `PGLITE_OWNER_PROCESS_BACKEND_CAPABILITIES`, stale type re-exports). Replace the loose `ignoreIssues` allowlist in `knip.json` with explicit production entries so cross-package barrel leaks are caught. * refactor(cli): delete internal barrel index.ts files The 34 `index.ts` re-export barrels inside `packages/cli/src/` were holdovers from the pre-fold multi-workspace structure. Post-fold-in they served no production purpose: external consumers go through the single package main entry, and in-repo callers mostly imported through them only because the path was short. Internally, knip flagged most barrel re-exports as production-dead (only reached via tests). This change: - Deletes every internal barrel except `packages/cli/src/index.ts` (the published package entry). - Rewrites ~270 source/test files to import each name directly from the file that defines it. - Moves `tools/warehouse-verification/index.ts` to `create-warehouse-verification-tools.ts` (the function it defined locally) and updates its single consumer. - Renames `search/backend-conformance.ts` → `.test-utils.ts` to match the existing test-helper file convention. - Deletes 13 dead test-only chains (dbt-descriptions/*, live-database/extracted-schema, live-database/structural-sync, relationship-* feedback/review chain) plus their tests and a cascading orphan integration test. - Updates test mocks that pointed at deleted barrel paths (notion-client, connector barrels in scan/local-scan-connectors tests) to mock the source files instead. - Points the maintainer benchmark script (`scripts/relationship-benchmark-report.mjs`) at source files instead of `dist/context/scan/index.js`. - Drops the barrel `!` entries from `knip.json`; adds explicit production entries only for the benchmark code reached via dist by the maintainer script. Net: 413 files changed, ~1.2k insertions, ~9.4k deletions. `pnpm run dead-code` (Biome + knip default + knip production) and `pnpm run type-check` are clean; 2277 tests pass. * refactor(workspace): rename @ktx/cli to @kaelio/ktx and pack it directly Promote the CLI workspace package to the public name `@kaelio/ktx` and drop the separate `scripts/build-public-npm-package.mjs` wrapper. The CLI package is now publishable in place (`publishConfig.access: public`, `provenance: true`), so artifact packing uses `pnpm pack` against `packages/cli/` instead of assembling a parallel package tree. Updates all workspace filter invocations, docs, tests, and release readiness checks to reference the new package name, and folds the tarball-name helper into `scripts/public-npm-release-metadata.mjs`. * docs: align "agent clients" and "data agents" terminology Replace "client agents" with "agent clients" and "database agents" with "data agents" across AGENTS.md, README.md, the docs-site copy, and the matching setup-agents test description, matching the canonical vocabulary in docs/terminology.md. Also moves packages/cli/tsconfig.json's tsBuildInfoFile from node_modules/.cache/ to dist/.tsbuildinfo so incremental builds survive node_modules reinstalls. * refactor(release): single source of truth for package version Make packages/cli/package.json the single source of truth for the @kaelio/ktx version. publicNpmPackageVersion() now reads it directly, so artifact filenames, release-readiness checks, and the Python wheel version all derive from one field. The duplicate release-policy.json.publicNpmPackageVersion is removed. Previously the two fields could drift: tarballs were named kaelio-ktx-0.4.1.tgz while internally containing @kaelio/ktx@0.0.0-private. - update-public-release-version.mjs rewrites both Python pyproject.toml files (ktx-daemon, ktx-sl) alongside the npm package.jsons, normalizing the version for PEP 440 (e.g. 0.1.0-rc.2 -> 0.1.0rc2). - semantic-release-config.cjs adds the two pyproject.toml files to @semantic-release/git assets so the release commit back to main carries every version source in lockstep. - The six "?? '0.0.0-private'" fallback literals across the CLI are replaced with "?? getKtxCliPackageInfo().version", and createDefaultKtxMcpServer makes its version arg required. - docs/release.md describes the actual commit-back model: the dev tree always reflects the most recent release; no sentinel pin to maintain. Verified: pnpm run artifacts:build now produces kaelio-ktx-0.4.1.tgz and kaelio_ktx-0.4.1-py3-none-any.whl with @kaelio/ktx@0.4.1 inside. Full type-check, dead-code, and 2287 vitests + 173 script tests pass. * refactor(cli): inject embedding provider resolution and detect sentence-transformers runtime Make resolveProjectEmbeddingProvider and runtimeIo injectable in ingest and scan command entrypoints so tests can stub them, and teach resolvePublicIngestRuntimeRequirements to flag the local-embeddings runtime feature when ktx.yaml selects sentence-transformers. * chore(cli): mark buildLocalStatsStatus and LocalStatsStatus as @internal Both symbols are consumed only by status-project.test.ts. Annotating with /** @internal */ keeps knip's production-mode check clean without changing runtime behavior. * fix(cli): use real package metadata in print-command-tree The stubbed package name embedded a forbidden product identifier that tripped the boundary check in CI. Read the metadata from package.json instead — keeps the rendered tree unchanged and removes a duplicate source of truth. * feat(cli): show embedding coverage in `ktx status`, drop duplicate disk counts Inline `(N embedded)` next to the Wiki scope counts and Semantic-layer source counts, computed with `SUM(embedding_json IS NOT NULL)` over `knowledge_pages` and `local_sl_sources`. Rename the "Knowledge" label to "Wiki" (canonical per `docs/terminology.md`) and rename the matching `localStats.knowledgePages` field to `localStats.wikiPages`. Drop `wiki=N md` and `semantic-layer=N yaml` from the Disk row — those duplicated the per-surface rows above. Disk now reports only actual byte usage (db, cache, raw-sources). The unused `wikiGlobalMarkdownCount` / `semanticLayerYamlCount` fields, the `isMarkdownEntry` / `isYamlEntry` helpers, and the `filter` arg on `summarizeDir` are removed.
291 lines
9.1 KiB
JavaScript
291 lines
9.1 KiB
JavaScript
import assert from 'node:assert/strict';
|
|
import { readFile } from 'node:fs/promises';
|
|
import { describe, it } from 'node:test';
|
|
|
|
import {
|
|
buildPublishedPackageNpxCommand,
|
|
buildPublishedPackageSmokeCommands,
|
|
isPublishedPackageVersionLabel,
|
|
isTransientPublishedPackageLookupFailure,
|
|
publishedPackageSmokePnpmWorkspaceYaml,
|
|
publishedPackageSpec,
|
|
readPublishedPackageSmokeConfig,
|
|
} from './published-package-smoke.mjs';
|
|
|
|
describe('published package smoke config', () => {
|
|
it('skips by default until a published package name is supplied', () => {
|
|
assert.deepEqual(readPublishedPackageSmokeConfig({}, []), {
|
|
enabled: false,
|
|
requireConfig: false,
|
|
reason:
|
|
'Set KTX_PUBLISHED_KTX_PACKAGE or release-policy.json publishedPackageSmoke.packageName to the published npm package name after the release decision.',
|
|
});
|
|
});
|
|
|
|
it('can require the published package config for post-publication CI', () => {
|
|
assert.deepEqual(readPublishedPackageSmokeConfig({}, ['--require-config']), {
|
|
enabled: false,
|
|
requireConfig: true,
|
|
reason:
|
|
'Set KTX_PUBLISHED_KTX_PACKAGE or release-policy.json publishedPackageSmoke.packageName to the published npm package name after the release decision.',
|
|
});
|
|
});
|
|
|
|
it('reads the package, version, and registry from environment variables', () => {
|
|
assert.deepEqual(
|
|
readPublishedPackageSmokeConfig(
|
|
{
|
|
KTX_PUBLISHED_KTX_PACKAGE: '@kaelio/ktx',
|
|
KTX_PUBLISHED_KTX_VERSION: 'latest',
|
|
KTX_PUBLISHED_KTX_REGISTRY: 'https://registry.npmjs.org/',
|
|
},
|
|
[],
|
|
),
|
|
{
|
|
enabled: true,
|
|
requireConfig: false,
|
|
configSource: 'environment',
|
|
packageName: '@kaelio/ktx',
|
|
packageVersion: 'latest',
|
|
registry: 'https://registry.npmjs.org/',
|
|
},
|
|
);
|
|
});
|
|
|
|
it('reads the package, version, and registry from release policy when env vars are absent', () => {
|
|
assert.deepEqual(
|
|
readPublishedPackageSmokeConfig(
|
|
{},
|
|
[],
|
|
{
|
|
packageName: '@kaelio/ktx',
|
|
version: '2026.5.8',
|
|
registry: 'https://registry.npmjs.org/',
|
|
},
|
|
),
|
|
{
|
|
enabled: true,
|
|
requireConfig: false,
|
|
configSource: 'release-policy',
|
|
packageName: '@kaelio/ktx',
|
|
packageVersion: '2026.5.8',
|
|
registry: 'https://registry.npmjs.org/',
|
|
},
|
|
);
|
|
});
|
|
|
|
it('lets environment variables override release policy values', () => {
|
|
assert.deepEqual(
|
|
readPublishedPackageSmokeConfig(
|
|
{
|
|
KTX_PUBLISHED_KTX_PACKAGE: '@kaelio/ktx',
|
|
KTX_PUBLISHED_KTX_VERSION: 'latest',
|
|
},
|
|
[],
|
|
{
|
|
packageName: '@kaelio/ktx',
|
|
version: '2026.5.8',
|
|
registry: 'https://registry.npmjs.org/',
|
|
},
|
|
),
|
|
{
|
|
enabled: true,
|
|
requireConfig: false,
|
|
configSource: 'environment',
|
|
packageName: '@kaelio/ktx',
|
|
packageVersion: 'latest',
|
|
registry: 'https://registry.npmjs.org/',
|
|
},
|
|
);
|
|
});
|
|
|
|
it('rejects package names that would be unsafe as npx package specs', () => {
|
|
assert.throws(
|
|
() => readPublishedPackageSmokeConfig({ KTX_PUBLISHED_KTX_PACKAGE: '--package=@evil/pkg' }, []),
|
|
/Invalid KTX_PUBLISHED_KTX_PACKAGE/,
|
|
);
|
|
assert.throws(
|
|
() => readPublishedPackageSmokeConfig({ KTX_PUBLISHED_KTX_PACKAGE: '@kaelio/ktx public' }, []),
|
|
/Invalid KTX_PUBLISHED_KTX_PACKAGE/,
|
|
);
|
|
assert.throws(
|
|
() =>
|
|
readPublishedPackageSmokeConfig(
|
|
{},
|
|
[],
|
|
{
|
|
packageName: '@kaelio/ktx public',
|
|
version: 'latest',
|
|
registry: null,
|
|
},
|
|
),
|
|
/Invalid release-policy\.json publishedPackageSmoke\.packageName/,
|
|
);
|
|
});
|
|
|
|
it('rejects unsafe version tags and non-HTTP registries', () => {
|
|
assert.throws(
|
|
() =>
|
|
readPublishedPackageSmokeConfig(
|
|
{
|
|
KTX_PUBLISHED_KTX_PACKAGE: '@kaelio/ktx',
|
|
KTX_PUBLISHED_KTX_VERSION: '--tag latest',
|
|
},
|
|
[],
|
|
),
|
|
/Invalid KTX_PUBLISHED_KTX_VERSION/,
|
|
);
|
|
assert.throws(
|
|
() =>
|
|
readPublishedPackageSmokeConfig(
|
|
{
|
|
KTX_PUBLISHED_KTX_PACKAGE: '@kaelio/ktx',
|
|
KTX_PUBLISHED_KTX_REGISTRY: 'file:///tmp/npm',
|
|
},
|
|
[],
|
|
),
|
|
/KTX_PUBLISHED_KTX_REGISTRY must be an http\(s\) URL/,
|
|
);
|
|
});
|
|
});
|
|
|
|
describe('published package smoke output validation labels', () => {
|
|
it('classifies version commands', () => {
|
|
assert.equal(isPublishedPackageVersionLabel('published package npx version'), true);
|
|
assert.equal(isPublishedPackageVersionLabel('published package local version'), true);
|
|
assert.equal(isPublishedPackageVersionLabel('published package global version'), true);
|
|
assert.equal(isPublishedPackageVersionLabel('published package npx setup help'), false);
|
|
});
|
|
});
|
|
|
|
describe('published package smoke registry retry classification', () => {
|
|
it('recognizes npm propagation misses as transient lookup failures', () => {
|
|
assert.equal(
|
|
isTransientPublishedPackageLookupFailure({
|
|
code: 1,
|
|
stdout: '',
|
|
stderr: [
|
|
'npm error code ETARGET',
|
|
'npm error notarget No matching version found for @kaelio/ktx@0.1.0-rc.4.',
|
|
].join('\n'),
|
|
}),
|
|
true,
|
|
);
|
|
});
|
|
|
|
it('does not retry unrelated command failures', () => {
|
|
assert.equal(
|
|
isTransientPublishedPackageLookupFailure({
|
|
code: 1,
|
|
stdout: '',
|
|
stderr: 'npm error code EOTP',
|
|
}),
|
|
false,
|
|
);
|
|
});
|
|
});
|
|
|
|
describe('published package smoke command construction', () => {
|
|
const config = {
|
|
enabled: true,
|
|
requireConfig: false,
|
|
packageName: '@kaelio/ktx',
|
|
packageVersion: 'latest',
|
|
registry: 'https://registry.npmjs.org/',
|
|
};
|
|
|
|
it('builds the npx package spec from package name and version tag', () => {
|
|
assert.equal(publishedPackageSpec(config), '@kaelio/ktx@latest');
|
|
});
|
|
|
|
it('builds npx commands with a registry env patch instead of shell interpolation', () => {
|
|
assert.deepEqual(buildPublishedPackageNpxCommand(config, ['--version']), {
|
|
label: 'published package command',
|
|
command: 'npx',
|
|
args: ['--yes', '@kaelio/ktx@latest', '--version'],
|
|
env: { npm_config_registry: 'https://registry.npmjs.org/' },
|
|
});
|
|
});
|
|
|
|
it('builds the full public package smoke command list', () => {
|
|
assert.deepEqual(
|
|
buildPublishedPackageSmokeCommands(
|
|
config,
|
|
'/tmp/ktx-smoke/demo',
|
|
'/tmp/ktx-smoke/managed-runtime',
|
|
),
|
|
[
|
|
{
|
|
label: 'published package npx version',
|
|
command: 'npx',
|
|
args: ['--yes', '@kaelio/ktx@latest', '--version'],
|
|
env: { npm_config_registry: 'https://registry.npmjs.org/' },
|
|
},
|
|
{
|
|
label: 'published package npx setup help',
|
|
command: 'npx',
|
|
args: ['--yes', '@kaelio/ktx@latest', 'setup', '--help'],
|
|
env: { npm_config_registry: 'https://registry.npmjs.org/' },
|
|
},
|
|
{
|
|
label: 'published package npx status help',
|
|
command: 'npx',
|
|
args: ['--yes', '@kaelio/ktx@latest', 'status', '--help'],
|
|
env: { npm_config_registry: 'https://registry.npmjs.org/' },
|
|
},
|
|
{
|
|
label: 'published package local install',
|
|
command: 'pnpm',
|
|
args: ['add', '@kaelio/ktx@latest'],
|
|
env: { npm_config_registry: 'https://registry.npmjs.org/' },
|
|
},
|
|
{
|
|
label: 'published package local version',
|
|
command: 'npx',
|
|
args: ['ktx', '--version'],
|
|
env: { npm_config_registry: 'https://registry.npmjs.org/' },
|
|
},
|
|
{
|
|
label: 'published package local status help',
|
|
command: 'npx',
|
|
args: ['ktx', 'status', '--help'],
|
|
env: { npm_config_registry: 'https://registry.npmjs.org/' },
|
|
},
|
|
{
|
|
label: 'published package global install',
|
|
command: 'pnpm',
|
|
args: ['add', '--global', '@kaelio/ktx@latest'],
|
|
env: { npm_config_registry: 'https://registry.npmjs.org/' },
|
|
},
|
|
{
|
|
label: 'published package global version',
|
|
command: 'ktx',
|
|
args: ['--version'],
|
|
env: { npm_config_registry: 'https://registry.npmjs.org/' },
|
|
},
|
|
{
|
|
label: 'published package global status help',
|
|
command: 'ktx',
|
|
args: ['status', '--help'],
|
|
env: { npm_config_registry: 'https://registry.npmjs.org/' },
|
|
},
|
|
],
|
|
);
|
|
});
|
|
|
|
it('allows native dependency build scripts in clean pnpm smoke installs', () => {
|
|
assert.equal(
|
|
publishedPackageSmokePnpmWorkspaceYaml(),
|
|
['packages:', ' - "."', 'allowBuilds:', ' better-sqlite3: true', ''].join('\n'),
|
|
);
|
|
});
|
|
|
|
it('exposes the smoke through the package release script', async () => {
|
|
const packageJson = JSON.parse(await readFile(new URL('../package.json', import.meta.url), 'utf8'));
|
|
|
|
assert.equal(
|
|
packageJson.scripts['release:published-smoke'],
|
|
'node scripts/published-package-smoke.mjs --require-config',
|
|
);
|
|
});
|
|
});
|