mirror of
https://github.com/Kaelio/ktx.git
synced 2026-06-07 07:55:13 +02:00
* refactor(workspace): relocate @ktx/llm source into packages/cli/src/llm * refactor(workspace): rewrite @ktx/llm imports to relative paths * refactor(workspace): fold internal packages into cli * chore(workspace): gate dead-code with knip production mode Turn on production-mode knip plus an autofix run in pre-commit and the `pnpm dead-code` script, document the `/** @internal */` convention for test-only exports in AGENTS.md, annotate test-only exports across the CLI with that JSDoc, and drop dead exports/wrappers the new gate surfaced (e.g. `cli-project.ts`, `lookerRuntimeSourceToFileAdapterSource`, `createLocalScanEnrichmentProvidersFromConfig`, `PGLITE_OWNER_PROCESS_BACKEND_CAPABILITIES`, stale type re-exports). Replace the loose `ignoreIssues` allowlist in `knip.json` with explicit production entries so cross-package barrel leaks are caught. * refactor(cli): delete internal barrel index.ts files The 34 `index.ts` re-export barrels inside `packages/cli/src/` were holdovers from the pre-fold multi-workspace structure. Post-fold-in they served no production purpose: external consumers go through the single package main entry, and in-repo callers mostly imported through them only because the path was short. Internally, knip flagged most barrel re-exports as production-dead (only reached via tests). This change: - Deletes every internal barrel except `packages/cli/src/index.ts` (the published package entry). - Rewrites ~270 source/test files to import each name directly from the file that defines it. - Moves `tools/warehouse-verification/index.ts` to `create-warehouse-verification-tools.ts` (the function it defined locally) and updates its single consumer. - Renames `search/backend-conformance.ts` → `.test-utils.ts` to match the existing test-helper file convention. - Deletes 13 dead test-only chains (dbt-descriptions/*, live-database/extracted-schema, live-database/structural-sync, relationship-* feedback/review chain) plus their tests and a cascading orphan integration test. - Updates test mocks that pointed at deleted barrel paths (notion-client, connector barrels in scan/local-scan-connectors tests) to mock the source files instead. - Points the maintainer benchmark script (`scripts/relationship-benchmark-report.mjs`) at source files instead of `dist/context/scan/index.js`. - Drops the barrel `!` entries from `knip.json`; adds explicit production entries only for the benchmark code reached via dist by the maintainer script. Net: 413 files changed, ~1.2k insertions, ~9.4k deletions. `pnpm run dead-code` (Biome + knip default + knip production) and `pnpm run type-check` are clean; 2277 tests pass. * refactor(workspace): rename @ktx/cli to @kaelio/ktx and pack it directly Promote the CLI workspace package to the public name `@kaelio/ktx` and drop the separate `scripts/build-public-npm-package.mjs` wrapper. The CLI package is now publishable in place (`publishConfig.access: public`, `provenance: true`), so artifact packing uses `pnpm pack` against `packages/cli/` instead of assembling a parallel package tree. Updates all workspace filter invocations, docs, tests, and release readiness checks to reference the new package name, and folds the tarball-name helper into `scripts/public-npm-release-metadata.mjs`. * docs: align "agent clients" and "data agents" terminology Replace "client agents" with "agent clients" and "database agents" with "data agents" across AGENTS.md, README.md, the docs-site copy, and the matching setup-agents test description, matching the canonical vocabulary in docs/terminology.md. Also moves packages/cli/tsconfig.json's tsBuildInfoFile from node_modules/.cache/ to dist/.tsbuildinfo so incremental builds survive node_modules reinstalls. * refactor(release): single source of truth for package version Make packages/cli/package.json the single source of truth for the @kaelio/ktx version. publicNpmPackageVersion() now reads it directly, so artifact filenames, release-readiness checks, and the Python wheel version all derive from one field. The duplicate release-policy.json.publicNpmPackageVersion is removed. Previously the two fields could drift: tarballs were named kaelio-ktx-0.4.1.tgz while internally containing @kaelio/ktx@0.0.0-private. - update-public-release-version.mjs rewrites both Python pyproject.toml files (ktx-daemon, ktx-sl) alongside the npm package.jsons, normalizing the version for PEP 440 (e.g. 0.1.0-rc.2 -> 0.1.0rc2). - semantic-release-config.cjs adds the two pyproject.toml files to @semantic-release/git assets so the release commit back to main carries every version source in lockstep. - The six "?? '0.0.0-private'" fallback literals across the CLI are replaced with "?? getKtxCliPackageInfo().version", and createDefaultKtxMcpServer makes its version arg required. - docs/release.md describes the actual commit-back model: the dev tree always reflects the most recent release; no sentinel pin to maintain. Verified: pnpm run artifacts:build now produces kaelio-ktx-0.4.1.tgz and kaelio_ktx-0.4.1-py3-none-any.whl with @kaelio/ktx@0.4.1 inside. Full type-check, dead-code, and 2287 vitests + 173 script tests pass. * refactor(cli): inject embedding provider resolution and detect sentence-transformers runtime Make resolveProjectEmbeddingProvider and runtimeIo injectable in ingest and scan command entrypoints so tests can stub them, and teach resolvePublicIngestRuntimeRequirements to flag the local-embeddings runtime feature when ktx.yaml selects sentence-transformers. * chore(cli): mark buildLocalStatsStatus and LocalStatsStatus as @internal Both symbols are consumed only by status-project.test.ts. Annotating with /** @internal */ keeps knip's production-mode check clean without changing runtime behavior. * fix(cli): use real package metadata in print-command-tree The stubbed package name embedded a forbidden product identifier that tripped the boundary check in CI. Read the metadata from package.json instead — keeps the rendered tree unchanged and removes a duplicate source of truth. * feat(cli): show embedding coverage in `ktx status`, drop duplicate disk counts Inline `(N embedded)` next to the Wiki scope counts and Semantic-layer source counts, computed with `SUM(embedding_json IS NOT NULL)` over `knowledge_pages` and `local_sl_sources`. Rename the "Knowledge" label to "Wiki" (canonical per `docs/terminology.md`) and rename the matching `localStats.knowledgePages` field to `localStats.wikiPages`. Drop `wiki=N md` and `semantic-layer=N yaml` from the Disk row — those duplicated the per-surface rows above. Disk now reports only actual byte usage (db, cache, raw-sources). The unused `wikiGlobalMarkdownCount` / `semanticLayerYamlCount` fields, the `isMarkdownEntry` / `isYamlEntry` helpers, and the `filter` arg on `summarizeDir` are removed.
162 lines
7.7 KiB
JavaScript
162 lines
7.7 KiB
JavaScript
import assert from 'node:assert/strict';
|
|
import { createRequire } from 'node:module';
|
|
import { describe, it } from 'node:test';
|
|
|
|
const require = createRequire(import.meta.url);
|
|
const { createReleaseConfig, releaseBranches, releaseKind, releaseTag } = require('./semantic-release-config.cjs');
|
|
|
|
function prepareExecOptions(config) {
|
|
return config.plugins.find((plugin) => Array.isArray(plugin) && plugin[0] === '@semantic-release/exec' && plugin[1].prepareCmd)[1];
|
|
}
|
|
|
|
function publishExecOptions(config) {
|
|
return config.plugins.find((plugin) => Array.isArray(plugin) && plugin[0] === '@semantic-release/exec' && plugin[1].publishCmd)[1];
|
|
}
|
|
|
|
function gitPluginOptions(config) {
|
|
const found = config.plugins.find((plugin) => Array.isArray(plugin) && plugin[0] === '@semantic-release/git');
|
|
return found ? found[1] : undefined;
|
|
}
|
|
|
|
function pluginNames(config) {
|
|
return config.plugins.map((plugin) => (Array.isArray(plugin) ? plugin[0] : plugin));
|
|
}
|
|
|
|
describe('semantic-release config', () => {
|
|
it('configures rc releases as a prerelease on main', () => {
|
|
assert.equal(releaseKind({ KTX_RELEASE_KIND: 'rc' }), 'rc');
|
|
assert.equal(releaseTag('rc', { GITHUB_REF_NAME: 'main' }), 'next');
|
|
assert.deepEqual(releaseBranches({ KTX_RELEASE_KIND: 'rc', GITHUB_REF_NAME: 'main' }), [
|
|
{ name: 'main', prerelease: 'rc', channel: 'next' },
|
|
]);
|
|
|
|
const config = createReleaseConfig({ KTX_RELEASE_KIND: 'rc', GITHUB_REF_NAME: 'main' });
|
|
assert.equal(
|
|
config.plugins.find((plugin) => Array.isArray(plugin) && plugin[0] === '@semantic-release/npm'),
|
|
undefined,
|
|
'@semantic-release/npm must not run; the exec publishCmd publishes the pre-built tarball',
|
|
);
|
|
assert.match(
|
|
prepareExecOptions(config).prepareCmd,
|
|
/update-public-release-version\.mjs "\$\{nextRelease\.version\}" "next"/,
|
|
);
|
|
assert.match(
|
|
publishExecOptions(config).publishCmd,
|
|
/^npm publish dist\/artifacts\/npm\/kaelio-ktx-\$\{nextRelease\.version\}\.tgz --tag next --access public --provenance/,
|
|
);
|
|
assert.match(publishExecOptions(config).publishCmd, /pnpm run release:published-smoke/);
|
|
assert.doesNotMatch(JSON.stringify(config.plugins), /release:npm-publish/);
|
|
});
|
|
|
|
it('configures rc releases from branches with branch-specific prerelease and npm tag', () => {
|
|
assert.equal(releaseTag('rc', { GITHUB_REF_NAME: 'feature/branch-release' }), 'branch-feature-branch-release');
|
|
assert.deepEqual(releaseBranches({ KTX_RELEASE_KIND: 'rc', GITHUB_REF_NAME: 'feature/branch-release' }), [
|
|
{ name: 'main', prerelease: 'rc', channel: 'next' },
|
|
{ name: 'feature/branch-release', prerelease: 'feature-branch-release', channel: 'branch-feature-branch-release' },
|
|
]);
|
|
|
|
const config = createReleaseConfig({ KTX_RELEASE_KIND: 'rc', GITHUB_REF_NAME: 'feature/branch-release' });
|
|
assert.match(
|
|
prepareExecOptions(config).prepareCmd,
|
|
/update-public-release-version\.mjs "\$\{nextRelease\.version\}" "branch-feature-branch-release"/,
|
|
);
|
|
assert.match(
|
|
publishExecOptions(config).publishCmd,
|
|
/^npm publish dist\/artifacts\/npm\/kaelio-ktx-\$\{nextRelease\.version\}\.tgz --tag branch-feature-branch-release --access public --provenance/,
|
|
);
|
|
});
|
|
|
|
it('configures stable releases only from main with latest tag', () => {
|
|
assert.equal(releaseKind({ KTX_RELEASE_KIND: 'stable' }), 'stable');
|
|
assert.equal(releaseTag('stable'), 'latest');
|
|
assert.deepEqual(releaseBranches({ KTX_RELEASE_KIND: 'stable', GITHUB_REF_NAME: 'main' }), ['main']);
|
|
|
|
const config = createReleaseConfig({ KTX_RELEASE_KIND: 'stable', GITHUB_REF_NAME: 'main' });
|
|
assert.match(
|
|
prepareExecOptions(config).prepareCmd,
|
|
/update-public-release-version\.mjs "\$\{nextRelease\.version\}" "latest"/,
|
|
);
|
|
assert.match(
|
|
publishExecOptions(config).publishCmd,
|
|
/^npm publish dist\/artifacts\/npm\/kaelio-ktx-\$\{nextRelease\.version\}\.tgz --tag latest --access public --provenance/,
|
|
);
|
|
assert.equal(config.plugins.includes('./scripts/semantic-release-version-policy.cjs'), false);
|
|
});
|
|
|
|
it('commits release version files back to the branch via @semantic-release/git', () => {
|
|
for (const kind of ['rc', 'stable']) {
|
|
const config = createReleaseConfig({ KTX_RELEASE_KIND: kind, GITHUB_REF_NAME: 'main' });
|
|
const git = gitPluginOptions(config);
|
|
assert.ok(git, `${kind}: @semantic-release/git plugin must be configured`);
|
|
assert.deepEqual(git.assets, [
|
|
'package.json',
|
|
'release-policy.json',
|
|
'packages/cli/package.json',
|
|
'python/ktx-daemon/pyproject.toml',
|
|
'python/ktx-sl/pyproject.toml',
|
|
]);
|
|
assert.match(git.message, /^chore\(release\): \$\{nextRelease\.version\} \[skip ci\]/);
|
|
}
|
|
});
|
|
|
|
it('keeps @semantic-release/npm and @semantic-release/changelog out of the plugin chain', () => {
|
|
for (const kind of ['rc', 'stable']) {
|
|
const config = createReleaseConfig({ KTX_RELEASE_KIND: kind, GITHUB_REF_NAME: 'main' });
|
|
assert.equal(pluginNames(config).includes('@semantic-release/npm'), false, `${kind}: @semantic-release/npm`);
|
|
assert.equal(pluginNames(config).includes('@semantic-release/changelog'), false, `${kind}: @semantic-release/changelog`);
|
|
}
|
|
});
|
|
|
|
it('orders the prepare exec before @semantic-release/git before the publish exec', () => {
|
|
const config = createReleaseConfig({ KTX_RELEASE_KIND: 'stable', GITHUB_REF_NAME: 'main' });
|
|
const prepareIndex = config.plugins.findIndex(
|
|
(plugin) => Array.isArray(plugin) && plugin[0] === '@semantic-release/exec' && plugin[1].prepareCmd,
|
|
);
|
|
const gitIndex = config.plugins.findIndex(
|
|
(plugin) => Array.isArray(plugin) && plugin[0] === '@semantic-release/git',
|
|
);
|
|
const publishIndex = config.plugins.findIndex(
|
|
(plugin) => Array.isArray(plugin) && plugin[0] === '@semantic-release/exec' && plugin[1].publishCmd,
|
|
);
|
|
assert.ok(prepareIndex !== -1 && gitIndex !== -1 && publishIndex !== -1);
|
|
assert.ok(prepareIndex < gitIndex, 'prepare exec must run before @semantic-release/git');
|
|
assert.ok(gitIndex < publishIndex, '@semantic-release/git must run before the publish exec');
|
|
});
|
|
|
|
it('produces a loadable config regardless of GITHUB_REF_NAME', () => {
|
|
// Knip and other tooling load .releaserc.cjs on PR runners where
|
|
// GITHUB_REF_NAME is the merge ref. semantic-release itself enforces the
|
|
// main-only rule by refusing to publish when the current branch does not
|
|
// match a configured release branch, so the config must not throw at load.
|
|
for (const kind of ['rc', 'stable']) {
|
|
assert.doesNotThrow(() => releaseBranches({ KTX_RELEASE_KIND: kind, GITHUB_REF_NAME: '180/merge' }));
|
|
}
|
|
});
|
|
|
|
it('keeps the force-release patch escape hatch', () => {
|
|
const config = createReleaseConfig({ KTX_RELEASE_KIND: 'rc', GITHUB_REF_NAME: 'main' });
|
|
const analyzeExec = config.plugins.find(
|
|
(plugin) => Array.isArray(plugin) && plugin[0] === '@semantic-release/exec' && plugin[1].analyzeCommitsCmd,
|
|
);
|
|
assert.match(analyzeExec[1].analyzeCommitsCmd, /FORCE_RELEASE === 'true' \? 'patch' : ''/);
|
|
});
|
|
|
|
it('does not configure any commit type to create an automatic major release', () => {
|
|
const config = createReleaseConfig({ KTX_RELEASE_KIND: 'stable', GITHUB_REF_NAME: 'main' });
|
|
const analyzer = config.plugins.find(
|
|
(plugin) => Array.isArray(plugin) && plugin[0] === '@semantic-release/commit-analyzer',
|
|
);
|
|
|
|
assert.equal(
|
|
analyzer[1].releaseRules.some((rule) => rule.release === 'major'),
|
|
false,
|
|
);
|
|
assert.deepEqual(
|
|
analyzer[1].releaseRules.filter((rule) => rule.breaking || rule.type === 'major'),
|
|
[
|
|
{ breaking: true, release: 'minor' },
|
|
{ type: 'major', release: 'minor' },
|
|
],
|
|
);
|
|
});
|
|
});
|