mirror of
https://github.com/Kaelio/ktx.git
synced 2026-06-16 08:25:14 +02:00
The 34 `index.ts` re-export barrels inside `packages/cli/src/` were holdovers from the pre-fold multi-workspace structure. Post-fold-in they served no production purpose: external consumers go through the single package main entry, and in-repo callers mostly imported through them only because the path was short. Internally, knip flagged most barrel re-exports as production-dead (only reached via tests). This change: - Deletes every internal barrel except `packages/cli/src/index.ts` (the published package entry). - Rewrites ~270 source/test files to import each name directly from the file that defines it. - Moves `tools/warehouse-verification/index.ts` to `create-warehouse-verification-tools.ts` (the function it defined locally) and updates its single consumer. - Renames `search/backend-conformance.ts` → `.test-utils.ts` to match the existing test-helper file convention. - Deletes 13 dead test-only chains (dbt-descriptions/*, live-database/extracted-schema, live-database/structural-sync, relationship-* feedback/review chain) plus their tests and a cascading orphan integration test. - Updates test mocks that pointed at deleted barrel paths (notion-client, connector barrels in scan/local-scan-connectors tests) to mock the source files instead. - Points the maintainer benchmark script (`scripts/relationship-benchmark-report.mjs`) at source files instead of `dist/context/scan/index.js`. - Drops the barrel `!` entries from `knip.json`; adds explicit production entries only for the benchmark code reached via dist by the maintainer script. Net: 413 files changed, ~1.2k insertions, ~9.4k deletions. `pnpm run dead-code` (Biome + knip default + knip production) and `pnpm run type-check` are clean; 2277 tests pass.
106 lines
4.3 KiB
TypeScript
106 lines
4.3 KiB
TypeScript
import type { KtxEmbeddingProvider } from './llm/types.js';
|
|
import { createKtxEmbeddingProvider as defaultCreateKtxEmbeddingProvider } from './llm/embedding-provider.js';
|
|
import type { KtxLocalProject } from './context/project/project.js';
|
|
import type { KtxProjectEmbeddingConfig } from './context/project/config.js';
|
|
import { resolveLocalKtxEmbeddingConfig } from './context/llm/local-config.js';
|
|
import type { KtxCliIo } from './cli-runtime.js';
|
|
import {
|
|
ensureManagedLocalEmbeddingsDaemon as defaultEnsureManagedDaemon,
|
|
tryUseManagedLocalEmbeddingsDaemon as defaultTryUseManagedDaemon,
|
|
} from './managed-local-embeddings.js';
|
|
import type { KtxManagedPythonInstallPolicy } from './managed-python-command.js';
|
|
|
|
type EmbeddingResolutionMode = 'ensure' | 'use-if-running';
|
|
|
|
export type EmbeddingProviderResolution =
|
|
| { kind: 'disabled' }
|
|
| { kind: 'configured'; provider: KtxEmbeddingProvider; baseUrl: string }
|
|
| { kind: 'managed-running'; provider: KtxEmbeddingProvider; baseUrl: string }
|
|
| { kind: 'managed-started'; provider: KtxEmbeddingProvider; baseUrl: string }
|
|
| { kind: 'managed-unavailable'; reason: string };
|
|
|
|
export interface ResolveProjectEmbeddingProviderOptions {
|
|
mode: EmbeddingResolutionMode;
|
|
cliVersion: string;
|
|
io: KtxCliIo;
|
|
/** Required when mode === 'ensure'. */
|
|
installPolicy?: KtxManagedPythonInstallPolicy;
|
|
tryUseManagedDaemon?: typeof defaultTryUseManagedDaemon;
|
|
ensureManagedDaemon?: typeof defaultEnsureManagedDaemon;
|
|
createKtxEmbeddingProvider?: typeof defaultCreateKtxEmbeddingProvider;
|
|
}
|
|
|
|
function usesManagedDaemon(embeddings: KtxProjectEmbeddingConfig): boolean {
|
|
if (embeddings.backend !== 'sentence-transformers') {
|
|
return false;
|
|
}
|
|
const baseUrl = embeddings.sentenceTransformers?.base_url;
|
|
return baseUrl === undefined || baseUrl === '';
|
|
}
|
|
|
|
export async function resolveProjectEmbeddingProvider(
|
|
project: KtxLocalProject,
|
|
options: ResolveProjectEmbeddingProviderOptions,
|
|
): Promise<EmbeddingProviderResolution> {
|
|
const embeddings = project.config.ingest.embeddings;
|
|
if (embeddings.backend === 'none') {
|
|
return { kind: 'disabled' };
|
|
}
|
|
const createProvider = options.createKtxEmbeddingProvider ?? defaultCreateKtxEmbeddingProvider;
|
|
|
|
if (!usesManagedDaemon(embeddings)) {
|
|
const resolved = resolveLocalKtxEmbeddingConfig(embeddings, process.env);
|
|
if (!resolved) {
|
|
return { kind: 'managed-unavailable', reason: 'embedding config missing required fields' };
|
|
}
|
|
const provider = createProvider(resolved);
|
|
const baseUrl = embeddings.sentenceTransformers?.base_url ?? '';
|
|
return { kind: 'configured', provider, baseUrl };
|
|
}
|
|
|
|
const tryUse = options.tryUseManagedDaemon ?? defaultTryUseManagedDaemon;
|
|
const running = await tryUse({ cliVersion: options.cliVersion, projectDir: project.projectDir });
|
|
|
|
if (running) {
|
|
const provider = buildManagedProvider(embeddings, running.baseUrl, createProvider);
|
|
return provider
|
|
? { kind: 'managed-running', provider, baseUrl: running.baseUrl }
|
|
: { kind: 'managed-unavailable', reason: 'failed to build embedding provider from running daemon' };
|
|
}
|
|
|
|
if (options.mode === 'use-if-running') {
|
|
return { kind: 'managed-unavailable', reason: 'managed embeddings daemon is not running' };
|
|
}
|
|
|
|
const ensure = options.ensureManagedDaemon ?? defaultEnsureManagedDaemon;
|
|
if (!options.installPolicy) {
|
|
throw new Error("installPolicy is required when mode === 'ensure'");
|
|
}
|
|
const daemon = await ensure({
|
|
cliVersion: options.cliVersion,
|
|
projectDir: project.projectDir,
|
|
installPolicy: options.installPolicy,
|
|
io: options.io,
|
|
});
|
|
const provider = buildManagedProvider(embeddings, daemon.baseUrl, createProvider);
|
|
return provider
|
|
? { kind: 'managed-started', provider, baseUrl: daemon.baseUrl }
|
|
: { kind: 'managed-unavailable', reason: 'failed to build embedding provider after starting daemon' };
|
|
}
|
|
|
|
function buildManagedProvider(
|
|
embeddings: KtxProjectEmbeddingConfig,
|
|
baseUrl: string,
|
|
createProvider: typeof defaultCreateKtxEmbeddingProvider,
|
|
): KtxEmbeddingProvider | null {
|
|
const merged: KtxProjectEmbeddingConfig = {
|
|
...embeddings,
|
|
sentenceTransformers: {
|
|
...embeddings.sentenceTransformers,
|
|
base_url: baseUrl,
|
|
pathPrefix: '',
|
|
},
|
|
};
|
|
const resolved = resolveLocalKtxEmbeddingConfig(merged, process.env);
|
|
return resolved ? createProvider(resolved) : null;
|
|
}
|