mirror of
https://github.com/Kaelio/ktx.git
synced 2026-06-07 07:55:13 +02:00
* feat(cli): define full warehouse dialect contract
* test(cli): keep dialect edge tests focused
* fix(cli): stabilize dialect contract foundation
* refactor(connectors): own read-only query preparation
* refactor(connectors): resolve dialects through registry
* refactor(connectors): keep concrete dialect classes internal
* chore(workspace): enforce dialect import boundary
* refactor(cli): resolve relationship dialect at scan boundary
* refactor(cli): use dialect display parsing for entity details
* refactor(cli): use dialect display parsing for warehouse catalog
* refactor(cli): use dialect SQL in relationship workflows
* test(cli): verify solid dialect scan workflow closure
* test: split cli tests from source tree
* refactor(cli): standardize BigQuery scope listing
* feat(sqlite): implement connector scope listing
* test(connectors): cover required table listing
* feat(cli): add warehouse driver registry
* refactor(setup): route scope discovery through driver registry
* refactor(cli): route local query execution through driver registry
* refactor(historic-sql): route dialect support through driver registry
* refactor(cli): test warehouse connections through driver registry
* fix(cli): close driver registry type export gaps
* Improve setup daemon diagnostics
* refactor(setup): centralize rail-prefixed diagnostics + query-history fallback
Extract errorMessage, writePrefixedLines, and flushPrefixedBufferedCommandOutput
into clack.ts so the setup wizard, managed daemons, and embedding/agent steps
share one rail-formatted writer. setup-databases.ts also adds a
"disable query history and retry" option when the schema-context build fails
and query history is the likely culprit, surfaced via a new
failed-query-history-unavailable status.
* fix(cli): carry catalog through the picker so BigQuery/Snowflake/SQL Server scope filters match
The setup picker's KtxTableListEntry was a 2-level { schema, name }, so
qualifiedTableId always wrote db.name into enabled_tables. When BigQuery,
Snowflake, or SQL Server later ran fast ingest, their introspect step filtered
the scope set with scopedTableNames(scope, { catalog: projectId|database, db })
— catalog was non-null on the introspect side but null in the scope refs, so
every entry was rejected, the live-database adapter staged zero table files,
and detect() failed with 'Adapter "live-database" did not recognize fetched
source output'.
Align the picker boundary with the canonical 3-level KtxTableRef:
- Add catalog: string | null to KtxTableListEntry.
- BigQuery/Snowflake/SQL Server listTables populate catalog from the
resolved projectId / database; Postgres/MySQL/ClickHouse/SQLite set null.
- qualifiedTableId emits catalog.schema.name when catalog is non-null
(resolveEnabledTables already accepts the 3-part shape) and
schemasFromEnabledTables now goes through parseDottedTableEntry so it
recovers the schema correctly from both 2-part and 3-part entries.
- Export parseDottedTableEntry from enabled-tables.ts (@internal) for picker
reuse.
Update listTables expectations in all seven connector tests and the setup /
picker test fixtures. Add a picker regression test that covers the
catalog-bearing round-trip (save + refine).
* fix(cli): allow debug telemetry under opt-out env
218 lines
7.1 KiB
TypeScript
218 lines
7.1 KiB
TypeScript
import { describe, expect, it } from 'vitest';
|
|
import type { ToolCallLogEntry } from '../../../../src/context/ingest/tools/tool-call-logger.js';
|
|
import { createMutableToolTranscriptSummary, recordToolTranscriptEntry } from '../../../../src/context/ingest/tools/tool-transcript-summary.js';
|
|
|
|
function entry(overrides: Partial<ToolCallLogEntry>): ToolCallLogEntry {
|
|
return {
|
|
ts: '2026-05-11T00:00:00.000Z',
|
|
wuKey: 'wu-1',
|
|
toolName: 'wiki_write',
|
|
durationMs: 1,
|
|
input: {},
|
|
...overrides,
|
|
};
|
|
}
|
|
|
|
describe('tool transcript summaries', () => {
|
|
it('keeps recovered wiki_write structured failures out of fatal failures', () => {
|
|
const summary = createMutableToolTranscriptSummary('wu-1', '/tmp/wu-1.jsonl');
|
|
|
|
recordToolTranscriptEntry(
|
|
summary,
|
|
entry({
|
|
input: { key: 'orbit-customers' },
|
|
output: { structured: { success: false, key: 'orbit-customers' } },
|
|
}),
|
|
);
|
|
recordToolTranscriptEntry(
|
|
summary,
|
|
entry({
|
|
input: { key: 'orbit-customers' },
|
|
output: { structured: { success: true, key: 'orbit-customers' } },
|
|
}),
|
|
);
|
|
|
|
expect(summary.errorCount).toBe(1);
|
|
expect(summary.fatalErrorCount).toBe(0);
|
|
});
|
|
|
|
it('treats a suggested flat wiki key retry as recovery for an invalid nested key', () => {
|
|
const summary = createMutableToolTranscriptSummary('wu-1', '/tmp/wu-1.jsonl');
|
|
|
|
recordToolTranscriptEntry(
|
|
summary,
|
|
entry({
|
|
input: { key: 'historic-sql/top-accounts-by-contract-arr' },
|
|
output: { structured: { success: false, key: 'historic-sql/top-accounts-by-contract-arr' } },
|
|
}),
|
|
);
|
|
recordToolTranscriptEntry(
|
|
summary,
|
|
entry({
|
|
input: { key: 'historic-sql-top-accounts-by-contract-arr' },
|
|
output: { structured: { success: true, key: 'historic-sql-top-accounts-by-contract-arr' } },
|
|
}),
|
|
);
|
|
|
|
expect(summary.errorCount).toBe(1);
|
|
expect(summary.fatalErrorCount).toBe(0);
|
|
});
|
|
|
|
it('counts unrecovered wiki_remove structured failures as fatal transcript errors', () => {
|
|
const summary = createMutableToolTranscriptSummary('reconcile', '/tmp/reconcile.jsonl');
|
|
|
|
recordToolTranscriptEntry(summary, {
|
|
ts: '2026-05-11T00:00:00.000Z',
|
|
wuKey: 'reconcile',
|
|
toolCallId: 'remove-1',
|
|
toolName: 'wiki_remove',
|
|
durationMs: 1,
|
|
input: { key: 'duplicate-page' },
|
|
output: { structured: { success: false, key: 'duplicate-page' } },
|
|
});
|
|
|
|
expect(summary.errorCount).toBe(1);
|
|
expect(summary.fatalErrorCount).toBe(1);
|
|
});
|
|
|
|
it('keeps unrecovered structured write failures fatal', () => {
|
|
const summary = createMutableToolTranscriptSummary('wu-1', '/tmp/wu-1.jsonl');
|
|
|
|
recordToolTranscriptEntry(
|
|
summary,
|
|
entry({
|
|
input: { key: 'orbit-customers' },
|
|
output: { structured: { success: false, key: 'orbit-customers' } },
|
|
}),
|
|
);
|
|
|
|
expect(summary.errorCount).toBe(1);
|
|
expect(summary.fatalErrorCount).toBe(1);
|
|
});
|
|
|
|
it('treats a later sl_edit_source success as recovery for the same SL source', () => {
|
|
const summary = createMutableToolTranscriptSummary('wu-1', '/tmp/wu-1.jsonl');
|
|
|
|
recordToolTranscriptEntry(
|
|
summary,
|
|
entry({
|
|
toolName: 'sl_write_source',
|
|
input: { connectionId: 'warehouse', sourceName: 'orbit_customers' },
|
|
output: { structured: { success: false, sourceName: 'orbit_customers' } },
|
|
}),
|
|
);
|
|
recordToolTranscriptEntry(
|
|
summary,
|
|
entry({
|
|
toolName: 'sl_edit_source',
|
|
input: { connectionId: 'warehouse', sourceName: 'orbit_customers' },
|
|
output: { structured: { success: true, sourceName: 'orbit_customers' } },
|
|
}),
|
|
);
|
|
|
|
expect(summary.errorCount).toBe(1);
|
|
expect(summary.fatalErrorCount).toBe(0);
|
|
});
|
|
|
|
it('treats explicit unmapped fallback as recovery for guarded SL write failures', () => {
|
|
const summary = createMutableToolTranscriptSummary('wu-1', '/tmp/wu-1.jsonl');
|
|
|
|
recordToolTranscriptEntry(
|
|
summary,
|
|
entry({
|
|
toolName: 'sl_write_source',
|
|
input: { connectionId: 'dbt-main', sourceName: 'stg_accounts' },
|
|
output: { structured: { success: false, sourceName: 'stg_accounts' } },
|
|
}),
|
|
);
|
|
recordToolTranscriptEntry(
|
|
summary,
|
|
entry({
|
|
toolName: 'emit_unmapped_fallback',
|
|
input: { rawPath: 'models/schema.yml', reason: 'no_physical_table', tableRef: 'stg_accounts', fallback: 'wiki_only' },
|
|
output: 'recorded unmapped fallback for models/schema.yml (wiki_only)',
|
|
}),
|
|
);
|
|
|
|
expect(summary.errorCount).toBe(1);
|
|
expect(summary.fatalErrorCount).toBe(0);
|
|
});
|
|
|
|
it('treats an untargeted unmapped fallback as recovery when there is only one pending SL failure', () => {
|
|
const summary = createMutableToolTranscriptSummary('wu-1', '/tmp/wu-1.jsonl');
|
|
|
|
recordToolTranscriptEntry(
|
|
summary,
|
|
entry({
|
|
toolName: 'sl_write_source',
|
|
input: { connectionId: 'dbt-main', sourceName: 'stg_accounts' },
|
|
output: { structured: { success: false, sourceName: 'stg_accounts' } },
|
|
}),
|
|
);
|
|
recordToolTranscriptEntry(
|
|
summary,
|
|
entry({
|
|
toolName: 'emit_unmapped_fallback',
|
|
input: { rawPath: 'models/schema.yml', reason: 'no_physical_table', fallback: 'wiki_only' },
|
|
output: 'recorded unmapped fallback for models/schema.yml (wiki_only)',
|
|
}),
|
|
);
|
|
|
|
expect(summary.errorCount).toBe(1);
|
|
expect(summary.fatalErrorCount).toBe(0);
|
|
});
|
|
|
|
it('keeps unrelated SL write failures fatal when one source gets an unmapped fallback', () => {
|
|
const summary = createMutableToolTranscriptSummary('wu-1', '/tmp/wu-1.jsonl');
|
|
|
|
recordToolTranscriptEntry(
|
|
summary,
|
|
entry({
|
|
toolName: 'sl_write_source',
|
|
input: { connectionId: 'dbt-main', sourceName: 'stg_accounts' },
|
|
output: { structured: { success: false, sourceName: 'stg_accounts' } },
|
|
}),
|
|
);
|
|
recordToolTranscriptEntry(
|
|
summary,
|
|
entry({
|
|
toolName: 'sl_write_source',
|
|
input: { connectionId: 'dbt-main', sourceName: 'stg_orders' },
|
|
output: { structured: { success: false, sourceName: 'stg_orders' } },
|
|
}),
|
|
);
|
|
recordToolTranscriptEntry(
|
|
summary,
|
|
entry({
|
|
toolName: 'emit_unmapped_fallback',
|
|
input: { rawPath: 'models/schema.yml', reason: 'no_physical_table', tableRef: 'stg_accounts', fallback: 'wiki_only' },
|
|
output: 'recorded unmapped fallback for models/schema.yml (wiki_only)',
|
|
}),
|
|
);
|
|
|
|
expect(summary.errorCount).toBe(2);
|
|
expect(summary.fatalErrorCount).toBe(1);
|
|
});
|
|
|
|
it('keeps thrown tool errors fatal even after a successful write', () => {
|
|
const summary = createMutableToolTranscriptSummary('wu-1', '/tmp/wu-1.jsonl');
|
|
|
|
recordToolTranscriptEntry(
|
|
summary,
|
|
entry({
|
|
input: { key: 'orbit-customers' },
|
|
error: { message: 'tool crashed' },
|
|
}),
|
|
);
|
|
recordToolTranscriptEntry(
|
|
summary,
|
|
entry({
|
|
input: { key: 'orbit-customers' },
|
|
output: { structured: { success: true, key: 'orbit-customers' } },
|
|
}),
|
|
);
|
|
|
|
expect(summary.errorCount).toBe(1);
|
|
expect(summary.fatalErrorCount).toBe(1);
|
|
});
|
|
});
|