mirror of
https://github.com/Kaelio/ktx.git
synced 2026-06-07 07:55:13 +02:00
* feat(cli): define full warehouse dialect contract
* test(cli): keep dialect edge tests focused
* fix(cli): stabilize dialect contract foundation
* refactor(connectors): own read-only query preparation
* refactor(connectors): resolve dialects through registry
* refactor(connectors): keep concrete dialect classes internal
* chore(workspace): enforce dialect import boundary
* refactor(cli): resolve relationship dialect at scan boundary
* refactor(cli): use dialect display parsing for entity details
* refactor(cli): use dialect display parsing for warehouse catalog
* refactor(cli): use dialect SQL in relationship workflows
* test(cli): verify solid dialect scan workflow closure
* test: split cli tests from source tree
* refactor(cli): standardize BigQuery scope listing
* feat(sqlite): implement connector scope listing
* test(connectors): cover required table listing
* feat(cli): add warehouse driver registry
* refactor(setup): route scope discovery through driver registry
* refactor(cli): route local query execution through driver registry
* refactor(historic-sql): route dialect support through driver registry
* refactor(cli): test warehouse connections through driver registry
* fix(cli): close driver registry type export gaps
* Improve setup daemon diagnostics
* refactor(setup): centralize rail-prefixed diagnostics + query-history fallback
Extract errorMessage, writePrefixedLines, and flushPrefixedBufferedCommandOutput
into clack.ts so the setup wizard, managed daemons, and embedding/agent steps
share one rail-formatted writer. setup-databases.ts also adds a
"disable query history and retry" option when the schema-context build fails
and query history is the likely culprit, surfaced via a new
failed-query-history-unavailable status.
* fix(cli): carry catalog through the picker so BigQuery/Snowflake/SQL Server scope filters match
The setup picker's KtxTableListEntry was a 2-level { schema, name }, so
qualifiedTableId always wrote db.name into enabled_tables. When BigQuery,
Snowflake, or SQL Server later ran fast ingest, their introspect step filtered
the scope set with scopedTableNames(scope, { catalog: projectId|database, db })
— catalog was non-null on the introspect side but null in the scope refs, so
every entry was rejected, the live-database adapter staged zero table files,
and detect() failed with 'Adapter "live-database" did not recognize fetched
source output'.
Align the picker boundary with the canonical 3-level KtxTableRef:
- Add catalog: string | null to KtxTableListEntry.
- BigQuery/Snowflake/SQL Server listTables populate catalog from the
resolved projectId / database; Postgres/MySQL/ClickHouse/SQLite set null.
- qualifiedTableId emits catalog.schema.name when catalog is non-null
(resolveEnabledTables already accepts the 3-part shape) and
schemasFromEnabledTables now goes through parseDottedTableEntry so it
recovers the schema correctly from both 2-part and 3-part entries.
- Export parseDottedTableEntry from enabled-tables.ts (@internal) for picker
reuse.
Update listTables expectations in all seven connector tests and the setup /
picker test fixtures. Add a picker regression test that covers the
catalog-bearing round-trip (save + refine).
* fix(cli): allow debug telemetry under opt-out env
141 lines
3.7 KiB
TypeScript
141 lines
3.7 KiB
TypeScript
import { describe, expect, it } from 'vitest';
|
|
|
|
import { buildTelemetryEvent, type TelemetryCommonEnvelope } from '../../src/telemetry/events.js';
|
|
|
|
const BLACKLIST = [
|
|
'/Users/',
|
|
'/home/',
|
|
'C:\\',
|
|
'localhost',
|
|
'.local',
|
|
'kaelio.com',
|
|
'select ',
|
|
'SELECT ',
|
|
'INSERT',
|
|
'CREATE',
|
|
'@',
|
|
'password',
|
|
'secret',
|
|
'token',
|
|
'key',
|
|
];
|
|
|
|
const envelope: TelemetryCommonEnvelope = {
|
|
cliVersion: '0.4.1',
|
|
nodeVersion: 'v22.0.0',
|
|
osPlatform: 'darwin',
|
|
osRelease: '25.0.0',
|
|
arch: 'arm64',
|
|
runtime: 'node',
|
|
isCi: false,
|
|
};
|
|
|
|
describe('telemetry privacy snapshot', () => {
|
|
it('does not emit known private substrings from phase 1 event payloads', () => {
|
|
const events = [
|
|
buildTelemetryEvent('install_first_run', envelope, {}),
|
|
buildTelemetryEvent('command', envelope, {
|
|
commandPath: ['ktx', 'sql'],
|
|
durationMs: 10,
|
|
outcome: 'error',
|
|
errorClass: 'KtxProjectMissingAbortError',
|
|
flagsPresent: {
|
|
'project-dir': true,
|
|
connection: true,
|
|
c: true,
|
|
},
|
|
hasProject: false,
|
|
projectGroupAttached: false,
|
|
}),
|
|
buildTelemetryEvent('setup_step', envelope, {
|
|
step: 'databases',
|
|
outcome: 'completed',
|
|
durationMs: 42,
|
|
}),
|
|
buildTelemetryEvent('connection_added', envelope, {
|
|
driver: 'postgres',
|
|
isDemoConnection: false,
|
|
}),
|
|
buildTelemetryEvent('connection_test', envelope, {
|
|
driver: 'postgres',
|
|
isDemoConnection: false,
|
|
outcome: 'error',
|
|
errorClass: 'KtxConnectionTestAbortError',
|
|
durationMs: 34,
|
|
serverVersion: '16',
|
|
}),
|
|
buildTelemetryEvent('project_stack_snapshot', envelope, {
|
|
connectors: [
|
|
{ driver: 'sqlite', isDemo: true },
|
|
{ driver: 'postgres', isDemo: false },
|
|
],
|
|
connectionCount: 2,
|
|
hasSl: true,
|
|
hasWiki: true,
|
|
hasMcp: true,
|
|
hasManagedRuntime: true,
|
|
}),
|
|
buildTelemetryEvent('ingest_completed', envelope, {
|
|
driver: 'postgres',
|
|
isDemoConnection: false,
|
|
schemaCount: 2,
|
|
tableCount: 4,
|
|
columnCount: 20,
|
|
rowsBucket: '<100k',
|
|
durationMs: 100,
|
|
outcome: 'ok',
|
|
}),
|
|
buildTelemetryEvent('scan_completed', envelope, {
|
|
driver: 'postgres',
|
|
tableCount: 4,
|
|
columnCount: 20,
|
|
inferredFkCount: 2,
|
|
declaredFkCount: 1,
|
|
durationMs: 70,
|
|
outcome: 'ok',
|
|
}),
|
|
buildTelemetryEvent('sl_validate_completed', envelope, {
|
|
sourceCount: 1,
|
|
modelCount: 3,
|
|
validationErrorCount: 0,
|
|
outcome: 'ok',
|
|
durationMs: 15,
|
|
}),
|
|
buildTelemetryEvent('sl_query_completed', envelope, {
|
|
mode: 'compile',
|
|
referencedSourceCount: 1,
|
|
referencedDimensionCount: 2,
|
|
referencedMeasureCount: 1,
|
|
durationMs: 18,
|
|
outcome: 'ok',
|
|
}),
|
|
buildTelemetryEvent('sql_completed', envelope, {
|
|
driver: 'postgres',
|
|
isDemoConnection: false,
|
|
queryVerb: 'select',
|
|
referencedTableCount: 3,
|
|
durationMs: 20,
|
|
outcome: 'ok',
|
|
}),
|
|
buildTelemetryEvent('wiki_query_completed', envelope, {
|
|
queryLength: 'select private_table from /Users/alice'.length,
|
|
resultCount: 2,
|
|
durationMs: 8,
|
|
outcome: 'ok',
|
|
}),
|
|
buildTelemetryEvent('mcp_request_completed', envelope, {
|
|
toolName: 'sl_query',
|
|
outcome: 'error',
|
|
errorClass: 'KtxProjectMissingAbortError',
|
|
durationMs: 12,
|
|
sampleRate: 0.1,
|
|
}),
|
|
];
|
|
|
|
const payload = JSON.stringify(events);
|
|
|
|
for (const forbidden of BLACKLIST) {
|
|
expect(payload).not.toContain(forbidden);
|
|
}
|
|
});
|
|
});
|