mirror of
https://github.com/Kaelio/ktx.git
synced 2026-06-07 07:55:13 +02:00
56985b7e09
* feat(cli): define full warehouse dialect contract
* test(cli): keep dialect edge tests focused
* fix(cli): stabilize dialect contract foundation
* refactor(connectors): own read-only query preparation
* refactor(connectors): resolve dialects through registry
* refactor(connectors): keep concrete dialect classes internal
* chore(workspace): enforce dialect import boundary
* refactor(cli): resolve relationship dialect at scan boundary
* refactor(cli): use dialect display parsing for entity details
* refactor(cli): use dialect display parsing for warehouse catalog
* refactor(cli): use dialect SQL in relationship workflows
* test(cli): verify solid dialect scan workflow closure
* test: split cli tests from source tree
* refactor(cli): standardize BigQuery scope listing
* feat(sqlite): implement connector scope listing
* test(connectors): cover required table listing
* feat(cli): add warehouse driver registry
* refactor(setup): route scope discovery through driver registry
* refactor(cli): route local query execution through driver registry
* refactor(historic-sql): route dialect support through driver registry
* refactor(cli): test warehouse connections through driver registry
* fix(cli): close driver registry type export gaps
* Improve setup daemon diagnostics
* refactor(setup): centralize rail-prefixed diagnostics + query-history fallback
Extract errorMessage, writePrefixedLines, and flushPrefixedBufferedCommandOutput
into clack.ts so the setup wizard, managed daemons, and embedding/agent steps
share one rail-formatted writer. setup-databases.ts also adds a
"disable query history and retry" option when the schema-context build fails
and query history is the likely culprit, surfaced via a new
failed-query-history-unavailable status.
* fix(cli): carry catalog through the picker so BigQuery/Snowflake/SQL Server scope filters match
The setup picker's KtxTableListEntry was a 2-level { schema, name }, so
qualifiedTableId always wrote db.name into enabled_tables. When BigQuery,
Snowflake, or SQL Server later ran fast ingest, their introspect step filtered
the scope set with scopedTableNames(scope, { catalog: projectId|database, db })
— catalog was non-null on the introspect side but null in the scope refs, so
every entry was rejected, the live-database adapter staged zero table files,
and detect() failed with 'Adapter "live-database" did not recognize fetched
source output'.
Align the picker boundary with the canonical 3-level KtxTableRef:
- Add catalog: string | null to KtxTableListEntry.
- BigQuery/Snowflake/SQL Server listTables populate catalog from the
resolved projectId / database; Postgres/MySQL/ClickHouse/SQLite set null.
- qualifiedTableId emits catalog.schema.name when catalog is non-null
(resolveEnabledTables already accepts the 3-part shape) and
schemasFromEnabledTables now goes through parseDottedTableEntry so it
recovers the schema correctly from both 2-part and 3-part entries.
- Export parseDottedTableEntry from enabled-tables.ts (@internal) for picker
reuse.
Update listTables expectations in all seven connector tests and the setup /
picker test fixtures. Add a picker regression test that covers the
catalog-bearing round-trip (save + refine).
* fix(cli): allow debug telemetry under opt-out env
52 lines
2.4 KiB
TypeScript
52 lines
2.4 KiB
TypeScript
import { describe, expect, it } from 'vitest';
|
|
import {
|
|
publicDatabaseIngestMessage,
|
|
publicIngestOutputLine,
|
|
publicQueryHistoryMessage,
|
|
} from '../src/public-ingest-copy.js';
|
|
|
|
describe('public ingest copy sanitizers', () => {
|
|
it('maps database scan progress into schema-context wording', () => {
|
|
expect(publicDatabaseIngestMessage('Preparing scan')).toBe('Preparing database ingest');
|
|
expect(publicDatabaseIngestMessage('Inspecting database schema')).toBe('Reading database schema');
|
|
expect(publicDatabaseIngestMessage('Writing schema artifacts')).toBe('Writing schema context');
|
|
expect(publicDatabaseIngestMessage('Enriching schema metadata')).toBe('Building enriched schema context');
|
|
});
|
|
|
|
it('maps database scan failure text into public database ingest wording', () => {
|
|
expect(
|
|
publicDatabaseIngestMessage(
|
|
'KTX scan enrichment failed after structural scan completed: embedding service timed out',
|
|
),
|
|
).toBe('Database enrichment failed after schema context completed: embedding service timed out');
|
|
expect(publicDatabaseIngestMessage('structural scan wrote partial artifacts')).toBe(
|
|
'schema context wrote partial artifacts',
|
|
);
|
|
expect(publicDatabaseIngestMessage('scan results may be less complete')).toBe(
|
|
'database context may be less complete',
|
|
);
|
|
});
|
|
|
|
it('maps query-history adapter progress into public wording', () => {
|
|
expect(publicQueryHistoryMessage('Fetching source files for warehouse/historic-sql', 'warehouse')).toBe(
|
|
'Fetching query history for warehouse',
|
|
);
|
|
expect(publicQueryHistoryMessage('Curating warehouse/historic-sql tasks', 'warehouse')).toBe(
|
|
'Curating warehouse query history tasks',
|
|
);
|
|
expect(publicQueryHistoryMessage('historic SQL local ingest failed', 'warehouse')).toBe(
|
|
'query history local ingest failed',
|
|
);
|
|
});
|
|
|
|
it('sanitizes captured public output lines across database and query-history internals', () => {
|
|
expect(
|
|
publicIngestOutputLine(
|
|
'KTX scan enrichment failed after structural scan completed in raw-sources/warehouse/live-database/sync-1',
|
|
),
|
|
).toBe('Database enrichment failed after schema context completed in raw-sources/warehouse/database schema/sync-1');
|
|
expect(publicIngestOutputLine('Historic SQL local ingest requires a configured reader')).toBe(
|
|
'query history local ingest requires a configured reader',
|
|
);
|
|
});
|
|
});
|