mirror of
https://github.com/Kaelio/ktx.git
synced 2026-06-07 07:55:13 +02:00
* feat(cli): define full warehouse dialect contract
* test(cli): keep dialect edge tests focused
* fix(cli): stabilize dialect contract foundation
* refactor(connectors): own read-only query preparation
* refactor(connectors): resolve dialects through registry
* refactor(connectors): keep concrete dialect classes internal
* chore(workspace): enforce dialect import boundary
* refactor(cli): resolve relationship dialect at scan boundary
* refactor(cli): use dialect display parsing for entity details
* refactor(cli): use dialect display parsing for warehouse catalog
* refactor(cli): use dialect SQL in relationship workflows
* test(cli): verify solid dialect scan workflow closure
* test: split cli tests from source tree
* refactor(cli): standardize BigQuery scope listing
* feat(sqlite): implement connector scope listing
* test(connectors): cover required table listing
* feat(cli): add warehouse driver registry
* refactor(setup): route scope discovery through driver registry
* refactor(cli): route local query execution through driver registry
* refactor(historic-sql): route dialect support through driver registry
* refactor(cli): test warehouse connections through driver registry
* fix(cli): close driver registry type export gaps
* Improve setup daemon diagnostics
* refactor(setup): centralize rail-prefixed diagnostics + query-history fallback
Extract errorMessage, writePrefixedLines, and flushPrefixedBufferedCommandOutput
into clack.ts so the setup wizard, managed daemons, and embedding/agent steps
share one rail-formatted writer. setup-databases.ts also adds a
"disable query history and retry" option when the schema-context build fails
and query history is the likely culprit, surfaced via a new
failed-query-history-unavailable status.
* fix(cli): carry catalog through the picker so BigQuery/Snowflake/SQL Server scope filters match
The setup picker's KtxTableListEntry was a 2-level { schema, name }, so
qualifiedTableId always wrote db.name into enabled_tables. When BigQuery,
Snowflake, or SQL Server later ran fast ingest, their introspect step filtered
the scope set with scopedTableNames(scope, { catalog: projectId|database, db })
— catalog was non-null on the introspect side but null in the scope refs, so
every entry was rejected, the live-database adapter staged zero table files,
and detect() failed with 'Adapter "live-database" did not recognize fetched
source output'.
Align the picker boundary with the canonical 3-level KtxTableRef:
- Add catalog: string | null to KtxTableListEntry.
- BigQuery/Snowflake/SQL Server listTables populate catalog from the
resolved projectId / database; Postgres/MySQL/ClickHouse/SQLite set null.
- qualifiedTableId emits catalog.schema.name when catalog is non-null
(resolveEnabledTables already accepts the 3-part shape) and
schemasFromEnabledTables now goes through parseDottedTableEntry so it
recovers the schema correctly from both 2-part and 3-part entries.
- Export parseDottedTableEntry from enabled-tables.ts (@internal) for picker
reuse.
Update listTables expectations in all seven connector tests and the setup /
picker test fixtures. Add a picker regression test that covers the
catalog-bearing round-trip (save + refine).
* fix(cli): allow debug telemetry under opt-out env
202 lines
5.7 KiB
TypeScript
202 lines
5.7 KiB
TypeScript
import { mkdtemp, rm, writeFile } from 'node:fs/promises';
|
|
import { tmpdir } from 'node:os';
|
|
import { join } from 'node:path';
|
|
import { loadKtxProject } from '../src/context/project/project.js';
|
|
import { afterEach, beforeEach, describe, expect, it } from 'vitest';
|
|
import { createKtxCliLocalIngestAdapters } from '../src/local-adapters.js';
|
|
|
|
function sqlAnalysisStub() {
|
|
return {
|
|
async analyzeForFingerprint(sql: string) {
|
|
return {
|
|
fingerprint: 'fp',
|
|
normalizedSql: sql,
|
|
tablesTouched: [],
|
|
literalSlots: [],
|
|
};
|
|
},
|
|
async analyzeBatch() {
|
|
return new Map();
|
|
},
|
|
async validateReadOnly() {
|
|
return { ok: true };
|
|
},
|
|
};
|
|
}
|
|
|
|
async function writeProject(projectDir: string, body: string): Promise<void> {
|
|
await writeFile(join(projectDir, 'ktx.yaml'), body, 'utf-8');
|
|
}
|
|
|
|
describe('CLI local ingest adapters', () => {
|
|
let tempDir: string;
|
|
|
|
beforeEach(async () => {
|
|
tempDir = await mkdtemp(join(tmpdir(), 'ktx-cli-local-adapters-'));
|
|
});
|
|
|
|
afterEach(async () => {
|
|
await rm(tempDir, { recursive: true, force: true });
|
|
});
|
|
|
|
it('registers Postgres historic SQL from connection context query history', async () => {
|
|
await writeProject(
|
|
tempDir,
|
|
[
|
|
'connections:',
|
|
' warehouse:',
|
|
' driver: postgres',
|
|
' url: env:WAREHOUSE_DATABASE_URL',
|
|
' readonly: true',
|
|
' context:',
|
|
' queryHistory:',
|
|
' enabled: true',
|
|
'ingest:',
|
|
' adapters:',
|
|
' - historic-sql',
|
|
'',
|
|
].join('\n'),
|
|
);
|
|
const project = await loadKtxProject({ projectDir: tempDir });
|
|
|
|
const adapters = createKtxCliLocalIngestAdapters(project, {
|
|
historicSqlConnectionId: 'warehouse',
|
|
sqlAnalysis: sqlAnalysisStub(),
|
|
});
|
|
|
|
expect(adapters.find((adapter) => adapter.source === 'historic-sql')?.skillNames).toEqual([
|
|
'historic_sql_table_digest',
|
|
'historic_sql_patterns',
|
|
]);
|
|
});
|
|
|
|
it('registers BigQuery historic SQL from the requested connection', async () => {
|
|
await writeProject(
|
|
tempDir,
|
|
[
|
|
'connections:',
|
|
' bq:',
|
|
' driver: bigquery',
|
|
' dataset_id: analytics',
|
|
' location: us',
|
|
' credentials_json: \'{"project_id":"demo-project"}\'',
|
|
' context:',
|
|
' queryHistory:',
|
|
' enabled: true',
|
|
'ingest:',
|
|
' adapters:',
|
|
' - historic-sql',
|
|
'',
|
|
].join('\n'),
|
|
);
|
|
const project = await loadKtxProject({ projectDir: tempDir });
|
|
|
|
const adapters = createKtxCliLocalIngestAdapters(project, {
|
|
historicSqlConnectionId: 'bq',
|
|
sqlAnalysis: sqlAnalysisStub(),
|
|
});
|
|
|
|
expect(adapters.find((adapter) => adapter.source === 'historic-sql')?.skillNames).toEqual([
|
|
'historic_sql_table_digest',
|
|
'historic_sql_patterns',
|
|
]);
|
|
});
|
|
|
|
it('registers Snowflake historic SQL from the requested connection', async () => {
|
|
await writeProject(
|
|
tempDir,
|
|
[
|
|
'connections:',
|
|
' sf:',
|
|
' driver: snowflake',
|
|
' account: acct',
|
|
' warehouse: wh',
|
|
' database: ANALYTICS',
|
|
' schema_name: PUBLIC',
|
|
' username: reader',
|
|
' password: env:SNOWFLAKE_PASSWORD',
|
|
' context:',
|
|
' queryHistory:',
|
|
' enabled: true',
|
|
'ingest:',
|
|
' adapters:',
|
|
' - historic-sql',
|
|
'',
|
|
].join('\n'),
|
|
);
|
|
const project = await loadKtxProject({ projectDir: tempDir });
|
|
|
|
const adapters = createKtxCliLocalIngestAdapters(project, {
|
|
historicSqlConnectionId: 'sf',
|
|
sqlAnalysis: sqlAnalysisStub(),
|
|
});
|
|
|
|
expect(adapters.find((adapter) => adapter.source === 'historic-sql')?.skillNames).toEqual([
|
|
'historic_sql_table_digest',
|
|
'historic_sql_patterns',
|
|
]);
|
|
});
|
|
|
|
it('resolves BigQuery credentials_json from a file: reference for query history ingest', async () => {
|
|
const credentialsPath = join(tempDir, 'credentials.json');
|
|
await writeFile(credentialsPath, JSON.stringify({ project_id: 'demo-project' }), 'utf-8');
|
|
await writeProject(
|
|
tempDir,
|
|
[
|
|
'connections:',
|
|
' bq:',
|
|
' driver: bigquery',
|
|
' dataset_id: analytics',
|
|
' location: us',
|
|
` credentials_json: 'file:${credentialsPath}'`,
|
|
' context:',
|
|
' queryHistory:',
|
|
' enabled: true',
|
|
'ingest:',
|
|
' adapters:',
|
|
' - historic-sql',
|
|
'',
|
|
].join('\n'),
|
|
);
|
|
const project = await loadKtxProject({ projectDir: tempDir });
|
|
|
|
const adapters = createKtxCliLocalIngestAdapters(project, {
|
|
historicSqlConnectionId: 'bq',
|
|
sqlAnalysis: sqlAnalysisStub(),
|
|
});
|
|
|
|
expect(adapters.find((adapter) => adapter.source === 'historic-sql')?.skillNames).toEqual([
|
|
'historic_sql_table_digest',
|
|
'historic_sql_patterns',
|
|
]);
|
|
});
|
|
|
|
it('uses query-history wording for public BigQuery capability errors', async () => {
|
|
await writeProject(
|
|
tempDir,
|
|
[
|
|
'connections:',
|
|
' bq:',
|
|
' driver: bigquery',
|
|
' readonly: true',
|
|
' dataset_id: analytics',
|
|
' credentials_json: "{}"',
|
|
' context:',
|
|
' queryHistory:',
|
|
' enabled: true',
|
|
'ingest:',
|
|
' adapters:',
|
|
' - historic-sql',
|
|
'',
|
|
].join('\n'),
|
|
);
|
|
const project = await loadKtxProject({ projectDir: tempDir });
|
|
|
|
expect(() =>
|
|
createKtxCliLocalIngestAdapters(project, {
|
|
historicSqlConnectionId: 'bq',
|
|
sqlAnalysis: sqlAnalysisStub(),
|
|
}),
|
|
).toThrow('Query history BigQuery connection requires credentials_json.project_id');
|
|
});
|
|
});
|