mirror of
https://github.com/Kaelio/ktx.git
synced 2026-06-07 07:55:13 +02:00
56985b7e09
* feat(cli): define full warehouse dialect contract
* test(cli): keep dialect edge tests focused
* fix(cli): stabilize dialect contract foundation
* refactor(connectors): own read-only query preparation
* refactor(connectors): resolve dialects through registry
* refactor(connectors): keep concrete dialect classes internal
* chore(workspace): enforce dialect import boundary
* refactor(cli): resolve relationship dialect at scan boundary
* refactor(cli): use dialect display parsing for entity details
* refactor(cli): use dialect display parsing for warehouse catalog
* refactor(cli): use dialect SQL in relationship workflows
* test(cli): verify solid dialect scan workflow closure
* test: split cli tests from source tree
* refactor(cli): standardize BigQuery scope listing
* feat(sqlite): implement connector scope listing
* test(connectors): cover required table listing
* feat(cli): add warehouse driver registry
* refactor(setup): route scope discovery through driver registry
* refactor(cli): route local query execution through driver registry
* refactor(historic-sql): route dialect support through driver registry
* refactor(cli): test warehouse connections through driver registry
* fix(cli): close driver registry type export gaps
* Improve setup daemon diagnostics
* refactor(setup): centralize rail-prefixed diagnostics + query-history fallback
Extract errorMessage, writePrefixedLines, and flushPrefixedBufferedCommandOutput
into clack.ts so the setup wizard, managed daemons, and embedding/agent steps
share one rail-formatted writer. setup-databases.ts also adds a
"disable query history and retry" option when the schema-context build fails
and query history is the likely culprit, surfaced via a new
failed-query-history-unavailable status.
* fix(cli): carry catalog through the picker so BigQuery/Snowflake/SQL Server scope filters match
The setup picker's KtxTableListEntry was a 2-level { schema, name }, so
qualifiedTableId always wrote db.name into enabled_tables. When BigQuery,
Snowflake, or SQL Server later ran fast ingest, their introspect step filtered
the scope set with scopedTableNames(scope, { catalog: projectId|database, db })
— catalog was non-null on the introspect side but null in the scope refs, so
every entry was rejected, the live-database adapter staged zero table files,
and detect() failed with 'Adapter "live-database" did not recognize fetched
source output'.
Align the picker boundary with the canonical 3-level KtxTableRef:
- Add catalog: string | null to KtxTableListEntry.
- BigQuery/Snowflake/SQL Server listTables populate catalog from the
resolved projectId / database; Postgres/MySQL/ClickHouse/SQLite set null.
- qualifiedTableId emits catalog.schema.name when catalog is non-null
(resolveEnabledTables already accepts the 3-part shape) and
schemasFromEnabledTables now goes through parseDottedTableEntry so it
recovers the schema correctly from both 2-part and 3-part entries.
- Export parseDottedTableEntry from enabled-tables.ts (@internal) for picker
reuse.
Update listTables expectations in all seven connector tests and the setup /
picker test fixtures. Add a picker regression test that covers the
catalog-bearing round-trip (save + refine).
* fix(cli): allow debug telemetry under opt-out env
57 lines
2.3 KiB
TypeScript
57 lines
2.3 KiB
TypeScript
import { readFileSync } from 'node:fs';
|
|
import { join } from 'node:path';
|
|
import { fileURLToPath } from 'node:url';
|
|
import { describe, expect, it } from 'vitest';
|
|
|
|
const ktxRoot = fileURLToPath(new URL('../../../../..', import.meta.url));
|
|
|
|
function readKtxFile(relativePath: string): string {
|
|
return readFileSync(join(ktxRoot, relativePath), 'utf8');
|
|
}
|
|
|
|
function readCliPackageJson(): {
|
|
dependencies?: Record<string, string>;
|
|
devDependencies?: Record<string, string>;
|
|
exports?: Record<string, unknown>;
|
|
files?: string[];
|
|
} {
|
|
return JSON.parse(readKtxFile('packages/cli/package.json'));
|
|
}
|
|
|
|
describe('PGlite hybrid search runtime boundary', () => {
|
|
it('keeps PGlite packages as dev-only prototype dependencies', () => {
|
|
const pkg = readCliPackageJson();
|
|
|
|
expect(pkg.dependencies?.['@electric-sql/pglite']).toBeUndefined();
|
|
expect(pkg.dependencies?.['@electric-sql/pglite-socket']).toBeUndefined();
|
|
expect(pkg.devDependencies?.['@electric-sql/pglite']).toBeDefined();
|
|
expect(pkg.devDependencies?.['@electric-sql/pglite-socket']).toBeDefined();
|
|
expect(pkg.files).toEqual(['dist', 'assets']);
|
|
});
|
|
|
|
it('keeps PGlite prototypes out of public exports and production routing', () => {
|
|
const pkg = readCliPackageJson();
|
|
const packageExportKeys = Object.keys(pkg.exports ?? {});
|
|
|
|
expect(packageExportKeys.filter((key) => key.toLowerCase().includes('pglite'))).toEqual([]);
|
|
|
|
const productionRoutingFiles = [
|
|
'packages/cli/src/sl.ts',
|
|
'packages/cli/src/knowledge.ts',
|
|
'packages/cli/src/context/mcp/local-project-ports.ts',
|
|
'packages/cli/src/context/wiki/local-knowledge.ts',
|
|
'packages/cli/src/context/ingest/context-evidence/sqlite-context-evidence-store.ts',
|
|
];
|
|
|
|
for (const relativePath of productionRoutingFiles) {
|
|
expect(readKtxFile(relativePath), relativePath).not.toMatch(
|
|
/pglite-owner-prototype|pglite-sl-search-prototype|@electric-sql\/pglite/i,
|
|
);
|
|
}
|
|
|
|
const localSlSource = readKtxFile('packages/cli/src/context/sl/local-sl.ts');
|
|
expect(localSlSource).toContain("input.backend === 'pglite-owner-prototype'");
|
|
expect(localSlSource).toContain('PGlite semantic-layer search prototype requires pglite owner-process options.');
|
|
expect(localSlSource).toContain("await import('./pglite-sl-search-prototype.js')");
|
|
});
|
|
});
|