mirror of
https://github.com/Kaelio/ktx.git
synced 2026-06-07 07:55:13 +02:00
* feat(cli): define full warehouse dialect contract
* test(cli): keep dialect edge tests focused
* fix(cli): stabilize dialect contract foundation
* refactor(connectors): own read-only query preparation
* refactor(connectors): resolve dialects through registry
* refactor(connectors): keep concrete dialect classes internal
* chore(workspace): enforce dialect import boundary
* refactor(cli): resolve relationship dialect at scan boundary
* refactor(cli): use dialect display parsing for entity details
* refactor(cli): use dialect display parsing for warehouse catalog
* refactor(cli): use dialect SQL in relationship workflows
* test(cli): verify solid dialect scan workflow closure
* test: split cli tests from source tree
* refactor(cli): standardize BigQuery scope listing
* feat(sqlite): implement connector scope listing
* test(connectors): cover required table listing
* feat(cli): add warehouse driver registry
* refactor(setup): route scope discovery through driver registry
* refactor(cli): route local query execution through driver registry
* refactor(historic-sql): route dialect support through driver registry
* refactor(cli): test warehouse connections through driver registry
* fix(cli): close driver registry type export gaps
* Improve setup daemon diagnostics
* refactor(setup): centralize rail-prefixed diagnostics + query-history fallback
Extract errorMessage, writePrefixedLines, and flushPrefixedBufferedCommandOutput
into clack.ts so the setup wizard, managed daemons, and embedding/agent steps
share one rail-formatted writer. setup-databases.ts also adds a
"disable query history and retry" option when the schema-context build fails
and query history is the likely culprit, surfaced via a new
failed-query-history-unavailable status.
* fix(cli): carry catalog through the picker so BigQuery/Snowflake/SQL Server scope filters match
The setup picker's KtxTableListEntry was a 2-level { schema, name }, so
qualifiedTableId always wrote db.name into enabled_tables. When BigQuery,
Snowflake, or SQL Server later ran fast ingest, their introspect step filtered
the scope set with scopedTableNames(scope, { catalog: projectId|database, db })
— catalog was non-null on the introspect side but null in the scope refs, so
every entry was rejected, the live-database adapter staged zero table files,
and detect() failed with 'Adapter "live-database" did not recognize fetched
source output'.
Align the picker boundary with the canonical 3-level KtxTableRef:
- Add catalog: string | null to KtxTableListEntry.
- BigQuery/Snowflake/SQL Server listTables populate catalog from the
resolved projectId / database; Postgres/MySQL/ClickHouse/SQLite set null.
- qualifiedTableId emits catalog.schema.name when catalog is non-null
(resolveEnabledTables already accepts the 3-part shape) and
schemasFromEnabledTables now goes through parseDottedTableEntry so it
recovers the schema correctly from both 2-part and 3-part entries.
- Export parseDottedTableEntry from enabled-tables.ts (@internal) for picker
reuse.
Update listTables expectations in all seven connector tests and the setup /
picker test fixtures. Add a picker regression test that covers the
catalog-bearing round-trip (save + refine).
* fix(cli): allow debug telemetry under opt-out env
102 lines
3.9 KiB
TypeScript
102 lines
3.9 KiB
TypeScript
import { mkdtemp, readFile, rm, stat } from 'node:fs/promises';
|
|
import { tmpdir } from 'node:os';
|
|
import { join } from 'node:path';
|
|
import { afterEach, beforeEach, describe, expect, it } from 'vitest';
|
|
import { GitService } from '../../../src/context/core/git.service.js';
|
|
import type { KtxCoreConfig } from '../../../src/context/core/config.js';
|
|
import { LocalGitFileStore } from '../../../src/context/project/local-git-file-store.js';
|
|
|
|
describe('LocalGitFileStore', () => {
|
|
let tempDir: string;
|
|
let store: LocalGitFileStore;
|
|
|
|
beforeEach(async () => {
|
|
tempDir = await mkdtemp(join(tmpdir(), 'ktx-local-store-'));
|
|
const coreConfig: KtxCoreConfig = {
|
|
storage: { configDir: tempDir, homeDir: tempDir },
|
|
git: {
|
|
userName: 'ktx',
|
|
userEmail: 'ktx@example.com',
|
|
bootstrapMessage: 'Initialize test project',
|
|
bootstrapAuthor: 'ktx',
|
|
bootstrapAuthorEmail: 'ktx@example.com',
|
|
},
|
|
};
|
|
const git = new GitService(coreConfig);
|
|
await git.onModuleInit();
|
|
store = new LocalGitFileStore({ rootDir: tempDir, git });
|
|
});
|
|
|
|
afterEach(async () => {
|
|
await rm(tempDir, { recursive: true, force: true });
|
|
});
|
|
|
|
it('writes, commits, and reads a project file', async () => {
|
|
const write = await store.writeFile(
|
|
'wiki/global/revenue.md',
|
|
'# Revenue\n',
|
|
'Agent',
|
|
'agent@example.com',
|
|
'Add revenue page',
|
|
);
|
|
|
|
expect(write.commitHash).toMatch(/^[0-9a-f]{40}$/);
|
|
await expect(readFile(join(tempDir, 'wiki/global/revenue.md'), 'utf-8')).resolves.toBe('# Revenue\n');
|
|
await expect(store.readFile('wiki/global/revenue.md')).resolves.toMatchObject({
|
|
content: '# Revenue\n',
|
|
});
|
|
});
|
|
|
|
it('lists files recursively and can strip the requested prefix', async () => {
|
|
await store.writeFile('wiki/global/a.md', 'a', 'Agent', 'agent@example.com', 'Add a');
|
|
await store.writeFile('wiki/global/nested/b.md', 'b', 'Agent', 'agent@example.com', 'Add b');
|
|
|
|
await expect(store.listFiles('wiki')).resolves.toEqual({
|
|
files: ['wiki/global/a.md', 'wiki/global/nested/b.md'],
|
|
});
|
|
await expect(store.listFiles('wiki/global', true)).resolves.toEqual({
|
|
files: ['a.md', 'nested/b.md'],
|
|
});
|
|
});
|
|
|
|
it('deletes and commits an existing file', async () => {
|
|
await store.writeFile('semantic-layer/conn/orders.yaml', 'name: orders\n', 'Agent', 'agent@example.com', 'Add SL');
|
|
|
|
const deleted = await store.deleteFile(
|
|
'semantic-layer/conn/orders.yaml',
|
|
'Agent',
|
|
'agent@example.com',
|
|
'Delete SL',
|
|
);
|
|
|
|
expect(deleted?.commitHash).toMatch(/^[0-9a-f]{40}$/);
|
|
await expect(stat(join(tempDir, 'semantic-layer/conn/orders.yaml'))).rejects.toThrow();
|
|
});
|
|
|
|
it('returns null when deleting a missing file', async () => {
|
|
await expect(store.deleteFile('missing.md', 'Agent', 'agent@example.com', 'Delete missing')).resolves.toBeNull();
|
|
});
|
|
|
|
it('exposes Git history for a file', async () => {
|
|
await store.writeFile('wiki/global/history.md', 'v1', 'Agent', 'agent@example.com', 'Add history');
|
|
await store.writeFile('wiki/global/history.md', 'v2', 'Agent', 'agent@example.com', 'Update history');
|
|
|
|
const history = await store.getFileHistory('wiki/global/history.md');
|
|
|
|
expect(Array.isArray(history)).toBe(true);
|
|
expect(history[0]).toMatchObject({ message: 'Update history' });
|
|
expect(history[1]).toMatchObject({ message: 'Add history' });
|
|
});
|
|
|
|
it('rejects absolute paths and parent-directory traversal', async () => {
|
|
await expect(store.writeFile('/tmp/outside.md', 'bad', 'Agent', 'agent@example.com', 'Bad write')).rejects.toThrow(
|
|
'Path must be relative',
|
|
);
|
|
|
|
await expect(store.readFile('../outside.md')).rejects.toThrow('Path escapes the project directory');
|
|
});
|
|
|
|
it('rejects direct .git access', async () => {
|
|
await expect(store.readFile('.git/config')).rejects.toThrow('Path cannot access .git');
|
|
});
|
|
});
|