mirror of
https://github.com/Kaelio/ktx.git
synced 2026-06-07 07:55:13 +02:00
* feat(cli): define full warehouse dialect contract
* test(cli): keep dialect edge tests focused
* fix(cli): stabilize dialect contract foundation
* refactor(connectors): own read-only query preparation
* refactor(connectors): resolve dialects through registry
* refactor(connectors): keep concrete dialect classes internal
* chore(workspace): enforce dialect import boundary
* refactor(cli): resolve relationship dialect at scan boundary
* refactor(cli): use dialect display parsing for entity details
* refactor(cli): use dialect display parsing for warehouse catalog
* refactor(cli): use dialect SQL in relationship workflows
* test(cli): verify solid dialect scan workflow closure
* test: split cli tests from source tree
* refactor(cli): standardize BigQuery scope listing
* feat(sqlite): implement connector scope listing
* test(connectors): cover required table listing
* feat(cli): add warehouse driver registry
* refactor(setup): route scope discovery through driver registry
* refactor(cli): route local query execution through driver registry
* refactor(historic-sql): route dialect support through driver registry
* refactor(cli): test warehouse connections through driver registry
* fix(cli): close driver registry type export gaps
* Improve setup daemon diagnostics
* refactor(setup): centralize rail-prefixed diagnostics + query-history fallback
Extract errorMessage, writePrefixedLines, and flushPrefixedBufferedCommandOutput
into clack.ts so the setup wizard, managed daemons, and embedding/agent steps
share one rail-formatted writer. setup-databases.ts also adds a
"disable query history and retry" option when the schema-context build fails
and query history is the likely culprit, surfaced via a new
failed-query-history-unavailable status.
* fix(cli): carry catalog through the picker so BigQuery/Snowflake/SQL Server scope filters match
The setup picker's KtxTableListEntry was a 2-level { schema, name }, so
qualifiedTableId always wrote db.name into enabled_tables. When BigQuery,
Snowflake, or SQL Server later ran fast ingest, their introspect step filtered
the scope set with scopedTableNames(scope, { catalog: projectId|database, db })
— catalog was non-null on the introspect side but null in the scope refs, so
every entry was rejected, the live-database adapter staged zero table files,
and detect() failed with 'Adapter "live-database" did not recognize fetched
source output'.
Align the picker boundary with the canonical 3-level KtxTableRef:
- Add catalog: string | null to KtxTableListEntry.
- BigQuery/Snowflake/SQL Server listTables populate catalog from the
resolved projectId / database; Postgres/MySQL/ClickHouse/SQLite set null.
- qualifiedTableId emits catalog.schema.name when catalog is non-null
(resolveEnabledTables already accepts the 3-part shape) and
schemasFromEnabledTables now goes through parseDottedTableEntry so it
recovers the schema correctly from both 2-part and 3-part entries.
- Export parseDottedTableEntry from enabled-tables.ts (@internal) for picker
reuse.
Update listTables expectations in all seven connector tests and the setup /
picker test fixtures. Add a picker regression test that covers the
catalog-bearing round-trip (save + refine).
* fix(cli): allow debug telemetry under opt-out env
153 lines
5.7 KiB
TypeScript
153 lines
5.7 KiB
TypeScript
import { describe, expect, it } from 'vitest';
|
|
import { findInvalidWikiBodyRefs, parseWikiBodyRefs } from '../../../src/context/ingest/wiki-body-refs.js';
|
|
|
|
const sources = [
|
|
{
|
|
name: 'mart_account_segments',
|
|
grain: ['account_id'],
|
|
columns: [
|
|
{ name: 'account_id', type: 'string' },
|
|
{ name: 'segment', type: 'string' },
|
|
],
|
|
joins: [],
|
|
measures: [{ name: 'total_contract_arr', expr: 'sum(contract_arr)' }],
|
|
segments: [{ name: 'enterprise', expr: "segment = 'enterprise'" }],
|
|
table: 'analytics.mart_account_segments',
|
|
},
|
|
];
|
|
|
|
describe('wiki body refs', () => {
|
|
it('parses only explicit inline-code body references outside fenced blocks', () => {
|
|
const body = [
|
|
'Valid `mart_account_segments.total_contract_arr` and `source:mart_account_segments`.',
|
|
'Also `warehouse/mart_account_segments.segment` and `table:analytics.mart_account_segments`.',
|
|
'Ignore prose mart_account_segments.total_contract_arr_cents.',
|
|
'Ignore `single_token`.',
|
|
'Ignore wildcard pattern `mart_nrr_quarterly.*_arr_cents`.',
|
|
'Ignore condition `users.is_internal = false`.',
|
|
'```sql',
|
|
'select `mart_account_segments.total_contract_arr_cents`',
|
|
'```',
|
|
].join('\n');
|
|
|
|
expect(parseWikiBodyRefs(body)).toEqual([
|
|
{ kind: 'sl_entity', connectionId: null, sourceName: 'mart_account_segments', entityName: 'total_contract_arr' },
|
|
{ kind: 'sl_source', connectionId: null, sourceName: 'mart_account_segments' },
|
|
{ kind: 'sl_entity', connectionId: 'warehouse', sourceName: 'mart_account_segments', entityName: 'segment' },
|
|
{ kind: 'table', connectionId: null, tableRef: 'analytics.mart_account_segments' },
|
|
]);
|
|
});
|
|
|
|
it('rejects stale inline-code semantic-layer references', async () => {
|
|
const invalid = await findInvalidWikiBodyRefs({
|
|
pageKey: 'account-segments',
|
|
body: 'ARR is documented as `mart_account_segments.total_contract_arr_cents`.',
|
|
visibleConnectionIds: ['warehouse'],
|
|
loadSources: async () => sources,
|
|
tableExists: async () => true,
|
|
});
|
|
|
|
expect(invalid).toEqual([
|
|
'account-segments: unknown semantic-layer entity mart_account_segments.total_contract_arr_cents',
|
|
]);
|
|
});
|
|
|
|
it('does not treat wildcard inline-code patterns as exact semantic-layer entity references', async () => {
|
|
const invalid = await findInvalidWikiBodyRefs({
|
|
pageKey: 'revenue-metrics-encoding',
|
|
body: 'Cents columns include `mart_nrr_quarterly.*_arr_cents` and `mart_retention_movement_breakout.*_arr_cents`.',
|
|
visibleConnectionIds: ['warehouse'],
|
|
loadSources: async () => [
|
|
{ name: 'mart_nrr_quarterly', grain: [], columns: [], joins: [], measures: [], table: 'analytics.mart_nrr_quarterly' },
|
|
{
|
|
name: 'mart_retention_movement_breakout',
|
|
grain: [],
|
|
columns: [],
|
|
joins: [],
|
|
measures: [],
|
|
table: 'analytics.mart_retention_movement_breakout',
|
|
},
|
|
],
|
|
tableExists: async () => true,
|
|
});
|
|
|
|
expect(invalid).toEqual([]);
|
|
});
|
|
|
|
it('does not treat inline-code SQL predicates as exact semantic-layer entity references', async () => {
|
|
const invalid = await findInvalidWikiBodyRefs({
|
|
pageKey: 'account-reporting-exclusions',
|
|
body: 'Exclude internal users with `users.is_internal = false` and test users with `users.is_test = false`.',
|
|
visibleConnectionIds: ['warehouse'],
|
|
loadSources: async () => [
|
|
{
|
|
name: 'users',
|
|
grain: [],
|
|
columns: [
|
|
{ name: 'is_internal', type: 'boolean' },
|
|
{ name: 'is_test', type: 'boolean' },
|
|
],
|
|
joins: [],
|
|
measures: [],
|
|
table: 'analytics.users',
|
|
},
|
|
],
|
|
tableExists: async () => true,
|
|
});
|
|
|
|
expect(invalid).toEqual([]);
|
|
});
|
|
|
|
it('validates source, dimension, segment, measure, and table references', async () => {
|
|
const invalid = await findInvalidWikiBodyRefs({
|
|
pageKey: 'account-segments',
|
|
body: [
|
|
'`mart_account_segments.total_contract_arr`',
|
|
'`mart_account_segments.segment`',
|
|
'`mart_account_segments.enterprise`',
|
|
'`source:mart_account_segments`',
|
|
'`table:analytics.mart_account_segments`',
|
|
].join('\n'),
|
|
visibleConnectionIds: ['warehouse'],
|
|
loadSources: async () => sources,
|
|
tableExists: async (_connectionId, tableRef) => tableRef === 'analytics.mart_account_segments',
|
|
});
|
|
|
|
expect(invalid).toEqual([]);
|
|
});
|
|
|
|
it('ignores two-part inline code when the source is not visible', async () => {
|
|
const invalid = await findInvalidWikiBodyRefs({
|
|
pageKey: 'engineering-notes',
|
|
body: [
|
|
'A version token like `node.v22` is not a semantic-layer reference.',
|
|
'A raw table must use `table:analytics.mart_account_segments`.',
|
|
].join('\n'),
|
|
visibleConnectionIds: ['warehouse'],
|
|
loadSources: async () => sources,
|
|
tableExists: async (_connectionId, tableRef) => tableRef === 'analytics.mart_account_segments',
|
|
});
|
|
|
|
expect(invalid).toEqual([]);
|
|
});
|
|
|
|
it('still rejects explicit missing source and table references', async () => {
|
|
const invalid = await findInvalidWikiBodyRefs({
|
|
pageKey: 'account-segments',
|
|
body: [
|
|
'`source:missing_source`',
|
|
'`warehouse/source:missing_source`',
|
|
'`table:analytics.missing_table`',
|
|
].join('\n'),
|
|
visibleConnectionIds: ['warehouse'],
|
|
loadSources: async () => sources,
|
|
tableExists: async () => false,
|
|
});
|
|
|
|
expect(invalid).toEqual([
|
|
'account-segments: unknown semantic-layer source missing_source',
|
|
'account-segments: unknown semantic-layer source warehouse/missing_source',
|
|
'account-segments: unknown raw table analytics.missing_table',
|
|
]);
|
|
});
|
|
});
|