mirror of
https://github.com/Kaelio/ktx.git
synced 2026-06-10 08:05:14 +02:00
* feat(cli): define full warehouse dialect contract
* test(cli): keep dialect edge tests focused
* fix(cli): stabilize dialect contract foundation
* refactor(connectors): own read-only query preparation
* refactor(connectors): resolve dialects through registry
* refactor(connectors): keep concrete dialect classes internal
* chore(workspace): enforce dialect import boundary
* refactor(cli): resolve relationship dialect at scan boundary
* refactor(cli): use dialect display parsing for entity details
* refactor(cli): use dialect display parsing for warehouse catalog
* refactor(cli): use dialect SQL in relationship workflows
* test(cli): verify solid dialect scan workflow closure
* test: split cli tests from source tree
* refactor(cli): standardize BigQuery scope listing
* feat(sqlite): implement connector scope listing
* test(connectors): cover required table listing
* feat(cli): add warehouse driver registry
* refactor(setup): route scope discovery through driver registry
* refactor(cli): route local query execution through driver registry
* refactor(historic-sql): route dialect support through driver registry
* refactor(cli): test warehouse connections through driver registry
* fix(cli): close driver registry type export gaps
* Improve setup daemon diagnostics
* refactor(setup): centralize rail-prefixed diagnostics + query-history fallback
Extract errorMessage, writePrefixedLines, and flushPrefixedBufferedCommandOutput
into clack.ts so the setup wizard, managed daemons, and embedding/agent steps
share one rail-formatted writer. setup-databases.ts also adds a
"disable query history and retry" option when the schema-context build fails
and query history is the likely culprit, surfaced via a new
failed-query-history-unavailable status.
* fix(cli): carry catalog through the picker so BigQuery/Snowflake/SQL Server scope filters match
The setup picker's KtxTableListEntry was a 2-level { schema, name }, so
qualifiedTableId always wrote db.name into enabled_tables. When BigQuery,
Snowflake, or SQL Server later ran fast ingest, their introspect step filtered
the scope set with scopedTableNames(scope, { catalog: projectId|database, db })
— catalog was non-null on the introspect side but null in the scope refs, so
every entry was rejected, the live-database adapter staged zero table files,
and detect() failed with 'Adapter "live-database" did not recognize fetched
source output'.
Align the picker boundary with the canonical 3-level KtxTableRef:
- Add catalog: string | null to KtxTableListEntry.
- BigQuery/Snowflake/SQL Server listTables populate catalog from the
resolved projectId / database; Postgres/MySQL/ClickHouse/SQLite set null.
- qualifiedTableId emits catalog.schema.name when catalog is non-null
(resolveEnabledTables already accepts the 3-part shape) and
schemasFromEnabledTables now goes through parseDottedTableEntry so it
recovers the schema correctly from both 2-part and 3-part entries.
- Export parseDottedTableEntry from enabled-tables.ts (@internal) for picker
reuse.
Update listTables expectations in all seven connector tests and the setup /
picker test fixtures. Add a picker regression test that covers the
catalog-bearing round-trip (save + refine).
* fix(cli): allow debug telemetry under opt-out env
78 lines
2.8 KiB
TypeScript
78 lines
2.8 KiB
TypeScript
import { describe, expect, it, vi } from 'vitest';
|
|
import type { SlConnectionCatalogPort } from '../../../../../src/context/sl/ports.js';
|
|
import type { ToolContext } from '../../../../../src/context/tools/base-tool.js';
|
|
import { SqlExecutionTool } from '../../../../../src/context/ingest/tools/warehouse-verification/sql-execution.tool.js';
|
|
|
|
describe('SqlExecutionTool', () => {
|
|
const connections = {
|
|
executeQuery: vi.fn(),
|
|
} as unknown as SlConnectionCatalogPort & { executeQuery: ReturnType<typeof vi.fn> };
|
|
const tool = new SqlExecutionTool(connections);
|
|
const context: ToolContext = {
|
|
sourceId: 'ingest',
|
|
messageId: 'm1',
|
|
userId: 'system',
|
|
session: { allowedConnectionNames: new Set(['warehouse']) } as any,
|
|
};
|
|
|
|
it('wraps read-only SQL with a capped row limit', async () => {
|
|
connections.executeQuery.mockResolvedValue({ headers: ['status'], rows: [['paid']], totalRows: 1 });
|
|
|
|
const result = await tool.call(
|
|
{ connectionId: 'warehouse', sql: 'select status from public.orders', rowLimit: 5 },
|
|
context,
|
|
);
|
|
|
|
expect(connections.executeQuery).toHaveBeenCalledWith(
|
|
'warehouse',
|
|
'select * from (select status from public.orders) as ktx_query_result limit 5',
|
|
);
|
|
expect(result.markdown).toContain('| status |');
|
|
expect(result.structured.wrappedSql).toContain('limit 5');
|
|
});
|
|
|
|
it.each(['insert into x values (1)', 'drop table x', 'vacuum'])('rejects mutating SQL: %s', async (sql) => {
|
|
connections.executeQuery.mockClear();
|
|
|
|
const result = await tool.call({ connectionId: 'warehouse', sql }, context);
|
|
|
|
expect(result.markdown).toContain('Only read-only SELECT/WITH queries can be executed locally.');
|
|
expect(connections.executeQuery).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it('surfaces connector errors verbatim', async () => {
|
|
connections.executeQuery.mockRejectedValue(new Error('relation "orbit_analytics.customer" does not exist'));
|
|
|
|
const result = await tool.call(
|
|
{ connectionId: 'warehouse', sql: 'select 1 from orbit_analytics.customer', rowLimit: 1 },
|
|
context,
|
|
);
|
|
|
|
expect(result.markdown).toContain('relation "orbit_analytics.customer" does not exist');
|
|
expect(result.structured.error).toContain('relation "orbit_analytics.customer" does not exist');
|
|
});
|
|
|
|
it('uses connectionId as the public input field', () => {
|
|
const legacyConnectionField = ['connection', 'Name'].join('');
|
|
|
|
expect(
|
|
tool.parseInput({
|
|
connectionId: 'warehouse',
|
|
sql: 'select 1',
|
|
rowLimit: 5,
|
|
}),
|
|
).toEqual({
|
|
connectionId: 'warehouse',
|
|
sql: 'select 1',
|
|
rowLimit: 5,
|
|
});
|
|
|
|
expect(() =>
|
|
tool.parseInput({
|
|
[legacyConnectionField]: 'warehouse',
|
|
sql: 'select 1',
|
|
rowLimit: 5,
|
|
}),
|
|
).toThrow();
|
|
});
|
|
});
|