mirror of
https://github.com/Kaelio/ktx.git
synced 2026-06-07 07:55:13 +02:00
* feat(cli): define full warehouse dialect contract
* test(cli): keep dialect edge tests focused
* fix(cli): stabilize dialect contract foundation
* refactor(connectors): own read-only query preparation
* refactor(connectors): resolve dialects through registry
* refactor(connectors): keep concrete dialect classes internal
* chore(workspace): enforce dialect import boundary
* refactor(cli): resolve relationship dialect at scan boundary
* refactor(cli): use dialect display parsing for entity details
* refactor(cli): use dialect display parsing for warehouse catalog
* refactor(cli): use dialect SQL in relationship workflows
* test(cli): verify solid dialect scan workflow closure
* test: split cli tests from source tree
* refactor(cli): standardize BigQuery scope listing
* feat(sqlite): implement connector scope listing
* test(connectors): cover required table listing
* feat(cli): add warehouse driver registry
* refactor(setup): route scope discovery through driver registry
* refactor(cli): route local query execution through driver registry
* refactor(historic-sql): route dialect support through driver registry
* refactor(cli): test warehouse connections through driver registry
* fix(cli): close driver registry type export gaps
* Improve setup daemon diagnostics
* refactor(setup): centralize rail-prefixed diagnostics + query-history fallback
Extract errorMessage, writePrefixedLines, and flushPrefixedBufferedCommandOutput
into clack.ts so the setup wizard, managed daemons, and embedding/agent steps
share one rail-formatted writer. setup-databases.ts also adds a
"disable query history and retry" option when the schema-context build fails
and query history is the likely culprit, surfaced via a new
failed-query-history-unavailable status.
* fix(cli): carry catalog through the picker so BigQuery/Snowflake/SQL Server scope filters match
The setup picker's KtxTableListEntry was a 2-level { schema, name }, so
qualifiedTableId always wrote db.name into enabled_tables. When BigQuery,
Snowflake, or SQL Server later ran fast ingest, their introspect step filtered
the scope set with scopedTableNames(scope, { catalog: projectId|database, db })
— catalog was non-null on the introspect side but null in the scope refs, so
every entry was rejected, the live-database adapter staged zero table files,
and detect() failed with 'Adapter "live-database" did not recognize fetched
source output'.
Align the picker boundary with the canonical 3-level KtxTableRef:
- Add catalog: string | null to KtxTableListEntry.
- BigQuery/Snowflake/SQL Server listTables populate catalog from the
resolved projectId / database; Postgres/MySQL/ClickHouse/SQLite set null.
- qualifiedTableId emits catalog.schema.name when catalog is non-null
(resolveEnabledTables already accepts the 3-part shape) and
schemasFromEnabledTables now goes through parseDottedTableEntry so it
recovers the schema correctly from both 2-part and 3-part entries.
- Export parseDottedTableEntry from enabled-tables.ts (@internal) for picker
reuse.
Update listTables expectations in all seven connector tests and the setup /
picker test fixtures. Add a picker regression test that covers the
catalog-bearing round-trip (save + refine).
* fix(cli): allow debug telemetry under opt-out env
72 lines
2.9 KiB
TypeScript
72 lines
2.9 KiB
TypeScript
import { mkdtemp, rm } from 'node:fs/promises';
|
|
import { tmpdir } from 'node:os';
|
|
import { join } from 'node:path';
|
|
import { afterEach, describe, expect, it } from 'vitest';
|
|
import { ktxLocalStateDbPath } from '../../../src/context/project/local-state-db.js';
|
|
import type { KtxLocalProject } from '../../../src/context/project/project.js';
|
|
import { LocalLookerRuntimeStore } from '../../../src/context/ingest/adapters/looker/local-runtime-store.js';
|
|
import { seedLocalMappingStateFromKtxYaml } from '../../../src/context/ingest/local-mapping-reconcile.js';
|
|
|
|
describe('local mapping yaml reconciliation bridge', () => {
|
|
let tempDir: string;
|
|
|
|
afterEach(async () => {
|
|
if (tempDir) {
|
|
await rm(tempDir, { recursive: true, force: true });
|
|
}
|
|
});
|
|
|
|
function projectWithConnections(connections: KtxLocalProject['config']['connections']): KtxLocalProject {
|
|
return {
|
|
projectDir: tempDir,
|
|
config: { connections },
|
|
} as KtxLocalProject;
|
|
}
|
|
|
|
it('does not copy Metabase mapping intent into local SQLite state', async () => {
|
|
tempDir = await mkdtemp(join(tmpdir(), 'ktx-metabase-yaml-seed-'));
|
|
const project = projectWithConnections({
|
|
'prod-metabase': {
|
|
driver: 'metabase',
|
|
api_url: 'https://metabase.example.com',
|
|
mappings: {
|
|
databaseMappings: { '1': 'prod-warehouse' },
|
|
syncEnabled: { '1': true },
|
|
syncMode: 'ONLY',
|
|
selections: { collections: [12], items: [] },
|
|
defaultTagNames: ['ktx'],
|
|
},
|
|
},
|
|
'prod-warehouse': { driver: 'postgres', url: 'postgresql://readonly@db.test/analytics' },
|
|
});
|
|
|
|
await expect(seedLocalMappingStateFromKtxYaml(project, 'prod-metabase')).resolves.toBeUndefined();
|
|
});
|
|
|
|
it('seeds Looker local mappings from ktx.yaml mapping intent', async () => {
|
|
tempDir = await mkdtemp(join(tmpdir(), 'ktx-looker-yaml-seed-'));
|
|
const project = projectWithConnections({
|
|
'prod-looker': {
|
|
driver: 'looker',
|
|
base_url: 'https://looker.example.com',
|
|
client_id: 'client',
|
|
mappings: { connectionMappings: { analytics: 'prod-warehouse' } },
|
|
},
|
|
'prod-warehouse': { driver: 'postgres', url: 'postgresql://readonly@db.test/analytics' },
|
|
});
|
|
|
|
await seedLocalMappingStateFromKtxYaml(project, 'prod-looker');
|
|
|
|
const store = new LocalLookerRuntimeStore({ dbPath: ktxLocalStateDbPath(project) });
|
|
await expect(store.listConnectionMappings('prod-looker')).resolves.toMatchObject([
|
|
{ lookerConnectionName: 'analytics', ktxConnectionId: 'prod-warehouse', source: 'ktx.yaml' },
|
|
]);
|
|
});
|
|
|
|
it('does nothing for connections without mapping bootstrap intent', async () => {
|
|
tempDir = await mkdtemp(join(tmpdir(), 'ktx-no-yaml-seed-'));
|
|
const project = projectWithConnections({ warehouse: { driver: 'postgres', url: 'env:DATABASE_URL' } });
|
|
|
|
await expect(seedLocalMappingStateFromKtxYaml(project, 'warehouse')).resolves.toBeUndefined();
|
|
});
|
|
});
|