mirror of
https://github.com/Kaelio/ktx.git
synced 2026-06-13 08:15:14 +02:00
56985b7e09
* feat(cli): define full warehouse dialect contract
* test(cli): keep dialect edge tests focused
* fix(cli): stabilize dialect contract foundation
* refactor(connectors): own read-only query preparation
* refactor(connectors): resolve dialects through registry
* refactor(connectors): keep concrete dialect classes internal
* chore(workspace): enforce dialect import boundary
* refactor(cli): resolve relationship dialect at scan boundary
* refactor(cli): use dialect display parsing for entity details
* refactor(cli): use dialect display parsing for warehouse catalog
* refactor(cli): use dialect SQL in relationship workflows
* test(cli): verify solid dialect scan workflow closure
* test: split cli tests from source tree
* refactor(cli): standardize BigQuery scope listing
* feat(sqlite): implement connector scope listing
* test(connectors): cover required table listing
* feat(cli): add warehouse driver registry
* refactor(setup): route scope discovery through driver registry
* refactor(cli): route local query execution through driver registry
* refactor(historic-sql): route dialect support through driver registry
* refactor(cli): test warehouse connections through driver registry
* fix(cli): close driver registry type export gaps
* Improve setup daemon diagnostics
* refactor(setup): centralize rail-prefixed diagnostics + query-history fallback
Extract errorMessage, writePrefixedLines, and flushPrefixedBufferedCommandOutput
into clack.ts so the setup wizard, managed daemons, and embedding/agent steps
share one rail-formatted writer. setup-databases.ts also adds a
"disable query history and retry" option when the schema-context build fails
and query history is the likely culprit, surfaced via a new
failed-query-history-unavailable status.
* fix(cli): carry catalog through the picker so BigQuery/Snowflake/SQL Server scope filters match
The setup picker's KtxTableListEntry was a 2-level { schema, name }, so
qualifiedTableId always wrote db.name into enabled_tables. When BigQuery,
Snowflake, or SQL Server later ran fast ingest, their introspect step filtered
the scope set with scopedTableNames(scope, { catalog: projectId|database, db })
— catalog was non-null on the introspect side but null in the scope refs, so
every entry was rejected, the live-database adapter staged zero table files,
and detect() failed with 'Adapter "live-database" did not recognize fetched
source output'.
Align the picker boundary with the canonical 3-level KtxTableRef:
- Add catalog: string | null to KtxTableListEntry.
- BigQuery/Snowflake/SQL Server listTables populate catalog from the
resolved projectId / database; Postgres/MySQL/ClickHouse/SQLite set null.
- qualifiedTableId emits catalog.schema.name when catalog is non-null
(resolveEnabledTables already accepts the 3-part shape) and
schemasFromEnabledTables now goes through parseDottedTableEntry so it
recovers the schema correctly from both 2-part and 3-part entries.
- Export parseDottedTableEntry from enabled-tables.ts (@internal) for picker
reuse.
Update listTables expectations in all seven connector tests and the setup /
picker test fixtures. Add a picker regression test that covers the
catalog-bearing round-trip (save + refine).
* fix(cli): allow debug telemetry under opt-out env
82 lines
2.7 KiB
TypeScript
82 lines
2.7 KiB
TypeScript
import { describe, expect, it, vi } from 'vitest';
|
|
import { HistoricSqlGrantsMissingError } from '../../../../src/context/ingest/adapters/historic-sql/errors.js';
|
|
import { SnowflakeAccountUsageProbeRunner } from '../../../../src/context/ingest/historic-sql-probes/snowflake-runner.js';
|
|
|
|
describe('SnowflakeAccountUsageProbeRunner', () => {
|
|
it('runs the account usage reader and cleans up the client', async () => {
|
|
const cleanup = vi.fn(async () => undefined);
|
|
const reader = {
|
|
probe: vi.fn(async () => ({ warnings: [], info: ['query history available'] })),
|
|
};
|
|
const runner = new SnowflakeAccountUsageProbeRunner({
|
|
reader,
|
|
createClient: () => ({ client: { executeQuery: vi.fn() }, cleanup }),
|
|
});
|
|
|
|
await expect(
|
|
runner.run({
|
|
projectDir: '/work/project',
|
|
connectionId: 'warehouse',
|
|
connection: {
|
|
driver: 'snowflake',
|
|
account: 'ACCT',
|
|
warehouse: 'WH',
|
|
database: 'ANALYTICS',
|
|
username: 'reader',
|
|
},
|
|
env: {},
|
|
}),
|
|
).resolves.toEqual({ warnings: [], info: ['query history available'] });
|
|
expect(reader.probe).toHaveBeenCalledOnce();
|
|
expect(cleanup).toHaveBeenCalledOnce();
|
|
});
|
|
|
|
it('rejects non-Snowflake connections', async () => {
|
|
const runner = new SnowflakeAccountUsageProbeRunner({
|
|
reader: { probe: vi.fn() },
|
|
createClient: () => ({ client: {}, cleanup: vi.fn() }),
|
|
});
|
|
|
|
await expect(
|
|
runner.run({
|
|
projectDir: '/work/project',
|
|
connectionId: 'warehouse',
|
|
connection: { driver: 'postgres' },
|
|
env: {},
|
|
}),
|
|
).rejects.toThrow('Native Snowflake connector cannot run driver "postgres"');
|
|
});
|
|
|
|
it('formats successful Snowflake details', () => {
|
|
const runner = new SnowflakeAccountUsageProbeRunner();
|
|
|
|
expect(
|
|
runner.formatSuccessDetail({
|
|
warnings: ['query history is delayed'],
|
|
info: ['warehouse: WH'],
|
|
}),
|
|
).toEqual({
|
|
detail: 'SNOWFLAKE.ACCOUNT_USAGE.QUERY_HISTORY ready; warehouse: WH',
|
|
warnings: ['query history is delayed'],
|
|
});
|
|
});
|
|
|
|
it('maps Snowflake grant errors to runner advice', () => {
|
|
const runner = new SnowflakeAccountUsageProbeRunner();
|
|
|
|
expect(
|
|
runner.fixAdvice(
|
|
new HistoricSqlGrantsMissingError({
|
|
dialect: 'snowflake',
|
|
message: 'role cannot read account usage',
|
|
remediation:
|
|
'GRANT IMPORTED PRIVILEGES ON DATABASE SNOWFLAKE TO ROLE <connection role>;',
|
|
}),
|
|
),
|
|
).toEqual({
|
|
failHeadline: 'Snowflake role cannot read SNOWFLAKE.ACCOUNT_USAGE.QUERY_HISTORY',
|
|
remediation:
|
|
'GRANT IMPORTED PRIVILEGES ON DATABASE SNOWFLAKE TO ROLE <connection role>;',
|
|
});
|
|
});
|
|
});
|