mirror of
https://github.com/Kaelio/ktx.git
synced 2026-06-10 08:05:14 +02:00
56985b7e09
* feat(cli): define full warehouse dialect contract
* test(cli): keep dialect edge tests focused
* fix(cli): stabilize dialect contract foundation
* refactor(connectors): own read-only query preparation
* refactor(connectors): resolve dialects through registry
* refactor(connectors): keep concrete dialect classes internal
* chore(workspace): enforce dialect import boundary
* refactor(cli): resolve relationship dialect at scan boundary
* refactor(cli): use dialect display parsing for entity details
* refactor(cli): use dialect display parsing for warehouse catalog
* refactor(cli): use dialect SQL in relationship workflows
* test(cli): verify solid dialect scan workflow closure
* test: split cli tests from source tree
* refactor(cli): standardize BigQuery scope listing
* feat(sqlite): implement connector scope listing
* test(connectors): cover required table listing
* feat(cli): add warehouse driver registry
* refactor(setup): route scope discovery through driver registry
* refactor(cli): route local query execution through driver registry
* refactor(historic-sql): route dialect support through driver registry
* refactor(cli): test warehouse connections through driver registry
* fix(cli): close driver registry type export gaps
* Improve setup daemon diagnostics
* refactor(setup): centralize rail-prefixed diagnostics + query-history fallback
Extract errorMessage, writePrefixedLines, and flushPrefixedBufferedCommandOutput
into clack.ts so the setup wizard, managed daemons, and embedding/agent steps
share one rail-formatted writer. setup-databases.ts also adds a
"disable query history and retry" option when the schema-context build fails
and query history is the likely culprit, surfaced via a new
failed-query-history-unavailable status.
* fix(cli): carry catalog through the picker so BigQuery/Snowflake/SQL Server scope filters match
The setup picker's KtxTableListEntry was a 2-level { schema, name }, so
qualifiedTableId always wrote db.name into enabled_tables. When BigQuery,
Snowflake, or SQL Server later ran fast ingest, their introspect step filtered
the scope set with scopedTableNames(scope, { catalog: projectId|database, db })
— catalog was non-null on the introspect side but null in the scope refs, so
every entry was rejected, the live-database adapter staged zero table files,
and detect() failed with 'Adapter "live-database" did not recognize fetched
source output'.
Align the picker boundary with the canonical 3-level KtxTableRef:
- Add catalog: string | null to KtxTableListEntry.
- BigQuery/Snowflake/SQL Server listTables populate catalog from the
resolved projectId / database; Postgres/MySQL/ClickHouse/SQLite set null.
- qualifiedTableId emits catalog.schema.name when catalog is non-null
(resolveEnabledTables already accepts the 3-part shape) and
schemasFromEnabledTables now goes through parseDottedTableEntry so it
recovers the schema correctly from both 2-part and 3-part entries.
- Export parseDottedTableEntry from enabled-tables.ts (@internal) for picker
reuse.
Update listTables expectations in all seven connector tests and the setup /
picker test fixtures. Add a picker regression test that covers the
catalog-bearing round-trip (save + refine).
* fix(cli): allow debug telemetry under opt-out env
76 lines
2.8 KiB
TypeScript
76 lines
2.8 KiB
TypeScript
import { describe, expect, it, vi } from 'vitest';
|
|
import type { ContextCandidateForDedup } from '../../../../src/context/ingest/ports.js';
|
|
import type { ContextCandidateStorePort } from '../../../../src/context/ingest/context-candidates/store.js';
|
|
import type { InsertContextCandidateInput } from '../../../../src/context/ingest/context-candidates/types.js';
|
|
|
|
const candidate: ContextCandidateForDedup = {
|
|
id: 'candidate-1',
|
|
candidateKey: 'revenue-policy',
|
|
topic: 'Revenue policy',
|
|
assertion: 'Booked revenue excludes refunds.',
|
|
promotionScore: 10,
|
|
createdAt: new Date('2026-04-30T10:00:00.000Z'),
|
|
evidenceChunkIds: ['chunk-1'],
|
|
evidenceRefs: [{ stableCitationKey: 'notion:page-1:revenue' }],
|
|
embedding: '[1,0,0]',
|
|
lane: 'full',
|
|
};
|
|
|
|
const insert: InsertContextCandidateInput = {
|
|
runId: 'run-1',
|
|
connectionId: 'connection-1',
|
|
sourceKey: 'notion',
|
|
candidateKey: 'revenue-policy',
|
|
topic: 'Revenue policy',
|
|
assertion: 'Booked revenue excludes refunds.',
|
|
rationale: 'Finance handbook says this.',
|
|
evidenceChunkIds: ['chunk-1'],
|
|
evidenceRefs: [{ stableCitationKey: 'notion:page-1:revenue' }],
|
|
suggestedPageKey: 'revenue-policy',
|
|
actionHint: 'create',
|
|
durabilityScore: 3,
|
|
authorityScore: 3,
|
|
reuseScore: 3,
|
|
noveltyScore: 2,
|
|
riskScore: 1,
|
|
promotionScore: 10,
|
|
status: 'pending',
|
|
rejectionReason: null,
|
|
lane: 'full',
|
|
embedding: null,
|
|
};
|
|
|
|
describe('ContextCandidateStorePort', () => {
|
|
it('describes the persistence operations required by candidate services', async () => {
|
|
const store: ContextCandidateStorePort = {
|
|
listPendingCandidatesForDedup: vi.fn().mockResolvedValue([candidate]),
|
|
updateCandidateEmbedding: vi.fn().mockResolvedValue(undefined),
|
|
markCandidatesAsMergedToCluster: vi.fn().mockResolvedValue(undefined),
|
|
listBudgetExhaustedCandidatesForCarryForward: vi.fn().mockResolvedValue([]),
|
|
listCurrentRunEvidenceChunksForCarryForward: vi.fn().mockResolvedValue([]),
|
|
insertCandidate: vi.fn().mockResolvedValue({ id: 'candidate-2' }),
|
|
listCandidatesForPromptByKeys: vi.fn().mockResolvedValue([]),
|
|
markPendingCandidatesByReason: vi.fn().mockResolvedValue(0),
|
|
summarizeCandidateVerdicts: vi.fn().mockResolvedValue({
|
|
pending: 0,
|
|
promoted: 0,
|
|
merged: 0,
|
|
rejected: 0,
|
|
conflict: 0,
|
|
rejectedByReason: {},
|
|
}),
|
|
};
|
|
|
|
await expect(store.listPendingCandidatesForDedup('run-1')).resolves.toEqual([candidate]);
|
|
await expect(store.insertCandidate(insert)).resolves.toEqual({ id: 'candidate-2' });
|
|
await expect(
|
|
store.markCandidatesAsMergedToCluster({
|
|
representativeId: 'candidate-1',
|
|
memberIds: ['candidate-3'],
|
|
evidenceChunkIds: ['chunk-1', 'chunk-3'],
|
|
evidenceRefs: [{ stableCitationKey: 'notion:page-1:revenue' }],
|
|
promotionScore: 10,
|
|
}),
|
|
).resolves.toBeUndefined();
|
|
});
|
|
});
|