mirror of
https://github.com/Kaelio/ktx.git
synced 2026-06-13 08:15:14 +02:00
56985b7e09
* feat(cli): define full warehouse dialect contract
* test(cli): keep dialect edge tests focused
* fix(cli): stabilize dialect contract foundation
* refactor(connectors): own read-only query preparation
* refactor(connectors): resolve dialects through registry
* refactor(connectors): keep concrete dialect classes internal
* chore(workspace): enforce dialect import boundary
* refactor(cli): resolve relationship dialect at scan boundary
* refactor(cli): use dialect display parsing for entity details
* refactor(cli): use dialect display parsing for warehouse catalog
* refactor(cli): use dialect SQL in relationship workflows
* test(cli): verify solid dialect scan workflow closure
* test: split cli tests from source tree
* refactor(cli): standardize BigQuery scope listing
* feat(sqlite): implement connector scope listing
* test(connectors): cover required table listing
* feat(cli): add warehouse driver registry
* refactor(setup): route scope discovery through driver registry
* refactor(cli): route local query execution through driver registry
* refactor(historic-sql): route dialect support through driver registry
* refactor(cli): test warehouse connections through driver registry
* fix(cli): close driver registry type export gaps
* Improve setup daemon diagnostics
* refactor(setup): centralize rail-prefixed diagnostics + query-history fallback
Extract errorMessage, writePrefixedLines, and flushPrefixedBufferedCommandOutput
into clack.ts so the setup wizard, managed daemons, and embedding/agent steps
share one rail-formatted writer. setup-databases.ts also adds a
"disable query history and retry" option when the schema-context build fails
and query history is the likely culprit, surfaced via a new
failed-query-history-unavailable status.
* fix(cli): carry catalog through the picker so BigQuery/Snowflake/SQL Server scope filters match
The setup picker's KtxTableListEntry was a 2-level { schema, name }, so
qualifiedTableId always wrote db.name into enabled_tables. When BigQuery,
Snowflake, or SQL Server later ran fast ingest, their introspect step filtered
the scope set with scopedTableNames(scope, { catalog: projectId|database, db })
— catalog was non-null on the introspect side but null in the scope refs, so
every entry was rejected, the live-database adapter staged zero table files,
and detect() failed with 'Adapter "live-database" did not recognize fetched
source output'.
Align the picker boundary with the canonical 3-level KtxTableRef:
- Add catalog: string | null to KtxTableListEntry.
- BigQuery/Snowflake/SQL Server listTables populate catalog from the
resolved projectId / database; Postgres/MySQL/ClickHouse/SQLite set null.
- qualifiedTableId emits catalog.schema.name when catalog is non-null
(resolveEnabledTables already accepts the 3-part shape) and
schemasFromEnabledTables now goes through parseDottedTableEntry so it
recovers the schema correctly from both 2-part and 3-part entries.
- Export parseDottedTableEntry from enabled-tables.ts (@internal) for picker
reuse.
Update listTables expectations in all seven connector tests and the setup /
picker test fixtures. Add a picker regression test that covers the
catalog-bearing round-trip (save + refine).
* fix(cli): allow debug telemetry under opt-out env
76 lines
2.4 KiB
TypeScript
76 lines
2.4 KiB
TypeScript
import { describe, expect, it } from 'vitest';
|
|
import { buildCanonicalPinsPromptBlock, type CanonicalPin, selectRelevantCanonicalPins } from '../../../src/context/ingest/canonical-pins.js';
|
|
import type { StageIndex } from '../../../src/context/ingest/stages/stage-index.types.js';
|
|
|
|
function makeStageIndex(): StageIndex {
|
|
return {
|
|
jobId: 'job-1',
|
|
connectionId: 'c1',
|
|
workUnits: [
|
|
{
|
|
unitKey: 'wu-billing',
|
|
rawFiles: ['metrics/billing.yml'],
|
|
status: 'success',
|
|
actions: [
|
|
{
|
|
target: 'sl',
|
|
type: 'created',
|
|
key: 'billing.churn_risk_score',
|
|
detail: 'captured churn risk from billing',
|
|
},
|
|
],
|
|
touchedSlSources: [{ connectionId: 'c1', sourceName: 'billing' }],
|
|
},
|
|
],
|
|
conflictsResolved: [],
|
|
evictionsApplied: [],
|
|
unmappedFallbacks: [],
|
|
};
|
|
}
|
|
|
|
const pins: CanonicalPin[] = [
|
|
{
|
|
contestedKey: 'churn_risk_score',
|
|
canonicalArtifactKey: 'billing.churn_risk_score',
|
|
pinnedAt: '2026-04-27T12:00:00.000Z',
|
|
pinnedBy: 'user-1',
|
|
reason: 'billing owns the contractual definition',
|
|
},
|
|
{
|
|
contestedKey: 'gross_margin',
|
|
canonicalArtifactKey: 'finance.gross_margin',
|
|
pinnedAt: '2026-04-27T12:01:00.000Z',
|
|
pinnedBy: 'user-2',
|
|
reason: null,
|
|
},
|
|
];
|
|
|
|
describe('canonical pins', () => {
|
|
it('selects only pins relevant to the current Stage Index', () => {
|
|
expect(selectRelevantCanonicalPins(makeStageIndex(), pins)).toEqual([pins[0]]);
|
|
});
|
|
|
|
it('keeps pins whose canonical artifact is mentioned even when contestedKey is absent', () => {
|
|
const stageIndex = makeStageIndex();
|
|
stageIndex.workUnits[0].actions[0].key = 'finance.gross_margin';
|
|
stageIndex.workUnits[0].actions[0].detail = 'refreshed margin';
|
|
|
|
expect(selectRelevantCanonicalPins(stageIndex, pins)).toEqual([pins[1]]);
|
|
});
|
|
|
|
it('formats a compact canonical_pins block for the reconciliation prompt', () => {
|
|
expect(buildCanonicalPinsPromptBlock([pins[0]])).toBe(
|
|
[
|
|
'<canonical_pins>',
|
|
'- contestedKey: churn_risk_score',
|
|
' canonicalArtifactKey: billing.churn_risk_score',
|
|
' reason: billing owns the contractual definition',
|
|
'</canonical_pins>',
|
|
].join('\n'),
|
|
);
|
|
});
|
|
|
|
it('omits the block when no relevant pins exist', () => {
|
|
expect(buildCanonicalPinsPromptBlock([])).toBe('');
|
|
});
|
|
});
|