mirror of
https://github.com/Kaelio/ktx.git
synced 2026-06-16 08:25:14 +02:00
* feat(cli): define full warehouse dialect contract
* test(cli): keep dialect edge tests focused
* fix(cli): stabilize dialect contract foundation
* refactor(connectors): own read-only query preparation
* refactor(connectors): resolve dialects through registry
* refactor(connectors): keep concrete dialect classes internal
* chore(workspace): enforce dialect import boundary
* refactor(cli): resolve relationship dialect at scan boundary
* refactor(cli): use dialect display parsing for entity details
* refactor(cli): use dialect display parsing for warehouse catalog
* refactor(cli): use dialect SQL in relationship workflows
* test(cli): verify solid dialect scan workflow closure
* test: split cli tests from source tree
* refactor(cli): standardize BigQuery scope listing
* feat(sqlite): implement connector scope listing
* test(connectors): cover required table listing
* feat(cli): add warehouse driver registry
* refactor(setup): route scope discovery through driver registry
* refactor(cli): route local query execution through driver registry
* refactor(historic-sql): route dialect support through driver registry
* refactor(cli): test warehouse connections through driver registry
* fix(cli): close driver registry type export gaps
* Improve setup daemon diagnostics
* refactor(setup): centralize rail-prefixed diagnostics + query-history fallback
Extract errorMessage, writePrefixedLines, and flushPrefixedBufferedCommandOutput
into clack.ts so the setup wizard, managed daemons, and embedding/agent steps
share one rail-formatted writer. setup-databases.ts also adds a
"disable query history and retry" option when the schema-context build fails
and query history is the likely culprit, surfaced via a new
failed-query-history-unavailable status.
* fix(cli): carry catalog through the picker so BigQuery/Snowflake/SQL Server scope filters match
The setup picker's KtxTableListEntry was a 2-level { schema, name }, so
qualifiedTableId always wrote db.name into enabled_tables. When BigQuery,
Snowflake, or SQL Server later ran fast ingest, their introspect step filtered
the scope set with scopedTableNames(scope, { catalog: projectId|database, db })
— catalog was non-null on the introspect side but null in the scope refs, so
every entry was rejected, the live-database adapter staged zero table files,
and detect() failed with 'Adapter "live-database" did not recognize fetched
source output'.
Align the picker boundary with the canonical 3-level KtxTableRef:
- Add catalog: string | null to KtxTableListEntry.
- BigQuery/Snowflake/SQL Server listTables populate catalog from the
resolved projectId / database; Postgres/MySQL/ClickHouse/SQLite set null.
- qualifiedTableId emits catalog.schema.name when catalog is non-null
(resolveEnabledTables already accepts the 3-part shape) and
schemasFromEnabledTables now goes through parseDottedTableEntry so it
recovers the schema correctly from both 2-part and 3-part entries.
- Export parseDottedTableEntry from enabled-tables.ts (@internal) for picker
reuse.
Update listTables expectations in all seven connector tests and the setup /
picker test fixtures. Add a picker regression test that covers the
catalog-bearing round-trip (save + refine).
* fix(cli): allow debug telemetry under opt-out env
266 lines
8.9 KiB
TypeScript
266 lines
8.9 KiB
TypeScript
import { mkdir, mkdtemp, readFile, rm, writeFile } from 'node:fs/promises';
|
|
import { tmpdir } from 'node:os';
|
|
import { join } from 'node:path';
|
|
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
|
|
import { makeLocalGitRepo } from '../../../test/make-local-git-repo.js';
|
|
import type { SourceAdapter } from '../../../../../src/context/ingest/types.js';
|
|
import type { MetricFlowParseResult } from '../../../../../src/context/ingest/adapters/metricflow/deep-parse.js';
|
|
import { MetricflowSourceAdapter } from '../../../../../src/context/ingest/adapters/metricflow/metricflow.adapter.js';
|
|
import { readMetricflowProjectionConfig, writeMetricflowProjectionConfig } from '../../../../../src/context/ingest/adapters/metricflow/projection-config.js';
|
|
|
|
function compileOnlyRequiredDepsCheck(): void {
|
|
// @ts-expect-error MetricflowSourceAdapter requires an explicit cache home.
|
|
new MetricflowSourceAdapter();
|
|
}
|
|
void compileOnlyRequiredDepsCheck;
|
|
|
|
async function makeRepo(tmpRoot: string, files: Record<string, string>) {
|
|
const fixtureDir = join(tmpRoot, 'fixture-src');
|
|
for (const [path, content] of Object.entries(files)) {
|
|
const dest = join(fixtureDir, path);
|
|
await mkdir(join(dest, '..'), { recursive: true });
|
|
await writeFile(dest, content, 'utf-8');
|
|
}
|
|
return makeLocalGitRepo(fixtureDir, join(tmpRoot, 'origin'));
|
|
}
|
|
|
|
function metricflowParseResult(): MetricFlowParseResult {
|
|
return {
|
|
semanticModels: [
|
|
{
|
|
name: 'orders',
|
|
description: 'Orders',
|
|
modelRef: 'orders',
|
|
dimensions: [{ name: 'status', column: 'status', type: 'string', label: 'Status' }],
|
|
measures: [{ type: 'simple', name: 'order_count', column: 'id', aggregation: 'count' }],
|
|
entities: [{ name: 'customer', type: 'foreign', expr: 'customer_id' }],
|
|
defaultTimeDimension: null,
|
|
},
|
|
],
|
|
crossModelMetrics: [],
|
|
relationships: [],
|
|
warnings: ['parser warning'],
|
|
};
|
|
}
|
|
|
|
describe('MetricflowSourceAdapter', () => {
|
|
let tmpRoot: string;
|
|
let stagedDir: string;
|
|
let adapter: SourceAdapter;
|
|
|
|
beforeEach(async () => {
|
|
tmpRoot = await mkdtemp(join(tmpdir(), 'mf-adapter-'));
|
|
stagedDir = join(tmpRoot, 'stage');
|
|
adapter = new MetricflowSourceAdapter({ homeDir: join(tmpRoot, 'cache-home') });
|
|
});
|
|
|
|
afterEach(async () => {
|
|
await rm(tmpRoot, { recursive: true, force: true });
|
|
});
|
|
|
|
it('declares the expected source key and skill list', () => {
|
|
expect(adapter.source).toBe('metricflow');
|
|
expect(adapter.skillNames).toEqual(['metricflow_ingest']);
|
|
});
|
|
|
|
it('returns configured target warehouse connection ids', async () => {
|
|
const metricflow = new MetricflowSourceAdapter({
|
|
homeDir: join(tmpRoot, 'cache-home'),
|
|
targetConnectionIds: ['warehouse', 'analytics', 'warehouse'],
|
|
});
|
|
|
|
await expect(metricflow.listTargetConnectionIds?.(stagedDir)).resolves.toEqual(['analytics', 'warehouse']);
|
|
});
|
|
|
|
it('detects a staged dir with a semantic_models YAML', async () => {
|
|
await mkdir(join(stagedDir, 'models'), { recursive: true });
|
|
await writeFile(
|
|
join(stagedDir, 'models/orders.yml'),
|
|
'semantic_models:\n - {name: orders, model: x, measures: [{name: c, agg: count, expr: id}]}\n',
|
|
'utf-8',
|
|
);
|
|
expect(await adapter.detect(stagedDir)).toBe(true);
|
|
});
|
|
|
|
it('rejects a staged dir with no MetricFlow-shaped YAML', async () => {
|
|
await mkdir(stagedDir, { recursive: true });
|
|
await writeFile(join(stagedDir, 'dbt_project.yml'), 'name: proj\n', 'utf-8');
|
|
expect(await adapter.detect(stagedDir)).toBe(false);
|
|
});
|
|
|
|
it('chunk: first-run on a minimal single-model dir emits one WU', async () => {
|
|
await mkdir(join(stagedDir, 'models'), { recursive: true });
|
|
await writeFile(
|
|
join(stagedDir, 'models/orders.yml'),
|
|
'semantic_models:\n - {name: orders, model: x, measures: [{name: c, agg: count, expr: id}]}\n',
|
|
'utf-8',
|
|
);
|
|
const result = await adapter.chunk(stagedDir);
|
|
expect(result.workUnits).toHaveLength(1);
|
|
expect(result.workUnits[0].unitKey).toBe('metricflow-orders');
|
|
});
|
|
|
|
it('attaches deep parse artifacts to the chunk result', async () => {
|
|
await mkdir(stagedDir, { recursive: true });
|
|
await writeFile(
|
|
join(stagedDir, 'semantic_models.yml'),
|
|
[
|
|
'semantic_models:',
|
|
' - name: orders',
|
|
" model: ref('orders')",
|
|
' dimensions: []',
|
|
' measures:',
|
|
' - name: order_count',
|
|
' agg: count',
|
|
" expr: '1'",
|
|
].join('\n'),
|
|
);
|
|
|
|
const chunk = await adapter.chunk(stagedDir);
|
|
|
|
expect(chunk.parseArtifacts).toMatchObject({
|
|
semanticModels: [{ name: 'orders', modelRef: 'orders' }],
|
|
crossModelMetrics: [],
|
|
relationships: [],
|
|
warnings: [],
|
|
});
|
|
});
|
|
|
|
it('fetches repo YAML files into the staged directory using a per-connection cache', async () => {
|
|
const repo = await makeRepo(tmpRoot, {
|
|
'dbt_project.yml': 'name: analytics\n',
|
|
'models/orders.yml': 'semantic_models:\n - name: orders\n model: ref("orders")\n',
|
|
'models/readme.md': '# ignored\n',
|
|
});
|
|
|
|
await adapter.fetch?.(
|
|
{
|
|
repoUrl: repo.repoUrl,
|
|
branch: 'main',
|
|
path: null,
|
|
authToken: null,
|
|
parsedTargetTables: {},
|
|
},
|
|
stagedDir,
|
|
{ connectionId: 'warehouse-1', sourceKey: 'metricflow' },
|
|
);
|
|
|
|
await expect(readFile(join(stagedDir, 'models/orders.yml'), 'utf-8')).resolves.toContain('semantic_models');
|
|
expect(await adapter.detect(stagedDir)).toBe(true);
|
|
});
|
|
|
|
it('persists parsed target tables for deterministic projection during fetch', async () => {
|
|
const repo = await makeRepo(tmpRoot, {
|
|
'dbt_project.yml': 'name: analytics\n',
|
|
'models/orders.yml': 'semantic_models:\n - name: orders\n model: ref("orders")\n',
|
|
});
|
|
|
|
await adapter.fetch?.(
|
|
{
|
|
repoUrl: repo.repoUrl,
|
|
branch: 'main',
|
|
path: null,
|
|
authToken: null,
|
|
parsedTargetTables: {
|
|
orders: {
|
|
ok: true,
|
|
catalog: null,
|
|
schema: 'analytics',
|
|
name: 'orders',
|
|
canonicalTable: 'analytics.orders',
|
|
},
|
|
},
|
|
},
|
|
stagedDir,
|
|
{ connectionId: 'warehouse-1', sourceKey: 'metricflow' },
|
|
);
|
|
|
|
await expect(readMetricflowProjectionConfig(stagedDir)).resolves.toMatchObject({
|
|
parsedTargetTables: {
|
|
orders: {
|
|
ok: true,
|
|
schema: 'analytics',
|
|
name: 'orders',
|
|
},
|
|
},
|
|
});
|
|
});
|
|
|
|
it('projects parsed MetricFlow semantic models in the integration worktree', async () => {
|
|
await writeMetricflowProjectionConfig(stagedDir, {
|
|
parsedTargetTables: {
|
|
orders: {
|
|
ok: true,
|
|
catalog: null,
|
|
schema: 'analytics',
|
|
name: 'orders',
|
|
canonicalTable: 'analytics.orders',
|
|
},
|
|
},
|
|
});
|
|
const scoped = {
|
|
getManifestEntry: vi.fn().mockResolvedValue(null),
|
|
isManifestBacked: vi.fn().mockResolvedValue(false),
|
|
loadAllSources: vi.fn().mockResolvedValue({ sources: [], loadErrors: [] }),
|
|
loadSource: vi.fn().mockResolvedValue(null),
|
|
writeSource: vi.fn().mockResolvedValue({ warnings: [] }),
|
|
};
|
|
const semanticLayerService = {
|
|
forWorktree: vi.fn().mockReturnValue(scoped),
|
|
getManifestEntry: vi.fn(),
|
|
isManifestBacked: vi.fn(),
|
|
loadAllSources: vi.fn(),
|
|
loadSource: vi.fn(),
|
|
writeSource: vi.fn(),
|
|
};
|
|
|
|
const result = await adapter.project?.({
|
|
connectionId: 'warehouse-1',
|
|
sourceKey: 'metricflow',
|
|
syncId: 'sync-1',
|
|
jobId: 'job-1',
|
|
runId: 'run-1',
|
|
stagedDir,
|
|
workdir: '/tmp/metricflow-integration',
|
|
parseArtifacts: metricflowParseResult(),
|
|
semanticLayerService: semanticLayerService as never,
|
|
});
|
|
|
|
expect(semanticLayerService.forWorktree).toHaveBeenCalledWith('/tmp/metricflow-integration');
|
|
expect(scoped.writeSource).toHaveBeenCalledWith(
|
|
'warehouse-1',
|
|
expect.objectContaining({ name: 'orders' }),
|
|
'dbt MetricFlow',
|
|
expect.any(String),
|
|
'dbt MetricFlow sync: create source orders',
|
|
{ skipValidation: true },
|
|
);
|
|
expect(result).toMatchObject({
|
|
warnings: ['parser warning'],
|
|
errors: [],
|
|
touchedSources: [{ connectionId: 'warehouse-1', sourceName: 'orders' }],
|
|
changedWikiPageKeys: [],
|
|
});
|
|
});
|
|
|
|
it('returns a projection error when parse artifacts are missing', async () => {
|
|
const result = await adapter.project?.({
|
|
connectionId: 'warehouse-1',
|
|
sourceKey: 'metricflow',
|
|
syncId: 'sync-1',
|
|
jobId: 'job-1',
|
|
runId: 'run-1',
|
|
stagedDir,
|
|
workdir: '/tmp/metricflow-integration',
|
|
parseArtifacts: undefined,
|
|
semanticLayerService: {} as never,
|
|
});
|
|
|
|
expect(result).toMatchObject({
|
|
warnings: [],
|
|
errors: ['MetricFlow deterministic projection requires parseArtifacts from chunk()'],
|
|
touchedSources: [],
|
|
changedWikiPageKeys: [],
|
|
});
|
|
});
|
|
});
|