mirror of
https://github.com/Kaelio/ktx.git
synced 2026-06-10 08:05:14 +02:00
* feat(cli): define full warehouse dialect contract
* test(cli): keep dialect edge tests focused
* fix(cli): stabilize dialect contract foundation
* refactor(connectors): own read-only query preparation
* refactor(connectors): resolve dialects through registry
* refactor(connectors): keep concrete dialect classes internal
* chore(workspace): enforce dialect import boundary
* refactor(cli): resolve relationship dialect at scan boundary
* refactor(cli): use dialect display parsing for entity details
* refactor(cli): use dialect display parsing for warehouse catalog
* refactor(cli): use dialect SQL in relationship workflows
* test(cli): verify solid dialect scan workflow closure
* test: split cli tests from source tree
* refactor(cli): standardize BigQuery scope listing
* feat(sqlite): implement connector scope listing
* test(connectors): cover required table listing
* feat(cli): add warehouse driver registry
* refactor(setup): route scope discovery through driver registry
* refactor(cli): route local query execution through driver registry
* refactor(historic-sql): route dialect support through driver registry
* refactor(cli): test warehouse connections through driver registry
* fix(cli): close driver registry type export gaps
* Improve setup daemon diagnostics
* refactor(setup): centralize rail-prefixed diagnostics + query-history fallback
Extract errorMessage, writePrefixedLines, and flushPrefixedBufferedCommandOutput
into clack.ts so the setup wizard, managed daemons, and embedding/agent steps
share one rail-formatted writer. setup-databases.ts also adds a
"disable query history and retry" option when the schema-context build fails
and query history is the likely culprit, surfaced via a new
failed-query-history-unavailable status.
* fix(cli): carry catalog through the picker so BigQuery/Snowflake/SQL Server scope filters match
The setup picker's KtxTableListEntry was a 2-level { schema, name }, so
qualifiedTableId always wrote db.name into enabled_tables. When BigQuery,
Snowflake, or SQL Server later ran fast ingest, their introspect step filtered
the scope set with scopedTableNames(scope, { catalog: projectId|database, db })
— catalog was non-null on the introspect side but null in the scope refs, so
every entry was rejected, the live-database adapter staged zero table files,
and detect() failed with 'Adapter "live-database" did not recognize fetched
source output'.
Align the picker boundary with the canonical 3-level KtxTableRef:
- Add catalog: string | null to KtxTableListEntry.
- BigQuery/Snowflake/SQL Server listTables populate catalog from the
resolved projectId / database; Postgres/MySQL/ClickHouse/SQLite set null.
- qualifiedTableId emits catalog.schema.name when catalog is non-null
(resolveEnabledTables already accepts the 3-part shape) and
schemasFromEnabledTables now goes through parseDottedTableEntry so it
recovers the schema correctly from both 2-part and 3-part entries.
- Export parseDottedTableEntry from enabled-tables.ts (@internal) for picker
reuse.
Update listTables expectations in all seven connector tests and the setup /
picker test fixtures. Add a picker regression test that covers the
catalog-bearing round-trip (save + refine).
* fix(cli): allow debug telemetry under opt-out env
268 lines
8.2 KiB
TypeScript
268 lines
8.2 KiB
TypeScript
import { describe, expect, it } from 'vitest';
|
|
import { buildMetricFlowGraph } from '../../../../../src/context/ingest/adapters/metricflow/graph.js';
|
|
import type { ParsedMetricFlowProject } from '../../../../../src/context/ingest/adapters/metricflow/parse.js';
|
|
|
|
function project(parts: Partial<ParsedMetricFlowProject>): ParsedMetricFlowProject {
|
|
return {
|
|
semanticModels: parts.semanticModels ?? [],
|
|
metrics: parts.metrics ?? [],
|
|
allPaths: parts.allPaths ?? [],
|
|
files: parts.files ?? [],
|
|
};
|
|
}
|
|
|
|
describe('buildMetricFlowGraph', () => {
|
|
it('puts each standalone semantic_model in its own component', () => {
|
|
const graph = buildMetricFlowGraph(
|
|
project({
|
|
semanticModels: [
|
|
{
|
|
path: 'models/a.yml',
|
|
name: 'a',
|
|
modelRef: 'a',
|
|
extendsFrom: [],
|
|
measureNames: ['m1'],
|
|
dimensionNames: [],
|
|
entityNames: [],
|
|
primaryEntities: [],
|
|
foreignEntities: [],
|
|
defaultTimeDimension: null,
|
|
},
|
|
{
|
|
path: 'models/b.yml',
|
|
name: 'b',
|
|
modelRef: 'b',
|
|
extendsFrom: [],
|
|
measureNames: ['m2'],
|
|
dimensionNames: [],
|
|
entityNames: [],
|
|
primaryEntities: [],
|
|
foreignEntities: [],
|
|
defaultTimeDimension: null,
|
|
},
|
|
],
|
|
allPaths: ['models/a.yml', 'models/b.yml'],
|
|
}),
|
|
);
|
|
expect(graph.components).toHaveLength(2);
|
|
const byPath = new Map(graph.components.flatMap((c) => c.paths.map((p) => [p, c.id])));
|
|
expect(byPath.get('models/a.yml')).not.toBe(byPath.get('models/b.yml'));
|
|
});
|
|
|
|
it('unions two files when one semantic_model extends another', () => {
|
|
const graph = buildMetricFlowGraph(
|
|
project({
|
|
semanticModels: [
|
|
{
|
|
path: 'models/orders.yml',
|
|
name: 'orders',
|
|
modelRef: 'orders',
|
|
extendsFrom: [],
|
|
measureNames: ['gross_amount'],
|
|
dimensionNames: [],
|
|
entityNames: [],
|
|
primaryEntities: [],
|
|
foreignEntities: [],
|
|
defaultTimeDimension: null,
|
|
},
|
|
{
|
|
path: 'models/orders_ext.yml',
|
|
name: 'orders_ext',
|
|
modelRef: 'orders_ext',
|
|
extendsFrom: ['orders'],
|
|
measureNames: ['refund_amount'],
|
|
dimensionNames: [],
|
|
entityNames: [],
|
|
primaryEntities: [],
|
|
foreignEntities: [],
|
|
defaultTimeDimension: null,
|
|
},
|
|
],
|
|
allPaths: ['models/orders.yml', 'models/orders_ext.yml'],
|
|
}),
|
|
);
|
|
expect(graph.components).toHaveLength(1);
|
|
expect(graph.components[0].paths.sort()).toEqual(['models/orders.yml', 'models/orders_ext.yml']);
|
|
});
|
|
|
|
it('unions a metric-only file with the semantic_model files whose measures it references', () => {
|
|
const graph = buildMetricFlowGraph(
|
|
project({
|
|
semanticModels: [
|
|
{
|
|
path: 'models/orders.yml',
|
|
name: 'orders',
|
|
modelRef: 'orders',
|
|
extendsFrom: [],
|
|
measureNames: ['gross_amount'],
|
|
dimensionNames: [],
|
|
entityNames: [],
|
|
primaryEntities: [],
|
|
foreignEntities: [],
|
|
defaultTimeDimension: null,
|
|
},
|
|
{
|
|
path: 'models/orders_ext.yml',
|
|
name: 'orders_ext',
|
|
modelRef: 'orders_ext',
|
|
extendsFrom: ['orders'],
|
|
measureNames: ['refund_amount'],
|
|
dimensionNames: [],
|
|
entityNames: [],
|
|
primaryEntities: [],
|
|
foreignEntities: [],
|
|
defaultTimeDimension: null,
|
|
},
|
|
],
|
|
metrics: [
|
|
{
|
|
path: 'metrics/orders_final.yml',
|
|
name: 'revenue',
|
|
type: 'derived',
|
|
measureRef: null,
|
|
dependsOn: ['gross_amount', 'refund_amount'],
|
|
},
|
|
],
|
|
allPaths: ['metrics/orders_final.yml', 'models/orders.yml', 'models/orders_ext.yml'],
|
|
}),
|
|
);
|
|
expect(graph.components).toHaveLength(1);
|
|
expect(graph.components[0].paths.sort()).toEqual([
|
|
'metrics/orders_final.yml',
|
|
'models/orders.yml',
|
|
'models/orders_ext.yml',
|
|
]);
|
|
});
|
|
|
|
it('leaves unrelated semantic_models in separate components (two disjoint groups)', () => {
|
|
const graph = buildMetricFlowGraph(
|
|
project({
|
|
semanticModels: [
|
|
{
|
|
path: 'models/sales/orders.yml',
|
|
name: 'orders',
|
|
modelRef: 'orders',
|
|
extendsFrom: [],
|
|
measureNames: ['order_count'],
|
|
dimensionNames: [],
|
|
entityNames: [],
|
|
primaryEntities: [],
|
|
foreignEntities: [],
|
|
defaultTimeDimension: null,
|
|
},
|
|
{
|
|
path: 'models/marketing/campaigns.yml',
|
|
name: 'campaigns',
|
|
modelRef: 'campaigns',
|
|
extendsFrom: [],
|
|
measureNames: ['spend'],
|
|
dimensionNames: [],
|
|
entityNames: [],
|
|
primaryEntities: [],
|
|
foreignEntities: [],
|
|
defaultTimeDimension: null,
|
|
},
|
|
],
|
|
allPaths: ['models/marketing/campaigns.yml', 'models/sales/orders.yml'],
|
|
}),
|
|
);
|
|
expect(graph.components).toHaveLength(2);
|
|
});
|
|
|
|
it('returns components ordered lexicographically by their first-name-member', () => {
|
|
const graph = buildMetricFlowGraph(
|
|
project({
|
|
semanticModels: [
|
|
{
|
|
path: 'models/z.yml',
|
|
name: 'z_model',
|
|
modelRef: 'z',
|
|
extendsFrom: [],
|
|
measureNames: ['m'],
|
|
dimensionNames: [],
|
|
entityNames: [],
|
|
primaryEntities: [],
|
|
foreignEntities: [],
|
|
defaultTimeDimension: null,
|
|
},
|
|
{
|
|
path: 'models/a.yml',
|
|
name: 'a_model',
|
|
modelRef: 'a',
|
|
extendsFrom: [],
|
|
measureNames: ['m'],
|
|
dimensionNames: [],
|
|
entityNames: [],
|
|
primaryEntities: [],
|
|
foreignEntities: [],
|
|
defaultTimeDimension: null,
|
|
},
|
|
],
|
|
allPaths: ['models/a.yml', 'models/z.yml'],
|
|
}),
|
|
);
|
|
expect(graph.components.map((c) => c.leadName)).toEqual(['a_model', 'z_model']);
|
|
});
|
|
|
|
it('metric that references an unknown measure still anchors its own file as a singleton', () => {
|
|
const graph = buildMetricFlowGraph(
|
|
project({
|
|
metrics: [
|
|
{ path: 'metrics/dangling.yml', name: 'dangling', type: 'simple', measureRef: 'nowhere', dependsOn: [] },
|
|
],
|
|
allPaths: ['metrics/dangling.yml'],
|
|
}),
|
|
);
|
|
expect(graph.components).toHaveLength(1);
|
|
expect(graph.components[0].paths).toEqual(['metrics/dangling.yml']);
|
|
expect(graph.components[0].leadName).toBe('dangling');
|
|
});
|
|
|
|
it('transitive extends forms one component across 3 files', () => {
|
|
const graph = buildMetricFlowGraph(
|
|
project({
|
|
semanticModels: [
|
|
{
|
|
path: 'a.yml',
|
|
name: 'a',
|
|
modelRef: 'a',
|
|
extendsFrom: [],
|
|
measureNames: [],
|
|
dimensionNames: [],
|
|
entityNames: [],
|
|
primaryEntities: [],
|
|
foreignEntities: [],
|
|
defaultTimeDimension: null,
|
|
},
|
|
{
|
|
path: 'b.yml',
|
|
name: 'b',
|
|
modelRef: 'b',
|
|
extendsFrom: ['a'],
|
|
measureNames: [],
|
|
dimensionNames: [],
|
|
entityNames: [],
|
|
primaryEntities: [],
|
|
foreignEntities: [],
|
|
defaultTimeDimension: null,
|
|
},
|
|
{
|
|
path: 'c.yml',
|
|
name: 'c',
|
|
modelRef: 'c',
|
|
extendsFrom: ['b'],
|
|
measureNames: [],
|
|
dimensionNames: [],
|
|
entityNames: [],
|
|
primaryEntities: [],
|
|
foreignEntities: [],
|
|
defaultTimeDimension: null,
|
|
},
|
|
],
|
|
allPaths: ['a.yml', 'b.yml', 'c.yml'],
|
|
}),
|
|
);
|
|
expect(graph.components).toHaveLength(1);
|
|
expect(graph.components[0].paths.sort()).toEqual(['a.yml', 'b.yml', 'c.yml']);
|
|
});
|
|
});
|