mirror of
https://github.com/Kaelio/ktx.git
synced 2026-06-13 08:15:14 +02:00
* feat(cli): define full warehouse dialect contract
* test(cli): keep dialect edge tests focused
* fix(cli): stabilize dialect contract foundation
* refactor(connectors): own read-only query preparation
* refactor(connectors): resolve dialects through registry
* refactor(connectors): keep concrete dialect classes internal
* chore(workspace): enforce dialect import boundary
* refactor(cli): resolve relationship dialect at scan boundary
* refactor(cli): use dialect display parsing for entity details
* refactor(cli): use dialect display parsing for warehouse catalog
* refactor(cli): use dialect SQL in relationship workflows
* test(cli): verify solid dialect scan workflow closure
* test: split cli tests from source tree
* refactor(cli): standardize BigQuery scope listing
* feat(sqlite): implement connector scope listing
* test(connectors): cover required table listing
* feat(cli): add warehouse driver registry
* refactor(setup): route scope discovery through driver registry
* refactor(cli): route local query execution through driver registry
* refactor(historic-sql): route dialect support through driver registry
* refactor(cli): test warehouse connections through driver registry
* fix(cli): close driver registry type export gaps
* Improve setup daemon diagnostics
* refactor(setup): centralize rail-prefixed diagnostics + query-history fallback
Extract errorMessage, writePrefixedLines, and flushPrefixedBufferedCommandOutput
into clack.ts so the setup wizard, managed daemons, and embedding/agent steps
share one rail-formatted writer. setup-databases.ts also adds a
"disable query history and retry" option when the schema-context build fails
and query history is the likely culprit, surfaced via a new
failed-query-history-unavailable status.
* fix(cli): carry catalog through the picker so BigQuery/Snowflake/SQL Server scope filters match
The setup picker's KtxTableListEntry was a 2-level { schema, name }, so
qualifiedTableId always wrote db.name into enabled_tables. When BigQuery,
Snowflake, or SQL Server later ran fast ingest, their introspect step filtered
the scope set with scopedTableNames(scope, { catalog: projectId|database, db })
— catalog was non-null on the introspect side but null in the scope refs, so
every entry was rejected, the live-database adapter staged zero table files,
and detect() failed with 'Adapter "live-database" did not recognize fetched
source output'.
Align the picker boundary with the canonical 3-level KtxTableRef:
- Add catalog: string | null to KtxTableListEntry.
- BigQuery/Snowflake/SQL Server listTables populate catalog from the
resolved projectId / database; Postgres/MySQL/ClickHouse/SQLite set null.
- qualifiedTableId emits catalog.schema.name when catalog is non-null
(resolveEnabledTables already accepts the 3-part shape) and
schemasFromEnabledTables now goes through parseDottedTableEntry so it
recovers the schema correctly from both 2-part and 3-part entries.
- Export parseDottedTableEntry from enabled-tables.ts (@internal) for picker
reuse.
Update listTables expectations in all seven connector tests and the setup /
picker test fixtures. Add a picker regression test that covers the
catalog-bearing round-trip (save + refine).
* fix(cli): allow debug telemetry under opt-out env
110 lines
3.7 KiB
TypeScript
110 lines
3.7 KiB
TypeScript
import { access, mkdir, mkdtemp, readFile, rm, writeFile } from 'node:fs/promises';
|
|
import { tmpdir } from 'node:os';
|
|
import { join } from 'node:path';
|
|
import { afterEach, beforeEach, describe, expect, it } from 'vitest';
|
|
import { makeLocalGitRepo } from '../../../test/make-local-git-repo.js';
|
|
import { fetchMetricflowRepo } from '../../../../../src/context/ingest/adapters/metricflow/fetch.js';
|
|
|
|
async function exists(path: string): Promise<boolean> {
|
|
try {
|
|
await access(path);
|
|
return true;
|
|
} catch {
|
|
return false;
|
|
}
|
|
}
|
|
|
|
async function makeRepo(tmpRoot: string, files: Record<string, string>) {
|
|
const fixtureDir = join(tmpRoot, 'fixture-src');
|
|
for (const [path, content] of Object.entries(files)) {
|
|
const dest = join(fixtureDir, path);
|
|
await mkdir(join(dest, '..'), { recursive: true });
|
|
await writeFile(dest, content, 'utf-8');
|
|
}
|
|
return makeLocalGitRepo(fixtureDir, join(tmpRoot, 'origin'));
|
|
}
|
|
|
|
describe('fetchMetricflowRepo', () => {
|
|
let tmpRoot: string;
|
|
|
|
beforeEach(async () => {
|
|
tmpRoot = await mkdtemp(join(tmpdir(), 'metricflow-fetch-'));
|
|
});
|
|
|
|
afterEach(async () => {
|
|
await rm(tmpRoot, { recursive: true, force: true });
|
|
});
|
|
|
|
it('clones a dbt repo and stages only YAML files', async () => {
|
|
const repo = await makeRepo(tmpRoot, {
|
|
'dbt_project.yml': 'name: analytics\n',
|
|
'models/orders.yml': 'semantic_models:\n - name: orders\n model: ref("orders")\n',
|
|
'models/readme.md': '# not staged\n',
|
|
'macros/util.sql': 'select 1\n',
|
|
});
|
|
|
|
const result = await fetchMetricflowRepo({
|
|
config: {
|
|
repoUrl: repo.repoUrl,
|
|
branch: 'main',
|
|
path: null,
|
|
authToken: null,
|
|
parsedTargetTables: {},
|
|
},
|
|
cacheDir: join(tmpRoot, 'cache'),
|
|
stagedDir: join(tmpRoot, 'stage'),
|
|
});
|
|
|
|
expect(result.filesCopied).toBe(2);
|
|
expect(result.commitHash).toMatch(/^[0-9a-f]{40}$/);
|
|
await expect(readFile(join(tmpRoot, 'stage/dbt_project.yml'), 'utf-8')).resolves.toContain('analytics');
|
|
await expect(readFile(join(tmpRoot, 'stage/models/orders.yml'), 'utf-8')).resolves.toContain('semantic_models');
|
|
expect(await exists(join(tmpRoot, 'stage/models/readme.md'))).toBe(false);
|
|
expect(await exists(join(tmpRoot, 'stage/macros/util.sql'))).toBe(false);
|
|
});
|
|
|
|
it('honors a configured repo subdirectory', async () => {
|
|
const repo = await makeRepo(tmpRoot, {
|
|
'warehouse/dbt_project.yml': 'name: warehouse\n',
|
|
'warehouse/models/orders.yaml': 'semantic_models:\n - name: orders\n model: ref("orders")\n',
|
|
'outside/ignored.yml': 'semantic_models:\n - name: ignored\n model: ref("ignored")\n',
|
|
});
|
|
|
|
const result = await fetchMetricflowRepo({
|
|
config: {
|
|
repoUrl: repo.repoUrl,
|
|
branch: 'main',
|
|
path: 'warehouse',
|
|
authToken: null,
|
|
parsedTargetTables: {},
|
|
},
|
|
cacheDir: join(tmpRoot, 'cache'),
|
|
stagedDir: join(tmpRoot, 'stage'),
|
|
});
|
|
|
|
expect(result.filesCopied).toBe(2);
|
|
await expect(readFile(join(tmpRoot, 'stage/models/orders.yaml'), 'utf-8')).resolves.toContain('orders');
|
|
expect(await exists(join(tmpRoot, 'stage/outside/ignored.yml'))).toBe(false);
|
|
});
|
|
|
|
it('returns zero files when the configured subdirectory is absent', async () => {
|
|
const repo = await makeRepo(tmpRoot, {
|
|
'dbt_project.yml': 'name: analytics\n',
|
|
});
|
|
await mkdir(join(tmpRoot, 'stage'), { recursive: true });
|
|
|
|
const result = await fetchMetricflowRepo({
|
|
config: {
|
|
repoUrl: repo.repoUrl,
|
|
branch: 'main',
|
|
path: 'missing',
|
|
authToken: null,
|
|
parsedTargetTables: {},
|
|
},
|
|
cacheDir: join(tmpRoot, 'cache'),
|
|
stagedDir: join(tmpRoot, 'stage'),
|
|
});
|
|
|
|
expect(result.filesCopied).toBe(0);
|
|
});
|
|
});
|